- 18 Mar, 2020 40 commits
-
-
John Lee authored
Example of what it might look like on Linux: https://imgur.com/a/j0VmU6q Change-Id: I044b1fcb8154e15211f89cee7d1b8b8d1725a604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106761 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751523}
-
Yuwei Huang authored
Previously we made FtlMessageReceptionChannel run the stream closed callback with a CANCELLED status when StopReceivingMessages is called, and FtlSignalStrategy would special-case CANCELLED and do nothing in that case. This is potentially related to the zombie host issue, where the FTL server might potentially return a CANCELLED status. Reporting CANCELLED for user triggered cancellation doesn't do much and potentially causes amiguation, so this CL just removes this logic and adds a log to see if the server can indeed respond with a CANCELLED status. Bug: 1062759 Change-Id: I9d3069e9f3dda49052015bb5ab67fa060a4516bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108875 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#751522}
-
Demetrios Papadopoulos authored
Unit tests will be migrated in later CLs, as this element is tested from people_page.html which is not quite ready yet. Bug: 1026426 Change-Id: Iec7765dcdbae46a4e3ce1080d4526e5afbd88a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106954Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#751521}
-
Peter Kotwicz authored
This CL moves shouldStayInWebapp() logic from ExternalNavigationDelegateImpl to CustomTabDelegateFactory. This CL does not modify behaviour as WebApkActivity/WebappActivity uses CustomTabDelegateFactory BUG=054718 TEST=CustomTabExternalNavigationTest.testShouldDisableExternalIntentRequestsForUrl Change-Id: I3766f09e1915f065039e4dffd4ee589c2352aecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103129Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751520}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e14702b1..96241ef6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibe91aeb9d3c0c573d4914d7633885f6f58ed8bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105798Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751519}
-
Adam Goode authored
In crbug.com/758048, zeroconf-discovered printers were changed to use a more friendly name, but used the make and model instead of the printer's display name. In Privet, the display name of the printer is stored in the "ty" key of the TXT record: https://developers.google.com/cloud-print/docs/privet#2.2.2.-ty But in zeroconf, the display name should be derived from the mDNS name: See https://developer.apple.com/bonjour/printing-specification/bonjourprinting-1.2.1.pdf section 7.1. "ty" describes the make and model of the printer, see section 9.2.6. With this change, zeroconf printers will have the recommended name, like in Privet. Bug: 895502 Change-Id: I6e088927c68c626c52056cdc04540684e95f2878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108827Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Adam Goode <agoode@chromium.org> Cr-Commit-Position: refs/heads/master@{#751518}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/dc0f1319307e..bc98fbeec99b git log dc0f1319307e..bc98fbeec99b --date=short --first-parent --format='%ad %ae %s' 2020-03-18 amaiorano@google.com Subzero: fix external function calls on x86-32 Created with: gclient setdep -r src/third_party/swiftshader@bc98fbeec99b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I102b03487217d91eddd5940eb743cfd707ece90e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108664Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751517}
-
Sunggook Chue authored
The changes are - gIRA register WebContentOberser for render frame host deletion. - In frame host deletion callback, it nullify member variable of frame host pointer. - Render frame host pointer check is made before referencing it. Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1062091 Change-Id: I7bc261a292b63c8e60865916315b3dea59130c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107618 Commit-Queue: Sunggook Chue <sunggch@microsoft.com> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#751516}
-
Rakina Zata Amni authored
With ProactivelySwapBrowsingInstance, we will swap BrowsingInstances on most cross-site navigations, which means there will be more cross-process navigations on Android. This CL tries to reduce that by trying to reuse the previous page's renderer process for the new page when we do a proactive BrowsingInstance swap, if possible. Note that the CL won't change cases where we are already forcing a BrowsingInstance + process swap. Browser-initiated cross-site navigations will cause BrowsingInstance + process swap no matter what, and they will keep doing so even with this CL. Some renderer-initiated cross-site navigations, however, do not trigger a BrowsingInstance swap without us proactively swapping, so it is OK to reuse the process in their case (because we would've done so anyways if we don't do a proactive BrowsingInstance swap). See https://docs.google.com/document/d/1b-uMmwzTlwGfpn8pjd59iA57RnBHVx4IOarWnxYYxQk/edit?usp=sharing for more context (google-only) Bug: 977562 Change-Id: I57d725aa1435de0ee54788de4bfe627161400725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043521 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#751515}
-
Xianzhu Wang authored
It was needed when some style affecting visual effect of the whole DOM subtree changed before we had raster invalidation on paint property changes. The following existing tests ensure correct invalidation on change of the css properties that previously caused subtree paint invalidation: paint/invalidation/mix-blend-mode-separate-stacking-context.html css3/blending/svg-isolation-remove-isolation.html css3/blending/svg-isolation-add-isolation.html Added new tests for -webkit-mask-image and -webkit-mask-box-image. Change-Id: Ib5fab2d553b9b52588d55d14559293df8cab182f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101304 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#751514}
-
Jerome Jiang authored
https://aomedia.googlesource.com/aom.git/+log/f83d681765cd..c25910f6d213 $ git log f83d68176..c25910f6d --date=short --no-merges --format='%ad %ae %s' 2020-03-18 danilchap Remove extra semi columns 2020-03-15 remya.prakasan Extend sf prune_inter_modes_based_on_tpl for 3 & 4 2020-03-17 kyslov AV1 RT: Dynamically allocate space for 64x64 blocks 2020-03-13 remya.prakasan Enable the sf prune_inter_modes_based_on_tpl 2020-03-12 nithya.vs Correct skip rdy computation for txfm_rd_gate_level sf 2020-03-14 kyslov AV1 RT: Limit RT RDO TX types to DCT only 2020-03-10 mufaddal.chakera Correct frames_to_key in single_pass for last GOP 2020-03-13 aasaipriya.c Fix key frames forced by application. 2020-02-26 aasaipriya.c Enable single pass lap for forward key frames. 2020-02-25 aasaipriya.c Fix forward keyframes when kf_min_dist = kf_max_dist. (...) 2020-02-29 urvang For fixed offsets, use QP offset 76% for keyframe 2020-02-28 jzern gf_pyr_height_test: use Values() w/explicit values 2020-02-28 urvang Respect --gf_max_pyr_height. 2020-01-27 urvang Command-line option for minimum pyramid height. 2020-01-24 urvang 2-pass: Disable ARF for fixed small intervals. 2020-02-28 marpan rtc: Code cleanup for interpol_search in nonrd 2020-02-27 huisu Use mi_row and mi_col stored in xd when possible 2020-02-26 huisu Pre-calculate and store smooth interintra masks 2020-02-28 jingning Remove unused FRAME_CONTEXT_INDEX typedef 2020-02-26 sanampudi.venkatarao Prune inter modes when best mode is skippable Created with: roll-dep src/third_party/libaom/source/libaom R=jzern@google.com BUG=1055917 Change-Id: I514ba8c3f0516cb55778de66f212c9c0d4409bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108526Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#751513}
-
David Black authored
Previously the AssistantAlarmTimerController/Model only handled fired timers. Due to new UX requirements, we are going to need to handle scheduled and paused timers as well. This CL makes the necessary changes to the AssistantAlarmTimerController and model to support scheduled, paused, and firing timers. Note that though this CL contains sufficient code to support them, it stops short of actually handling them as this will be done in another set of CLs. That being the case, this CL does not have a functional impact on the existing experience. Also note that this CL removes some "alarm" related nomenclature. Alarms may/may not be implemented in the near future and (if we do) the code will be friendlier to treat alarms and timers as distinct entities. Bug: b:149570650 Change-Id: I6025471b80def7610625dcfa3c66ce17ba7e2817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095939Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#751512}
-
Pavel Yatsuk authored
InfoBar#getNativeInfoBarPtr shouldn't be exposed in general. In this case it was only used to get to top infobar's identifier. Replacing the call with more targeted method. BUG=1056346 R=mdjones@chromium.org Change-Id: Ia2115a44a4badf5eec93ed858a49fa9bc7688c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108918Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#751511}
-
Joe Mason authored
chrome-safebrowsing-alerts. Extend SoftwareReporter.* histograms that expire in M82. R=drubery Bug: 1053148 Change-Id: Id31b95bbdacc4df8e6fc50d52aadcfdf58bb0dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071051 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#751510}
-
DongJun Kim authored
This Cl updates the calls to DeprecatedEqualIgnoringCase to use EqualIgnoringASCIICase as needed. Bug: 627682 Signed-off-by:
DongJun Kim <djmix.kim@samsung.com> Change-Id: Id288a4886a9e5c13133d6d29015431fac55386e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105265Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751509}
-
Scott Violet authored
Loading WebView loads from disk. BUG=1062554 TEST=test only change Change-Id: I156a8df429cce7b3f88827ed432ce1d3581c98ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109132Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751508}
-
Ted Choc authored
This temporarily leaves in the appcompat library entries in case the android X were to be reverted. We should be able to remove those entries in the not so distant future though. BUG= Change-Id: I4233c6396497778789ecb38774d07a551c82cfeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108963Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#751507}
-
Theresa Wellington authored
The KitKat bot on the CQ is currently not running chrome_public_test_apk, which makes generating new, reliable goldens more challenging. Remove the N5 KitKat bot from the list of models for now. BUG=1060245 Change-Id: I3cd75ff0ca14baa8e68034d803c904733c91cc0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108912 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#751506}
-
George Burgess IV authored
This was originally added for linux-chromeos builds. Now that we have is_chromeos_device here, it's redundant, and it unintentionally disables ThinLTO/CFI for ARC pieces of non-linux CrOS builds. Bug: 1062713, 1050199 Change-Id: I27022ed72597a90ae7d2bb385729550fa8d772e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108822Reviewed-by:
Bob Haarman <inglorion@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#751505}
-
Jun Mukai authored
ScreenRotationTest test cases have been disabled due to flakiness, but they are resolved by: * not running on sanitizer builds (crrev.com/r/749747) * fix of WindowAnimationWaiter (crrev.com/r/750605) As I tested locally, they pass all of 20 runs on debug build, so I think this isn't flaky anymore. Bug: 1017206, 1060667, 1057868 Test: interactive_ui_tests --gtest_repeat=20 Change-Id: Ia8128e04d49833d8d06d7430bd23d78348fc0823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109023Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#751504}
-
Sam Bowen authored
Bug: 1056762 Change-Id: I81b58b6408712b8eb0293448a20b1f9f7164a629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095443 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#751503}
-
Etienne Pierre-doray authored
Note: This CL enables feature BlinkHeapConcurrentMarking to get the desired behavior. However, we should land enabling BlinkHeapConcurrentMarking on its own first. active_markers + GlobalPoolSize() is used to determine the desired number of workers. NotifyConcurrencyIncrease() is called periodically from ConcurrentMarkingStep() if GlobalPoolSize() > 0, to make sure enough workers are scheduled. CancelableTaskScheduler is no longer used and deleted in this CL. Benchmark v8.browsing_desktop on win-10-perf browse:news:cnn:2018: blink-gc-atomic-pause-mark-transitive-closure: 13% improvement blink-gc-atomic-pause-sweep-and-compact: 5% improvement blink-gc-complete-sweep: 34% improvement blink-gc-total: 2% improvement https://pinpoint-dot-chromeperf.appspot.com/job/136a60ce620000 Bug: 1046343 Change-Id: Ie2957abf200037ccacc017b1e38dc41f47811ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029609 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#751502}
-
Mikel Astiz authored
Change-Id: Ic9e7222d268da4c7eb1b402f66550f290092371c Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108505 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#751501}
-
Mike Wittman authored
Passes |frame| by const reference rather than const pointer, to be consistent with style. Bug: 1035855 Change-Id: I783441fcfcbca46147bffc428a838a3920856f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091650 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#751500}
-
Xiaoqian Dai authored
Bug: 1061144 Change-Id: I9f84dd6a381fb32624826f58a24e6aca8a2059a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108089 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#751499}
-
Katie D authored
Reader mode should have the (i) icon for security indicator along with the text "reader mode". When clicked, it should explain that you are viewing the source of a webpage. Bug: 840191 Change-Id: I431a50447ea7efc6f854ac944f8db131d8241414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072471 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#751498}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc29b0ad4658..560e87aa8193 git log fc29b0ad4658..560e87aa8193 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 danilchap@webrtc.org Reenable libaom decoder by default Created with: gclient setdep -r src/third_party/webrtc@560e87aa8193 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8c419dc82756c5065e0ebe46e540eaab3ff4ce63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751497}
-
Nancy Wang authored
This reverts commit d1337c0f. Reason for revert: <INSERT REASONING HERE> It looks like this CL break build https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/11952 Original change's description: > Revert "Propagation of main frame document intersections through page load metrics." > > This reverts commit e5c21760. > > Reason for revert: Crash on Chrome OS with LTO enabled (crbug/1062006). > > Original change's description: > > Propagation of main frame document intersections through page load metrics. > > > > This CL leverages the existing page load metrics communication to > > pass main frame document intersections from render frame observers to > > page load metrics observers. Done via adding frame intersection to the > > PageLoadMetadata struct (renamed to FrameMetadata) as it stores > > frame-level intersection information. > > > > There is existing intersection state being passed from RemoteFrameView > > to LocalFrameView's in the cross process connector but this is only sent > > for cross process frames. The main frame document intersections here > > are sent for all frames. > > > > This CL exposes each frame's main frame intersection rect and respective > > render frame host to a page load metrics observer callback. Future work > > will leverage this to track the intersections and calculate page ad > > density in the ads page load metrics observer. > > > > BUG=993453 > > > > Change-Id: I5005fcd66c923212b7e73fdc6b46fa484cfb5f13 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982622 > > Commit-Queue: Justin Miron <justinmiron@google.com> > > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > > Reviewed-by: Scott Violet <sky@chromium.org> > > Reviewed-by: John Delaney <johnidel@chromium.org> > > Reviewed-by: Stefan Zager <szager@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#750146} > > TBR=sky@chromium.org,dcheng@chromium.org,szager@chromium.org,bmcquade@chromium.org,johnidel@chromium.org,justinmiron@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 993453 > Change-Id: Id0340c52a4551a4a2a140e1b10e1f635004d5cbd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108622 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Reviewed-by: John Delaney <johnidel@chromium.org> > Commit-Queue: Justin Miron <justinmiron@google.com> > Cr-Commit-Position: refs/heads/master@{#751494} TBR=stevenjb@chromium.org,sky@chromium.org,dcheng@chromium.org,szager@chromium.org,bmcquade@chromium.org,johnidel@chromium.org,justinmiron@google.com Change-Id: I1ce5b10a4c5889eabc9ffdb96a4d55c9e387ab75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 993453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108407Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#751496}
-
Lan Wei authored
ChromeDriverTest.testActionsMultiTouchPoint fails on Pixel 3 because there is a rounding error, ChromeDriver log file shows that the touch action was dispatched to coordinate (60,60): [03-16-2020 15:03:49.094928][DEBUG]: DevTools WebSocket Command: Input.dispatchTouchEvent (id=29) 0 { "timestamp": -446703130, "touchPoints": [ { "force": 1.0, "id": 1, "radiusX": 1.0, "radiusY": 1.0, "rotationAngle": 0.0, "x": 60, "y": 60 } ], "type": "touchEnd" } But the resulting event had a slightly different coordinate: [03-16-2020 15:03:50.145445][DEBUG]: DevTools WebSocket Response: Runtime.evaluate (id=32) 0 { "result": { "type": "object", "value": { "status": 0, "value": [ { "type": "touchstart", "x": 50, "y": 50 }, { "type": "touchstart", "x": 60.00000762939453, "y": 60.00000762939453 }, { "type": "touchend" }, { "type": "touchend" } ] } } } We should use assertAlmostEqual instead of assertEqual to just compare the integer part. The decimal part is because the coordinates transformation and conversion through the code pipeline. Bug chromedriver:3397 Change-Id: I3820338e94a9bcff6b5f4d4d180af01569915bfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108903Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#751495}
-
Justin Miron authored
This reverts commit e5c21760. Reason for revert: Crash on Chrome OS with LTO enabled (crbug/1062006). Original change's description: > Propagation of main frame document intersections through page load metrics. > > This CL leverages the existing page load metrics communication to > pass main frame document intersections from render frame observers to > page load metrics observers. Done via adding frame intersection to the > PageLoadMetadata struct (renamed to FrameMetadata) as it stores > frame-level intersection information. > > There is existing intersection state being passed from RemoteFrameView > to LocalFrameView's in the cross process connector but this is only sent > for cross process frames. The main frame document intersections here > are sent for all frames. > > This CL exposes each frame's main frame intersection rect and respective > render frame host to a page load metrics observer callback. Future work > will leverage this to track the intersections and calculate page ad > density in the ads page load metrics observer. > > BUG=993453 > > Change-Id: I5005fcd66c923212b7e73fdc6b46fa484cfb5f13 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982622 > Commit-Queue: Justin Miron <justinmiron@google.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: John Delaney <johnidel@chromium.org> > Reviewed-by: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#750146} TBR=sky@chromium.org,dcheng@chromium.org,szager@chromium.org,bmcquade@chromium.org,johnidel@chromium.org,justinmiron@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 993453 Change-Id: Id0340c52a4551a4a2a140e1b10e1f635004d5cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108622Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Commit-Queue: Justin Miron <justinmiron@google.com> Cr-Commit-Position: refs/heads/master@{#751494}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d7e0131c7edc..d3b92b910ce0 git log d7e0131c7edc..d3b92b910ce0 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 kjlubick@google.com [canvaskit] Add tests for gradients 2020-03-18 reed@google.com hide bitmap virtuals 2020-03-18 kjlubick@google.com [canvaskit] Update to 0.14.0 2020-03-18 kjlubick@google.com [canvaskit] Add tests for patheffects 2020-03-18 kjlubick@google.com [canvaskit] Make codec inclusion configurable 2020-03-18 jvanverth@google.com Reland "Set up eGPU/discrete support for MacOS." 2020-03-18 brianosman@google.com Add a custom GP for GrDrawVerticesOp 2020-03-18 bsalomon@google.com Revert "Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots"" 2020-03-18 reed@google.com Revert "remove uncalled virtuals" 2020-03-18 robertphillips@google.com Make GrOp::onPrePrepare be pure virtual 2020-03-18 fmalita@chromium.org [skottie] VectorValue specialization 2020-03-18 kjlubick@google.com Add fiddle example for MakeLinear 2020-03-18 bsalomon@google.com Add SkBudgeted parameter to SkImage::makeTextureImage(). 2020-03-18 brianosman@google.com Remove GrGLSLUtil 2020-03-18 jvanverth@google.com Revert "Reland "Clear out atlases if they haven't been used in a while."" 2020-03-18 reed@google.com remove uncalled virtuals 2020-03-18 borenet@google.com [infra] Run recipe and python unittests unbuffered 2020-03-18 bsalomon@google.com Revert "Don't build GL on Metal, Vulkan, Dawn, Direct3D bots" 2020-03-18 robertphillips@google.com Update AAHairlineOp to surface its programInfos at record time 2020-03-18 bsalomon@google.com Don't build GL on Metal, Vulkan, Dawn, Direct3D bots 2020-03-18 borenet@google.com [infra] gen_task: follow-ups from http://review.skia.org/275076 Created with: gclient setdep -r src/third_party/skia@d3b92b910ce0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1058905 Tbr: egdaniel@google.com Change-Id: Ie039b2a3a091483b11a1e45c00b727daf7b995ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108886Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751493}
-
Andrey Kosyakov authored
- introduce DeviceEmulator, make it navigation-associated - move WebDeviceEmulationParams to blink/public/common/devtools - use base::Optional<WebDeviceEmulationParams> to represent emulation enabled/disabled state through most interfaces. Change-Id: Ic743a1af02019610149e1c4a765696c9d8711e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092938 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#751492}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/1ccecb74b36f..362becca1ff2 git log 1ccecb74b36f..362becca1ff2 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 rharrison@google.com Add support for storage texture format reflection (#1005) Created with: gclient setdep -r src/third_party/shaderc/src@362becca1ff2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: I1132f6c81433abc3e83668b76df66130f023ca90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108887Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751491}
-
Nicolás Peña Moreno authored
Bug: 1062667 Change-Id: I739add59d11c3017390700069c8a586605f29178 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108913 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Auto-Submit: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#751490}
-
John Lee authored
Bug: 973674 Change-Id: I9827d8849edf8b6ae8ac42ed6547e81af9f5b17f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107793Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#751489}
-
Xiaocheng Hu authored
For all callers of FontBuilder::CreateFont() and CreateFontForDocument() the value of |font_selector| is always equal to the FontSelector of the current document. Hence, this patch removes it. It also eases the elimination of the deprecated function Font::Update(). Bug: 1049295 Change-Id: I1e5521c00191a9af0f670cc985c1de198734bece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107696Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#751488}
-
Tricia Crichton authored
Remove creation of new ChromeDriver when testing Cookie retrieval for frames to enable test to run on Android. Bug: chromedriver:3396 Change-Id: If611001e2e72af95d96529872962703157563d7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108904Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#751487}
-
John Pham authored
Defining focus: the parent view's active descendant Problem: An active virtual view reports itself as having keyboard focus even if keyboard focus is somewhere else. This leads to more than 1 virtual view reporting that they have keyboard focus when only 1 virtual view should be. Bug: 811277 Change-Id: I8985129ad4eafffa658159b1b73993cff2f01b96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095466 Commit-Queue: John Pham <johnp@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#751486}
-
Ben Pastene authored
Partial revert of crrev.com/c/2097516, which accidentally dropped 'is_chrome_branded' from the bots. Will reland once crrev.com/c/2107709 lands. Bug: 937821 Change-Id: Ia7d84b99aac9b04deb2861f06a34643eba8cc05d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108826Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#751485}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ebf739be7bab..fc29b0ad4658 git log ebf739be7bab..fc29b0ad4658 --date=short --first-parent --format='%ad %ae %s' 2020-03-18 hbos@webrtc.org [Stats] Include RTX retransmissions in the VideoSenderInfo. Created with: gclient setdep -r src/third_party/webrtc@fc29b0ad4658 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4aa3144226c2fcbf42820c7fa4782d77a7aed825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108884Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#751484}
-