GitLab

Bug: 758632
Change-Id: I33c62a8c7ce7d8afd47021dc9833bf739dd26696
Reviewed-on: https://chromium-review.googlesource.com/956089Reviewed-by: Ashley Enstad <ashleymarie@chromium.org>
Commit-Queue: Ashley Enstad <ashleymarie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542056}

There's a delay in making local state available in //ash, so we
previously created |OnReadyToSetWallpaper| to notify //chrome when
it's ready. However, we do not have the mechanism to prevent early
ShowUserWallpaper requests. The correct behavior should be to directly
ignore it, otherwise it automatically falls back to a default wallpaper
as the bug shows.

This problem only exists for browser restart, but not login. Because
the ShowUserWallpaper requested from login is very late due to web-ui
initialization.

Bug: 820196
Change-Id: Ie05235b5966b14ea80a7e83aca98f8b7147cc9b7
Reviewed-on: https://chromium-review.googlesource.com/956350Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542055}

This changes adds a new target to the mojom template which depends on
the parse target and is a dependency for all generation targets. A new
action has been added to the mojom_bindings_generator.py script that
compares the list of sources for all dependencies of a given mojom file
target to the list of imports in this file. If missing dependencies are
found, they are printed and the script exits with an error.
This changes also fixes missing dependencies and not fully-qualified
import statements.

Dependency check has been disabled for //content/common:mojo_bindings
and //content/public/common/interfaces since it caused multiple
definitions linker errors on Windows (they have both direct and indirect
dependencies on specific targets).

Bug: 753219
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I64613ad14af41f1fc2a77b81ac76507e26f9dfcc
Reviewed-on: https://chromium-review.googlesource.com/947384
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542054}

Bug:805552
Change-Id: Ifd631d785f309d9f46b401daaec44d0cf89a8631

Pinpoint tryjobs:

Android: https://pinpoint-dot-chromeperf.appspot.com/job/14c63ffa440000
Linux: https://pinpoint-dot-chromeperf.appspot.com/job/10787612440000
Mac: https://pinpoint-dot-chromeperf.appspot.com/job/1499113a440000
Win: https://pinpoint-dot-chromeperf.appspot.com/job/1381251a440000
Change-Id: Ifd631d785f309d9f46b401daaec44d0cf89a8631
Reviewed-on: https://chromium-review.googlesource.com/956203
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542053}

This Cl introduces "ClipboardCommands.h", move the declarations of some
static functions related to clipboard to the header file. Make
EditorCommand simpler for improving code health.

Bug: 818552
Signed-off-by: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Change-Id: I2ebbd4ebb6a0ee3cc13f3a928c786a8d6e285bf4
Reviewed-on: https://chromium-review.googlesource.com/952744Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542052}

Move all layout to Layout() so that it updates correctly when the
browser window is resized with the results dropdown open.

Bug: 801583
Change-Id: I7b931ff3d3b8623e5a01b4543b441767845818ac
Reviewed-on: https://chromium-review.googlesource.com/942562
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542051}

Platform-specific IPC::Channel implementations included Chrome IPC
message logging, but this was not carried into the Mojo-based Channel
implementation.

Chrome IPC message logging is higher-level than Mojo IPC message logs,
which can be useful for certain kinds of diagnosis.

Bug: 816620
Change-Id: I467857fd07b66c3d468039d6fb7c2950f931c8bb
Reviewed-on: https://chromium-review.googlesource.com/956347Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542050}

ExtensionView::DidStopLoading() collided with
content::WebContentsObserver::DidStopLoading().

BUG=818397
TBR=rdevlin.cronin@chromium.org
Method rename.

Change-Id: I15ea2074f7c430429d2538ef19c858cb74f549b3
Reviewed-on: https://chromium-review.googlesource.com/954065
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542049}

This prototype is 'assert_equals(actual, expected, description)', we
should pass 'actual' and 'expected' in order, to make the failure
message be reasonable.

This CL just fixes
external/wpt/service-workers/service-worker/navigate-window.https.html.

BUG=

Change-Id: Ic11ec67f27f7a9a5ae289ddda4362af72b4737d4
Reviewed-on: https://chromium-review.googlesource.com/955282
Commit-Queue: Han Leon <leon.han@intel.com>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542048}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/595b66866726..e0f4e29651e2

$ git log 595b66866..e0f4e2965 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ibad7f06f6c5fcca4823f9497eefaabefe107bdb3
Reviewed-on: https://chromium-review.googlesource.com/956746Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542047}

Per discussion on the CL below [1], we want to move decrypting
decoder creation to the standard renderer factory. To do this we
need to provide the WaitingForDecryptionKeyCB to the decoders at
time of Initialize() to avoid duplicate callbacks for the same
functionality.

This has the side effect of providing the wait for key CB in new
places that should eventually make use of it (Mojo, Gpu decoder).

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/952207

BUG=801245
TEST=no functional changes, so builds and tests pass.
TBR=bbudge

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4e6c9dc6344a798ab9a9b374acc8aff67d9dd4d1
Reviewed-on: https://chromium-review.googlesource.com/956344
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542046}

Refactor LocationBarView to move Refresh logic for some BubbleIconViews into the respective subclasses.

This is initial work for adding BubbleIconViews to Chrome OS Desktop PWAs.
It partially decouples BubbleIconViews from the LocationBarView so that
they can also be used in HostedAppButtonContainer.

Bug: 788051
Change-Id: I986951b64fb02f2d2728abbe6a3964ff97e04909
Reviewed-on: https://chromium-review.googlesource.com/923607
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542045}

These tests run on waterfall builders, so they should run in the CQ.
They shouldn't be limited to Linux and CrOS trybots.

AppShell is only actively developed for Linux, but it's used elsewhere
for extension tests, so we should avoid regressions in AppShell-specific
code on all desktop bots.

Change-Id: I6a8de9bb9cb1a04756e66ba596abec1955a83a86
Reviewed-on: https://chromium-review.googlesource.com/950480Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542044}

https://chromium.googlesource.com/chromiumos/platform/minigbm/+log/7f79cb5..6eca368

$ git log 7f79cb5..6eca368 --date=short --no-merges --format='%ad %ae %s'
2018-03-06 servolk@google.com Rename amlogic backend in minigbm into meson
2018-02-28 marcheu@chromium.org msm: Align buffer dimensions for llvmpipe
2018-02-20 Deepak.Sharma@amd.com minigbm: amdgpu: support DRM_FORMAT_YVU420_ANDROID
2018-02-07 hoegsberg@chromium.org i915: Always set the modifier when allocating BOs

Also made two changes in third_party/minigbm/BUILD.gn:
1. Updates for the "amlogic" backend being renamed into "meson"
2. Added "libminigbm" target for Chromecast builds, which expect the final lib
name to be <GN target name> + .so

Bug: internal b/70752885
Test: build and run ozone_demo
Change-Id: Ie358b925464745f27402a826ef256e3da5199ec6
Reviewed-on: https://chromium-review.googlesource.com/952165Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542043}

The recent change in MediaFoundation API requires explicit enumeration
of sensor (newer depth Hello) cameras.

Pass-through mode fixes in MF capture implementation.

Verified using both Intel® RealSense™ Depth Camera D435 and previous depth
cameras, those that are not marked as sensors in driver inf, e.g. SR300.

Minor refactoring static -> anonymous namespace.

BUG=807293

Change-Id: I8c13d360bfc30cae8902f8e03d553dff69dcbf34
Reviewed-on: https://chromium-review.googlesource.com/944627
Commit-Queue: Aleksandar Stojiljkovic <aleksandar.stojiljkovic@intel.com>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542042}

This CL changes CompositingInputsUpdater to keep track of scrolling
container for different type of positioned descendants, so we won't need
to walk up ancestor chain to look for them. This is similar to the
technique used by PrePaintTreeWalk.

No behavior change is expected.

BUG=818768

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I2409dd91e5b2903e348bdebca7f6ac2f1544ea94
Reviewed-on: https://chromium-review.googlesource.com/952540
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542041}

https://chromium.googlesource.com/angle/angle.git/+log/19fa1c6f8852..e8a93c6ed6fe

$ git log 19fa1c6f8..e8a93c6ed --date=short --no-merges --format='%ad %ae %s'
2018-01-04 jdarpinian New transform feedback buffer binding rules
2018-03-08 lucferron Vulkan: Support of GL_UNSIGNED_BYTE type in drawElements
2018-03-05 brandon1.jones Add NPOT validation to copyTextureCHROMIUM

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ibb5aac5ef69704b80f060b2292d0480ef99d074e
Reviewed-on: https://chromium-review.googlesource.com/956891
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542040}

Bug: 813477
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaa6c3f1acb0b6767f491fd437fa58a8764efcdcf
Reviewed-on: https://chromium-review.googlesource.com/954802Reviewed-by: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542039}

1. Removed two members stored in SpellingRequest; Changed them as passed
   via call stack. Note: |SpellingRequest::text_| doesn't need to be
   stored, either; However, it still seems natural to store it.

2. Added more comments to SpellingRequest.

Change-Id: I64a07a8e1fe9b23bf5dd0757d225f309548da05b
Reviewed-on: https://chromium-review.googlesource.com/956617Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542038}

https://chromium.googlesource.com/catapult.git/+log/df668c31259d..78d89b42c293

$ git log df668c312..78d89b42c --date=short --no-merges --format='%ad %ae %s'
2018-03-08 kjharland [Dashboard] Whitelist Fuchsia garnet-ci dev acct
2018-03-07 perezju Reland "[Telemetry] Move apk finding code to Android backend settings"

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I897909bec9222fbcf834f63642b2254d976e3fde
Reviewed-on: https://chromium-review.googlesource.com/956888Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542037}

https://webrtc.googlesource.com/src.git/+log/8861da8356ee..8493594dc2ae

$ git log 8861da835..8493594dc --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None,None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Id48cefe2e32f0a1a18f9b8f2eea78cf78858fa2f
Reviewed-on: https://chromium-review.googlesource.com/956412
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542036}

Before this patch, TextureDefinition considers itself "defined" if any image is
defined on the source Texture. However it could be the case that the level 0
(which is the one we deal with in MailboxManagerSync) might not be defined (but
others are). Make sure that this is handled correctly, by considering
TextureDefinition to be "defined" iff level 0 is defined

Bug: 814677
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id14f00d0c6ac36385d378a42df7b2119adbd0879
Reviewed-on: https://chromium-review.googlesource.com/956748Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542035}

Previously LogMessage would use the POSIX getpid() API, which is not
a real implementation under Fuchsia.

Bug: 706592
Change-Id: I9d2b2f06efcecfea9457f7d96295457de2ef888d
Reviewed-on: https://chromium-review.googlesource.com/954420Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542034}

Changes some Contextual Search tests that are flaking on KitKat.
Now they only run on Android-L or later.

BUG=818897

Change-Id: I97b10e45b055ccc8b05dce569b44c8f987c13d90
Reviewed-on: https://chromium-review.googlesource.com/953563
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542033}

Prepares support for BigInts in
- JSAutocomplete
- objectValue, heap snapshot, console styles
- 'copy' command line API value

Screenshot: https://imgur.com/a/KqyBg

Bug: v8:7486
Change-Id: I12bab5a06dc940ebdb096c3b944fb71646f5b62c
Reviewed-on: https://chromium-review.googlesource.com/940774
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542032}

New version of acorn support spread and rest operators.

R=dgozman@chromium.org

Bug: chromium:756006
Change-Id: I8c0a5a6d0f39027920f7d0e8b8df42a711262d97
Reviewed-on: https://chromium-review.googlesource.com/956559Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542031}

This updates //crypto to use base::OnceCallback instead of legacy
base::Callback. No intended functional change is included.

This reduces the number of 'base::Bind' in //crypto from 3 to 0,
as tracked at http://goo.gl/LUVhDj

Bug: 714018
Change-Id: I020993c154a0706a262543937d9ebe506ea01c25
Reviewed-on: https://chromium-review.googlesource.com/952507Reviewed-by: Adam Langley <agl@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542030}

https://pdfium.googlesource.com/pdfium.git/+log/a724cb2df9f7..5a7e330ef5e0

$ git log a724cb2df..5a7e330ef --date=short --no-merges --format='%ad %ae %s'
2018-03-08 hnakashima Unset timer in XFA scrollbar after stopping it.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: If6646e4bd84d235353bc2020d7f9b9cdc4480288
Reviewed-on: https://chromium-review.googlesource.com/956489Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#542029}

BUG=762641
TBR=xdai@google.com

Change-Id: Iec61e0be5a160775219e23f283b5bc433d4703ab
Reviewed-on: https://chromium-review.googlesource.com/955915
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542028}

This reverts commit 7ba450fd.

Reason for revert: lld-link currently warns if the orderfile
references non-existing functions, without implementing the flag
to disable that warning. Since our orderfiles are usually somewhat
out of date, lld-link currently always warns. Reland once
https://llvm.org/PR36657 is fixed and rolled in.

Original change's description:
> win: Use order files with lld as well.
> 
> Bug: 792131, 728324
> Change-Id: I3b2ebe4a2073b6a03193dac5c497dbd3c53fc06d
> Reviewed-on: https://chromium-review.googlesource.com/955726
> Reviewed-by: Reid Kleckner <rnk@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541874}

TBR=thakis@chromium.org,rnk@chromium.org

Change-Id: Ic9c6b7e94b99559c88a61fb22df253becf6853e9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 792131, 728324
Reviewed-on: https://chromium-review.googlesource.com/956035Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542027}

The previous mechanism would generate the variations crash keys from scratch
whenever a field trial became active, which would often be over 20 times
during startup. Generating the full list required a number of operations,
including SHA1-hashing each trial and group name and copying data between
several intermediate vectors.

This change optimizes this by keeping the intermediate results between
crash key updates, such that only the newly-activated trial needs to
have its strings hashed.

Additionally, cleans up some code, such as moving the responsibility of
monitoring active field trials for crash keys from several different
locations in the code base to the new variations_crash_keys.cc
implementation, thereby getting rid of ios::FieldTrialSynchronizer class.

Also fixes an oversight where synthetic trials were not set up on iOS.

This change clears the path for fixing crbug.com/309729, where a trial
that was just activated would not appear in crash reports, which I plan
to do in a follow-up CL. (This CL enables that by having a single place
that monitors field trials for crash keys, which I plan to convert to a
new API to fix that bug.)

Bug: 309729
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibb6818600868f9f0e562d56858959516612ba55d
Reviewed-on: https://chromium-review.googlesource.com/947382Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542026}

This is a reland of 613ba331. This collided with
r541891.

Original change's description:
> Extensions: Fix memory leak in ExtensionApiFrameIdMap.
>
> Currently in ExtensionApiFrameIdMap::UpdateTabAndWindowId and
> ExtensionApiFrameIdMap::LookupFrameDataOnUI we don't check whether a
> RenderFrameHost is alive, before storing it's frame data. It's possible that
> such a RenderFrameHost never becomes alive, and hence we don't get any
> OnRenderFrameDeleted notification for it. Since ExtensionApiFrameIdMap is a
> singleton, this causes a memory leak. To fix, ensure that only live
> RenderFrameHosts are tracked.
>
> Also ensure in InProcessBrowserTest::TearDown that ExtensionApiFrameIdMap is not
> leaking memory for any browser test.
>
> BUG=817205
>
> Change-Id: I78bf06cee7e10465f9eb5973ee8e59f525a74d93
> Reviewed-on: https://chromium-review.googlesource.com/951975
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#541950}

TBR=sky@chromium.org,rdevlin.cronin@chromium.org

Bug: 817205
Change-Id: I7b3ac6806d0c747d439e74f80f623a7fd4412050
Reviewed-on: https://chromium-review.googlesource.com/956762
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542025}

Rule of log levels I follow:

Level 1: construction, destruction, initialization, error
Level 2: flush, reset, key status, renewal, warning
Level 3: decrypt, decode, info

Change-Id: I2e83c5d55217b114a92d3b9789956bd80b1bf440
Reviewed-on: https://chromium-review.googlesource.com/955558Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542024}

The linked bug breaks when root-layer-scrolls is turned on because the
scrolling contents layer of the LayoutView's CompositedLayerMapping gets
its size from LayoutView::DocumentRect which is based on the overflow
rect. This is fractional because of Android's minimum-scale frame resize
after layout. This is snapped and becomes 1px shorter than the main
frame - which uses an expanded int rect in WebViewImpl::MainFrameSize().
This causes the background override to not be seen in the bottom row of
pixels.

This works without RLS because the LayoutView itself doesn't have a
scrolling contents layer - the main GraphicsLayer itself is the
scrolling contents and its size comes from
PaintLayer::BoundingBoxForCompositing which uses the expanded-int frame
size for the root layer.

The fix in this CL is to ensure a scrolling contents layer is always at
least as large as its clipping layer. This must necessarily be the case
since we only create scrolling layers if we have overflow. Even if we
only overflow in one dimension, the other dimension is typically set to
the clip size so this is the expectation.

An additional change is required in this CL. The scrolling bounds as
used in CC to calculate whether CC-controlled scrollbars should be shown
uses the same minimum-scale main frame resize as in WebViewImpl
mentioned above. This incorrectly keeps the bounds in fractional pixels.
Since we now effectively ceil the bounds in Blink, we do the same in CC
to avoid showing the scrollbars unnecessarily.

Bug: 811406
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Idcbdac1b03999f30c8d373f4b45dc6040d8f8514
Reviewed-on: https://chromium-review.googlesource.com/949772Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542023}

Using wpt-import in Chromium 9b9c97df.
With Chromium commits locally applied on WPT:
14350ac7 "[PE] Don't truncate table cell's padding"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13492

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org, mstensho@chromium.org:
  external/wpt/css/CSS2

TBR=robertma

No-Export: true
Change-Id: I8ea2fda00b9695baa9e2b487dbc7b195ed91c8e8
Reviewed-on: https://chromium-review.googlesource.com/956506
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542022}

A proper WaitForPopup() is necessary to observe when the ExtensionPopup
appears instead of using a content notification heuristic.

BUG=818397

Change-Id: I52e28711de32671329b468844dae420be943f6fd
Reviewed-on: https://chromium-review.googlesource.com/953258
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542021}

This cl reduces the search latency in Keyboard Shortcut Viewer (KSV).
1. Set a time delay to process key events in search mode. In this way,
users can keep typing in the search box.
2. Reuse the KeyboardShortcutItemView between TabbedView and the search
results. This reduces the layout time for |shortcut_label_view_| in
KeyboardShortcutItemView.
3. To highight matched search queries, we cannot avoid layouting
|description_label_view_| in KeyboardShortcutItemView.

Bug: 818882
Test: Tested on Eve and Minnie
Change-Id: I4b36e18fe3f72fba4884c0cc02fea24ff4416630
Reviewed-on: https://chromium-review.googlesource.com/951709Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542020}

Fails on Nexus 5X, Flaky on Linux NVIDIA

BUG=819635,820240
TBR=kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ie1daa75a8144d7bbcd314cba228fc528e6a4956a
Reviewed-on: https://chromium-review.googlesource.com/955959
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542019}

This likely leads to using the wrong locale for non-english systems.

BUG=819369
TEST=none

Change-Id: Ie432f038567f077ab10a18257b4b89c8a1a3282e
Reviewed-on: https://chromium-review.googlesource.com/951708Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542018}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=anantha@chromium.org

Change-Id: Ic8e7d26164a8f8fcf016abe5b3c24c1e10e66406
Reviewed-on: https://chromium-review.googlesource.com/955913Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542017}