- 26 Apr, 2018 40 commits
-
-
Hwanseung Lee authored
according to previous git log[1], it looks likes used to store test files in official Chrome build gs:// drops. these files haven't been touched in a long time. and it seems like not used any more. [1]https://codereview.chromium.org/545103003 Bug: 829975 Change-Id: Ida8e887c64d4d18b7eb877f3cda2001a1871b844 Reviewed-on: https://chromium-review.googlesource.com/1027598Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Cr-Commit-Position: refs/heads/master@{#553915}
-
Koji Ishii authored
This patch changes visual rect of NGPhysicalTextFragment to include its frame rect. Legacy does so, but NG did not when it was first implemented due to the lack of understanding. After reviewing test results, it turns out that by not doing so, background and decorations on space characters are affected by this difference because space characters do not have glyph bounding box, which results in empty visual rect. Includes rebaselines that improve the rendering. Bug: 636993, 714962 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I888f8b27680aa1ff806cca15c84919461c06fc31 Reviewed-on: https://chromium-review.googlesource.com/1027012Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#553914}
-
tzik authored
In C++17, noexcept keyword is a part of the function type, and that causes a pattern match failure on base::Bind implementation. This CL fixes the failure by falling it back to bare function cases. Bug: 752720 Change-Id: I98c71977fa3fd759956c86e394fb9e30179c951c Reviewed-on: https://chromium-review.googlesource.com/1027530Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#553913}
-
Peter Boström authored
The generic icon should be shown when there's only one (non-signed in) user. We need to listen for add/remove profile events so we can detect whether a generic icon should be shown or not for existing windows as well. Bug: chromium:822070 Change-Id: Ia84feb13dd10b4459aeff326e2fd6e1d29698a76 Reviewed-on: https://chromium-review.googlesource.com/1028981Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#553912}
-
Katie D authored
Because language -> voice pref is a DICTONARY type pref, this change extends settings-dropdown-menu to work with dictionary prefs given a new parameter, prefKey. When set, prefKey tells the settings dropdown which key in the dictionary is associated with the value it represents. This is not yet hooked up to the Text-to-Speech controller. In addition, we don't yet define default voices per language. Bug: 823359 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I6b7ae800ed6f0230076da5d65114d305fc1dc64d Reviewed-on: https://chromium-review.googlesource.com/1020456 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#553911}
-
Maggie Chen authored
The callback function UpdateGpuInfoOnIO is added to the DX12/Vulkan info collection path. The data is now saved in gpu_info of the browser process. Both DX12 and Vulkan info collection functions are removed from the about:gpu path. The data can be found in the gpu info. There is no need to call these two functions again. BUG=775983 TEST=manual,Chrome://histograms R=zmo@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6716aed172c8c6821f60124fb9cedc0c2e2b5079 Reviewed-on: https://chromium-review.googlesource.com/1026946Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#553910}
-
Yoichi Osato authored
Bug: 766694, 523952 Change-Id: Ic794281024e97783d9f2bde6f2ca6c7f2eefdbb8 Reviewed-on: https://chromium-review.googlesource.com/1027551Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#553909}
-
Kevin Marshall authored
This change uses the tempfile library to manage temporary named files instead of using a DIY try/finally approach. Bug: 832849 Change-Id: I439ff29edfb0e8791202604d56f891827d79f0a2 Reviewed-on: https://chromium-review.googlesource.com/1029212Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#553908}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ad0b2d2757e8..48a13aacf880 $ git log ad0b2d275..48a13aacf --date=short --no-merges --format='%ad %ae %s' 2018-04-25 dgarrett remote_try: Use luci_builder build config value. Created with: roll-dep src/third_party/chromite BUG=chromium:832747 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I100607416aef078b66dbe44a837db19069ca5ecb Reviewed-on: https://chromium-review.googlesource.com/1029352Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553907}
-
Tetsui Ohkubo authored
This is a reland of 59692b72 Change from original CL (PS#1): Fix use-after-free in unit test. Original change's description: > Observe ClockModel directly from DateView/TimeView > > This CL changes DateView and TimeView to directly observe ClockModel. > It removes unrelated logic from SystemTrayItem and makes embeding these > views easier. > > TEST=ash_unittests > BUG=none > > Change-Id: I70b3a873c0ac259a05597d3f93b77fd7519dd462 > Reviewed-on: https://chromium-review.googlesource.com/1025615 > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553433} TBR=stevenjb@chromium.org Bug: none Change-Id: I0c609729e5ccc7fea66a696b57a689097f3465af Reviewed-on: https://chromium-review.googlesource.com/1029390 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#553906}
-
Chris Blume authored
The LSI allocators previously did not store a copy of the last generated LSI. As a result, many call sites would have to keep their own copies. Now that the LSI allocators have their own copies, the call sites can be updated to no longer store a separate copy. FrameGenerator is one such call site. BUG=759031 Change-Id: I39774ba04f4bbfd61909e9df12df76c1fd76c492 Reviewed-on: https://chromium-review.googlesource.com/1029427 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553905}
-
Noel Gordon authored
After crrev.com/553147 FolderShortcuts/FileManagerBrowserTest.Test/1 is a persistent TIMEOUT on the DEBUG and ASAN bots, also Test/0 is a flaky TIMEOUT on DEBUG and ASAN. Disable them on DEBUG and ASAN. Seems the expandTreeItem querySelector() is the problem: the element the test expects should appear, never does => TIMEOUT. Bug: 837106,836254 Change-Id: Icfb19ad7e2c170dc125f7081e4d69b12d0df5811 Reviewed-on: https://chromium-review.googlesource.com/1029591Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553904}
-
Takuto Ikuta authored
We don't want to run test on the builders. I will add webrtc target in tools repository. https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py Bug: b/78251210 Bug: 835686 Bug: 834213 Change-Id: Ib2ac5238e86fc965df9bfd4af098d60d3cbfb89b Reviewed-on: https://chromium-review.googlesource.com/1027575Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#553903}
-
Patti authored
gfx::VectorIcons were refactored in r552619 to allow arbitrarily many versions for the same icon. Update documentation to reflect this. Bug: 647286 Change-Id: I2b82a7c1c9832ed2a7bf4c83bd3223b7d73f1110 Reviewed-on: https://chromium-review.googlesource.com/1023625 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#553902}
-
Erik Luo authored
After marking Document's "location" attribute as kHasNoSideEffect, the CL [1] failed to reset bindings tests results. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1024863/ Bug: none Change-Id: Ie0be4542bd1b58939b12c342056d521abb5e4ddd Reviewed-on: https://chromium-review.googlesource.com/1029451Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#553901}
-
Hajime Hoshi authored
According to the task type usage guideline, we use kInternalDefault for internal and default behavior tasks. This CL introduces kInternalDefault by renaming kUnspecedTimer. Doc: https://docs.google.com/document/d/1k7EEHQUEujgQ7BAhbmNdeaddwfJPWp7qjLy8mnVTQ9Y/edit Bug: 836410 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id3d1aec136c6c30c632b87d58a13b8de76738653 Reviewed-on: https://chromium-review.googlesource.com/1027572 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#553900}
-
Kenichi Ishibashi authored
The GDB pretty printers for blink has moved. Update the doc accordingly. Bug: N/A Change-Id: Ifce05658d6c207d761fb349d5c4ab877f7e09ae9 Reviewed-on: https://chromium-review.googlesource.com/1029650 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#553899}
-
Alan Cutter authored
This CL fixes a regression caused by https://chromium-review.googlesource.com/1004886 where permission prompts would appear partially off screen in full screen mode on platforms where we hide the Chrome UI. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=334665&signed_aid=cQIe_b4bfUZn8i-akRK_ZQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=334829&signed_aid=cXhOlJe-_oibvrzmLtL4Bw==&inline=1 This also fixes the DCHECK in GetPageInfoAnchorRect() to be relative to GetPageInfoAnchorView() rather than copy pasting its bail out condition. Bug: 833257, 814532 Change-Id: I6ef85ace735b0b217b3a473365791ad453cf8378 Reviewed-on: https://chromium-review.googlesource.com/1013676 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#553898}
-
tzik authored
https://chromium.googlesource.com/webm/libwebm.git/+log/b03c65468b06..af81f26025b7 $ git log b03c65468..af81f2602 --date=short --no-merges --format='%ad %ae %s' 2018-03-02 mjbshaw Fix MSVC warning about 2147483648 not fitting in an int 2018-02-28 mjbshaw Fix compilation with MSVC 2018-02-06 tomfinegan Allow shared builds of libwebm. 2018-01-31 tomfinegan webm2pes: Avoid OOB reads caused by invalid superframe index. 2018-02-01 jzern vp9_header_parser: make SetFrame private 2018-01-30 tomfinegan Limit string element size to 20 million bytes. 2018-01-22 velden Replace uses of deprecated std::auto_ptr with std::unique_ptr. 2018-01-19 mjbshaw Set a maximum limit on element recursion depth 2017-12-18 tomfinegan Silence -Wdeprecated-declarations in GCC 4.7+. 2017-12-07 huisu Update VP9 level definition Created with: roll-dep src/third_party/libwebm/source BUG=836706 Change-Id: I16a6a0a850e9a47a81176d116af7ddde4fd6c0bf Reviewed-on: https://chromium-review.googlesource.com/1027561Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#553897}
-
Kunihiko Sakamoto authored
This patch fixes a bug where font display timeouts (100ms and 3s) didn't start if the font resource is already started loading by <link rel=preload>. Bug: 835583 Change-Id: Ie464179ebcc56f2d18c99d234eadd4fc26bc1fcd Reviewed-on: https://chromium-review.googlesource.com/1027331Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#553896}
-
kapishnikov authored
BUG=836347 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I53cb9dca6a9dd1d874c58d72b36c75e82b1142c4 Reviewed-on: https://chromium-review.googlesource.com/1026415Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#553895}
-
Brad Lassey authored
changes Socket::Read(), Socket::ReadIfRead(), Socket::Write(), StreamSocket::Connect(), SocketPosix::Accept() & SocketPosix::Connect() to CompletionOnceCallback. R=bnc@chromium.org, reillyg@chromium.org, sergeyu@chromium.org, sky@chromium.org Bug: 807724 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia363b632bf1193c40576e3ccdd93188081aca589 Reviewed-on: https://chromium-review.googlesource.com/907076 Commit-Queue: Brad Lassey <lassey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#553894}
-
Sam McNally authored
Mime handler guests currently do not set their view type. Thus, their foreground pages do not count as foreground pages for the purpose of deciding whether to keep their background pages alive, resulting in the background page being shut down while the mime handler remains open. Set the view type to VIEW_TYPE_EXTENSION_GUEST when creating mime handler guests to ensure mime handlers keep their background pages alive while open. Bug: 819761 Change-Id: Ibc64c93bbb33022375cf91b45785f543a53ca71c Reviewed-on: https://chromium-review.googlesource.com/1023518 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#553893}
-
Yoichi Osato authored
This patch wanted to confirm changing selection invalidation between execCommand("selectAll") and Selection.setBaseAndExtent(). However calling execCommand("selectAll") before load is flaky from the point of invalidation. This patch arranges the function calls so that invalidation occurs only on selection difference w/o flakiness. Bug: 774437 Change-Id: I63efe553282f4a6643c0d7b8eb0b0597b1ccac9f Reviewed-on: https://chromium-review.googlesource.com/1025594 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553892}
-
Maks Orlovich authored
This is so that exporting of this functionality over mojo can accurately express the underlying type and the kNoLimit constant. (Which doesn't seem doable with size_t since its size, and therefore value of its max, differs on different platforms). Bug: 767450 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I741bfe1c942e5ee7752f346932a26e861cefb0c8 Reviewed-on: https://chromium-review.googlesource.com/1027905Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#553891}
-
https://chromium.googlesource.com/catapult.git/+log/d43ffede2b5c..dc970d3e1f7b $ git log d43ffede2..dc970d3e1 --date=short --no-merges --format='%ad %ae %s' 2018-04-24 simonhatch Dashboard - Remove alert_group. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ia5ddfdf725e1f290fe2f04d6c0db1ff92fe17093 Reviewed-on: https://chromium-review.googlesource.com/1028990Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553890}
-
Daniel Blakemore authored
Bug: 810904 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I07075a30553f1c3e2f70b1b776ea064c376ce186 Reviewed-on: https://chromium-review.googlesource.com/1018114 Commit-Queue: Daniel Blakemore <danblakemore@google.com> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553889}
-
Bill Orr authored
We were getting into a state where we thought we had requested a vsync from the device, but actually haven't. This causes future RAFs to not run, and we won't render. BUG=835888 Change-Id: I41af90675fa5ba8e6b78a598594f4a2cf28217ed Reviewed-on: https://chromium-review.googlesource.com/1028935Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#553888}
-
Timothy Loh authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/62d5021bb6d4..1f64aefc280e $ git log 62d5021bb..1f64aefc2 --date=short --no-merges --format='%ad %ae %s' 2018-04-20 timloh Add startup_notify field to apps.proto Created with: roll-dep src/third_party/cros_system_api Bug: 821662 Change-Id: I5126d2b48bb46832aea047cb857cf8bab6cee518 Reviewed-on: https://chromium-review.googlesource.com/1029330Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#553887}
-
Abhishek Arya authored
R=mmoroz@chromium.org,metzman@chromium.org Bug: 821574 Change-Id: I628a946982489fa9f265f78cbd467d9be7ceabe3 Reviewed-on: https://chromium-review.googlesource.com/1028668 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#553886}
-
Vladimir Levin authored
If enable-threaded-compositing is specified (via a threaded virtual test, or on the command line), along with the display compositor dumps, then we don't need to synchronously composite frames. Instead we should rely on surface synchronization to wait for frames to be submitted via a scheduler. R=piman@chromium.org, fsamuel@chromium.org Bug: 667551 Change-Id: I05859b1ebe18cc59379514d604268940714250b0 Reviewed-on: https://chromium-review.googlesource.com/1026563Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#553885}
-
Sergey Berezin authored
R=justincohen@chromium.org Bug: 834527 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8707404256448ffe8f60037785d9b0ee20d08fc6 Reviewed-on: https://chromium-review.googlesource.com/1029205 Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#553884}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6376ebcedebd..7e2468888f99 $ git log 6376ebced..7e2468888 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:None The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I56d244721388dcb6b654930ef03715055af7e17e Reviewed-on: https://chromium-review.googlesource.com/1029259 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553883}
-
Tsuyoshi Horo authored
We are trying to show SignedExchange related information in DevTools. https://bit.ly/2HXVbCU This CL adds LayoutTests and -expected.txt files to track the progress of the implementation. Currently there are some difference from the ideal behavior: - The status code of the succeeded .htxg should be 200. Currenly it is 302 which is the status code of internally generated redirect response. - The status code of the invalid .htxg should be 200. Currenly it is 0 because the actual response is not sent to DevTools. DevTools just recieves "loadingFailed" event. - The request to the certificate file shold be displayed. Currenly DevTools doesn't recieve the certificate request which is sent from the browser process. - There is no signed exchange related information in the network log. Bug: 830505 Change-Id: I80c4c648c466505fef4f729eb046a91ede4a4660 Reviewed-on: https://chromium-review.googlesource.com/1027574 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#553882}
-
Stephen Martinis authored
Bug: 782863 Change-Id: I9565b84c027f0c88dfb4ee02602a2d49c3a95016 Reviewed-on: https://chromium-review.googlesource.com/1029218Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#553881}
-
Peter Kasting authored
Incognito state is indicated by the avatar button in the toolbar. BUG=822070 TEST=none Change-Id: Ib87a4f8dbc6e89694277e40fa0f4143ad8e25496 Reviewed-on: https://chromium-review.googlesource.com/1029255Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#553880}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ic9ad97d4381e555ba69f55e72152965098041e92 Reviewed-on: https://chromium-review.googlesource.com/1029670Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#553879}
-
Hans Wennborg authored
This reverts commit 6b5ac2ef. Reason for revert: It broke the Win ASan bot on the LKGR waterfall (see second bug). Original change's description: > Reland "win: Link with lld instead of MSVC's link.exe by default" > > This is a reland of be8138a4 > The issues with the previous attempt were addressed in the latest > Clang roll (#553415). > > Original change's description: > > win: Link with lld instead of MSVC's link.exe by default > > > > lld is LLVM's linker. It produces PE/COFF and PDB files just like > > link.exe, but it's significantly faster and it can also handle LLVM's > > internal representation, which will enable us to do link-time > > optimization and control-flow integraty checks with Clang. > > > > While lld is much faster at linking, it doesn't support incremental > > links, meaning builds that only touch a few files and re-link a large > > executable may become slower. > > > > This is the first attempt at switching everything over, with the > > purpose of gathering data and finding unknown unknowns. It's likely > > temporary until something breaks. > > > > is_win_fastlink is implicitly ignored when using lld, as lld without > > fastlink is faster than link.exe with it. > > > > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's > > link.exe to make sure that configuration keeps working. > > > > Bug: 792131 > > Change-Id: I0f115a78c33d69eadbd480f75c2a5d636e86483d > > Reviewed-on: https://chromium-review.googlesource.com/983632 > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#551367} > > Bug: 792131 > Change-Id: I3b76cd015ef18bb3e2ac7a3efa4352c4f04e560b > Reviewed-on: https://chromium-review.googlesource.com/1028374 > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553776} TBR=thakis@chromium.org,hans@chromium.org Change-Id: Ied5addd2f8d16d1e002bf37846e7106b4c754cb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 792131, 837090 Reviewed-on: https://chromium-review.googlesource.com/1029631Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#553878}
-
Noel Gordon authored
Mash browser tests do not support this test (see patch set #2 trys) so disable it in mash. No-Tree-Checks: true Bug: 836254,701924 Change-Id: I3266d131b84c261e5bb6b9358b7c9132172bbabf Reviewed-on: https://chromium-review.googlesource.com/1029470Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553877}
-
Sergey Berezin authored
This reverts commit 116dd7c3. Reason for revert: broke https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac%20Builder/240835 Original change's description: > Replace hermetic Xcode installation with CIPD-based flow. > > The 'API' to the scripts remains the same, only the delivery mechanism changes. > > BUG=797051 > R=erikchen@chromium.org, justincohen@chromium.org > > Change-Id: I8ee5486b107061f9fb6e64354463ac51de53d4cc > Reviewed-on: https://chromium-review.googlesource.com/887819 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553871} TBR=erikchen@chromium.org,justincohen@chromium.org,sergeyberezin@chromium.org,jbudorick@chromium.org Change-Id: Icdd25e048a8ed6de19b7a98e41a438c1c7c6ed2f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 797051 Reviewed-on: https://chromium-review.googlesource.com/1029630Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#553876}
-