Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 07 Jun, 2016 33 commits
  3. 06 Jun, 2016 7 commits
    • erikchen's avatar
      Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return const... · 41b2e7da
      erikchen authored 
      Revert of Make CSSComputedStyledeclaration::getPropertyCSSValue return const (patchset #3 id:40001 of https://codereview.chromium.org/2034013002/ )

Reason for revert:
"""
../../third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:14:15: error: cannot initialize a variable of type 'blink::CSSValue *' with an rvalue of type 'const blink::CSSValue *'
    CSSValue* cssValue = m_computedStyleDeclaration->getPropertyCSSValueInternal(propertyID);
"""

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Linux%20TSan%20Builder/builds/23734/steps/compile/logs/stdio

Original issue's description:
> Make CSSComputedStyledeclaration::getPropertyCSSValue return const
>
> Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
> CSSValue* instead of a regular CSSValue*. This required changing
> CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
> CSSValue* as well, and marking CSSValueList::copy() as a const method
> (which it already was, it was just missing the const modifier). This is
> pre-work for making CSSValueList store const CSSValues.
>
> This patch is mostly mechanical changes, but does contain one logic
> change: the static method mergeTextDecorationValues in EditingStyle
> needs to be changed since it modifies a CSSValueList that points inside
> the mutable style. Instead, the function is changed to take two
> CSSValueLists and return a new one, and the callsite is changed to
> replace the old CSSValueList with the new one in the style rather than
> modifying the old CSSValueList in-place.
>
> BUG=526586
>
> Committed: https://crrev.com/5896ec297d9240b691e7f70a239498b795531dc1
> Cr-Commit-Position: refs/heads/master@{#398151}

TBR=haraken@chromium.org,timloh@chromium.org,yukishiino@chromium.org,sashab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526586

Review-Url: https://codereview.chromium.org/2042113002
Cr-Commit-Position: refs/heads/master@{#398156}
      41b2e7da
    • jessicag's avatar
      Add user agent to System Context Getter as suggested by metrics team. · 117048d2
      jessicag authored 
      Currently the user agent is set to empty string which results in the
upload being ignored by the metrics service.

Setting this value will allow for processing and display of metrics
for Blimp.

BUG=592757

Review-Url: https://codereview.chromium.org/2041933002
Cr-Commit-Position: refs/heads/master@{#398155}
      117048d2
    • fdoray's avatar
      Remove use of deprecated MessageLoop methods in rlz. · 67dc362c
      fdoray authored 
      MessageLoop::PostTask/PostDelayedTask/DeleteSoon/ReleaseSoon
are deprecated. This CL makes the following replacements to
remove some uses of these methods:

"MessageLoop(ForUI|ForIO)::current()->PostTask" ->
  "ThreadTaskRunnerHandle::Get()->PostTask"
"MessageLoop(ForUI|ForIO)::current()->PostDelayedTask" ->
  "ThreadTaskRunnerHandle::Get()->PostDelayedTask"
"MessageLoop(ForUI|ForIO)::current()->DeleteSoon" ->
  "ThreadTaskRunnerHandle::Get()->DeleteSoon"
"MessageLoop(ForUI|ForIO)::current()->ReleaseSoon" ->
  "ThreadTaskRunnerHandle::Get()->ReleaseSoon"

In files where these replacements are made, it adds these includes:
  #include "base/location.h"
  #include "base/single_thread_task_runner.h"
  #include "base/threading/thread_task_runner_handle.h"

And removes this include if it is no longer required:
  #include "base/message_loop/message_loop.h"

Why ThreadTaskRunnerHandle::Get() instead of
MessageLoop::current()->task_runner()?
 - The two are equivalent on threads that run a MessageLoop.
 - MessageLoop::current() doesn't work in base/task_scheduler
   because the scheduler's thread don't run MessageLoops.
   This CL will therefore facilitate the migration of browser
   threads to base/task_scheduler.

Steps to generate this patch:
1. Run message_loop_cleanup.py (see code on the bug).
2. Run tools/sort-headers.py on modified files.
3. Run git cl format.

BUG=616447
R=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2033863003
Cr-Commit-Position: refs/heads/master@{#398154}
      67dc362c
    • sebmarchand's avatar
      Use /LTCG:Incremental to speed up the non-clobber official builds. · 98fccebb
      sebmarchand authored 
      /LTCG:Incremental is different from /INCREMENTAL, it speeds-up the link time of the WPO build without affecting the code quality and the performance, see https://blogs.msdn.microsoft.com/vcblog/2014/11/12/speeding-up-the-incremental-developer-build-scenario/ for more details on this.

Review-Url: https://codereview.chromium.org/2045683002
Cr-Commit-Position: refs/heads/master@{#398153}
      98fccebb
    • rkjnsn's avatar
      Refactor ResizingHostObserver tests · 7142e66c
      rkjnsn authored 
      Remove a couple of possible sources of dangling pointers and make the
tests cleaner and more compact.

Review-Url: https://codereview.chromium.org/2038183002
Cr-Commit-Position: refs/heads/master@{#398152}
      7142e66c
    • sashab's avatar
      Make CSSComputedStyledeclaration::getPropertyCSSValue return const · 5896ec29
      sashab authored 
      Make CSSComputedStyledeclaration::getPropertyCSSValue() return a const
CSSValue* instead of a regular CSSValue*. This required changing
CSSStyleDeclaration::getPropertyCSSValueInternal() return a const
CSSValue* as well, and marking CSSValueList::copy() as a const method
(which it already was, it was just missing the const modifier). This is
pre-work for making CSSValueList store const CSSValues.

This patch is mostly mechanical changes, but does contain one logic
change: the static method mergeTextDecorationValues in EditingStyle
needs to be changed since it modifies a CSSValueList that points inside
the mutable style. Instead, the function is changed to take two
CSSValueLists and return a new one, and the callsite is changed to
replace the old CSSValueList with the new one in the style rather than
modifying the old CSSValueList in-place.

BUG=526586

Review-Url: https://codereview.chromium.org/2034013002
Cr-Commit-Position: refs/heads/master@{#398151}
      5896ec29
    • dschuyler's avatar
      [MD settings] google-grey to paper-grey · 38ed4344
      dschuyler authored 
      This CL replaces some uses of the non-existent
--google-grey-600 with --paper-grey-600

BUG=589630
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2010283003
Cr-Commit-Position: refs/heads/master@{#398150}
      38ed4344