- 15 Oct, 2019 10 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e16ffffc28f3..c6512213a7b7 git log e16ffffc28f3..c6512213a7b7 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 ehmaldonado@chromium.org depot_tools: Run recipe scripts using vpython. Created with: gclient setdep -r src/third_party/depot_tools@c6512213a7b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I443f3cb3532c3ce6751540441d2bb806f5827e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860982Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705763}
-
Robert Liao authored
BUG=1014283 Change-Id: I7c81dcbe039392b91ca8f8b7875b9b5bcad65d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859903 Commit-Queue: Peter Boström <pbos@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705762}
-
Tim Song authored
BUG=1009622 Change-Id: Ib26a700b2889f101da40947f9f90f3058282540b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848363Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#705761}
-
Eric Karl authored
Adds Android-specific customization of de-jelly effect based on display properties. Bug: 995965 Change-Id: Ie48ddf1e3f61d601e05522cf1f7b99a3dc25f012 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837115 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#705760}
-
minch authored
Do not go back and show the back gesture affordance while in overview mode, home screen or not in an ACTIVE session. Bug: 1002733 Change-Id: Id01ac4fe02fefd94423924ea4871428c29aee497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854792Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#705759}
-
Lei Zhang authored
TBR=emaxx@chromium.org Bug: 1014318 Change-Id: Ia50ec7454db51e18b287a48fa72a7777967259e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861107 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705758}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8cd95dd1d376..61d564ff3b00 git log 8cd95dd1d376..61d564ff3b00 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 bpastene@chromium.org chrome_committer: Send all CHROMEOS_LKGM updates to the current gardener via gwsq. Created with: gclient setdep -r src/third_party/chromite@61d564ff3b00 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie1f29b33d0c134f0bcdce984d7f707b4233c9a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860890Reviewed-by:
-
Shakti Sahu authored
This CL adds an offline message card on NTP when chrome is offline, tapping on which will open offline home. It also fixes the way NTP hides or unhides the views depending on search provider logo availability. Bug: 1012267, 1012397 Change-Id: I0fcfcc22b63c41e43bbd047529752ae48dba89e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847771 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#705756}
-
Kristi Park authored
Bug: 851335 Change-Id: Ib73f8952c5e0e01f8a2f9523bfec65d5cf34b55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854418 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#705755}
-
Klaus Weidner authored
OnSessionEnded claimed to be safe to be run repeatedly, but it wasn't quite a no-op. Use VRDeviceBase's session tracking to be clearer about session lifetime, and only do teardown once. This is a speculative fix for DCHECK errors in the linked bug, though I haven't been able to specifically reproduce these. Bug: 1014159 Change-Id: I800f62bee87a1827d57999af12e721ba06fd3c79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859832Reviewed-by:
Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#705754}
-
- 14 Oct, 2019 30 commits
-
-
Avery Musbach authored
The present CL is a new version of: https://chromium-review.googlesource.com/c/chromium/src/+/1726272 Bug: 970013 Change-Id: Ie4960fb590b3ce096ac0cca8f4a6bcbf2d4c73be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857178Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#705753}
-
Austin Eng authored
In https://github.com/gpuweb/gpuweb/pull/429, we said that popErrorScope throws an exception instead of rejecting the Promise. However, according to http://heycam.github.io/webidl/#es-operations, it is illegal to throw an exception and not return a Promise from a Promise-returning function. Instead, we need to reject the Promise with an exception. Bug: 1013815 Change-Id: I0879ab13764a3c6d475a9f8d47c06034069ce328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857483Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#705752}
-
Shik Chen authored
We should prefer constant 30 fps over the default {min: 24} constraint for video recording. Bug: b:139118507 Test: Check FPS in CCA Expert Mode with lens covered in low resolution to isolate the performance issue. Test: Check the metadata control.aeTargetFpsRange is set to "30 30" with metadata inspector. Such as $ cros_camera_service \ --metadata_inspector_output=/dev/stdout \ --metadata_inspector_whitelist=fps Change-Id: Ib8115cdd371b767e1ea4bd0a3d9d21cee15d5126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859534Reviewed-by:Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#705751}
-
Mike Wasserman authored
The bubble was passing the desired icon color as |related_text_color|. Use a slightly different function that takes the icon color itself. Bug: 999761 Test: Button color appears as expected. Change-Id: Iff87e0f3950131695cbcfe179b4ef33732b55b3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861034 Commit-Queue: Michael Wasserman <msw@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#705750}
-
Ahmed Mehfooz authored
Modify check for message center gaining activation to not dereference the message center widget. There's a crash caused by focus switching between the message center and quick setting bubbles before the message center bubble's constructor has exited. Change-Id: Ia15acb47dc3806466a2f40a73e843333655e7953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860692 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#705749}
-
Ahmed Mehfooz authored
When Alt+Shift+N is used to open the message center, the first notification will be focused with this change. This fix is only available when the "Enable Message Center Redesign" flag is enabled. Bug: 1009485 Change-Id: I3509725aa76ad10d2a711c7cd923af4adc6ba31c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859647Reviewed-by:
-
Jesse Schettler authored
Replace PrintMsg_ClosePrintPreviewDialog and PrintMsg_PrintForSystemDialog IPC messages with new Mojo methods. Bug: 1008939 Test: Print a webpage and PDF Change-Id: I59dd3f50f01c04debe3cb0ebd51062bc6cf597be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829467Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#705747}
-
chrome://media-appTrent Apted authored
Note that --enable-features=MediaApp and the added test still work even when gn args has enable_cros_media_app = false, but the mock app is loaded in this case (i.e. js/app_main.js is an empty file). The manifest and html served are the same regardless of enable_cros_media_app. Bug: 996088 Change-Id: I4b81f622efc874afdc53794eede8d04b69e3e3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824523Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
Jeevan Shikaram authored
This CL adds null checks to shelf related pointers within the shelf delegate. This prevents null pointer errors when the App Management page handler is created when the shelf does not exist, e.g. on the lock screen. Bug: 1011756 Change-Id: I97d3bee4daeba9a97c89ba4a91c3f736857df964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858022 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#705745}
-
Rakib M. Hasan authored
Bug: chromium:1014196 Change-Id: If433f69918658cc8336bc4f48f156e5f6e8a7f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860975Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#705744}
-
Renjie Tang authored
The data is generated by QUIC transport and has no user information. Change-Id: I001bb30a69129cdb5195c36e1ba3abc39628fd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838538Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#705743}
-
Robert Sesek authored
In Catalina, sometimes (under unclear circumstances) the NS{Open,Save}Panel objects do not go through the remote panel view system. Instead, NSOpenPanel returns a non-exported AppKit type NSLocalOpenPanel, which does not have any is-a relationship to a NSSave/OpenPanel. The type checks in SelectFileDialogBridge cause failures when this happens, so relax them. Test: `./Chromium.app/Contents/MacOS/Chromium -NSUseRemoteSavePanel NO` and go to "data:text/html,<input type=file>" in the Omnibox. Upload a file and no crash should occur. Bug: 995476 Change-Id: If57acb94ef7d92784cdb5f6e48f4ea908f2bbdce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860995 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705742}
-
Lei Zhang authored
TBR=rdevlin.cronin@chromium.org Bug: 1006634 Change-Id: Id72dd4892c52e53b7a892f6c7e0671bea65a67cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860043Reviewed-by:
-
benwgold authored
Bug: 1010708 Change-Id: I8fb61b726ffd4ac964cdbe0909689e0b15021fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856619Reviewed-by:
-
Xinghui Lu authored
Bug: 1014202 Change-Id: I2c985e1a87e9297c28d6ac10e89ceefeba0e08a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860876Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705739}
-
Yuwei Huang authored
Catalina starts making /bin/sh the responsible process of the host service script even if we don't explicitly put sh in the launchd plist file, which is bad since the user would be tempted to grant permissions to sh and effectively all shell scripts. This CL reimplements the old script as an executable so that it (remoting_me2me_host_service) can become the responsible process and we can fallback to the old script with disclaim_responsibility in the future. We can technically launch host with disclaim_responsibility to make remoting_me2me_host the responsible process, but both of them still show up as ChromeRemoteDesktopHost on Preferences, while disclaim_responsibility uses an undocumented private API, so I prefer not doing so. The new binary is a drop-in replacement for the old script. The only change here is the removal of SIGKILL, SIGSTOP, and SIGCHLD from the signal forwarding list, as they are either not catchable or make no sense to forward. Bug: 1013692 Change-Id: I56eae7116fdc03aeb9bf754164618bcb84ae5ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857651 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#705738}
-
Darwin Huang authored
The ui/base/clipboard implementation allowed read or write for one of each PortableFormat, where PortableFormat was an enum. While only one of each clipboard format should technically be written to the platform clipboard, this also only allowed one PortableFormat::kData object to be written. The Raw Clipboard[1] feature needs to be able to write any amount of arbitrary representations to the system clipboard. Goals: - Support >1 Platform Representation in each write. - Support custom ordering of Platform Representations. - Pave the way for raw clipboard access. This CL: - Provides a way to write multiple platform representations. - Provides a maximum limit of clipboard formats registered in the browser instance, in platforms with relevant limitations. - Provides relevant conservative checks to avoid abuse. - Adds tests for writing multiple representations, verifying that multiple writes before each commit won't result in an overwrite. [1]: https://tinyurl.com/raw-clipboard-access-design Bug: 897289 Change-Id: I368d2ff0a849ae9475af3335e66c0795039342d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729965 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#705737}
-
Vikas Soni authored
Re-enable AImageReader on Qcom driver version 269.0 since few bug fixes related to memory regressions have been landed and we expect those fixes might have also fixed the crashed we were seeing with version 269.0. Will need to revert this CL if it causes crashes. Since the crashes are not reproducible locally, there is no other way to test this expect removing this driver version from blacklist and hence enabling it on ToT. Bug: 941716 Change-Id: Iaef04f2734271676b59537ade00bdbaf2db416e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860679Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#705736}
-
Evan Stade authored
This completes ScopedObserver updates for Windows, Mac and Android. iOS is the final holdout. Bug: 998625 Change-Id: I415fe2f6799fcd1631385c4a825027424d8bfc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854520Reviewed-by:
-
Lijin Shen authored
On landscape view, the tab text is not on the middle of the tab. Add tabMaxWidth to make the text centered. Bug: 1013521 Change-Id: Ic5d1b173f368c1cf3910f86c718c77aaf618bd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856848Reviewed-by:
-
khmel@chromium.org authored
This exposes test API to start, stop and get tracing results for active ARC app. TEST=Unit/browser tests, + test prototype BUG=b:141885826 Change-Id: I3870e724108098ebac47f97b08323f341e6ffe80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854790Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Toni Barzic authored
The app list item focus ring is painted using stroke width 2, within bounds specified by AppListConfig::grid_focus_size(). This fixes discrepancy between what app list config specifies and what actually gets painted using stroke width 2: * the bounds were painted so the stroke was centered on the focus ring bounds * app list config specifies the outer focus ring bounds For kMedium and kSmall app list config (where the top focus ring bounds match the app list item bounds), this caused the top focus ring to be painted using width 1 instead of required 2 (as the upper part of the ring stroke was clipped by the app list item bounds). This updates the focus ring bounds calculation in AppListItemView to account for the stroke size - the target focus ring bounds are inset by half the ring width. BUG=1014128 Change-Id: Ib605afdc4312214a2a6d6c7c46251dd6fbe46000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859578 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by: -
Matt Jones authored
This patch removes the custom dialog suppression logic in the premissions manager over to ChromeActivity (temporarily) where it can be used by all dialogs. While the bottom sheet is showing, no dialog should be able to be displayed. To support this change, the TokenHolder utility class has been moved from *fullscreen/ to the ui directory where it can be used by the ModalDialogManager. This was done as there are a number of features that individually want to enable or disable one or more types of dialog temporarily. The added token system prevents them from conflicting. This change was made to remove a dependent of getBottomSheet on ChromeActivity. Eventually the logic added to ChromeActivity will live in the RootUiCoordinator. Bug: 986310, 1002277 Change-Id: I727e61c036649d088584be6ebf54a68254998aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816186 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
John Delaney authored
This CL adds intervention reporting to the heavy ad intervention. An intervention report is generated in the root ad frame and every child frame that is going to be unloaded by the intervention. This CL adds a new function SendInterventionReport() on the blink Frame mojo interface which is exposed by the public RenderFrameHost interface. In the browser process, we call SendInterventionReports on all frames in the subtree that will be unloaded, then load the error page. Because navigations are handled via mojo on the same message pipe as SendInterventionReports for each renderer, we are guaranteed that intervention reports are queued prior to the unload event being dispatched on each frame. Bug: 1003395 Change-Id: If0e8db49dc84b7ec48b6d8c8780361f372df074f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783300Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705730}
-
Wenbin Zhang authored
Some of the timing data files under src/tools/perf/core/shard_maps/timing_data are no longer in use. This CL will simply removed those files. For those being removed, I've verified that no corresponding _map.json files exists. Bug: chromium:1013767 Change-Id: Iedbc01884d4e115d63ad8b044e8d7100716ce199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857643Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#705729}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/da1f90aa77b4..e7b5c5e99289 git log da1f90aa77b4..e7b5c5e99289 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 jmadill@chromium.org Metal: Use -weak_framework to support OS 10.10. Created with: gclient setdep -r src/third_party/angle@e7b5c5e99289 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:1014228 Change-Id: Ia3b8f0ed48d8ea1d32d6258dfd2fd78faa0182fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859885Reviewed-by:
-
Yusuf Ozuysal authored
This reverts commit 14f7eff8. Reason for revert: Crashes on Canary with voice input Original change's description: > [StartSurface] Add long press behavior for the fake box > > This CL is based on > https://chromium-review.googlesource.com/c/chromium/src/+/1824554/3 > > It is the fourth patch of splitting the bigger one > https://chromium-review.googlesource.com/c/chromium/src/+/1797069 > > It also unifies the record of the 'Android.OmniboxFocusReason' metrics. > > Screenshot: > https://drive.google.com/file/d/1YlxcF40SYtGVj9K0YgviQtnt5tdGFm-m/view?usp=sharing > > Bug: 982018, 1012275 > Change-Id: I16d045777164d49d72356af474e5c186c8318370 > Binary-Size: crbug.com/998206 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824126 > Commit-Queue: Ganggui Tang <gogerald@chromium.org> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705264} TBR=yusufo@chromium.org,gogerald@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 982018, 1012275, 1013943 Change-Id: I4a48866d15dc65e8f939fe1c86867754eea87604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860598Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705727}
-
Lijin Shen authored
Chrome will crash if we select some bookmarks and then add them to their parent folder. This CL is trying to fix that. Bug: 1012651 Change-Id: I164de82a84bf922c5acdcea560a033291856708d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850418Reviewed-by:
-
Yusuke Sato authored
This will fix DCHECK failures on eve-arcvm. BUG=b:142144019 TEST=ARCVM starts even with dcheck_always_on = true Change-Id: I21755f2dd27fe3041fe3728355870703011b1092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860883 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705725}
-
Lei Zhang authored
The test is flaky. TBR=sebmarchand@chromium.org Bug: 1014282 Change-Id: I5b0f151426a8463b750fe99dafe0f271d7fc02ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860978Reviewed-by:
-
