- 18 Nov, 2020 40 commits
-
-
Maksim Ivanov authored
Extend the chrome.certificateProvider API to support the RSA-PSS signature algorithms. This makes it possible to use this API with TLS 1.3 - for example, for using a smart card middleware extension for authenticating on a website via a smart card (once the extension gets migrated to support this new algorithm). Fixed: 792204 Change-Id: I863b7fac59344f69788820a579f3ef8cdfeb9cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545925 Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#828892}
-
Nina Satragno authored
virtual/gpu/fast/canvas/canvas-composite-shadow.html is flaky. Mark as such. Tbr: sugoi@chromium.org Bug: 1150518 Change-Id: I0ee14f9d8f4c38fe4c61cc0cd1e697f4e8249f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547391Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#828891}
-
Sebastien Lalancette authored
The current EarlGrey version has the fix for the original issue. The test hook is no longer required. Bug: 1129058 Change-Id: Idf287df68d149c57f26b3e01e2936dc210acec82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544806Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#828890}
-
Keishi Hattori authored
There is a member pointer to the TestCase fields. The rewriter can't rewrite them so we need to exclude them. Bug: 1073933 Change-Id: I576722aebc59310f2bc7c9a8788c57a6a4e739d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545323Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828889}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605700503-b63c9b13eb8ce76349ecd0eadd611ab4ead01971.profdata to chrome-linux-master-1605722062-63dbc729233b875bed4d9f1fa158097610c580cf.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7d6994a984d01b2d9bc3dda400c2a50ca1b200f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547111Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#828888}
-
Peter Kasting authored
Bug: none Change-Id: Idb6a5aef372726171389074bf216ef9000e715f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533285 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Fix matcher for constructors via an implicit cast so it matches implicit constructor call where the function accepts a reference. Change-Id: I2e94d7d05536012a24a42fd30e28c7535f1f2ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545851Reviewed-by:
-
Devlin Cronin authored
Allow ScriptExecutor to support multiple frame IDs being specified. If multiple frame IDs are specified, the script will be injected into each, returning only when all are complete. If INCLUDE_SUB_FRAMES is also specified, the script is injected into all frames that are a subframe of any of the specified frames. Add browsertests for the same. Bug: 1148878 Change-Id: I8ba90348a9a55e08972576aeb6ff477a5b39d9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533412 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#828885}
-
Saurabh Nijhara authored
The browser tests related to promotional tabs policy are moved to a separated file. Bug: 1149938 Change-Id: Ie7574d9e8a9eafed7a0b07f2bd5857a003bc7d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544643 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#828884}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605657601-548324a0b0ab154da49d0cf44438a7e310772c46.profdata to chrome-win64-master-1605700503-d95dd16f6b81bc506b282993a455cc1291c6d3ef.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic70931d9e0f3edfe8b1871bcf33d27c83fb5c39a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547147Reviewed-by:
-
Eric Willigers authored
ComputeMultipartBody is now in components/web_share_target. This allows it to be used on Desktop as well as Android. Bug: 1125880 Change-Id: I63672ab4c59760e5dafe6b47d02e6848275dec67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539218 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828882}
-
Josh Karlin authored
Switch from 'sqlite_master' to list the names of tables to 'sqlite_schema'. Bug: 1097286 Change-Id: Id2a7bfac2b5d12a4169fa350293c140b4f14578f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544024Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#828881}
-
Omar Morsi authored
This CL adds unit tests to test the behavior of SystemTokenCertDBInitializer::GetSystemTokenCertDb when system token initialization fails/succeeds. Bug: 1068548, 844022 Change-Id: I2d7a0d5dabc74e768ed77f32ddfe48132ca6aa6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544569 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#828880}
-
Phillis Tang authored
Rename field trial param for site engagement threshold to have a "x_" suffix so that it won't be parsed by IPH feature engagement tracker. fieldtrial params are parsed by feature_engagement::Tracker to apply configurations generic to IPH framework. For PWA install IPH we implemented custom logic on top of IPH framework to only show IPH when site engagement score is above X. According to IPH doc https://chromium.googlesource.com/chromium/src/+/master/components/feature_engagement/README.md#featureconfig if a non IPH predefined field is specified without "x_" it will be recorded as FAILURE_UNKNOWN_KEY in the InProductHelp.Config.ParsingEvent histogram. Bug: 1150502 Change-Id: Id72ccfaa7855052ed8ad3010ae1c6c87ef5cf7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545261 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#828879}
-
Daniel Cheng authored
Change-Id: I1116d41985a070cc00056205edb5aa7fcf0a9713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547629Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#828878}
-
Friedrich Horschig authored
Bug: None Change-Id: Ia849b221bae0d3ad316f3c7c9e0b4f27cdd1cb70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547681Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#828877}
-
Edward Lesmes authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //chrome. Bug: 1113033 Change-Id: Iece38e6a64fe06e058bdece48ece4f6428e42fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544863Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Cr-Commit-Position: refs/heads/master@{#828876}
-
Andrew Grieve authored
Reworks several things: * method_count.py now exposes a DexStatsCollector and can take an .aab as an input. * DFMs now report normalized size * DexCache metric now diffs based on min_sdk_version to account for it being smaller on Oreo+. * Trichrome's "Combined_unique methods" no longer double-counts methods that exist in the various APKs. * Fixed a couple files being treated as unrecognized: * assets/icudtl_extra.dat * assets/webapk_dex_version.txt Tested by running //tools/binary_size/diagnose_bloat.py locally with a flag flip for enable_chrome_module=true. Result: +330,788 bytes other lib size +568,824 bytes main dex size +992,148 bytes normalized apk size These results look correct to me. Chrome module does increase size currently. Binary-Size: Changed metric (not a real regression) Bug: 1143687 Change-Id: I8a073d2492b3ff675dc6636cbded5f501763c3aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542803Reviewed-by:Samuel Huang <huangs@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#828875}
-
Mason Freed authored
The [1] CL moved many flaky-timeout WPT (and non-WPT layout) tests over to SlowTests, with the expectation that many of them just needed more time. The WPT tests within this set should now be marked via the <meta name=timeout content=long> to benefit other implementations. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2538144 Bug: 1095379 Change-Id: I50a26ebf6dbf5903bdec4ebba5b7b9cc5c5379db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547627 Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#828874}
-
Nektarios Paisios authored
This patch is the first, (not user visible), fix for a bug with the reading of lines in NVDA. When the screen reader focus is in the accessibility tree for Views, such as in a context menu, a toolbar or the main application's menu, the "Read Line" command (NVDAKey+Up) doesn't always read the currently focused item. We were exposing ignored views in the accessibility tree that was exposed to platform APIs. As a result, platform specific code under ui/accessibility was building IA2 and ATK hypertext for ignored nodes, while text navigation code in the same component was trying to locate non-existent line boundaries in that hypertext. A followup patch will ensure that the names of Views that come from their contents are clearly marked as such. R=dmazzoni@chromium.org, aleventhal@chromium.org AX-Relnotes: n/a. Change-Id: I5fdae5714b10b10db3dc5b5dcf22d118f322e9e7 Bug: 1098528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435645 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#828873}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/309eb9b67205..6e44bd85f3a3 2020-11-18 heiserya@google.com Implement support for Lacros in Telemetry. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1148485 Tbr: nuskos@google.com Change-Id: I8173d8285bafab16efd206d0729413c222e6f59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547387Reviewed-by:
-
Majid Valipour authored
We are planning to start the devtrial for the new backend in the next two milestones so updating the flag expiry to reflect this. Bug: 1101050 Change-Id: Ife0ad995225169ec0e3705dfa66d1d5e3706880c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546992Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Auto-Submit: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#828871}
-
David Tseng authored
This change makes it explicitly clear that chromeos::test::SpeechMonitor is meant to be used in test code only. R=dmazzoni@chromium.org Change-Id: If2ae2d9c5cc49b33e8e580ac82298477650f2b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547761Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#828870}
-
Nina Satragno authored
Mark http/tests/devtools/persistence/persistence-move-breakpoints-on-reload.js as flaky on all platforms. No-Try: true Tbr: yigu@chromium.org Bug: 1046784 Change-Id: I6b838ff0103d7df2f4dd2fd838a5995a55614a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547881 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
-
Stephen McGruer authored
This rolls up to sha 79331586050ac939313f48167a7a26d9c2332382 Bug: None Change-Id: I37b635ad21cb9ed751209dd09d1b3fae910ebb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545065 Commit-Queue: Luke Z <lpz@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#828868}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: If26c9fd5a55e58d960d843a395ba20b2a31931e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546968Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#828867}
-
Matthew Mourgos authored
Crash can be triggered from login screen when any paste is performed and ClipboardNudgeController::OnClipboardDataRead is called. So add a check to see that the clipboard history is enabled in the current mode. Also possible is that ClipboardNudgeController::ShouldShowNudge() is passed a null PrefService*. So add a check for this being null, as well as some checks for null dictionaries. Bug: 1150168 Change-Id: I79e407f3896408af7a44aacf31f15d290c2629c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546085 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#828866}
-
Brian Ho authored
As part of the UseRealBuffersForPageFlipTest experiment, OverlayProcessorOzone now uses the primary plane's buffer directly for page flip tests [1]. This buffer is obtained via OutputSurface::GetOverlayMailbox [2] which is unfortunately only implemented for GL-based OutputSurfaces. With SkiaRenderer enabled, OverlayProcessorOzone can't extract the primary plane mailbox and skips promoting overlays at all [3]. This CL implements GetOverlayMailbox for SkiaOutputSurface by threading the corresponding mailbox from the GPU main thread back to the compositor thread via the SwapBuffers callback. Note that since GetOverlayMailbox corresponds to the *last* submitted buffer, we need to skip the primary plane in the event of a reshape because the page flip test result is meaningless. [1] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/overlay_processor_ozone.cc;l=139;drc=a44fcb321ea308b8f8d2227190a99c6cca2b79e6 [2] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/direct_renderer.cc;l=356;drc=a44fcb321ea308b8f8d2227190a99c6cca2b79e6 [3] https://source.chromium.org/chromium/chromium/src/+/master:components/viz/service/display/overlay_processor_ozone.cc;l=210;drc=a44fcb321ea308b8f8d2227190a99c6cca2b79e6 Change-Id: I88d10746ede9bdc8afa565e8a42aef27d5572e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533416 Commit-Queue: Brian Ho <hob@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#828865}
-
Xi Han authored
This reverts commit 661d737a. Reason for revert: this CL didn't fix the issue, and in favour of https://chromium-review.googlesource.com/c/chromium/src/+/2547200. Original change's description: > [Instant Start] Shows identity disc button on Start Surface. > > When Instant Start is enabled, the calculateButtonData() is called > pre-native and early exits without calling the > IdentityDiscController#ensureProfileDataCache(). As a result, the > IdentityDiscController misses the event of the onProfileDataUpdated() > and thus doesn't notify its observer StartSurfaceToolbarMediator to > update the visibility of the identity disc button. > > To fix the issue, we cache the call of calculateButtonData() from the > Start surface if it is called pre-native. When a new Profile is set, we > check if a cached request exists, and call the calculateButtonData() if > yes. Thus, it guarantees to update the button data if Profile has > updated, as well as to notify Start Surface to update the visibility of > the button. > > Bug: 1137535 > Change-Id: I3aca4434ecc74850ee226affd3c3425931cf02a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533522 > Reviewed-by: Pavel Yatsuk <pavely@chromium.org> > Commit-Queue: Xi Han <hanxi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828362} TBR=pavely@chromium.org,hanxi@chromium.org Change-Id: I942ac76741e193705c757e739a14d4cfca827ae4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1137535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546972Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828864}
-
Peter Kasting authored
This is primarily to address the case of "inf / inf", which in terms of doubles is 1, but in terms of TimeDeltas is a checkfailure. Bug: 1148774 Change-Id: Iee4d80a721915ab2251535585153d9f6e2eb7f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545026Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#828863}
-
John Lee authored
Fixed: 1145715 Change-Id: I2b5a6660b2dd09a05c24e252df384f01fe3ee49d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541746 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#828862}
-
Renato Silva authored
Fix compile error: comparison of integers of different signs: 'const unsigned long' and 'const int' in certificate_provider_apitest.cc:658 EXPECT_EQ(GetAllProvidedCertificates().size(), 1); Change-Id: Iddfb3b8b4015b0f99c337e91a11ddcc92fd9e881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547108 Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
-
Nina Satragno authored
Disable PaymentRequestShippingAddressEditorTest.AsyncData. It's Flaky. Change-Id: I468a82a404ebd93b78f6e4160577d3b690d6d5e3 Tbr: danyao@chromium.org Bug: 1150496 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547386Reviewed-by:
-
James Forshaw authored
This CL removes support for the SANDBOX_EXPORTS compile option. The feature is not tested or officially supported. It's common practice to removed unused code where possible. Bug: 610499 Change-Id: I357e8a0a531dc0cbbd263baa77441bb7f97c5585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544878 Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
-
Xida Chen authored
This CL moves the paint of the background color off the main thread. Here is the design doc: https://docs.google.com/document/d/1usCnwWs8HsH5FU_185q6MsrZehFmpl5QgbbB4pvHIjI/edit In particular, we follow the infra of paint worklet. When main thread paints, we create a PaintDeferredImage, which is a place holder that does nothing. And then we create a NativePaintWorkletInput that captures necessary info and pass it to the compositor thread. After commit, we ask the compositor thread to use the information from the NativePaintWorkletInput and paint the background color. Once the paint is done, we activate the pending tree. There is no need to add new test, as long as the current test are passing because this CL should not cause any behavior change. Bug: 1139004 Change-Id: Id487ca3c8511e620bcc652e75199f893227a50e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466140 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#828858}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d14436f82285..2e4ad365f6e4 2020-11-18 tvanderlippe@chromium.org Remove bridge files from inline_editor 2020-11-18 tvanderlippe@chromium.org Use TypeScript-authored files in inline_editor/ 2020-11-18 tvanderlippe@chromium.org Typecheck inline_editor/Swatches.js with TypeScript 2020-11-18 tvanderlippe@chromium.org Remove bridge files in elements/ 2020-11-18 bmeurer@chromium.org [bindings] Fix breakpoint not hit upon first reload. 2020-11-18 jacktfranklin@chromium.org Fix heuristic for determining external bundles in Release If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1150259 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icc477a04776447848d11ecef8bd23af00f2f0639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547141Reviewed-by:
-
Chris Sharp authored
Users can change it, so it isn't always 3 Change-Id: I71b9cb834ba79414b7590a07601b58d2edb49f39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547305Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#828856}
-
Steven Bingler authored
The ordering of columns in the SQL access statements was different from the initial schema. This CL reorders them to match. While it is possible to omit the column names and only reference them by number the code is easier to read/confirm correct by using the names. Fixed: 1149659 Change-Id: Ia60848f5d3b5940b5f283448911ce426271c7328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542943 Commit-Queue: Steven Bingler <bingler@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
-
Moe Ahmadi authored
crrev.com/c/2531654 made deletion of queries from the in-memory URL DB asynchronous by posting the deletion task to a sequenced task runner on the UI thread. The said CL was later reverted in crrev.com/c/2532543 for making RepeatableQueriesServiceTest.SignedOut_Deletion flaky. This CL fixes the flakiness by providing a way for the tests to flush the scheduled tasks after deletion from the in-memory URL DB and TearDown() Bug: 1148612 Change-Id: I3f5c7b598a5d6907794b9d6ca1598626156516c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536355Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#828854}
-
Omar Morsi authored
This CL handles cases when TPM initialization fails and system token certificate database was requested. It handles this case by introducing a five-minutes-timeout for the database request. Bug: 1068548, 844022 Change-Id: If738218f7816aa9af931fa23c85da39012b86b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410377Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
