- 09 Jan, 2020 40 commits
-
-
Tommy Steimel authored
This CL switches the kaleidoscope browsertest to JavaScript Bug: 1026732 Change-Id: I35463113733460f24ebd1025420c94e9d8443825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993629Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#729894}
-
Fernando Serboncini authored
Change-Id: Ie841d2cf24be16f9a744b0a76bd35130a9d8ef10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993401 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#729893}
-
Greg Thompson authored
BUG=1037237 R=proberge@chromium.org Change-Id: I1af2a700fe4d3922f9a16e3068b8b73f09980a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986075 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#729892}
-
Yao Xiao authored
Bug: 1037382 Change-Id: I3ce638552ab44050af8bdd3083a42a5879c0c537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991748 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#729891}
-
Matt Reynolds authored
This CL modifies the return value from navigator.hid.requestDevice to return an array of HIDDevice objects instead of a single HIDDevice. If the device chooser is canceled without making a selection, the promise is resolved with an empty array instead of rejecting with a DOM exception. The HID device chooser has also been modified such that each item in the chooser represents a single physical device. If multiple logical HID interfaces are exposed by the same physical device, granting permission to access the single physical device grants permission to access any logical HID interfaces hosted by the device that satisfy the chooser filters. BUG=1036439 Change-Id: Ib67b71bcee32e261d3c9425cfc8bd7173f4ebb8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966496Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#729890}
-
Oystein Eftevaag authored
This reverts commit c6d81bfc. Reason for revert: Broken again. Original change's description: > Revert "Disable v8.browsing_mobile/browse:news:nytimes:2019 on android go & nexus 5" > > This reverts commit 5be23f11. > > Reason for revert: The CL that caused problems has been reverted. > > Original change's description: > > Disable v8.browsing_mobile/browse:news:nytimes:2019 on android go & nexus 5 > > > > NOTRY=true > > TBR=crouleau@chromium.org > > CC=mythria@chromium.org,ulan@chromium.org > > BUG=1039295 > > > > Change-Id: I418cf1c1be64257871972520008cf61749fa6032 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988546 > > Reviewed-by: Stephen Nusko <nuskos@chromium.org> > > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#728565} > > TBR=crouleau@chromium.org,nuskos@chromium.org > > Change-Id: Iaee18d7609fd7a54b480ab59b3dd1a3313be9be5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1039295 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985956 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728875} TBR=rmcilroy@chromium.org,crouleau@chromium.org,nuskos@chromium.org NOTRY=true Bug: 1039295 Change-Id: Iaf40d9ec4acef0aeb9ec0e809c707c8e070766aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994020Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#729889}
-
Patrick Monette authored
This CL adds an overload to WebContentsImpl::FromRenderFrameHostID() and to RenderFrameHost::FromID() that takes in a GlobalFrameRoutingId instead of taking in a pair of ints. This makes those functions easier to use when the caller already has a GlobalFrameRoutingId instance. Change-Id: I1fd7acf816d5f48b792f69d21007a302317f5cea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988729 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#729888}
-
Haiyang Pan authored
This reverts commit 4276efd8. Reason for revert: The CL https://crrev.com/c/1988925 offers the same result in a better way Original change's description: > android: Add logging for local instrumentation test run to help debugging > > Currently the builder test-n-tablet has flaky test failure due to timeout in > apk installation. > Adding logging to see which apk spent the most time. > > This CL can be reverted after the issue 1004322 is resolved > > Bug: 1004322 > Change-Id: Ic51694add3666aa0e0442cb6f8c11131e04ae13d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859904 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#706212} TBR=bpastene@chromium.org,jbudorick@chromium.org,hypan@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1004322 Change-Id: I4157e86800050f8ac051678e22224a4618118484 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993444Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#729887}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/368d39c30c42..f6a6a4162f28 git log 368d39c30c42..f6a6a4162f28 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 bclayton@google.com SpirvShader: Move extension list out of for loop. Created with: gclient setdep -r src/third_party/swiftshader@f6a6a4162f28 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Id02f1b5bf63bf0c6d72a8616406146f8f149719a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993583Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#729886}
-
Jack Lynch authored
This CL fixes tests that will be broken by https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891267 Bug: 963183 Change-Id: I009b29a449d76d2a147fd32bb72bf8b2d4e5ebc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636716Reviewed-by:
Robert Paveza <Rob.Paveza@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#729885}
-
sebsg authored
This reverts commit de763ddc. Reason for revert: Causing consistent build failures on https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-cfi-thin-lto-rel See crbug.com/1040636 for more info. Original change's description: > Implement DWARF Fission support in Chrome Android. > > - Modify some compiler build definitions to allow symbol_level=2 with > Chrome Android 32bit, and to make the build respect use_debug_fission in > those cases. > - Modify "link" and "solink" tools in Android toolchain so that DWP > files can be generated for builds with use_debug_fission. > - Modify partitioned_shared_library template/script so that DWP files > can be generated for partitioned libs when use_debug_fission is set. > > Change-Id: I85b755302976d9675ef00c5a79f5184ecc8dbd4b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975081 > Commit-Queue: Nelson Billing <nbilling@google.com> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729858} TBR=thakis@chromium.org,agrieve@chromium.org,scottmg@chromium.org,nbilling@google.com Change-Id: I3f3e446ba7ce07034301663af4d2cf0b5cd95982 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993901Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#729884}
-
Gabriel Charette authored
Bug: 1039833 Change-Id: Ib37fd30a9fb47c3e85787e8d249ec2491c40030e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989996 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
-
Chase Phillips authored
As part of addressing a problem with corrupt cache entries, this test verifies that the initial cause of the issue is fixed: cached HttpResponseInfo instances should have a valid request and response time. The original problem resulted in these values being set to their default values (year 1601 on Linux). I verified directly that commenting out the fix in appcache_update_url_loader_request.cc caused this new test to fail. Bug: 989611 Change-Id: I338446b18007ac3cda3e1cd2b5e2cc7a1da6efb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992350 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#729882}
-
Koji Ishii authored
Change-Id: Ic51da64e6dbfb30de6cb4f47ea7fbeb1fbbdd97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993063Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#729881}
-
kylechar authored
SkiaOutputSurfaceImplOnGpu::num_readbacks_pending_ isn't decremented when readback is complete. CheckReadbackCompletion() will continue to run periodically even when there are no pending readbacks as a result. Bug: 1022495 Change-Id: I636d83db87bcad0debbf3098d25023d88e5947b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993392 Auto-Submit: kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#729880}
-
Koji Ishii authored
This patch changes |NGInlineBoxFragmentPainterBase:: ComputeFragmentOffsetOnLine| to support |NGFragmentItem|. It used |NGPaintFragment|, but did not crash when it was null. Fixes e.g., fast/inline/inline-box-background.html Bug: 982194 Change-Id: I99abff4e4a2319151870d1283681d1d957c6d3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993363Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#729879}
-
Jack Lynch authored
This CL fixes tests that will be broken by https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1891546 Bug: 963183 Change-Id: If58c767086ea176c430cf764fe9245312ebc6ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721843Reviewed-by:
-
Stephen Martinis authored
They don't need to be in the test_suite_exceptions file Change-Id: I727e160cb66775ef3e368166cc13ae7aa9eb41a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984706Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#729877}
-
chrome://extensions-frameDemetrios Papadopoulos authored
Bug: None Change-Id: Ibf3299e2487b3796e12569b21362c751426e2ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992695 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#729876}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ae4bbcda1a91..ce9e11f02436 git log ae4bbcda1a91..ce9e11f02436 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 hypan@google.com Use --no-streaming option when installing app on certain devices Created with: gclient setdep -r src/third_party/catapult@ce9e11f02436 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1004322 Tbr: oysteine@google.com Change-Id: I651c74aeaa20daf3e35ea8da0d252d573cf2185f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993394Reviewed-by:
-
Erik Jensen authored
On Windows, ToUnicodeEx returns ASCII control characters for certain functional keys. E.g., escape returns 0x1B. This change translates such control characters to the corresponding key function instead of reporting the keys as (unprintable) chacter-generating keys in the layout. In addition, this change checks for known, possibly redundant keys and removes them for a cleaner layout. E.g., if Backslash and IntlBackslash happen to generate the exact same characters for the current layout, only Backslash will be included in the layout sent to the client. Bug: 1026029 Change-Id: Ia261e5ca3baa86b16bba7a4bc6926b5d81c33c85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975296 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#729874}
-
Xida Chen authored
This CL adds a gpu pixel test for off-thread paint worklet, which contains basic draw and transform operations. This test serves as preventing regression before shipping off-thread paint worklet, it also ensures that we would get consistent results cross platforms. Bug: 829967 Change-Id: I0597213905630b84391157b134982a19b2215cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992311Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#729873}
-
Jimmy Gong authored
- This is another step in removing deprecated printer settings code. - This removes unused dialogs. - Adjusts browser tests to reflect this change. Bug: 1005905 Test: Browser tests Change-Id: I674f4436c4bd17351ff9db2c98e8602dd229ca96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939957 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#729872}
-
Miguel Casas authored
This CL: - Adds a media_gpu_cros target, with the appropriate folders to watch and directed to the similarly named mailing list. - Takes the chance to rename other similar variables, |media_win| and |vaapi|, so they start with media_gpu_ and are therefore grouped together. Tested it with statements like: ~/p/depot_tools/watchlists.py media/mojo/clients/mojo_video_encode_accelerator.h ~/p/depot_tools/watchlists.py media/gpu/h264_decoder.h to verify it. Change-Id: I790a88bf109137a7119a164fa98b0c754e342f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993143Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#729871}
-
Chase Phillips authored
This change updates the IfModifiedSinceUpgradeParserVersion1 test to use the new cache helper. There's no expected change in functionality for this test. A later CL will add another test to verify the 304 behavior for multiple cached resources (not just the manifest) based on this test's new structure. Bug: 989611 Change-Id: I6984632694efa2fd17d100281416890800e93990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990252 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#729870}
-
Christopher Grant authored
DFMs use explicit JNI registration for both Chrome and Monochrome, but the feature shouldn't care which it's in. Traditionally, JNI registration has been done based on APK targets, but we can also point generation at an Android library. Do that here, and also, tweak the JNI generation template to allow exclusion of transitive deps. For a DFM, this means we can generate JNI only for a module's entrypoints, without pulling in methods from the base module or other unneeded deps. This seems cleaner, and also allows this change to work in component builds. Bug: None Change-Id: I3f3f457815a7e2f06f575f72476cc4c877741c7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992694 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#729869}
-
Ben Kelly authored
Bug: 913107 Change-Id: Ie5f5360e8d8c31bbd5b54f739266f5ac0f7038f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991411Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
-
Mitsuru Oshima authored
This will make window dragging in tablet mode smoother. I'll convert splitview code in a separate CL. Bug:1031927 Test: manually tested on slate. Change-Id: I99f28c6239e31cbd8556ce9e5fd18a01fab50b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987580Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#729867}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b92d20526b83..797d74a266bb git log b92d20526b83..797d74a266bb --date=short --first-parent --format='%ad %ae %s' 2020-01-09 ehmaldonado@google.com vpython: Specify interpreter to run. Created with: gclient setdep -r src/third_party/depot_tools@797d74a266bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1036606 Tbr: agable@chromium.org Change-Id: I62f011bf09a60291f27f05f110b617a805efacaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993580Reviewed-by:
-
Willie Koomson authored
This change adds startTracing()/stopTracing() functions to the autotest API to allow Chrome tracing to be started/stopped from tests. tast test Test: startStopTracing browser test; manually tested by using API in Bug: b:145813709 Change-Id: I636bb8aa4c8bdaaa144ecfd4160a74d43ac404fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989883 Commit-Queue: Willie Koomson <wvk@google.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#729865}
-
Henrique Nakashima authored
Some SharedPreferences keys used in the past are dynamic. For example, in PaymentPreferencesUtil, keys of the format "payment_instrument_use_count_[type]" are generated. These keys should be usable by SharedPreferencesManager, which will only allow whitelisted keys to be used. This CL creates a whitelist of dynamic key prefixes grandfathered in because they do not follow the format "Chrome.[Feature].[KeyPrefix].*". Bug: 1022108 Change-Id: Iaf9ebf170c339cc4b6d13705d515c97eef9087cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981262 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#729864}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/caa32a553682..63dded1f4d55 git log caa32a553682..63dded1f4d55 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 fmayer@google.com Merge "Import what you use." 2020-01-09 fmayer@google.com Merge "Remove dead code." Created with: gclient setdep -r src/third_party/perfetto@63dded1f4d55 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I853632adb2a8d84b68d19dc0ff0d610727bd7893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993581Reviewed-by:
-
Toby Huang authored
Add tip about @{u} as short-hand for the upstream branch when trying to squash commits using `git rebase -i @{u}`. Bug: None Change-Id: I8b06ccdb976fdfe84eac858d3871fac8f85c2f74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993498Reviewed-by:Aga Wronska <agawronska@chromium.org> Commit-Queue: Toby Huang <tobyhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#729862}
-
Chase Phillips authored
Originally, the AppCacheUpdateJobTest was only concerned with testing that manifest fetches and the headers that were returned matched expectations. That was because the update job tests weren't verifying anything about the fetch process for cached resources. Unfortunately, the 304 response handling for cached resources isn't correct which led to a series of bugs where any cached resource that gets a 304 response can go stale when it could instead have had its lifetime extended by the server. This, coupled with a bug where the request and response times weren't saved at all led to a bunch of corrupt resources in AppCaches. This CL extends the interceptor in AppCacheUpdateJobTest so it can handle monitoring multiple resources, not just a single manifest resource. A later CL will add a test which captures a full cache request and response cycle and monitors multiple resource fetches. Bug: 989611 Change-Id: I486d11f5be187f76e2ab2bf2c0f931c3efa9d7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989002 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
-
Peng Huang authored
In some cases, device can be lost with vulkan. This change supports context lost with non-gl backends. However on Android, the GPU is not running in a separate GPU process, when the context is lost, we need to fallback from non-gl backends to gl or sw backend. It is not implemented right now. Bug: 1038107 Change-Id: I5b1a0c9380c6ad3b995bf602a4e7787360f2993f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980185Reviewed-by:
-
Connie Wan authored
See screenshots in attached bug. Bug: 1027483 Change-Id: Ibce801813480d49ffe856fb095d260c1e56213cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990423 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#729859}
-
Nelson Billing authored
- Modify some compiler build definitions to allow symbol_level=2 with Chrome Android 32bit, and to make the build respect use_debug_fission in those cases. - Modify "link" and "solink" tools in Android toolchain so that DWP files can be generated for builds with use_debug_fission. - Modify partitioned_shared_library template/script so that DWP files can be generated for partitioned libs when use_debug_fission is set. Change-Id: I85b755302976d9675ef00c5a79f5184ecc8dbd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975081 Commit-Queue: Nelson Billing <nbilling@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#729858}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a88cab1ad9f2..8d3c0c7a1a60 git log a88cab1ad9f2..8d3c0c7a1a60 --date=short --first-parent --format='%ad %ae %s' 2020-01-09 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-01-09 bsalomon@google.com Allow implicit conversion from GrSamplerState::Filter to GrSamplerState Created with: gclient setdep -r src/third_party/skia@8d3c0c7a1a60 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jvanverth@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: jvanverth@google.com Change-Id: If357d636fa8c7cbc5b2c8b0894486a22e82c31c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993494Reviewed-by:
-
Aaron Gable authored
We support changing Visual Studio versions with the `--ide=vs2017` flag to `gn gen`. The default version is now VS2019. Bug: 1038364 Change-Id: I4de7849aab72bfdf1a4ba7465858816500abf122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984705Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#729856}
-
danakj authored
The terminology was defined around never Showing a RenderWidget to the user and thus not compositing it. However visibility is now split between Widgets (show for compositing) and Views/Pages (show for blink timers/js). And since we plumb this bit through RenderView creation and store it there, it becomes ambiguous. This renames it throughout to be more clear that it is about compositing (ie RenderWidgets) and not about page visiblity. R=avi@chromium.org, dcheng@chromium.org TBR=sky Bug: 419087 Change-Id: Ic95d7c0eae473d5a1adfc369fd88272471f6fafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992343 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#729855}
-
