- 18 Jun, 2020 40 commits
-
-
Hans Wennborg authored
38f6034998cc fuchsia: add invtsc to qemu command line 032f1aecc2ee Include-what-you-use related to logging.h Bug: 1031540 Change-Id: Iad420a52c15da204f52b1594522889c59de8f052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252139 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#779852}
-
Bartek Nowierski authored
The latest rewrite attempt revealed a couple more classes of compiler errors, that would be hard to handle automatically in the rewriter. We also found culprits for a bunch of run-time errors related to pointers being assigned invalid address with tops bits set. Bug: 1069567 Change-Id: Id8713344e602a2d995d2464a925f2892466a1652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249270 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#779851}
-
Ben Blake authored
Change-Id: Idf090e8c108c54dac39ca34e43967ad62ef432a0 Fixed: 1010212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248640Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Siyu An <siyua@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Ben Blake <fiorito@google.com> Cr-Commit-Position: refs/heads/master@{#779850}
-
Kyle Horimoto authored
This CL adds search tags for non-split sync settings when the split sync flag is disabled. Fixed: 1091061 Change-Id: I59848a1128ff6115df477918281171f3a00f1769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251170Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#779849}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/55ac3e87d96a..0ca3d7910867 2020-06-18 almuthanna@google.com Add tests for breakpoint scenarios If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1091116 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I301dc21d5975a4de43ecbccf40a02d6d249e7913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779848}
-
Matt Menard authored
Reports app info activity up to the current time instead of to the end of the previous day. Account for concurrent states in app instance updates. Give better messages for app activity matchers. Bug: 1058453 Change-Id: I06274894768eb5a5c222fcfdea0bce903dc512f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249271Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Matt Menard <mattme@google.com> Cr-Commit-Position: refs/heads/master@{#779847}
-
Kyle Ju authored
Fix importer failure due to flaky failures on external/wpt/webaudio/the-audio-api/the-audiocontext-interface/processing-after-resume.https.html Bug: 1096493 Change-Id: Ib9448cc50974b6d19df8cbc4e5cc7a178e619ffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252298Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Kyle Ju <kyleju@chromium.org> Cr-Commit-Position: refs/heads/master@{#779846}
-
Vasilii Sukhanov authored
reminder. The bubble appears after save/update password bubble reminding the user about the remaining issues. Bug: 1049200 Change-Id: I289938d66911453fce34923bf9db2b7515bc29d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249937 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#779845}
-
Dominique Fauteux-Chapleau authored
The max time increases from 10 seconds to 6 minutes to get a better view of the worst times for this metric. This is achieved by replacing the histogram with SafeBrowsingBinaryUploadRequest.TimeToGetFCMToken Bug: 1094398 Change-Id: Ied5c9d53de67e349096b240f5f83b9f2f9441e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243596 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#779844}
-
Dana Fried authored
Fixes a bug where a clipped favicon was sometimes visible in a collapsed tab even when the tab is collapsed. Tabs which are in collapsed groups *and* which are zero-width (so not counting tabs which are animating to or from the collapsed state) now cause TabStrip::ShouldTabBeVisible() to return false. Bug: 1094051 Change-Id: Ie696a6e8442f6a4a761b7dee279da2e1a96ea1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251738 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779843}
-
Alexander Timin authored
Some users might want to pass NullRemote if they are not interested in observing cookie-related notifications. The network service already supports null remote, so update the mojom to reflect that. R=kinuko@chromium.org BUG=1095600 Change-Id: I8be8a319a6b06d18400c05b3d452fec44b20f024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250064Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#779842}
-
Andre Le authored
Add CHAR_LIMIT attribute to strings used in Status Tray. BUG=1082967,1076307 Change-Id: Ia6819ab8c40563fb81dc9695eb15069819a6be84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250998 Commit-Queue: Andre Le <leandre@google.com> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#779841}
-
Scott Violet authored
This changes RemovePositionedObjects to remove any fixed-pos descendants. This ensures that if the removed object is added back, it doesn't end up after any descendants, which would cause out of order layout. BUG=1092887 TEST=webkit-box-fixed-position-child.html Change-Id: I41f01bad74048cf4983f0dda5fe0f073b3eb38f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248136Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#779840}
-
Antonio Gomes authored
.. instead of WebMediaStreamTrack. This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=407136 R=guidou@chromium.org Change-Id: Ibc60f16f8aab681fab91b5fff9b5c7b004d49607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248160 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#779839}
-
David Jean authored
Bug: 956511 Change-Id: I3f64f693d26d0db9f54f84ef7e2a36fa713434d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247764 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#779838}
-
Victor Hugo Vianna Silva authored
crrev.com/c/2246157 is suspect of causing failures in CrSettingsPasswordsSectionV3Test. This could be caused by click events in the new tests not being flushed, so this CL adds missing flush() calls. Bug: None Change-Id: I3abff7ddb894aa4a3cb3f7cf0dd2a06c7f05ec73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252138 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779837}
-
Daniele Castagna authored
SurfaceAggregator has an option to output only quads that intersect the damage rect computed by SA itself. crrev.com/c/2205886 re-enabled a SurfaceAggregator optimization for GLRenderer but left it disabled for SkiaRenderer/ This patch enables the optimization for SkiaRenderer. Bug: 925181 Change-Id: I1ad90ab2ec0d3a5b5444350ffadb7c3a5f2469ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250780Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#779836}
-
Sebastien Lalancette authored
The fix is to get the root VC to dismiss our hierarchy. If we simply use the current VC then, when the pop-over is presented, only that pop-over will be dismissed (as per the UIKit documentation and as per this bug). Bug: 1093908 Change-Id: Ia576910873acec1163f54abf8012210d13e016fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241995Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#779835}
-
OlivierLi authored
Bug: 1075553 Change-Id: Ie863e35e110966efa62c4a3eaf8ac4dd4b0fa46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248072Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#779834}
-
Ali Juma authored
The WKNavigation for a committed interstitial is used in the callback passed to ChromeWebClient::PrepareErrorPage, in order to commit the associated navigation item. For SSL interstitials, this callback is called later, asynchronously. This means that deleting the navigation in didFailProvisionalNavigation later leads to a crash when attempting to access the navigation's item, in the case where the error page load is triggered in didFailProvisionalNavigation. This happens in ErrorRetryStateMachine::DidFailProvisionalNavigation when the current webview URL is a restore_session.html URL. This CL fixes this crash by not deleting the navigation in didFailProvisionalNavigation when it is for a committed SSL interstital. There is already similar logic for deciding whether to delete a navigation in didFinishNavigation. Change-Id: Ib8aabeeeca33f63b313daa0772990b8b841d462a Bug: 1050808 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248137 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Livvie Lin <livvielin@chromium.org> Reviewed-by:
-
Lucas Furukawa Gadani authored
Bug: 967204 Change-Id: I276e6f8d8bdc3d317f5ce58f138d77601ee3c878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248059Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#779832}
-
Christian Dullweber authored
The opt-in for account storage of passwords needs to be reset after password deletion is finished and committed to the sync server. Add integration test for password deletion for account storage. Bug: 1052005 Change-Id: I342f60b076a2ee0a7a8dfae0de4341b7ab684cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250186 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
-
Xiyuan Xia authored
Replace AnimationMetricsReporter with AnimationThroughputReporter to use new code path for smoothness metrics. Bug: 1021774 Change-Id: I1d15a836b43bacb80cc244a840cbe01de6f34ec6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250502Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779830}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592470587-41d382284b84615cf61150faa274f216b9eaf19d.profdata to chrome-win32-master-1592481559-cd0ac58705eebf31c71fdcab35041388ee8d8f2d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I88e2910db16e04936c763fe84c8b8a01d58a8829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251737Reviewed-by:
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/88024df12147e56b6abd66b743ff441a0aaa09a8..c17985424391fcbaaa57f733b7197c5dd3e510aa The following commits have Chromium bugs associated: 251b5169f Assert md_size > 0. The following commits have update notes: cd8f3d36f Enforce the keyUsage extension in TLS 1.2 client certs. Bug: 1092697 Change-Id: I1fe40b43b42a93a1ace5a1cf9f1671aef6665e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250885 Auto-Submit: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#779828}
-
sandromaggi authored
This adds a new method to the |TriggerContext| enabling us to check if a certain experiment is present. Bug: b/158750294 Change-Id: Ibff03efef920c2e9afad6eb0b11a071ff2fa3864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250069 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#779827}
-
Side Yilmaz authored
This CL replaces deprecated functions of IdentityServicesProvider with the newer service getters with profile parameter. Since first run flow only run in regular mode, it is safe to pass always regular profile to IdentityServicesProvider functions. Note: This CL does not make any behaviour change. Bug: 1041781, 1075562 Change-Id: Ibee67f4d13e364613ebd267c77ec2d5981b9458e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241545Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#779826}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2878b9ea5ed3..d70c25298bc8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com Change-Id: Iec854c25ab111a72a1ade0f3ebf67e2387a58dfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251735Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779825}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/57f137d71cdf..5ad9ad04a741 2020-06-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from a7112d544b2e to 99651228b238 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: Ice1c0d877358e0e8af94bae97b5163deb0e365e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251736Reviewed-by:
-
Tibor Goldschwendt authored
Previously, we nested the doodle iframe inside a chrome-untrusted iframe because web iframes in WebUIs were not supported. This is possible now. + Remove chrome-untrusted://new-tab-page/iframe as this is no longer needed. Bug: 688960 Change-Id: Ibf3b78097193c51ed05f65a89c9f14d1fbe89ba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250826 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#779823}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ef226c9565d..5b621a997903 2020-06-18 lalitm@google.com Merge "tp: remove over-cautious detection of use-after-free in iterators" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Icd792d51bf690504f8008e59ff559a94e19f8714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251731Reviewed-by:
-
Mustaq Ahmed authored
Bug: 1049456,1080997,1081277 Change-Id: Ia0958f533ade479f523f61f4225b02a883d26122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250219Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#779821}
-
Mahmoud Gawad authored
Add HTTP PATCH Mojo API support in wilco_dtc_supportd.mojom. Add the HTTP PATCH method to the list of supported HTTP methods in wilco_dtc_supportd mojo client. This enables the requester (wilco_dtc_supportd daemon) to make HTTP PATCH requests instead of receiving errors. BUG=b:159097923 TEST=Added unit test for Patch method (PASS) Change-Id: I1000067f5c3658f80c6046e4ffea9871d49d557d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247030Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#779820}
-
Colin Blundell authored
For the translate infobar WebLayer needs a couple Material Design resources. Allow these as an exception to the exclusion of material design resources in system_webview_apk_tmpl.gni, as without this allowance TriChrome (and presumably standalone WebView)-powered WebLayer crash when showing the translate infobar. I didn't detect this when landing the initial CL enabling translate in WebLayer because the default weblayer_shell build doesn't do this exclusion. Needed resources are the ones referenced here: third_party/android_deps/libs/com_android_support_design/com_android_support_design.info: "res/layout/design_layout_tab_icon.xml", third_party/android_deps/libs/com_android_support_design/com_android_support_design.info: "res/layout/design_layout_tab_text.xml", Bug: 1025620 Change-Id: I63543aaa17b45829897cee999d372aecc156d750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250109Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#779819}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8514078e455e..55ac3e87d96a 2020-06-18 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I17c42dc78ce2f586c44f7fd5ee2ba4c96a4b7280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252019Reviewed-by:
-
Side Yilmaz authored
This CL changes ImageFetcherBridge behaviour for different profiles. Today, ImageFectherBridge is singleton, so there is only one instance created for one regular and multiple incognito profiles on Android. To avoid data leak between profiles, we need to create different instances for each profile. By this CL; - Each call to |ImageFectherBridge#getForProfile| function creates an instance of ImageFectherBridge that stores profile as member variable. - Each call to any other function of ImageFectherBridge will directly hit the native services through native bridge. - Native image_fetcher_bridge is a wrapper to reach the service that belongs to the given profile. There is no member functions anymore, but all are static. Bug: 1075562, 1041781, 1083923 Change-Id: Ic96d1c8fa1a7bd093abcf8939375f8934fd3cd92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231124 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
-
Raymond Toy authored
This is the Arm/Neon equivalent of the x86/simd version of the main k-rate processing loop. The Web Audio Bench (100 runs of 10 sec) shows that we have about a 33% improvement in speed (on a Pixel 2). The difference is statistically significant. Without CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 1778 1778 1888 2013 2498 3363 2225.6 437.41 Oscillator 1388 1388 1597 2104 2427 5244 2079.37 581.86 With CL: TEST μs MIN Q1 MEDIAN Q3 MAX MEAN STDDEV Baseline 1757 1757 1863 1955 2378 3280 2164.5 424.23 Oscillator 897 897 1001 1224 1764 4068 1399.1 515.9 Manually ran the tests in webaudio/Oscillator and all tests pass. Bug: 1013118 Change-Id: I738dfc9e9f108ac6a421099c69f11aab7750605f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233003 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#779816}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/e9d517989f66..e6613e91b26e $ git log e9d517989..e6613e91b --date=short --no-merges --format='%ad %ae %s' 2020-06-16 junyer Distinguish between missing ')' and unexpected ')'. 2020-06-16 junyer Make RE2::Set and FilteredRE2 movable. 2020-06-15 junyer Herp derp. It's actually constant-time append. Created with: roll-dep src/third_party/re2/src R=thakis@chromium.org CC=mmoroz@chromium.org Change-Id: Idda604a248dd85373905c069aa0db96b9a6c396b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250476 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#779815}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a84ab4815027..581c407cd20b 2020-06-18 cwallez@chromium.org Fix TypedInteger hash compilation failure with stdlibc++ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I34be8a79c857ec2b08a1b54b373c624e27870132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252018Reviewed-by:
-
Maria Kazinova authored
FormJsTests. This is a small fix to stop tests from hanging forever in case something goes wrong. Change-Id: I334d85e97b0f290ecf011a0b8ef40e1300275aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238156Reviewed-by:
-
