- 12 Jan, 2021 40 commits
-
-
Stephen Chenney authored
Code in DarkModeFilter was applying a dark mode color filter to any painted content that had some other shader associated with it. Such shaders come from gradients, mostly, but also tiled images and some background images. This patch limits the application of the dark mode color filter shaders that are not images or paint records. The former because we should not be applying a naive color filter to images, and the latter because they should already have filters dark mode filters applied. Fixes: 1160239 Change-Id: Id7dfbf999d43d7a9f5953d1f5a5edc5a1c92fe07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622989 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#842366}
-
Keishi Hattori authored
ast_type_traits namespace was removed in https://reviews.llvm.org/D93244 Change-Id: I93b7cb789085185036f257a764afc3d6ee7c47ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612589Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842365}
-
Eugene Zemtsov authored
plus some minimal C++ code to make things compile Bug: 1094179 Change-Id: Idea9b5fec09aeb19be4748c1746178744e5991e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619621 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#842364}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/026943fd29be..53a231c0ae86 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7be859d6f99690fd6a819dc6cb4bfeb9b1d360b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623270Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842363}
-
Yoichi Osato authored
This CL disables DragMultipleTabsRightIntoGroup and DragAllToSeparateWindow on windows. TBR=sky@chromium.org Bug: 1164561, 1128774 Change-Id: I49c825f1950af449e765f0a3f2a1918b1ddfb3a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623570Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#842362}
-
Yutaka Hirano authored
- DataElement::SetToEmptyBytes and DataElement::AppendBytes are used only by tests. Remove them. - Pass base::Time by value, rather than passing by reference. Bug: None Change-Id: I50180b3dbf7292063a6221de424499f8ca907eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595761 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#842361}
-
Ken Rockot authored
Bug: 1004256 Change-Id: I77c6539836d48687d78151f947ee26fb2f0b58ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617056 Auto-Submit: Ken Rockot <rockot@google.com> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#842360}
-
Lukasz Anforowicz authored
This CL makes VerifyThatBrowserAndRendererCalculatedOriginsToCommitMatch slightly stricter - it now requires that browser-side and renderer-side have to agree whether the origin to commit should be opaque (previously browser-side origin would be ignored if renderer-side was opaque). The above is achieved by the combination of the following changes: 1. Extracting NavigationRequest::ShouldCommitOpaqueOrigin to account not only for sandbox flags, but also for network errors. Accounting for network errors in GetOriginForURLLoaderFactory allows to simplify (a bit) RFHI::ExtractFactoryParamsFromNavigationRequest.. 2. Focusing the origin calculations and checks on cross-document navigations. 2.1. Moving the VerifyThat...OriginsToCommitMatch call to RenderFrameHostImpl::DidCommitNewDocument (next to a similar check for browser-side vs renderer-side sandbox flags). 2.2. Tweaking NavigationRequest::GetOriginForURLLoaderFactory to use the last committed origin for same-document and back-forward-cache navigations. 3. Tweaking NavigationSimulatorImpl::BuildDidCommitProvisionalLoadParams to more accurately simulate the product code, by taking into account CSP headers that (through sandbox directive) end up committing an opaque origin. This new ability had to be used in one of unit tests tweaked by this CL. Bug: 888079 Change-Id: I86edbd6920a1e17abb4e1d20104c5356a4dc3ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581008 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#842359}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cf65caef0129..6f7379c80b03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yoichio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yoichio@google.com Change-Id: I36880c105b84b666583b876c6520db1e51f7568a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622763Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842358}
-
Sophie Chang authored
This is a reland of 9a33bf90 RELAND_REASON: This one got wrongly reverted. https://chromium-review.googlesource.com/c/chromium/src/+/2622582 should be reverted instead. TBR=sky@chromium.org,waffles@chromium.org Original change's description: > Componentize OptimizationHintsComponentInstaller for reuse on iOS > > This also makes the component available on incognito (which was an > oversight in previous support to have optimization hints be in incognito) > > Bug: 1154790 > Change-Id: I97a427d5af0f94fa0b5282032b8cef6ce754c81d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617866 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842267} Bug: 1154790 Change-Id: I547245f282f4088368e05f4910a414cea49b741f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622583 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#842357}
-
Wei Lee authored
There are several ways to minimize CCA: 1. Clicking minimize button on the top bar of the window 2. Pressing "<-" (F1) button on the keyboard 3. Pressing "Alt + -" on the keyboard (Default behavior) 4. (Tablet mode) Swipe from left to right (Default behavior) When handling intent, we don't want users to minimize window. We have already removed the minimize button from the window (1). In this CL, for (2) we only proactively minimize window for non-intent instance. For (3), we prevent the default behavior for intent window. For (4), we explicitly disable the corresponding window property to totally disable it. Bug: b/175322338, b/175326967 Test: Manually Change-Id: I4b4fb91ab07dcd46bb61512fe2622770c0a4c373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619249Reviewed-by:
Shik Chen <shik@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#842356}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6db1f918c5759d768083ef3b0cf17c8ec3dd9692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623469Reviewed-by:
-
Jonah Chin authored
This reverts commit 0c93bcb5. Reason for revert: An earlier change is causing a canvas video issue. This change depends on that change. Reverting both changes until the bug is resolved. See crbug.com/1164407. Original change's description: > Introduce mailbox-based version of VideoTextureBacking > > This CL introduces an OOPR compatible version of VideoTextureBacking and > updates PaintCanvasVideoRenderer::UpdateLastImage() to use this new > version in the OOPR codepath. > > More details about overall PaintImage effort: crbug.com/1023259 > Info about the OOPR-Canvas2D project: crbug.com/1018894 > > Bug: 1115217 > Change-Id: I4590cf16d6faef0e5575b0b4006ea88de89aa13d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419653 > Reviewed-by: Khushal <khushalsagar@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Jonah Chin <jochin@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#826449} TBR=dalecurtis@chromium.org,khushalsagar@chromium.org,jochin@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1115217 Change-Id: I3b1d370e7048eee9d8885651ee0e68b342340b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623174Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Jonah Chin <jochin@microsoft.com> Commit-Queue: Jonah Chin <jochin@microsoft.com> Cr-Commit-Position: refs/heads/master@{#842354}
-
Alan Cutter authored
These methods call non-trivial methods and should be moved to the cc file. Change-Id: I9b24047da4d48e90022edfc53498332bb333ec89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616644 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#842353}
-
Alexander Timin authored
Remove old-style deprecated macros and reduce confusion. R=eseckler@chromium.org,sunnyps@chromium.org,rockot@chromium.org BUG=1164298 Change-Id: Ibb827cb42b62fb0f00ae46bd082c8b4a6f17caa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617782 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#842352}
-
Honglin Yu authored
Add the "Call" postfix. TEST=compiles BUG=none Change-Id: Iddb96ff06e576be0231db154405a331375a3116e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619103 Commit-Queue: Honglin Yu <honglinyu@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#842351}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610387594-3b3bb0a15d14b239dcb6d81b73ae08ab0d827c57.profdata to chrome-win32-master-1610398040-59038019b78fe7d9277311f636fda97275a69be4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I465aa6bbda21787870788599e0a0324d14834b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623248Reviewed-by:
-
Michael Crouse authored
Current usages do not run on the trybot, this change moves the code towards compiling and running successfully. Bug: 1165517 Change-Id: Ic9f06e296b9b5c4158923c3ba37f9a307a170776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623530Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#842349}
-
David Dorwin authored
The target already builds successfully when directly referenced. Bug: 1164524 Change-Id: I54c74b87be87069c005bed8416ac307d0eb7a5c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618961 Auto-Submit: David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#842348}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b2230ba88f16..d1a3011cd912 2021-01-12 jbudorick@chromium.org Revert "devil: make devil_env_test pass under py3. (reland)" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1007101 Tbr: sadrul@google.com Change-Id: Ie136edd232910dff2ce0dd136ff562aea8f2e4dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623252Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610387594-9644082f15d83cc3788996ee889bd06710e6b3cf.profdata to chrome-mac-master-1610408110-5a618b6e0bdb5b4a60796f5aa8c6f6759f78cdd3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ieab1de1e4012865a5b23466b92c7a14ca9bdcf00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623257Reviewed-by:
-
Koji Ishii authored
Blink (legacy and NG) and WebKit does not hyphenate the last word in a paragraph, except when it is a single-word paragraph. However, when the containing block is narrow, sometimes authors want a long last word to be hyphenated. This patch changtes the heursitic to allow hyphenation if the line is a single-word line. CSS Text 4 has a property to control this behavior, but no browsers have implemented it yet. Bug: 1022415 Change-Id: Ibd8d8b132e540a142f18efc09a37fed2b207bfdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599567 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#842345}
-
Sinan Sahin authored
Clean-up work after crbug.com/1153706 Bug: 1154731 Change-Id: I27a1003541b1ce577ca28f92f0b8aa5f0705b9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622734Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#842344}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.85. R=rmhasan@google.com Bug: 1041619 Change-Id: Ic2f3c1f26f20a894982432476be04142dddac796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623198 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#842343}
-
Michael Checo authored
Screenshot: http://shortn/_gDqXwFySMr Spec: https://carbon.googleplex.com/cros-ux/pages/diagnostics/mvp/cda946b2-7a91-4b33-90ca-1e054cd986fc#ce65ba52-0b2f-4307-aab1-196fce16bc22 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ied96e5fc3601e1e47bec04d9d9c9b6bb14034dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556009 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#842342}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610387594-52fbb832db018eba5e89364d93d0a6bfe8f2e511.profdata to chrome-linux-master-1610408110-1b25c741a858a17df9d643531610232aedd2e5da.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibe737e499f7416e62f2b97ce9b21615c7dcd25e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623254Reviewed-by:
-
Song Fangzhen authored
Based on the previous CL https://chromium-review.googlesource.com/c/chromium/src/+/2603775 It is simple to support mDNS. Below documents are from Eric Willigers <ericwilligers@chromium.org>. Explainer: https://github.com/WICG/raw-sockets/blob/master/docs/explainer.md Design doc: https://docs.google.com/document/d/1Xa5nFkIWxkL3hZHvDYWPhT8sZvNeFpCUKNuqIwZHxnE/edit?usp=sharing Bug: 1124255 Change-Id: I8cce5d944b1130461df596e667fbfc99c86f54bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619408Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Ke He <kehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#842340}
-
Toby Huang authored
USER_TYPE_SUPERVISED is confusing with USER_TYPE_CHILD, especially since the former is deprecated. This CL is a mechanical change to rename USER_TYPE_SUPERVISED to USER_TYPE_SUPERVISED_DEPRECATED. It also renames other deprecated supervised user enums and functions. Bug: 1158600 Change-Id: I4d00c530a5ce3e58daa93c55dc37d68b7ddf53b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592329 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#842339}
-
Yuly Novikov authored
Previously were disabled on iOS and Fuchsia Bug: angleproject:5417 Change-Id: I3e73e11b728ebfacb8082ce90f333193cb44a3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621926Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#842338}
-
Koji Ishii authored
This patch fixes Minikin hyphenation to hyphenate words with leading and/or trailing punctuation characters, using the same logic as Minikin `WordBreaker`[1]. On Mac, the underlying Core Foundation API handles such cases. This issue is part of the reasons for the last words not being hyphenated <crbug.com/1022415>. [1] https://android.googlesource.com/platform/frameworks/minikin/+/master/libs/minikin/WordBreaker.cpp#270:~:text=WordBreaker%3A%3AwordStart Bug: 815061 Change-Id: I64908bf2000e9586b1cb7f0d28a0d730c6311da2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599789 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4f62c670fe0c..d08c55317628 2021-01-11 soxia@microsoft.com Make dual screen support default If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1ce65749e8d9313583a1f18fc14cae344a0c42ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623250Reviewed-by:
-
Collin Baker authored
Bug: 1163666 Change-Id: Ie677edd59696139abab312bc80a0c033e35b68f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613541 Auto-Submit: Collin Baker <collinbaker@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#842335}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bdc7f626dbce..026943fd29be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I55c6df99da5bb85cc6b815d34890c1510b1061b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622595Reviewed-by:
-
chinsenj authored
Currently when a window destroys, it is not removed from DesksController.visible_on_all_desks_windows_. This can cause bugs where a destroyed window is returned. This CL changes the WorkspaceLayoutManager to remove visible on all desks windows when they are destroyed. Test: manual + added Bug: 1023794 Change-Id: If2b50fe87b5356044070dfc740809f80d268c24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622396 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#842333}
-
Evan Stade authored
Bug: 1158983 Change-Id: I785176aa17e7efab7d66d45ace4e88ffecaa9eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612151 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/99c3a691c23d..ea26a8ce553f 2021-01-11 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from f51d965befa1 to c3c70f848a71 (22 revisions) 2021-01-11 cwoffenden@gmail.com Minor fix to build with MSVC: Gets content address instead of iterator 2021-01-11 cwallez@chromium.org Remove obsolete build flag. 2021-01-11 yunchao.he@intel.com Add more constants for max texture sizes 2021-01-11 senorblanco@chromium.org Add ANGLE to Dawn build. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1164276 Tbr: dsinclair@google.com Change-Id: I236814ebae3d546139caa63854d8a68883198f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623247Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/36267de97e83..cf65caef0129 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yoichio@google.com,hiroshige@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: yoichio@google.com,hiroshige@google.com Change-Id: I2bb8f6d40c211d8171395c1b9252b5cc5bb09054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622964Reviewed-by:
-
Aaron Leventhal authored
It is only safe to create an accessibility object when a document's style has been computed and layout is clean. Previously, tests failed because an extra kLoadComplete event was sometimes fired for the initial empty document, before navigating to the actual data: url with the test's contents. The extra event only seems to occur in ChromeOS debug builds. Bug: 1156939 Change-Id: I95f4afdb5471a98ed87fb1cf8e8a208e5ebfc453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611559Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842329}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bdc7f626dbce..026943fd29be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2938e7fc3d4dc85823ca8f7c12a2dd8158963cc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623162Reviewed-by:
-
Ehimare Okoyomon authored
Bug: 1158288 Change-Id: Ifa1084c6b4c606c1e0fa9900b78f44ffee60f784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586351 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#842327}
-
