- 25 Jan, 2018 40 commits
-
-
Christian Fremerey authored
This reverts commit 2e8b1501. Reason for revert: Failing tests on webrtc bots, e.g. https://ci.chromium.org/buildbot/chromium.webrtc/Win10%20Tester/24669 Original change's description: > Reland: Win video capture: use IMFCaptureEngine for Media Foundation > > Fixes for reland number 5: > - "Win10 Tester" browser_tests_functional failure > - "Win8 Tester" browser_tests_functional failure > > Fixes for reland number 4: > - "Win10 Tester" browser_tests_functional failure > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Fixes for reland number 3: > - "Win10 Tester" browser_tests_functional failure > - "Win10 Tester" capture_unittests failure > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Fixes for reland number 2: > - "Win10 Tester" browser_tests_functional failure > - "Win10 Tester" capture_unittests failure > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Fixes for reland number 1: > - "Win8 Tester" browser_tests_functional failure > - "Win8 Tester" capture_unittests failure > > Original description: > - Full rewrite of the MediaFoundation implementation video part to use > IMFCaptureEngine > - Implementation of takePhoto, setPhotoOptions and getPhotoCapabilities > - takePhoto triggers a still image capture with the highest available > resolution without stopping the video stream thanks to IMFCaptureEngine > > TEST=adapted video_capture_device_unittest.cc and > webrtc_image_capture_browsertest.cc; launch Chrome with > --force-mediafoundation on Win8+ and capture video using > e.g. https://webrtc.github.io/samples/src/content/getusermedia/gum/ > > TBR=mcasas@chromium.org > > Bug: 730068 > Change-Id: If081d29402e9f595a3fd1906e45a3bec1d712b3a > Reviewed-on: https://chromium-review.googlesource.com/734042 > Commit-Queue: Christian Fremerey <chfremer@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Cr-Original-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#521435} > Reviewed-on: https://chromium-review.googlesource.com/810766 > Cr-Original-Original-Original-Original-Commit-Position: refs/heads/master@{#524417} > Reviewed-on: https://chromium-review.googlesource.com/843974 > Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#527139} > Reviewed-on: https://chromium-review.googlesource.com/852455 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Original-Original-Commit-Position: refs/heads/master@{#528005} > Reviewed-on: https://chromium-review.googlesource.com/858138 > Cr-Original-Commit-Position: refs/heads/master@{#531109} > Reviewed-on: https://chromium-review.googlesource.com/880944 > Cr-Commit-Position: refs/heads/master@{#531791} TBR=mcasas@chromium.org,chfremer@chromium.org,alaoui.rda@gmail.com Change-Id: Idae6023d22c51e2df66687729ea0df5232c67fc6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 730068 Reviewed-on: https://chromium-review.googlesource.com/886081Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#531831}
-
Keishi Hattori authored
Rename CrossThreadPersistentRegion to CrossThreadPersistentRegions as we will be adding a second PersistentRegion for weak persistents: BUG=757440 Change-Id: I751747470c5ddc1481270e181cdd1edcf9ae5291 Reviewed-on: https://chromium-review.googlesource.com/882626Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531830}
-
Yutaka Hirano authored
Some features defined in content/public/common/content_features.h prevented us moving files from content/network to services/network. This CL unblocks that by defining such features in services/network. Bug: 754918, 804769 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I378bef8d314003530019c9e4aab01bdb2f91a2b7 Reviewed-on: https://chromium-review.googlesource.com/874980 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#531829}
-
Scott Violet authored
Classic ash doesn't do grabs when in unified mode. For compatibility this patch makes the window-service not execute a grab when in unified mode. To execute a grab leads to ash doing the wrong event conversion. BUG=804460,773348 TEST=covered by test Change-Id: I6d402ec4eb5d68946f98757cc4a56e850bd1e8b0 Reviewed-on: https://chromium-review.googlesource.com/884569 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#531828}
-
Yoshifumi Inoue authored
This patch expands |FindRightNonPseudoNodeInlineBox()| into the call site since it is used once to reduce source code size for improving code health. This patch is a follow-up of the patch[1]. The patch[2] does same thing for |FindLeftNonPseudoNodeInlineBox()| [1] http://crrev.com/c/882791 LineEndpointComputationMode to template parameter in StartPositionForLine() [2] http://crrev.com/c/885683 Expand FindLeftNonPseudoNodeInlineBox() into the call site in VisibleUnit.cpp Change-Id: I57ae8c462a3b76ee07f41f3cabd6579765ee1a20 Reviewed-on: https://chromium-review.googlesource.com/885663 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#531827}
-
Yoshifumi Inoue authored
This patch expands |FindLeftNonPseudoNodeInlineBox()| into the call site since it is used once to reduce source code size for improving code health. This patch is a follow-up of the patch[1]. The patch[2] does same thing for |FindRightNonPseudoNodeInlineBox()| [1] http://crrev.com/c/882531 Convert LineEndpointComputationMode to template parameter in EndPositionForLine() [2] http://crrev.com/c/885683 Expand FindRightNonPseudoNodeInlineBox() into the call site in VisibleUnit.cpp Change-Id: I11df57f02eaa2f7681751f299948ab0ee8da8e8d Reviewed-on: https://chromium-review.googlesource.com/885683 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Chris Nardi authored
calc() was previously unsupported in CSS media queries. This change adds in support for parsing calc() values in media queries, transitioning MediaQueryExp.cpp to use CSSParserHelpers functions instead of bare CSSParserTokens. Bug: 421909 Change-Id: I81fea4dc6c70caaab79874722f114d261c26c886 Reviewed-on: https://chromium-review.googlesource.com/884571Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531825}
-
Yoichi Osato authored
This patch moves PositionInGraphicsLayerBacking() after IsVisible(). Bug: 789870 Change-Id: Ia4c7bcd590ea36cfefc97ae3f92eca01142304f8 Reviewed-on: https://chromium-review.googlesource.com/885665Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#531824}
-
Austin Tankiang authored
Mojo InterfacePtrs need a way to be automatically revoked, so wrap them in a WeakInterfacePtr class. This class is associated with an InterfaceInvalidator class that revokes the weak interface pointer when the invalidator is destroyed. Add tests to verify that invalidation works well with the existing InterfacePtr functions. Change PingService to be [Sync] so both async and sync calls can be tested. Also introduce a new typedef for blink code, |WeakFooPtr|. Existing code will be gradually changed to use the new typedef. Bug: 800641 Change-Id: I29778b233b81eec14ffca048a70f84cc3e31fb44 Reviewed-on: https://chromium-review.googlesource.com/848432Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Austin Tankiang <austinct@google.com> Cr-Commit-Position: refs/heads/master@{#531823}
-
Timothy Loh authored
The enums PermissionAction::REENABLED and PermissionAction::REQUESTED don't seem to have ever been used, so this patch removes them. TBR=nparker Bug: 638076 Change-Id: Iadcbc6f44a8c33233b702287167baef56c807699 Reviewed-on: https://chromium-review.googlesource.com/867794 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#531822}
-
Aaron Leventhal authored
Setting an attribute to the same value it had before should never change the accessibility tree. For example, setting the role attribute to the same value, although not a recommended authoring practice, has negative consequences as the accessible object must be recreated to be safe. In general it is not necessary to update the AX tree unless the value changes. Bug: 801293 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iab61b3a9a4c30c5183046c9de073e71ab216d6cb Reviewed-on: https://chromium-review.googlesource.com/876309 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#531821}
-
Hajime Hoshi authored
media: Use per-frame task runners at WebRTCMediaStreamAdapterMap and WebRtcMediaStreamTrackAdapterMap This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: I300a38816bef6bb8f371203aaad52cb31154309a Reviewed-on: https://chromium-review.googlesource.com/882713Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#531820}
-
Khushal authored
We lock all at-raster images for the duration of a tile, which is contrary to the aim of this mode of minimizing peak memory usage. This was initially added for OOP raster potentially needing all decodes to be ready before serialization, but that is no longer the case. R=ericrk@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic6dfc54718413bc808f60eccdc36d7f43be664d2 Reviewed-on: https://chromium-review.googlesource.com/882188Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#531819}
-
Chris Morin authored
Since we will only support the mini-container start up flow, we can simplify the code by eliminating code paths which required to support launching the full instance directly. Bug: 65548422 Test: Ensure container boots and upgrades successfully. Change-Id: Ibb1c2f7af66e3f1ea7f3495f26f34b5e47a4270a Reviewed-on: https://chromium-review.googlesource.com/821650 Commit-Queue: Christopher Morin <cmtm@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#531818}
-
Ken Rockot authored
This race was introduced by r531093. It causes intermittent flakiness on mash_browser_tests runs and would probably eventually turn up with subtly broken behavior in the wild (e.g., spellcheck failing randomly). The gist is that ChromeService modifies some exclusive IO-thread state from the main thread and this can race, leaving the browser's "chrome" service Connector in a defunct state unable to reach other services. In developer builds the failure mode is a more obvious (but still quite rare and flaky) DCHECK caused by sending an invalid ConnectorRequest over a Clone() message. Bug: None Change-Id: I5776005269bef1307b7fc2225bf22cd72bb706fa Reviewed-on: https://chromium-review.googlesource.com/884577Reviewed-by:
Ben Goodger <ben@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#531817}
-
Han Leon authored
Before, we avoid sending clients back to those STOPPED/STOPPING workers via the legacy IPC ServiceWorkerMsg_DidGetClients, maybe this is in order to avoid stray IPC in the workers side. After mojofication of GetClients(), we do not need to consider stray message anymore, because we start to send clients back by running response callback of the Mojo interface method GetClients(), which is guaranteed to be safe no matter the other side endpoint has destroyed or not. BUG=772793 Change-Id: I2ae3e4ccf76bc4dc12d6312c694ab90cd7b9fcd7 Reviewed-on: https://chromium-review.googlesource.com/882348 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#531816}
-
src-internal-roller@chromium.org authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6f8e8f899c7a..8af6931d8777 $ git log 6f8e8f899..8af6931d8 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I1239268da73fec12f7ad414e35a23d3462bb4ea6 Reviewed-on: https://chromium-review.googlesource.com/885643Reviewed-by:
src-internal-roller . <src-internal-roller@chromium.org> Commit-Queue: src-internal-roller . <src-internal-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#531815}
-
Alan Cutter authored
This CL prevents animations from running on the compositor when they contain neutral keyframes and apply on top of existing animaions on the same property. Bug: 805323 Change-Id: Iba19882454211f127358b78fcbfa32bfdf183048 Reviewed-on: https://chromium-review.googlesource.com/884781Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#531814}
-
Yuri Wiitala authored
A recent change added new content_browsertests, and the tests are flaky. Root cause analysis shows it to be caused by initial instability in the content shell window size; and so the tests will have to account for that before being re-enabled. NOTRY=true TBR=xjz@chromium.org Bug: 754872 Change-Id: I8017d5d6b451eaedd7c8d9803780ffa7d67327a4 Reviewed-on: https://chromium-review.googlesource.com/885821Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#531813}
-
Giovanni Ortuño Urquidi authored
This reverts commit 6252427a. Reason for revert: Fails site_per_process_webkit_layout_tests https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/66700 Original change's description: > Add WPT tests for feature policy > > 1. Added tests for header policy. > a. document.policy shows correctly parsed policy > b. local / remote iframes without allow attribute correctly inherit > document.policy > c. dynamically update allow attribute updates the policy correctly. > > 2. Added tests for nested policies. > > Bug: 732003 > Change-Id: I869449f6bba89fc58997355df27249f403d76808 > Reviewed-on: https://chromium-review.googlesource.com/796952 > Commit-Queue: Luna Lu <loonybear@chromium.org> > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Cr-Commit-Position: refs/heads/master@{#531698} TBR=iclelland@chromium.org,loonybear@chromium.org Change-Id: I7b12b6809313f91df3f742e949439719adf8b867 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732003 Reviewed-on: https://chromium-review.googlesource.com/885741Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#531812}
-
Kunihiko Sakamoto authored
- Use SharedDesktopPageState instead of SharedMobilePageState - Re-record the story set - Disable stories that WPR could not record the page correctly Note for perf sheriffs: This is expected to affect loading.desktop benchmark. Bug: 805115 Change-Id: I60d6b455c9553bc6b7202bf9082d2a12096a981e Reviewed-on: https://chromium-review.googlesource.com/883004 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#531811}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I7def16389a4fd40bdf285207411361c596684213 Reviewed-on: https://chromium-review.googlesource.com/885303Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#531810}
-
Giovanni Ortuño Urquidi authored
Test keeps timing out on Windows and Linux TBR=alancutter@chromium.org NOTRY=true Bug: 805788 Change-Id: Id1eeb9a0c6629af693131456dc24a5dce532c211 Reviewed-on: https://chromium-review.googlesource.com/885661 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
Ryo Hashimoto authored
This hack was added in https://codereview.chromium.org/601733002. I planned to remove it after a few weeks, but forgot to do so. BUG=None TEST=build Change-Id: Ifdfadc62f4b46fedf8e0f8dca98cb6810ed278f5 Reviewed-on: https://chromium-review.googlesource.com/880541Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#531808}
-
Siddhartha authored
The histroy db tasks are run using the location of history service. But in reality they are started by various other components. Using the location from the original location is easier for tracing. BUG=803822 Change-Id: I97bc4aa03aa202903dd8346c39d3b284be078a6c Reviewed-on: https://chromium-review.googlesource.com/884725 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |LineEndpointComputationMode| parameter to template parameter in |EndPositionForLine()| to avoid runtime checking of parameter and remove unused enum |LineEndpointComputationMode|. The patch[1] does same thing for |StartPositionForLine()|. [1] http://crrev.com/c/882791 Convert LineEndpointComputationMode to template parameter in StartPositionForLine() Change-Id: I325faeeeac8abc3fb971221de047e09f4ffb2341 Reviewed-on: https://chromium-review.googlesource.com/882531 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#531806}
-
Pavel Feldman authored
We used to detach from targets aggressively because of the timing of the UpdateFrames call. Current frame host was still non-cross-process and hence was detached from. This change migrates from bulk-frame update to treating render frame host swap in AutoAttachToFrame. Bug: 805248 Change-Id: Id6c8a665676167fea5048c23db20cfc8fafd86f1 Reviewed-on: https://chromium-review.googlesource.com/882167 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#531805}
-
John Z Wu authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1b4fce16214294d93ed41beef057c8a3ba544b40 Reviewed-on: https://chromium-review.googlesource.com/881708 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#531804}
-
Tom Sepez authored
These are required when a namespace sandbox is engaged, so put this code adjacent to the namespace sandbox. Put both the client and server code for the interceptor into the same file. A few symbols have to move lower down to avoid a /sandbox -> /services/service_manager dependency. Pass the result of GetSandboxFD() at init time to avoid a /sandbox -> /content dependency. Duplicate a small bit of code to write a reply. Bug: 781334 Change-Id: I0ddaba96cc7feea3d78612219b24370e43dc90f7 Reviewed-on: https://chromium-review.googlesource.com/882281Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#531803}
-
Ryo Hashimoto authored
BUG=None TEST=build Change-Id: I57c3527fd27169ad96705d741e24daca056797a4 Reviewed-on: https://chromium-review.googlesource.com/880261Reviewed-by:
-
Matt Falkenhagen authored
This test case is covered by WPT test fetch-event.https.html, which is now passing in S13nServiceWorker. R=kinuko, shimazu Bug: 778878 Change-Id: I2d79be1c20ebd363f4ff06cbe708ce5bee287a23 Reviewed-on: https://chromium-review.googlesource.com/882787 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Tom Anderson authored
BUG=804637 R=peter Change-Id: I06611b6d8569c05dc4349121d565b645a3359c6b Reviewed-on: https://chromium-review.googlesource.com/884572 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#531800}
-
Ria Jiang authored
Bug: none Change-Id: Ic7b56e00135f5624249c84e04fd4f7dcc28057fc Reviewed-on: https://chromium-review.googlesource.com/884830Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#531799}
-
Tom Anderson authored
BUG=805488 R=dpranke Change-Id: I8a6daa7bbce3fec4eabdeae9b2e7adf7f732813b Reviewed-on: https://chromium-review.googlesource.com/885006Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#531798}
-
Tetsui Ohkubo authored
This reverts commit 53b9235c. Reason for revert: Clusterfuzz crash https://crbug.com/804108 Original change's description: > Do not close widget in TrayBubbleView for notification center. > > This is a follow-up CL of https://crrev.com/c/816778 . > > There were three code paths to close notification center: > * Only WebNotificationTray::HideMessageCenter is called. > (clicking on tray bell icon) > + TrayBubbleWrapper::OnWindowActivated is called in addition. > (pressing search button) > + TrayBubbleView::OnWidgetActivationChanged is called in addition. > (clicking on screenshot notification in notification center) > > On the last code path, Widget::Close() is called before > WebNotificationTray::HideMessageCenter(). > HideMessageCenter() assumed the widget is still open, thus the crash > https://crbug.com/792583#c14 was caused. > > The quick fix CL fixed HideMessageCenter(), but it is confusing that > the widget can be closed through multiple code paths. > This CL uses TrayBubbleView::InitParams::close_on_deactivate so that > the TrayBubbleView does not close the widget. > > TEST=manual > BUG=792583 > > Change-Id: Ibff47189719043d6ec6830f50888c8323e63f44a > Reviewed-on: https://chromium-review.googlesource.com/833429 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528866} TBR=oshima@chromium.org,tetsui@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 792583, 804108 Change-Id: I69ef7cd54a156e4de83ce04e0aa0b433ecf743c9 Reviewed-on: https://chromium-review.googlesource.com/885281Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#531797}
-
Xiaohan Wang authored
This CL connects the CdmProxy's CdmContext with the media components, e.g. audio/video decoder. If the CdmProxy is destroyed (e.g. on connection error), all the CdmContext calls will fail. Details: - Update CdmContext to support GetDecryptContext(). - Update CdmProxy to support CdmContext. - Add CdmProxyContextRef to support weak CdmContext pointers. - Let MojoCdmServiceContext generates CDM ID, to make sure there's no duplicate CDM IDs among CDMs and CdmProxies. - Update MojoCdmServiceContext to support CdmProxy. - Add MojoCdmProxyTest. - Nit: Also update MojoCdmService constructor parameter order to match other classes that use MojoCdmServiceContext. BUG=803710 Change-Id: I055e740de0e71790e364d48aca05a067b123a14f Reviewed-on: https://chromium-review.googlesource.com/877394Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#531796}
-
Khushal authored
TBR=reed@google.com Bug: 800612 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I1507687375387030a354a964c1d4b6ba5415ddd0 Reviewed-on: https://chromium-review.googlesource.com/876949 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Mike Reed <reed@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#531795}
-
Yuri Wiitala authored
Virtually all of the implementation of content::WebContentsVCD is replaced with a minimal subclass-of-FrameSinkVCD implementation. All existing testing that was a part of content_unittests has been deleted. However, most of the functionality is being tested in other subcomponents of the system now (in the VIZ world); and so the same (and more!) functional test coverage should exist. In addition, a suite of tests has been added to content_browsertests to test the behavior of this capture device when running in a full browser. Note that the --enable-features=VizDisplayCompositor flag can be added to the command line to confirm working behavior whether the display compositor is running in the browser process or GPU/VIZ process. Bug: 754872 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I8ad741aa19387f0f27bf437ebcaa71ca3730457f Reviewed-on: https://chromium-review.googlesource.com/879270 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Cr-Commit-Position: refs/heads/master@{#531794}
-
Sandeep Vijayasekar authored
Bug: 71798364 Bug: 71646628 Test: Send feedback on home app Change-Id: Iba23a4e07369a9557a8ef43c23a7f93f3184a9c6 Reviewed-on: https://chromium-review.googlesource.com/882493 Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#531793}
-
Mostyn Bramley-Moore authored
Cq-Include-Trybots: master.tryserver.chromium.android:android_arm64_dbg_recipe;master.tryserver.chromium.android:android_compile_mips_dbg;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Change-Id: I353279f5fb386971e3f4b50b98cc50d6d97207aa Reviewed-on: https://chromium-review.googlesource.com/883287 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
-
