- 06 Mar, 2019 40 commits
-
-
Yi Gu authored
We used to have will-change: transform in test reference but they are no longer needed. Change-Id: Ib6870863760e32de201a0560fa59f43634c72da8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504711 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#638107}
-
W. James MacLean authored
This CL removes a helper class, InnerWebContentsHelper, that is no longer needed since the associated bug has been resolved. TBR=alexmos@chromium.org Bug: 821187 Change-Id: I2bdbe77f995b31d727e10bd5e6a86e3d636e0cfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505834Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#638106}
-
Michael Lippautz authored
With unified heap TraceWrapperMember is deprecated and we need an alternative way to produce heap snapshots in the case (a) we are interested in JS objects, and (b) in the case we are interested in the full unified object graph. This patch provides a new way to generate the snapshot for V8 embedders and performs the following operations: - Objects are classified as attached, detached, or unknown. - Depending an implicit mode, objects are classified as relevant or internal. This classification happens based on NameTrait and the fact that all ScriptWrappable objects (those that can have JS properties) are using that trait. - Not relevant objects are filtered where possible, e.g., sub graphs of internals are filtered and not reported. The algorithm performs a single pass on the graph, starting from V8-to-Blink references that identify attached nodes. Each object then starts a recursion into its own subgraph to identify and filter subgraphs that only consist of internals. Roots, which are potentially Blink only, are transitively traversed after handling JavaScript related objects. Change-Id: I746930e0ede6b18d6942d9bfcef4950f13aea967 Bug: 936797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499567Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#638105}
-
Gauthier Ambard authored
This CL groups the private properties together. Bug: 938255 Change-Id: I27345e69ee48593c5fc30e02913b5fae95a82cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503327 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#638104}
-
Lowell Manners authored
IdentityAccessorImpl is being migrated to use IdentityManager, the new interface for external clients to Identity. Change-Id: Iad5cef7d8f4fe069516f35e17a23d6363f3533c9 Bug: 933109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499454Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#638103}
-
Kent Tamura authored
Bug: crbug.com/894661 Change-Id: I1df3af43ec2818f181eff99277c1d14c0dd3bb63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502772 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#638102}
-
dalyk authored
CT log inclusion checks use secure DNS if the associated hostname lookup was resolved securely; otherwise the CT log inclusion checks use insecure DNS. Bug: 878582 Change-Id: Iaaa47078a7278576811c70cb95430a6e116c6c04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1480547 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#638101}
-
Richard Townsend authored
Makes LapTimer (which provides a runs per second figure) accessible to base_perftests benchmarks by updating it and moving it into base/. Bug: 908966 Change-Id: I7913ea8e37b04d5309bed577dbdc54d98df971c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1353950Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#638100}
-
Gauthier Ambard authored
This CL puts all the public methods together. It also moves webState, webStateImpl and scrollPosition to private properties. Bug: 938255 Change-Id: Ic2b9870da254f538c201893dad87a99f4d18c216 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503323 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Saman Sami authored
The current logic is probably wrong if a client changes its embed token. Bug: 931801 Change-Id: I9ce49fa2fd8efccd5a556483d6c24bb81d95a783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504212 Auto-Submit: Saman Sami <samans@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#638098}
-
Marc Treib authored
This acts as a killswitch for https://crrev.com/c/1478878. Bug: 938819 Change-Id: I2f724523bd8ceab648998d5a656ce4ea88eb2860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505492Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#638097}
-
Kush Sinha authored
It was required that |IdentityManager::LegacySeedAccountInfo| be called before calling |chromeos::AccountManager::UpsertAccount| because Chrome OS Account Manager's |Observer|s needed to translate |chromeos::AccountManager::AccountKey| to other formats (raw email and canonical email) and relied on |AccountTrackerService| / |AccountMapperUtil| for doing so. This is no longer required: - Chrome OS Account Manager can now maintain the mapping from AccountKey to email id by itself (https://crrev.com/c/1452003) and can notify its |Observer|s about this information (https://crrev.com/c/1477691). All new account additions to Chrome OS Account Manager are now guaranteed to have an email id associated with them in Account Manager itself. - AccountMapperUtil has now been deleted (https://crrev.com/c/1483024). Hence, remove the temporal coupling between |IdentityManager::LegacySeedAccountInfo| and |chromeos::AccountManager::UpsertAccount| in all production call-sites. This seeding of AccountInfo will now be handled within |ChromeOSOAuth2TokenServiceDelegate::OnTokenUpserted|, just after the account gets added to |chromeos::AccountManager|. Bug: 922026 Change-Id: I77cdaa93ef34fc400f00a09aee8d9d847ef0fc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1495551Reviewed-by:Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Bryan McQuade authored
This implements support for tracking performance metrics for AMP documents loaded in subframes. This is something we'd wanted to implement but weren't sure how to implement. After discussion with AMP team we determined that we should take the following approach: * whenever the main frame URL gets updated with an AMP viewer URL (e.g. https://www.google.com/amp/...), we track that in OnCommitSameDocumentNavigation. we use the time of the main frame URL update as the baseline time from which the user-perceived performance metrics like FCP are computed. * whenever an iframe AMP document is loaded, we track that in OnDidFinishSubFrameNavigation. we also keep track of the performance timing metrics such as FCP reported in the frame. * we associate the main frame AMP navigation with its associated AMP document in an iframe by comparing URLs between the main frame and the iframe documents. * we record AMP metrics at the times when an AMP viewer URL is navigated away from. when a user swipes to change the AMP document, closes a tab, types a new URL in the URL bar, etc, we will record AMP metrics for the AMP doc in an iframe that the user is navigating away from. Change-Id: I08c36148907145ea89aa24652ed7efc9ed863757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500202 Commit-Queue: Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#638095}
-
Yi Su authored
This CL moves helper function "PreferredFontForTextStyleWithMaxCategory" from uikit_ui_util.mm to dynamic_type_util.mm, and adds some unittests. Change-Id: I08620274827845d58a9a4cced1c91b849c5da91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496857 Commit-Queue: Yi Su <mrsuyi@chromium.org> Auto-Submit: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#638094}
-
Ben Wagner authored
This allows gn to check FreeType includes. Change-Id: If9fe723e876e88164fa95191f8384d6805056b7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504235 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#638093}
-
Boris Sazonov authored
If Mirror header has a service type GAIA_SERVICE_TYPE_SIGNUP or GAIA_SERVICE_TYPE_ADDSESSION, start an activity to add an account to the device. Bug: 938554 Change-Id: Ib2d77afaa3434941c0597026211fa3d03292e456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504016 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
As a step to annotate the macros of Allocator for the Onion Soup, this CL annotates some classes of //third_party/blink/renderer/platform/scheduler with the macros of Allocator. After some analyzes, it was concluded that for the case of BudgetPool, DeadlineTaskRunner, FrameTaskQueueController, PageLifecycleStateTracker, RenderWidgetSignals, UserModel, Thread, PauseHandle, Builder, ThreadManager, Task, and ThreadPoolManager classes, they make sense to use USING_FAST_MALLOC because they have been used as a member variable with new() or smart pointers. In CancelableClosureHolder, ThreadLoadTracker, Policy, PendingUserInput, Monitor, PrioritizeCompositingAfterInputExperiment, QueueingTimeEstimator, RunningAverage, Calculator, TaskHandle, and SequenceManagerFuzzerProcessor classes, they make sense to use DISALLOW_NEW because they're used as member variable with a reference type. Lastly, the rest of classes this CL annotates make sense to use STACK_ALLOCATED. Bug: 919389 Change-Id: I0cd6908ae98b372ebf458bc94a5536f6f82c369d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504666 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#638091}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3e8a733a..79ffd9b5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54fc5a30b14dd64e3685dbd88a12f3f7db4376da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504780Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638090}
-
v.paturi authored
The function ContainingNGBlockFlow() might return a nullptr. So add a null check before dereferencing the pointer returned by it. Bug: None Change-Id: Ib4c3f84166654ec7af3bc187190714f2c3ab2bee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505352Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Commit-Queue: Prashant Nevase <prashant.n@samsung.com> Cr-Commit-Position: refs/heads/master@{#638089}
-
Raphael Kubo da Costa authored
Per the C++ standard, uintptr_t comes from <stdint.h>, so include it rather than relying on the header coming in implicitly. This fixes base_unittests's build with libstdc++, which was failing with errors such as In file included from ../../base/containers/vector_buffer.h:14, from ../../base/containers/vector_buffer_unittest.cc:5: ../../base/containers/util.h:13:15: error: ‘uintptr_t’ does not name a type; did you mean ‘u_int64_t’? static inline uintptr_t get_uintptr(const T* t) { ^~~~~~~~~ u_int64_t Bug: 819294 Change-Id: I68e8d5aac3918044a39b6f16fda4800a18ce74a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505554 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#638088}
-
Yi Su authored
This CL enables dynamic number of tiles per row for NTP. Now it will calculate the number of tiles per row based on the collectionView's width, the spacing between tiles, and the tile view's size which is decided by the font size. This CL also moves all tile view layout related helper functions to ios/chrome/browser/ui/ntp_tile_views/ntp_tile_layout_util.h&mm, so that they can be reused by omnibox pop shortcuts. Bug: 893523 Change-Id: I5be280f2adf2fd7c413f7e4e4bc34a84b5cc0b79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1499544Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0b1b7431ea96..31e0aecb035f Created with: gclient setdep -r src-internal@31e0aecb035f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I14e6b3acf4c4cedf82aa8a0b1e7f9dc69ed347f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504986Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638086}
-
Jordan Demeulenaere authored
Change-Id: I89b17d286c9790912ecfa107bd4de0a6fb0ca65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503328 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#638085}
-
Lukasz Suder authored
* Updates Details with latest mocks * Fixes and enables missing placeholder animations Before: https://screenshot.googleplex.com/jChmwed1MXK.png After: https://screenshot.googleplex.com/oFbYWvbQPOd.png Bug: 806868 Change-Id: Ica15073b30e3ff4fbd959fa6e79f4defaba073d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503317 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#638084}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I11ddeb833b134c683193b4a1940ed3f730d8fd20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#638083}
-
Marc Treib authored
It was already enabled by default; time to get rid of the old code. This also lets us remove many tests which were duplicated to cover both the enabled and disabled case. Bug: 935908 Change-Id: I274e86189637207cc72267a7ace4f1a911de2470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1430089 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
This is a follow-up for my last patch to modify how the class generate console logs, refs/heads/master@{#637638}. Bug: 936937 Change-Id: I74db0198180a222ab39ed347f1b9b3a5285540c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504659 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#638081}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eb748c338927..c854c371c89b git log eb748c338927..c854c371c89b --date=short --no-merges --format='%ad %ae %s' 2019-03-06 fmayer@google.com Merge "E2E test in both fork and central mode." Created with: gclient setdep -r src/third_party/perfetto@c854c371c89b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Iaff4fa0212f0f3f8559f3b560835d5c9421136d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504985Reviewed-by:
-
Gauthier Ambard authored
Instead of setting the Mime type in decidePolicyForNavigationResponse, set it in didCommitNavigation. This is because the URL passed in the navigation response might not be the same as the pending one. Bug: 936750 Change-Id: I9b1dfcc78e1c5ab9265b2cec653c502e5d012d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503432Reviewed-by:
-
Abhijeet Kandalkar authored
blink::mojom::ConsoleMessageLevel and blink::MessageLevel are essentially the same enums and represent same values for logging. This CL replace use of blink::MessageLevel with blink::mojom::ConsoleMessageLevel. Bug: 937184 Change-Id: Ibc029cc89f4178b9be13d32bcda2bd83c1a59b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502315 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
-
Olya Kalitova authored
Bug: 938252 Change-Id: I34600b86d73a1bc8c1db04af717216e406e02af9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503453Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#638077}
-
Gauthier Ambard authored
This CL format CRWWebController, cleaning up the pragma, make sure that the pragma for protocol are correctly named. It also removes the UIGestureRecognizerDelegate protocol which wasn't used and unnecessary synthesizes. Bug: 938255 Change-Id: I7e24a1b6545bd16cad22d93841bbb8701cc670e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503433Reviewed-by:
-
Matthew Cary authored
The previous registration in SetupMobileFieldTrials was too early; the g_browser_process is not initialized yet. This registration works. Bug: 932578 Change-Id: If45b6b88c1be4c1025f9ecd6ee8e5efc5685bc9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1473174Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Yoav Weiss authored
This CL is a refactor only with no functional change. It changes the finish_time variable into response_end to make it closer the what that value represents as part of the ResourceTiming entry. Change-Id: Ieca7843fcf1570b9a1ea3ba89ea6d3751529bae0 BUG: 938798 Change-Id: Ieca7843fcf1570b9a1ea3ba89ea6d3751529bae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503462 Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Bug: 889470 Change-Id: Id2d9309af28a82274c5041643763fce368fd26ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503756 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/233178a15e11..0b1b7431ea96 Created with: gclient setdep -r src-internal@0b1b7431ea96 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org Change-Id: I9315810656a28acc02498763ff16ff1e6a0928bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504983Reviewed-by:
-
Olivier Robin authored
As a consequence of WebFrameMessaging, the initial processing of frames is asynchronous. Wait for it to happen in tests. Bug: 938837 Change-Id: I05a759ea17944f316a9a19999afd1cab4fe5a59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1505532 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
dstockwell authored
Bug: 902646 Change-Id: If6f594535a1d1cdff19e441d0995d1ef57e22885 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504670 Commit-Queue: dstockwell <dstockwell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#638070}
-
Pavel Shmakov authored
Crash 1: https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BAndroid+Java+Exception%5D+java.lang.RuntimeException+at+org.chromium.chrome.browser.ChromeActivity.getFullscreenManager%28ChromeActivity.java%29%27+AND+product_name%3D%27Chrome_Android%27#-propertyselector,productname:1000,productversion:100,magicsignature:50,magicsignature2:50,stablesignature:50,magicsignaturesorted:50 Crash 2: https://crash.corp.google.com/browse?q=product_name%3D%27Chrome_Android%27+AND+product.version%3D%2773.0.3683.37%27+AND+expanded_custom_data.ChromeCrashProto.channel%3D%27beta%27+AND+expanded_custom_data.ChromeCrashProto.ptype%3D%27browser%27+AND+expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27%5BAndroid+Java+Exception%5D+java.lang.IllegalStateException+at+org.chromium.chrome.browser.ChromeActivity.getFullscreenManager%28ChromeActivity.java%29%27 Plus potential similar crash in TWAs Bug: 938212 Change-Id: Icd183741ea042f7d4c491a4755acc7fd4aff5050 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503256Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Cr-Commit-Position: refs/heads/master@{#638069}
-
Alex Clarke authored
We no longer need to split the lock in TaskQueueImpl. Change-Id: I05d1bc597f34fbe4a1a10ffc3a95fc451b72abc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504017 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
