GitLab

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/aa347dd67ba1..a6ad2f38573b


Created with:
  gclient setdep -r src-internal@a6ad2f38573b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ib1bb8314374ae1eccd690015b8b8cdebb607b696
Reviewed-on: https://chromium-review.googlesource.com/c/1327727Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606677}

While I was investigating traces I noticed that some trace events
in ServiceWorkerSubresourceLoader have the same IDs even for
different resource loading. This is probably because different
instances of ServiceWorkerSubresourceLoader are happend to be
allocated in the same address. These events are not overlapped
so this isn't a critical problem but it makes difficult to
analyze traces. Use resource_id_ as the trace event id to make
analyzing traces easy.

Change-Id: I6718bdc82d3aba1df422dbbbcbe3b4f1b06ca8cb
Bug: N/A
Reviewed-on: https://chromium-review.googlesource.com/c/1325283Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606676}

Bug: 874296
Change-Id: I233cda30e59b696bc6960f1e7366cbee62849bed
Reviewed-on: https://chromium-review.googlesource.com/c/1325011
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606675}

Removed the pointer cursor and focus state when the checkbox is
disabled.  This should prevent the checkbox from maintaining any
unnecessary focus as well as preventing any confusion when hovering
over the overwrite changes checkbox.

Bug: 888464
Change-Id: I14547deb878f2948e5606f3bf0bbc01b9ba75886
Reviewed-on: https://chromium-review.googlesource.com/c/1318062Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606674}

Increase the default snackbar duration to 10s when accessibility
mode is on. Also make SnackbarManager to double the custom
duration automatically when accessibility mode is on.

Bug: 699160
Change-Id: If3762db7eea56eed614ce15ff69a6591c7ae7706
Reviewed-on: https://chromium-review.googlesource.com/c/1327330Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606673}

This actually fixes a bug that appeared in the bindings for window.
Previously window.scrollTo.length == 2 in Chrome but was 0 in
FireFox. This is detected by the cssom-view wpt test.

CSSOM View smooth scroll API shipped in M61
https://codereview.chromium.org/2938373003
https://www.chromestatus.com/features/5812155903377408

BUG=243871

Change-Id: I7e2d5b7be38fd7dfc26e633ccd171e435eba51e5
Reviewed-on: https://chromium-review.googlesource.com/c/1323694
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606672}

Whenever a device is running an unsupported version of Android, we
display a menu item telling the user that Chrome is unable to
update. The same menu item is displayed (with different text and
visuals) whenever there is an update available. When the user
taps the menu item in the update available flow, they start
the update flow.

However, when the user is shown that they can not update, nothing
happens when they tap the item. This can lead to confusing
situations when using accessibility mode, since they are informed
that they can double tap to activate.

This CL changes this behavior to disable the menu item in the
unsupported OS case. The item is still possible to tap to inspect
though.

Bug: 852650
Change-Id: I1385bc798ea0324cc5043c390c20c40a45c2727f
Reviewed-on: https://chromium-review.googlesource.com/c/1327567Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606671}

chrome_modern_public_apk and chrome_public_apk hit the single dex
method limit when feed is enabled. This CL re-enables feed while also
turning on multidex for the required APKs.

Binary-Size: Feed was disabled to fix the multidex method limit issue.
Bug: 901488
Change-Id: Ifba41178fad6c206ec1f458d420187ef1c2eb6f3
Reviewed-on: https://chromium-review.googlesource.com/c/1327403
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606670}

Additionally, update the other patterns to only match at the beginning
to avoid inadvertently picking up similarly named directories under
other paths (currently just ios/chrome/browser/ui/omnibox).

Change-Id: I6da957f06af0de4b13c344cbbcdfae65a7e74821
Reviewed-on: https://chromium-review.googlesource.com/c/1327554Reviewed-by: Kevin Bailey <krb@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606669}

This updates tab text colors to both enhance contrast of text over tab
backgrounds as well as contrast between active and inactive windows.

Bug: 859243, 881916
Change-Id: I98257077fd6a9b7cf9521f845ea40218dcf11a70
Reviewed-on: https://chromium-review.googlesource.com/c/1297185
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606668}

The expectation is that the IPv6 literal not be bracketed.

Change-Id: I90631a55cddf1c02684512c8e9989f6d21cdc174
Reviewed-on: https://chromium-review.googlesource.com/c/1327528Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606667}

DidSuppressDialog callback is unnecessary because PreloadController
implements CWVWebStateDelegate and can cancel preload on window.open or
showing JS alert.

ShouldSuppressDialogs is unnecessary because PreloadController can
prevent dialogs via CWVWebStateDelegate callbacks.

This CL does not change the behavior. Previously webStateDidSuppressDialog
used to cancel the preload.

Bug: 777912
Change-Id: Ifbcc6ee48ecee741c2c6ff9a4760d601e3e1b843
Reviewed-on: https://chromium-review.googlesource.com/c/1322358
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606666}

The current NetworkChangeNotifierChromeOS implementation won't work
with the network service enabled because it listens for network changes
from Shill, which only supports a single client. The browser process
has other dependencies on Shill, so it has to be the client for the time
being, meaning the network service can't directly listen for network
changes and has to be notified of them from the browser process.

This CL splits the NetworkChangeNotifierChromeOS into two parts;
the first will live in the browser process and listen to Shill, while
the second is the actual NetworkChangeNotifierChromeOS implementation
which will have an instance in both the browser and network processes.
Since NetworkChangeNotifierChromeOS can't actually listen for network
changes itself, it just gets notified of changes from part 1 via a new
method in NetworkChangeManager. When the thing listening to Shill sees
a network change, it notifies its local NetworkChangeNotifierChromeOS
instance, and calls the new NetworkChangeManager method, the
implementation of which then notifies the network service's
NetworkChangeNotifierChromeOS instance.

Bug: 882610
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414
Reviewed-on: https://chromium-review.googlesource.com/c/1274445Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606665}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fc810ab24daa..93cd73d98000


git log fc810ab24daa..93cd73d98000 --date=short --no-merges --format='%ad %ae %s'
2018-11-08 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-11-08 bpastene@chromium.org Allow gsutil recipe_module calls to not always be infra_steps.
2018-11-08 martiniss@chromium.org Revert "Roll recipe dependencies (trivial)."


Created with:
  gclient setdep -r src/third_party/depot_tools@93cd73d98000

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:866062
TBR=agable@chromium.org

Change-Id: Ib3a90d2e456d199614cc895ed7e4b47d7e2a3208
Reviewed-on: https://chromium-review.googlesource.com/c/1327351Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606664}

Fairly basic and the connection must be manually torn down for now, but
allows requesting an interface implemention from the JS side.

Bug: 883496
Change-Id: I8367fd50097403ee2f9911657afbabdd8d461a41
Reviewed-on: https://chromium-review.googlesource.com/c/1324929
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606663}

LoginScreen::FocusLoginShelf() mojo API can be reused.

BUG=854346
TEST=trybot

Change-Id: Ide7dad98e1da57826d37d5dff4c3e269aee07c14
Reviewed-on: https://chromium-review.googlesource.com/c/1325689Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606662}

PreviewsState is used in DataReductionProxyURLLoaderThrottle to set some
chrome-proxy specific headers to serve previews.

Bug: 893728
Change-Id: Ie54f174bb1ba2ff4d77f725c0e64450f8d2aad0c
Reviewed-on: https://chromium-review.googlesource.com/c/1327568Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606661}

BUG=843181

Change-Id: I8b43a72535dd09a175df731a94dc8e216374e7ff
Reviewed-on: https://chromium-review.googlesource.com/c/1306660
Commit-Queue: Nik Bhagat <nikunjb@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606660}

BUG=chromium:890636
TEST=Enroll using attestation and check UMA

Change-Id: Ifdfa408a62cf7af43e7436b4a64b2a43afe7bf18
Reviewed-on: https://chromium-review.googlesource.com/c/1304613
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606659}

This reverts commit e19fa28d.

Reason for revert: Cause of https://crbug.com/903402

Original change's description:
> Marks the document object as busy while it is still loading
> 
> Screen readers want to have a reliable way to know whether a document is still loading so as to ignore events coming from it.
> The current change can be made irrespective to whether we will mark the document as loaded when HTML parsing has started or when the "interactive" readyState has been entered.
> 
> R=​dmazzoni@chromium.org, aleventhal@chromium.org
> 
> Bug: 897177
> Change-Id: I5d734ff9d32c53b7ba12a6d5d4eeb74b26ba0a02
> Reviewed-on: https://chromium-review.googlesource.com/c/1295769
> Commit-Queue: Nektarios Paisios <nektar@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606147}

TBR=dmazzoni@chromium.org,nektar@chromium.org,aleventhal@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 897177
Change-Id: Ib13f772ecf7fe300afbb48e16952f65bf0d0728a
Reviewed-on: https://chromium-review.googlesource.com/c/1327721Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606658}

(Previously it would just print -1 if the request failed due to a network error)

Change-Id: I5f61bc4461f109c733f56983ac0420b0e5083c27
Reviewed-on: https://chromium-review.googlesource.com/c/1327575Reviewed-by: Yves Arrouye <drcrash@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606657}

Bug: 889972
Change-Id: I5b0ab0869a526061f0125d5d23beb8f38f81b7ed
Reviewed-on: https://chromium-review.googlesource.com/c/1326845Reviewed-by: Nathan Parker <nparker@chromium.org>
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606656}

Importantly, non-visible RenderWidgets include swapped out RenderWidgets
which are zombies, without a frame, and which should not be used.

This can happen if the RenderWidget swap out races with the posted task
from the compositor to make a LayerTreeFrameSink. When swapping out, the
compositor would be marked as not-visible, which would stop it from
making such requests, but one could already be in flight.

In the other case, honoring the request for a non-visible compositor is
more benign, but we can delay it until the compositor is actually
visible again. This means if a context is lost, backgrounded tabs would
not all attempt to reconnect to the Gpu process at once.

This is a better followup for the hacky
https://chromium-review.googlesource.com/c/chromium/src/+/1292711 which
was meant only for merge to a release branch. It reverts that change as
part of this one.

R=piman@chromium.org

Change-Id: I058bdc37482d04bb86d65a7377b7520dad8573e7
Bug: 896836, 419087
Reviewed-on: https://chromium-review.googlesource.com/c/1292714
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606655}

Removing TabIcon from a layer used to happen after SetData marks a tab
as no longer loading. With the new tab-icon animation we extend the
animation period for 200ms past that.

This is a speculative fix for the referenced bug that I've been unable
to reproduce locally.

Bug: chromium:901277
Change-Id: I81c5e5af56fddc90ca210b027a681cd2309d2742
Reviewed-on: https://chromium-review.googlesource.com/c/1327231Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606654}

https://pdfium.googlesource.com/pdfium.git/+log/b8b52b46f8db..760b1c16f676


git log b8b52b46f8db..760b1c16f676 --date=short --no-merges --format='%ad %ae %s'
2018-11-08 thestig@chromium.org Remove CPDF_DocRenderData::Clear().


Created with:
  gclient setdep -r src/third_party/pdfium@760b1c16f676

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I9b6d7c3304b4db3c9210144d864650e61735def3
Reviewed-on: https://chromium-review.googlesource.com/c/1327350Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#606653}

Bug: 901563
Change-Id: Ia65425e4d47e79bfae1eb7bcd6f08aa0f4b641d5
Reviewed-on: https://chromium-review.googlesource.com/c/1321573Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606652}

I've just noticed that crrev.com/606339 causes a crash, and that's
because PrintWindowHierarchy starts from a root window, which
do not have a parent, but it tries to call IsToplevelWindow() which
assumes the existence of the parent.

BUG=none
TEST=manually

Change-Id: Ie4460302674d057a6c7960e0b012c80b63e06a2c
Reviewed-on: https://chromium-review.googlesource.com/c/1327560Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606651}

FrameSetPainter paints everything in the foreground phase, so
a frame under frameset should paint its box decoration background
in the foreground phase.

Bug: 902274
Change-Id: Id56af37a478b8503f17199753a485f6fe1261c95
Reviewed-on: https://chromium-review.googlesource.com/c/1326205Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606650}

Keeping scoped_refptr<WebWorkerFetchContext> in WorkerFetchContextHolder
cause WebWorkerFetchContext destruction on the main thread, because
WorkerFetchContextHolder is destructed on the main thread.

To avoid this, this CL passes WebWorkerFetchContext via
GlobalScopeCreationParams to WorkerOrWorkletGlobalScope.

This CL doesn't change the behavior.

Bug: 880027
Change-Id: Idab91d31cafdb33b264662c5f1bef126d93ba9f3
Reviewed-on: https://chromium-review.googlesource.com/c/1198891
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606649}

web_frame_test.cc is huge! This patch splits out the blink->compositor
tests into web_layer_test.cc. This is primarily a code move but the
following renames have also been included:
  SlimmingPaintWebFrameTest -> WebLayerListTest
  SlimmingPaintWebFrameSimTest -> WebLayerListSimTest

Change-Id: I78d2dbd242c1a69dbbc9a76dcf2be20087018508
Reviewed-on: https://chromium-review.googlesource.com/c/1327152
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606648}

This reverts commit 0cfecb52.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 606552 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGNmZWNiNTI0ODcwNjZhZDBjYzU1Y2NmMTg2MzVlNmQyOGJkOWI1ZAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/16586

Sample Failed Step: network_service_browser_tests on Intel GPU on Mac on Mac-10.12.6

Sample Flaky Test: PictureInPicturePixelComparisonBrowserTest.VideoPlay

Original change's description:
> [Media UX] Enable the pixel by pixel comparison test for Mac OS.
> 
> 1. Tested on Mac and verify everything works as expected.
> 2. Removed the unnecessary call of GetNativeWindow().
> 3. The RGB for GPU enabled and GPU disabled test images is slightly different. Additional check is needed.
> 
> Bug: 898230
> Change-Id: I85bf2450862361572597632159de60db6abf2c22
> Reviewed-on: https://chromium-review.googlesource.com/c/1307062
> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
> Commit-Queue: Clifford Cheng <cliffordcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606552}

Change-Id: I10a133230cad3256bf4e5e0c3c925920484ce6a1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898230, 903580
Reviewed-on: https://chromium-review.googlesource.com/c/1327612
Cr-Commit-Position: refs/heads/master@{#606647}

This reverts commit a9531c4a.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 606631 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E5NTMxYzRhYWU1Y2FhY2RhN2MxNDg1OGRlMzg2MGVmYjQxMjI4YjQM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-rel/4213

Sample Failed Step: compile

Original change's description:
> Android: Roll android_tools and fix lint errors
> 
> Update lint to version 26.4.0-alpha03+.
> 
> This is the first lint update since 2017 September, thus a long list of
> TODOs is expected.
> 
> TBR for mechanical fixes to existing lint errors that are only exposed
> due to update.
> 
> TBR=mheikal@chromium.org
> 
> Bug: 900912
> Change-Id: I3335834ae308a3411ced51bb2c913b76a8f8d8c3
> Reviewed-on: https://chromium-review.googlesource.com/c/1327157
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606631}

Change-Id: Ie3a61a6d093d8cd6426ddcd7bf833f98c9b4f78c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 900912
Reviewed-on: https://chromium-review.googlesource.com/c/1327611
Cr-Commit-Position: refs/heads/master@{#606646}

Change-Id: If497956bc179864957dd21b8b88c8db354dd96af
Reviewed-on: https://chromium-review.googlesource.com/c/1325069Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606645}

Change-Id: I9f539e61174d0aa23767e9de9107b5fa8c606418
Reviewed-on: https://chromium-review.googlesource.com/c/1323690Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606644}

This is a reland of 126a1168

The fix in this change addresses compile errors on the
Oculus platform.

TBR=dcheng@chromium.org
dcheng@chromium.org: please review, though there are no
new changes to vr_service.mojom

Original change's description:
> Make XR FrameData and Environment mojo associated
>
> The XRFrameDataProvider now returns an associated
> XREnvironmentDataProvider interface so that the
> two share callback queues and thus allow strict
> ordering of the two interfaces. This is critical
> for frame synchronization between frames and the
> associated environment data.
>
> Note: We can't just mark the interfaceptrs for
> XRFrameDataProvider and
> XREnvironmentIntegrationProvider as associated
> in the XRSession struct. XRDevice implementations
> mostly live on separate threads from the
> XRFrameDataProviders, so we'd have extra thread
> hopping. For the VR headsets we explicitly live
> off the main thread to avoid latency, and because
> we do some work that may block the thread the
> XRFrameDataProvider lives on (for example waiting
> for vsync, or submitting frames to headset APIs).
>
> Bug: 867057, 876135, 843376
> Change-Id: If2fb62fcd185825209dec08e421df05f34d41c30
> Reviewed-on: https://chromium-review.googlesource.com/c/1171794
> Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Bill Orr <billorr@chromium.org>
> Reviewed-by: Klaus Weidner <klausw@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#605545}

Bug: 867057, 876135, 843376
Change-Id: If76578ebabbb40d03a21f6f557c5d4c27f69fc38
Reviewed-on: https://chromium-review.googlesource.com/c/1324089
Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606643}

The virtual keyboard extension is responsible for choosing the size of
the keyboard window. In test code, we mock out the extension but we
don't set a size. This means that test code has to manually set the
bounds of the keyboard window, which is a bit weird. Failing to set
the size result in very confusing test failures too.

Therefore, we set a default virtual keyboard size in the test KeyboardUI
implementations. If test code need a specific size, they can always
resize the window themselves.

Bug: 849995
Change-Id: I3794f11719bcfe722317174d43492141e6f75b80
Reviewed-on: https://chromium-review.googlesource.com/c/1278462
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606642}

When sync is paused, a button to signin again is shown
in the sync account control on the main settings page.

Bug: 902949
Change-Id: I818034d4d6980ff3d26c4eb8429a13fe20a6fbf2
Reviewed-on: https://chromium-review.googlesource.com/c/1324399Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606641}

It's not clear what preferring Ethernet or cellular means. Users can
just disable WiFi if they want to 'prefer' their cellular network.

Bug: 881557
Change-Id: I7e53ca9e4fac2be8f952f0081868a3c255f17f0e
Reviewed-on: https://chromium-review.googlesource.com/c/1325150Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Tony De Luna <tonydeluna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606640}

Change-Id: Ib616de76fcaca95b252183e85cc1d595b2b8d9fb
Reviewed-on: https://chromium-review.googlesource.com/c/1323627
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606639}

Bug: 902959
Change-Id: I6a5bfde6b6b81f16b34d0ae6b728a0aa26f869a3
Reviewed-on: https://chromium-review.googlesource.com/c/1327566Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#606638}