- 28 Jul, 2020 40 commits
-
-
Zhongyi Shi authored
Collect additional data when network changes are detected: 0. # of sessions that has been active or created during the time period of speculative error. 1. # of sessions that (previously) degraded until a network change. 2. % of sessions that degraded of all tracked sessions since first session that detects degradation. 3. # of sessions that were closed due to QUIC_PACKET_WRITE_ERROR before degradation detection. 4. occurrence of sessions that detects a QUIC_PACKET_WRITE_ERROR after degradation detection. Bug: 1090532 Change-Id: Ic61db8152ff46b9819ff2626869e96e7d69c388b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293617 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#792440}
-
Ankit Kumar 🌪️ authored
This CL draws/hides the focus rectangle around the PDF document based on whether the PDF document has the focus or not. The focus rectangle color is currently white. It's a placeholder for now and will most likely change in future. Fixed: 1069370 Change-Id: Ib8446a2326924ff0fed59d8fd2b04db462c1488c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211562 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#792439}
-
Sebastien Marchand authored
This cleanup some things inherited from the previous implementation, some properties were tracked multiple time (in the PageNode itself, in the SiteDataWriter and in the NodeData object), this removes some of the duplication and privileges using data directly from the PageNode. This also renames the NotifySiteVisibilityChanged function to a pair of NotifySiteForegrounded/NotifySiteBackgrounded function for consistency with the other functions of the SiteDataWriter class. Change-Id: I6412e2f79d8f330214567a439c33727e87210ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283297Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#792438}
-
chinsenj authored
If an app has focus while overview starts, it can receive key events. For apps like Chrome, this can result in visual glitches like fragments of omnibox appearing during the overview startup animation. To prevent this behavior, overview session now eats keys during the start animation. Test: OverviewSessionTest.EatKeysDuringStartAnimation Bug: 951324 Change-Id: Ic0f4c0cef94477ea56846eb7d7f115fc74fbcc79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323741 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#792437}
-
manuk authored
Bug: 591981 Change-Id: I8b5cb4ae18c7081d3733521926125aed2995aeb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314268Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#792436}
-
Avi Drissman authored
This migrates: defined(OS_MACOSX) -> defined(OS_APPLE) defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC) !defined(OS_MACOSX) || defined(OS_IOS) -> !defined(OS_MAC) Bug: 1105907 Change-Id: I29e66db0baaa7cf1aa6e16a385f99b6d398bcde6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321211 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#792435}
-
Jonathan Ross authored
When running Pinpoint, and CQ Dry Runs of the GpuMemoryAblationExperiment being enabled-by-default, a few issues were uncovered: - GrContexts cannot always be initialized (crbug.com/1103780) - Nested changes to GLContext during initialization fails (crbug.com/1104316) - Nested deletion crashes in mutually-exclusive ways (crbug.com/1106926) This change looks to address these by restructuring how GpuMemoryAblationExperiment performs its initialization and context switches. - The feature will now disable itself for Mock/Stub GL impls. This will prevent attempting to create GrContext in tests where it will always fail. - For initialization and allocation a ui::ScopedMakeContext will be used. This allows resetting of previous state so that GLContexts can properly initialize. - Deletion will now be done on a PostTask. While some deletion errors can be addressed by resetting the context. Resetting the context itself can lead to accessing partially deleted objects. Setting a a null Surface instead of a scoped context would address these cases, but do not address deletion paths that need their context set the entire time. This update to initialization and context handling did help uncover other issues (1107497, 1107502, 1107509, 1107512) however those are either platforms we are not running Pinpoint on, or tied to specific test suites. The root causes of these failures will be investigated separately. Bug: 1103780, 1104316, 1106926 Change-Id: Ibf3c9a3a560912f5505f99870b848878a99da5ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300183 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#792434}
-
Yuke Liao authored
This reverts commit 3e86bdd3. Reason for revert: Issue was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2321237. Original change's description: > [lacros] Exclude ui_base_unittests > > Exclude ui_base_unittest from linux lacros builders due to a compile > failure. > > Bug: 1110072 > Change-Id: Ia228c2d6959d4821c2258d68bccb0a34d02bf02e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321244 > Reviewed-by: Sven Zheng <svenzheng@chromium.org> > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792134} TBR=liaoyuke@chromium.org,svenzheng@chromium.org Change-Id: If91ef1a30c259cf819e0b4e8e5e85dec851ce7e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1110072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324407Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#792433}
-
Xiaohui Chen authored
* Add fade in/out animation for ambient mode * When showing ambient mode, fixed the first black screen issue * When idling on lock screen and ambient mode returns, fixed the first image quickly flashes problem This CL enables the default window animations, it also creates the window only when images are successfully downloaded. Bug: None Change-Id: Ideb5683aefe92b5f375f06515db822bfd3cb7678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321714Reviewed-by:
Meilin Wang <meilinw@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#792432}
-
Kevin Marshall authored
TBR=sdefresne@chromium.org Bug: 1110452 Change-Id: I1f12593431d3818f270fa077b9b3b97dcd007753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324563Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#792431}
-
Maxime Charland authored
Currently, the button in TableViewIllustratedCell has a leading and trailing constraint. This means the button's width is determined by the view's size, instead of the button's content's size. Removing the leading and trailing constraints of the button allows for a more flexible sizing and is better aligned with the Chrome Empties design. (Googlers only links) Screenshot without constraints : https://drive.google.com/file/d/1TE00X2gZks0_FUTYzOQoQoHgXOvTo6ux/view?usp=sharing Screenshot with constraints : https://drive.google.com/file/d/16YIpHydO0tnsxS5X5sUBMc3u2xd_UWSw/view?usp=sharing Bug: 1098328 Change-Id: Ie858503dd221936798e4ced65664eeac67b63691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317606Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Maxime Charland <mcharland@google.com> Cr-Commit-Position: refs/heads/master@{#792430}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6007f3bd6f36..b394db45e6e6 2020-07-28 rmistry@google.com Migrate Canary-G3 to task driver 2020-07-28 bungeman@google.com Mark sk_abort_no_print [[noreturn]]. 2020-07-28 johnstiles@google.com Update Slide::getName to return a const reference. 2020-07-28 reed@google.com Remove subset parameter from making encoded/generator images 2020-07-28 jlavrova@google.com Reland "Attach whitespaces to the neighbor unresolved blocks" 2020-07-28 bsalomon@google.com Remove asserts in SkMatrix get_scale_factor 2020-07-28 adlai@google.com Change makeTextureImage staging to allow either API 2020-07-28 scroggo@google.com Remove gendered language 2020-07-28 johnstiles@google.com Remove unnecessary macros from SkString header. 2020-07-28 robertphillips@google.com Make some GMs compatible with the *ooprddl configs 2020-07-28 jvanverth@google.com Initialize temp vertex array for GrAAHairlinePathRenderer. 2020-07-28 bsalomon@google.com Add nearest MIP filtering to GPU and wire up to SkImageShader 2020-07-28 bsalomon@google.com Remove GrSurfacePriv and GrRenderTargetPriv 2020-07-28 scroggo@google.com Remove "master" from lua files 2020-07-28 scroggo@google.com Remove experimental/Networking code 2020-07-28 scroggo@google.com Remove more references to "master" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1096001,chromium:1101491 Tbr: borenet@google.com Change-Id: I3ff2dd19004da5c11aa26ad6f8330a07417e7144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324550Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#792429}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9cbd788e95fc..3dc032a7f76a 2020-07-28 t-olfly@microsoft.com Source Order Viewer Labels 2020-07-28 aerotwist@chromium.org Migrates extensions to devtools_entrypoint 2020-07-28 janscheffler@chromium.org Disable flaky e2e test 2020-07-28 janscheffler@chromium.org Migrate `front_end/services` to `devtools_entrypoint` If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1094406,chromium:1101738,chromium:1110351 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I842d90d0442fc5e91f9a317f82d7e7dff360ff7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324701Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5408a4532748..1da974976b2a 2020-07-28 saklein@chromium.org cros workon: fix board parsing. 2020-07-28 vapier@chromium.org licensing: convert API from board to sysroot 2020-07-28 tbarzic@chromium.org Revert "deploy_chrome: copy swiftshader" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md No-Try'ing for a speedy uprev; all affected bots have passed. No-Try: true Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I555cb204c375afdb98d6798622dae42ffa310123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323764 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
-
Daniel McArdle authored
The prior CL put experiment group names in the place where feature param names should go. Bug: 1052476 Change-Id: I5ec9f0a8eb6a40a4a570adb626082af53771597d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323140Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Dan McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#792426}
-
Ben Pastene authored
This reverts commit f4723a7e. Reason for revert: cdm_storage_id.cc:112:45: error: expected ')' https://ci.chromium.org/p/chrome/builders/ci/chromeos-kevin-chrome/8936 Original change's description: > Convert from base::Bind and base::Callback to Once/Repeating in media > > This CL converts base::Callback (and corresponding calls to base::Bind) > to either base::OnceCallback or base::RepeatingCallback in > chrome/browser/media. In general a base::OnceCallback is preferred since > that's a stronger API guarantee, so that's been done where safe. > > Bug: 1007635 > Change-Id: Ie3113c61db1ae43ce2e31c262f023d714f42dfc0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321003 > Commit-Queue: Will Cassella <cassew@google.com> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#792380} TBR=liberato@chromium.org,cassew@google.com Change-Id: Ie1ee4eb9a5a81ef346e38e21fff6535ef29e2790 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1007635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324498Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#792425}
-
evliu authored
This CL secures SODA with an API key as outlined in go/securing-soda-on-chrome. Bug: 1107615 Change-Id: I7239c4f369c52360c293fc33959f99c044503ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314987Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#792424}
-
Yuke Liao authored
The breakage was introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2315863 lacros-chrome is built on Linux, but doesn't use x11, so this CL fixes the assumption. Bug: 1110072 Change-Id: I85293dd604a390d8cc97e5f03f637db40d1d5812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321237Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#792423}
-
Jia Li authored
1. Added a Finch flag to enable/disable ML service. 2. Decoupled model storing and model loading in PredictionManager::UpdatePredictionModel to support async model loading. A model is now stored before it is validated and loaded, and will be removed if model fail to load. Bug: 1099371 Change-Id: I3d2e06e769601f5fcfde06f1d2af72f69f478e4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319050Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Jia Li <jiakl@google.com> Cr-Commit-Position: refs/heads/master@{#792422}
-
Nina Satragno authored
Stop and clear lottie animations when changing the animation-url. This prevents a visual glitch where the previous animation might show for a few frames while the new one loads. Fixed: 1104241 Change-Id: Id2015c8a374180eda33a8fd870611f224cae4e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317814 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#792421}
-
Jonathan Ross authored
Some alpha blending media tests are flaky with SkiaRenderer. In both Vulkan and GL. This change adds a Skip expectation for GL. This change also updates the note for the Vulkan expectations to refer to this being a bug and not just lack of rebaselines. TBR=backer@chromium.org TEST=vulkan_native_blink_web_tests, skia_renderer_gl_blink_web_tests media/alpha-video-playback.html Bug: 1094635 Change-Id: Id8cab6764c88f7d21e889ca7dd8554e43de3554d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324486Reviewed-by:
-
Mario Bianucci authored
Start forwarding points from the browser process directly to viz via the UI compositor when delegated ink trails are being drawn. This CL gets the point to Display, the next CL will start storing the points and using them as they arrive. This CL only supports aura, follow up CLs will add support for Android and Mac. Bug: 1052145 Change-Id: Ic36d45bd960d358ececaf0312ce801da33686966 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259015Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#792419}
-
Tim Song authored
BUG=1057204 Change-Id: Ie829a462889890d9fe57d47f9043a46759a26b18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150077 Commit-Queue: Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792418}
-
Sam Sebree authored
This change uses native_theme_base.cc and controls_refresh.cc to update the styling for the button native controls in dark mode. Bug: 1099624 Change-Id: Ib907a5a5887266c1bff3903b1b1c571e4dbc7aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311419 Commit-Queue: Sam Sebree <sasebree@microsoft.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792417}
-
Kevin Marshall authored
This reverts commit ed6fd705. Reason for revert: New WebRTC test failure on WebKit Mac10.13 test bot started after the new roll. https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Mac10.13%20%28retina%29/31755 Original change's description: > Roll WebRTC from 0bb26390604e to 24a53a05a52d (3 revisions) > > https://webrtc.googlesource.com/src.git/+log/0bb26390604e..24a53a05a52d > > 2020-07-28 dminor@webrtc.org Fix division by zero in I420Buffer::CropAndScaleFrom > 2020-07-28 hbos@webrtc.org [Perfect Negotiation] Implement non-racy version of SetLocalDescription. > 2020-07-28 sakal@webrtc.org Delete dead code from JNI audio header. > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/webrtc-chromium-autoroll > Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Bug: chromium:1071733 > Tbr: webrtc-chromium-sheriffs-robots@google.com > Change-Id: I7f2478c5f1258a935467101742f6bd5cb5f68f56 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323241 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#792358} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,webrtc-chromium-sheriffs-robots@google.com Change-Id: Ieced76c106cffe3dc7207eed3937356c3df51e5f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1071733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324887Reviewed-by:
-
Anastasiia N authored
On Chrome OS we should not change accounts using AccountsMutatorImpl. All methods except UpdateAccountInfo should be NOTREACHED. Bug: 1068240 Change-Id: Ib25550b82e8b81d7b58c0995a6809e148c4e3b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317351 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#792415}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595937363-e1ba3bb5d536598606cbf11f12f7443f2b2cf4cf.profdata to chrome-mac-master-1595959156-afb0fd7058e155b7eeff3c31fa05c2b8de5863d0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6e6972596a12f618cd29105216a3fca636c13de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324483 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Dana Fried authored
Forgot to add field trial entry, but need to start testing. Bug: 1109256 Change-Id: Id4abe245625c4475885b3e899487bd9a1b25cdf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315798 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
-
zhaoyangli authored
Makes test runner run XCTest based unit tests with correct test app, by testing args passed to test runner. Use xctest arg to determine runner type only, but not parser type anymore in test runner, except for special handling for WebRTC xctests with a TODO. Related CLs: - GN building the arg to test runner: crrev/c/2314134. - GN config change in some iOS FYI builders: crrev/c/2315638. Bug: 1001667, 1006881 Change-Id: I3fcd69f21641894f12e315898ce29059449b1b6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315245 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#792412}
-
Nina Satragno authored
The FIDO spec has renamed the uvToken parameter to pinUvAuthToken. The semantics haven't changed for our implementation, so simply renaming should be enough. Fixed: 1110106 Change-Id: I46a05f35c404acce842cc5341a8ec117f9d2af84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321548 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#792411}
-
Solomon Kinard authored
.gyp files were removed years ago for performance reasons. Bug: None Change-Id: I01fded482a7cde8dd0732e0724ff54316afebb61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323961 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#792410}
-
Mikel Astiz authored
The class has no dependencies to ProfileManager. R=nyquist@chromium.org Bug: None Change-Id: I67b998477a0dcff2970404f115d4118d018b9cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315153Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#792409}
-
Josh Nohle authored
The method returns true if the CryptAuth app handler has been added to the GCM driver. This is particularly important to know when fetching Instance ID data (see crbug.com/1006280). Child CLs will utilize this method to confirm that the manager is listening before registering with GCM or fetching Instance IDs. --- This is ClientAppMetadata change-detection CL [1/4]: This chain of CLs relates to the end goal of re-enrolling if ClientAppMetadata has changed since the last successful enrollment. For example, when Phone Hub become supported, we will want to re-enroll. We were previously only fetching ClientAppMetadata on demand, for instance, right before a periodic enrollment. Now, we need to fetch the data every time the service starts up to see if it changed. We continue to make the assumption that the data will not change during a user session. Bug: 1105703 Change-Id: Ifb08bc479b96e0ace0f85d27041a8259b9b29967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319327Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#792408}
-
Jonathan Ross authored
These tests began failing on GPU Windows 10 NVIDIA Quadro P400 bots. Originally this was seen just for no-use-gl, but the d3d11 angle versions are also failing. Extending the suppressions. TBR=ynovikov@chromium.org TEST=webgl2_conformance_d3d11_passthrough_tests conformance2/textures/misc/tex-3d-mipmap-levels-intel-bug.html deqp/functional/gles3/shadertexturefunction/texturesize.html conformance2/textures/misc/tex-mipmap-levels.html Bug: 1106078 Change-Id: I9e688fa581483c04bec4dcd897e0e2d3dc6f11f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323886Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#792407}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/469c2061cd49..cfacaaffd1fe 2020-07-28 tommek@google.com Adding support for the additional fixed sample mask in MSL (#1120) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I285d90bb26edd9cd346280bd51be33cc23253eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322589Reviewed-by:
-
Richard Townsend authored
Improves checks around deferred parser scheduling to make sure that PumpTokenizer does not operate when the parser's stopped, improves parser termination to deschedule any pending pumps, and expands test coverage. Bug: 901056, 1106314 Change-Id: I03787e9a9e440fc9ce92d98040b1cdce3ea1ddc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302612 Commit-Queue: Richard Townsend <richard.townsend@arm.com> Reviewed-by:
-
Yicheng Li authored
Add an InSessionAuthDialog class with a debug view, which currently is a text prompt and two buttons. The InSessionAuthDialog will show this debug view if the runtime flag show-auth-dialog-dev-overlay is set, and will show nothing otherwise. InSessionAuthDialog will be called by an AuthDialogController class (to be added in a follow-up CL).ash: Add a barebone AuthenticationDialog class Bug: b:156258540 Change-Id: Ib764399702ca557014b24faadf7855c4f9f39b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298527 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#792404}
-
Avi Drissman authored
This migrates: defined(OS_MACOSX) -> defined(OS_APPLE) defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC) !defined(OS_MACOSX) || defined(OS_IOS) -> !defined(OS_MAC) Bug: 1105907 Change-Id: I1f750eadc953115462fcd276ec3ffb3bfb9808ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321052 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#792403}
-
Robert Sesek authored
Change-Id: I780524c08cecbd6d6511db456ded0e3676cefc1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308132Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#792402}
-
Evan Stade authored
Bug: 1007823 Change-Id: Ia2aea90862946a5a6a8f95a9e5da76ed0241d876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324207 Commit-Queue: Dirk Pranke <dpranke@google.com> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#792401}
-
