- 11 Sep, 2020 40 commits
-
-
Rohit Agarwal authored
This CL adds the support of linking CustomTabIncognitoManager instance with a WindowAndroid object instance. This would enable querying the non primary OTR profile from the CustomTabIncognitoManager instance. This CL is step [1] for the refactoring the TabModelImpl to take in profile as an argument. [1] go/incognito-cct-profile-passing-support Bug: 1099642 Change-Id: I0b4e0e3959247925f41292ce8b15855aa8fe4347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396336 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#806127}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0c8f66c7169c..9a7e7b08a74e 2020-09-11 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 30a5da05 to fe51fcb5 (441 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Ib254d266772dfdcc15934d6970cfab26b8ca5f07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405981Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806126}
-
Mariia Shvedchenko authored
This CL provides new structure MatchingPattern that replace using single regular expressions, but store more information about concret pattern. Also it contains splitted MatchType into MactchFieldTypes and MatchAttributes and sceleton of PatternProvider class. Change-Id: I5acebf12aafaca67ae87260b2c897bdf35a38bea Bug: 1121990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385282Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Mariia Shvedchenko <mariiash@google.com> Cr-Commit-Position: refs/heads/master@{#806125}
-
Mirko Bonadei authored
This CL adds some missing dependencies from the Chromium WebRTC component to //third_party/webrtc build targets in order to try to enable GN check on the following paths: "//third_party/blink/renderer/modules/peerconnection:*" "//third_party/blink/renderer/modules:*" "//third_party/blink/renderer/platform:*" Bug: 1126839 Change-Id: Ie53c02bcfb5ff00e40d9f4db55f701700da7f5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404790Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#806124}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org Bug: 1083010 Change-Id: I031dcc1847a0e5e7309b78c9f1db63dac8e267c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398909Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#806123}
-
Mark Brand authored
This change creates a new mojo::Message for each deserialisation, avoiding OOM issues created when too many objects are deserialised in a single testcase. It also adds a maximum action size to the CodeCacheHost fuzzer to enforce a "reasonable" maximum. Bug: 1121032 Change-Id: I7d1c07330e66f856ab2eb0697973b186bed66f02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397616Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Mark Brand <markbrand@google.com> Cr-Commit-Position: refs/heads/master@{#806122}
-
Frédéric Wang authored
This CL makes MathML monolithic, ensures it does not use legacy layout and removes the corresponding check in CreateLayoutObject. This makes MathML correctly laid out in SVG foreignObject and fragmented subtrees. Bug: 6606, 1125133, 829028, 707656, 989916 Change-Id: I5d0c19c8bbb777e1891e708f81a8cf61e1dc62a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398702 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Ana SollanoKim authored
The test fieldset-as-multicol.html is expecting that multicolumn has no effect on a fieldset element and directly contradicts the test fieldset-multicol.html, where we are expecting fieldsets to break into columns. For this reason, fieldset-as-multicol.html is no longer useful. Bug: 875235 Change-Id: Idae4c8181c1c2a5b3d2b0db34e05cb4f0740069f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404376 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/983a47d55ab1..b686cc006318 2020-09-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ic7096ee50c1f0394175f83eabd8a5289770340f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405984Reviewed-by:
-
Michael van Ouwerkerk authored
Bug: 1125772 Change-Id: Ic758e75b99bd1b9d414e4d1f71f3b6dcca9307fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398527Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#806118}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2157bf8b002d..5eb6da2205cd 2020-09-11 changhaohan@chromium.org Fix adorner update race condition 2020-09-11 chrche@microsoft.com [Loc] Update Documentation 2020-09-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2020-09-11 szuend@chromium.org [ts] Remove unnecessary @ts-nocheck from sources/SnippetsPlugin.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1126334,chromium:941561 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3d525f38b8c29f7342c0c09c9089e041246ad5f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405977Reviewed-by:
-
Mohamed Amir Yosef authored
Before the patch: Api_FillsResponseWhenNoErrors was mistakenly instantiated FillResponseWhenNoErrors against the LegacyTestEnv. This patch correctly instatates it against ApiTestEnv and does the required modification to make it pass. Bug: 1114655 Change-Id: I99a8463615069d3307a84190bae383e92a309c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404927Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#806116}
-
Mohamed Amir Yosef authored
`may_use_prefilled_placeholder` has been overlooked when converting the old proto to the new one. This CL is fixing that and adding a test. Bug: 1126961 Change-Id: I363d21c6c09050a5b9b1adca52ff496ce6c756f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403642Reviewed-by:
-
Bret Sepulveda authored
We would like to use this histograms for our upcoming experiments. Bug: 1125739, 1125738 Change-Id: Ic55346888c451db300420099aa9d1bbb8ed45654 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401339Reviewed-by:
-
Tal Pressman authored
Route most of the calls from RenderViewHost to RenderProcessHost via the AgentSchedulingGroupHost instead. This is needed since in the future all widget-specific communication will be done directly at the agent scheduling group level, and not the process level. Bug: 1111231 Change-Id: If87179b98a89d25f09723867710a43b01afda1fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397131Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#806113}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4bb03bb4b22d..44c9ca6a2c0e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC orphis@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040645 Tbr: orphis@google.com Change-Id: I586d0a124bb943405b379d527767540d5730141e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405975Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806112}
-
Tamir Duberstein authored
Assert after each send call to better pinpoint future problems. The test passes locally. Fixed: 1125855 Change-Id: I30d5c7bd2bc14fbd9547b1eb6d309d7556274891 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404483Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Tamir Duberstein <tamird@google.com> Cr-Commit-Position: refs/heads/master@{#806111}
-
Olivier Robin authored
FormInputAccessoryView is only fully dismissed when keyboard is hidden. In multiwindow, it is possible that keyboard stays on screen when a text field edition ends, if the keyboard is used in another window. Hide the accessory view to avoid having an inactive accessory view on screen. Bug: 1125110 Change-Id: I1ff717af263589185e69eaddff8e469edde8c77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401102Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806110}
-
Olivier Robin authored
This fixes OverlayPresentationContextViewControllerTest.* tests Change-Id: I406440441707273077c32f3a2cf971504b4f10f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403364 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#806109}
-
Maggie Cai authored
This CL update the sharesheet button and context menu to use the sharesheet label. BUG=1097623 Change-Id: I9403ad075c3e1a7899edfd26181d4a8ed4452084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404230Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#806108}
-
Ioana Pandele authored
This check is performed once before to determine whether to show the password change button. It can happen, however, that the conditions change without the UI refreshing (e.g. an app was uninstalled), so an additional check is required. Bug: 1124273 Change-Id: I0e51997a8a48a88c2d44b90d3ac12a2789a1a27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403470Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#806107}
-
Olivier Robin authored
Change-Id: I4996afbbc8b56b59e979a5f2e2c5a136f281bf6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403361 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806106}
-
Jan Wilken Dörrie authored
This change moves the backport of std::ranges algorithms from //base/util/ranges to //base/ranges and updates call sites. TBR=dcheng Bug: 1071094 Change-Id: I696c1f4c27f603255b32845d8b7fb4e176190367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362816 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#806105}
-
Kent Tamura authored
This is a preparation to enable "gn check" for //third_party/blink/renderer/platform. This CL fixes errors other than crbug.com/1126839. - a visibility adjustment - deps/public_deps corrections - moving test helper files from :unit_tests to :test_support This CL has no behavior changes. Bug: 800764 Change-Id: I7bbb02173cb8211ce250ddc69e5e50d36c1b0220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402720 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806104}
-
Alex Rudenko authored
Issue 1125357 highlighted a case which was not accounted for previously: <link> CSS files can be edited via DevTools making them look like constructed stylesheets. This CL adds an explicit isConstructed attribute to CSSStyleSheetHeader for the frontend to be able to distinguish between constructed and linked stylesheets. Frontend CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2403326 Bug: 1125357 Change-Id: I66f5d9c935a0992977737c323476494db5331959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403560Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#806103}
-
Tamir Duberstein authored
Bug: 768916, fuchsia:20638 Change-Id: Ibb6e1897661505c050c197cd30c853ba9bc115d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404622Reviewed-by:
-
yilkal authored
Replace ui based oppressive words with more inclusive ones. Bug: 1121639 Change-Id: Ifc5722d50ddbe30ede297a7ac161e2717402a3a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402167Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#806101}
-
Alice Wang authored
This CL refactors the method SyncTestRule#setUpTestAccountAndSignInWithSyncSetupAsIncomplete() by replacing its internal sign-in method with sign-in from AccountManagerTestRule. Bug: 1126814 Change-Id: Ief0190f97ca45582bf6e9810f56f646aa49414e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403461 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#806100}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599781911-9c360a18426c47cd39d0c24797835d08f90d685a.profdata to chrome-mac-master-1599803297-f57c520d1d1c3cda3710a7861122a030eca358e8.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib75bc229c19a1173f9b185a2d037887700b0729d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405974Reviewed-by:
-
Hiroshige Hayashizaki authored
To avoid timeout, this CL - Removes arbitrary timeout of 2 seconds, and - Splits `message.html` into multiple test files. This is to unblock V8 roll: https://chromium-review.googlesource.com/c/chromium/src/+/2401062 Bug: 590219, 1127235 Change-Id: I86a750f3b158797a393506bf7be32ecc573e73f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405726 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806098}
-
sandromaggi authored
This continues the effort to make |WebController| actions use |ElementFinder::Result| instead of |Selector|. It also adds some missing tests to cover the new scenarios. Bug: b/168107066 Change-Id: Ie0899426c5f6c66d748fbc2548871a3fc66b4c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401618Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#806097}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/fb6d901df74d..983a47d55ab1 2020-09-11 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I225124acd27019c9047a299cb69f6301a3f85162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404679Reviewed-by:
-
Fergal Daly authored
Just cleaning up the files I touch regularly. use - make_unique - default - range-based looping syntax Change-Id: I915a10ea0bbdd370ca9d19e867f98cd75c7c5d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400793 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#806095}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/11042f961ca6..2157bf8b002d 2020-09-11 szuend@chromium.org [ts] Remove unnecessary @ts-nocheck from sources/OpenFileQuickOpen.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id220bcdc1c03d63f8e52bdfe9b9be3a7ee176d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404677Reviewed-by:
-
Nidhi Jaju authored
While changing GURL callsites to url::Origin for origins in https://chromium-review.googlesource.com/c/chromium/src/+/2389201, we realised that we should change |registered_origins_| to use url::Origin instead of GURL. This CL makes that change. The relevant callsites have also been modified. Bug: 1095896 Change-Id: I76f8bc42634b8cb34b0fca79fd55d0509034b713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401033Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju127@gmail.com> Cr-Commit-Position: refs/heads/master@{#806093}
-
En-Shuo Hsu authored
The powerd battery info was designed to be a periodic signal. This was fine because the need was for low battery warning. Now that we want to display the Bluetooth battery values continuously, there is a problem where Chrome does not have the battery values after Chrome restarts (for example when signing out) until powerd's next battery poll. A workaround for this is to have an API in powerd for Chrome to request a signal for a Bluetooth device. This lets Chrome sync with powerd's battery values when Chrome starts up. This workaround will be removed when we migrate to go/bluez-battery-provider-api. Corresponding cras change: CL:2395856 and CL:2396355. BUG=b:166530001 TEST=Build chrome ash_unittests and run ash_unittests Connect Bluetooth Headset, logout and check if the battery level is shown after the logout Change-Id: I1f6785fab12d4f485eab01e552a2b869fd956d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395998 Commit-Queue: En-Shuo Hsu <enshuo@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#806092}
-
Mario Sanchez Prada authored
This CL migrates this legacy IPC message out of frame_messages.h to the LocalFrameHost mojo interface from Blink, by using the newly defined method SelectionChanged() in that interface. As part of the migration of the MessageOrderInDidChangeSelection test in render_view_browsertest.cc, this CL also updates that test to rely on gmock to ensure that the two messages are sent and that they happen in the expected order, allowing to refactor some code in that file. Bug: 993189, 1047379 Change-Id: Ia7f51a690fa45ba43e2016081d42c0381359c589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398618Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1599781911-7dd6ce5c7bf44a9e9e915c505640214d1e509445.profdata to chrome-linux-master-1599803297-c5d0441082dd5a8fa2a2c84cdf40fe1c77138c5e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I34a6e1da23e746c01d10e42d68edd0e352350b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405972Reviewed-by:
-
Gauthier Ambard authored
This CL removes the description of the error in the URL. Bug: none Change-Id: I2cfdbce6eddc1876c7ecf46d5bd2a7d395c0ba26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398498 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#806089}
-
Gauthier Ambard authored
This CL makes sure that the last committed item is trusted when it has a file scheme. I think this was the intend when the code was written as the check for the about scheme is here twice. Bug: 991608 Change-Id: I5b2f44351e8b73ccf3804c173db944d49557c477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401022 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806088}
-
