- 03 Jun, 2020 23 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/76a2918f55cd..cf77d6e387b6 2020-06-02 vapier@chromium.org repo: update to 2.8 launcher If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Test: Test: `repo sync` still works Change-Id: I4d6b3983bda93e662507076df2a4ad9781810b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227281Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774429}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88bc40da7991..9f2374511ab3 2020-06-02 chrche@microsoft.com Add customization to i18n.js 2020-06-02 cjamcl@chromium.org Update the fallback revision for remote modules. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I55982b72cb119c3db08625d8ce4f287a086a88e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227284Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774428}
-
Robert Liao authored
Change-Id: Ia30b175784474592469f9a862592125416d15726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227310 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#774427}
-
Yuwei Huang authored
Currently ftl_echo_message_listener_ is never explicitly freed, and it calls `signal_strategy_->RemoveListener(this)` in its dtor, while signal_strategy_ is freed in HostProcess::OnHostOfflineReasonAck. This causes a use-after-free issue when the ftl_echo_message_listener_ is explicitly freed, which means the host would crash in shutdown and soft restart. This CL frees ftl_echo_message_listener_ before signal_strategy_ is freed. Bug: 1090595 Change-Id: Ie546a9084fdf21545ecd9158b9830cc93335ecb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227265 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#774426}
-
Peter Kasting authored
This simplifies some code that no longer needs to worry about whether they're supported. Bug: none Change-Id: I728fb9a93373d6cb3674c5dbaecccce341774780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227101 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#774425}
-
Tina Wang authored
- Add customized item and cell for settings which has a toggle switcher once not managed by policy. - Apply to "Save Password" setting. - Add corresponding method to handle click action of the info button. Screenshot: https://screenshot.googleplex.com/6doUPsk0Dmj Bug: 1087223 Change-Id: I3140c7cfb99dbaf46f8679c4e675b9ab0002d6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219569 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#774424}
-
Bo Liu authored
Change-Id: I975b7d0bbd7bc7c002954939563d5e54cdcbc1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227375Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774423}
-
Scott Violet authored
To fully support onScrollOffsetOrExtentChanged() comes at a performance cost. As very few places actually need this, this creates a new interface with onScrollOffsetOrExtentChanged() and converts the places that need it to the new interface. BUG=1087480 TEST=none Change-Id: I1f54bdf74ee0b6006fc92284bc761ed6992a0d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225548 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774422}
-
Sammie Quon authored
Test: added test Bug: 1077922 Change-Id: Id596f604a24e230c818fa81c930782c9fa4841eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227289Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#774421}
-
Rouslan Solomakhin authored
Before this patch, Android integration tests for payment handler capabilities used the internals of ServiceWorkerPaymentApp.java, which prevented moving the payment handler logic from Java to the C++ service_worker_payment_app.cc. This patch replaces one Android integration test for capabilities with a cross-platform browser test. After this patch, fewer tests depend on ServiceWorkerPaymentApp.java internals, so its logic can be moved from Java to C++ easier. Design: https://bit.ly/cross-platform-pay-app-factory TBR=yusufo@chromium.org Bug: 1022512 Change-Id: I5d2bd943f079f501a681a5ef03d12329d3d91d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223650 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#774420}
-
Brandon Maslen authored
This change adds telemetry to the Storage Access API with the goal of tracking the utilization of the API and how the API is being used. This includes the following metrics: - UseCounter for document.hasStorageAccess and document.requestStorageAccess methods. - Histogram API.StorageAccess.AllowedRequests to track how often requests for storage access are allowed/blocked and specifically allowed due to the API. - Histogram API.StorageAccess.GrantIsImplicit to track how often requests generate an implicit vs explicit grant. - Histogram API.StorageAccess.RequestStorageAccess to track how the main method for the API is utilized and how frequently usage is successful or fails for various reasons. Various tests have been added where possible to validate the associated telemetry items have been fired. Bug: 989663 Change-Id: I44ecf8240ccfd50fee445e1782e9a578354ab68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211135 Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#774419}
-
Yoichi Osato authored
This CL relands the patch crrev.com/c/2172724, which was reverted as crrev.com/c/2224218 due to 1. linux-blink-cors-rel failure 2. http/tests/loading/bad-server-subframe.html failing on mac bots I fixed #1 by updating FlagExpectations/disable-features=OutOfBlinkCors. For #2, it is reported flaky: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAaHR0cC90ZXN0cy9sb2FkaW5nL2JhZC1zZXJ2ZXItc3ViZnJhbWUuaHRtbAw (guessed crrev.com/c/2219088 the culprit). Now this CL passes the bots. Bug: 688906 Cq-Include-Trybots: chromium/try:mac10.10-blink-rel,mac10.11-blink-rel Change-Id: I9d64f917014096f79b224369fc719e9743086b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226103Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#774418}
-
Garrett Beaty authored
Bug: 944108 Change-Id: I940c98b23f028d1f6e62d7880284f5dae6e82fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227509 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#774417}
-
Reilly Grant authored
UsbServiceLinux, HidServiceLinux and SerialDeviceEnumeratorLinux each only care about devices from a particular subsystem. This change avoids processing other devices which should decrease the time it takes to perform the initial enumeration. Change-Id: I3535b5e6ecbb8c013957197cff151011a19a6097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227094 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#774416}
-
Bill Budge authored
Bug: chromium:1089352 Change-Id: I4730c417100532410e9355a8fdf5551ee130138f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225591 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#774415}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cd6894f0a29e..bbbe9134378d 2020-06-02 bpastene@chromium.org devil: Remove special EBUSY error logging when mkdir'ing on devices If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:739899 Tbr: wenbinzhang@google.com Change-Id: Ic5194f779e084d7255796fac4396b738d391a33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227274Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774414}
-
Sammie Quon authored
Re-try of crrev.com/c/2182409. The change is the same but this time I was able to locally repro the original failure (and have no failures running this) and some fixes have landed since the last attempt. Test: none Bug: 1035356 Change-Id: Idc53b58a70f68be05b7ad36efb18c6facdb3ad56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226784Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#774413}
-
Khushal Sagar authored
This histogram is needed to track the proportion of devices with accelerated rasterization (drivers haven't been blacklisted) for which we want to have continuous monitoring. Bug: 1089346 Change-Id: I7b2dc36216fc91980c26ee34870be48eda952812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226783 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#774412}
-
Jinsuk Kim authored
Once theme change happens, the old StatusBarColorController needs to stop referencing the tab which is now being handled by a new instance after the reparenting. This CL makes sure to null out the reference. Bug: 1087257 Change-Id: Ib58f74b78fec84b197e501169be07f60a5532ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217724Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#774411}
-
tby authored
Change-Id: I7a20e77790f3ec4ffbdad575ef018617a84d85eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226482Reviewed-by:
Charles . <charleszhao@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#774410}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591084785-bc7c0a51a37ede3908243e746df6ba544dcec5c7.profdata to chrome-win32-master-1591113598-40e58c4b4405dc23a9940215457135cbcc33e410.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I7a89a6feb3e33d1a9811ab1ddda6708594e69ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226953Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774409}
-
Fred Mello authored
Extending the expiry date for all DFM "Android.FeatureModules." in tools/metrics/histograms/histograms.xml. These are still needed while we continue to troubleshoot a small number of issues. Changed owners to reflect a more up-to-date set. Bug: 1086211 Change-Id: Ie5d2f14a93af008134c4742cc8c59edbfb017ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225386 Commit-Queue: Fred Mello <fredmello@chromium.org> Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774408}
-
Austin Eng authored
Tbr=kainino@chromium.org Bug: dawn:449, dawn:323, dawn:399 Change-Id: I3f1892acad7c636e8c10f852510ed89972411f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226914 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Auto-Submit: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#774407}
-
- 02 Jun, 2020 17 commits
-
-
Carlos Frias authored
ChromeBackForwardCacheBrowserTest.WebBluetooth Test is flaky. It is reported as a hidden flake as it passes on retries. Cause identified: The test configures a mock Bluetooth adapter first and then performs a web Bluetooth API call. Although in some executions, it is observed that the browser has already started the initialization of the default Bluetooth adapter, when the test configures the mock adapter changing the adapter pointer, causing that the callbacks from the default adapter try to use an already released adapter pointer, thus reading from a nullptr, and crashing the test. Fix proposed: Move the MockBluetoothAdapter out from being configured at the specific test and instead be a class member and configured at test setup. By doing this the mock adapter is configured from the beginning avoiding the callback issue observed with the default Bluetooth adapter. Bug: 1087190 Change-Id: I3f2e8bd4159f072712f1082f05e35ec24f9b2f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220627 Commit-Queue: Carlos Frias <carlos.frias@microsoft.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774406}
-
Max Li authored
This will now be enabled by default, but disabled on specific problematic boards. See go/tethering-client-expansion for details. Change-Id: Ia9988e3d6ad3b249f9a80d78b8f8607129218137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222296 Commit-Queue: Max Li <themaxli@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#774405}
-
Nigel Tao authored
Bug: 1070409 Change-Id: I488a2edafed79e209f4ab89d56a54d4dd031b2eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224422Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#774404}
-
Peter Collingbourne authored
This is consistent with the other Alt shortcuts for which we also have Search shortcuts (Home, End, Bksp) and will aid in the possible future deprecation/removal of the Alt shortcuts. Bug: 1090186 Change-Id: Ifce1a066fb5bd5b27850625f759bbf815042147c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227052 Auto-Submit: Peter Collingbourne <pcc@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#774403}
-
Thomas Guilbert authored
These UMAs are some of the few that help us understand how casting is used in Chrome, and should be kept around. Bug: 1088675, 1088676, 1088677, 1088678, 1088679 Change-Id: I1e07e24e58d43f3b1ac4c240d5072466b15222b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227174 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774402}
-
Alison Maher authored
Extend the forced colors mode flag and the high contrast histogram from M85 to M88. Bug: 1088533,970285 Change-Id: I565ade742857c64c53a13eee8de8eaf745c21cf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225752Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774401}
-
Aaron Leventhal authored
AX-Relnotes: Omnibox accessibility reliability Bug: 943105, 1039422 Change-Id: Icf6adebabdcd7d9627c58f3c7260fc5359043fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226061 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#774400}
-
alanlxl authored
Version "20200601.0" is basically the same as "2019.11.12.0", only with a generic metrics model name in the meta JSON file. Note: The version schema is changed from "yyyy.mm.dd.sub" to "yyyymmdd.sub", that's because Omaha server automatically changes "2020.06.01.0" to "2020.6.1.0", while we want to keep the origin date string. All the future versions will be "yyyymmdd.sub". Bug: 1067048 Test: Tested on DUT Change-Id: I6b738698fd9b06c9edc666803630115509a736fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226104 Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#774399}
-
Tal Pressman authored
Change-Id: Id0cade394c0e730348f0bbbf5329444412f172a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225015Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Tal Pressman <talp@chromium.org> Cr-Commit-Position: refs/heads/master@{#774398}
-
Sergey Ulanov authored
The new function will allow SysmemBufferWriter users to get direct mapping to the buffer if they need it. Bug: b/158033083 Change-Id: Id6aeabf415a65f859d6d0add7015a8a7868946ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206339 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774397}
-
Eric Roman authored
The expected default is false, as that is what is used at other layers: * net::HttpAuthPreferences * prefs::kEnableAuthNegotiatePort * key::kEnableAuthNegotiatePort Using true can cause problems with integrated auth, as it constructs SPNs in the less common way. Bug: 924746 Change-Id: I2d09f0c72aa2ac8d8f60c1e2adfeb92c379d336b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225531 Commit-Queue: Eric Roman <eroman@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Auto-Submit: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774396}
-
Alan Cutter authored
When a user has a web app installed then uninstalled via policy we leave behind some policy install info in their prefs. This info is used by CanCreateWebApp() to determine whether there is an app already installed by policy. This causes a bug where users cannot install web apps after they've been removed from policy. This CL updates the check to also check whether the app is actually installed and not just check for the presence of the pref data. Bug: 1090182 Change-Id: I736118cec4e0b1ff34ae335965dc7b8816c20837 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224417 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#774395}
-
Daniel Rubery authored
The histograms show no major regressions on Canary/Dev. We'll need the increased data volume from Beta to validate the model performance improvements. Before doing so, enable the new model version in field trials. This should have no effect, since this parameter chooses a model version in communication with remote SB servers. Bug: 1054056 Change-Id: Ifa10a303d880cb05c5176a8813b2bece06a992f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216389 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774394}
-
Chris Blume authored
Android uses the dynamic color gamut to change gamuts as needed based on the content being displayed. There is a Finch experiment for this which is rolled out to 50% of Canary and Dev channels. This CL adds a field trial for that Finch experiment so bots can test the config. Change-Id: I112a9dc0f8edb99b39f227a81a7785527717db95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225622 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#774393}
-
Yi Gu authored
The TODO was introduced in crrev.com/c/548875. Bug: None Change-Id: I03f6061787278b04976c53c79760447a98c03346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227045Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774392}
-
Eric Lawrence authored
Users can easily lose work if they drag/drop a file or URL into a tab that does not consume the dropped data (e.g. as a file upload). Rather than navigating the current tab (blowing away whatever was in it), instead open the dropped URL in a new foreground tab. Bug: 451659 Change-Id: Ic7010a3c933d7747d4b70fefa4d0a5380448c58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213459Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774391}
-
dpapad authored
Some manual edits have been recorded in the form of "NOTE" comments, since the generation script still has some bugs. Bug: 1081815 Change-Id: I2d2fb4cf82d0b1467a0afd335cd61a3c68688990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212998Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#774390}
-