- 20 Nov, 2020 40 commits
-
-
Gauthier Ambard authored
This CL changes the update of the item's URL when the WebView URL is changed. If the new WebView URL is different from the URL of the item but is the URL associated with the session restoration of this URL, the URL of the item is no longer updated. Fixed: 1139289 Change-Id: Id3b31bfedeb6e84bc0527f642fa424e7f81381dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549620Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#829605}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c55cbc12. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I4e0fac974dfb7b276b33ffe57699a380fa3a6bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551514Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829604}
-
Amr Aboelkher authored
As the PSM switch kEnterpriseEnablePrivateSetMembership is going to be enabled by default. The tests should force disable it whenever the param of PSM state is disabled. BUG=chromium:1150878 Change-Id: If2a1d939f5c282e68a1bbfdcadf4293722568148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550074 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#829603}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/511da9af8056..a3b434580dbf 2020-11-20 bmeurer@chromium.org [sdk] Break another cycle between sdk/ and bindings/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083146,chromium:1150029 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib97e79a1deff43193c89548504556e49e7d4d077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551230Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829602}
-
Wez authored
The MetricsRecorder is requested once during web.Context startup, and the request is routed to one of the running CastComponents. Now that the Context may be launched on-demand, to serve FrameHost requests, update the CastRunner to allow the FrameHostComponent to be used to route the MetricsRecorder capability. Bug: 1150776, 1120914 Change-Id: I6d5d336ef7d7af6d0c664e85e8b05f9b6813a5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550543 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829601}
-
Asami Doi authored
This CL just updates a WPT (clim-worker-fetch.https.html) to use async/await instead of Promise/then(). This doesn't add a test nor change the test result. Change-Id: I042d0947b4593825fc58fb00dc9537cc0e102c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550101 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829600}
-
Rahul Goyal authored
Did client changes to set a11y strings from backend for AssistantChipViewHolder.java Bug: b/171963823 Change-Id: Id3a5d80cb08f065423db52c0bf66ac8af71415b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532079 Commit-Queue: Rahul Goyal <goyalrahul@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829599}
-
Pavel Yatsuk authored
SavePasswordMessageDelegate::DisplaySavePasswordPrompt accesses member field web_contents_ before assigning it, causing null pointer dereference. The function is the only one not covered by unittest which made the issue committed unnoticed. BUG=1123947 R=vasilii@chromium.org Change-Id: Iac6c4e2c0d5b4b348883812c14a8c541e91fd238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550608 Auto-Submit: Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#829598}
-
Mirko Bonadei authored
Bug: webrtc:12212 Change-Id: Ib845403ce4c83597f7304829b7f978eee7025074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550670Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#829597}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8930f18245df..777749aafaac 2020-11-20 b.schade@samsung.com Vulkan: Fix image copies with renderbuffers 2020-11-20 cnorthrop@google.com Capture/Replay: Limit GL_MAX_IMAGE_UNITS during capture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: LEGO MECTest: Test: dEQP-GLES31.functional.copy_image.*renderbuffer* Change-Id: Ief33c3f6274490f6a0be694310e2f904dbce2e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551977Reviewed-by:
-
Miriam Polzer authored
ChromeOsReleaseChannel is only honored if ChromeOsReleaseChannelDelegated is False and the release channel on devices can only be switched if ChromeOsReleaseChannel is set to True. Update comments and policy description to match the behavior. Bug: 1147003 Change-Id: I72436eb3d50df9755c88aeec17b099e2a3d26b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549923Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Miriam Polzer <mpolzer@google.com> Cr-Commit-Position: refs/heads/master@{#829595}
-
Amr Aboelkher authored
This CL includes all PSM UMA histogram unit tests. That's also including the comparison between PSM and Hash dance UMA tests. BUG=chromium:1136866 Change-Id: I67614870c3355853e8aa29b49499f1897cbd877d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546012 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Add support for specifying specific frame IDs (one or multiple) in the chrome.scripting APIs (scripting.executeScript and scripting.insertCSS). Add tests for the same. Bug: 1148878 Change-Id: Idae2940c9bfe1d7b9d456799da941083eac2df0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547432 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#829593}
-
Bao-Duy Tran authored
This enum is only applicable to InputMethod.ID2 [1], a sparse histogram (not an enum histogram). Its reverse mappings from numerical values to string labels aren't exhaustive by nature. In particular, there are only mappings for 1P input methods of Chrome OS. No mappings for open-source Chromium OS nor third-party IME extensions. At some point, the numerical values corresponding to Chrome OS input method IDs were changed (due to [3]) and thus the mappings had to be adjusted [4], with many marked as obsolete (with a suffix "_old") but not removed (likely to facilitate analyses of data recorded prior to [3] in the transitional period back in 2017, circa M60). Now that more than three years have passed, it's unlikely we'd need to analyse pre-M60 data, all "_old" ones can be cleaned up. These removals are effectively the same as adjusting the labels to 'unknown', which is permitted by UMA guidelines. In the highly unlikely event that we need to interpret pre-M60 data, the mappings can always be resurrected from Git repo history, or derived manually again in the same way as when analysing data from open-source Chromium and 3P IME extensions. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/input_method/input_method_manager_impl.cc;l=1004;drc=f395ddcfc286124a44d175c2d48113ee75244234 [2] https://source.chromium.org/chromium/chromium/src/+/master:tools/metrics/histograms/histograms_xml/obsolete_histograms.xml;l=27595;drc=3e63c87eac95d1fc8405443ebfabd70e666bf83f [3] https://chromium.googlesource.com/chromium/src/+/df82c2f1f609cfe5cead26794eeb85320594c904 [4] https://crrev.com/c/1124212 Bug: 1150183 Change-Id: Ia9af662db2c7e5d71f71f5dd1b45af5576c43da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546385 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829592}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605830203-b886e962da8895514d6a5d81640dc11fdcd7ef55.profdata to chrome-linux-master-1605851942-6f480177b4524c7e895c150a8dd7d9195900edb6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6b6876a47bb3a001adc07abfa7e0f2ad3e9294ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551959Reviewed-by:
-
Egor Pasko authored
Remove the workaround for a bug that was fixed in the NDK in 2013. Bug: None Change-Id: I6b1e25c53c9b6d86604c3ae796d36ca5e2e50937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550801 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#829590}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7ab0cbf6d83f..9ac93dfb7d8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shimazu@google.com Change-Id: I7a7290269199734001c9849c02da1f42e10af68d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551508Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829589}
-
Nick Diego Yamane authored
R=oshima@chromium.org Bug: None Change-Id: I156235abba5234e964260d40f07547d86fa7e8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546960 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#829588}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id2b4f554a1eafc7400a7ec49b5fe5b0eac1b17df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551545Reviewed-by:
-
Ankit Kumar 🌪️ authored
Add AccessibilityPageInfo in pdf/ to replace usage of PP_PrivateAccessibilityPageInfo. PP_PrivateAccessibilityPageInfo is a Pepper struct. The new struct ensures that PP_PrivateAccessibilityPageInfo is scoped to parts specific to Pepper implementation. Bug: 1144444 Change-Id: Id0cf87848a5e7fa936647475e8e204ead4dbe084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546661 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#829586}
-
Matthew Denton authored
GCC seems to have a bug with constexpr when this flag is present: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97913 So enable it only on clang for now. Bug: 1139129 Change-Id: If657d5e3fac1621adf57c266cfd64ce628dc7b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551494 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829585}
-
Makoto Shimazu authored
TBR=michaelpg@chromium.org No-Try: true Bug: 1150349 Change-Id: Ib27007ecf4929f227fa9e7925fefa4bfed903c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551885Reviewed-by:
-
Ian Struiksma authored
Tests have been stable after changes were made in crrev.com/c/2490868, removing debug logging. Also enabling test 'FillChangeSecondFieldRefillSecondFieldClearFirst' which was disabled under same bug. Bug: 967588 Change-Id: I7da6b5c24424d6763d59ea93c9cd067139fc641e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550609 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#829583}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/330b60556789..26ced490899d 2020-11-20 linxinan@chromium.org Improve the readability on variable name added in crrev/c/2528670 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1146487 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ida94502ef59e3ff6a3916e8e54d9a1a3468b3522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551507Reviewed-by:
-
Makoto Shimazu authored
TBR=tbarzic@chromium.org No-Try: true Bug: 1151205 Change-Id: Id39eb0bf84373073db454ba94c0d76c006b12b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551884Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I66ef180d2f9591681fe8e9c8f3c70bf760b18c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536428Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829580}
-
Dominic Mazzoni authored
Bug: 897365 Change-Id: Id88ee9a1a83c4f8b918c688732d30ba037c441bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550527 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#829579}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4f660f22d9eb..9dce4d081f8a 2020-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 8b76d37f9f9a to 777749aafaac (19 revisions) 2020-11-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from ce207be41fd6 to 1a14e7e02441 (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Test: Test: Test: LEGO MECTest: Test: dEQP-GLES31.functional.copy_image.*renderbuffer* Change-Id: Iacaeb12d720a057ab9e8b89dd2397941a00e5967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551505Reviewed-by:
-
Makoto Shimazu authored
This reverts commit f219c238. Reason for revert: LocalStorageImplTest.CorruptionOnDisk became flaky. Three builds are failing in a row. Example build: https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64%20%28dbg%29/18708 Original change's description: > Constrain DOM Storage backend lifetime > > LocalStorageImpl and SessionStorageImpl are self-owned objects with > lifetime loosely bound to their corresponding Mojo interface receivers. > This means it's possible for them to outlive the service itself (i.e. > the StorageServiceImpl instance) and continue scheduling work during > the service process's shutdown. They also use shutdown-blocking > TaskRunners for some of their tasks, which is problematic given the > potentially too-long lifetime: if a non-shutdown-blocking task races > with shutdown completion and then attempts to schedule a shutdown- > blocking task, we have a bad time. > > This CL fixes the issue by changing LocalStorageImpl and > SessionStorageImpl to have stronger ownership within PartitionImpl > and initiating an explicit shutdown step when the partition is > torn down. This step effectively inhibits the scheduling of any > subsequent non-shutdown-blocking tasks for these objects, ensuring > that any remaining work comes in the form of shutdown-blocking tasks > scheduled prior to or during the explicit shutdown step, or from > other shutdown-blocking tasks posted by those tasks. In other words, > shutdown remains continuously blocked until these objects are done > scheduling work. > > This achieves the same shutdown-blocking behavior without the risk > of a race against shutdown completion. > > Fixed: 1135957 > Change-Id: Ie2fcc25df7fafe390c736d2c56d139433c69bf8c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533934 > Reviewed-by: Victor Costan <pwnall@chromium.org> > Commit-Queue: Ken Rockot <rockot@google.com> > Cr-Commit-Position: refs/heads/master@{#829483} TBR=rockot@google.com,pwnall@chromium.org Change-Id: Ibad7482357ba3122fd88afad31ed4a85b6651c83 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551866Reviewed-by:
-
Makoto Shimazu authored
This reverts commit 32cf67c4. Reason for revert: these two tests added in this CL were flaky - OverlayPopupAdViolationBrowserTest.OverlayPopupAd_AdInterventionTriggered - OverlayPopupAdViolationBrowserTestWithoutEnforcement.OverlayPopupAd_NoAdInterventionTriggered sample builds: https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/5924 https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/39438 Original change's description: > Sticky and Overlay-popup ads recorded in ads intervention manager > > This change propagates signals for sticky ad and overlay-popup ad > detection from the renderer to the ads intervention manager through > the subresource filter component. > > As the ads intervention manager is running in dry run mode and > does not block ads, this allows us to record intervention behavior > when triggered by one of these two interventions. Understanding > the intervention behavior is a precursor to the ads intervention > manager intervening to actively intervening on sites with better > ads standard violations. > > Add base::Feature flags to allow disabling the frequency capping from > either web_tests and browsertests. Move relevant tests into a virtual > test suite that has the flag disabled. > > Bug: 1099741 > Change-Id: Id0c922adfbb7cd71f641c6e9586eed9c311feb18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525769 > Commit-Queue: Yao Xiao <yaoxia@chromium.org> > Reviewed-by: Eric Robinson <ericrobinson@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Stefan Zager <szager@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829547} TBR=dcheng@chromium.org,szager@chromium.org,alexmos@chromium.org,ericrobinson@chromium.org,yaoxia@chromium.org Change-Id: Ibe952a34ab4cc194f318497a631e01f96d665e71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1099741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550017Reviewed-by:
-
Yutaka Hirano authored
- ScriptPromise corresponds to Handle<v8::Promise> and ScriptValue corresponds to Handle<v8::Value>. Hence conceptually ScriptPromise should be convertible to ScriptValue, reflecting the fact that v8::Promise is a subtype of v8::Value. Rename ScriptValue::GetScriptValue to ScriptValue::AsScriptValue, for the explicit conversion. - Add V8Promise() which returns a v8::Local<v8::Promise>. The function is safe because `promise_` always stores a v8::Promise as long as it's non-empty. Bug: None Change-Id: Ie21703e2673a7c0443259c61bfca11379d758e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549320Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#829575}
-
Polina Bondarenko authored
Add ArcDataRemoveRequestObserver to stop TakeSnapshot flow when kArcDataRemoveRequested is set to true. BUG=b:161221001 TEST=components_unittests Change-Id: Ic59bbc3c5b74b7927b4d5bdfead523bb12de46b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537964 Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Oleksandr Peletskyi <peletskyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829574}
-
Daniel Hosseinian authored
With the PDF Viewer update, the plugin's viewport no longer takes the size of the entire frame. Additionally, the toolbar no longer overlays the plugin. Consequently, the plugin has an offset relative to the frame. The plugin's size and offset can change with the toggling of the sidenav. Send the plugin offset to PdfAccessibilityTree so accessibility rects can have the correct transformation. Bug: 1150660 Change-Id: Idef25f31cfbfa459e317b6f003a289fcb8daac19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551465Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#829573}
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: Icd81a140a5c542148b95e7037cf9c44d9e65ce9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537278Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829572}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a241aa984fd6..511da9af8056 2020-11-20 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I80341f3ee0432527f7c8c9b558c614088f4b78b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551228Reviewed-by:
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_CHROMEOS_ASH) and GN variable is_chromeos with is_chromeos_ash with some special cases (For those cases please refer to http://go/lacros-macros). The patch is made in preparation to switching lacros build from target_os=linux to target_os=chromeos. This will prevent lacros from changing behaviour after the switch. Bug: 1052397 Change-Id: I59c92c79d224aaf14b3a85c6c56d45222ebcd670 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536583 Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#829570}
-
Bao-Duy Tran authored
This enum is only applicable to obsolete InputMethod.ID histogram that's been deprecated since M46. Therefore it should have been marked obsolete together with the histogram's deprecation 6 years ago (July 2014, see https://crrev.com/254e75d880369bf49bdf0e8ccc400ab71f6f2fee). The enum ID needs to be marked obsolete (and not removed), as per UMA guidelines to avoid inadvertent reuse that causes confusion in future. Enum etries can however be completely cleaned up, because InputMethod.ID was a sparse histogram (not an enum histogram) and these reverse mappings from numerical values to labels aren't exhaustive anyway. These removals are akin to adjusting the labels to 'unknown'. These removals only make interpretation of old data inconvenient. It's however unlikely we'd need to analyse data of deprecated InputMethod.ID metric that's no longer been recorded for the past 6 years. In the highly unlikely event we need to do so, repo history is at our disposal. Bug: 1150183 Change-Id: I3f274c038be1b334a4e49ccbef3bae518ede0019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546345Reviewed-by:
Jing Wang <jiwan@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Cr-Commit-Position: refs/heads/master@{#829569}
-
Kenichi Ishibashi authored
Before this CL, the callbacks of the following methods were passed directly to mojo remote calls: * UpdateLastUpdateCheckTime * UpdateNavigationPreloadEnabled * UpdateNavigationPreloadHeader As a preparation to support retry for these calls, this CL introduces ServiceWorkerRegistry::DidUpdateRegistration and passes it as the callbacks of remote calls. DidUpdateRegistration keeps the original callbacks and runs the callbacks when ServiceWorkerRegistry gets responses for them. DidUpdateRegistration also checks the result of remote calls. If it's a disk error, it schedules DeleteAndStartOver as the same as other DidXXX callbacks do. This CL doesn't add the retry mechanism for these methods yet. DidUpdateToActiveState is merged into DidUpdateRegistration because it does the same thing. Bug: 1133143 Change-Id: I50bd2f526c9cef03277ae2c3da81a6eb7aa8b63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550112Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#829568}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605808617-3dd590b3717c834812eb8652d51332097d715185.profdata to chrome-win64-master-1605819430-f29c6c0acb8066d29cda4fb937b7ae2e0e828814.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id5a80fb4b5238839eb88ea125e490ba264c9092d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551306Reviewed-by:
-
Mason Freed authored
Per the comment, the allowable values come from the enum in feature_policy_features.h. There is no DisableForAll. TBR=iclelland@chromium.org Change-Id: I1509a66c570dbb0c2b34876019f965446f91093c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551958Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#829566}
-
