- 25 Oct, 2019 40 commits
-
-
Chih-Yu Huang authored
Currently only ChromeOS platform uses ImageProcessor. This CL moves the related files from //media/gpu to //media/gpu/chromeos. BUG=chromium:1012587 TEST=ninja chrome on kevin, eve and target_os="chromeos" TEST=ninja image_processor_test on kevin and eve TEST=gn check on kevin and eve Change-Id: I3af70f388407045e5bbb2f938f16f66c3f0eb3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875667Reviewed-by:
Shuo-Peng Liao <deanliao@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#709360}
-
Rakina Zata Amni authored
We want to ship non-relationship aria properties on ElementInternals first, because the relationship properties are still WIP. We are also removing the string version of the relationship properties. Change-Id: Iccd73d1c9b1b31a431764e7989083dac43ed76d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874751Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#709359}
-
Yoshifumi Inoue authored
This patch Introduces member functions in |NGInlineCursor| to utilize in AbstractLineBox[1]: - MoveToNextLine() - Predicates * IsEmptyLineBox() * IsInlineLeaf() * IsListMarker() [1] http://crrev.com/c/1877499 Utilize NGInlineCursor in AbstractLineBox Bug: 982194 Change-Id: Id6eb2d95902ae0d2222715f592993bf1e33c472f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877498 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709358}
-
Alice Boxhall authored
Also, move UpdateHadKeyboardEvent() call into KeyboardEventManager::KeyEvent(). Happy to revert the latter change if folks don't like it, but it seemed logically consistent with e.g. gesture detection. Bug: 920458 Change-Id: Ia423a0533325314ae4f83e619337b5a81af0f4c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871715 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#709357}
-
Yoshifumi Inoue authored
This patch changes |SelectionTopAndBottom()| for |LayoutReplaced| to use |NGPhyiscalBoxFragment| instead of |NGPaintFragment| for preparation of migrating |NGFragmentItem|. Bug: 982194 Change-Id: Icecde9639f340d61aa971e4a5c917738f62fe2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877878 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709356}
-
Jinsuk Kim authored
This CL turns the method to private-package after refactoring the remaining callsites outside the tab package. - ChromeDownloadDelegate: the context got left unused after going changes. Just removed it from the parameter. - ReparentingTask: Passed to a new Intent, which was for getting its package name. So doesn't have to be ThemedApplicationContext. The underlying application context works as good. Bug: 995903 Change-Id: Ic21d8f98aba3e8d6a557c0cbdedb6916f86f87e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866494 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#709355}
-
David Tseng authored
Change-Id: I8d8b30665ac9627c010002561e710449311a952b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879333Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#709354}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/794ed818b893..651618043819 git log 794ed818b893..651618043819 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 thestig@chromium.org Get rid of some longjmp() usage in CFX_BmpDecompressor. Created with: gclient setdep -r src/third_party/pdfium@651618043819 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: chromium:1017253 Change-Id: Iaabf49bb137d95c70c7adc24cbd0d9b73f55192a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880379Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709353}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a9229043e357..ef0e4d043845 git log a9229043e357..ef0e4d043845 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e1ab9e9b..64883b3e (709180:709283) 2019-10-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d7338c33..e1ab9e9b (708965:709180) 2019-10-24 gustaf@webrtc.org AEC3: Support negative delay with external delay estimator Created with: gclient setdep -r src/third_party/webrtc@ef0e4d043845 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None,chromium:b/130016532 Change-Id: Ie52b1de2f96fe109c7d3ec840615211507649470 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880378Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709352}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5d8831fefd51..849d640a644f git log 5d8831fefd51..849d640a644f --date=short --no-merges --format='%ad %ae %s' 2019-10-25 vapier@chromium.org clean up module import ordering and drop pylint-1.7 workaround 2019-10-25 vapier@chromium.org cros lint: upgrade to pylint-1.9 Created with: gclient setdep -r src/third_party/chromite@849d640a644f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2b181945de8105d17c4fd338bb70e66380aacc48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880377Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709351}
-
Jason Lin authored
Bug: 929571 Change-Id: Ia0a3153e15ed6ec773084a3431ffdffe5566e76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871714 Auto-Submit: Jason Lin <lxj@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#709350}
-
Meredith Lane authored
virtual/threaded-no-composited-antialiasing/animations/custom-properties/registered-var-to-registered.html virtual/threaded-no-composited-antialiasing/animations/custom-properties/registered-var-fallback.html TBR=xidachen@chromium.org Bug: 1018027 Change-Id: I390670347c9bd07437fe59faac5e4c2cbb97eb8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880410Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709349}
-
Peter Collingbourne authored
These will be required in order to use Trichrome in the 64/32 configuration. Bug: 1010749 Change-Id: I9ba165b13a5ad8034496b5795a53de35847e3786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834847Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Auto-Submit: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#709348}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/342fbc54844d..28a8f28b3eaf git log 342fbc54844d..28a8f28b3eaf --date=short --no-merges --format='%ad %ae %s' 2019-10-25 bsalomon@google.com Rename functions in TestUtils.h Created with: gclient setdep -r src/third_party/skia@28a8f28b3eaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: Ice9287788264370dea96da5781e1de1c0a8089c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880638Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709347}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I9acd88d8d96c7bb52946d1fb55cb046717fc392c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880532Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709346}
-
Kenichi Ishibashi authored
Some comments were outdated and mentioned classes which no longer exist. Update these comments. Bug: N/A Change-Id: I2264e8a664d2a74f56080f8a4ccdc98d1fd0a5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880239 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#709345}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I8739274490cab8399460cdaf6e9703d8236ad8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880667Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709344}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/98c55a366e1b..a4271e070be6 Created with: gclient setdep -r src-internal@a4271e070be6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:1014539 Change-Id: If919a5560ff6f599b8fa0f702059cdcf443d1a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879526Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709343}
-
Nick Harper authored
Removal was requested via email and verified via DNS TXT record. Change-Id: If45eef4aa7fdb9fde102ee18c7cafa1f72aab8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880588 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709342}
-
Marina Sakai authored
This CL replaces the old GetSymbol, which uses void* as a key, with the new GetSymbol, which uses an instance of SymbolKey created in CL1877490 as a key, in GetHistoryStateSymbol. Bug: 715418 Change-Id: Iab40205b1793c42ef8cedf82ee9f9ea2ee46c337 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877501 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#709341}
-
Rakina Zata Amni authored
Currently SearchBox is using the default per-thread task runner for its mojo bindings. We are converting it to use per-frame task runner so that BFCache can freeze the task runner correctly and don't need to evict the page in case it receives mojo messages for SearchBox. Change-Id: I16ddd7a19b4da0fec3eba61318e8901cb210b7af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877488 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#709340}
-
Piotr Bialecki authored
Fixed: 1008199 Change-Id: I3037a9435c7d4e3f9d719275d8c538f8c2876e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876203 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#709339}
-
Emircan Uysaler authored
This is a reland of a2c0ced3 Original change's description: > [Fuchsia] Reenable protected mode in WebEngine > > Bug: 982922, fuchsia:24570 > Change-Id: If9fb495249488c43f97e4451a14f0193911d600f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804527 > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#697683} Bug: 982922, fuchsia:24570 Change-Id: Id4c70e7efbc1ba5c39f08178c5f8c62559838973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877193Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#709338}
-
Nate Fischer authored
This adds a test suite for WebView's metrics integration. This verifies WebView correctly configures the MetricsService such that it logs values for proto fields in the UMA record. Most of these tests won't validate the values make sense (verifying this logic should be in unittests for each MetricsProvider), but rather that the field itself is populated (as the status quo is many fields are simply not populated). This configures the MetricsService to upload the initial log record very quickly, as an optimization in the test case (the current delay of 20sec would not be acceptable for each test). This does not modify the interval between subsequent uploads, as each test case runs in a separate process, so we'll never reach subsequent uploads. Bug: 1011991 Test: run_webview_instrumentation_test_apk --gtest_filter=AwMetricsMetadataTest.* Change-Id: If8b0400ec9904258ba9ae653e98b9c6d53a36d1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854507 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#709337}
-
Jinsuk Kim authored
This CL fixes a bug that shows a blank navigation sheet when invoked while other bottom sheet is visible. When it cannot be opened, it removes itself from the bottom sheet queue to prevent it from showing up later. Bug: 1016750 Change-Id: I0f0cee5088832224706ea7b999e9843420bdc0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875888Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#709336}
-
Marina Sakai authored
Currently the API |GetSymbol| in V8PrivateProperty is used to get Symbol using HashMap with a static variable address as a key. However, this key is not suitable for tracking private properties because the type is void*. We can improve the tracking ability by using an instance of private property key dedicated class instead of void* type. This CL creates a new class which is dedicated to private property keys, and adds a new API to get Symbol using an instance of the class. Bug: 715418 Change-Id: Ieac862e8e2b5406a2c35c1a1f3368494833c3287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877490 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#709335}
-
Joel Hockey authored
Change-Id: I137e4deaf16599b5ce304382b1d805914d77d69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879390 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#709334}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/de9e3cabe60e..86244d691364 git log de9e3cabe60e..86244d691364 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 vadimsh@chromium.org [lucicfg] Update from v1.8.6 to v1.11.4. 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-24 ehmaldonado@google.com presubmit: Run tests on Windows. 2019-10-24 jmadill@chromium.org git-cl: Add 'format-full-by-default' setting. Created with: gclient setdep -r src/third_party/depot_tools@86244d691364 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I9c192ac3488b956e8584ee25d3e42b11ea80278f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879586Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709333}
-
Jinsuk Kim authored
This reverts commit 62dae75f. Reason for revert: this time will land the internal cl https://crrev.com/i/2015128 asap to keep the build green Original change's description: > Revert "Android: Private-package Tab.setIsShowingErroPage" > > This reverts commit 1e252fbf. > > Reason for revert: this change broke the internal build https://ci.chromium.org/p/chrome/builders/ci/android-internal-chromium-tot/b8898843520461106640 > > Also, TabTestUtils.setIsShowingErrorPage() isn't defined as static, so the error couldn't be fixed in 1 internal CL. > > Original change's description: > > Android: Private-package Tab.setIsShowingErroPage > > > > The method is called by a class in chrome.browser.tab package > > in production code. Makes it a private-package method. > > > > Bug: 995903 > > Change-Id: I5f8b73200ae4a3c966b140a44e63cfc991f9b249 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872079 > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#708466} > > TBR=dtrainor@chromium.org,jinsukkim@chromium.org > > Change-Id: Ieed0cf2e34f59cf4f7e68a4eb44dea0ea2f561aa > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 995903 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876389 > Reviewed-by: Alex Ilin <alexilin@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708594} TBR=dtrainor@chromium.org,jinsukkim@chromium.org,alexilin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 995903 Change-Id: I28634b5fd495b50823158f34589c032e472d988b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880231Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#709332}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/25df51372600..5d8831fefd51 git log 25df51372600..5d8831fefd51 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 ahassani@chromium.org chromeos_config: Mark littlejoe and viking as experimental Created with: gclient setdep -r src/third_party/chromite@5d8831fefd51 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2c917493eb7954e52b11da64b55da008d22a1dd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879522Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709331}
-
Frank Liberato authored
|textures_per_picture| is an implementation detail of the binding texture wrapper. This CL moves it entirely there, rather than having it passed in from D3D11VideoDecoder. Change-Id: I1cf12bfd4bcc52defd3610e0a9e0f94cd41129ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876759Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#709330}
-
tby authored
This is the first change to convert the existing hashed logging code into a general framework. This CL mostly removes code that was specific to the search ranking use of hashed logging, and also changes the API for logging. Note that all hashed logging has been disabled for this refactor. We need to delete this code now because there's a chain of dependencies between the refactoring CLs. Roughly: 1. Code referencing the current proto used to report logs must be deleted. 2. The proto itself can then be changed internally, and re-exported to chromium. This has to be done as a unitary CL, with no other changes. 3. Then, code can be re-added that references the new version of the proto. Detailed changes: 1. AppListLaunchRecorder::Record has become ::Log, which now takes lists of hashed and unhashed data. This is a tentative first try at the new API. 2. The core hashed logic in AppListLaunchMetricsProvider has been deleted, because it will need to be generalized. 3. The unit tests have all been disabled and the core EXPECT logic removed. This too must be rewritten for the generalized version. Bug: 1016655 Change-Id: Iccc98771003c602b1a8375b4b2898e077f28def6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874411Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#709329}
-
Chris Mumford authored
media::remoting::RpcBroker::ReceiveMessageCallback is used for callers that wish to process messages via a call to RpcBroker::ProcessMessageFromRemote. As it is legal to call ProcessMessageFromRemote multiple times switching ReceiveMessageCallback from base::Callback to base::RepeatingCallback. Bug: 1007810 Change-Id: I3479ea065a4b1bc743f41e300f9ded81401b6415 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875272Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#709328}
-
rbpotter authored
Use rollup along with existing Polymer CSS build and Uglify tools to bundle Polymer 3 pages in optimized builds. This will be used by the extensions Web UI in a followup CL: https://chromium-review.googlesource.com/c/chromium/src/+/1817293 Bug: 965770 Change-Id: Id4538b5628d1d59824300598082d89ea316eb628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846752 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#709327}
-
Tsuyoshi Horo authored
We don't need this PostTask after NavigationLoaderOnUI. This method is always called on the UI thread. Bug: 824854, 1016865 Change-Id: Id8c5117ffead8860e660b4483465408ab18510c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880488Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709326}
-
Sven Zheng authored
There are some e2e tests which set passphrase. After they run, we can not reset account because we can not start sync. With this change, account can correctly sign in after those tests, no matter the account requires or not the passphrase. TEST: tested e2e tests can still pass. Bug: 1010568 Change-Id: I91ddf83fee188c5f6a16f8f97ded482437c21398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867470 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#709325}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b653813d5814..342fbc54844d git log b653813d5814..342fbc54844d --date=short --no-merges --format='%ad %ae %s' 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@342fbc54844d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I5ab954422127e58dbd3145bd252d623dea96426b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879583Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709324}
-
Wei Wang authored
This patch makes BlobToString()/CopyBody a helper function in storage/browser/test/blob_test_utils.h which can be used by service_worker_browsertest, cache_storage_cache_unittest and background_fetch_data_manager_unittest. Bug: 931094 Change-Id: I672e0896b9c817d6eeb7e61c1c02736aa62fad12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865708Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Wei4 Wang <wei4.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#709323}
-
Chris Palmer authored
Performance regressions, alas. Bug: 1005070, 1013329, 1013326, 1013324 Change-Id: I15c0a539d5adde6f86de98ceec301863708307f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880145Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#709322}
-
Meredith Lane authored
TBR=michaelpg@chromium.org Bug: 1018012 Change-Id: If3de2ca1745a674f2a4b972fcf72b683cde61bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880408Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#709321}
-