GitLab

This is needed due to a specific requirements for integration with the
extensions Management API, which needs to first create the dialog, then
create the callback that takes ownership of the dialog instance, then
show the dialog.

That order isn't possible when the dialog's callback is set in
its constructor.

Also remove unused ShowParentPermissionDialog...() fns from
SupervisedUserService since we need to create the dialogs directly to
achieve the pattern described above.

Bug:957832

Change-Id: I9852a4ecbe12babfadd3a806513713d2085b3d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088952
Auto-Submit: Dan S <danan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Dan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747827}

Different VkImageUsageFlags may create VkImages with different
characteristics. glTexStorageMem2DEXTFn doesn't accept a usage flag
argument, instead the spec requires us to request all supported flags for
allocations that will alias GL textures.

This fixes ExternalVkImageFactory to comply this requirement. It's an
issue on ARM where VK_IMAGE_USAGE_STORAGE_BIT affects VkImage memory
requirements.

Bug: 1058958

Change-Id: I711f8463f709e9c77811325e004018c87bcd0626
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090454Reviewed-by: Peng Huang <penghuang@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747826}

When the last tab in the grid tab switcher is removed, remove all the
message items appended. Notice that different from invalidating the
message items, this would just temporarily remove them and will restore
message items if needed when the tab switcher is no longer empty.

Bug: 1050443
Change-Id: Ia5e0aa36c7ac35ad59027fa2ebab25343029e3dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083566
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747825}

NextAfter(kBegin, ...) has two callsites - ComputeNextIntervalTime() and
HandleIntervalRestart(). In the latter we don't need to take any
specific care about an "indefinite" value in the begin instance list
(because an interval will never "end after" "indefinite"). For the
former, the check ought to have no practical effect but we keep it
around for clarity.
This makes NextAfter() behaviorally independent of the |begin_or_end|
argument, which in turn makes it easier to factor out. Factoring the
list handling out will make it easier to add certain list-related
optimizations.

Bug: 1039243
Change-Id: I0eaa12a08e1b8e330955f486880cb3a9f4d99f78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089689Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#747824}

Drag handle is used as an anchor for in-app to home contextual nudge,
and for login shelf swipe contextual nudge. By default, anchor bounds
are derived from the anchor's bounds in screen. This generally works,
but due to the way shelf widget (who owns the drag handled) bounds are
animated, relying on bounds in screen could end up misplacing the
contextual nudge widget when bounds change.

The shelf widget is animated by setting it's target bounds, and then
animating a transform that matches the current shelf position to the
identity transform. This means that when the widget bounds are set, the
widget might have non-identity transform. GetBoundsInScreen will take
that transform into account, and cause the nudge widget to be positioned
relative to the current widget position, instead of the target one.

This updates the logic for calculating drag handle anchor bounds to
ignore the shelf widget transforms. Additionally, it is changed to
ignore the drag handle's transform as well - the drag handle gets
translated using a transform when in-app to home  nudge is shown, but
the nudge bounds are set relative to the handle bounds with no
transform, and in addition have the identical transform set.

BUG=1058615

Change-Id: I1e398cf2e0d149c0bb9b2bea22651196a26b89fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091271
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747823}

Bug: 1007815
Change-Id: I66bd17ffad93f40b404aab1ff2647ab2e7a0f836
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091492
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747822}

Recently we noticed the libassistant.log file is always empty when
running the Assistant on real hardware.

The root cause for this is that LibAssistant started disabling logging
by default.  This CL enables the flag to enable logging in LibAssistant.

Tests: Deployed on real hardware and verified the logs are populated.
Bug: b/148693233
Change-Id: I2e12742f57649b108e49a825c3d83e8dae4645da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088217Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Jeroen Dhollander <jeroendh@google.com>
Cr-Commit-Position: refs/heads/master@{#747821}

Bug: 1054966
Change-Id: I93f73023e6e6bdc24c329c36b2b14323522a078c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085156
Commit-Queue: Yann Dago <ydago@chromium.org>
Auto-Submit: Yann Dago <ydago@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747820}

Now that user activation is successfully propagated between inner and
outer web contents (crbug.com/934637 and crbug.com/1013447), the
history intervention can be enabled for plug-in cases.
This reverts the changes in
https://chromium-review.googlesource.com/c/chromium/src/+/1623137
and adds tests.

Bug: 965434
Change-Id: I38859bdba998d8b769ddcfeb979752df5939f0a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090093
Commit-Queue: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747819}

This cl fixes an issue where it is not possible to build a stable
channel public build without enabling check_android_configuration (due
to gn failure from useless assignments).

Change-Id: I5b2ecf2a9d9529b75383b2a498e4a6240a89c186
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090139
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747818}

This reverts commit a65d1637.

Reason for revert:
https://chromium-review.googlesource.com/c/chromium/src/+/2087971
was reverted.

Original change's description:
> Remove unused headers in task_runner_util.h after fixing IWYU
> 
> Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2076423
> After https://chromium-review.googlesource.com/c/chromium/src/+/2087971
> and https://chromium-review.googlesource.com/c/chromium/src/+/2087892
> 
> R=​ajwong@chromium.org
> 
> Bug: 1026641
> Change-Id: Ia2c180759677a51502c5c1c04508d165f7c35856
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087893
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Reviewed-by: Albert J. Wong <ajwong@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747707}

TBR=ajwong@chromium.org,gab@chromium.org

Change-Id: Id2b54936ec594834407e3e78e9affee53fca8f19
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1026641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092036Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747817}

These are orphans from an earlier, now-abandoned implementation.

Bug: 755840
Change-Id: If649f858655b4babe3cdda3d9467174b12f24ff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090140Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Will Harris <wfh@chromium.org>
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747816}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9d8c9bf34d9c..c46171246cf5

git log 9d8c9bf34d9c..c46171246cf5 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 tvanderlippe@chromium.org Cleanup _checkWithNodeScript
2020-03-06 tvanderlippe@chromium.org Cleanup _CheckFormat presubmit check
2020-03-06 tvanderlippe@chromium.org Remove unnecessary _CheckCSSViolations check

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@c46171246cf5

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I8b8ec26984b2fd999c19d3159583631f8aa49b6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091676Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747815}

In order for Chrome to output tagged PDFs, it needs content painted
by Blink to be tagged with its associated DOM node. Text is already
marked with its DOMNodeID. This patch extends that to tag
arbitrary drawing in GraphicsContext.

For background, see this design doc:
https://docs.google.com/document/d/1ku6QNtAHEqVnRGqFzpmlMe1fowkjCX9miHj8Kx1cFlk/edit#

Bug: 607777
Change-Id: Iec5cab6aa22c79ca3ce4db681164a97541264506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927975Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747814}

The WebRTC's |total_frame_count_| tracks how many frames have been
enqueued, and not how many frames have been presented. This means that
|total_frame_count_| could have the same value for different presented
frames, which can give the appearance of stale frames and cause
video.rAF callbacks to never fire.

This CL fixes the issue by keeping track of the number of presented
frames separately from the total frames.

The CL also passes along rendering interval and average frame duration
from the compositor, to help with performance when dealing with high
frame rate videos.

Bug: 1012063
Change-Id: I222887ed3554dbb71830f904f24526895bda5947
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088636
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747813}

This is needed to add support for zaura_surface_set_client_surface_id

Bug: 1011977
Test: NONE
Change-Id: I460e0d5a2a5f9f63f94035bfc0665691492ec21e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090605Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Shawn Gallea <sagallea@google.com>
Cr-Commit-Position: refs/heads/master@{#747812}

This is done in order to facilitate addition of future decorators.

Existing functions are moved to new files to facilitate sharing use.

Tab properties decorator for PageNode will be added in the next CL.

Bug: 1059341
Change-Id: I9cb0f8fdbb2636daaa310b7f69568377184021d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083674
Commit-Queue: Hailey Wang <haileywang@google.com>
Reviewed-by: Jun Cai <juncai@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747811}

This reverts commit faad9f7d.

Reason for revert: Test is constantly failing on iPad device.
https://crbug.com/1059256

Original change's description:
> [iOS] Reenable testXClientData
> 
> This CL re-enable testXClientData as it was probably failing because of
> a DCHECK in WebController, that should have been fixed in
> crrev.com/c/1992063.
> 
> Fixed: 1036225
> Change-Id: Id9a85c0f35310e79adcf030d222cce2e9e36274b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993813
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#731180}

TBR=stkhapugin@chromium.org,gambard@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I46f969294cb515e38df34df3f6ed66e4fc9ec558
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091711Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747810}

https://chromium.googlesource.com/webm/libvpx.git/+log/55f2e4a0a80d..5532775efe80

$ git log 55f2e4a0a..5532775ef --date=short --no-merges --format='%ad %ae %s'
2020-03-04 marpan rtc: Update svc test for resize
2020-03-03 marpan vp9-svc: Allow for dynamic resize for single layer SVC
2020-02-25 angiebird Add RefFrameInfo
2020-02-24 angiebird Keep ref frame coding indexes in SimpleEncode
2020-02-18 chengchen Make external arf consistent with vp9
2020-02-18 chengchen Allow external arf to determine gop size
2020-02-17 chengchen Add interface for external arf indexes.
2020-02-20 angiebird Rename values in RefFrameType and FrameType
2020-02-20 angiebird Use ref_frame[0] to determine mv_count
2020-02-20 angiebird Consistency test for GroupOfPicture
2020-02-20 angiebird Use ObserveGroupOfPicture() in EncodeFrame test
2020-02-20 angiebird Add kGoldenFrame and kOverlayFrame to FrameType
2020-02-14 jzern x86_simd_caps: make mask value unsigned

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

Change-Id: Id106bfceb77f91ec0d333fdad90a87d15c2917e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090597Reviewed-by: James Zern <jzern@google.com>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#747809}

WriteScanTime method is not called anymore
in Chrome Cleanup Tool. Thus, there is no
point in recording SoftwareReporter.UwSScanTimes
histogram anymore.

Bug: 1055885
Change-Id: I9be90ede011667285129eb2e9f9802ddd35570a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090591
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747808}

This CL sets up the directory for query tiles upboarding project. Also
added an interface for image loader system.

Bug: 1058534
Change-Id: Id4f60ba590d5da155a30087b3db8f1e3389b55e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088492Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Hesen Zhang <hesen@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747807}

When NTP realbox was initially implemented, we didn't use the default
provider list, and instead opted to create a manual whitelist of enabled
providers.

Original CL for context:
https://chromium-review.googlesource.com/c/chromium/src/+/1761688/22/chrome/browser/ui/search/search_tab_helper.cc#558

Now that we are aiming to bring NTP realbox to feature parity with
the actual omnibox, I suggest adopting this two-prong strategy.

 1. Aggressively enable all the same providers in realbox as in the
    omnibox. They should work in principle.

 2. Make NTP realbox work with chrome://omnibox so we can identify and
    fix any weird behavior. See:
    https://bugs.chromium.org/p/chromium/issues/detail?id=1058486

Here's the status on the four newly enabled suggestion types:
 1. On Device Head - seems to work fine.
 2. Document Provider - seems to work fine, although the icons don't
    have the nice custom document icons yet. Not a blocker IMO.
 3. KeywordProvider - I haven't noticed it activate on NTP realbox
    even when enabled. I think since we have forbidden keyword
    operations on AutocompleteInput, it's early exiting. We will need
    to enable chrome://omnibox for NTP realbox to verify this.
 4. Shortcuts - I can't see how this could cause a problem, but again,
    we will need chrome://omnibox to verify its behavior in realbox.

Bug: 1039357
Change-Id: Ibf2b2ec08a8f718c57f3af9456a7457185d67d6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088347Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747806}

Bug: 1026426
Change-Id: I0e085305564aaa6f1359ac11818de748b796d1d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088182Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747805}

This reverts commit b8ffaf4c.

Reason for revert:
This broke the build of the blink_gc_plugin, which does not use base/
(see bug). Please don't commit to tools/clang/ without review.

Original change's description:
> IWYU for bind/callback_helpers.h and ptr_util.h
> 
> These missing includes are preventing removal of unused headers from
> task_runner_util.h and consequently migration from task_runner_util.h to
> task_runner.h's new PostTaskAndReplyWithResult member method.
> 
> The following script was run on every file in the codebase, prioritizing
> .h over matching .cc to best enforce the rule of not include a header
> included by your .h :
> 
> def Fix(file_path):
>   content = refactor_lib.ReadFile(file_path)
> 
>   # Assume fwd-decls are correct in first pass.
>   fwd_decls_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*class (NullCallback|DoNothing|ScopedClosureRunner);', re.DOTALL).findall(content)
>   if fwd_decls_match:
>     print 'fwd_decls_match in %s' % (file_path)
>     return False
> 
>   bind_helpers_match = re.compile(
>       # Doesn't begin with a comment.
>       r'\n *[^/\n][^/\n]'
>       # Anything else after a non-comment start (and don't allow this to capture a comment start either)
>       r'[^/\n]*'
>       # Anything before but an open angle-bracket to avoid cases like unique_ptr<Foo> where you don't need the full definition of Foo.
>       r'[^<]'
>       # Only match with base:: prefix; more precise, can manually fix missing includes in //base proper in a follow-up pass if needed.
>       r'base::(NullCallback|DoNothing|DeletePointer)\b[^*]', re.DOTALL).findall(content)
> 
>   callback_helpers_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::(IsBaseCallback|EnableIfIsBaseCallback|AdaptCallbackForRepeating|ScopedClosureRunner)\b[^*]', re.DOTALL).findall(content)
> 
>   ptr_util_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::WrapUnique\b[^*]', re.DOTALL).findall(content)
> 
>   if not bind_helpers_match and not callback_helpers_match and not ptr_util_match:
>     return False
> 
>   updated_content = content
>   if bind_helpers_match:
>     updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/bind_helpers.h")
>   if callback_helpers_match:
>     updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/callback_helpers.h")
>   if ptr_util_match:
>     updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/memory/ptr_util.h")
> 
>   if updated_content == content:
>     return False
> 
>   # Write updated file
>   refactor_lib.WriteFile(file_path, updated_content)
> 
>   return True
> 
> TBR=danakj@chromium.org
> (mechanical change for //base API)
> 
> Bug: 1026641
> Change-Id: Ic88585c62dd2f74d34c59c708faeddb231aee47f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087971
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747685}

TBR=danakj@chromium.org,gab@chromium.org

Change-Id: I59d6cd69bd898e9f6d10922c67d8c24ba582bf7f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1026641, 1059359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091356Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747804}

https://android.googlesource.com/platform/external/perfetto.git/+log/88d9224c538a..6b79fee5ae98

git log 88d9224c538a..6b79fee5ae98 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 taylori@google.com Merge "perfetto-ui: Don't throw an error for user queries"

Created with:
  gclient setdep -r src/third_party/perfetto@6b79fee5ae98

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ib528ca755b55784860b2013be98da57076a4f446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091666Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747803}

Fixed: 1037256,1037258,1021155,1053121,1053122,1037259,1037260,1037261,1037257,1025890
Change-Id: I97aef4c0d7537e3192ae2b1fc29164e7223e2690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090364
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747802}

https://chromium.googlesource.com/angle/angle.git/+log/81cee994e1d2..e8883562ef57

git log 81cee994e1d2..e8883562ef57 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 geofflang@google.com Add a GN argument to enable/disable commit_id.

Created with:
  gclient setdep -r src/third_party/angle@e8883562ef57

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: ianelliott@google.com
Change-Id: I6c7825f5bab705102384fbf82ee6578a65235f4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091423Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747801}

https://webrtc.googlesource.com/src.git/+log/74dadc1e8e33..d14525eb59b9

git log 74dadc1e8e33..d14525eb59b9 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 jakobi@webrtc.org Make sure that the audio stream is allocated with the correct overhead.
2020-03-06 hbos@webrtc.org [Overuse] Make VideoStreamAdapter responsible for executing adaptation.

Created with:
  gclient setdep -r src/third_party/webrtc@d14525eb59b9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I382cc50efd422913df42647580a7d336df6fd6d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091671Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747800}

In such case, it's enough to only remove the profile copy without
changing the account store.

Bug: 1032992
Change-Id: I75a3e8ebdcbf3c7bb096850cb031b06c1364e4b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091348
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747799}

Fixed this issue by overriding GetDescription().

Bug: 1059071
Change-Id: I7def9efbf3b9ae1d86511b875b8e44af60c99a56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090727Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747798}

This is a reland of 4ed2234c

Original change's description:
> generate_wrapper targets for iOS' non-EG/EG2 tests, EG, and EG2 tests
>
> The existing iOS recipe utilizes an isolate template, and an
> isolated.gen.json file to fill the template in per test with
> config-variables and path-variables. This isolate template contains
> the command arguments to invoke the iOS test runner.
>
> To support the iOS recipe migration to the Chromium recipe, I use GN to
> generate a script per test target instead of the isolate template. The
> script is pre-baked with arguments to the test runner (run.py). The
> given Swarming task is expected to execute the test by invoking the
> generated script.
>
> Invoking the generated script requires changes to gn_isolate_map.pyl
> for each iOS test target, and thus, these changes are only additive.
>
> * "ios_test_runner_wrapper" template wraps the generate_wrapper target.
>  It bakes iOS specific arguments into the script, such that it can
>  launch run.py with the given args.
> * ios_eg2_test, ios_eg_test, and test templates have
>  been updated to utilize the ios_test_runner_wrapper for iOS targets.
> * mb.py to skip generated_directory check when writing isolates.
>  View crbug/ in comments.
>
> Change-Id: I941d37dfdff0bd1ead1baff70907a197fee3fe64
> Bug: 1055328,912681
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023748
> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745105}

Bug: 1055328, 912681
Change-Id: Ie7979979365b570369e6b6f750cc9f3006024564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088345Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747797}

The current instruction is a bit confusing and the example 'smoothness'
no longer exists. Updating to make it clear.

Bug: chromium:1058129
Change-Id: Iaa37a77580035493744f2928be26e85ddfd0cf63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089954
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747796}

This CL refactors OmniboxPopupView::OnSelectionStateChanged into a new
OmniboxPopupView::OnSelectedLineChanged method.

The general theme for these refactors is:

The "OnFooChanged" methods should provide all the data necessary as
parameters, rather than forcing the delegate to reach back into the
OmniboxPopupModel to see what has changed.

This is because:
 - For WebUI, we want to minimize the number of calls / roundtrips.
 - This new API is I think more clear even for the native Views code.

Should be no behavioral changes here, just a pure refactor.

Bug: 1046561
Change-Id: I0aec1cb7487dc549270c8db677cd89fde1312b25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085604
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747795}

Add new string nickname to WalletMaskedCreditCard, also update
corresponding proto_visitor. We will update other copies of
this proto in other places as a follow up.

Please refer to design doc for more info: go/nicknames-autofill-dd

Bug: 1059087
Change-Id: I1a1f666e96049e9dec40a53ec4085bbcb4b1f3c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090770
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#747794}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ee8be8a36862..94bafe03c84e

git log ee8be8a36862..94bafe03c84e --date=short --first-parent --format='%ad %ae %s'
2020-03-06 tikuta@chromium.org add instruction for download failure due to 401

Created with:
  gclient setdep -r src/third_party/depot_tools@94bafe03c84e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Ieee3fa0db1feae07d6d56735e1b7ce66dc5d1ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091667Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747793}

The test was flaky less than 1% of the time because of a race between
the "Cancel" button click propagating and the scan responses. The fix is
to set up the delegate so that those responses never come back.

Bug: 1059060
Change-Id: I5d6dd17bfe76f8a2120e3a8cd1cb312f8f5c1fac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090135Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747792}

Change-Id: I2200d62068bde5defc3ce0ae65978b6850d7520d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090363
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747791}

The end_time of SendBeginMainToCommit would be set by the time that
OnFinishImplFrame is received, which might be before the MainFrameAbort.
This could result into TotalLatency being smaller than the sum of stages.

Bug: chromium:1048696
Change-Id: I551c495da084c1887410495caab28de91cfa63e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062575Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747790}

This reverts commit 28640451.

Reason for revert: build failures (https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/48184)

Original change's description:
> Add browser tests for DeepScanningDialogDelegate
> 
> These tests use the least possible amount of overrides to ensure
> DeepScanningDialogDelegate every requests/callbacks eventually resolves
> and returns to the caller.
> 
> Also add code to handle the web contents being destroyed and avoid ASAN
> issues.
> 
> Bug: 1041890
> Change-Id: Ibfe232354f0591ae9e854bf5a0163ede68d6faf9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083598
> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
> Reviewed-by: Daniel Rubery <drubery@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747713}

TBR=drubery@chromium.org,domfc@chromium.org

Change-Id: I6f6df269f31685f004d317e42670542e3e69941c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1041890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090208Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747789}

http://crrev.com/c/2012901 this CL uses DisplayAndroid to get screen
height as preparation for upcoming android R. However, the new way of
fetching screen height includes the top and bottom bar height, which is
different from the setup we use in tab_ui. This CL fixes this issue.

Bug: 1046395
Change-Id: If0bf151a90147b237cf8f41806e1d42b0ff70d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023250
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747788}