- 18 Feb, 2020 40 commits
-
-
Christos Froussios authored
The save payment icon currently talks with the SaveCardBubbleController. With this CL, it gets its own controller interface. The implementing class stays the same. Bug: 986289 Change-Id: Ic7370ca998fdd9ee8baf453fc2c9919d074cce08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060960 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#742258}
-
Michael Thiessen authored
Going through each of the usages will take some care, so I want to essentially fix the API in a no-op pass and properly migrate each of the callsites independently (or in batches). I'm still working on migrating users of WebContents#getVisibleUrl, but some to the APIs those usages call into are shared by users of Tab#getUrl, so exposing a GURL Tab#getUrl early makes this less painful and requires less duplication and converting. This will be a 3-sided patch: 1. Add the getUrlString() method and migrate upstream usage. 2. Migrate downstream usage to getUrlString(). 3. Change getUrl() to return a GURL (this CL). Bug: 783819 Change-Id: If841d509bff8ea9d2da048021da6ba8635a8cd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044379 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#742257}
-
Sadrul Habib Chowdhury authored
The sequence numbers in BeginFrameArgs are expected to be incremented based on vsync intervals. Refactor the code for this from DelayBasedBeginFrameSource and ExternalBeginFrameSourceAndroid into a BeginFrameArgsGenerator. This is a simple refactor of the code, and does not change behaviour. BUG=none Change-Id: Idb51e1306dc6e6c64acbe2027cc28df0ba440055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058032Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#742256}
-
Chong Gu authored
Excluding tests that will crash before we enable cc unittests that use Vulkan renderer. Bug: 1047032 Change-Id: I75d52b9499808d10ce64ab61dfa3a4098f63b590 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053448Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#742255}
-
chrome://omniboxmanukh authored
The debug page compares response and request inputTexts to prevent async responses for old requests from being shown. Responses' inputTexts are trimmed of leading whitespace. The previous CL crrev.com/c/2019927 began trimming both leading and trailing whitespace from the requests' inputTexts. This fixed the case where inputs had leading whitespace, but broke the case where inputs had trailing whitespace. This CL trims only the leading whitespace of requests' inputTexts to match the responses' inputTexts behavior. Bug: 1045343 Change-Id: I93b6158255a99951a8643998e219c9913474e1a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062669Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#742254}
-
Dominic Farolino authored
This CL adds a URLLoaderFactory mojo disconnect handler for OriginPolicyManager to recover its URLLoaderFactory, after factories are reset. This CL also adds a browser test that exercises the disconnect handler, demonstrating that it plays a critical role when e.g., an extension with the declarative web request permission is loaded in the browser, and the NetworkContext's URLLoaderFactories are reset. Co-authored-by:
Domenic Denicola <domenic@chromium.org> Bug: 1047275 Change-Id: Iaa978348d069dfd61bc157ddbe159b1766a0e7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053228Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742253}
-
Avi Drissman authored
BUG=1023913 Change-Id: I11d24c83ca1f8f99fc64c612c383fd3979e00551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036406Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#742252}
-
John Rummell authored
Due to problems on some bots failing to start PulseAudio and causing Chrome startup to hang, avoid trying to initialize PulseAudio if audio output has been disabled. Bug: 986021,1023029,1026849,1035472,1049467 Test: media content_browsertests pass Change-Id: Ib75e44843df6e9e54d85ee4bd164b091ab2ade70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062694 Commit-Queue: John Rummell <jrummell@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742251}
-
Tom McKee authored
TBR=pkasting@chromium.org Change-Id: I906a7918779e5dc17d4cc35406470bca43e1deb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062912Reviewed-by:
Tom McKee <tommckee@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#742250}
-
James Cook authored
It was accidentally being registered twice. This didn't cause any user-visible issues, but made the code confusing. Bug: none Test: wallpaper picker still opens from OS settings Change-Id: Ica83d04267ae16d79e4f379e03ea7b6e47110fdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062796 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#742249}
-
Joey Arhar authored
As explained in crbug.com/958524 this post data was only used when using the xhr replay feature on the OPTIONS request of a CORS preflight. Now that OOR-CORS has launched crbug.com/905971 CORS preflights won't show up in DevTools anymore so we don't need to store this extra copy of post data. Bug: 958524, 780935 Change-Id: Ifecb37042c5845dc1bfbd594deb6cb635a3d7c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051443Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#742248}
-
Guillaume Jenkins authored
Potential fix for the flaky SpellcheckServiceBrowserTest.CustomDictionaryChanged test. I believe the problem is that the EXPECT_TRUE is executed before spell check initialization finishes, since spell check initialization is now async after the Windows native spell checker integration. I simply added a run loop after spell check initialization before the test continues. I don't know for sure if this was the true cause of flakiness, but I ran 1500 iterations locally with and without this fix. Without this fix, I had 12 failures. With this fix, I had 0. #Squeegee Bug: 1051777 Change-Id: I1f38cbffc82783b0274623631f2e1266d97ed3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055286Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Guillaume Jenkins <gujen@google.com> Cr-Commit-Position: refs/heads/master@{#742247}
-
Eugene But authored
"Success" will be the most common page load result and can be omitted as default. Bug: 2056565 Change-Id: I866aa24ea6da824fd3ff7c11f72fd4ca5acd1ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057784 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#742246}
-
Wenyu Fu authored
Homepage should always be visible to user even when the homepage is disabled. Add test for non-converted UI. Bug: 1047606 Change-Id: Ia7e3453a4014b7c23f17f37771bee8a3088d5b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045146 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#742245}
-
Joey Scarr authored
Bug: 1007685 Change-Id: I1a783decfc2b00e0b124543b8ee3aeee5a8e35d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059748 Auto-Submit: Joey Scarr <jsca@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742244}
-
Lei Zhang authored
The libexif code were removed in r381121. Change-Id: Ie66360817896cfbdd2b849c243e7c80d9eeaffd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050750Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#742243}
-
Eugene But authored
Breakscrumbs (feature which attaches steps to reproduce to crashlogs) relies on not_user_triggered="true" to filter out non-interesting events. This CL adds not_user_triggered="true" attribute to Clear Browsing Data user actions which can be triggered from browser cude without user's involvement. Bug: 1046231 Change-Id: I2f26fce5f9f6e904c4f8c50e7e08c5c64069747b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056565 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#742242}
-
Findit authored
This reverts commit 16c153e6. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 742233 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzE2YzE1M2U2ZWUzMzYxMjE2NThjMDA3ZGMzYjJjZGQ3MDZiMmYzN2UM Sample Failed Build: https://ci.chromium.org/b/8888089659985838672 Sample Failed Step: compile Original change's description: > Enable ATK and Glib on Linux/Ozone > > BUG=988094,1014934 > R=sky > CC=nickdiego,msisov,adunaev > > Change-Id: I05b4bae5ccce53053ad4ae8269db849c2db9e569 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056570 > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Nick Yamane <nickdiego@igalia.com> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742233} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=988094,1014934 Change-Id: If3f5a60b81a9e80ba326f3fdddef15dad08d8628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062760 Cr-Commit-Position: refs/heads/master@{#742241}
-
Christopher Cameron authored
When moving between two screens that don't change scale factor, but do change color space, this message was getting dropped. Remove the early-out, because the call to UpdateSurface has its own early-out. Change-Id: I8772a8cf982739039800f41e89857856aa5693ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062749Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#742240}
-
John Budorick authored
Promoting from a nightly build. Bug: 922145 Change-Id: I41e858309178ff785d0a47d6416f9182bfe5ccc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062750Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#742239}
-
Sebastien Marchand authored
Remove georgesak@ as he's no longer working on this. Update some other metrics owned by Georges while I'm here. Change-Id: I042c5e4d96b7c5a880a22751309d0a7104ced987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062249Reviewed-by:
Georges Khalil <georgesak@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#742238}
-
Wenyu Fu authored
Per Google style (https://screenshot.googleplex.com/K2X2oRG3VCN), we use "homepage" as one word. This CL changes "home page" that appears in Chrome on Android. Bug: 1028210 Change-Id: Id8b4f7d55dde174aedde6789400705562c3d6889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036438 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#742237}
-
Christos Froussios authored
These will remain until the migration code is deleted: - PasswordManager.LinuxBackendMigration.AttemptResult - PasswordManager.LinuxBackendMigration.Adoption These are no longer in use: - PasswordManager.LinuxBackendMigration.TimeIntoEncrypted Bug: 1053264 Change-Id: I861ff61d5e9e0177eaac5a5e0f933ef5e79fdcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062409 Auto-Submit: Christos Froussios <cfroussios@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#742236}
-
Jose Torreguitar authored
The modern Xbox Elite Series 2 controller firmware reports on less axes than the previous firmware. However, the only way to distinguish between firmware versions is to check the length of the axes reported. This change updates the mapping function to work for all firmware versions by checking the axes length. On the older firmware, the axes are shifted by one after axis 3 because axes 4 and 9 are redundancies. BUG=1052543 TEST=Testing this requires two Xbox elite series 2 controllers, one with modern firmware and one with release firmware. When using them on production code users will notice that on pressing the DPAD on modern firmware either the triggers or the opposing dpad axis is pressed. Change-Id: Ie51fd897a14180d664463d196b2fe744338c61c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057624Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: José Torreguitar <jtguitar@google.com> Cr-Commit-Position: refs/heads/master@{#742235}
-
Alex Cooper authored
Updates the Android WebXr test infrastructure to allow accepting or rejecting permissions prompts in addition to the consent dialog, based on whether or not the feature is enabled. This ensures that tests will keep running when the permissions prompt is enabled by default, and can be cleaned up as time permits. Additionally, consent prompt tests that still make sense to run when the permissions prompt is enabled were pulled into an impl method and a variation of the test was created which explicitly sets the feature to the desired state. The old tests can thus be more easily removed when the feature flag is removed. This ensures both some coverage of the permissions prompt flow now, and continued coverage of the consent flow after it is disabled, until such time as it can be removed. Some tests were determined to be testing logic specific only to the current consent flow, and as such those tests forcibly ensure that the permissions prompt is disabled. Bug: 1043241 Change-Id: Ib61d81a3f3aa90b1869d13ad53112ecd5606b627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051367 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#742234}
-
Tom Anderson authored
BUG=988094,1014934 R=sky CC=nickdiego,msisov,adunaev Change-Id: I05b4bae5ccce53053ad4ae8269db849c2db9e569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056570Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#742233}
-
dalyk authored
This change adds several fields to each provider entry that will be used when populating the dropdown menu. The redundancy between the DoH template and the HTTP method for a provider entry is now removed. Bug: 1040145 Change-Id: Id137659fa93850d1fc5f6379a844fd98ab63733f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048963Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Katharine Daly <dalyk@google.com> Cr-Commit-Position: refs/heads/master@{#742232}
-
Wan-Teh Chang authored
Compare coded_size directly instead of its width and height components. Bug: N/A Change-Id: I372335275d2f41ef8a0d98045f6fa87074cdf66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058068Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#742231}
-
Becca Hughes authored
This is a follow up from https://crrev.com/c/2055597 to add webui to the owners for the resources file. Change-Id: I63ab01298933c1c81a3c35d462571563066d28e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062929Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#742230}
-
Kurt Horimoto authored
These containers will be used to present the banner and modal view controllers. Bug: 1030357 Change-Id: I824563eb5b028b576dc29eb270685711e148f87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033339 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#742229}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 37 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-08-16. Change-Id: Ibc83f2b3c6cc0afb47de8490d80e58c372abfc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062472 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#742228}
-
Toni Barzic authored
Makes existing tests pass by explicitly disabling the feature (once the feature flag is removed, the test set up should be updated to enable the accessibiltiy feature to force shelf navigation buttons in tablet mode). Adds tests that verify the overview button gets shown when spoken feedback, autoclick, or switch access is enabled (and fixes an issue where the button visibility was not getting updated when accessibility features value changed). BUG=1051714 Change-Id: I618206e2d56857cd119f07ff9cad915b2944d213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055347Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#742227}
-
Becca Hughes authored
Add the media sessions tab to the WebUI for debugging. Change-Id: Iecbe717a118e44b05a95fd5432b1384f3d32f6fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055597Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#742226}
-
Tina Wang authored
- Add ContentPreviewData.java to store information needed for content preview. - Add ArrayList<ContentPreviewData> field to ProfileCardData object. - Add content_preview_contatinor.xml and content_preview_post.xml. - Add logic that passing ContentPreviewData to ProfileCardVeiw and forming the posts view dynamically. Bug: 1051154 Change-Id: I89bb9960bad95a5a57be9c4ddcd13719f7710867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055433 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#742225}
-
Jose Lopes authored
Remove base::Callback in some media unittests. The following callbacks are called every time a texture is created: * https://cs.chromium.org/chromium/src/media/renderers/paint_canvas_video_renderer_unittest.cc?rcl=f511dfda653e4f840e520384df599885ae827039&l=934 * https://cs.chromium.org/chromium/src/media/renderers/paint_canvas_video_renderer_unittest.cc?rcl=f511dfda653e4f840e520384df599885ae827039&l=949 The following callback is used in a factory: * https://cs.chromium.org/chromium/src/media/mojo/test/mojo_video_decoder_integration_test.cc?rcl=99887411e48037a3d41ab6862b460d1f501fea34&l=193 The following base::Callback definition can be omitted by rewriting the gmock code: * https://cs.chromium.org/chromium/src/media/filters/source_buffer_state_unittest.cc?rcl=f5dd4b5e849703668bd1e606eb6b6dc43027a1ac&l=55 The following callback is called on a stream until false is returned: * https://cs.chromium.org/chromium/src/media/gpu/video_encode_accelerator_unittest.cc?rcl=f5dd4b5e849703668bd1e606eb6b6dc43027a1ac&l=849 The following callback is called on every frame: * https://cs.chromium.org/chromium/src/media/remoting/end2end_test_renderer.cc?rcl=f5dd4b5e849703668bd1e606eb6b6dc43027a1ac&l=61 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I568b22ff281c0217f1cb49f6fe9a040cefd24d72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2058953 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742224}
-
kylechar authored
The test that runs after conformance/state/gl-object-get-calls.html is failing on Nexus5/6 GPU FYI bots consistently. It also might be causing failures on Nexus 5X and potentially other bots. Skip running the test. TBR=ynovikov@chromium.org Bug: 1052790 Change-Id: Ic3b65ca5948b591ad95e2095ae753f7086286cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062548Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#742223}
-
Alex Leung authored
Bug: b/149422033 Change-Id: Iffca5a1ab394ddafee3bbfa81c255db14df180ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056930Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Alex Leung <alexleung@google.com> Cr-Commit-Position: refs/heads/master@{#742222}
-
Andrew Xu authored
Basically two elements are required by View::ScrollRectToVisible: the rectangle to show and the bounds of the visible space. However, in ScrollableShelfView::ScrollRectToVisible, the rectangle to show is not mirrored under RTL while the visible space is mirrored. This CL mirrors the visible space from RTL to LTR when RTL is enabled. A test case is also created for this scenario. Bug: 1052553 Change-Id: I3a051c40a87f93f612edf558944479aad61d6ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056938Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#742221}
-
Changwan Ryu authored
Extend the current StartupTimeActivity to measure the time series of UI blocking of WebView creation tasks. Bug: N/A Change-Id: I5511fb6da1fd978c562100d79cf0b0bcaa7f6d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056500Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#742220}
-
Dominique Fauteux-Chapleau authored
Also fix how the SHA256 is obtained to avoid having giant files in memory. Bug: 1048784 Change-Id: Ifec7cab506c8501ff01f3c7e5295297f1447f4e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036660 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#742219}
-