- 17 May, 2018 40 commits
-
-
Gustaf Ullberg authored
Crashdumps indicate that HB_gain can become NaN. When the gain is applied to the input signal all samples become NaN, which causes the crashes described in chromium:826914. Changes: - Check if HB_gain becomes NaN and then set it to 1 (no high-band attenuation). If this CL does not fix the issue it should be reverted. If this CL does fix the issue we should investigate further. Bug: chromium:826914 Change-Id: Idfcee178715180faf57a3d26918e941b99a09071 Reviewed-on: https://chromium-review.googlesource.com/1061499Reviewed-by:
Felicia Lim <flim@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Gustaf Ullberg <gustaf@chromium.org> Cr-Commit-Position: refs/heads/master@{#559432}
-
John Chen authored
Disable testCloseWindow and testCloseWindowUsingJavascript, which have been flaky recently. Also increase logging verbosity level to help diagnose this issue. TBR=kereliuk@chromium.org Bug: chromedriver:2431 Change-Id: Ic501ed3ea97817d76cfe37f5a58aee2f3f7254fe Reviewed-on: https://chromium-review.googlesource.com/1063530Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559431}
-
Hajime Hoshi authored
The task runner is used at UpdateInternalInstanceId and DeleteSoon, and I think unthorttled task runner is not necessary here. Note that the original task runner before kUnthrottled was ThreadTaskRunnerHandle::Get(). We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Task type guideline: https://bit.ly/2vMAsQ4 Bug: 836410 Change-Id: I11679337908b6c64f3f6604639f2aed3b7c60ab0 Reviewed-on: https://chromium-review.googlesource.com/1055367Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559430}
-
Yutaka Hirano authored
It is suspected that due to sandbox a user-agent string gotten in a renderer process is difference from that gotten in the browser process. This CL removes the call in renderer. Instead, the value is passed from the browser process. This is a speculative fix. If it doesn't fix the issue, I will revert it. Further refactoring will be done in subsequent CLs (after confirming that this CL fixes the issue). Bug: 818450 Change-Id: Ie657c858f582ecdaee5c3245751068615969c890 Reviewed-on: https://chromium-review.googlesource.com/1031693 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#559429}
-
Mike Wasserman authored
Add an InputDeviceServer instance to ui::ws2::WindowService. Add an InputDeviceClient instance to MusClient, remove from Chrome. (allows mojo apps using ws2 & MusClient to access InputDeviceManager) Split out TouchDeviceServer ownership to ui::Service. (IIUC, this won't be needed at all for ash->ws2 usage) Refine the server interface registration (BindSourceInfo not needed). Make the shortcut viewer dependency on InputDeviceManager explicit. Fix the DCHECK in ksv unit tests, and a crash showing the KSV in Mash. This is a prerequisite for making Keyboard Shortcut Viewer a mojo app: https://chromium-review.googlesource.com/c/chromium/src/+/1060163 Bug: 841020 Change-Id: I9de8e9ccf249aa40e7a297261d9d2e0f2989fbfe Reviewed-on: https://chromium-review.googlesource.com/1062770Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#559428}
-
Jun Mukai authored
This extension allows the cursor shape by its ID rather than graphical data through surface. This is an extension, so the existing behavior will work as-is without any changes. Bug: b/70666810 Change-Id: Iafa576a6d2e0103f7bc1b6eb295a0187f967a80a Reviewed-on: https://chromium-review.googlesource.com/1040670 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#559427}
-
Alan Cutter authored
There's no UX on a PWA window to indicate incognito status, disable the ability to get in this situation (also it DCHECKs). Bug: 843869 Change-Id: I6b48258dfbe118ea67aae9b9a5375b198eaa4e75 Reviewed-on: https://chromium-review.googlesource.com/1062991 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#559426}
-
Takayoshi Kochi authored
Use UKM for document.registerElement() to help investigate which site is actively using Custom Elements V0 API. The motivation is to drive usage down, by outreaching those users. As of today the usage is around 5% so we sample this feature as well as the existing kElementCreateShadowRoot. https://www.chromestatus.com/metrics/feature/timeline/popularity/457 Bug: 843080 Change-Id: I8a94fdcf2d0c905a3a978cb78673c0544b2155a2 Reviewed-on: https://chromium-review.googlesource.com/1059100 Commit-Queue: Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Hayato Ito authored
Make IncremantalShadowDOM flag stable. PSA in blink-dev is here: https://groups.google.com/a/chromium.org/d/msg/blink-dev/1TXLVz_H1S0/n4cdluQjAwAJ Bug: 776656 Change-Id: I8d6c02d793ad30c4774fe069b84127e5575b3678 Reviewed-on: https://chromium-review.googlesource.com/908269Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#559424}
-
Hiroshige Hayashizaki authored
This CL sets IsReady() false at MockPendingScript construction and sets it true in ScriptRunnerTest::NotifyScriptReady(). This removes most of IsReady() EXPECT_CALL()s. Bug: 842349 Change-Id: I633f4fa17add8f149efc068b8b2a4573db2a6c53 Reviewed-on: https://chromium-review.googlesource.com/1041131 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#559423}
-
Lei Zhang authored
Get rid of deprecated linked_ptr usage. Use RefCounted because the object has shared ownership. BUG=556939 Change-Id: Iab75d2a4cf834227764d4ac1888e3efa690b2ce2 Reviewed-on: https://chromium-review.googlesource.com/1053992 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#559422}
-
Scott Violet authored
The WindowService (indirectly) installs observers on various objects created by Ash. Because of this the WindowService really needs to be destroyed before ash's Shell. This patch introduces the WindowServiceOwner, which owns the WindowService. ServiceManager supports this by way of providing a function to bind the ServiceRequest directly. When the request is seen WindowServiceOwner creates a ServiceContext, which owns the WindowService. WindowServiceOwner owns the ServiceContext. Shell owns the WindowServiceOwner, so we can guarantee a particular shutdown ordering. I also made it so the WindowService is immediately created. This was mostly because it simplified the code slightly, but I could make it lazily created if necessary. BUG=837692 TEST=none (test will follow) Change-Id: I2628292c73f4fe86e48cad55d2b63e9345fcd831 Reviewed-on: https://chromium-review.googlesource.com/1062717 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#559421}
-
https://pdfium.googlesource.com/pdfium.git/+log/98ec53359b8e..db3c6cefcedd $ git log 98ec53359..db3c6cefc --date=short --no-merges --format='%ad %ae %s' 2018-05-17 thestig Update third_party/base/compiler_specific.h. 2018-05-16 npm Move JBig2 HuffmanTables into JBig2_HuffmanTable.cpp Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie8437df3f524273976b9ed4ee01ecff5172572f9 Reviewed-on: https://chromium-review.googlesource.com/1062917 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559420}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05da1c16dfb4..ed4921b9d473 $ git log 05da1c16d..ed4921b9d --date=short --no-merges --format='%ad %ae %s' 2018-05-16 skcms-skia-autoroll Roll skia/third_party/skcms 5cc905d..e4c0e54 (1 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I132d2bd4bbf51e92acb210ad6665b29e20a7e0f7 Reviewed-on: https://chromium-review.googlesource.com/1062918Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559419}
-
Mike Frysinger authored
Change-Id: I1af04d08c63f66d58cbb97fc1c824509138f0fd2 Reviewed-on: https://chromium-review.googlesource.com/1063151Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#559418}
-
Mike Frysinger authored
This syncs the set of permissions from Secure Shell that we want/use in newer versions of hterm. Bug: 822490, 646690 Change-Id: I7abadb369b3178739808aa41fd0cae9ef3c0759e Reviewed-on: https://chromium-review.googlesource.com/1061619Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
Sheng-Hao Tsao authored
This CL allows EXIF buffer to be absent in a JEA request. BUG=b:79251580 TEST=Still capture with JEA works with EXIF length equaling 0 Change-Id: I4e9ff0a162bb3ac3f227f44716575234350eb2e0 Reviewed-on: https://chromium-review.googlesource.com/1061774Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#559416}
-
Koji Ishii authored
Following bot results are included. 5553 5560 5564 7 lines were removed and 0 lines were deflaked by consecutive results since 5428. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I31c70a938e2c28178bcf9136beca4639d961e678 Reviewed-on: https://chromium-review.googlesource.com/1062665 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#559415}
-
Mike Frysinger authored
The options page has been around for 5+ years, but only accessible if you typed the URL directly, or used the Ctrl-Shift-P shortcut added in the last year or so. While we've been updating the manifest files in the nassh repo, we had forgotten about this one. Although it wasn't useful before the recent Terminal/Crostini work as crosh hasn't been a visible "app", only via the Ctrl-Alt-T shortcut on a Chromebook. Bug: 843613 Change-Id: I32a67cd85d5eafe147672cd93c35dea0cc5edcdd Reviewed-on: https://chromium-review.googlesource.com/1061618 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#559414}
-
Xiaocheng Hu authored
LayoutBlock::PositionForPointIfOutsideAtomicInlineLevel() hard-maps the left side of an atomic inline to the DOM position at its start, and the right side to its end, which is wrong if the atomic inline is RTL. This patch fixes the issue. Note: this patch doesn't fix selection flickering when dragging mouse over an atomic inline surrounded by bidi text, due to bugs in bidi adjustment in SelectionController. Bug: 811502, 834066 Change-Id: Id1687922f3d713cb2eb4b8668cb0687196a2fc44 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1062831Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Alexandros Frantzis authored
This commit prepares ozone_demo to use GpuFences for overlay planes, when support for them lands in any of the Ozone backends. The --use-gpu-fences ozone_demo flag controls whether to enable the use of fences or use the existing glFinish mechanism. Bug: 828393 Test: Run ozone_demo on Ozone-DRM Change-Id: I797e9445479ff4a9768cb89033d1dd6fd826b5ae Reviewed-on: https://chromium-review.googlesource.com/1021693 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#559412}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ibb6b5ef9c34efcfd06bb9e362a7ec2cad16c2609 Reviewed-on: https://chromium-review.googlesource.com/1063150Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#559411}
-
James Darpinian authored
The flakiness is on all platforms. https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVQsSBUZsYWtlIkpncHVfdGVzdHMucGl4ZWxfaW50ZWdyYXRpb25fdGVzdC5QaXhlbEludGVncmF0aW9uVGVzdC5QaXhlbF9XZWJHTFNhZENhbnZhcww Bug: 835867 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I959dd5e6db6f8ca4f50effeca828a8cd98f6b5fa Reviewed-on: https://chromium-review.googlesource.com/1062911 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559410}
-
Koji Ishii authored
This patch adds ComputedStyle::GetFontBaseline function, and use it in all places in LayoutNG. It should depend on 'writing-mode' and 'text-orientation', but in many places in LayoutNG it is determined only from 'writing-mode'. This fixes 4 tests but discovers 2 failures. As in the added comment, the inline boxes and text should be aligned to parent's dominant baseline. In many places in LayoutNG and also in the current engine, we check the baseline of the child box. Some of these look incorrect, but fixing them is for future CLs. This CL just replaces each code with the common function. A design question is whether to add this to NGConstraintSpace or not, because the layout depends on parent's dominant baseline. This patch does not do this but instead pass when necessary, because it is only needed for inline context, and we don't create NGConstraintSpace for inline descendants. This may be revisited in future. Bug: 636993 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iba77fd528fb0ea54526f45d8dfd83bbcfb48411c Reviewed-on: https://chromium-review.googlesource.com/1059974 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#559409}
-
Gary Kacmarcik authored
This class contains all the platform-independent code for creating the Keyboard Map. Bug: 832811 Change-Id: Icb4dbf85419c72e795b090bae816b0b1c6b03f67 Reviewed-on: https://chromium-review.googlesource.com/1062925 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559408}
-
Tom Anderson authored
Includes 4 changes: https://chromium.googlesource.com/chromium/buildtools/+log/a9e946f166b73f9dc170129f6586a1e68efb0ab3..94288c26d2ffe3aec9848c147839afee597acefd Notably, libc++ and libunwind are rolled. BUG=767901 R=thakis Change-Id: Ie4ce691439dea7a362501ebaba9c2ccc130ea90a Reviewed-on: https://chromium-review.googlesource.com/1063019Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#559407}
-
Lucas Gadani authored
This is a reland of 7a5a390d Original change's description: > Remove CacheStorage mojom typemaps. > > This CL removes the typemaps for CacheStorage and converts the browser usage of > CacheStorage types to mojo types. > > Bug: 612287 > Change-Id: Ied68ed00f2cc7af71cc33660544be9894cbb2eb1 > Reviewed-on: https://chromium-review.googlesource.com/1058334 > Reviewed-by: Joshua Bell <jsbell@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Lucas Gadani <lfg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#559058} Bug: 612287 Change-Id: Iea6d8ef4f67616be7350edec7705d71b2b1ac126 Reviewed-on: https://chromium-review.googlesource.com/1061986Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
-
Stefan Zager authored
For IntersectionObserver, we only want to hit test down to the target element. BUG=827639 R=chrishtr@chromium.org,pdr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7c64a73577c1d685ba73ecc6ad388cd790122ad8 Reviewed-on: https://chromium-review.googlesource.com/1054132 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559405}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d6b41a27678f..05da1c16dfb4 $ git log d6b41a276..05da1c16d --date=short --no-merges --format='%ad %ae %s' 2018-05-16 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ c8403ec14..89c43d202 (1 commit) 2018-05-16 angle-skia-autoroll Roll third_party/externals/angle2/ 80c32ccbb..f299a378f (6 commits) 2018-05-16 brianosman Suppress bad-function-cast warning 2018-05-15 enne Driver bug workaround: pack_parameters_workaround_with_pack_buffer 2018-05-16 jvanverth Fix check for valid proxies returned by AtlasManager. 2018-05-16 skcms-skia-autoroll Roll skia/third_party/skcms a7e79c5..5cc905d (1 commits) 2018-05-16 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ 596f653f5..c8403ec14 (1 commit) 2018-05-15 bungeman SkImage::onRefEncoded to return sk_sp. 2018-05-15 enne Driver bug workaround: gl_clear_broken 2018-05-16 swiftshader-skia-autoroll Roll third_party/externals/swiftshader/ e475674ef..596f653f5 (1 commit) 2018-05-15 enne Driver bug workaround: restore_scissor_on_fbo_change 2018-05-16 kjlubick Remove problematic pre-allocations when deserializing 2018-05-16 herb Fix compiler warning for MSVC 2018-05-16 skcms-skia-autoroll Roll skia/third_party/skcms e040063..a7e79c5 (2 commits) Created with: roll-dep src/third_party/skia BUG=chromium: 829614,chromium: 829614,chromium: 829614 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: Ic77fdbcc06c7d4ce7c8354c041e9997d3be8bb76 Reviewed-on: https://chromium-review.googlesource.com/1063112 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Rakina Zata Amni authored
The wrong request id is used while binding OnGetNearestFindResultReply. The original IPC version used activate_.current_request_id but we used current_session_id_ in the mojoification on crrev.com/c/1051143, making replies received in OnGetNearestFindResultReply to be dropped because the request id don't match. This CL makes the mojo call to use activate_.current_request_id. Bug: 843448 Change-Id: I049d4f560ed82d36f8d3ffb876217ba94a46fe1c Reviewed-on: https://chromium-review.googlesource.com/1063045Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#559403}
-
Erik Chen authored
The tests recently started flaking. It's unclear why. Bug: 843467, 843843 Change-Id: Ie5141f65a6da01314da263ab5b875126e4e4fb3e Reviewed-on: https://chromium-review.googlesource.com/1062834 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Chris Harrelson authored
descendants. When <foreignObject> was made a stacking context, it also had the side-effect of painting it at the same time as positioned elements. This is a change to painting order and caused a regression. Instead, implement a new mechanism by which a "replaced normal-flow stacking" element paints during the foreground phase of the LayoutObject paint tree walk. This is used for now just for <foreignObject>, but may be applied to other replaced elements such as iframes or embedded objects in the future. Bug:842668 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I450944986abfb6610084444abf2724e7406145cf Reviewed-on: https://chromium-review.googlesource.com/1060333 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#559401}
-
Abhishek Arya authored
R=mmoroz@chromium.org,liaoyuke@chromium.org Bug: 843183 Change-Id: I194ad5ccfa7f6145beccc1f4b4c0e083e4f5c681 Reviewed-on: https://chromium-review.googlesource.com/1063120 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#559400}
-
Xiaohan Wang authored
Add a new MediaLog level so that we don't have to abuse MEDIALOG_ERROR, which could end up in MediaError.message and should be carefully used. Also update documentation on MediaLog levels. Also use MEDIALOG_WARNING in audio_timestamp_validator.cc for non-fatal issues. Bug: 843808 Test: Manually tested and verified in about://media-internals Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I20350d305b3f55d1f59e6d2324cc3be7452bcbbe Reviewed-on: https://chromium-review.googlesource.com/1063009Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/07bcf9fc1678..78fd93090e2f $ git log 07bcf9fc1..78fd93090 --date=short --no-merges --format='%ad %ae %s' 2018-05-16 sullivan Implement gerrit_service.PostChangeComment Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I877559f12f54994c3fe6e4f05ec5e664474e0733 Reviewed-on: https://chromium-review.googlesource.com/1063175Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#559398}
-
Tessa Nijssen authored
Previously, when a Textfield instance changed its text direction, no change was made to its horizontal alignment. Now, ChangeTextDirectionAndLayoutAlignment() calls SetHorizontalAlignment() with the correct alignment based on text direction. Text direction Horizontal alignment Right-to-left -> Aligned right Left-to-right -> Aligned left This fixes a bug where toggling RTL in a Textfield did not change the text writing direction. A unit test was also added to test ChangeTextDirectionAndLayoutAlignment(). This test checks that a call to the method properly updates the textfield's text direction and horizontal alignment. Bug: 841123 Change-Id: I8dadc1272a3474dc72ae9470bdc7d9949e8fd854 Reviewed-on: https://chromium-review.googlesource.com/1060626 Commit-Queue: Tessa Nijssen <tnijssen@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sarah Chan <spqchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#559397}
-
Jeffrey Kardatzke authored
This is an obvious coding error, the wrong variable was used for checking if an iterator was empty. Depending upon if a specific bit was set in that random memory location, then we'd get the right/wrong behavior. Bug: 842196 Test: Icons load (although they usually did before) Change-Id: Ie52747f0b03e82ba2915df3f8ce9198a9a22452f Reviewed-on: https://chromium-review.googlesource.com/1062199Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#559396}
-
Bailey Berro authored
This change adds more descriptive mount errors in order to display more detailed reasons for a failed mount to the user. Bug: chromium:757625 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I11d46ca74d40d77276bce6839899ac723b3b77c6 Reviewed-on: https://chromium-review.googlesource.com/1060428 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#559395}
-
Jinsuk Kim authored
BindingManager.java is not in use by the target defined in Chrome build any more. This CL removes the corresponding DEPS exception rule. Bug: 617324 Change-Id: I1c0a35d6f950d237b72b33c2dad69847d5bfc50c Reviewed-on: https://chromium-review.googlesource.com/1060719Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#559394}
-
Alan Cutter authored
This CL fixes the review nits in https://chromium-review.googlesource.com/c/chromium/src/+/1049126 Bug: 788051 Change-Id: Ie05dfc59896f528408ef305c9f56cadfafa587d0 Reviewed-on: https://chromium-review.googlesource.com/1058737Reviewed-by:
-
