GitLab

It broke multiple browser_tests like
ExtensionWebstorePrivateApiTest.InstallAccepted and
ExtensionNoConfirmWebstorePrivateApiTest.InstallTheme on multiple OSes.

TBR=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10274026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134688 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134685 0039d316-1c4b-4281-b951-d872f2087c98

Add commas between array elements and remove extra spaces at end.

BUG=none
TEST=trybots


Review URL: http://codereview.chromium.org/10264022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134683 0039d316-1c4b-4281-b951-d872f2087c98

This CL sets the image scale factor for data packs.

This will be used by the DOM UI code to look up encoded PNG data for images with a specific scale factor.

BUG=114311
TEST=


Review URL: http://codereview.chromium.org/10151025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134682 0039d316-1c4b-4281-b951-d872f2087c98

In preparation for making FindEntryByPathAsync() private.
The new function is not used in production code yet.

BUG=chromium-os:30251
TEST=add unit tests

Review URL: https://chromiumcodereview.appspot.com/10271026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134681 0039d316-1c4b-4281-b951-d872f2087c98

Instead use GetFileInfoByPathAsync(). This is in preparation for
making FindEntryByPathAsync() private.

BUG=chromium-os:30251
TEST=gdata in the file manager works as before (ex. pinned files are shown as pinned)

Review URL: https://chromiumcodereview.appspot.com/10271016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134680 0039d316-1c4b-4281-b951-d872f2087c98

These functions will be used in an upcoming patch, when
we extract file info from GDataFileProto/GDataDirectoryProto
(i.e. in some places, we need PlatFormFileInfo).

BUG=chromium-os:30251
TEST=GDataFileSystemTest.CachedFeedLoading

Review URL: https://chromiumcodereview.appspot.com/10270027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/10148001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10255020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134677 0039d316-1c4b-4281-b951-d872f2087c98

Will stop open windows from staying around while other unit tests run.

TBR=jhawkins@chromium.org
BUG=122152
TEST=


Review URL: http://codereview.chromium.org/10048005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134676 0039d316-1c4b-4281-b951-d872f2087c98

but not yet played). Underlying code expects per-logical-stream pending bytes,
while all mixer gets when called for more data is pending bytes per combined stream.

Fix is to keep track of
* amount of data in every buffer
* buffers for every logical stream
and manually calculate per-logical-stream pending bytes.

That is last CL in initial audio mixer implementation, after it go through mixer
should be ready for full testing.

Review URL: http://codereview.chromium.org/10154007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134675 0039d316-1c4b-4281-b951-d872f2087c98

JSON schema compiler now supports having strings as types.

Similar to http://crbug.com/122075

BUG=124771
TEST=cpp_type_generator_test.py


Review URL: http://codereview.chromium.org/10206034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134674 0039d316-1c4b-4281-b951-d872f2087c98

for extensions that have a homepage url

BUG=105858
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/10103015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134673 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123685
TEST=


Review URL: http://codereview.chromium.org/10261019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134672 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110212
TEST=Will be testable via subsequent API-consumer CL.


Review URL: http://codereview.chromium.org/10262019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134671 0039d316-1c4b-4281-b951-d872f2087c98

it broke the linux x64 bulder.

> Revert r134607 "Revert r134508 "Revert 134507, broke the main builders:""

> Overall, this reapplies r134507.

> The dependencies were retrieved with trace_inputs.py and merged with merge_isolate.py.

> Manual edits:
> - Added <(EXECUTABLE_SUFFIX) to two executables: unit_tests and xdisplaycheck.
> - Removed testserver.log and unit_tests.log.
> - Added copyright.
> - Removed *.db-journal files.

> TBR=rogerta@chromium.org
> BUG=98636
> TEST=


> Review URL: http://codereview.chromium.org/10269019

TBR=maruel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10264027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134670 0039d316-1c4b-4281-b951-d872f2087c98

Revert r134607 "Revert r134508 "Revert 134507, broke the main builders:""

Overall, this reapplies r134507.

The dependencies were retrieved with trace_inputs.py and merged with merge_isolate.py.

Manual edits:
- Added <(EXECUTABLE_SUFFIX) to two executables: unit_tests and xdisplaycheck.
- Removed testserver.log and unit_tests.log.
- Added copyright.
- Removed *.db-journal files.

TBR=rogerta@chromium.org
BUG=98636
TEST=


Review URL: http://codereview.chromium.org/10269019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134667 0039d316-1c4b-4281-b951-d872f2087c98

Added a new automation hook ExecuteJavascriptInOOBEWebUI() to permit executing abitrary javascript prior to login on chromeos.

Change-Id: If96d94bb22ac5bd25fa4ab1e3a4c3ba52ea47370

BUG=chromium-os:29466,chromium-os:20709
TEST=functional/chromeos_login.py (testExecuteJavascriptInOOBEWebUI)

Review URL: http://codereview.chromium.org/10257015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134666 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125568
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10274022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134665 0039d316-1c4b-4281-b951-d872f2087c98

realized the old implementation was over-complicated and could fail if two objects had interleaved, rather than nested, scope.

BUG=none
TEST=manual


Review URL: http://codereview.chromium.org/10269008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134663 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/10268021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134660 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102482
TEST=


Review URL: http://codereview.chromium.org/10266010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Manual

Review URL: https://chromiumcodereview.appspot.com/10271025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134658 0039d316-1c4b-4281-b951-d872f2087c98

page action.

BUG=124605


Review URL: http://codereview.chromium.org/10264004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134657 0039d316-1c4b-4281-b951-d872f2087c98

This bug was introduced by r10170037 which waited until mouse was
released to truly end a grab.

BUG=crash when clicking on titlebar to restore a minimized panel
TEST=minimize a panel. click on titlebar to restore. verify no crash.

Review URL: https://chromiumcodereview.appspot.com/10266021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134655 0039d316-1c4b-4281-b951-d872f2087c98

R=aa@chromium.org
BUG=124477

Review URL: http://codereview.chromium.org/10177006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134654 0039d316-1c4b-4281-b951-d872f2087c98

the original way (installed then loaded).

I originally switched the order so I could dispatch the onInstalled event, but
doing so in a PostTask is a better solution to that.

BUG=no
TEST=no


Review URL: http://codereview.chromium.org/10274013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134653 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134652 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree
Review URL: https://chromiumcodereview.appspot.com/10260027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134651 0039d316-1c4b-4281-b951-d872f2087c98

HostPortAllocator is a PortAllocator specific to Chromoting host.

BUG=103991

Review URL: https://chromiumcodereview.appspot.com/10160013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134650 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134649 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree
Review URL: https://chromiumcodereview.appspot.com/10264018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134648 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125471
TEST=none


Review URL: http://codereview.chromium.org/10268019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134647 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Right-click #include "qms.h" in VS2010 works.


Review URL: http://codereview.chromium.org/10271005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134646 0039d316-1c4b-4281-b951-d872f2087c98

http://www.corp.google.com/~kenmoore/mocks/chromeos/Misc_2012/Menus/markup1/menu4.html

Menu text enabled color, button enabled text color, label enabled text color are set to #222.
Menu text disabled color, button disabled text color, label disabled text color are set to #999.
Menu keyboard shortcut text color is set to #999.
Menu item hover background color is set to #f1f1f1.



BUG=122858
TEST=Menu spec for all the color is implemented, see code review description for details.

Review URL: http://codereview.chromium.org/10270021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134645 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119511
TEST=none
TBR=reed

Review URL: https://chromiumcodereview.appspot.com/10262024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134644 0039d316-1c4b-4281-b951-d872f2087c98

Installed the root certificate on each of the chrome-qa bots and
ran the disabled SSL tests to verify. Only managed to install the
root certificate on the windows bots on the chromium waterfall.

TEST=Verified in each chrome-qa bot.
BUG=119110,119173
Review URL: https://chromiumcodereview.appspot.com/10271021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134643 0039d316-1c4b-4281-b951-d872f2087c98

R=ben@chromium.org
TBR=thestig@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10170045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134642 0039d316-1c4b-4281-b951-d872f2087c98

Revert 134625 - Transmit a X-Chrome-UMA-Enabled bit to Google domains from clients that have UMA enabled. Causing startup crash on Linux chromeos bot.

This requires a change to the ChromeNetworkDelegate where we feed the incognito state (a bool) into the object at creation time, so we can check that field when doing our header setting.

BUG=123609
TEST=With UMA enabled (not Chromium), visit www.google.com and ensure that the request header includes X-Chrome-UMA-Enabled with value "1". Ensure that disabling UMA also disables the transmission of this header entirely.  Also, ensure that unit_tests GoogleUtilTests all pass.
TBR=ivankr@chromium.org

Review URL: http://codereview.chromium.org/10108026

TBR=stevet@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10264023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134641 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=crash reporting still works (need to build Chrome, not Chromium) and dbeam%40%20doesn't%20go%20crazy%20trying%20to%20read%20it

Review URL: https://chromiumcodereview.appspot.com/10007040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134640 0039d316-1c4b-4281-b951-d872f2087c98