- 15 Jan, 2021 40 commits
-
-
Alexei Svitkine authored
I ran these locally via an ASAN build running on an emulator and did not see any failures. It's possible whatever issues seen before are already fixed. Bug: 1102747 Change-Id: I6ed6c49b69f2950857ed742856654972d5c0c776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632054 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#844235}
-
siashah authored
We expect to show the IPH bubble up to: *A maximum of 3 times without without having the user dismiss it. *A maximum of 2 times if the user accepts the suggestion with the bubble. We do not care about how many bubbles were shown in the current session, this is to maximize the chances of showing the offer iph when the first time an offer is available. Bug: 1156916 Change-Id: Ia419391d350dd04dd1565ebb53334ec1fdd6a76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625917Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#844234}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I2e29d87ce7fac11f2f24d5fa047cd6b72db05049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633091Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844233}
-
Ken Rockot authored
All mechanical (relative path) changes. Bug: 1004256 Change-Id: Ie93e691769ef885acdc368cb4524ebd3e373ecb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626983Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#844232}
-
Yi Gu authored
NOTRY=TRUE Bug: 1167309 Change-Id: If905b546159bd773b95490192de0f03da9f109d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633923 Auto-Submit: Yi Gu <yigu@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#844231}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d2e76b73efc2..8f5ca26678c1 2021-01-15 syoussefi@chromium.org Vulkan: Move xfb position decl to translator in extension path 2021-01-15 lexa.knyazev@gmail.com OpenGL: Remove avoidDXT1sRGBTextureFormat workaround 2021-01-15 jmadill@chromium.org Capture/Replay tests: Fixes and improvements. 2021-01-15 syoussefi@chromium.org Vulkan: Generate gl_Position.z correction in SPIR-V If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Icd410000b1f1a0090dc8a68a6b5e839e2c340388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633138Reviewed-by:
-
Xiaocheng Hu authored
This patch stops the function from using the deprecated EListStyleType enum, which only works with predefined counter styles. Now it's extended to work with all counter styles that: - For predefined counter styles, the return value remains the same - For custom counter styles, the return value is kOther Note: Ideally, AX should use the 'speak-as' descriptor to handle custom counter styles. This is out of the scope of this patch. Bug: 687225 Change-Id: I9b2065f9b025f268bbb9d44af9f7a1541ed19744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629991 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844229}
-
Michael Thiessen authored
IntentHandler.EXTRA_PARENT_COMPONENT is no longer used by DownloadActivity. Change-Id: I73c315ea62fe44c13364a6d64ca94cf8d14f2dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633802 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Auto-Submit: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#844228}
-
Michael Lippautz authored
Oilpan provided regular and static Persistent references. The main idea was that statically registered Persistent handles would a) be ignored by LSAN and b) would be cleared first during termination GCs. The existing annotations weren't working for a long time as they checked for a registerAsStaticReference() method instead of RegisterAsStaticReference(). The main idea behind b) was that static singletons required explicit clearing as they would otherwise not go away. However, the termination GC also employs a second GC loop that just clears all Persistent references. The only reason to make a difference is that in theory those two sets of Persistent references can be used to provide two stages of finalization. In practice this is hard, as an object may also be reachable from the other set and thus not be collected in the first loop. This CL simplifies the termination GCs to always clear all Persistent roots. In addition to simplification on the user side, this allows for implementing a more efficient algorithm in future (Oilpan library) that does not require a marking phase. This is important as the marking phase in the Oilpan library would include the JS heap which is potentially still large at this point. Support for accessing singletons and adding new objects in dtors is kept. Change-Id: I124a734bce05808f62633a1dbdbbaa314b47e22a Bug: 1056170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629309Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844227}
-
Yi Gu authored
See linked bug for details. TBR=finnur@chromium.org Bug: 1163813d Change-Id: I536916958e5dcec1a25b631b6ffff5d906ec5a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633670Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Auto-Submit: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#844226}
-
Stephen McGruer authored
The chrome and chromedriver binaries are named different or in different places on these platforms. Bug: None Change-Id: I4c551fba8752bd1efeddf89ca34a9191587f53c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557220Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844225}
-
Alex Newcomer authored
UX/PM are researching an experimental key combo (hold ctrl for X time, then press V to show multipaste). Things UX/PM would like to know prior to creating this prototype: 1. Are users pressing Ctrl + V with generally consistent timing? - No current data here. This is important because we do not want to be annoying to users. 2. What time period would be reasonable for holding ctrl without disrupting users? After this metric lands, we will at least know the answer to #1, and may be able to determine #2. This key combo is just an idea as of now, but this data will lead to us being able to build a prototype. There are a11y concerns with this approach, but we likely will not get rid of the old key combo for multipaste, but add this one as a faster way to show multipaste. Bug: 1158619 Change-Id: Ie7b15b2330b1828e1fa99a46218514870efa74a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616243 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#844224}
-
Dirk Pranke authored
Generated by //tools/gn/roll_gn.py https://gn.googlesource.com/gn/+log/595e3be7..1b4a9dfc 1b4a9dfc Rewriting python search logic Bug: 1112471 Change-Id: I0a593ef359499cb397043b6f66aad8f7f2fce7b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626079 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#844223}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1502a9ec072f..86e4bd2600ce 2021-01-15 janscheffler@chromium.org [JSDOC2TS]: Migrate input 2021-01-15 janscheffler@chromium.org [JSDOC2TS]: Migrate help If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia3844e00e55b3f55ece34e0fa95844bd75d6f6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633517Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/15595ea39c44..4f4c064d5b74 2021-01-15 mtklein@google.com roll gn to latest 2021-01-15 fmalita@chromium.org [svg] Add support for mask color-interpolation 2021-01-15 johnstiles@google.com Fix for fuzzer-discovered use-after-free. 2021-01-15 tdenniston@google.com [svg] Implement feOffset filter 2021-01-15 bsalomon@google.com Test all YUVA image factories with different encoded origins. 2021-01-15 johnstiles@google.com Honor fIsScope when emitting a Block's description. 2021-01-15 fmalita@chromium.org [svg] Fix mask edge artifacts 2021-01-15 egdaniel@google.com Fix caps checks for vulkan indirect and instanced draws. 2021-01-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 5255c465bbba to aedd133cd85f (1 revision) 2021-01-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 198dc345383e to 50c82f42e33f (10 revisions) 2021-01-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2930e73f to e330bc98 (559 revisions) 2021-01-15 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 6f833b7f78c9 to 5a6fda1a6fcc (6 revisions) 2021-01-14 csmartdalton@google.com Add GrTriangulator::TriangulateInnerPolygons 2021-01-14 brianosman@google.com Enforce (valid) array sizes in many more places 2021-01-14 tdenniston@google.com [svg] Handle std input case for filter subregion calculation 2021-01-14 tdenniston@google.com [svg] Fix <use> bounds calculation 2021-01-14 mtklein@google.com restore select() in bool->int 2021-01-14 jlavrova@google.com Fixed TextBehavior for one line 2021-01-14 fmalita@chromium.org [svg] Add clipPathUnits support 2021-01-14 mtklein@google.com get rid of I32a/F32a 2021-01-14 johnstiles@google.com Enforce strict type coercion between int and uint. 2021-01-14 johnstiles@google.com Update int/float mismatch test to include uints. 2021-01-14 fmalita@chromium.org [svg] Fix null text context crash 2021-01-14 johnstiles@google.com Enforce stricter type coercion rules in SkSL. 2021-01-14 fmalita@chromium.org [svg] Mask support 2021-01-14 johnstiles@google.com Add SPIR-V support for casts to boolean scalar. 2021-01-14 brianosman@google.com Disallow switch statements in runtime effects 2021-01-14 brianosman@google.com Move all runtime effect error tests to runtime_errors 2021-01-14 mtklein@google.com always init function fReturnValue 2021-01-14 mtklein@google.com slightly tweak bool->int 2021-01-14 johnstiles@google.com Add unit test for int/float mismatch error detection. 2021-01-14 johnstiles@google.com Add SPIR-V support for boolean vector typecasts. 2021-01-14 mtklein@google.com macro hygiene in SkRP_opts.h 2021-01-14 johnstiles@google.com Add unit test for scalar conversion constructors. 2021-01-14 brianosman@google.com Use isNumber() rather than isFloat() || isInteger() 2021-01-14 tdenniston@google.com Reland "[svg] Perform colorspace conversions for filter effects" 2021-01-14 hcm@google.com Update Skia milestone to 90 2021-01-14 djsollen@google.com Add generic uniform setter function to SkRuntimeShaderBuilder 2021-01-14 brianosman@google.com Add unit tests for for-loop unrolling If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Test: Test: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*magic_tiles_3*Test: Test: scripts/roll_aosp.sh && m ANGLE Change-Id: I0c74ebd709762ac5c6c0b4d934f8f2925914b52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633170Reviewed-by:
-
Becca Hughes authored
Change-Id: I2c7115f0bd48afdb5cffc471501679ed71555f78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626923Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Evan Liu <evliu@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#844220}
-
Adam Norberg authored
This is a reland of 669044bf Original change's description: > Implement an ExternalConstants provider that reads from a base::Value. > > This is going to get populated with a JSONFileDeserializer. > > Bug: 1154901 > Change-Id: I5285b3b24a4d574c311addd44e34572b9e863c8b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598004 > Commit-Queue: Adam Norberg <norberg@google.com> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843868} Bug: 1154901 Change-Id: I451b74ea7c23aabfd59bdddf0354c04a3d09cb2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633761 Commit-Queue: Adam Norberg <norberg@google.com> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Adam Norberg <norberg@google.com> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#844219}
-
Eugene Zemtsov authored
ChromeOS video encoder accelerators can resize GPU backed frames internally. There is no need to do it renderer using libyuv CPU implementation. This change also introduces VEA::IsGpuFrameResizeSupported for future more flexible implementation of the same capability. Bug: 1166889 Change-Id: I5c1a23bde637fe894db607904b44facd7cc0d7f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630886Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Igor Ruvinov authored
Update policy description of BrowsingDataLifetime policy to make it more informative while cutting down on the technical details and complexity. Bug: 1163584 Change-Id: I2764fbf7651625667b9199136f17ea6dc709ae41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630865 Commit-Queue: Igor Ruvinov <igorruvinov@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#844217}
-
Nick Burris authored
* Create a new test observer interface PaymentUIObserver intended for cross-platform UI event waiters for testing. * Expand the existing secure_payment_confirmation_browsertests to wait until the UI is displayed rather than just waiting for the PaymentRequest kAppListReady event. This ensures the controller successfully creates the DialogView and calls ShowDialog. Bug: 1124929 Change-Id: Iacec5998e1b15c4e6def109f2c9a465b0f6abffb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631425 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#844216}
-
Domenic Denicola authored
942aca88 switched us from parsing the Origin-Isolation header to parsing the Origin-Agent-Cluster header. This followup updates some of the browser-process code to follow that rename. In particular, it targets the "end result" computation process and resulting console warnings. Some of the other browser-process code might want to stay with the "opt-in origin isolation" nomenclature, as a peer to command-line origin isolation, but this stuff is clearly header-related. This also updates the use counter test. Bug: 1158853 Change-Id: I358e254ff7210a4736469cdf168e7496e6394f16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630367 Commit-Queue: Domenic Denicola <domenic@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#844215}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610711423-66d1757656af1c1220147c4ed72bfc529787f050.profdata to chrome-win32-master-1610722723-5f792ea0c486212ce0348d8664e26e62d0b387f7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I878b8778d4a8ce68ff4ccfcb2cff846668eff04f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633445Reviewed-by:
-
Nathan Zabriskie authored
Currently RasterDecoder::CopySubTexture has three internal functions for performing the copy based on the current backend. Previously copying with Skia could require one extra copy when OneCopyRasterBuffer was in use but this has been fixed with crrev.com/c/2517149. This CL changes the copy to always default to Skia when OOPR Canvas is enabled. A future CL will remove that restriction and always perform the copy using Skia. Bug: 984045 Change-Id: If317ceb59cf7eb93cfce521d2453a44348f6a2ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2570079Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
-
Stephen McGruer authored
Android is no longer supported for running web_tests (and has not been for some time). The SmokeTests file however is still used, by the Fuchsia bots. Bug: 567947 Change-Id: Id4dde2b2d8751b9fadc2a94fdd682b78fba5aeb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629569Reviewed-by:
Rakib Hasan <rmhasan@google.com> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#844212}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610711423-18f006eac9d09987835ac3798b0f3a285cb6646c.profdata to chrome-linux-master-1610733364-157abbebfa8d67c9510c102888afbc9dd88135a0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I11142793551e8d806a5ac104c9a1fef73c1e0324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633453Reviewed-by:
-
Sami Kyostila authored
Chrome is about to switch to the TRACE_EVENT macro implementation provided by Perfetto. The new implementation requires trace event statements to be terminated by semicolons, so this patch modifies the codebase to add semicolons where they were previously left out. No functional changes. Bug: 1006541 Change-Id: If9e1397a58ef93f8dfe6f9302a87420837758e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628300 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
-
Gordon Seto authored
Update 'Forward' button to have a dynamic label. Remove 'Done' and 'Skip Discovery' buttons and replace instances with 'Forward' button. Bug: 1093185 Change-Id: I08259968c5d9ea16e8bad17be12c8cc4be88c198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631226 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#844209}
-
Chrome Cunningham authored
This reverts commit 79de0d4b. Reason for revert: We expect another CL may be the correct fix. https://chromium-review.googlesource.com/c/chromium/src/+/2626920 Original change's description: > Defensive fix for crash in MediaWebContentsobserver > > This defensive fix until MediaSession owners return from vacation. > Reverting is challenging given the long string of CLs. > > GetMediaPlayerRemote(player_id) is crashing for failing to find the > remote with that ID. The stack shows the call coming from > MediaSessionController, which should have the same lifetime as its > associated mojo::Remote<media::mojom::MediaPlayer>. So far, I have not > found how those lifetimes are getting out of sync. > > Ownership looks like this (read -> as "owns", MWCO as MediaWebContentsObserver): > MWCO -> MediaSessionControllersManager -> map<MediaPlayerId, MediaSessionController(s)> > MWCO -> map<MediaPlayerId, mojo::Remote<media::mojom::MediaPlayer>> > > I've combed through all the places where MWCO removes from its map of > MediaPlayer remotes, and looked for a failure to call > MediaSessionControllersManger::OnEnd(Id) to remove the associated > MediaSessionController. There are 3 cases where we remove from the > map... > 1. MediaWebContentsObserver::RenderFrameDeleted() > 2. MediaWebContentsObserver::WebContentsDestroyed() > 3. media_player_remotes_[player_id].set_disconnect_handler(base::BindOnce(... > > The only case where I don't see a call to > MediaSessionControllersManager is #2. But that shouldn't matter since > MWCO's destructor is called shortly (synchronously) after > WebContentsDestroyed(). Its destructor will tear down the > MediaSessionControllersManager. > > The defensive fix does not address the root lifetime issue. It is > probably the case that the MediaSessionControllers are being leaked. > > Bug: 1161551, 1039252 > Change-Id: I85337eae106d8b56b7d48fc9759702dc579855ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2607579 > Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> > Cr-Commit-Position: refs/heads/master@{#839818} TBR=dcheng@chromium.org,mlamouri@chromium.org,chcunningham@chromium.org,liberato@chromium.org,beccahughes@chromium.org,mario@igalia.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1161551 Bug: 1039252 Change-Id: Id12ba170758a4479342c0eb3b2c64bb1243f34b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632919Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#844208}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/428143ee24c5..071c3b1b313a 2021-01-15 ehmaldonado@google.com owners: Support '*' when checking approval status. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1166467 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I1526069a2addedc8df032652c5fa454ad68e8cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633449Reviewed-by:
-
Jeroen Dhollander authored
This CL migrates the implementation of |AudioInputProviderImpl| and |AudioInputImpl| to the new Libassistant mojom service. To reduce the size of the CL this migration has been split in 3 CLs: 1. The mojom APIs 2. The implementation on the Libassistant mojom service (this CL). 3. Changing the Browser side to use the new mojom service. This does mean that this CL has to copy |AudioInputImpl|, |AudioInputProviderImpl| and |AudioInputStream|, rather than move them. In a follow up CL these classes will be removed from //chromeos/services/assistant, when they are unused there. These classes are mostly unchanged, except: - Renamed |AudioStream| to |AudioInputStream|. - Replaced |AudioStreamFactoryDelegate| with |mojom::AudioStreamFactoryDelegate|. - Stripped support for the gn flag `enable_fake_assistant_microphone`, as that would have required some extra files to be moved (and this CL is big enough as-is). I will re-add this in a follow up CL. Note that the fake microphone still works, as this new version is not used anyway. - An extra VLOG in UpdateRecordingState(). Bug: b/171748795 Test: chromeos_unittests --gtest_filter="Audio*" Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I80965e5de31ea48c19363966bae384414b16bcc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605706 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Yaron Friedman authored
BUG=783819 Change-Id: Ib3c902569d57b0849d4ac2eb8ad049317db6946a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626422 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#844205}
-
Cammie Smith Barnes authored
This CL is part of the Code Health Rotation, and converts base::Bind, base::Callback, and base::Closure to Once/Repeating as the code context dictates. It also replaces 'typedef' with 'using' in several places adjacent to other changes. Bug: 1007635 Change-Id: Id5cb1bf95d408dfb67cc92ea2cc636598d0b5262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626767Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#844204}
-
danakj authored
Extensions code wants to run scripts on the initial empty document, so instead of adding a duplicate call to all ContentRendererClients (both RenderFrameCreated and RunScriptsAtDocumentStart) we can have the extensions code do the right thing with the RenderFrameCreated signal. R=dcheng@chromium.org, reillyg@chromium.org Bug: 1158869 Change-Id: I11a969e8b84933f13a5ceadb6e6d3943a5fb5d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627690Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#844203}
-
Yi Gu authored
The test is flaky on all platforms: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=LoadTimingBrowserTest.HTTPS&testType=browser_tests TBR=ryansturm@chromium.org Bug: 1128033 Change-Id: I5de88f598d93ff43f06a617a9713d95375698775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633684 Commit-Queue: Yi Gu <yigu@chromium.org> Auto-Submit: Yi Gu <yigu@chromium.org> Reviewed-by:
-
Peter Wen authored
Based on Søren's sample code in http://b/176818423. D8's java API allows us to determine the exact set of dependencies that a class in the current target depends on to desugar correctly (generally its superclass(es) and interface(s) it implements). The class would only need to be re-desugared with D8 if one of these dependencies changes. This CL makes use of this information in a less granular way. If any jar containing one of these dependencies is changed, then we re-dex all the classes. Even so, this limited reduction in dependencies from using D8 for desugaring reduced the previous regression from +50% to +10% for the base_java_sig benchmark. Follow-up CLs will attempt to make use of the more granular desugar dependency information to further improve the timing of D8 desugar. For the time being, we are continuing to use bazel desugar. Bug: 1015559 Change-Id: If507a4013af7bed0820758629a4b9db69942727b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621928 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#844201}
-
Fabrice de Gans-Riberi authored
The test is flaky. TBR=kmarshall@chromium.org Bug: 1167266 Change-Id: I1a788509d7bb69439549358f6a8ef651a38526d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633841Reviewed-by:
-
Yuke Liao authored
This CL starts running lacros tast tests on the builder: chromeos-amd64-generic-lacros-chrome. Bug: 1158590 Change-Id: I2336084746548f8db6d2596ced7768c9c1088cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622344Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#844199}
-
Hui Yingst authored
This CL changes `scroll_offset_at_last_raster_`, `scroll_offset_`, and BoundScrollOffsetToDocument() from pp::FloatPoint/pp::Point to gfx::PointF/gfx::Point, so that they can be migrated to PdfViewPluginBase later. Bug: 1101101 Change-Id: Iaa845e45b7d6a1d735fb44de3f7194df43b0f32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626926 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#844198}
-
Fredrik Söderqvist authored
The existing name is somewhat peculiar - the new name better describes the CSS syntax being parsed. Change-Id: Ief212daa9e910b9a148f9946206e25f18cc2c81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632690 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#844197}
-
Andrey Kosyakov authored
Bug: 1164469 Change-Id: I0fab507f0a58676abd0143e5bb8ea562bfb113f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628083 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#844196}
-
