- 01 Sep, 2020 40 commits
-
-
Sylvain Defresne authored
The creation of weakSelf in -updateAllTopSitesSpotlightItems was done in a block passed to -clearAllSpotlightItems to be used by an inner block. This caused the outer block (that is passed to Spotlight) to capture a reference to self. As spotlight execute the block on a background thread, this could cause the instance of TopSitesSpotlightManager to be deallocated on the background thread which is not supported (as BaseSpotlightManager owns a base::CancelableTaskTracker which is sequence-affine). Creating the weakSelf outside of all the block ensure that none of them (either the outer or inner block) capture a strong reference to the BaseSpotlightManager, leaving the full ownership of them to SpotlightManager (and ensuring that they are deallocated when shutdown is called). Bug: 1122991 Change-Id: Ie5e91d3cf29da2ecbca91d2c6c3722cf8b6d0769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388280 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#803566}
-
Chris Hamilton authored
BUG=1096617 Change-Id: I962dcb06fdfbbbdc1494a9e4d3f1b1eeda8dbdec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363022Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#803565}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 15 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-11-30. TBR=chromium-metrics-reviews@google.com Change-Id: I91cc8a0e0a1d5ed39fc97a0f949834db3343bf2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387741Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#803564}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 83dffc51. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools nzolghadr@chromium.org, yosin@chromium.org: external/wpt/input-events NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Change-Id: I0f94f9f22dae5de5c468420e99cbbca8760801e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388000Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803563}
-
dpapad authored
Specifically: - change toolbar height from 48px to 56px - add 16px start/end padding - add 4px padding between toolbar icons - adjust margin and padding in zoom-controls Bug: 1123803 Change-Id: I5f8d7b68e3cc651422de7bc58465c2be35440874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386853Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#803562}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/b6c82a149ed8..482642324c4e 2020-09-01 rharrison@google.com Roll 3 dependencies and update expectations (#1133) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I8142d20095bc4095fc8bceb33edf7359292db72e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387945Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803561}
-
Austin Eng authored
Instead of eagerly flushing commands whenever there is a pending callback, enqueue a microtask if one hasn't been already, to perform a flush if it is still needed. This optimization prevents excess IPC flushes. Bug: none Change-Id: Icc48978fdc5d6a54ef61f9379bb4c78d3c75e08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380084Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#803560}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/64e4b1e8e2e8..816506e1c600 2020-09-01 primiano@google.com Update CHANGELOG for v7.0 release If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2652d58830aa73f2ef838014c544189aa9e739e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387958Reviewed-by:
-
Ben Pastene authored
Like crrev.com/c/2386599, but adds one more that was missed on accident. Bug: 1123300 Change-Id: I0b97c17eb77eab08f45009147183c7ea528ef328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388340 Auto-Submit: Ben Pastene <bpastene@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#803558}
-
Tomasz Wiszkowski authored
This has been requested by l10n team. The team also finds annotations better. Screen: http://screen/5hS2fKXfgpmAv7W Original bug: http://b/167229239 Bug: 1096131 Change-Id: I0aac8f04a1cd9fc1d9225410b4af103e59b7c6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386493Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Auto-Submit: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#803557}
-
Stepan Khapugin authored
Removes unused method argument in app state. Bug: none Change-Id: I126ed9d24407311b2bae745ec8af2eec791f10b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386803 Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#803556}
-
Tommy Martino authored
This reverts commit 33d4fbea. Reason for revert: We believe this is causing the build failure that closed the tree: https://ci.chromium.org/p/chromium/builders/ci/win-archive-rel/17171? Original change's description: > PSM: Support PSM RLWE based message definitions in Chromium > > This CL adds the communication between client and server > for issuing and retrieving determination using PSM. It also > supports the usage of private_membership third_party protos > package in device_management_backend. > > BUG=chromium:1094675 > > Binary-Size: Increase is temporary. > Change-Id: If791aa1a4a936e1d42fde397a33c1a19c640359d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245131 > Reviewed-by: David Benjamin <davidben@chromium.org> > Reviewed-by: Amr Aboelkher <amraboelkher@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> > Cr-Commit-Position: refs/heads/master@{#803532} TBR=davidben@chromium.org,emaxx@chromium.org,tikuta@chromium.org,pmarko@chromium.org,amraboelkher@google.com,amraboelkher@chromium.org Change-Id: I33f2f9200c3ef24d7c6059d116a88807d83aa0f0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1094675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388267Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#803555}
-
Alison Maher authored
When adding fragmented OOF positioned layout results to a multi-col, we need to skip over any spanning fragments. Bug: 1079031 Change-Id: I81fc206b2506a66cb7c701c8ff7c7f6d1f7aa364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357514Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#803554}
-
Christopher Cameron authored
The ARM DTK does not specify a PCI device ID for the GPU. Do not fail in this configuration. There are other places, GPUTestConfig::IsValid, for instance, where we explicit allow a zero device ID. Of note is that zero device IDs are allowed only when there is a single GPU. ANGLE's current enumeration code will only enumerate non-PCI devices once no PCI devices are found, so this is will continue to work for the moment. Bug: 1110421, 1121663, 1121672 Change-Id: I7cba1c4d074c291663913b970db3e4085afa0adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387308Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#803553}
-
yiyix authored
In past 2 month, I have moved all tests in blink_perf.canvas to rendering_benchmark. In the future, developers should continue add tests to renderingbenchmark instead to blink_perf.canvas. As this target is no longer needed, I removed it from the code base. Bug: 1077148 Change-Id: Idd8ba7e0a80d3088824c9588be9d022c1455e4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367753Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#803552}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a2e6c1a149f4..4953712980a2 2020-09-01 jaebaek@google.com Handle DebugGlobalVariable using DebugInfoNone If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I10a752171dc92e134f322e05154e2bbcf885b262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387954Reviewed-by:
-
John Smith authored
Themes with images for the ntb use a calculation to determine the right part of the image to use. The ntb was recently moved to a new container (http://crrev.com/c/2333341), which meant that this calculation wasn't getting the right position anymore. Switch to make sure that we get the position of the ntb relative to the tabstrip so it gets the right offset. Bug: 1123195 Change-Id: I917e13bf342f670bc8f50a0b9da6eb84b3691eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382429 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#803550}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009010800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/hpvLwAWDVkSoL-uwAv5VXFc-bqnqhg1pfnTdcLgdoBAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ie7b211de6ac4c743c37bc415a0f8f99a54fb7776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387953Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#803549}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/090049c54646..2bca0089149c 2020-09-01 perkj@webrtc.org Reland "Make cricket::SctpTransportInternalFactory injectable through PeerConnectionFactory Deps" 2020-09-01 zhaoliang.ma@intel.com aec3: Support AVX2/FMA intrinsics in AEC3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibe0724fc6a61f7fd505bbfa7dea44ae994be1953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387956Reviewed-by:
-
Maksim Ivanov authored
Fix bug found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I0b3d37aeebc855e62b5f42af5d886b53fab1dc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386728 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#803547}
-
Nektarios Paisios authored
Document markers were only exposed on static text nodes in the accessibility tree. However, all other textual information, including word boundaries and character bounds, were exposed on inline text boxes. This patch adds document markers to kInlineTextBox nodes in the accessibility tree. This will enable us to use AXPosition for finding and navigating among misspelling and grammar errors on all platforms, including Mac, Win (IA2 / UIA), and Linux ATK, eliminating all the custom code we currently have for each platform. AX-Relnotes: Misspellings are now announced with VoiceOver on the Mac. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I246ab1f267dd5e01d3920a78f26ec377016b179e Bug: 1008031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288789 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#803546}
-
Dominik Röttsches authored
Enable the binding by explicitly passing the bind request over to the Java side, otherwise, the registry on the Java side of things is not reached. Requires: https://chromium-review.googlesource.com/c/chromium/src/+/2347916 Bug: 1121589 Change-Id: I75193e1743a0c86cc7fa364c53fd5ec88650d123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375329 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#803545}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009010800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/KrYfqVB6LhkjazZLnT1OKxOSEdYeE1SUB-xcQF7oD-MC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/167177599 Tbr: help-app@grotations.appspotmail.com Change-Id: I311f64fdaf8629eefb8ca0b049352b3a3776b4e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387134Reviewed-by:
-
Sebastien Marchand authored
Change-Id: Icc92d067d7199960ce25797077c33c65f6855cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2366665 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#803543}
-
Michael Lippautz authored
This removes infrastructure to track backingstore callbacks for compaction. There are no more data structures left using such callbacks. Change-Id: I532ced7f70aa37b3d62bc1a8507042b857f7cb31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386730Reviewed-by:
Omer Katz <omerkatz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#803542}
-
James Cook authored
It is unchanged since it was refactored to use skia.mojom.Bitmap in early 2018. I recently marked skia.mojom.Bitmap as [Stable], so its only dependency is [Stable]. Last non-trivial change: https://chromium-review.googlesource.com/c/chromium/src/+/1004598/ This will allow me to use it in Lacros for the notifications API, to transport high-DPI icon images. Bug: 1116652 Test: presubmits Change-Id: I7161ee8666483f8b536c390d50e9e5cf54872ecc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386458Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
-
adamta authored
Records metrics for several Discover feed back of card actions: - Open in same tab - Open in new tab - Open in incognito tab - Add to reading list - Open Send Feedback form Required by crrev.com/i/3245773. Bug: 1085419, 1122409 Change-Id: Idf4d2dcf958a49828eedf4d090432741e6db44ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387402 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#803540}
-
Becca Hughes authored
Change-Id: Iafcef7fe0cb76d04a48bc8da115f5a84aef8ad32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386286Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#803539}
-
Michael Bai authored
This reverts commit c8026dea. Reason for revert: The fix will be in blink side, revert it by disable the feature by default, to make landing fix easily. Original change's description: > Revert "Make ContentCapture ready for experiment" > > This reverts commit 564da6d9. > > Reason for revert: Very likely the cause of crbug.com/1122472 > See the analysis in crbug.com/1123677#c4 for detail > > Original change's description: > > Make ContentCapture ready for experiment > > > > Currently the triggering of ContentCapture is unpredictable, it is > > hard for us to get the unbiased result for the UserActivatedDelay > > experiment. > > > > This patch adds an ExperimentContentCaptureConsumer which triggers > > the ContentCapture independently and is enabled by default. > > > > The allow list check is moved to consumer if the experiment > > is enabled. > > > > As ContentCapture is potentially used for all Android versions, > > we plan to run the experiment for all of them. > > > > This mechanism will also be used for future experiments. > > > > This patch hasn't supported multiple consumers yet. > > > > Test: Added new tests and pass the existing tests > > > > Bug: 1114819, 1119663 > > Change-Id: I72e0b991767329caec37080caae2d5c2a9068eaf > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368104 > > Commit-Queue: Tao Bai <michaelbai@chromium.org> > > Reviewed-by: David Trainor <dtrainor@chromium.org> > > Reviewed-by: Changwan Ryu <changwan@chromium.org> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801672} > > TBR=michaelbai@chromium.org,wangxianzhu@chromium.org,dtrainor@chromium.org,changwan@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1114819 > Bug: 1119663 > Bug: 1122472 > Change-Id: Ife98d73f4e77062606f18adb0ba12e9baaf4f6c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386578 > Reviewed-by: Haiyang Pan <hypan@google.com> > Commit-Queue: Haiyang Pan <hypan@google.com> > Cr-Commit-Position: refs/heads/master@{#803349} TBR=michaelbai@chromium.org,wangxianzhu@chromium.org,dtrainor@chromium.org,changwan@chromium.org,hypan@google.com # Not skipping CQ checks because this is a reland. Bug: 1114819 Bug: 1119663 Bug: 1122472 Change-Id: I0763e728f9f75701c05ef9ae51f359eb78723660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387429Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#803538}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/AOMediaCodec/libavif.git/+log/94ac5b4c7215..f88383daa8de $ git log 94ac5b4c7..f88383daa --date=short --no-merges --format='%ad %ae %s' 2020-08-31 wtc Make AVIF_ENABLE_WERROR enable -Werror or /WX only 2020-08-28 wtc Generalize the sanity check for the sum of extents 2020-08-21 kornel Option to build with compilers that have more warnings 2020-08-28 wtc Miscellaneous minor cleanups 2020-08-28 wtc Validate adds, casts in avifParseItemLocationBox 2020-08-18 dnovomesky Transformations support (crop,rotate,mirror) in gdk-pixbuf loader 2020-08-29 nathbappai gdk-pixbuf/loader.c: Include stdlib.h for strtol 2020-08-28 jdrago Fixes for oss-fuzz 25266 2020-08-28 jdrago Support multiple extents in an ItemLocationBox 2020-08-27 jdrago Codec-specific options plumbing for advanced encoding settings (unused, first pass) 2020-08-22 wtc Disable -Wpoison-system-directories if supported Created with: roll-dep src/third_party/libavif/src R=dalecurtis@chromium.org Bug: 1122634 Change-Id: I28fbb6810da03aace61d932709119c1b03650915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386673 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Miguel Casas authored
Video encoding doesn't use the GPU workarounds but those are great to interact with e.g. external partners. This CL wires those for hardware accelerated video encoding -- for two operations: profile enumeration via GpuVideoEncodeAcceleratorFactory, and VEA Initialization via MojoVideoEncodeAcceleratorProvider/Service). It also removes the hardcoded VP8 encoding blocklist, and adds a GPU workaround for it (looks like [1] in chrome:gpu). [1] https://i.imgur.com/ML66OJG.png (imgur.com/a/uO1PFlQ) Bug: 1120411, b:158655609 Change-Id: I44500d4c4b1b9d43c148084f234c57edb674c638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368465 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#803536}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d397f7662abb..977b68ba4969 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tmartino@google.com,mamir@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tmartino@google.com,mamir@google.com Change-Id: Ife2ad3d98ba5b4dc5b9108e1d0ca2efe7c03d2d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387946Reviewed-by:
-
Thomas Tellier authored
Bug: 1123639 Change-Id: Id75eaed4b6d143199d9280825009ecf01ee6c08f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387114Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Thomas Tellier <tellier@google.com> Cr-Commit-Position: refs/heads/master@{#803534}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c21fdb07d60c..736c43a1bb8f 2020-09-01 tobine@google.com Rename ANGLE apk package to org.chromium.angle If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I035d8ce9c561a4823c57c09fd489409523898a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387947Reviewed-by:
-
Amr Aboelkher authored
This CL adds the communication between client and server for issuing and retrieving determination using PSM. It also supports the usage of private_membership third_party protos package in device_management_backend. BUG=chromium:1094675 Binary-Size: Increase is temporary. Change-Id: If791aa1a4a936e1d42fde397a33c1a19c640359d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245131Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Amr Aboelkher <amraboelkher@chromium.org> Cr-Commit-Position: refs/heads/master@{#803532}
-
John Budorick authored
Bug: 1097306 Change-Id: I7a96cddd408d6b75e3a55c68f7e18fd481476361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384079 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#803531}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/19157ee4a2fd..64e4b1e8e2e8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic74629579a574b82d5b7ce54159a418b32611134 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387428Reviewed-by:
-
Xing Liu authored
This CL adds a boolean check for stopForeground that if startForeground is not called, then ignore stopForeground call. Bug: 1121096 Change-Id: I71295038925947472b0df7be2630a7cffbb79f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386421Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#803529}
-
Ewann authored
This CL adds a dynamic string to the action sheet that asks for confirmation to avoid unwanted tab clearing. Bug: 1119319 Change-Id: I42c28f820c7354d86c112b20fe003bd912116cfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362656 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#803528}
-
Adam Rice authored
Create a README file for blink/renderer/modules/encoding. Change-Id: I713876693d0a604d08d68bc0d0e275b5976b4ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386683 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#803527}
-
