- 11 Dec, 2020 40 commits
-
-
Dirk Pranke authored
This CL makes Python 3 be the default script executable used by Ninja to run action() and action_foreach()'s during the build. This does *not* mean that everything works with Python3; many targets may still use Python 2 via the python2_action() and python2_action_foreach() targets or via custom logic. However, it does mean that it should prevent regressions from creeping in. This CL should not be taken to imply that we can start to write Python3-specific code that can run during the build; we should still be trying to ensure that everything is compatible with Python2. Also, this CL does not enable the use of vpython in actions; we should still avoid that because vpython is slower than direct Python invocations. Bug: 1112471 Change-Id: I472b032b500715156d955b0758640a7ed0384305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515787Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#836234}
-
Edman Anjos authored
Bug: None Test: NA Change-Id: Iea59f14f50bb3f3fa6d5f9b4efaad582ec8b9d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584853 Auto-Submit: Edman Anjos <edman@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#836233}
-
John Lee authored
Fixed: 1142080 Change-Id: Ib9fee0ddff34897d56779009ba7463a12fb57940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580183 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#836232}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I2b4eb95a7eed50807e69e6e2921ffaa3b2fee8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586034Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836231}
-
Joe DeBlasio authored
Enabling by default in preparation for 100% launch. Change-Id: If5bdb740c73758da16cdce4deae7e18bf73b8ad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586266 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#836230}
-
Guido Urdaneta authored
This CL updates queue management for MSTP as follows: 1. The main queue management now occurs in the underlying source and not in the stream controller. A frame is enqueued in the controller when pull() is invoked, or a when a new frame becomes available after a previous pull with an empty queue. 2. When the queue is full and more frames arrive (i.e., in a situation of slow consumption), old frames are dropped. Before this CL, incoming frames were dropped when the controller queue desired size exceeded a threshold. 3. The queue size is now configurable from the JS side (via a constructor parameter). This makes it possible to support more use cases than with a fixed queue. The new parameter will also be useful for audio when it becomes available. Fixed: 1157605, 1157604 Change-Id: I0260f7d5fe0495c33cfc022ce534ef04c518e90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587034 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#836229}
-
Peter Kasting authored
Technically this variable was not uninitialized, as the caller sets it to 0 beforehand. But this is fragile and unclear. Bug: none Change-Id: I85b56897e9dd767835efa14fd8389ce3005f8e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586185Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#836228}
-
Aleks Totic authored
Turn on TablesNG virtual test suite. 23 tests that used to fail in Legacy now pass. 14 tests in the test suite are still failing. 5 fail because of incorrect anonymous table fixup. virtual/layout_ng_table/external/wpt/css/css-tables/anonymous-table-ws-001.html virtual/layout_ng_table/external/wpt/css/css-tables/fixup-dynamic-anonymous-inline-table-001.html virtual/layout_ng_table/external/wpt/css/css-tables/fixup-dynamic-anonymous-inline-table-002.html virtual/layout_ng_table/external/wpt/css/css-tables/fixup-dynamic-anonymous-table-001.html virtual/layout_ng_table/external/wpt/css/css-tables/table-model-fixup-2.html 3 fail because "ignore percent inside flex/grid/td" has not landed virtual/layout_ng_table/external/wpt/css/css-tables/percent-width-ignored-001.tentative.html virtual/layout_ng_table/external/wpt/css/css-tables/percent-width-ignored-003.tentative.html virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/percentage-sizing-of-table-cell-children.html 2 fail because "caption-side:left is not implemented" virtual/layout_ng_table/external/wpt/css/css-tables/floats/floats-wrap-bfc-006b.xht virtual/layout_ng_table/external/wpt/css/css-tables/floats/floats-wrap-bfc-006c.xht 1 fail because "table height distribution to rows does not distribute to head" filed an issue virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/extra-height-given-to-all-row-groups-004.html 2 fail because "rowspan + visibility:collapse differ from standard" virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-colspan-003.html virtual/layout_ng_table/external/wpt/css/css-tables/visibility-collapse-rowspan-005.html I think virtual/layout_ng_table/external/wpt/css/css-tables/height-distribution/computing-row-measure-0.html is a bad test. We match FF, will check with dgrogan Bug: 958381 Change-Id: I08e7713e908638262d61cd0742e2bf0b77ed0b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586269 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#836227}
-
Hongchan Choi authored
The comment doesn't seem actionable and not sure what the alternative is. Bug: 854229 Change-Id: I87e1ac40e874303e73f043a87d9d56a90b7585e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577533 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#836226}
-
Nektarios Paisios authored
Cleanup: Modernizes some parts of CrossPlatformAccessibilityBrowserTest, enables all disabled tests and makes them more consistent with other accessibility browser tests Some tests having to do with iframe traversal in CrossPlatformAccessibilityBrowserTest were disabled. In https://crrev.com/c/2556452, the kPDFRoot role is being added and the kWebArea role is being removed. Iframe traversal tests should be enabled and functioning to ensure the robustness of any code changes in those roles, as they could potentially break iframe navigation. Meanwhile, many of the code convensions used in CrossPlatformAccessibilityBrowserTest were different from all other accessibility browser tests and some have been superceded by changes to C++. This patch switches to using raw literal strings for loading HTML snippets, improves indentation, and uses the same method names for loading test pages as in other accessibility browser tests. Also, useless comments were eliminated and test fixtures cleaned up were necessary. Originally split out from https://crrev.com/c/2556452 AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: Ia9c3094606581468d7f1b5c8849bb44668b47de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575101 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#836225}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a77bc1f1e690..d9318acc24b0 2020-12-11 syoussefi@chromium.org Roll VK-GL-CTS from 41331850eb21 to 54509765b18d (18 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I34743d47a6b0043dd12eed5fc2e43b482e1f5179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587254Reviewed-by:
-
Yuly Novikov authored
Suppress as flaky on Mac Catalina Unskip on Win10 to gauge flakiness rate Bug: 1085222 Change-Id: I62ee9d7bfa92c9b0f5ec7b577bb94e6c3486749a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585630Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#836223}
-
Joel Riley authored
Original patch: http://crrev.com/c/2568547 Revert: http://crrev.com/c/2583106 Fix for issue where focus ring appears below switch access panel. Now clients can specify if they want their focus ring to appear above or below accessibility bubble panels. STS will specify they appear below, though other clients will (by default) specify they appear above all panels. This fixes an issue with the switch access focus ring didn't appear above the switch access panel. Original description: Move focus rings and highlight layers under accessibility bubbles. Will allow Select-to-speak panel UI to appear above focus ring and highlight layers. This also avoids the need to create more window containers. Bug: 1157261, 1143814 Change-Id: Ibd8dd577ecd4fb5767b628c2eff679a2f6931b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582997Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#836222}
-
Michael Checo authored
Screenshot: http://shortn/_2F4mclWC9p Bug: 1154764 Test: unit_tests --gtest_filter=NearbySh* Change-Id: I76b370e10e2b1b2e38b7c33eb29f4b4b36f677a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576635 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#836221}
-
Alex Moshchuk authored
Bug: 1157137 Change-Id: I4ed35a4620b9672baaec7edaa03a5f75cc2516f7 Tbr: omorsi@google.com, emaxx@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586957Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836220}
-
minch authored
The contents of DesksBarView is put inside the ScrollView to support the scrollable desks. And the customized BentoDesksBarLayout is used to layout the contents. The follow up work will include new style of new desk button, define the minimum width of the mini view to make sure the desk's name can always be seen, etc. Bug: 1147245 Change-Id: Ic75f21d1b534723a551f3e56ab0edbfac4e07d4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566350Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#836219}
-
Min Qin authored
This CL fixes a couple issues on counting tile impressions on NTP. 1. NTP calls TileManager::GetTiles() to get both the top and sub tiles. While Omnibox makes two separate calls of GetTiles() and GetTile(). This CL fixes the behavior of NTP to match that of Omnibox, so we can count top level tile impression when GetTiles() is called, and counts subtile impression when GetTile() is called. 2. Clicking the home button will often invoke 2 calls to GetTiles(). One caused by QueryTileSection ctor, one caused by OnLoadUrl() for NTP. We don't actually need to reload tiles if user never clicked on any tiles. In most cases, only the call from ctor is necessary. This CL fixes the issue by checking whether tiles has been clicked before reloading all tiles. BUG=1155919 Change-Id: Ief1f4be957d160119c40fec1da71ae79d6258321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576504 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836218}
-
Peter Kasting authored
Various functions were unconditionally casting non-representable values. Bug: 1124595 Change-Id: I811f44164a7c9f5802287e1d826cf403ff2e08e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585669 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Orin Jaworski authored
Bug: 1157612 Change-Id: Iebd56655a223360f716c0d075c68fa2572fd1508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585752Reviewed-by:
Angela Yoeurng <yoangela@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#836216}
-
Dominic Mazzoni authored
The ForcedColors feature is fully implemented and on track to ship in M89. That brings Chrome to parity with Edge in how it handles Windows High Contrast mode and it also gives web developers new CSS features to detect and override it where needed. InvertBubbleView was our previous solution - if a user had high contrast mode enabled, we'd show this bubble to direct them to an extension and theme to get a similar effect. Those recommendations are now no longer necessary. Bug: 970285 Change-Id: I0e0e78e489f2a40f1618055b7ebaea660e155e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586367 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#836215}
-
Richard Stotz authored
This CL fixes some minor issues with NativeIO's web platform tests. - The concurrent_io tests obtain a more unified structure to reduce the chance of missing an await. - createFile() is removed from close_async as the exact same function is provided by resources/support.js. Bug: 1157915 Change-Id: I3e33cc8d93e08c31dddc4d844310c92eeba31a7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587058 Commit-Queue: Richard Stotz <rstz@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#836214}
-
dpapad authored
Bug: 1132403 Change-Id: I013ec9272dfb73fd0ccc1c205397d561be65c84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581441 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Ryan Sturm authored
This is a reland of 583f52a3 See https://chromium-review.googlesource.com/c/chromium/src/+/2585991/2 for underlying MSAN issue unrelated to this CL (just caught by this CL's tests) Original change's description: > Search Prefetch Streaming requests can be cancelled after headers > > The goal of this CL is to allow unneeded requests to be cancelled > when they are unlikely to be navigated to. This is achieved through > a few avenues of change: > > -- When the user navigates to something in omnibox, the URL is reported > to Search Prefetch Service to be able to mark it as likely to be served > (using kCanBeServedAndUserClicked when the request is kCanBeServed). > This occurs before the omnibox is closed and all results are wiped. > -- kCanBeServed are wiped when omnibox closes. > -- Streaming requests will no longer pause the mojo channel, so they can > witness the Complete event to be able to make the request as complete. > -- As part of above, we store the response body in memory instead of > just handing off the data pipe. Data pipes have a 500k data limit, which > search requests typically go over. Net won't send the complete event > until all data is in the pipe. Therefore we store the data and create a > pipe to navigation if needed. > -- Full body implementation now reports kComplete where it used to > report kCanBeServed. > > Bug: 1156325 > Change-Id: Ied70a3eafd896801e263f631cb4d80556e762180 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583112 > Reviewed-by: Tarun Bansal <tbansal@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Commit-Queue: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835897} Bug: 1156325 Change-Id: Ifeeed421e9124f99a0f6aa27ca08734a1b130878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587263Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#836212}
-
Pranav Batra authored
If packets are rate limited by CUPS proxy, the print request will probably fail. We want this information to always be logged so that we can determine whether or not rate limiting is the cause of the print failure by looking through the log. Bug: 1157699 Change-Id: If1cb5689ca8f645a63ea93a0b4e368d83319e88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586756Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#836211}
-
Jesse Schettler authored
Update the layout of the elements in the done section to conform to the spec. Spec: https://carbon.googleplex.com/cros-ux/pages/scanning Screenshot: http://shortn/_b4ThkiWjXu Bug: 1059779 Change-Id: If058edfe23fa4ef15fa2e85931d72e4867ba3756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586764Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#836210}
-
Jarryd authored
This change also adds a basic test to verify the action. Bug: 1156349 Change-Id: Ic1f0f331e72029cd8bb95368d525bc27c3e247a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580485 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#836209}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/203ae7e60e20..29339074e443 2020-12-11 ethannicholas@google.com fixed SkSL crash when performing binary operations on invalid types 2020-12-11 johnstiles@google.com Add Metal support for the `findLSB` intrinsic. 2020-12-11 brianosman@google.com SkSLSlide: Fill the entire canvas with the user shader 2020-12-11 ethannicholas@google.com Revert "Reland "Reland "Revert "Initial land of SkSL DSL."""" 2020-12-11 tdenniston@google.com [svg] Minor cleanups 2020-12-11 nifong@google.com Update buildbot repo to deploy debugger changes 2020-12-11 brianosman@google.com Add shadertoy style 'iTime' to SkSLSlide 2020-12-11 johnstiles@google.com Add support for scalar `faceforward` intrinsic in Metal. 2020-12-11 tdenniston@google.com [svg] Add feFlood filter node 2020-12-11 johnstiles@google.com Add Metal support for degrees() and radians() intrinsics. 2020-12-11 johnstiles@google.com Clean up Metal bitcast implementation. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I7f3e003f22b2bd9d4ed80f3d0bcde2a0197b70bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586032Reviewed-by:
-
Pranav Batra authored
tast.printer.ProxyPinPrintLexmark.no_pin appears to be failing due to throttling. Increase the rate limit to prevent this. Bug: 1157699 Change-Id: I51b4268551bdcee5003be84c161e2a8ff9894df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586757Reviewed-by:
-
Ryan Sturm authored
render_process_assignment_ was uninitialized and can be used in OnHidden before OnCommit happens. We'll move to the optional pattern used in this file. Bug: 1157751 Change-Id: I4c126735ef51b126b93208cc61a1a08802bde802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585991Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/671ca647718c..0a8e6d54fba6 2020-12-11 sidereal@google.com Introduce guest_vm_image config 2020-12-11 batrapranav@chromium.org uprev_lib.py: Do not ignore ebuild version errors 2020-12-10 vapier@chromium.org cros deploy: speed up --unmerge 2020-12-10 mmortensen@google.com DebugSymbolFiles: Add functionality to generate breakpad symbols. 2020-12-10 jbates@chromium.org usergroup_baseline: add crosvm to traced-producer group If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I0bc4adaec54754a1d6492d5087a5d8d077a713b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586907Reviewed-by:
-
Matt Wolenetz authored
This change: 1) Implements WebSourceBufferImpl::AppendChunks(), plumbing the appended chunks through ChunkDemuxer into the stream parser's ProcessChunks(). 2) Implements WebCodecsEncodedChunkStreamParser::ProcessChunks(), emitting cached config when necessary (prior to calling the NewBuffersCB, initially, or if a flush() operation had just happened before the chunks were appended. 3) Aligns as much as possible with existing architecture for similar handling by regular bytestream parsers, for improved reuse and maintainability. 4) Adds a basic end-to-end vp9 video chunk buffering and playback test. Later refinements will add more tests and may improve usability with things like EncodedAudioChunk duration, EncodedVideoChunk decodeTimestamp, and h264 support (where applicable by build flags). BUG=1144908 Change-Id: Ib787d22b0171826fa28bdbb776410e02e25a9cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575501 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#836204}
-
Thomas Lukaszewicz authored
This CL fixes it so the margins from the beginning of the tab search item to the favicon match those from the end of the tab search item to the close button. This CL also hides the close button when the tab search item is not hovered or focused to increase the space available to tab titles and hostnames. Before: https://drive.google.com/file/d/1cmuKp4R_nVc7eAaljtIbFX2g0nwlIzKT/view?usp=sharing After: https://drive.google.com/file/d/1oa0lyapwxIGwtCpbxc61bJdPD03gfdVC/view?usp=sharing Bug: 1128599 Change-Id: I6d49a6982483a87028f2d562884f752b82ea6cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582629Reviewed-by:
Roman Arora <romanarora@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#836203}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/54c26addfe46..977eeb69af7b 2020-12-11 vmpstr@chromium.org Add content-visibility information for node highlight. 2020-12-11 sigurds@chromium.org Refactor ExpandableApplicationPanelTreeElement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1147510,chromium:1157484 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibb3b1803836a96ab3228f7ac234b8115a0bb1831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586103Reviewed-by:
-
Matt Wolenetz authored
This change: 1) Implements SourceBuffer::appendEncodedChunks(). This is the first promise-based MSE API. Like async appendBuffer(), once the synchronous prepareAppend steps are complete, an async task is scheduled to complete the chunks' append. Unlike async appendBuffer(), the 'update', 'updateend', 'abort', 'error' events involved in an async chunk append are not enqueued, as the same information is exposed instead in promise rejections. Also, mixing event-notification with promise resolution/rejection is confusing and redundant, and w3ctag guidelines for promise-based APIs need such events originating in a promise's async execution to be dispatched (not just enqueued) prior to promise resolution/rejection occurring. 2) Converts (using new local helpers in SourceBuffer) the chunks directly into the type used in the underlying MSE buffering implementation (StreamParserBuffers in a circular_deque) during the synchronous portion of appendEncodedChunks(). 3) The async chunk task is canceled during contextDestruction; it also is used to gate hasPendingActivity. Essentially, it's a 3rd async operation the SourceBuffer could do (in addition to pre-existing async appendBuffer and async remove). At most one of these three async operations may be pending at a time. This keeps the behavior unsurprising and aligns better w.r.t. previous similar async MSE operations. 4) Adds a new WebSourceBuffer AppendChunks method and a stubbed implementation of it in WebSourceBufferImpl. Later changes will update WSBI::AppendChunks() to send the buffers through ChunkDemuxer to the WebCodecsEncodedChunkStreamParser, and add tests for promise rejection/abort/success scenarios and basic end-to-end buffering and playback of encoded chunks with MSE. Refinements, such as supporting h264 chunk buffering, using non-hardcoded audio chunk duration (from a new optional duration, but required-for-MSE, EncodedAudioChunkInit attribute), and letting the app provide decode timestamp in EncodedVideoChunkInit, may also come later. BUG=1144908 Change-Id: Ieb5d0942e68f48156bee9290dcb99dad2e280e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574534Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d1910cef3a77..f48161bc4b8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alexmos@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: alexmos@google.com,eirage@google.com Change-Id: Iff6e88691998d07ccdc53d6b058129957b00e749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586318Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836200}
-
Luke Zielinski authored
TBR=robertma Change-Id: I55fc4259b71e41da2db975917c8e8585cce5f10f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587348Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#836199}
-
Olesia Marukhno authored
Announce to screenreaders that a permission has requested if chip UI is used. For prompt UI, the bubble is shown and it takes over the focus. Chip UI is less intrusive so it must be explicitly annouced for screen reader users. To avoid users not hearing the announcement, it would be reannouced after 2 minutes. Chip UI is now one of the panes (users can cycle through panes with F6). This way users can easily access it with keyboard which is very important for screenreader users. Also to make sure that users don't miss pending permission request, added message about having pending permission request to tab announcement. Bug: 1150836 Change-Id: I7118abcf0bed9702cf17d15a9bb59f9a1d8783b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578843 Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#836198}
-
Mehran Mahmoudi authored
Change-Id: I7e203ddd04ab61e1f480db09380ec90d7e95ffc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583002 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#836197}
-
Robbie Gibson authored
The major issue here was that the height calculation in horizontal_layout.mm wasn't taking the collection view's contentInsets into account when calculating the sectionInset. This meant that the resulting layout was too large. Specifically, the vertical sectionInsets + contentInset + item height ended up larger than the collection view's height, causing the layout to be incorrect. Fixed: 1155601 Change-Id: Ie9594fec2762239963bc90c41bf07f8caa42bf83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587038Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#836196}
-
Robbie Gibson authored
Before, -setInsetForRemoteTabs wasn't being called because the tab grid was appearing in a different way (through the pan handler). Fixed: 1155610 Change-Id: I1444624c2bf7d6c3c379f083205a520a731cab98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585095Reviewed-by:
-
