- 25 Jun, 2020 40 commits
-
-
Himanshu Jaju authored
Implements the HTTP APIs for Tachyon Express to send and receive messages between devices. Tachyon would be used as the signaling channel for webrtc messages in Chrome Sharing. The actual mojo implementation and tying it to the utility process is upcoming in the next CL. Bug: 1082305 Change-Id: I62e1c3a2deb8a6ef376e474b5ce353a3cb863232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250061 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#782712}
-
George Burgess IV authored
The intended fix for this is https://reviews.llvm.org/D77421, which is now a part of both the CrOS and Chromium toolchains. Removing this should now be safe. Bug: 1062006 Change-Id: I1557aa18898966c14aafd53b64027e61b0afb5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267452Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#782711}
-
Andrew Grieve authored
E.g.: https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-fyi-rel/884 Regressed in 71bd025e Bug: 1078460 Change-Id: I6b265fa7f542964c685bf18556f112ac491cbc68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268399Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#782710}
-
John Delaney authored
What: Create a PageTimingSender for frames that abort their initial navigation with a doc.write to render content. This is done by observing document element without a committed load. Why: This behavior has been seen numerous times in the wild causing, where PLM byte metrics are not catching the majority of network usage by the page. In a number of instances, there are video players loaded inside of these frames causing most network bytes to be unattributed to the PageLoad. This also affects the HeavyAdIntervention, which uses PLM measurements to trigger unloading. How: For these types of loads, we will not send paint timing, render data, or metadata updates to the browser process. There is currently a lack of understanding regarding paint timing in frames like this. There is also no browser process machinery to merge timing updates in frames that do not have loads (as we cannot get a navigation start offset). It is unclear the effect that this change will have overall on metrics. Anecdotally, it is not expected to not produce a significant change due to being a fairly nuanced edge case. Bug: 914893 Change-Id: Ic696e693e11f2d7cdcd8c97e9418a55d7bf4b2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1822218Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#782709}
-
Chris Mumford authored
Disabling flaky test: DemoSetupArcSupportedTest.ShowOfflineSetupOptionOnNetworkList Bug: 1099402 Change-Id: I5f8dc26198f3e6fb0e3a7f4f0da4c69e2f93a5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268297Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#782708}
-
Sammie Quon authored
This is a heavy animation as it basically calls into UpdateResize which resizes both windows (or one window and overview). Also, changes the animation to use a runner which is synced with the compositor. Test: none, will update tast-tests Bug: 1047495 Change-Id: Ic29eb0dd831e7bbc5115268f8c09718b6fc82796 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254820Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#782707}
-
Swapnil authored
ExtensionInstallEventLogManagerWrapper class observes the pref that indicates whether to log events for extensions. If the event logging is enabled, it creates an |ExtensionInstallEventLogManager|. ExtensionInstallEventLoggingEnabled policy is added which allows the user to opt in or out of event based reporting. Bug: 1092840 Change-Id: I98659c9092b4e3c1c8d9fbab612c72477dd8a71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249779Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#782706}
-
Dana Fried authored
Only occurs when the "enable new badges" flag is enabled. Bug: 1098731 Change-Id: I75bb992c7f4d50c7c2bdac506782133e86a95fab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264253 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#782705}
-
Andres Calderon Jaramillo authored
Fixes for reland (see changes since PS1): 1) PlatformVideoFramePool used DmabufVideoFramePool::GetDmabufId() to track video frames in use, but this is no longer applicable since now the video frames are GpuMemoryBuffer-backed (instead of dma-buf-backed). Therefore, we use the GpuMemoryBuffer ID instead. 2) Because PlatformVideoFramePool now uses GpuMemoryBuffer IDs, the unit tests are adapted to use GpuMemoryBuffer VideoFrames. We use FakeGpuMemoryBuffer for this purpose. However, it was necessary to adapt FakeGpuMemoryBuffer to handle more buffer formats. Instead of adding special cases for the new formats, we use VideoFrame's static methods to make FakeGpuMemoryBuffer more general. 3) V4L2WritableBufferRef::QueueDMABuf() is adapted to handle GpuMemoryBuffer video frames. 4) We allow creating a V4L2ImageProcessorBackend that uses GpuMemoryBuffer video frames for output. This is needed to avoid problems in kukui (and likely other MediaTek devices). Original change description: > In the newly introduced VideoDecoder, we create a native buffer for > video decoding on demand in the PlatformVideoFramePool. This buffer > eventually makes it to the MailboxVideoFrameConverter in order to > produce a SharedImage for the client. > > This CL ensures that the NativePixmap created in the > PlatformVideoFramePool can be re-used in the > MailboxVideoFrameConverter. Before this CL, we would call > CreateNativePixmapFromHandle() unnecessarily when creating the > SharedImage for a buffer. That's because we didn't propagate the > GpuMemoryBufferId correctly from the PlatformVideoFramePool to the > MailboxVideoFrameConverter and the check in [1] would fail. As a > result, we would end up creating an additional DRM framebuffer which > is unnecessary because the allocation in the PlatformVideoFramePool > would have already created one. Thus, the video.MemCheck.h264_hw > test would fail because of having created too many objects. > > To propagate the GpuMemoryBufferId correctly, we create a > GpuMemoryBuffer VideoFrame in the PlatformVideoFramePool (instead of a > dma-buf VideoFrame). That way, when MailboxVideoFrameConverter calls > CreateGpuMemoryBufferHandle(), it gets a GpuMemoryBufferHandle with > the same ID that PlatformVideoFramePool gets. Additionally, we make > MailboxVideoFrameConverter use kPlatformVideoFramePoolClientId since > that identifies the namespace of the GpuMemoryBufferIds in question. > > Note that for SCANOUT_VDA_WRITE buffers (which we use for video > decoding), we end up creating a ClientNativePixmapOpaque when creating > a GpuMemoryBufferImplNativePixmap. This is problematic because a > ClientNativePixmapOpaque doesn't let us query the stride and we need > to know it in order to create a GpuMemoryBuffer VideoFrame. Therefore, > GpuMemoryBufferImplNativePixmap::stride() is changed so that it's not > necessary to have a gfx::ClientNativePixmap to query the stride. > Instead, we query the underlying NativePixmapHandle directly. > > For that same reason, we must introduce a workaround in the > VideoFrameValidator: when we get a GMB VideoFrame, we cannot map it > directly because ClientNativePixmapOpaque doesn't allow us to. > Therefore, we extract the dma-buf FDs and use the regular dma-buf > mapping path. > > [1] https://cs.chromium.org/chromium/src/gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc?l=152&rcl=d96e9f16ae852ec9dbd15bf17df3d440402413bb > > Bug: 1091450, 1093644 > Test: video.MemCheck.h264_hw_switch, video.DecodeAccelVD.h264 on eve > Change-Id: I3d60efa362b66bd2f01139296d4ed756c8777ef8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2233534 > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Chih-Yu Huang <akahuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780504} Bug: 1091450, 1093644, 1097755, b:159589162 Test: video_decode_accelerator_tests --use_vd on kevin/kukui w/ DCHECKs Change-Id: Id12e318adee090b6969748e7df33070b80a0c5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258252 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#782704}
-
Stephanie Kim authored
Bug: 1072012 Change-Id: I0a40c29081459e3308e07f17c22968ac9f913c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267412Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#782703}
-
Xiaocheng Hu authored
In previous study, we found out that: - The "failure" mode of this intervention breaks icon fonts massively - Icon fonts generally define almost all of their glyphs in Private Use Area, while non-icon fonts don't use PUA that much Hence, this patch adds a heuristic to decide whether a font is an icon font by checking its PUA usage, and use that as a hint to decide whether AlignFontDisplayAutoTimeoutWithLCPGoal should move a font into the failure display period. As a result: - Non-icon fonts that don't finish loading fast enough after navigation will end up with fallback - Icon fonts will have the same behavior as before Bug: 1065508 Change-Id: I54e52e714a74c17b647d8b072d2f634660e56627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261898Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#782702}
-
Mirko Bonadei authored
This is a reland of 5906c258 This CL adds .def files for release builds (and changes the generator script to generate them at roll time). The issue was that release component builds (is_debug=false) were trying to link symbols that were not available in release mode .obj files. Original change's description: > Abseil component build (default symbols visibility). > > This CL introduces an Abseil component on which all Chromium Abseil > clients will have to depend on. > > Abseil doesn't export symbols explicitly, so for the moment Chromium > exports all of them when is_component_build=true. On Android, Linux and > Mac -fvisibility=default is used while on Windows a .def file is > generated at Abseil roll time. > > Bug: 1046390 > Change-Id: I1697eb9e0179cee01badcf1b687acd94160e5f6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174434 > Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781225} Bug: 1046390 Change-Id: Ieb48ec9eff6d08a0770c4b22521536bb29a76121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264062 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#782701}
-
Rachel Wong authored
This CL addresses a bug where suggested_content_info_view_ might still be visible if assistant_privacy_info_view_ exists, due to its SetVisibility not being explicitly configured. Bug: 1079169 Change-Id: Ifacc5291da2a09af6a6620ae0ed5693dacdc4c5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259421 Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
-
Yulun Wu authored
Bug: 1098711 Change-Id: I410ca6745c858286a5b828464049c5168ed32bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268262Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Yulun Wu <yulunwu@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#782699}
-
Andre Le authored
BUG=1093614 Change-Id: Ie5a368ff723970b10527d9249f6bc490d7ba1b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261852Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#782698}
-
dpapad authored
Shows a dummy (empty) new toolbar UI element when --enable-features=PDFViewerUpdate is specified. Decided to use a completely new element, since it will significantly diverge from the existing UI (sidenav button, different zoom controls + buttons, overflow menu) Bug: 1098124 Change-Id: I03db34b48d5e6d1f4aed051ff8ec10dfc7b50a09 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258966Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#782697}
-
Alex Ilin authored
The reauth dialog communicates with Gaia in background, and then in foreground. Some UI interactions are blocked until the first navigation to the Gaia reauth endpoint is completed. This CL adds two duration histograms that will help us understand delays that users may experience in the reauth dialog. Bug: 1045515 Change-Id: Ibc7ddfee24b2ff0b7c3e8f591c76dc341cd0df54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266554 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Mugdha Lakhani authored
Design doc: https://docs.google.com/document/d/166h__sHZGVD7eTBKkBMF7beLGOmT6mwTVe8dtsTCU7A/edit?usp=sharing Before change screenshot: https://drive.google.com/a/google.com/file/d/15sHXrBgFOUAT5p2gccLHfIyP5ELYRsXV/view?usp=sharing After change screnshots: https://drive.google.com/drive/folders/1UBj97q3vl5fYCFwtNUjju6Z_fJcwKIEd?usp=sharing Change-Id: Ic2f5c19562a010bbce9fbf8e313a9fe6f9181745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880994 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#782695}
-
Mila Green authored
Bug: 1020650 Change-Id: I269a3b5edf8c66f5c91dda8ddab33794b9827bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268219Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mila Green <milagreen@chromium.org> Cr-Commit-Position: refs/heads/master@{#782694}
-
Dominique Fauteux-Chapleau authored
Bug: 1098414 Change-Id: I52c4554448f932c73148b7f52ddb04cc14ba7081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268400 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Auto-Submit: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#782693}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4f404fa8beab..6f6f74587197 2020-06-25 kahinds@microsoft.com Fix DevTools.Launch.Elements marker placement If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I763d52e4a6a770992e3070e8e87e96414e7765e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268021Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782692}
-
rbpotter authored
Check that the viewer element and its shadow root are non-null, before querying for the plugin element. If either are null, follow the same behavior as currently occurs for null plugin elements (i.e. NOTREACHED() and return blink::WebElement()). Bug: 1099227 Change-Id: Icbf899b0270d359beeedde8aee7b48611d926b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266960 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ea70630494ad..6d781655d0f3 2020-06-25 cclao@google.com Update style guide for reference on container object 2020-06-25 m.maiya@samsung.com Vulkan: Handle overflow in maxCombinedUniformComponents computation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ic98434e4095fb43e0c7fb472cce8ec047e6f1552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268020Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I750b7c57385e5ecfe3f43e5191db301d6d0db492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268078Reviewed-by:
-
Sahel Sharify authored
This cl adds an UMA use counter to count the number of cases where Chrome crawls to refetch the missing icon of installed payment apps. The icon refetch logic will be removed once this count drops to zero. Bug: 1069010 Change-Id: I59260337c2743bff3c1197f2369f78f083962f14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265137 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#782688}
-
Ella Ge authored
This reverts commit 5cd3140c. Reason for revert: test failing on win7 bot https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/104437 Original change's description: > Use wheelTick in forms/resources/common-wheel-event.js > > After we finish the scroll unification, the scrolls happens mainly on > the compositor thread, and the scroll code in the main thread will be > removed. eventSender sends the scroll events to main thread, so it > would not work after the scroll unification. This CL we should replace > eventSender.mouseScrollBy with wheelTick which uses > gpuBenchmarking.smoothScrollByXY in > forms/resources/common-wheel-event.js. > > Bug: 1047176 > Change-Id: I7416727dfcfbe2d88a283907ee132c838952747e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171955 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Lan Wei <lanwei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782599} TBR=ellyjones@chromium.org,avi@chromium.org,sadrul@chromium.org,sky@chromium.org,ccameron@chromium.org,bokan@chromium.org,lanwei@chromium.org Change-Id: I5348ccf4d638c0c4be96ac111d41a6f45e772a32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1047176 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268226Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#782687}
-
Haiyang Pan authored
And change mb config for "Network Service Linux" to release_bot It does not seems right for a CI builder to use a trybot config Bug: 1099088 Change-Id: Iab1c9cb742a3ccd5334f2927b5d376064069fa3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267843Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#782686}
-
Connie Wan authored
This is very similar to crrev.com/c/2003922, but accommodating the ctrl+shift+pgup/pgdown shortcut on Linux. Bug: 1086123 Change-Id: Idb9c933a823518aae8eda92db8045cc1b6bed64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267432Reviewed-by:
-
Devlin Cronin authored
There was an integer division error in reporting one of our percentages. Fix it, and add a test to cover the case. Bug: None Change-Id: Ibc1993852644c86fdfe356862cbb8e5bc51644dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265420Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782684}
-
Alexander Surkov authored
DumpAccTree testing: add helper macroses to report failures when parsing parameters for parameterized attributes Bug: 1095619 Change-Id: Icf80cd3b96bc790150d91774a5843817751194fc AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260395 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#782683}
-
Hans Wennborg authored
This is a reland of f85481f8 Fixes since the previous commit: https://chrome-internal-review.googlesource.com/c/chrome/deps/amd/+/3133484 https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/3133487 https://chrome-internal-review.googlesource.com/c/chrome/assistant/+/3135083 https://chromium-review.googlesource.com/c/chromium/src/+/2264371 Original change's description: > [base] Stop including check.h, notreached.h, etc. in logging.h > > The CHECK, CHECK_EQ etc., and NOTREACHED macros have moved out > of logging.h into separate, much cheaper to include, headers. > > Now that the code has been updated to use the new headers, and > to not rergess on that, stop including them in logging.h. > > Bug: 1031540 > Change-Id: Idfa891b991cbca1dfef93630c0f37b1b022f99df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264413 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Hans Wennborg <hans@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781970} TBR=thakis Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: 1031540 Change-Id: Ie889e031d229745f93363c7bb2605c4f65591f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264297 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
-
John Abd-El-Malek authored
Bug: 1096670 Change-Id: I5780bd39e44b914369047bb054dc191f16a979ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264792 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
David Bertoni authored
There is code to conditionally enable the UpdateWindowShowState test. This cl moves the #ifdef block to the location of the function, rather than the beginning of the file. Change-Id: Ifae53e01f262e747f84292a32599bfd39de5eaf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268260 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#782680}
-
Natalie Chouinard authored
Additional downstream FeedbackSourceProviders were removed in https://crrev.com/i/3119108, so this now removes redundant classes and methods. Bug: 1098518 Change-Id: I4c3cedadc9538126c45a4255f20427c1452f088e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261615 Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#782679}
-
Donn Denman authored
Updates the UX for showing the in product help balloon for promoting a longpress when switching away from tap. When the user taps and we show the balloon we want to also highlight the word tapped. BUG=1096323 Change-Id: Ic048c4b5b410fb4389c60c0a5437dab3f493c45c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2266018 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#782678}
-
rajendrant authored
Infobar should be shown for users who enabled LiteMode before M85 release date. The user likely saw the old help center article (or privacy whitepaper), and does not know about https image compression. For users who enabled LiteMode after M85, infobar need not be shown. Bug: 1090843 Change-Id: I6df372d34d5e4309f66e9f7eb5f8467f6c972d74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262121 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#782677}
-
Leonard Grey authored
On Mac, this was replaced by the email share service in the share menu. It doesn't appear to have ever been hooked up on other platforms. Bug: 1098822 Change-Id: Ibb3c30c0c32d98e7c46f04e80e01c05e145b5ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264583Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Ella Ge authored
This reverts commit c858e90e. Reason for revert: compile failure on win64 bot https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/3761?blamelist=1#blamelist-tab Original change's description: > [Nearby Share] Add NearbyShareClient, NearbyShareClientImpl > > Implement an HTTP client to make calls to the OnePlatform server > defined here: > https://source.corp.google.com/piper///depot/google3/google/internal/location/nearby/sharing/v1/service.proto > > Bug: b/154863110 > Change-Id: I0a3b06d067e7f06a0fc933f2cf69aac4ca20036f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229299 > Reviewed-by: Josh Nohle <nohle@chromium.org> > Reviewed-by: James Vecore <vecore@google.com> > Commit-Queue: Curt Clemens <cclem@google.com> > Cr-Commit-Position: refs/heads/master@{#782646} TBR=nohle@chromium.org,vecore@google.com,cclem@google.com Change-Id: I55c1fd117a81bda2135a3f0dcb56ef2ee88f4524 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/154863110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268205Reviewed-by:
-
Zhongyi Shi authored
Non-functional change for measurement. Follow up changes will add functionality protected by flags. Add QuicConnectivityMonitor to track QUIC sessions that are degrading on the default network. 1.When NetworkHandle is supported, QuicStreamFactory is registered as NetworkObserver and picks up default network change with the associated NetworkHandle. Note IPAddressChange notification in this case is ignored by QuicConnectivityMonitor. Case 1: if connection migration is supported, QUIC session may use different network, the active network being used is tracked by the bound network bound by the last socket. Case 2: otherwise, QUIC session always sticks on the |default_network_| passed in upon construction. 2.When NetworkHandle is not supported, QuicStreamFactory is not registered as NetworkObserver. Default network changes are notified via IPAddressChange which is spurious though. a. Connection Migration is never supported in this case. The QUIC session will either goaway (Cronet on iOS) or killed or stay until the OSS kills the underlying socket. b. Reporting from the session is immediately disabled when IP address changes, as there is no way to track if the session stays on the default network or not. For simplicity, reporting for go_away_on_path_degrading is disabled. Bug: 1090532 Change-Id: I4649ddef72249d64b9a2faa7070efaef0c383ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247130 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#782674}
-
David Bertoni authored
ExtensionApiTabTest.TabOpener was disabled for flakiness on Windows. It passed 3000 iterations on the Windows bots with no flakes. Bug: 238667 Change-Id: I1838fe53f0c3e14c3524793610f8d5f9fbb6c422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264029Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#782673}
-
