- 22 Aug, 2019 40 commits
-
-
Rafael Cintron authored
In preparation to reuse the code in SwapChainFactoryDXGI for shared images, this CL renames classes to have more general purpose names: * SwapChainFactoryDXGI --> SharedImageBackingFactoryD3D * SharedImageBackingDXGISwapChain --> SharedImageBackingFactoryD3D * GLImageDXGISwapChain --> GLImageD3D * SwapChainFactoryDXGI --> SharedImageBackingFactoryD3D::IsSwapChainSupported * SwapChainFactoryDXGITest --> SharedImageBackingFactoryD3DTest Bug: 966580 Change-Id: Iffb511df7802a78e1ca3ceafd83fdb082b33a478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761438 Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#689332}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/78f41f5a6e33..ec4ea59c6d52 git log 78f41f5a6e33..ec4ea59c6d52 --date=short --no-merges --format='%ad %ae %s' 2019-08-22 dneto@google.com Force Glslang to support HLSL in its interface (#784) Created with: gclient setdep -r src/third_party/shaderc/src@ec4ea59c6d52 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: I55091bd304c26da0c85224b911a97850770ab0df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764892Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689331}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: Ia29bb79a54e64e504392952a82a4c67e6db36887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764400Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689330}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/c9ccac7cb734..fb49e6c16449 git log c9ccac7cb734..fb49e6c16449 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 zhangxy@google.com Merge pull request #2393 from kuzkry:custom-type-traits-remove_const 2019-08-21 absl-team@google.com Googletest export Created with: gclient setdep -r src/third_party/googletest/src@fb49e6c16449 The AutoRoll server is located here: https://autoroll.skia.org/r/googletest-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com,staphany@google.com Bug: None Change-Id: I167a094c06c4de743e7a618f700b96c59be746eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764342Reviewed-by:
Staphany Park <staphany@google.com> Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689329}
-
Donn Denman authored
Extends the CardTag histogram, which tells us what kind of card has been generated from the server and therefore characterizes the data that we'll display in the Bar. This is a very useful histogram, which we'll use for several experiments in the works. BUG=984239 Change-Id: I0aac1e7b0e22a296d6a8d8ab6efac552dd632fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752388 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#689328}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I300826b935887976b8818d7c19c331d9a57de643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764891Reviewed-by:
-
Justin Cohen authored
Increases a webState timeout, disables a request desktop and two share button tests. Bug: 995797, 996541, 990186, 996544 Change-Id: I07c8dd52d0bb13c6c805ef35b2c727ec3deb84bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762331 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689326}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe65f6d2c3d1..42c6af9182d2 git log fe65f6d2c3d1..42c6af9182d2 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@42c6af9182d2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: Ia6aa0cb33665a29a2314db77322a6a76e088bb04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764770Reviewed-by:
-
Ryan Hamilton authored
https://quiche.googlesource.com/quiche.git/+log/9a910e3deaec..0b20fdfd4bea $ git log 9a910e3de..0b20fdfd4 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 rch Add missing include of <set> to qpack_decoder.h2019-08-21 rch Use the uint64_t specialization of std::min in qpack_encoder.cc to fix Chrome build breakage where size_t != uint64_t. 2019-08-21 bnc Enforce limit on number of blocked streams in QPACK decoder. 2019-08-21 fayang gfe-relnote: Remove QUIC version 44. 2019-08-21 quiche-dev gfe-relnote: change logs about window update frames from DLOG(INFO) to DVLOG(1). 2019-08-21 fayang gfe-relnote: Deprecate gfe2_reloadable_flag_quic_fix_packets_acked. 2019-08-21 renjietang Prevent QPACK streams from being created more than once. 2019-08-21 nharper gfe-relnote: Use new flag quic_enable_version_48_2 for QUIC_VERSION_48 2019-08-21 bnc Remove two obsolete TODOs from http_decoder.cc. 2019-08-20 bnc Use dynamic table for QPACK encoding. 2019-08-20 bnc Feed header block in fragments in QPACK roundtrip fuzzer. 2019-08-20 fayang gfe-relnote: Add live check to QuicSpdySession. No functional change expected, not protected. 2019-08-20 renjietang Do not check config() when sending HTTP/3 SETTINGS frame. 2019-08-20 fayang gfe-relnote: In QUIC v48, support partial write of CRYPTO frames. Protected by existing gfe2_reloadable_flag_quic_enable_version_48. 2019-08-20 fkastenholz Add flag to QuicSession indicating that it has been configured 2019-08-19 wub gfe-relnote: Default-initialize QUIC BBRv2 loss event threshold for exiting STARTUP from a flag. Protected by --gfe2_reloadable_flag_quic_default_to_bbr_v2. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I3ec9ca8c79805a0a371c10bec36c9150332bdfe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764252 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689324}
-
Dan Beam authored
BUG=994064 TBR=pastarmovj@chromium.org Change-Id: I9d9b40fa01a39c38c4dbc9886362ebd006fa0ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756432 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#689323}
-
Makoto Shimazu authored
This CL adds a test to check if WebRequest API can observe requests for service worker scripts. There are a couple of code paths to load a service worker script: new script on registration, and updating the service worker. This tests the both. I manually confirmed this passes when disabling ServiceWorkerImportedScriptUpdateCheck, and temporarily disabled since it's enabled by default now. Let's enable the test when the fix lands. Bug: 995763, 991443 Change-Id: I230d4a5b3b7928e25c69b27b3316ab015ef3aa16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763487 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689322}
-
Ryan Hamilton authored
which takes a QUIC flag name and value as a string and sets the flag appropriately. Bug: 984738 Change-Id: If2223c084da792d25dfc94ca4ac3795c39895338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761254Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b06831a5ae4a..f8ff63e09525 Created with: gclient setdep -r src-internal@f8ff63e09525 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:991478 Change-Id: I64bfe19094ac641a78b04427e9aa1b1e94e8e864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764771Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689320}
-
Gyuyoung Kim authored
As the last step to deprecate Platform::GetDataResource(name), this CL removes Platform::GetDataResource(name) in //content and blink. Bug: 983396 Change-Id: Ibdb8b3c44a9184f031b157ed0c2bd0cf6e9ad721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761899 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#689319}
-
Nick Diego Yamane authored
Currently, MessagePumpGlib's FD watching API implementation sets FdWatch Gsource's can_recurse to false, which causes issues when nested loops are used (e.g: X11WholeScreenMoveLoop, ClipboardOzone, etc). So, switch it to true to fix that aforementioned issue. Bug: 996117 Change-Id: I41d9b37eeb1a3b9a4e9cf8cf6c675181f8a6706b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760426Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#689318}
-
Findit authored
This reverts commit 591bf020. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 689296 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU5MWJmMDIwMzI5ZTk5YjZlMDBiNTgzYjgzNmYyODlkNTBhY2FhM2QM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-archive-rel/3803 Sample Failed Step: compile Original change's description: > UI_DevTools: Backend for ui_devtools performance panel. > > The goal is to enable and create the performance tool for ui_devtools. > The performance panel will record and show metrics such as FPS, CPU time utilization > for Aura/Views UI. This CL is for the backend only. The TracingAgent is very similar > to the TracingHandler from > https://cs.chromium.org/chromium/src/content/browser/devtools/protocol/tracing_handler.cc. > > Bug: 989052 > Change-Id: Ic696e09f700e93bcd0842fdbda575ef1f54af63a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726651 > Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Dana Fried <dfried@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Leonard Grey <lgrey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689296} Change-Id: Icce706bb8f3e3451762bcea6d5611cfc863f73e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 989052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764933 Cr-Commit-Position: refs/heads/master@{#689317}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dc613c9c. With Chromium commits locally applied on WPT: 1194775a "Add ability to block same-origin access via document-access feature policy" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools msisov@igalia.com: external/wpt/webvtt rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I95beb857f3d488a0f480652ff18b9164e9c2f49a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763877Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689316}
-
Willie Koomson authored
ArcInstanceThrottle, instead of observing window changes itself, now holds a number of observers for different conditions (mojom instance connected, ARC window focused, app launched), which notify ArcInstanceThrottle of a change. AIT will then apply the appropriate throttling level to the container. Bug: b:133417350 Test: Build and flash to eve. Monitor /var/log/chrome/chrome to see throttling de/activate according to the different conditions. Change-Id: I8e90f507c6807b836bd83400f731fa33ba663e3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763041Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Willie Koomson <wvk@google.com> Cr-Commit-Position: refs/heads/master@{#689315}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4de25e8087ab..3418cf472b93 git log 4de25e8087ab..3418cf472b93 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 manojgupta@google.com afdo: Disable checks on haswell profiles. 2019-08-21 xiaohuic@chromium.org Revert "deploy_chrome: Copy libassistant_debug.so if built" 2019-08-21 gwendal@chromium.org Revert "chromeos_config: mark some loonix derivative experimental" 2019-08-21 vapier@chromium.org cros lint: rework pylint invocation after upgrade Created with: gclient setdep -r src/third_party/chromite@3418cf472b93 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2af6f275f3bf5bdeaab0027893666f37a4e3d73a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763437Reviewed-by:
-
sczs authored
Also adds folderPickerDidDismiss to BookmarkFolderViewControllerDelegate so the VC that pushed the Folder picker can clean up presentation when they're dismissed. Bug: 979201 Change-Id: Ie22e9026dfbcbe56d3f2fa771e047eff380542ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762864Reviewed-by:
-
Meredith Lane authored
A crash was occurring in the following snippet: .elem::before { content: / "alt"; } This has now been fixed at the parsing level, as this is considered invalid syntax according to the content property spec: https://drafts.csswg.org/css-content/#content-property BUG=995891 Change-Id: If34e986ef54a8a3b7e35212894f33b00e1b71351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762251 Commit-Queue: Meredith Lane <meredithl@chromium.org> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#689312}
-
Joey Arhar authored
Screenshots: https://imgur.com/a/7rqmXSI Bug: 996208 Change-Id: Id2beed57157772d28c98d87c6a88dfb88eca2d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764126Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#689311}
-
Alexey Baskakov authored
Extract common test fixture with data. Extract common utils to test fixture. Bug: 891172 Change-Id: I59153af17b71892a2e4b3cc862e3d73141f246d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763557Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#689310}
-
Clark DuVall authored
Bug: 995711 Change-Id: If4f55e5b137b9ee8084823718f73ca791d7a5152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764870Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#689309}
-
Rachel Wong authored
Bug: 959679 Change-Id: I8af10949fc1c10f08d18eb3c13eb787d121622ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763559 Commit-Queue: Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#689308}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new Mojo types in //third_party/blink/renderer/modules/offscreencanvas and related classes. This cl replaces mojo::Binding with mojo::Receiver mainly. Bug: 955171 Change-Id: If813b64079bf7d1b33e796dcda128cc283e74a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761893Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#689307}
-
Rakina Zata Amni authored
DL: Create AXNodeObject instead of AXLayoutObjects for activatable locked trees & ignore non-activatable When creating AXObjects for nodes in locked subtrees, we will create AXNodeObjects instead of AXLayoutObjects, even if the nodes in the locked subtree actually have layout objects. This CL also makes us ignore non-activatable locked subtrees for accessibility - they will no longer be part of the AX tree. Bug: 972506 Change-Id: I3ec340503f7137b0b198c2b82904cb19754779ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688771Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Noel Gordon authored
This reverts commit 19e338fb. Reason for revert: FindIt suspect this change at 88% as having caused failure on Mac ASAN 64. https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/55957 Original change's description: > Dispatch scroll end event immediately when a fling isn't going to happen > > This issue was found while working on the fix in this[1] CL. > > Prior to this CL, when transitioning from scrolling to anything, a scroll > end event was scheduled, but not immediately dispatched. This is so that > if the scroll is going to be followed by a momentum scroll (fling), the > scroll end event wouldn't be sent. However, momentum scrolling doesn't > always occur after a scroll, and because of an issue with Direct > Manipulation, sometimes a scroll begin then end event would be sent when > the user is actually doing a pinch zoom. In this case, we know that we > can immediately dispatch the end event rather than scheduling it. > > Now with this change, if we are transitioning from a scroll to a pinch, > the momentum_phase of an event is set to Blocked, signalling that a > momentum scroll will not happen. We then immediately dispatch the end > event without waiting. > > [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1725349 > > Bug: 908758 > Change-Id: If89fea60a396ff10b54d56b986052c704eabb0b2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708994 > Commit-Queue: Mario Bianucci <mabian@microsoft.com> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#689142} TBR=sadrul@chromium.org,sky@chromium.org,dcheng@chromium.org,bokan@chromium.org,mabian@microsoft.com Change-Id: Id62346a383a050ec8ff6af0abed96d7388a1eecb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 908758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763515Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#689305}
-
Ryan Hamilton authored
QuicStreamFrame objects are no longer passed by reference into QuicFrame object, but are copied instead. This means that the QuicStreamFrame does not need to outlive the QuicFrame. Thus we can avoid storing QuicStreamFrames on the stack just so they can outlive the associated QuicFrame. As a result GenerateNextStreamFrames and GenerateNextStreamFrame can return QuicFrames instead of QuicStreamFrames. Change-Id: I9c968392ab44d78967f77db515adf2f743580cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764102 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
David Grogan authored
Force the cross size on stretchy items when they are laid out for flex base sizing or cross size determination. Bug: 845235 Change-Id: I49c6b9a9ef1d2e86aa02c47841075ed2726d5619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762816 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#689303}
-
Kenichi Ishibashi authored
EmbeddedWorkerInstanceClient::AddMessageToConsole() was used for following cases: 1. Show error message when service worker script fetch is failed (ServiceWorkerUpdatedScriptLoader and ServiceWorkerNewScriptLoader) 2. Notify when service worker is forcibly updated on reload (ServiceWorkerVersion::ReportForceUpdateToDevTools()) However, after crrev.com/c/1748972 the method was no-op. As an alternative, this CL moves the method to ServiceWorker mojom interface. The interface is implemented by ServiceWorkerGlobalScope and it can directly add messages to the attached DevTools console. Bug: 538751 Change-Id: Ib6a4304e8c9f48380a805a9e2a4e16ee7d3ff361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760832 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#689302}
-
Joe DeBlasio authored
This CL prevents the Safety Tip bubble or infobar from activating when a page is loaded in the background by adding a visibility check before displaying and checking safety tip status when a tab becomes newly visible. This results in potentially checking the reputation of a page multiple times, but doing so is inexpensive at present. If future checks are heavier, we may need to cache reputation results. This CL also changes behavior of the escape key, which is now treated as equivalent to other ways to close the bubble. Bug: 994410 Change-Id: I27c4bb6839afb6e9e5188665aa89cd30437c75cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761221 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#689301}
-
Adam Langley authored
The logic around this has changed from CTAP 2.0 to the current draft of 2.1 and is likely to change further[1]. There's a good argument to be made based on CTAP 2.0 (but not the 2.1 draft) that it's ok to send numberOfCredentials even for a non-empty allow list case so we shouldn't depend on that. Instead, have AuthenticatorCommon just remember whether the allow list was empty or not. Then, in the empty case, show a picker if we can. If there are multiple options then we have to show a picker. If there's only a single option but we have identifying information, show a picker to let the user confirm which account they wish to use. In the future, if there's an explicit userSelected signal in CTAP2 then we'll suppress the picker when that's asserted. [1] https://github.com/fido-alliance/fido-2-specs/pull/717 Change-Id: I1060c94258428adfdc14f6999b1e07bde93456fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762942 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#689300}
-
Andres Calderon Jaramillo authored
This CL adds the GL_COMMANDS_ISSUED_TIMESTAMP_CHROMIUM query type to the raster and GLES2 command buffers. A client can use this query to get the timestamp at which preceding commands have been issued to the driver. The use case is in the follow-up CL: we want to measure the wall time it takes for a raster task created in the renderer to start being issued to the driver in the GPU process. This essentially makes sure that there are no regressions between these events: this is useful to make sure that the way we process hardware accelerated image decodes does not cause raster work to systematically start later than with software image decodes. This query is similar to the GL_TIMESTAMP query (see the ARB_timer_query specification). The main differences are: 1) The QueryCounter() behavior of GL_TIMESTAMP is asynchronous, but it is undesired because it gives us the timestamp when all preceding commands have been fully realized: we don't care about commands being completed; we only care that they've been issued to the driver. 2) The GetIntegerv()/GetInteger64v() behavior of GL_TIMESTAMP is undesired because it is synchronous. Bug: 995155 Test: Updated relevant unit tests. Change-Id: Ibc52b2c530151d2fe0740180a8f643d992ee8b5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753206 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#689299}
-
Ian Struiksma authored
Updated recipes and some archives to take advantage of new actions and other fixes for the autofill framework. Notes inline in the testcases.json file. Most issues were timing and autofill cache related Updated DEPS with new cipd version for autofill captured sites Change-Id: I4bb9250902ac91835bbc4a2cb3ac8cb25548a81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755542 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#689298}
-
Steven Bennetts authored
This CL: * Adds SetProperties to CrosNetworkConfig with a test * Implements AutoConnect and Priority in the internet detail page using CrosNetworkConfig.SetProperties. Bug: 853953 Change-Id: I7e0f4be921e8ba8aebb4413a449c4ff54e2a0bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756852Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#689297}
-
Andrew Lee authored
The goal is to enable and create the performance tool for ui_devtools. The performance panel will record and show metrics such as FPS, CPU time utilization for Aura/Views UI. This CL is for the backend only. The TracingAgent is very similar to the TracingHandler from https://cs.chromium.org/chromium/src/content/browser/devtools/protocol/tracing_handler.cc. Bug: 989052 Change-Id: Ic696e09f700e93bcd0842fdbda575ef1f54af63a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726651 Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#689296}
-
Kenichi Ishibashi authored
Otherwise MSan complains we use uninitialized memory. Bug: N/A Tbr: afakhry@chromium.org Change-Id: I5ee9e0e5e9ae8e5c010701b403d22f0058b3abad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763513Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689295}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a1b7d649aa4c..679dc3716bdb git log a1b7d649aa4c..679dc3716bdb --date=short --no-merges --format='%ad %ae %s' 2019-08-21 simonhatch@chromium.org Pinpoint - Wait to issue iron-ajax calls until route is queue-stats 2019-08-21 bsheedy@chromium.org Support minidump symbolization on ChromeOS Created with: gclient setdep -r src/third_party/catapult@679dc3716bdb The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Bug: chromium:996319,chromium:978952 Change-Id: Ibe7bf12f521a6eaa871c067b1287ea38a531f3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764347Reviewed-by:
-
Becca Hughes authored
Adds two histograms for the lock screen media controls. The first is records whether the controls were shown and if they will never be shown the reason why. The second records the reason if they were shown the reason why they were hidden. BUG=995373 Change-Id: Ic1448098912a79ebf6a2dad9e346c8fe3771eb01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761069 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689293}
-
