- 18 Aug, 2020 40 commits
-
-
Fred Mello authored
https://docs.google.com/document/d/1F7tSDDHEFzASIViYpf4J5weDpsmTuq7AKvLJ55lgs4s Bug: 1112872 Change-Id: Id73b41d34c098a3452a60f60c8600798f6e630a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359585 Commit-Queue: Fred Mello <fredmello@chromium.org> Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799115}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1756465158d3..b6a272ffee65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7de88f9f1864fe7aeaedf45a758424a5222db5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799114}
-
Alex Ilin authored
Gaia Reauth page doesn't support dark mode. The reauth confirmation dialog is shown right before the Gaia Reauth. The transition between the two dialogs looks weird if one of them is dark and another one is light. The reauth confirmation dialog should also be displayed in light mode until Gaia Reauth supports dark mode. Bug: 1115930 Change-Id: I535b62e6a8782406bb30ac7521060468f7e7afc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362928 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#799113}
-
Rune Lillesveen authored
Test is occasionally flaky (timeout) on multiple platforms. Copied OWNERS from wpt/css. Bug: 1093478 Change-Id: Ie83aa61a9caa65f51bb81e01e1a74d28ddd2db69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362728Reviewed-by:
Rob Buis <rbuis@igalia.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#799112}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1756465158d3..b6a272ffee65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia9b3534ab57392b8719c43d7b5509726d6573010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362708Reviewed-by:
-
Alice Wang authored
This CL changes the argument of AccountPickerDelegate.signIn() from account email string to CoreAccountInfo object. Bug: 1093741 Change-Id: I296674da6757962c21c2956075e94d97de542525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351977 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#799110}
-
David Roger authored
This CL changes new profiles created by signin interception to use the generic avatar instead of a random avatar. Bug: 1076880 Change-Id: I54a9481db74e9672250e1e4c3436fb723be130de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353338 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#799109}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7ab30019695731649113bd0f1b4aa5014e5b9f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363053Reviewed-by:
-
Chris Sharp authored
TBR=arthursonzogni@chromium.org Bug: 1116023 Change-Id: Ifc002bbc19f771ca2370f2d7049992cb7b2d861a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362308Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#799107}
-
Adam Langley authored
This change allows the caller of |CreateWebSocket| to pass in the traffic annotation tag. This follows the pattern of other interfaces in network_context.mojom such as |CreateTCPConnectedSocket|. Change-Id: I3a8654c5a290a69d5e627450efed61fb9d36ed53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357669Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#799106}
-
Reda Tawfik authored
1. Creates Java bridge |AllPasswordsBottomSheetBridge| and data class |Credentials|. 2. Initializes |AllPasswordsBottomSheetController| with passed |web_contents|, PasswordStore and |dismissal_callback| (called when the user dismisses the sheet) from |PasswordAccessoryControllerImpl|. 3. Creates native view interface |AllPasswordsBottomSheetView| which is implemented in |AllPasswordsBottomSheetViewImpl|. 4. Implements |GetOrCreateJavaObject| method which initializes or returns Java bridge object. 5. Implements filling logic in |OnCredentialSelected| method. 6. Adds unittest for AllPasswordsBottomSheetController. Bug: 1104132 Change-Id: I28408f0302627f3fb4d87d631d9f33f2662d5a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309694 Commit-Queue: Reda Tawfik <redatawfik@noogler.google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#799105}
-
Owen Min authored
The secure connect extension API should not show any user confirmation dialog as it's admin's responsibility to confirm it ahead of time. Disable the dialog temporarily when quering the password from Keychain. Bug: 1077078 Change-Id: I6c3426e2cd58149fa4ef74cb1a8f7c8eaab5556f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358905Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#799104}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0dca23916904..6b30e90492c5 2020-08-18 jleconte@google.com Revert "Chrome Perf Dashboard UI links to Monorail bugs are missing project id." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1101773 Tbr: rmhasan@google.com Change-Id: I0e49407d3b002c9251ebc8b66e54659e97be2063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361787Reviewed-by:
-
Tamir Duberstein authored
Fixed: 1099393 Change-Id: I15d48675a9824f54542f70a5eb03c429443c88f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358210 Commit-Queue: Tamir Duberstein <tamird@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#799102}
-
Hirokazu Honda authored
Bug: 1030199 Test: vp9_encoder_unittest Change-Id: Id6cc6779c6632d778e8ef664c66a440252358520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359973 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#799101}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8150670ddd8d..0d421b6025ff 2020-08-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 99638d8d7fc6 to 834673eaa34a (1 revision) 2020-08-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from 758b30727efc to f257e0ea6b9a (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: Ib414def2857bdcf1603c8d8e5b5f7696c4b52b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361869Reviewed-by:
-
Maks Orlovich authored
Fixed: 1037125 Change-Id: Id68245046250dd1263ea2e57f6c9dc000e20c5ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359574Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#799099}
-
Andy Paicu authored
The flag has been enabled by default since M71 and the feature has been well received by other browers as well as the community. Bug: 1090670 Change-Id: Ia1e93bae53932b0b6e16b979612afe702c458657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315016 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#799098}
-
Charlie Hu authored
Bug: 1113375 Change-Id: I195fafec5b957750b295cf8fa0a954532599c196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333497Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#799097}
-
Himanshu Jaju authored
- Checks if incoming files are store-able in the Downloads section - Adds a test to get Fail incoming connection due to storage crunch - PRD for decision on storing in Downloads (go/cros-nearby) Bug: 1085068 Change-Id: Ibee41fce67d0da5b904112b4b9970215ae874b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336033 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#799096}
-
Andrew Grieve authored
Adds a secondary ninja pool for R8 / lint for machines with not much RAM. For machines with more ram, R8 / lint continue to use the same pool as links. Speed up compiles on android-binary-size by ~90 seconds. Example: A bot has 18GB of RAM, and it takes 10GB to link: * concurrent_links = 1, with 8GB leftover * So add an java_cmd_pool of size 8/2 = 4. A bot has 22GB of RAM, and it takes 10GB to link: * concurrent_links = 2, with 2GB leftover * A secondary pool would be of size=1, so in this case have java commands use the link_pool directly so that size=2 rather than size=1. Bug: 1078460 Change-Id: I7e4ecfeb04d1c215b2ff27b6a0c438c0e8e3dd88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347960 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#799095}
-
Etienne Pierre-doray authored
GetMaxConcurrency() is given the active worker_count. The main thread shouldn't be counted when it returns, otherwise causing infinite job. Bug: 1114823 Change-Id: I4954559992a8e17a92dbbbc9e3bce152563d1235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355297Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#799094}
-
Fred Mello authored
https://docs.google.com/document/d/11syJ3z5uLOE07ctP_17Mqfuzq_-Gb7PvoVvsjUdIDFQ Bug: 1112872 Change-Id: Iba9af88e2c7ca28321ae32b8a60735097943e874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360696 Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
-
Guido Urdaneta authored
This reverts commit eb0887d9. Reason for revert: Speculative revert. Will see if it fixes some persistent video failures on Windows. Will reland if the revert doesn't work. Example failed bot: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29/106480 Original change's description: > [media/gpu/vaapi/test] Add Vp9Decoder. > > Add basic VP9 decoding for an IVF video stream, with > functionality to save the last decoded frame as PNG. > > BUG=crbug:1062407 > > Change-Id: I0e9272a50e269af658a9427e8b01548443dd467d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296872 > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798886} TBR=mcasas@chromium.org,jchinlee@chromium.org,andrescj@chromium.org Change-Id: Id80ba32e2a73aa83dde3bda453fc02e0ddd7d25b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: crbug:1062407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362851Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#799092}
-
Jan Krcal authored
This CL makes sure that the profile picker window fits on the current screen. Moreover, it forces the window to be somewhat smaller then the current screen so that it still looks like a dialog window. Bug: 773501 Change-Id: If5fef1920387c6fd421c3b7257426e6bacd6fdad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362887 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
-
Sam Maier authored
This is a reland of a0c9fe7f I fixed the dependency checker issue it was causing by disabling it for this new target. Original change's description: > Adding androidx.window to android_deps > > Also fixes warning in android_deps where buildCompile or test targets were > triggering vulnerability errors when they aren't shipped. > > androidx.window is being added to implement Web APIs related to dual screen > and foldable devices. See: > https://groups.google.com/a/chromium.org/g/blink-dev/c/_1_ljYsaqrU/m/qOoHJ7MhAgAJ > > TBR: OWNERS check broken for new android_deps OWNERS file > Change-Id: I350a1f464be2ecb0111004c89aaa87477c7e7e96 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354599 > Commit-Queue: Sam Maier <smaier@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Auto-Submit: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798709} Change-Id: Ibdc2a03727c2234267a237d1c697eb5e4f410a27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360225Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597708766-1039a8f039b278bc6845dae261350aff5bb3b369.profdata to chrome-mac-master-1597751915-4ae12f45519e9d683fdf6edd45cc3e8b84e80d22.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I93436ab5670d4af124d253d882513710b7a81c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362709Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8cf23871. With Chromium commits locally applied on WPT: 5599375e "[WPT] Only load *.mojom.js through loadMojoResources" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: dgrogan@chromium.org: external/wpt/css/css-tables NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: Icc5517f1a6b687566c5f2eb0b277205049552096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362767Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799088}
-
Rohit Rao authored
This reverts commit c0c1dee7. Reason for revert: Continues to crash on iOS 12.4 iPhone X when built with the iOS 14 SDK. Original change's description: > [iOS] Reenable PassKitEGTest/testPassKitDownload > > The test was disabled due to flakiness, but it looks fine on try bots. > > Bug: 1109131 > Change-Id: I9f113a468e5b415344b70510918ef07e791bfd75 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354947 > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798285} TBR=eugenebut@chromium.org,zhaoyangli@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1109131 Change-Id: I3adf02d233cbf055858ca6dd37fe8c0bef697903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361845Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#799087}
-
Taras Antoshchuk authored
SupervisionTransitionScreenHandler::profile_ field was initialized in ::Initialize method. By the time profile_ was used in ::Show, current active profile was already changed, causing screen handler to interact with wrong profile. This CL moves initialization of profile_ field, to ensure that screen handler interacts with actual current active profile. Bug: 1105127 Test: manual gellerization/degellerization flow Change-Id: Ib2563d3fd7d0910e1b11c3a4962905601950a07e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356424Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Taras Antoshchuk <tantoshchuk@google.com> Cr-Commit-Position: refs/heads/master@{#799086}
-
Hirokazu Honda authored
Bug: 1045825 Test: video_encode_accelerator_tests Change-Id: I094d75a21c0d75fe9adb079ec2d31f1179d89edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359853 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#799085}
-
Sigurd Schneider authored
Design doc: http://doc/1ZwBd-j5fEJhSNz3Nry-L7qV4TyOO1erHYRXQ9Cax7mo#heading=h.7nki9mck5t64 Bug: chromium:1051466 Change-Id: I27089c294642178102401696b6154aa731eed69f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351992 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#799084}
-
Takashi Toyoshima authored
CorsMitigationList and CorsLegacyModeEnabled policies are hidden by default from m84, but still alive in the code behind field trial flags just in case. Now that we ensure that these policies are not needed any more, this patch removes the flags and enterprise policies support completely. Bug: 1053866 Change-Id: Ia4662949d27bb0c9f303fdf8b95973693d1d8ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360053 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#799083}
-
Fred Mello authored
https://docs.google.com/document/d/1A0VNbt6MMhJUCxHFgigPGoSqvR_ifRi8TeMcoYm2ZwE Bug: 1112872 Change-Id: I682971f80c3f3f9877f96aa8c8d3c08bfa56f2e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360236Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#799082}
-
Side Yilmaz authored
This CL replaces deprecated |createImageFetcher| function by using newer one passing profile.|setProfile| function is triggered on start of application and anytime when profile changes. Therefore, when tab model selector change from regular to incognito mode (or vice versa), |setProfile| is triggered and creates a new image fetcher with the current profile, instead of using always regular profile as today. Bug: 1041781, 1083923, 1075562 Change-Id: If5ed73b133457ca430e9caed9ddf278a3c6c75ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302851Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799081}
-
Robert Ma authored
With https://github.com/web-platform-tests/rfcs/pull/28, we can now use assert_* freely in any (including the first) test function without worrying about turning the test into a single-page test accidentally. This CL takes advantage of that and makes better use of assert_implements to convey failure messages. Change-Id: I328fdbb31195b02e3f97e16cc9f1f1cacbe03f7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359163 Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#799080}
-
Michael Tang authored
Change-Id: I94d7526807c7204ef13f0ad42a5c95499211c926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334005 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#799079}
-
Guido Urdaneta authored
This reverts commit f97ca58f. Reason for revert: While the bot got green, the revert did not seem to be the cause. Reverting to confirm. Original change's description: > Revert "Reland "RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive"" > > This reverts commit 49422e89. > > Reason for revert: Speculative revert. > Suspect of causing some failures that report Gpu issues with Wayland. > https://ci.chromium.org/p/chromium/builders/ci/linux-lacros-tester-rel/1109 > Will reland if the revert does not fix the bot. > > Original change's description: > > Reland "RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive" > > > > This is a reland of 02aec841 > > > > Speculative revert was incorrect > > > > Original change's description: > > > RELAND 2: media/gpu/vaapi_video_decoder: keep allocated VASurfaces alive > > > > > > The relanded CL was reverted due to crashes when used from ARC++: > > > Video Frames coming from this path are not GpuMemoryBuffers, so there's > > > a DCHECK not verified, and then a crash. This CL addresses that > > > situation, fixing `video_decode_accelerator_tests --use_vd_vda`: > > > see crrev.com/c/2359734/1..3. > > > > > > Bug: b:163920993 > > > > > > Original RELAND description ------------------------------------------- > > > > > > The original CL was reverted due to crashes in betty initialization: > > > betty is a VM which doesn't support VA, so the VideoDecoderPipeline > > > constructed-destructed a VaapiVideoDecoder, hitting an unprotected > > > nullptr |vaapi_wrapper_| in dtor. Fix in crrev.com/c/2339494/2..3. > > > > > > TBR=andrescj@chromium.org > > > > > > Original CL description ----------------------------------------------- > > > > > > Certain platforms and codecs suffer from horrible artifacts (Intel BYT, > > > H264) or crashes (Intel BSW/BDW, VP9). This was traced to some kind of > > > error in the tracking of the VASurfaces lifetime in the driver: every > > > time we get a new resource from the pool to decode onto, this is > > > imported into libva as a VASurface: this works fine almost everywhere > > > but doesn't play well in these old platforms (see CreateSurface() body). > > > > > > This CL adds a map that keeps the ref-counted VASurfaces alive and > > > indexed by the unique GpuMemoryBufferId until the VA Context is > > > destroyed. In so doing, we're basically observing the "contract" of > > > va.h vaDestroySurfaces() [1] "Surfaces can only be destroyed after all > > > contexts using these surfaces have been destroyed". > > > > > > [1] https://github.com/intel/libva/blob/libva-2.0.0/va/va.h#L1134 > > > > > > Bug: b:142019786 b:143323596 > > > Change-Id: I16e74eb2b483b892961eca27aed30112240aa8ba > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339494 > > > Reviewed-by: Miguel Casas <mcasas@chromium.org> > > > Commit-Queue: Miguel Casas <mcasas@chromium.org> > > > Cr-Original-Commit-Position: refs/heads/master@{#795026} > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359734 > > > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > > > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > > > Auto-Submit: Miguel Casas <mcasas@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#798931} > > > > TBR=mcasas@chromium.org,andrescj@chromium.org > > > > Bug: b:163920993 > > Bug: b:142019786 b:143323596 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Change-Id: I6124e960d93f6985dbf9a546bc9d34372815e002 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359975 > > Reviewed-by: Fergus Dall <sidereal@google.com> > > Commit-Queue: Fergus Dall <sidereal@google.com> > > Cr-Commit-Position: refs/heads/master@{#798968} > > TBR=mcasas@chromium.org,andrescj@chromium.org,sidereal@google.com > > Change-Id: I5a6c92e18abcfd4d16f67942fa882fdb6cbe4001 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: b:163920993 > Bug: b:142019786 b:143323596 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362247 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799038} TBR=mcasas@chromium.org,guidou@chromium.org,andrescj@chromium.org,sidereal@google.com # Not skipping CQ checks because this is a reland. Bug: b:163920993 Bug: b:142019786 b:143323596 Change-Id: I17db054c9f09739a3b9486b53bad3bec42af40ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362747Reviewed-by:
-
Batalov Vladislav authored
There is a moment between requesting manifest and providing the answer when destroying (detaching) of execution context leds to crash. E.g. without waiting for the promise to be triggered, detach the frame by navigating to a different URL. Change-Id: I6cfcfc26daac62d76aa0323f68d315315799a67e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358739Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799077}
-
Chris Sharp authored
This reverts commit 5db0bd08. Reason for revert: Test is failing on Mac10.14 Tests Original change's description: > [system_health] add infinite scrolling for Twitter using performance.mark metrics > > R=johnchen@chromium.org > CC=cbruni@chromium.org,jdecaires@twitter.com > > Bug: 1114635 > Change-Id: I8d569776bd0f6fdbb656d70172f70c6f08ca3cbe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352939 > Auto-Submit: Tamer Tas <tmrts@chromium.org> > Commit-Queue: Tamer Tas <tmrts@google.com> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799056} TBR=johnchen@chromium.org,tmrts@chromium.org,tmrts@google.com Change-Id: I15f87c0a0374759a7d12b61415f38c11df60a537 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1114635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363067Reviewed-by:
-
