- 18 Jul, 2018 40 commits
-
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/941ac6857d71..26d6aff1b57b git log 941ac6857d71..26d6aff1b57b --date=short --no-merges --format='%ad %ae %s' 2018-07-18 dtu@chromium.org [pinpoint] Add `android-pixel2-perf` config. 2018-07-18 nednguyen@google.com Remove stray debug print in page_test_results.py Created with: gclient setdep -r src/third_party/catapult@26d6aff1b57b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860091 TBR=sullivan@chromium.org Change-Id: I3c3c08e18bde2a25e9565965cea0a9e4bac8e734 Reviewed-on: https://chromium-review.googlesource.com/1142012Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576258}
-
Joshua Peraza authored
CrashDumpObserver is used to observe information about child process exits, including non-crashes, so ChildExitObserver more accurately reflects what this class does. Also move ChildExitObserver and ChildProcessCrashObserver to the crash_reporter namespace as part of the move away from breakpad. TBR=sanfin@chromium.org Bug: crashpad:30 Change-Id: Ib480af7fbf800afd63beccee90bbee01f9ec7610 Reviewed-on: https://chromium-review.googlesource.com/1138727 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#576257}
-
Alexander Alekseev authored
Offline Gaia did not have dedicated API, so it crashed when trying to sign-in as non-existing user. This CL adds a dedicated API which displays error message to user. Bug: 863847 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8354a88befb7cb99a64519c3f3d07449ead8fc4d Reviewed-on: https://chromium-review.googlesource.com/1141654 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#576256}
-
Trent Apted authored
Since AppKit coordinates are flipped, NSWindowDelegate may not send move changes when the top-left corner of the window moves relative to the screen. Similarly, it will send a move when resizing a window vertically via the bottom edge, which other platforms do not class as a move. To fix, track the top-left window corner relative to the top-left of the screen and ensure the toolkit is notified when it changes. OnWidgetMove() had no test coverage, so add a cross-platform widget test. The test exposes a discrepancy on Windows only, which is likely a bug to investigate in a follow-up. Bug: 862217, 864938 Change-Id: I1fb0a6c2b463ea7cbd823fbe4d65545991564d50 Reviewed-on: https://chromium-review.googlesource.com/1141555Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#576255}
-
Johann authored
https://aomedia.googlesource.com/aom.git/+log/000f2f686d60..369ab2088d3f $ git log 000f2f686..369ab2088 --date=short --no-merges --format='%ad %ae %s' 2018-07-17 johannkoenig cmake: fix formatting typo 2018-06-20 yuec Enable rdmult tuning for deltaq mode 2018-07-13 jonathan.matthews lightfield_tile_list decoder: allow obu format 2018-06-08 birkbeck Add denoiser & noise estimation in the encoder. 2018-07-17 yunqingwang Output the error message for unsupported options 2018-07-18 ravi.chaudhary Modify encoder multi-threading unit tests 2018-07-12 ddvfinite Opt convolve avx2 2018-07-17 yunqingwang Set the default number of encoder threads to 1 2018-07-13 vigneshv obu: align the reader before reading tile group 2018-06-29 grant.hsu Merge drl modes search into function handle_inter_mode 2018-07-17 grant.hsu Skip redundant compound search 2018-06-28 urvang Transform stats: Add rdmult and rdcost. 2018-07-17 urvang Add ML model for RDCost of transform block. 2018-07-17 wtc Allow the bit reader to read only obu_size bytes. 2018-07-16 ravi.chaudhary Initialize skip flag in reset_partition 2018-07-17 ravi.chaudhary Fix in initializing mi pointer grid at frame level 2018-07-17 binpengsmail Fix error reported by valgrind 2018-07-17 wtc Do not set error_code after aom_internal_error. 2018-07-11 urvang Improve BDRate and encode speed at cpu-used >= 2 2018-07-16 deepa.kg Refine the decode job dispatch logic (...) Created with: roll-dep src/third_party/libaom/source/libaom Change-Id: I1a5e87e678dca59544ada55b1755cbf0cde3deb5 Reviewed-on: https://chromium-review.googlesource.com/1142391Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#576254}
-
Peter Mayo authored
This flag specifically improves the results of layout test compositing/masks/mask-with-added-filters.html Bug: 865039 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8589dacff3c77b42931e58bc3d39c0360f93aa9e Reviewed-on: https://chromium-review.googlesource.com/1142237 Commit-Queue: Peter Mayo <petermayo@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576253}
-
Justin Donnelly authored
This eliminates the need for special layout in the > 1 display scale case. Bug: 853355 Change-Id: I5c4a30cee3b8ad05bed1bad094678351ec728ea5 Reviewed-on: https://chromium-review.googlesource.com/1142440 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#576252}
-
David Black authored
Was previously circumvented for development purposes. Bug: b:79120852 Change-Id: I68cf1fea763dd84ab886cf7e3e5df7cadfe616a5 Reviewed-on: https://chromium-review.googlesource.com/1142288Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#576251}
-
Sammie Quon authored
This reverts commit f00acd85. Reason for revert: crbug.com/863795 Original change's description: > Reland "overview: Hide title bars before animating into overview mode." > > This is a reland of a663e7fd > > The original cl causes some flaky tests with stack trace: > > [16202:16202:0709/211202.910243:FATAL:single_thread_proxy.cc(237)] Check failed: task_runner_provider_->IsMainThread(). > #0 0x7f9b36f8672d base::debug::StackTrace::StackTrace() > #1 0x7f9b36c9d3fc base::debug::StackTrace::StackTrace() > #2 0x7f9b36d06dfd logging::LogMessage::~LogMessage() > #3 0x7f9b2b5692e8 cc::SingleThreadProxy::SetNeedsCommit() > #4 0x7f9b2b45ecef cc::LayerTreeHost::SetNeedsCommit() > #5 0x7f9b2b467426 cc::LayerTreeHost::SetMutatorsNeedCommit() > #6 0x7f9b0fd29981 cc::AnimationHost::SetNeedsCommit() > #7 0x7f9b0fd1962d cc::Animation::SetNeedsCommit() > #8 0x7f9b0fd41151 cc::KeyframeEffect::KeyframeModelAdded() > #9 0x7f9b0fd44e6c cc::KeyframeEffect::AddKeyframeModel() > #10 0x7f9b0fd17fbc cc::Animation::AddKeyframeModelForKeyframeEffect() > #11 0x7f9b0fd71a6d cc::SingleKeyframeEffectAnimation::AddKeyframeModel() > #12 0x7f9b28c83a95 ui::LayerAnimator::AddThreadedAnimation() > #13 0x7f9b28c7498e ui::(anonymous namespace)::ThreadedLayerAnimationElement::RequestEffectiveStart() > #14 0x7f9b28c71113 ui::LayerAnimationElement::Start() > #15 0x7f9b28c7cbe3 ui::LayerAnimationSequence::Start() > #16 0x7f9b28c84287 ui::LayerAnimator::StartSequenceImmediately() > #17 0x7f9b28c81251 ui::LayerAnimator::StartAnimation() > #18 0x7f9b28c80eb6 ui::LayerAnimator::SetTransform() > #19 0x7f9b28c6122e ui::Layer::SetTransform() > #20 0x7f9b28ded831 aura::Window::SetTransform() > #21 0x7f9b22b732df ash::ScopedTransformOverviewWindow::SetTransform() > #22 0x7f9b22b73f69 ash::ScopedTransformOverviewWindow::OnCompositingStarted() > #23 0x7f9b28c4d734 ui::Compositor::DidSubmitCompositorFrame() > #24 0x7f9b2b56cd05 cc::SingleThreadProxy::DoComposite() > #25 0x7f9b2b56e835 cc::SingleThreadProxy::ScheduledActionDrawIfPossible() > #26 0x7f9b2b3736fd cc::Scheduler::DrawIfPossible() > #27 0x7f9b2b36dbdc cc::Scheduler::ProcessScheduledActions() > #28 0x7f9b2b36d5fd cc::Scheduler::OnBeginImplFrameDeadline() > > This cl makes that test skip waiting for composit when entering overview, like the tests > in ash. > > Original change's description: > > overview: Hide title bars before animating into overview mode. > > > > The title bars should not visible while animating overview mode. This cl > > hides the title bar if needed and waits until the next paint before > > animating the windows. This will hide the title bar as expected while > > keeping the benefits of DeferPaint. > > > > Test: manual > > Bug: 843851 > > Change-Id: I99cf7ca39fd1ae14314ac406abd0fec999e2c024 > > Reviewed-on: https://chromium-review.googlesource.com/1112774 > > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > > Reviewed-by: Tao Wu <wutao@chromium.org> > > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#573552} > > TBR=oshima@chromium.org > > Bug: 843851 > Change-Id: I3a538250d5f6d42d6c73e218445080af533b54dc > Reviewed-on: https://chromium-review.googlesource.com/1131874 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574209} TBR=msw@chromium.org,oshima@chromium.org,sammiequon@chromium.org,wutao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 843851 Change-Id: Ib2744c7f677be40004b70a714cebe0a337f7c60b Reviewed-on: https://chromium-review.googlesource.com/1142304Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#576250}
-
Dominic Mazzoni authored
Whenever we post a change to the accessibility tree affecting an element, if that element isn't block-level we should walk up to the nearest block-level element and serialize the whole thing. The reason is that we have fields like nextOnLine and previousOnLine that depend on the line layout, which can change when changes happen to inline elements. Eventually I'd like to have a better concept of marking part of the accessibility tree "dirty" as a way of cleaning up this logic, but in the meantime this is hopefully a good fix with a test that can potentially help fix some real bugs now. Bug: 843746, 651614 Change-Id: I411a13c63b0c88ab225393b5287cb87a5887565b Reviewed-on: https://chromium-review.googlesource.com/1062661Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#576249}
-
Weidong Guo authored
1. Set a mask layer to create a rounded rect background. 2. Change the corner radius based on app list height. Specs: https://screenshot.googleplex.com/xVbKhQhE9xf Bug: 860822 Change-Id: I3db9f1ebb29978b1dd0804afbb8accf253db2751 Reviewed-on: https://chromium-review.googlesource.com/1138636Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#576248}
-
Boris Sazonov authored
This CL adds ConsentBumpFragment and the corresponding layout file. The fragment will be wired up in subsequent CLs. Bug: 814728 Change-Id: I5daf9eed75d10a0ef292874bb8eea06f888c609e Reviewed-on: https://chromium-review.googlesource.com/1140719Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#576247}
-
Zhongyi Shi authored
Add a new QUIC error code for connection migration, which will be used to close the connection when migration is triggered before handshake is confirmed. Manually merge internal change: 205108882 Bug: 790547 Change-Id: Id337b125c38b9d06d892a9f3a235f61d10f3eaf4 Reviewed-on: https://chromium-review.googlesource.com/1142379Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#576246}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d7b61abe..2c1fd401 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idb09331da891874aaba4544acd90c7e6a821e4d9 Reviewed-on: https://chromium-review.googlesource.com/1142285Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576245}
-
erikchen authored
The test AcceleratorsCocoaBrowserTest.MainMenuAcceleratorsInMapping had an incorrect early return, where it intended to use a continue. The first attempt to land this CL changed the early return to a continue. This broke the test. This CL fixes the test by: * Not performing any checks on menu items without tags, as they may just be macOS menu items added by the OS that we don't care about. * Adding missing accelerator combinations to AcceleratorsCocoa. This CL also removes some dead code in accelerators_cocoa.mm > ui::Accelerator had a member platform_accelerator() which was only used on > macOS, and provided redundant information. This CL removes the member. > > Bug: 846893, 702823 > Reviewed-on: https://chromium-review.googlesource.com/1135644 > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575429} Change-Id: I195bd174a96da58bff96e22495c5ea5b5bfe8549 Bug: 846893, 702823 Reviewed-on: https://chromium-review.googlesource.com/1140211 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#576244}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/764a58f972be..ed4c83aac3f1 git log 764a58f972be..ed4c83aac3f1 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 chrome-bot@chromium.org Update config settings by config-updater. 2018-07-18 dgarrett@google.com chromeos-config: Migrate Chrome PFQ master to swarming (again). Created with: gclient setdep -r src/third_party/chromite@ed4c83aac3f1 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I7732c988d977829dfd737bcbeacb611bec757d3d Reviewed-on: https://chromium-review.googlesource.com/1142011Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576243}
-
Tiger Oakes authored
Continuation of work in bug 646094. Preparing to activate an errorprone check to flag context#getApplicationContext calls. The goal is to prevent storing the resulting context as a class property, and instead use ContextUtils. This CL replaces two others: https://chromium-review.googlesource.com/c/chromium/src/+/1095986 https://chromium-review.googlesource.com/c/chromium/src/+/1095999 Bug: 846456 Change-Id: Id7ed38c318d97b7370938d32677bcf73b85c3314 Reviewed-on: https://chromium-review.googlesource.com/1141933Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#576242}
-
Chris Harrelson authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iac377bceee1a0aab36e9d70c854f4e1d82dc4631 Reviewed-on: https://chromium-review.googlesource.com/1141216Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576241}
-
Sky Malice authored
As part of adding histograms, it seems that the preferred way to emit enum histograms is with a kMaxValue sentinel and let the enum macro detect that. All of the scheduler and user classifier histograms were converted from SHOUTY_CASE to kCamelCase to facilitate a kMaxValue. Bug: 831648 Change-Id: Ib24791fdb7bcafcfeb6cf754736fe6ba7298c7d7 Reviewed-on: https://chromium-review.googlesource.com/1133687 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#576240}
-
Marcin Wiacek authored
Change-Id: Ie684317904482f3f2629c8cd613008fdd76a5b3d Reviewed-on: https://chromium-review.googlesource.com/1142405Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#576239}
-
Marcin Wiacek authored
Change-Id: Ibca3a219a21281cf573a963732a1ef7220be1ffd Reviewed-on: https://chromium-review.googlesource.com/1142410Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#576238}
-
Jiajia Qin authored
This patch conditionally compile the implementation of WebGL2ComputeRenderingContext only on some platforms. Add a gn arg support_webgl2_compute_context to control it. Bug: 862151 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iadf55fa02174bb0451a9035d6513de5a6b94c051 Reviewed-on: https://chromium-review.googlesource.com/1137987Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576237}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9ee65033ce97..1b013420703b git log 9ee65033ce97..1b013420703b --date=short --no-merges --format='%ad %ae %s' 2018-07-18 oysteine@google.com Merge "Chrome: Add message for trace metadata" 2018-07-17 oysteine@google.com Chrome: Add message for trace metadata Created with: gclient setdep -r src/third_party/perfetto@1b013420703b The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:78791178,chromium:840499 TBR=perfetto-bugs@google.com Change-Id: I3c30a560be5cbb34f82107f798888a421f4bad7c Reviewed-on: https://chromium-review.googlesource.com/1142015 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576236}
-
Achuith Bhandarkar authored
This method is intended to be used by the smart-card extension to monitor login status. * cros-specific usersPrivate.getLoginStatus returns a dictionary with data members isLoggedIn and isScreenLocked. * tests for logged-in user, and screenlock cases. Bug: 777356 Test: browser_tests --gtest_filter=UsersPrivateApiLo\* Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib0ba29d3c715fb0ce162ba234ca9be657d40582c Reviewed-on: https://chromium-review.googlesource.com/1094203 Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#576235}
-
bsheedy authored
One of the tests that uses the DON flow was erroneously changed during the XR test refactor to use enterSessionWithUserGestureOrFail instead of enterSessionWithUserGestureAndWait, causing it to fail 100% of the time. TBR=mthiessse@chromium.org Change-Id: I6d05fa052f2d13998b2c25f3d0f80b6d5b7681ca Reviewed-on: https://chromium-review.googlesource.com/1142510Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#576234}
-
Tommy Steimel authored
This CL makes further updates to the MediaControlOverlayPlayButton's KeepEventInNode calculation to only keep mouse events in node if they are on the internal play button itself. This fixes an issue on YouTube Creator's custom blurring tool which prevents the user from creating any blurs. Bug: 864739 Change-Id: I5106ba061c4bcce3594b84e0615ea45352db0f04 Reviewed-on: https://chromium-review.googlesource.com/1141097 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#576233}
-
Marcin Wiacek authored
Change-Id: I2c9cdc7386989e6762a5ae1ac00a868235ed8b8c Reviewed-on: https://chromium-review.googlesource.com/1142407Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#576232}
-
Scott Chen authored
Part of the effort to remove iron-icons/*.html iconsets from the repro. Screenshot showing icons unchanged from before: https://imgur.com/a/1iDQh03 Bug: 855205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iac109e42bee49be6467e40746e3e54d4ab200826 Reviewed-on: https://chromium-review.googlesource.com/1139220Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576231}
-
Stephen Martinis authored
I typo-ed the builder name, mispelled fuchsia Bug: 758256 Change-Id: I75d94e0cd2b6ed13e67dbfe71ec9f85c229a75d0 Reviewed-on: https://chromium-review.googlesource.com/1142443Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#576230}
-
Ian Clelland authored
This is a reland of ac436aaa Original change's description: > Adjusted references in tests to match new helper.sub.js file > > helper.js changed to helper.sub.js. > URLS.safe modified to work with wpt. > > Bug: 739170 > Change-Id: I89e0efdb07c94e78be826c8807d0577ede8a97ec > Reviewed-on: https://chromium-review.googlesource.com/1141725 > Reviewed-by: Mike West <mkwst@chromium.org> > Commit-Queue: Maja Kabus <kabusm@google.com> > Cr-Commit-Position: refs/heads/master@{#576037} Bug: 739170 Tbr: alexmos@chromium.org Change-Id: Idc1e5d5cc4b1dbbc4de4145af38b894c5f4a65b5 Reviewed-on: https://chromium-review.googlesource.com/1142169 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#576229}
-
Khushal authored
This reverts commit 49b85d74. Reason for revert: Speculative revert for failures in crbug.com/865138 Original change's description: > gpu: Add disk caching for skia generated shaders in OOP-R. > > Use the GrContextOptions::PersistentCache API provided by skia to > persist shaders generated internally by skia for OOP raster to disk. > This requires using a special client id to namespace these shaders, > similar to the one used by the InProcessCommandBuffer for viz. > > While the shaders for different sources are stored seperately on disk, > they are finally merged into a single memory cache in the GPU process. In > order to maintain a seperate cache for skia generated shaders, this also > plumbs the client id for a loaded shader to the GPU process. > > R=piman@chromium.org > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I91fd89ed2c3d2a0bcbcb9b1fdc4ddfbc5b8de147 > Bug: 854416,840559 > Reviewed-on: https://chromium-review.googlesource.com/1116197 > Commit-Queue: Khushal <khushalsagar@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#575987} TBR=sadrul@chromium.org,tsepez@chromium.org,khushalsagar@chromium.org,piman@chromium.org,ericrk@chromium.org Change-Id: I0cde27e30d1ab0c8803539148efc42a24a3e2230 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 854416, 840559 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1142306 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#576228}
-
Caleb Rouleau authored
Bug: 864205 Change-Id: I5d9ad26b1f14ae28ca1b80399539dbb3c3a978ee Reviewed-on: https://chromium-review.googlesource.com/1141163Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#576227}
-
Parastoo Geranmayeh authored
Problem: if the state is not saved as the key (like NY), and is saved as a complete form (New York), or is invalid (Caoldo), the assert would fail on debug mode. On release build, the state would not show up on the editor. Solution: Look for both the key and the complete form. If can't find them (invalid value), show the default or the first item. Tests added. Bug: 861821 Change-Id: I8eeb3679c0dd503c264014e22d8e2a6cd8ef5405 Reviewed-on: https://chromium-review.googlesource.com/1140366 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#576226}
-
Nate Chapin authored
This change exposes the Worker() constructor to dedicated workers, allowing them to create descendant workers. Chrome feature entry: https://www.chromestatus.com/feature/6080438103703552 Intent to Implement and Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/KZx0i3e5nZM Bug: 31666 Change-Id: I449978641f7ee4afba2a1087da91d84b78559abb Reviewed-on: https://chromium-review.googlesource.com/953746Reviewed-by:
Ojan Vafai <ojan@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#576225}
-
erikchen authored
The implementation of heap_profiling uses base::Lock. That uses GlobalActivityTracker::GetOrCreateTracker, which uses Chrome TLS. Since heap_profiling may be used post TLS destruction, all called code must also guard against use of Chrome TLS by checking base::ThreadLocalStorage::HasBeenDestroyed. Bug: 864589 Change-Id: I9b7b61d702a79062f847f17d18b6d30f3681b837 Reviewed-on: https://chromium-review.googlesource.com/1142347Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576224}
-
Theresa authored
Allow the bottom sheet to be displayed when contextual search is showing and the toolbar button is enabled. The sheet covers the composited UI when the EoC button is pressed. BUG=863992 Change-Id: I8eeef01d66cceec31d3ebf35351bd958ce962809 Reviewed-on: https://chromium-review.googlesource.com/1141166 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#576223}
-
Scott Violet authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1138866 . Diff between patchsets 2 and 3 to see the diff. And changes ws2 to ensure client is notified when scale-factor changes. The conversion from ScreenProviderObserver to associated interface is to ensure the ScreenProviderObserver is notified *before* the bounds change because of scale-factor. To do otherwise means the client might use the wrong scale-factor. BUG=862409 TEST=none TBR=tsepez@chromium.org, sadrul@chromium.org Change-Id: I4a82d78cf880935d0c740ae3b98bd01c7eb61227 Reviewed-on: https://chromium-review.googlesource.com/1142185Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#576222}
-
Gabriel Marin authored
This CL pulls in tcmalloc 2.7, the most recent release from upstream. Places the files under vendor/ and makes a copy of the code under chromium/. This CL did: # clone tcmalloc repository git clone https://github.com/gperftools/gperftools vendor # checkout the new version and remove git metadata cd vendor && git checkout gperftools-2.7 && rm -rf .git # mirror the src folder cd .. && rsync -av --delete vendor/src/ chromium/src/ This is code pulled from upstream. NOPRESUBMIT=true BUG=724399,b:70905156 Change-Id: I3a3510d514de15a8b1463725fa6f7dab9b1e6d0e Reviewed-on: https://chromium-review.googlesource.com/1130671Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#576221}
-
Ryan Daum authored
Expiry for margin-events timer was always hit because it was using the elapsed time from the last gesture swipe instead of the current. Bug: internal b/111304882 Test: manual Change-Id: Ia6caf8c1291b8bb880272141c23c57f6575b8b3e Reviewed-on: https://chromium-review.googlesource.com/1142353Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#576220}
-
Tom Anderson authored
The comments are no longer applicable. BUG=863460 R=thakis Change-Id: I29d89d18509f600aeac094fa577ec497377bcb93 Reviewed-on: https://chromium-review.googlesource.com/1142375Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#576219}
-