- 16 Sep, 2020 7 commits
-
-
Matt Wolenetz authored
Updates MediaSource and SourceBuffer to consult the MediaSourceAttachmentSupplement to obtain state information about the attached media element, instead of directly asking the element. Updates the SameThreadMediaSourceAttachment implementation to directly consult the element. The state information pumped from the media element is mostly ignored, except: 1) the contexts' destruction is verified to not have occurred already (since in same-thread attachments, the caller would also have been destructed already), 2) the error state of the media element is verified to match the synchronous retrieval (since in same-thread attachments, any update to the element error should also include pumping that to the attachment already),and 3) debug logs emit both the pumped and synchronous time information for comparison. Also includes notification of the attachment supplement when the media source execution context is destroyed. This will be useful especially in later prevention of UAF in a cross-thread attachment implementation. Later changes that add cross-thread attachment support (in a distinct "CrossThreadMediaSourceAttachment" implementation of a MediaSourceAttachment) will instead use the pumped information provided by the media element, to reduce latency and blocking, and to ensure safety/prevent UAF if either context has been destroyed. BUG=878133 Change-Id: Ia8d31c51d21d44552f2a92b76f67d33e164f774c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401808 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#807264}
-
Peter McNeeley authored
Currently the build flag for the ozone platform DRM is actually ozone_platform_gbm. This change renames this flag to ozone_platform_drm in a backwards compatible way. This change will also require changes to third_party in order to support the deprecation of the old flag. (see https://crbug.com/1122010) The final act of this rename will be to remove the old flag. (See https://crbug.com/1122010) R=brucedawson@chromium.org, penghuang@chromium.org, rjkroege@chromium.org Bug: 1116466 Change-Id: I481edf07290eb27b011aede08de40e4210a52834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373181Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Auto-Submit: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#807263}
-
David Bokan authored
Root scroller assumes that if a LayoutBox is scrollable it must have an associated Node. However, there are some edge cases where an anonymous LayoutBox is created, such as for overflowing <input> and <fieldset> controls. To be strictly correct, we could make root scroller work in these cases but it's not likely to be useful in any use cases. It'd also be non-trivial work to fix root scroller machinery - for example, "is root scroller" bits are currently cached on the Node's LayoutBox rather than on the LayoutBoxForScrolling. Instead, we'll simply ignore these cases to avoid crashing. Bug: 1125621 Change-Id: I92880f4430aaa4a4b67d9bdf1ebed2e8dada7d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411396 Auto-Submit: David Bokan <bokan@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#807262}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a195d101f96c..9791e50e3da4 2020-09-15 mtklein@google.com impl q14x2 ops in interpreter 2020-09-15 mtklein@google.com make skvx::if_then_else work at byte granularity 2020-09-15 michaelludwig@google.com Fully disable CCPR for unit test 2020-09-15 bsalomon@google.com SkYUVAPixmaps::toLegacy() init unused mapping for missing alpha channel 2020-09-15 csmartdalton@google.com Relax SkStrokeRec::hasEqualEffect If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ia6e3e9a223dde22c9fcef7c5a00149e8336e24db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412957Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807261}
-
David Vallet authored
Bug: 1124062 Change-Id: I549503bf2ae09c30260133c48af304923bba0996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409884 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#807260}
-
Trent Apted authored
The AppService presents itself to the system differently in these profile configurations, which has resulted in subtle crashes. This CL configures SystemWebAppManagerBrowserTest with a third gtest parameter type. It "defaults" to TestProfileType::kRegular and establishes a way for system apps to neatly specify a set of their tests that should have coverage for all profile types. Bespoke tests for the HelpApp are migrated to this setup, and a subset of pertinent MediaApp tests are parameterised for profiles. Verified the desired coverage is satisfied by commenting out code in web_file_tasks.cc that fixed things that have crashed in the past. E.g. Unconditionally doing `profile = profile->GetOriginalProfile()` causes 6 of the guest mode tests to crash, and omitting that completely causes DCHECK(..IsAppServiceAvailableForProfile) to fail for the incognito tests. Bug: b/166730281 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I22e7062eab0d4d21329602ec27afba89197e7c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398450Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Jiewei Qian <qjw@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#807259}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie5acaacba6fc481453923281172dc836aea51b2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412949Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807258}
-
- 15 Sep, 2020 33 commits
-
-
Alec Douglas authored
This commit makes explicit the nullability of the ControlContainer passed through the Chrome compositor classes. There is already null-checking present throughout, but the @Nullable annotation has been added to make things more clear. This also removes a recently added assert that the ControlContainer must be non-null (added in 144fcec9). There is an existing assert in BrowserControlsManager that checks that the ControlContainer is either non-null OR its position is NONE. cr https://code.amazon.com/reviews/CR-33223034 Bug: 1127053 Change-Id: I214f134c710a535970005e585f073bca9ad313f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404375Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#807257}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/986e74510613..ae073e44336f 2020-09-15 mbonadei@webrtc.org Clobber iOS builders. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Id3130789251670e672018b821930f17501e986e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412953Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807256}
-
David Vallet authored
Bug: 1124062 Change-Id: Ifddf4d3c0f3eb4ec60b0364bf129ba33313bd8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404282Reviewed-by:
David Vallet <dvallet@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Vallet <dvallet@chromium.org> Cr-Commit-Position: refs/heads/master@{#807255}
-
Peng Huang authored
Bug: 1128175 Change-Id: Id9ad4f95dde6131fbf5e3754ee2eaa786d54e363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412187 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#807254}
-
Robert Ma authored
With necessary changes to make Mojo lite bindings available in WPT: * Release mojo/public/mojom/base/*.mojom*.js (mojo_bindings_lite.js was already released). * Add an optional `lite` param to loadMojoResources(). Fixed: 1123987, 1126628 Change-Id: I35d37aa848e7a6333e6185450280c44afd6438c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410676Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#807253}
-
Clark DuVall authored
This enables WebLayer in a split in WebView bundles in canary. I tested on L-Q and ran all instrumentation tests on P with this setup. Bug: 1105096 Change-Id: I517bce4109531108a4fb3af64a87aa1f5d2a91bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412705Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#807252}
-
Ben Pastene authored
As outlined in https://bugs.chromium.org/p/chromium/issues/detail?id=1111436#c17 Bug: 1111436 Change-Id: I8e652b731de9de83bbde1a0acb54e5bf3093519f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349928 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#807251}
-
Kyle Milka authored
Wrap the contents of the share sheet in a ScrollView so it can be scrolled if it doesn't all fit in the viewport. Bug: 1127249 Change-Id: Id86b92a52f93b107842f9ddb679537afdec75306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410310 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#807250}
-
Sadrul Habib Chowdhury authored
The 'SmoothnessDroppedFrame' trace event is reported every time an animation or scroll/pinch ends. The trace-event includes how many vsyncs the page was visible for, and how many dropped frames affected the smoothness during this time. BUG=1125152 Change-Id: I87e5668bd43911f2e66c27b0a4d04b7ed016e5f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378784 Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#807249}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd48130b2905..52fdd1ffcefb 2020-09-15 miladfar@ca.ibm.com Adding AIX If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I63f752040c060a10345a36da0800e212378170b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412952Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807248}
-
Morten Stenshorne authored
This reverts commit 07caa42f. Reason for revert: Performance regression. crbug.com/1128152 Original change's description: > [TextAutosizer] Recalculate inline-size before layout on font size change. > > If the inline-size is deduced from the min/max size somehow (e.g. > shrink-to-fit), a font size change may change the intrinsic (min/max) > sizes, which in turn may affect the inline-size of the element. > > Additionally, we need to make sure that we actually DO recalculate the > intrinsic size of all elements affected by a font size change. > > Note that this bug also exists in the legacy layout engine, but this CL > doesn't address that. > > Bug: 1125109 > Change-Id: Ibb33648fcb9bc6c9061d95e42b7f3c4db7b1bd90 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404847 > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806263} TBR=pdr@chromium.org,ikilpatrick@chromium.org,mstensho@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1125109, 1128152 Change-Id: Iad4e987046a1b9c1f289089ca6997775e47f494f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411942Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#807247}
-
chinsenj authored
In app list, the rename textfield is inconsistent with other renaming patterns. This CL aims to make it consistent and improve it as well. It makes the following changes: - Change background color on hover. - Change size of name textfield. - Add border when name textfield is focused. - When text field is pressed, highlight all text rather than position cursor. - Changes underlying view width from max width to variable length, depending on size of current folder name. Test: Manual Bug: 1127498 Change-Id: I78727116737acdc261419255e3b8b132f79c3313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406281Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#807246}
-
Matt Wolenetz authored
To facilitate implementation cleanup of the interaction between MSE API and the HTMLMediaElement, and also to make subsequent support changes in the MSE API to enable cross-thread function, this change updates HTMLMediaElement to, when attached to a MediaSource: 1) Notify the attachment upon updates to the notion of currentTime. This is necessary for continued proper function without behavior change of the pre-existing implementation of the MSE SourceBuffer coded frame eviction algorithm's eviction range selection heuristic, which attempts to preserve buffered media around the current playhead, or around the seek target. 2) Notify the attachment upon transition of the media element to having a non-null error attribute. This is necessary for continued proper function without behavior change of the pre-existing implementation of the MSE SourceBuffer Prepare Append Algorithm. 3) Notify the attachment upon media element receipt of context destruction notification. In later changes, this will enable protection against UAF of the element-owned webmediaplayer-owned MSE ChunkDemuxer when the element's context outlives the attached worker-context MediaSource. These changes simply notify these bits of information, with a minimal implementation change in the concrete attachment implementation in modules/mediasource. Later modules/mediasource changes to the attachment and media source implementations will actually use this information in at least a cross-thread attachment variant, instead of synchronously querying the media element directly. Note that a same-thread attachment variant may ignore this information and directly consult the media element to ensure no regression of existing same-thread MSE behavior. This change also includes a minimal piece that removes the unused MediaSourceAttachment::IsClosed() interface method. BUG=878133 Change-Id: I91950fdcc916144c82744bfb63382b66fb33b392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391934 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#807245}
-
Ken Rockot authored
This merges all remaining typemap configs in //content into their respective mojom target definitions. Bug: 1059389 Change-Id: Ieeb43ce49ff4bdb2a0c4b95965f374dcca73bc3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407928 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#807244}
-
Elly Fong-Jones authored
This test needs a case for what clang does on Mac Arm64, so add that. Bug: 1128436,1121871 Change-Id: I5d57f99f7d041bc91d9fc862c1d10ddc1b48f540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412552 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#807243}
-
Anastasia Helfinstein authored
Instead of iterating through the array to make a copy, use the ES6 spread operator. AX-Relnotes: n/a. Bug: None. Change-Id: Ia0e1a8d738c5c9480bf991ba9de4a50bb4fca482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391506 Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#807242}
-
Ayu Ishii authored
This change updates TaskType to match the spec from kMiscPlatformAPI to kDOMManipulation. Further discussion can be found here: https://github.com/WICG/cookie-store/issues/159 Bug: 1128057 Change-Id: Ic1066280d7810328f70881772d51066f852b1803 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412699Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#807241}
-
Lukasz Anforowicz authored
This CL removes the allowlist that has been hardcoded into Chromium source code. The deprecation has been announced on chromium-extension@ discussion list, and in the enterprise release notes. The CL introduces a new feature that will be used by the field-trial-param-based mechanism for distributing the allowlist. This can be used to retain extensions on the allowlist if for some reason they didn't migrate to the new security model in Chrome 87. Bug: 1124077 Change-Id: I96c1df1f5b08e177b74f8168b7bd4172c045b391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388709Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#807240}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/93d0ecf3d428..3f01e83f96b0 2020-09-15 johnchen@chromium.org [Catapult] Fix Mac CQ resource error If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1128481 Tbr: zhanliang@google.com Change-Id: I829f9ea89b6aa9653cc6f00a835a96c1095659e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412560Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807239}
-
Ken Rockot authored
This merges some typemap configs in //chrome and //chromecast into their respective mojom target definitions. Bug: 1059389 Change-Id: I955e624f046b77e0506f661b05716ca53c8108e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407927 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#807238}
-
Nnamdi Theodore Johnson-Kanu authored
- Renames button from 'finish' to 'done' - Removes finish string and adds done string - Adds button states for each page in psim flow https://imgur.com/38HmCzm, https://imgur.com/UZ7emL3, https://imgur.com/6WbDN4l Bug: 1093185 Change-Id: I7f79b744887ce3937aa0eaf8bccbd17f15771a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391860 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#807237}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I46793279dae557c6a6b26828f1d8fcaa2d836e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807236}
-
Ehimare Okoyomon authored
Bug: 1077766 Change-Id: I818717294f62843b4489d0e99b38dcd764760342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410874 Commit-Queue: Ehimare Okoyomon <eokoyomon@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#807235}
-
Victor Vasiliev authored
This changes QuicheStringPiece to be an alias of absl::string_view, rather than base::StringPiece. This is a first step in fully replacing QuicheStringPiece with absl::string_view and deprecating the earlier. This adds conversions around the code and switches some of the text_utils_impl to use Abseil directly in order to get the code to compile. Bug: 1128392 Change-Id: I1034ac9b381e44668a738f6538395cf9e338d2f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411554Reviewed-by:
David Schinazi <dschinazi@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#807234}
-
Ken Rockot authored
The typemapping configs are merged into their respective mojom target definitions. Bug: 1059389 Change-Id: I9882de654483126a8f9c048eade521fbbe4e918f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407034 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#807233}
-
David Bertoni authored
The FileSystemApiOpenDirectoryWithWriteTest was never re-enabled after it was determined not to be flaky. Bug: 499233 Change-Id: I26849d8c924e6dda9a6e425f65c4fe82dcc65a72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412747 Auto-Submit: David Bertoni <dbertoni@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#807232}
-
Michael Hansen authored
This fixes the method ordering in nearby_sharing_service_impl.cc to match the order they are declared in nearby_sharing_service_impl.h. Change-Id: I9063aceb60ed831598dd9adbed7893ace0b7f110 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405558 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#807231}
-
Xianzhu Wang authored
Change-Id: I782be143c72a08c2347944451ed1fc32d0aadeb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408273 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#807230}
-
Nikita Podguzov authored
NetworkThrottlingEnabled policy doesn't have a 1:1 mapping to chrome_device_policy.proto thus should be moved to |legacy_device_policy_proto_map| list. Bug: 1108908 Change-Id: Ib74519a7e9eee0c14838c24eb652ad5ccd9a0c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410402Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#807229}
-
Pranav Batra authored
Add method GetRecentlyUsedPrinters() for use with the CUPS proxy. Bug: 1015662 Test: xvfb-run ./unit_tests --gtest_filter=PrintPreviewStickySettingsUnittest.* Change-Id: I908f47d45259ab8dd941d320dad66275b95e00b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359729 Commit-Queue: Pranav Batra <batrapranav@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#807228}
-
Ahmed Mehfooz authored
This change adds icons to make the holding space context menus match the rest of the context menus used in ash. BUG=1127255 Change-Id: I5fd3b528883cbab45a70843a764c7a9acdc2f078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409216 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#807227}
-
Renjie Tang authored
https://quiche.googlesource.com/quiche.git/+log/093f8e4f0014..a5c338388099 $ git log 093f8e4f0..a5c338388 --date=short --no-merges --format='%ad %ae %s' 2020-09-15 fayang Change undecryptable_packets_ from QuicCircularDeque to std::deque. No functional change expected. This is the preparation to support out of order deletion. 2020-09-14 wub Internal QUICHE change 2020-09-14 ianswett Deprecate quic_bbr_flexible_app_limited which was blocked by a bug that's now closed. This was added for Quartc, but that project is no longer active. 2020-09-14 fayang Deprecate gfe2_reloadable_flag_quic_fix_neuter_handshake_data. 2020-09-14 renjietang Pass early data reject reason to debug_visitor. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: I975e50199a590513c299c940c3b119225633fdaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412632 Commit-Queue: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807226}
-
Harkiran Bolaria authored
Bug: 1110344 Change-Id: Ice3b26b0923328dadcf8d81d22abe3024a845129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404368 Commit-Queue: Harkiran Bolaria <hbolaria@google.com> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#807225}
-