- 31 Mar, 2020 40 commits
-
-
Johann authored
Flakiness on https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux Sample output: [ RUN ] LoadingPredictorBrowserTestWithOptimizationGuide.OptimizationGuidePredictionsNotAppliedForAlreadyCommittedNavigation/1 [22182:22182:0330/211059.950234:15709478620:ERROR:edid_parser.cc(102)] Too short EDID data: manufacturer id [22182:22182:0330/211100.151354:INFO:content_main_runner_impl.cc(974)] Chrome is running in full browser mode. [22182:22462:0330/211100.642123:ERROR:object_proxy.cc(632)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [22182:22462:0330/211100.642156:WARNING:property.cc(144)] DaemonVersion: GetAndBlock: failed. [22182:22462:0330/211100.642407:ERROR:object_proxy.cc(632)] Failed to call method: org.freedesktop.UPower.GetDisplayDevice: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [22182:22462:0330/211100.642629:ERROR:object_proxy.cc(632)] Failed to call method: org.freedesktop.UPower.EnumerateDevices: object_path= /org/freedesktop/UPower: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.UPower was not provided by any .service files [22384:22480:0330/211100.706731:WARNING:simple_synchronous_entry.cc(1389)] Could not open platform files for entry. [22182:22182:0330/211100.741071:WARNING:gaia_auth_fetcher.cc(989)] Could not reach Google Accounts servers: errno -11 ../../base/test/metrics/histogram_tester.cc:201: Failure Expected equality of these values: expected_count Which is: 1 actual_count Which is: 0 Histogram LoadingPredictor.OptimizationHintsReceiveStatus does not have the right number of samples (1) in the expected bucket (2). It has (0). BUG=chromium:1060966 TBR=tbansal@chromium.org Change-Id: Ia2ab0b7bc030b6ee68c440e2bfb540ddb8dce95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128040Reviewed-by:
Johann Koenig <johannkoenig@google.com> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#754817}
-
Jinsuk Kim authored
ChromeActionModeCallback is a WebContents object that handles events for action mode. This CL introduces a new class ChromeActionModeHandler that manages the callbacks in response to the lifecycle of the active Tab's WebContents. It is owned by RootUiCoordinator which hooks up the handler with ToolbarManager. It replaces TabObserver.notify..Changed with the observer list managed by the handler. Bug: 995903 Change-Id: Ib9f3ec4c16f71141d339ff8a807ae2167e6e8d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912100 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#754816}
-
Morten Stenshorne authored
No support for block fragmentation yet. There are no new tests, since the new code will be covered by most (all?) tests in the layout_ng_fragment_traversal virtual testsuite. Because of the way a FragmentData object is shared between all (inline) fragments within a block fragment, we now store the "is first for node" bit on all fragments, not only block fragments. This way we know when to reset FragmentData objects during pre-paint (which should only happen for the first fragment, and for subsequent fragments within the same block fragment, we just expand the visual rectangle). Since we now visit each fragment, rather than treating the LayoutObject as a whole (and therefore build up the visual rectangle fragment by fragment as we visit them), there's no way to detect whether the visual rectangle of the FragmentData changed since previous layout. This is obviously unfortunate. We also need some special code when dealing with an out-of-flow positioned box whose containing block is a non-atomic inline, since this relationship isn't reflected in the fragment tree structure. Out-of-flow positioned boxes also need special treatment if we have only performed NG fragment tree traversal in parts of a subtree (and done LayoutObject traversal in other parts). Apart from that, the changes in pre-paint are rather straight-forward. We use NGFragmentChildIterator to walk the fragment tree, rather than walking the LayoutObject tree. There's some refactoring and cleanup possible, but probably not much until we've completely got rid of legacy layout altogether. FragmentPaintPropertyTreeBuilder won't be needed then. Bug: 1043787 Change-Id: I7e1a4ef107acbfc910fdb0a43b5bd0b3b556e62a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111158 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#754815}
-
Maggie Cai authored
This CL removes the original preferred apps files that is no longer neede. BUG=853604 Change-Id: I59598a574d2be298eb60a8a9b14500e3c6aae3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125916 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754814}
-
Koji Ishii authored
This patch prevents crashes when the last resort font for ellipsis is missing. Bug: 561873, 1065045 Change-Id: Ica2ccb1fa458b0353569dde80ea1100d1e2c6c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128002Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#754813}
-
Yi Xu authored
The experiment on whether we need to do a partial update on canvas has finished, so deleting the UMA and logics in code. TBR=rkaplow@chromium.org BUG: 1014246 Change-Id: I72b23e408026cd8f3c2583f90b40038f783460aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125475 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#754812}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/14ba58ff012f..25a88e75eaed git log 14ba58ff012f..25a88e75eaed --date=short --first-parent --format='%ad %ae %s' 2020-03-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src af1924a6..f43e7c4d (411 commits) Created with: gclient setdep -r src/third_party/skia@25a88e75eaed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I81b37a2a9aad09479ad6569d0b6ceaf13bc0bd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128880Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754811}
-
Maggie Cai authored
This CL migrate the app service to use the newly created preferred app list instead of the original preferred app. Follow up CL will be uploaded to clean up the unused pref service code and the original preferred app struct. BUG=853604 Change-Id: I7b26b2ba9007b4733c05e7f49beb91e4573c3777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126409 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#754810}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3f8aa4aefae435d4e14305c504beba7b7d3803e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128881Reviewed-by:
-
David Bokan authored
Overlay scrollbars - the type that fade in/out, not overflow: overlay - should only ever be visible when the content is scrolling. Therefore, if the content cannot scroll, we should never see an overlay scrollbar. This is different from classic (i.e. non-overlay) scrollbars. An overflow:scroll scroller requires showing a (disabled) scrollbar even when there is no overflow. Today, when an overlay scrollbar is created we check after-the-fact in UpdateAfterLayout whether there is overflow and, if there isn't, we remove overlay scrollbars. This is how the above mentioned behavior for |overflow:scroll| overlays is implemented. However, this doesn't account for different kinds of updates. UpdateAfterStyleChange must also recompute scrollbar states and didn't have this no-overflow removal logic. If content caused a style update that didn't require a layout, an overlay scrollbar would be attached in this case. In the attached bug, the scrollbar is visible because the fade out (on the main thread) is controlled by a timer that causes scrollbars to be disabled (which causes them not to paint). In addition to incorrectly creating the scrollbar, UpdateAfterStyleChange does not compute the scrollbar enabled state so it defaults to true. Without being able to scroll, the fade out timer is never started. This CL fixes the issue by moving the overflow requirement for overlay scrollbars into ComputeScrollbarExistence so that we account for it no matter the point at which we recompute scrollbar existence. We also refactor ComputeScrollbarExistence to make clear the distinction between overflow dependent and independent computations. A considered alternative was to always create the scrollbar but ensure its enabled state is correctly set. This would have unified the lifetimes of overlay and non-overlay scrollbars. However, it requires we prevent creating composited layers for scrollbars that are overlay but have no overflow since the compositor fades all of a scroller's scrollbars together so such scrollbars would become visible if the other axis is scrollable. We couldn't use the enabled state for this because it is flipped every time the scrollbars fade in/out so that would cause layers to constanty be created/destroyed so we'd have to introduce more complexity to compositing decisions. This change caused three tests to break (note: unit tests generally use mock overlay scrollbars): RepaintScrollableAreaLayersInMainThreadScrolling: A style change like this does not require invalidating paint on overlay scrollbars' compositing layers since the compositor can deal with resizes on its own. However, this was causing an invalidation because of the bug fixed here: the style change adds a horizontal scrollbar and the layout removes it. Because it isn't composited, it causes the whole PaintLayer to be invalidated[1]. This causes the scrollbar layer to also need a repaint[2]. Since we no longer cause this creation and destruction of the horizontal scrollbar, we don't get this invalidation. This test now resizes the overflow so that the vertical scrollbar needs to be disabled which does cause an invalidation. [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc?l=2845&rcl=33a9a3956034a765124f034a8f7d86f19c9c17e6 [2] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc?l=2099&rcl=01e24ce806680bf99abf117e77d30d9566c72121 TraverseNonCompositingDescendantsInPaintOrder: The source of the failure here was that the |overflow:scroll| div no longer has overlay scrollbars after its style is updated (but before it does layout). When it performs PaintLayer::UpdateSelfPaintingLayer it will no longer be self painting[3]. Since it no longer has a self painting layer it will be added to the parent's visual overflow. This larger rect means that during overlap testing, the scroller's sibling (#stacked-child-of-composited-non-stacking-context) and its parent will overlap and so the sibling will require compositing. Finally, because it is now composited, it is now a paint invalidation container and so it won't be invalidated from the container element[5]. The fix here is to simply add overflow to the scrolling div so that it continues to cause a self painting layer in [3]. [3] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/paint_layer.cc?l=3054&rcl=fa18fef1b31a878fed89e2a543c3be0af2f57623 [4] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/layout_box.cc?l=5780&rcl=0650ec2415a0f2583db48d11c6d8b6a31ff448c4 [5] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/paint/object_paint_invalidator.cc?l=70&rcl=d9d7df43f1718c900afc470371b382c8dca085b6 mock-scrollbars.html: This was failing only on the legacy LayoutNG disabled bot so I didn't dig too deeply into it. The failure here was that the inner box would layout as if the parent had non-overlay scrollbars. I believe this is because the mock scrollbars were being enabled at load, after layout was already completed. I think this used to work because the scrollbar was being added and then removed which would cause a layout invalidation which no longer happens, thus we need to ensure mock scrollbars are enabled before we produce the first layout. Bug: 1039501 Change-Id: Ic68522a4fdba8ffaa2c5ef508736c9a94eac7682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119933 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
-
danielng authored
default Follow up from CL:2086359 to ensure that the Crostini mic sharing dialog only shows when Crostini needs to be restarted. Tests were added to check this and the flag regarding the mic sharing settings is now enabled by default. Note that the mic is not shared by default. Tests: Tested mannually and expanded the appropriate browser test Bug: 1016193 Change-Id: I4b416feedddbe4e3b7f0c5fc638701f9f809ae66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123579 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#754807}
-
Alan Cutter authored
In BrowserActionsContainer::GetFlexRule() the width is clamped between a min width and a max width. If the min width is > max width it should still win. This CL ensures this behaviour in the boundary condition and fixes a bug where resizing the extension icons in the toolbar to 0 would not be able to be reversed. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=439709&signed_aid=C2ncXrrBkAc-NH_GjVaSmg==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=439710&signed_aid=9D3JktJW8DssKm2eMOvAYg==&inline=1 Bug: 1066337 Change-Id: I6602673fdefb84ee0a3c2b1eaa728238d3175573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128039 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#754806}
-
Devlin Cronin authored
Add user actions for: - The menu being opened - The pin button being pressed - The user activating an extension from the menu - The user activating an extension from the toolbar Bug: 1064111 Change-Id: I6978c1ffefcbb4171e756375e9bc9798d2674be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116583Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754805}
-
Gang Wu authored
Tried 100 times by tools/run-swarmed.py and the test never failed, so enable the test. Bug:791021 Change-Id: I903fa0abd132aea10e8a2b84b7282c5476bb7487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125871Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754804}
-
Dominick Ng authored
The new web apps backend is explicitly disabled in ARC++ Kiosk mode, which causes a crash as ApkWebAppInstallService now depends on the new web apps backend. This CL disables ApkWebAppInstallService when the new web apps backend is disabled. BUG=1065655 Change-Id: I1488cb9a57e89c76e4c011f11e86349322501516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127989Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#754803}
-
Pavel Yatsuk authored
This reverts commit 1e688ea3. Reason for revert: This CL breaks Clank build. Failed builder: https://ci.chromium.org/p/chrome/builders/ci/arm64-builder-rel/21232 Compiler message: ../../components/feed/core/v2/feed_stream_unittest.cc:251:7: error: predefined identifier is only valid inside function [-Werror,-Wpredefined-identifier-outside-function] FROM_HERE, base::TimeDelta::FromSeconds(1)}; ^ ../../base/location.h:123:52: note: expanded from macro 'FROM_HERE' #define FROM_HERE ::base::Location::CreateFromHere(__func__, __FILE__, __LINE__) ^ Original change's description: > Work toward synchronizing feed store and model > > - Added LoadStreamFromStoreTask to read model data from the store. > - Update LoadStoreTask to try loading from the store first, via the new > task. > - Save operations executed to persistent storage. > - Added some conversions to textproto for tests. > > My primary goal when making this change was to save operations to > persistent storage as they are executed. Pulling this thread led to > several changes. > > We were saving a bit too much data in the single 'stream_data' record, > which meant we would have to re-serialize the whole model to save a > single piece of information. I went ahead and split 'stream structures' > out into another record. All stream structures for the stream now need > to be read in at load time, and they need to be sequenced appropriately. > > In making that change, I wanted to verify we could actually load the > data back in. So I implemented loading a stream from storage as well. > > Bug: 1044139 > Change-Id: I98767281b4a5d1ae401dba5db5bff966f3473452 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123249 > Commit-Queue: Dan H <harringtond@chromium.org> > Reviewed-by: Ian Wells <iwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754782} TBR=iwells@chromium.org,harringtond@chromium.org Change-Id: I7a1955a0a4dbb76cf6d17497be63b8256218ca31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129234Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#754802}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1288aa12369e..05fa1a99914a git log 1288aa12369e..05fa1a99914a --date=short --first-parent --format='%ad %ae %s' 2020-03-31 ynovikov@chromium.org Skip test flaky on SwANGLE bots Created with: gclient setdep -r src/third_party/angle@05fa1a99914a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ie6e0c404ed94b56f14bd2ec2ef44e3b9a9f41e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129268Reviewed-by:
-
David Bokan authored
In https://crrev.com/c/2119933 I added a new call to GetScrollbarTheme which caused a number of unit tests to start crashing. On Android, unit tests run without a ThemeEngine (Platform::Current()->ThemeEngine() == nullptr). This means that they must use a mock scrollbar theme, otherwise anything scrollbar related might crash. Currently, it was possible for some tests to avoid setting a mock theme and run successfully if they got lucky and avoided code paths that called into the theme. This CL adds a DCHECK when a blink::Page is created to ensure we can access the theme. This flushed out all tests that were in this situation and we fix them here. It also ensures future tests are made to install a mock theme so we don't run into this situation again. Bug: 1039501 Change-Id: I78dbf406b6168a71b67e75f09ef824b5cdc2a8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125952Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#754800}
-
Gyuyoung Kim authored
This CL moves flexitem-stretch-range[-expected].html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and test description. Additionally, this CL removes <p></p> paragraph because it's the same to the assert. Bug: 1063749 Change-Id: If2811c22ddb2d38e9bb233d8fca416c8c5f0452d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124280 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#754799}
-
Rakina Zata Amni authored
We changed find-in-page to use normal tasks instead of idle tasks in crrev.com/c/2041711, but it's currently causing crashes. To ensure stability in M83, we're reverting the change (but not all of it, we're keeping the scheduler-side changes to use later - it won't affect the revert). We'll investigate this and reland after the M83 branch point. Bug: 1065371 Change-Id: Ib7b0db989910a5c1c0da82eea65af1ab6f617441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127998Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#754798}
-
Jeevan Shikaram authored
This CL uses the web app registrar to make DoShowAppInfoFlow extension agnostic. Bug: 1064877 Change-Id: I3c10831be43da207edc1d007e5f3b74891d3df84 Fixed: 1064877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124282 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/4da46462d786..276b0652658d git log 4da46462d786..276b0652658d --date=short --first-parent --format='%ad %ae %s' 2020-03-30 yunchao.he@intel.com Add validation tests for resource usage tracking - 4 2020-03-30 cwallez@chromium.org Fix compilation on iOS where setDisplaySyncEnabled isn't available. 2020-03-30 bungeman@chromium.org Add std:: to nullptr_t 2020-03-30 rafael.cintron@microsoft.com Call ID3D12SharingContract::Present on WebGPU swap buffer destroy Created with: gclient setdep -r src/third_party/dawn@276b0652658d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4356776b53fbc158b0c1579977c0eee36503b617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129177Reviewed-by:
-
Sadrul Habib Chowdhury authored
The PipelineReporter trace-events can be a bit confusing sometimes because some child-events seem to not be parented correctly. There seems to be at least one issue with the trace-viewer: if a parent-event has only a single child-event, and both have the same start/end timestamps, then the parenting seems to break. So change how the trace-events are generated to account for this. Notable changes: . All trace-events are generated at the end of the frame. This makes it possible to not report the child-events if there's only one child event for a parent. This also moves all the trace-related code into one place, clearing up the other code. . The 'is single threaded' information in the traces is not really all that useful, since that information is already available in the trace viewer (only Browser is single-threaded). So remove that information from the trace (and the associated plumbing), and instead include the BeginFrameId. BUG=none Change-Id: I319fb764bf24acba6ed3f8427bb0d0a79a891613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125822 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#754795}
-
Nicholas Hollingum authored
We split up the crostini tests so that each suite runs in a separate test. This requires factoring tests from SubPageDetails into a leaf suite called "SubPageDefault". We also re-enable all the tests except the Port Forwarding suite, which we suspect is responsible for the flakes but we can not reproduce the flakes locally. Bug: 1056268 Change-Id: I8f4a6af5943845c67178e2fe3d9edde69fc9616f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124281Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
-
Meredith Lane authored
This reverts commit 33a9de15. Reason for revert: Broke unvisited links in light theme on Android. Original change's description: > [ReaderMode] Update background and text colours for themes > > Updates background, text and link colours to match Figma mocks, and also > fix some colour contrast issues. > > Bug: 1025300 > Change-Id: I1fca11a04863718ffa1676fe978538a2ebacd6c4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114475 > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > Commit-Queue: Meredith Lane <meredithl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753037} TBR=wychen@chromium.org,gilmanmh@google.com,meredithl@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1025300 Change-Id: I08fd60558a65e24685df8bb62a1d886c567f2960 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128034Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#754793}
-
Sorin Jianu authored
Essentially, it is writing some callbacks and callback adaptors to handle the updater and the COM RPC in the correct sequences and threads. This CL fixes a small bug when saving prefs during the updater setup when no --appid was specified. Bug: 1053729 Change-Id: I0effe3eee25315e42d09ac51fe5f32df6701082e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123758 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#754792}
-
James Zern authored
Change-Id: Ic6e92db4c24b7b13804f84824b82c89f26ab5bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128945Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#754791}
-
chrome://media-appTrent Apted authored
The media app has the ability to "interrupt" image decodes by revoking Blob URLs, but this makes tests confusing. Update the chrome://media-app tests to properly propagate the completion of image loads on the initial loads and on navigation. Bug: b/152729704 Change-Id: Iaca65ac183f5fd4cfa5f84be93c724266e4ae4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127996Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#754790}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=cmasso@chromium.org Change-Id: I11957d8c1127bec834147200278586cc53112db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129109Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754789}
-
Lukasz Anforowicz authored
As explained in https://crbug.com/1021172#c5 and #c6, tests working with extension popups are sensitive to focus/activation changes. This can manifest as flaky test failures if such tests execute in browser_tests test suite. To avoid this, this CL moves the affected tests to the interactive_ui_tests. Bug: 1021172 Change-Id: Icf4bcd43a3343c32ebe693b42026d7822d9ded41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108082Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#754788}
-
Kenichi Ishibashi authored
This CL adds a mojo interface which will be used between //content and the storage service to handle storage operations. This interface is similar to LocalStorageControl but for service worker storage. ServiceWorkerStorage will directly implement the interface. However, to reduce impacts on existing code base, the interface is going to be implemented by a thin wrapper calls ServiceWorkerStorageImpl for now. This CL only adds methods to find a registration. Subsequent CLs will add more methods. Bug: 1055677 Change-Id: I7d8cd0677356a6953144896dd7f05a4ed04a2608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120838 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754787}
-
Michael Cui authored
Dwell time is the time the user spent interacting with the current demo session, measured from first user activity to last user activity. While there is an existing metric which measures this, DemoSession.SessionLength, there are some key differences: - SessionLength measures the duration to logout. DwellTime measures the duration to the last user activity. - SessionLength is measured to the nearest minute and uses linear bucketing up to 2 hours. DwellTime is measured to the nearest second and uses exponential bucketing up to 1 hour. - SessionLength persists across crashes and is reported at the start of the next session (possibly to ensure that metrics are sent correctly), while DwellTime is not crash-resistant and is reported at the end of the session. Bug: b/148752593 Test: ash_unittests --gtest_filter="DemoSessionMetricsRecorderTest.DwellTime" Change-Id: I179c59ecd537f33e36e329ba9853b35198ccc793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114319 Commit-Queue: Michael Cui <mlcui@google.com> Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#754786}
-
Andres Calderon Jaramillo authored
This CL fixes the MailboxVideoFrameConverter to let ScopedSharedImage be owned by the unwrapped DMA-buf VideoFrame (a.k.a. origin_frame in the code). Note that the mailbox VideoFrame sent to the client has a reference to the wrapping VideoFrame. Therefore, the new ownership model ensures that the SharedImage lives at least as long as the mailbox VideoFrame, even if the MailboxVideoFrameConverter dies in the meantime (this has been observed to happen when pausing a video then switching to another tab to play another video and then switching back to the original tab - see referenced bug for more details). Note that ScopedSharedImage is changed to be mutable. That's because we need to handle a case in which the visible rectangle of a VideoFrame changes and the SharedImage needs to be regenerated. Bug: 1044890 Test: forced the use of VD in krane and went through scenario in bug. Change-Id: I4ff20b0b5088a7a202efc98747fdb5e7a9e9d5f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119153 Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754785}
-
Steven Bennetts authored
The current logic doesn't actually get the correct timezone for determining UTC offsets, this fixes that. Bug: 1054951 Change-Id: I46a704647c77adf9fb2806d415ecd219c56d0378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124542 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#754784}
-
Gyuyoung Kim authored
This CL moves flex-item-contains-strict.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, a proper title, and test description. Bug: 1063749 Change-Id: I8c688b51efc8890250073778b76bef1f23f8fa24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123573Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#754783}
-
Dan Harrington authored
- Added LoadStreamFromStoreTask to read model data from the store. - Update LoadStoreTask to try loading from the store first, via the new task. - Save operations executed to persistent storage. - Added some conversions to textproto for tests. My primary goal when making this change was to save operations to persistent storage as they are executed. Pulling this thread led to several changes. We were saving a bit too much data in the single 'stream_data' record, which meant we would have to re-serialize the whole model to save a single piece of information. I went ahead and split 'stream structures' out into another record. All stream structures for the stream now need to be read in at load time, and they need to be sequenced appropriately. In making that change, I wanted to verify we could actually load the data back in. So I implemented loading a stream from storage as well. Bug: 1044139 Change-Id: I98767281b4a5d1ae401dba5db5bff966f3473452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123249 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#754782}
-
Daniel Hosseinian authored
The current return type of base::SHA1HashSpan() is too long. Change-Id: I6220807ba411933e9494bed09ce95bd0f5cc5c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125625Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#754781}
-
Brandon Wylie authored
The current implementation is looking for a currently running tabbed activity to handle the incoming intent. This is the correct thing to do when handling outside intends, such as an open request from a messaging app. When reparenting tabs in multi-window mode, this clobbers a ChromeTabbedActivity instance which is being recreated as a result of a theme change. Bug: 1055228 Change-Id: I722365c43ec97ab12120e9139eb43a781de8090a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117062Reviewed-by:
-
Nate Fischer authored
This links to zsh-users/zsh-completions, which includes a completion script for the Android emulator command line tool. Test: Upload to gerrit > open file > click "gitiles" Change-Id: I527c5da96af560ad9853c00050fc5e7dcc36705d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128786Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#754779}
-
Gyuyoung Kim authored
Change 'auto' with 'percentage the test title and file name. And, the attribute of the bug link rel is changed to 'issue' with a full bug link. Bug: 1063749 Change-Id: I0a25c6caa3d3afd6c928bb8bc2b692037c0f57c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126329Reviewed-by:
-
