- 31 Jul, 2019 40 commits
-
-
Antonio Gomes authored
BUG=704136,919392 R=guidou@chromium.org, haraken@chromium.org Change-Id: If572e29ad5e6bd87c4d6c9de445e9edea09f8416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729329 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#682748}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bf1198869aba..80dc3d15d3e3 Created with: gclient setdep -r src-internal@80dc3d15d3e3 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie4be52319402e7ba98d41b77cea717b9b86dda36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729310Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682747}
-
Chromium WPT Sync authored
Using wpt-import in Chromium df2ed4af. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 55d429a7 "CSS: WPT for font-variation-settings parsing" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams mstensho@chromium.org: external/wpt/css/css-multicol rijubrata.bhaumik@intel.com: external/wpt/html-media-capture NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I7b0e19d4698af96fcc83d2f2f0ff360110894095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728213Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682746}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=knollr@chromium.org Bug: 968047 Change-Id: I6c06f32b24ff208b5020f45f70b3c09d08fd9881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728558 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Richard Knoll <knollr@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#682745}
-
Charlie Harrison authored
Bug: None Change-Id: I19aaad53c0c6aad79b538005882197fa53387cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703587Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#682744}
-
Sophie Chang authored
Bug: 969558 Change-Id: I6b6457c4203c3d2b849f10d85e1ec2b3912ae0cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726762Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#682743}
-
Igor authored
The new value for the case when PCR0 is in a wrong state is added. The implementation of ChromeOS side is done in https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1724372 Bug: b:127321828 Test: None Change-Id: I58f0e7daf24560f56295d369c9e766f7188a0491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729159Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#682742}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ccb430fd4ebb..e2248cbc238c git log ccb430fd4ebb..e2248cbc238c --date=short --no-merges --format='%ad %ae %s' 2019-07-31 taylori@google.com Merge "perfetto-ui: Fix sidebar" Created with: gclient setdep -r src/third_party/perfetto@e2248cbc238c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I7d95d09ff030635a74b5638bcb89b4bd3f0595cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728312Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682741}
-
Gauthier Ambard authored
In some cases null items could be committed. For example if two navigations are pending at the same time: 1. Both navigations start 2. Second navigation is hitting "LoadRequest", resetting the pending item. 3. First navigation commit, the "pending item" (which is null) is committed. This CL prevents this. Bug: 979569 Change-Id: I504a0a9d9186cf276a9210167d724de2c7c4bbad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725642Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#682740}
-
Abhijeet Kandalkar authored
The primary goal of this CL is to use IsA<HTMLBaseElement>(element) in place of IsHTMLBaseElement(element) Bug: 891908 Change-Id: I7ba795ddbf3a0650a0ca212066d53328559d1e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728537Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#682739}
-
Clemens Arbesser authored
This fixes a bug with the chevron alignment and also a bug where the last (rather than the first) complete item was preselected in some cases. Screenshot after change (chevron in payment method is now vertically centered): https://screenshot.googleplex.com/buOn4neaRxZ.png Bug: b/138643986 Bug: b/138643669 Change-Id: Idf61e667a5290a2314d3d95d62f45cab9e0e0bc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729227 Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#682738}
-
Justin Cohen authored
Also disables more affected context menu tests. Bug: 989550 Change-Id: I9963e6c6dc44f0e255a689c83a878d6db610f342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728539 Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#682737}
-
Xiang Ji authored
Change-Id: Ie0e5103e4c952ef65110855de248e80a5a54468a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725254Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Xiang Ji <jxiang@google.com> Cr-Commit-Position: refs/heads/master@{#682736}
-
Vincent Boisselle authored
In its current implementation, IsSyncEnable() does not cover by default the case where sync is in the "paused" state where it will return true when sync is "paused". Considering that we don't want demographics to be provided when sync is "paused", we need to add an explicit check for the "paused" state before providing demographics. Bug: 988825 Change-Id: Ic62a2a6a43468ad3980d7d1fc0e127ba6241579e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724638 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#682735}
-
Maks Orlovich authored
This avoids setting it when the new entry ownership is not actually transferred to the caller, hence avoiding double-Closes with perfectly reasonable code like LegacyCacheStorageCache::QueryCacheContext destructor. (I am probably going to refactor this issue away next week, but that's not for M77). Bug: 987782, 976206, 982033 Change-Id: I056d238bf8e1a5083f48034318b131fc6acb79e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721109 Commit-Queue: Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682734}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I5d63f8738bf2034ff93c33e446c011938ef61344 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729050Reviewed-by:
-
Daniel Bratell authored
kMediaStreamSourceTab, kMediaStreamSourceScreen, kMediaStreamSourceDesktop and kMediaStreamSourceSystem were declared to be exported from both blink_platform.dll and blink_common.dll. In some build configurations that inconsistency caused build errors: In file included from third_party/blink/renderer/platform/mediastream/media_stream_center.cc:42: In file included from third_party/blink/renderer/platform/mediastream/media_stream_descriptor.h:37: In file included from third_party/blink/renderer/platform/mediastream/media_stream_source.h:39: In file included from third_party/blink/public/platform/modules/mediastream/web_platform_media_stream_source.h:9: ../..\third_party/blink/public/common/mediastream/media_stream_controls.h(17,1): error: 'dllimport' attribute ignored [-Werror,-Wignored-attributes] BLINK_COMMON_EXPORT extern const char kMediaStreamSourceTab[]; The error is triggered by first seeing the constant with a declspec(dllexport) (expanded from BLINK_PLATFORM_EXPORT) and then with a declspec(dllimport) (expanded from BLINK_COMMON_EXPORT). Since common can't depend on platform, the constants need to be in blink_common.dll so this moves them there. This is only an issue in Windows component builds. Bug: 704136 Change-Id: I4bcd6c5b29e534ecfc3ffef908a095b2d33f3a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729251Reviewed-by:
-
Carlos Caballero authored
It is going away soon, replace with the real thing: MessagePumpType Had to fix a lot of includes (MessagePumpType is defined in message_pump_type.h). This is a mechanical change that will be reviewed according to https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes Bug: 891670 TBR=gab@chromium.org Change-Id: I1c85fce3cc11f7a283153ccaf2596e6e92a638d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726058 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#682731}
-
Andrew Grieve authored
This was my intention before, but was buggy :(. Change-Id: I307d13e9a30ee021a5943bc085961281b1d83421 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727772 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#682730}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6acb069c2c13..97e015fa8e5a git log 6acb069c2c13..97e015fa8e5a --date=short --no-merges --format='%ad %ae %s' 2019-07-31 titovartem@webrtc.org Update metrics units for better fit in DefaultVideoQualityAnalyzer 2019-07-31 sprang@webrtc.org Fix potential crash if nack is being processed when media gets disabled 2019-07-31 titovartem@webrtc.org Remove dead code from DefaultVideoQualityAnalyzer 2019-07-31 kron@webrtc.org Use total_decode_time_ms in VideoAnalyzer Created with: gclient setdep -r src/third_party/webrtc@97e015fa8e5a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:b/138636698,chromium:980853 Change-Id: Ifee9f86ef83e24164453e3575c16c9104975dd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729309Reviewed-by:
-
Kinuko Yasuda authored
Change-Id: I0fad75959c29514e06083bffab9d05a0952d3ed3 Bug: 824840 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728310 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682728}
-
Jit Yao Yap authored
Background: The chrome.loginScreenUi extension API can open windows while in the ChromeOS signin screen. The API uses a views::WebDialogView to show the window. One of the parameters of the API sets whether the window can be closed by the user. Currently, setting the parameter to false prevents the user from closing the window, but the close button is still interactive (animates when hovered and when pressed). ash::NonClientFrameViewAsh and DefaultCaptionButtonModel treats the close button as always visible and always enabled. This CL changes FrameCaptionButtonContainerView to not show the close button depending on views::WidgetDelegate::ShouldShowCloseButton(). In addition, this CL also makes the LoginScreenExtensionUi window not draggable. BUG=985754 Change-Id: I191cfad13aeb2764fecaa8867cf344a16aeb0e6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709586 Commit-Queue: Jit Yao Yap <jityao@google.com> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#682727}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=davidben@chromium.org Bug: 968047 Change-Id: Ibcfcb0491d7c78c55f2c5ea250b94f276293cd4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728881 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#682726}
-
Avi Drissman authored
BUG=988979 TEST=as in bug Change-Id: I40c09d3f3d630d2ef4762d7970d6a6ec52a875ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727489Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#682725}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/38a850d9..da479f0f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If172e61638a2fbaafba416c7de378bf1030bcaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729269Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682724}
-
Martin Robinson authored
Orca no longer needs this because it no longer assumes that the document doesn't include anonymous block text in its own AtkText. Bug: 959659 Change-Id: If9f0c2de7678e66cec94e998ea9fcdf1ed4440dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728659Reviewed-by:
Joanmarie Diggs <jdiggs@igalia.com> Commit-Queue: Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#682723}
-
Matt Menke authored
This CL makes LoadingPredictor always use the NetworkIsolationKey for the initial main frame URL when preconnecting. In a future CL, I'll make it use a NetworkIsolationKey of the expected destination URL, after redirects, instead. BUG=987735 Change-Id: I221a6bd4175005758ebf86b55cc21bdd98b167eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716620 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682722}
-
Antonio Gomes authored
This is how the methods got distributed: * modules/mediastream/media_stream_utils.cc|h (added): - DidCreateMediaStreamTrack() - CreateNativeAudioMediaStreamTrack() * modules/mediastream/media_stream_track.cc - DidCloneMediaStreamTrack() - DidSetMediaStreamTrackEnabled() - CloneNativeVideoMediaStreamTrack() - CreateWebAudioSourceFromMediaStreamTrack() * modules/mediacapturefromelement/canvas_capture_media_stream_track.cc: - DidCreateMediaStreamTrack() * modules/webaudio/media_stream_audio_destination_node.cc - DidCreateMediaStreamAndTracks() * modules/mediacapturefromelement/html_media_element_capture.cc: - DidStopMediaStreamSource() Additionally, the following midfield files/classes got removed: * WebMediaStreamCenter - third_party/blink/public/platform/web_media_stream_center.h * content::MediaStreamCenter - content/renderer/media/stream/media_stream_center.h BUG=704136,919392 R=guidou@chromium.org, haraken@chromium.org TBR=jam@chromium.org Change-Id: I490ad2fc5eddb03a2c342731713fef7e2f12d952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726573 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Peter Marshall authored
Previously we applied the filtering from the user (_textFilter) before we calculated the self-time for each of the nodes. The way this calculation works is that each node is assigned the entire time of its duration, and then child nodes 'steal' self-time from their parent, and the parent is left with the remaining non-stolen self-time. If we filter before calculating time, child nodes won't steal self-time from their parents, and the self-time for the parents will be wrong as seen in the bug report. This change includes all nodes (ignoring _textFilter) in the calculation step and then filters out the nodes from the final data structure. Bug: chromium:970825 Change-Id: I99655877e46671c4e2beb944116aa57eab69b8a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706694Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682720}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6808e2d1faac..fe125a11032d git log 6808e2d1faac..fe125a11032d --date=short --no-merges --format='%ad %ae %s' 2019-07-31 aparchur@google.com [skottie] Rename TextValue to TextPropertyValue and make public. Created with: gclient setdep -r src/third_party/skia@fe125a11032d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: Ib4cdb2e8fde34b00550ef3a5f6cb5088ef25ede3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729229Reviewed-by:
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=rockot@google.com Bug: 968047 Change-Id: Ibc0247e479f4dcf648806a34d8328be152b38147 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729217 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#682718}
-
Carlos Caballero authored
MessageLoop is deprecated and we no longer run SequenceManager instances on top of a MessageLoop BUG=891670 Change-Id: Ie24973c321b0656b7decc2bc33b9d0566d4e2fc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715502 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#682717}
-
Kevin Ellis authored
This patch is part of a series to clean up the implementation of web-animation to align with the specification. Bug: 960944 Change-Id: Ie8c97d61ee371c22454ceb52c9441161199775d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726349 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#682716}
-
vitaliii authored
Disable SingleClientSessionsSyncTest.NavigationChainAlteredDestructively on Win and Linux (flaky). TBR=frechette@chromium.org Bug: 972871 Change-Id: I0d3b400c1465ed1b728ce186c011d7dcdffbc669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729220Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#682715}
-
Carlos Caballero authored
MessageLoopForUI will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=timvolodine@chromium.org Change-Id: Idd79f6d837976092a9e4cf5e8cac878bd3e727f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715820 Auto-Submit: Carlos Caballero <carlscab@google.com> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#682714}
-
Randy Rossi authored
Allow setting the ax child tree id property on the full screen shell surface. Bug: None Test: Manual w/display assistant build Change-Id: I465e45dc37038ea3c36131fb04a8d57c7b94f3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720867Reviewed-by:
-
Mugdha Lakhani authored
We should only increment num_attempts for Periodic Background Sync if the event has been unsuccessful. This also extracts out the logic of calculating num_attempts into a helper method. Bug: 989444 Change-Id: I820f91cd2799be9803295cf9baf3dbd194fd3b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729078Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#682712}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=rogerta@chromium.org Bug: 968047 Change-Id: Ie0678d17a9847458418eaa08e0832295d70e5e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729216 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Roger Tawa <rogerta@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#682711}
-
Charlie Harrison authored
Bug: 980418, 972783 Change-Id: Ie9d53b6e4377bfb90dfdd8343e228856477b40d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715102Reviewed-by:
-
Daniel Bratell authored
I'm trying to remove variable shadowing in some Chromium code to maybe make the code a bit more robust, and there were nested timestamps named |start| in some test code that triggered the shadowing warning (not yet enabled). Bug: 925310 Change-Id: I1ce0b98228e683b497b6362fb1519beadb07de71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729149Reviewed-by:
-
