- 08 Nov, 2019 15 commits
-
-
Finnur Thorarinsson authored
Bug: 1016870, 860467 Change-Id: I185dc9f2eb07b0471ddf3eb8ceafdd3768c02af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897700 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#713685}
-
Scott Violet authored
These come from running the android linter. BUG=1020414 TEST=none Change-Id: I02069762e3cbadf595884ddaa607c810a30fc45e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904763 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#713684}
-
John Budorick authored
Bug: 984162, 1004848 Change-Id: Ibb7c47f0188de8e077cd30aa8d68ca61133d2037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904549 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#713683}
-
Kai Ninomiya authored
Specification change: https://github.com/gpuweb/gpuweb/pull/469 Dawn roll: https://dawn.googlesource.com/dawn/+log/c3284fa40ec6b12731ed66c2f2a9256ae3fa692e..ae1f25fee85ebf2773b24a0a4f39c160839b1dbb CTS roll: https://github.com/gpuweb/cts/compare/3dc37c83a70667e9a92df773f34d154ec600d203...e114192747a54f34157eb65754e037701fbdf98b TBR: haraken@chromium.org Bug: dawn:22 Change-Id: Ib427760b9fba4b2cc4290de046c4a31d77e0b67a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900807Reviewed-by:
Austin Eng <enga@chromium.org> Reviewed-by:
Yunchao He <yunchao.he@intel.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#713682}
-
Nasko Oskov authored
Bug: 763548, 1002276 Change-Id: I31ce542d39baee996359ba179759ac00239744c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904448 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713681}
-
Armando Miraglia authored
http://crrev.com/c/1831763 introduced a policy to make sure that enterprises can explicitly control the audio sandbox. The CL assumed that all calls of IsAudioSandboxEnabled() would happen on the browser process. It was, however, noticed that this is not the case as IsAudioSandboxEnabled() is called on the audio utility process to configure the sandbox. This caused the sandbox to always be enabled, since the default value for g_audio_sandbox_enabled is true. This CL fixes the behavior by replacing the global static variable with a switch which is then copied over to the audio utility process. Bug: 1018580 Change-Id: I810ca1f0c9aed43b892c06960cd8a87fc6debd8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901029Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#713680}
-
Robert Liao authored
BUG=5027 Change-Id: If972ad1381437b116f3279a3a51480dd2098d564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904495 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#713679}
-
yjliu authored
Added VLOG to trace the bug where switching users with both having sunset-to-sunrise schedules may not apply NL correctly Bug: 1015474 Change-Id: Ib8a92dad84563175a48bce1a5270b341716b15e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902114Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#713678}
-
Xiaoqian Dai authored
For a fling event, if the hotseat was hidden when the drag started, only if the fling event position exceeds the restore-to-maximized threshold, the window will be taken back to home screen. Also, remove the logic to decide if drag can be allowed from DragWindowFromShelfController as ShelfLayoutManager already handled it. Bug: 997885 Change-Id: I35b9c35df1477b92b5c01db49c9302b6f3bace60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902176 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713677}
-
Ben Kelly authored
This was an oversight in crrev.com/c/1884932 and effectively made the CacheStorageHighPriorityMatch feature have no effect. Bug: 1018920 Change-Id: Ib962f254c9204cdcde1c817cf7ecfa13360ac2e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904125 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#713676}
-
David Grogan authored
We had been reversing the position of the items ignoring the fact that margin-top and margin-bottom shouldn't flip. Bug: 845235 Change-Id: I943c454fdb5f850a1e1294349abc9e9fe8c46aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903616 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#713675}
-
wutao authored
For Assistant web container, we do not need to clip the contents corners. Bug: b/144047917 Test: manual Change-Id: I865bb375c52faee3b5cda708b48b137aa07452ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902715 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713674}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I1e74a496b861354f9b5e83d74610b87c491af991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904536Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#713673}
-
Wenjie Shi authored
The PlatformSensorReaderWinrtBase::IsSensorCreateSuccess function has a switch case that determines whether a PlatformSensorReader was successfully created. The kErrorGetMinReportIntervalFailed (which is not fatal) and kErrorISensorWinrtStaticsActivationFailedcases (which is fatal) cases should have been swapped. This is causing a non-null PlatformSensorReader to be returned, but the underlying WinRT sensor object was null which triggers a null pointer deference the next time it is used. The fix is to swap the switch cases. Verified by running the new unit test. Bug: 1020987 Change-Id: Ia9ac960fb95de0b028677c1ff97b632aecd0b6f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904503 Commit-Queue: Wenjie Shi <wensh@microsoft.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#713672}
-
Daniel Rubery authored
Extend the lifetime of ZipFileSuccess, because the current status is somewhat surprising to me (only 85% extract successfully). crbug/1022564 has been opened to track the investigation into this fact. Fixed: 1021142 Change-Id: I34670e18c13ceeef98800b48be1fdda1492fae22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904621 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#713671}
-
- 07 Nov, 2019 25 commits
-
-
John Rummell authored
QueryOutputProtectionStatus() should report that a MediaRecorder is capturing audio/video streams. This adds a test that sets up a MediaRecorder using getDisplayMedia() to provide the stream, and verifies that the query does detect it. ClearKey CDM updated to periodically query for changes, and if a network link is detected, generate a keystatuseschange event with a dummy key ID and status 'output-restricted'. Bug: 856276 Test: new browser_test passes Change-Id: I3f9f200dded6647ec9526d929b962b3ccfae1d7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894356 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#713670}
-
Vladimir Levin authored
A recent change for intrinsic-size forgot to update the enums.xml file. (crrev.com/ae891958) This patch updates said file. R=chrishtr@chromium.org Change-Id: I332d69cfdf1974e709bf6c9d3c14a998c51c38f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904498 Auto-Submit: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#713669}
-
Matt Menke authored
Somehow managed not to delete it in when I removed it from net/BUILD.gn in https://chromium-review.googlesource.com/c/chromium/src/+/1869725. Bug: 934009 Change-Id: I1a85d090064e472e04d9f7d9767d6f5399a767b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903830Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#713668}
-
Ionel Popescu authored
This CL removes the rounded corners and padding for select options to avoid exposing the underneath background of the select. The new behavior is validated by select-popup-appearance-basic.html and by new tests added in select-multiple-appearance-basic.html Bug: 1021227 Change-Id: I6e6c45fc6627187f18511e0409ca0e20e07e1d29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902525 Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#713667}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/27a3d31d7a9d..d9ed1c2732ba git log 27a3d31d7a9d..d9ed1c2732ba --date=short --no-merges --format='%ad %ae %s' 2019-11-07 sugoi@google.com Prevent rasterizing fragments outside the framebuffer Created with: gclient setdep -r src/third_party/swiftshader@d9ed1c2732ba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141999739 Change-Id: I281ee29a1bb2124be08fba5ad65fe00923530a16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904608Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713666}
-
Hongchan Choi authored
As suggested in: https://chromium-review.googlesource.com/c/chromium/src/+/1903756 TBR=sky@chromium.org Bug: 1022319 Change-Id: I31474c0f0242ca5177ef2bfca9b2415c6448f437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904543Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Auto-Submit: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713665}
-
Chris Blume authored
SurfaceAggregator's call to AddColorConversionPass() currently happens on all platforms. But it should be a no-op on every platform except Windows. On other platforms, there is a proper gamma curve. But on Windows it is linear. This results in color values that are outside an acceptable threshold. That is why a color conversion is necessary. The intent was for this to only happen on Windows. This CL matches that intent by explicitly marking that function call as only happening on Windows. Change-Id: I66ebf3b42b84729e6062ff738c25d903aac2dc5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900286Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#713664}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a9c5d494..29e8c96f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifab465b945682f6272f0f3f0ac38bb56a450cc59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904668Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713663}
-
Takumi Fujimoto authored
Fix histogram names that got swapped around during a refactoring. Change-Id: I8f680a9c0ae28ab287656fea1981f26bd338f712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904540 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Auto-Submit: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#713662}
-
Michael Crouse authored
This change allows the folder that an optimization guide store uses to persist its data on disk in. A future change will create a store with a folder for only the prediction model and host model feature data to be held. Bug: 1001194 Change-Id: I0f03fea562a69eb8ddc4ea3f7e69ee2f1a999162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904612Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#713661}
-
Donn Denman authored
Adds side-shadow assets to the Overlay in the new layout that already has rounded corners. These assets just add a shadow, so there are no dark versions needed, and we just have one side (using code to flip it for the other side). Binary-Size: +2K for the side shadow assets. BUG=1005975 Change-Id: I31ebf657b2e9f49822c5aeb525b655c91d9b81aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895924 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#713660}
-
Christopher Cameron authored
This is now in a good enough shape to turn on. The remaining work is to add tracking to ensure that we open the most-recently-used profile on launch. Bug: 982024 Change-Id: Ib6b922a1ebca043a6c8f8eb2ded2cd3c837cc80d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902866 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#713659}
-
Jinsong Fan authored
Since ContentVideoView has been removed for a long time, kUseContentVideoView is no longer used. The CL removes it and related codes, replaces the switch::kUseAndroidOverlay by the switch::kOverlayFullscreenVideo everywhere. Bug: None Change-Id: I95e9d6ec33fd8027914770cd5224163018fd6399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890510Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#713658}
-
Rob Schonberger authored
This CL adds a featureparam for experimental updates of radius polynomial - and adds a parser for the string value. The parser is tested both via the factory and as a standalone - which is why it's placed in a separated namespace rather than the natural anonymous namespace. Bug: 1009290 Change-Id: I8d9edcd9c8267f6d85026f79bd30dc22cacefbc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903108Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#713657}
-
Matt Menke authored
An earlier CL of mine made each run parse the input string twice, which slowed things down enough to make libfuzzer (which already runs each input through the fuzzer twice) sad. Bug: 1019151 Change-Id: Iee963f40c9bf30a24a77961be4cef8ca64b3c20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903964Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#713656}
-
Sara Kato authored
Bug: 904383 Test: manual (follow repro steps on bug, and observe expected behaviour) Change-Id: Ia60c2ec1a0891ca4c42a5b1ff79aff17aad06fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903175Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#713655}
-
Mike Dougherty authored
Bug: 987646 Change-Id: Ibdb5b6b7393fbdc3593c498d52f4d595872a3647 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903839Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713654}
-
George Zhang authored
Remove unsigned int typecasts. Bug: 1012072 Change-Id: I05a38c48f3c5415b209d89c396ed3a25545d88f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902566 Commit-Queue: George Zhang <zhanggeorge@google.com> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#713653}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4e10964bf967..a942a9f9a235 git log 4e10964bf967..a942a9f9a235 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 vapier@chromium.org patch: drop chromeos/cbuildbot/git/fetch_count metric Created with: gclient setdep -r src/third_party/chromite@a942a9f9a235 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I945abc5926b4e4fb85143fb2fbe19713d67609d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904622Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713652}
-
Alexander Nohe authored
We changed the focus ring on eject button activation to be hidden. This ensures consistency with other button behavior within the files app. We swapped the original eject button (<button>) for a cr-button, a polymer element. This simplifies the eject button implementation by removing a nested HTMLElement since the ripple effect is contained within the polymer element (<cr-button>). Bug: 1006198 Change-Id: I5fc60a28db9bbd8166420fe50ef89bd88facdc1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830218Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#713651}
-
David Grogan authored
There was a blank space before each test name when copying plain text report. Before: ` css3/flexbox/flex-flow-auto-margins.html` ` external/wpt/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html` Now: `css3/flexbox/flex-flow-auto-margins.html` `external/wpt/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html` Change-Id: I4195af5f95347754bcfabefed04c9ce3cd387993 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904351Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#713650}
-
Khushal Sagar authored
GLHelper assumes that the texture used in readback with it is always GL_TEXTURE_2D which is not the case for resources creates for canvas2d elements on mac using GL_TEXTURE_RECTANGLE_ARB. R=ericrk@chromium.org, guidou@chromium.org Bug: 1020796 Change-Id: Ic5a4b8e0ba5a0d61a8af43251438f5323b911fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902506 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#713649}
-
Wei-Yin Chen (陳威尹) authored
Bug: None Change-Id: I41bf85b61e1cf79dfe9e048da8d1a13c96f0f144 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903618 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#713648}
-
Brandon Wylie authored
When both the search engine logo and the identity disc are enabled, the urlbar placeholder text is clipped. This change removes the end padding of the location bar to prevent that clipping. Bug: 1019019 Change-Id: Ie02ef36f784a13a06e978cd7b8210c7ffbd36ab6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885556 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#713647}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic027fcccdc59257500b38649fceb4d6f656f766e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904610Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713646}
-