- 19 Oct, 2018 40 commits
-
-
Aldo Culquicondor authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7d2dbc7816dca5ada17ca444c8c61093a86f6fb8 Reviewed-on: https://chromium-review.googlesource.com/c/1280605Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#601187}
-
Scott Violet authored
on single-process mash (interactive ui tests). It's flaky. BUG=897058 TEST=test only change TBR=mukai@chromium.org Change-Id: I1eaea1ca641f01d4d8e2fb749e497d11c7ec6b1e Reviewed-on: https://chromium-review.googlesource.com/c/1291690Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601186}
-
Bo Liu authored
Change-Id: I67bf19c8225d76d2f1b383597af14627cce2f669 Reviewed-on: https://chromium-review.googlesource.com/c/1291529Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601185}
-
Evan Stade authored
Adds a single-item context menu for Hosted app windows (teleport window). This is currently only supported in single process Mash because multi user window manager doesn't work in multi process Mash. Bug: 887051 Change-Id: Ifd1c7a08acf46615ff5fec2f0e7a614c9c99775c Reviewed-on: https://chromium-review.googlesource.com/c/1287202Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Camille Lamy authored
This CL makes sure we do not attempt to rewrite a subframe navigation URL in should only be performed on main frame navigations. NavigationControllerImpl: :CreateNavigationRequestFromLoadParams. Rewrites Bug: 895065, 803859, 896028 Change-Id: I2a2326d802b55655d59f0c6d3d73e3060c58152b Reviewed-on: https://chromium-review.googlesource.com/c/1282992 Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601183}
-
Scott Violet authored
Currently clients of window-service forward KeyEvents to IME. Ash was doing the same, resulting in KeyEvents destined for remote clients going to IME twice. BUG=891489 TEST=none Change-Id: I315c84399cfb9d8adf39ae9f3eb6c50d222f22c4 Reviewed-on: https://chromium-review.googlesource.com/c/1290194Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601182}
-
Fady Samuel authored
Now that we don't do temporary reference ownership, SurfaceObserver::OnSurfaceCreated doesn't do anything useful. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I6e9cf4557c10f50f097cd02c78fb3bd688cfc9d6 Reviewed-on: https://chromium-review.googlesource.com/c/1291216Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601181}
-
danakj authored
Child local roots (ie OOPIF) widgets will CloseWebWidget() synchronously in the IPC handler for OnClose(). Then they post-task the Close() action. The Close() action will also CloseWebWidget() but it does other work first. To keep the order consistent, move code above CloseWebWidget() into the method so both paths close things in the same order. R=ajwong@chromium.org, avi@chromium.org Change-Id: I0a5ac711b8ee17879483a1c37fab3d6d5176f798 Bug: 419087 Reviewed-on: https://chromium-review.googlesource.com/c/1290129Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#601180}
-
Sorin Jianu authored
This is a mechanical change. Its purpose is allowing different wire protocol parsers and serializers to be injected in the UpdateChecker and PingManager instances in the UpdateClient using the Configuration instance. The current code hardcodes an instance of ProtocolHandlerXm. There is work in progress to support JSON. Bug: 881076 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I40cb1605f134a5d3f168a511094b2b265bc50f25 Reviewed-on: https://chromium-review.googlesource.com/c/1289510Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601179}
-
David 'Digit' Turner authored
Normally, compiling Android resources requires unpacking and processing resource dependencies into a temporary directory before sending the result to 'aapt2 compile', then getting rid of these intermediate files. To help debug issues related to Android resource compilation, this CL introduces a new GN variable that can be set in your args.gn, to force the build to put all such build directories under a top-level directory, and not removing intermediate files in it. This should allow inspecting the intermediate files to better understand what's going on. This is needed to debug issues that appeared in my attempt to change the resources stored in APKs versus bundles, e.g.: https://chromium-review.googlesource.com/c/chromium/src/+/1270947 BUG=879228,882860,897056 R=agrieve@chromium.org, estevenson@chromium.org,yfriedman@chromium.org Change-Id: I76c79a893b0bbdb56ba685f4304da929d11c7e05 Reviewed-on: https://chromium-review.googlesource.com/c/1288436Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#601178}
-
Daniel Bratell authored
Some headers appeared twice in some sources list. This confused some other tools so it seems like a good idea to only have them there once. Change-Id: Ifa0c7b2e0fbb8b7ec401bad2737384cffa3d940a Reviewed-on: https://chromium-review.googlesource.com/c/1290949Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
-
Peter Kotwicz authored
This CL removes the handling of the com.android.browser.headers intent extra in WebappActivity. The handling was added in https://chromium-review.googlesource.com/c/chromium/src/+/1116219 at the time that TWAs used WebappActivity. They no longer do so. BUG=871266, 801487 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ife40f882f45900f33ff356c435ee1a9283a4419e Reviewed-on: https://chromium-review.googlesource.com/c/1288012Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#601176}
-
Scott Violet authored
This adds the ability to register a callback on a KeyEvent that is called when async processing completes. This is important for content as key events may be handed to the renderer, which means the event is asynchronously processed. BUG=891489 TEST=none TBR=sadrul@chromium.org Change-Id: I1dc0ae3768c61eac7bd5edadf0be8562dae8b1d3 Reviewed-on: https://chromium-review.googlesource.com/c/1290069Reviewed-by:
-
Lukasz Anforowicz authored
This CL: 1. Transitions core CORB test coverage away from the fetch API (where blocking by OOR-CORS can interfere with test results) to triggering fetches via <img> tags (where CORB stays applicable even after OOR-CORS ships). Tests covering CORS/CORB intersection continue to be done via fetch API (in CrossSiteDocumentBlockingTest.BlockFetches test). Verification of response body no longer depends on disabled web security (and inspecting fetch API results), but is instead done via RequestInterceptor helper that lives next to the tests. The CL also uncovered and fixes a threading issue in the implementation of RequestInterceptor. 2. Stops testing range requests in content_browsertests and starts to rely on existing and new test coverage in content_unittests (fetch API seems to be the only directly-test-controllable way of making range requests). I've tested this CL by manually running CrossSiteDocumentBlockingTest from content_browsertests 1) in default mode, 2) with NetworkService enabled and 3) with NetworkService and OutOfBlinkCORS enabled. Bug: 870173 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iec5c9f0e7ddad0ff02627b88dcfab276795e7be9 Reviewed-on: https://chromium-review.googlesource.com/c/1279351Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Sky Malice authored
Specifics: +737,771 bytes normalized apk size +5 zip entries file count +62,432 bytes main lib size +454,572 bytes main dex size InstallSize: +285,833 bytes APK size +817,682 bytes Estimated installed size (Android Go) +2,122,304 bytes Estimated installed size InstallBreakdown (+2,119,225 bytes): +2,634 bytes unwind_cfi (dev and canary only) size +1,930 bytes Non-compiled Android resources size +62,432 bytes Native code size +364 bytes Package metadata size +2,036,261 bytes Java code size +15,604 bytes Compiled Android resources size Dex: +2,312 entries fields +3,224 entries methods +758 entries types +1,608 entries strings Change-Id: I11d8256a8a571169e0a39892e6c99ab6f8282629 Reviewed-on: https://chromium-review.googlesource.com/c/1290201Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#601173}
-
Ben Wagner authored
Specifies the cross product of '@font-face font-feature-settings', 'font-variant-ligatures', 'letter-spacing', and 'font-feature-settings' with various values to test feature precedence with respect to ligatures. Bug: chromium:894954, chromium:896033, chromium:450619, chromium:443467 Change-Id: I182ce477fd0ec5dd5070c540460b1ee4e1148b8a Reviewed-on: https://chromium-review.googlesource.com/c/1289729 Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#601172}
-
chrome://creditsPeter K. Lee authored
Bug: 884663 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0075911b60df18873c8c64db17d3455d567e9ea6 Reviewed-on: https://chromium-review.googlesource.com/c/1236661Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#601171}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/0e68bb36327c..67ebe3f7aebe git log 0e68bb36327c..67ebe3f7aebe --date=short --no-merges --format='%ad %ae %s' 2018-10-19 stevenperron@google.com Add custom target to wrap around custom commands. (#1986) 2018-10-19 greg@lunarg.com Fix ADCE to treat OpUnreachable correctly during liveness analysis (#1984) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@67ebe3f7aebe The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I2efc4ff24e4f8f11ee84cca38316fd534c2e3466 Reviewed-on: https://chromium-review.googlesource.com/c/1291156Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601170}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a4c3ebaca5a9..4bcf107ea529 git log a4c3ebaca5a9..4bcf107ea529 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 titovartem@chromium.org Add units for Ampers, Volts, Hertz, bytes per second Created with: gclient setdep -r src/third_party/catapult@4bcf107ea529 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I219847965f9753d4ad032a9d41ea23baf483fdb5 Reviewed-on: https://chromium-review.googlesource.com/c/1291157Reviewed-by:
-
Xida Chen authored
No behavior change. Bug: None Change-Id: Ifc1874c520d7d6f03f674f5fb228cdeec3bc9b7d Reviewed-on: https://chromium-review.googlesource.com/c/1291214Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601168}
-
W. James MacLean authored
Revise float comparison tolerance since it seems SyntheticTouchscreenPinchGesture is fairly imprecise sometimes in the final page scale factor. TBR=kenrb@chromium.org Bug: 897062 Change-Id: Ibd6470eb190f90deeff709f333c058d4c4367a1e Reviewed-on: https://chromium-review.googlesource.com/c/1291353Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#601167}
-
Takuto Ikuta authored
Currently we require Xcode 10.0+ https://chromium.googlesource.com/chromium/src/+/HEAD/docs/ios/build_instructions.md#System-requirements So no need to have xcode version check. Cq-Include-Trybots: luci.chromium.try:ios-device-xcode-clang;luci.chromium.try:ios-simulator-xcode-clang;luci.chromium.try:ios12-sdk-simulator Change-Id: Ia5f3dfc45979dda917666bbfaa804f1308f74dd0 Reviewed-on: https://chromium-review.googlesource.com/c/1290572 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601166}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/759a2673ff90..4b8db890c4ee Created with: gclient setdep -r src-internal@4b8db890c4ee The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I37d6871cae3e501a305e8d899ce3ed0af0fbdccc Reviewed-on: https://chromium-review.googlesource.com/c/1291152Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601165}
-
Alex Clarke authored
Currently it only tests SingleThreadTaskRunners Change-Id: I73997d105d74b31a1b52b85fd076b81ff99e7958 Reviewed-on: https://chromium-review.googlesource.com/c/1290985 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601164}
-
Liquan(Max) Gu authored
The original implementation does not report an update to performance timing when the number of nodes is reduced to 0. This CL is to correct this behavior. Bug: 869924 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iff578e793965ae89f0e865f175335bb9a318fb9c Reviewed-on: https://chromium-review.googlesource.com/c/1289702Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#601163}
-
Jialiu Lin authored
Also made some adjustment to child_account_service_unittest and user_policy_signin_service_unittest to better simulate the sign-in state to avoid hitting a DCHECK in IdentityManager. Bug: 890882 Change-Id: Id76e2cd962904352bf0bdf86ff1fb5d6714573ae Reviewed-on: https://chromium-review.googlesource.com/c/1258162Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#601162}
-
David Bokan authored
chrishtr@ pointed out in https://crrev.com/c/1038648 that the paint order selection used when multiple elements on a page meet all the criteria of an implicit root scroller isn't correct. On reflection, it's not immediately clear to me that this is at all useful so, rather than adding complexity, this CL removes the ordering and just avoids making any decision at all in this case. We can revisit if the need comes up in real usage. Bug: 844534 Change-Id: I4e05da981eace4062f3898a3a7fe1d4cffdec658 Reviewed-on: https://chromium-review.googlesource.com/c/1288905Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601161}
-
Emircan Uysaler authored
This CL moves frame checks from WebMediaPlayerMS to WebMediaPlayerMSCompositor so that they happen after |current_frame_| is updated via SetCurrentFrame(). Bug: 894317 Change-Id: I93ea3160cee18fb012d3fd6c7c32fb5fe935868f Reviewed-on: https://chromium-review.googlesource.com/c/1289751Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601160}
-
Eduard Satdarov authored
Enabled LocalSyncTest.ShouldStart only on Window. Added command line for local sync backend dir in order to avoid problem with swarming tests. R: mastiz@chromium.org, treib@chromium.org Change-Id: Ia0ef5622bc8cc003e1f2b7f61eabbdae6ccff137 Reviewed-on: https://chromium-review.googlesource.com/c/1290981Reviewed-by:
-
Morten Stenshorne authored
These tests change the width of the container back and forth. In one of the tests all children have fixed inline-size. In the other test they have inline-size auto. Change-Id: I4324d06b5f6df39f613937cedc85bf947bc4df9d Reviewed-on: https://chromium-review.googlesource.com/c/1290976Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#601158}
-
Ryan Harrison authored
This CL changes the ICU collator being used for text searching in the PDF viewer from the default to the 'search' one. This is the same collator used in Blink, and it folds together similar looking characters in a locale specific way, so that things like accented and unaccented vowles will match or not match dependent on the expectations of the user locale. Additionally, when searching single and double quotation characters are being simplified to the ASCII forms of them to make matching between defferent types of quotes work better. Quotation marks are a known limitation of the search collator and this workaround is based off a similar solution that exists in Blink to improve matching. BUG=chromium:142627 Change-Id: I399ea1f0bacb58434b468866127a91ccb6213e99 Reviewed-on: https://chromium-review.googlesource.com/c/1281178 Commit-Queue: Ryan Harrison <rharrison@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#601157}
-
Aldo Culquicondor authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I44fc041457ce218766c05239acf5d7d46005b0a6 Reviewed-on: https://chromium-review.googlesource.com/c/1291349Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#601156}
-
Colin Blundell authored
Will shortly be needed by an //ios/chrome port of IdentityTestEnvironmentProfileAdaptor. Bug: 895772 Change-Id: Icb7478cfc51d6bd7f6061eeab5d1ced66fe1e1a7 Reviewed-on: https://chromium-review.googlesource.com/c/1290954Reviewed-by:
-
Geoff Lang authored
BUG=892288 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0619a87cc2babbc2e3f9e33135bb883a51d2d9c1 Reviewed-on: https://chromium-review.googlesource.com/c/1262429 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#601154}
-
Thomas Tangl authored
The profile card title in the user menu is fixed for non-syncing users that are offline. Bug: 897078 Change-Id: I041cf8296d0ab8b77f0bd8b082cf8f03e418828f Reviewed-on: https://chromium-review.googlesource.com/c/1290913 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#601153}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7a5d83bcb62f..429fb7c2bca7 git log 7a5d83bcb62f..429fb7c2bca7 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 fmayer@google.com profiling: Use total size in heap dumps. Created with: gclient setdep -r src/third_party/perfetto@429fb7c2bca7 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I0ec1c260dfdae9362d80c543f50334a9aafc210f Reviewed-on: https://chromium-review.googlesource.com/c/1291154Reviewed-by:
-
John Abd-El-Malek authored
Similar to the Set-Cookie case in r600570, Cookie headers can't be read/written by webRequest handlers when the network service is enabled. Instead of sending the GAPS cookie from C++ to JS which then sets it in the webRequest callback, have the C++ code directly write it to the temporary storage partition for login using CookieManager interface. Bug: 887061 Change-Id: I50acfb324e830f42d6a0d53ed32aa63e48aaab3a Reviewed-on: https://chromium-review.googlesource.com/c/1289960 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Yi Su authored
Find the OSDD(Open Search Description Document) <link> in web pages and return it's URL. This is one of methods that recognize a web page as a search engine. Bug: 433824 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I2c6d31bf48a9de4aedfe884147e55150c0ee23b9 Reviewed-on: https://chromium-review.googlesource.com/c/1290934 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#601150}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1bccae517ace..cf5c51bcd364 git log 1bccae517ace..cf5c51bcd364 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 reed@google.com remove unused flags -- no clients define these 2018-10-19 ethannicholas@google.com error when draw ops do not go through addDrawOp 2018-10-19 mtklein@google.com cut out another batch of old xfermodes Created with: gclient setdep -r src/third_party/skia@cf5c51bcd364 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I3eb68b170e44270a1c30bdceea29676a99977e2c Reviewed-on: https://chromium-review.googlesource.com/c/1291155Reviewed-by:
-
Nasko Oskov authored
The current window.open() implementation on the browser side is using OpenURL to navigate when the opener is suppressed (e.g. 'noopener') and URL is specified. This results in the navigation being sent up to the embedder and come back to content. Since the default parameters being constructed should not cause the embedder to make any changes to the navigation, it should be safe to skip the extra code and directly navigate the new window. This CL adds LoadURLParams storage to WebContentsImpl and implements all navigations of window.open() that are started browser process side to use NavigationController::LoadURLWithParams. It effectively short-circuits the unnecessary trip to the embedder. Bug: 882053 Change-Id: I09120397f3a6e7856e76ba0448d0bdff807f7628 Reviewed-on: https://chromium-review.googlesource.com/c/1286194 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601148}
-
