- 03 Nov, 2020 40 commits
-
-
Elly Fong-Jones authored
This title provides the only display of which origin is requesting the permission in question, so it should be accessibility-focusable to allow the user to focus it and navigate within it, select it, etc. Bug: 1099327 Change-Id: I4f8038f2623a79d10ba18cdd809b202110bc55ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515182Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#823620}
-
Xiaocheng Hu authored
Currently, for each tree scope, we gather all @keyframes rules into a hash map. This may cause memory issues when we have web components that carry @keyframes rules in its style sheet. This patch makes each tree scope iterate the already stored ActiveStyleSheetVector instead, so that we can save some memory. Bug: 1141814 Change-Id: I09a1fda77f10a22376ed83a0ac7bd1f6f9f3cca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493431Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#823619}
-
Alexander Surkov authored
changes Get rid of unnecessary accessibility_tree_formatter.h includes: no sense to make useless things but it also reduce build time for accessibility_tree_formatter.h changes. Bug: 1133330 AX-Relnotes: n/a Change-Id: I1ed327ec35afb7c876d40dfdaa801f278cd3b18f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510374Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Alexander Surkov <asurkov@igalia.com> Cr-Commit-Position: refs/heads/master@{#823618}
-
cfredric authored
This ensures that we perform the same validation and canonicalization, no matter how the First-Party Set was provided. Change-Id: Ifdd76cb2d29a2a28215051a2b5b2ad6f312f95aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510233Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@google.com> Auto-Submit: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#823617}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 18 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2021-02-01. TBR=chromium-metrics-reviews@google.com Change-Id: I42e0ae1d77f773120f1f5be2f486941e4074ff2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517883Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#823616}
-
Filip Gorski authored
Launch on ToT was requested based on go/clank-sro-incognito-metrics Bug: 894211 Change-Id: Ib333df7ab99104b8ed9325b3bcb433c27c753b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510355Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#823615}
-
Gang Wu authored
This CL also create a new flag about showing Thumbnail for image search suggestions. Currently, only Android support showing thumbnail for image Search suggestions. When enabling clipboard image suggestions by default on Android in https://crrev.com/c/2485343, we inadvertently made a change on iOS to retain the image thumbnail even though it's not used on that platform. This change restores the correct behavior on iOS because the new Feature is disabled there. Bug: 1056501 Change-Id: Idaa1f292e4ff98564035d6eabe64a7d9b8df6d3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2501073 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
-
Andrey Kosyakov authored
Bug: 1140420 Change-Id: Ia2b704e0e2146dfb7e71406126e101c06fbffd5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514800Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#823613}
-
Yao Xiao authored
2 tests were disabled recently as they were flaky on builder "Linux TSan Tests". That's because when the tests finish, there is still a pending history query, and on the history backend thread there is a check for the feature kHideFromApi3Transitions (also introduced recently). If the check occurs after the ScopedFeatureList is destroyed, then there is a data race and would fail the sanitizer. This CL moves the |feature_list_| member to the test class before the |history_service_| member, and initialize it in the test constructor. This ensures it will only be destroyed only after |history_service_| is destroyed. This CL also removes the FlocIdComputedEventLogging feature initialization in the test, as it's already enabled by default. Bug: 1143855 Change-Id: I6b7141a0bf9000ac453768828be1d6a35218a079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512846Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#823612}
-
Liviu Tinta authored
This is a reland of 365f1d94 I am waiting for action sequence to finish and for the event to execute before terminating the test. Original change's description: > WPT to check click/auxclick/contextmenu are pointerevents > > Verify that the user agent returns click/auxclick/contextmenu as pointerevents. > > Bug: 989958 > Change-Id: I02757ef704b605471614829177cba24a73b6c8db > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513801 > Commit-Queue: Liviu Tinta <liviutinta@chromium.org> > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823332} Bug: 989958 Change-Id: Icf79feebe63a3f2b94b3837dedfa68a4574927a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515051Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#823611}
-
Vikas Soni authored
Increase SurfaceControl transaction ack hang detection timeout from 1sec to 5sec. Bug: 1037760 Change-Id: I0402c3c641f814b6388d2b08798d96bacfa4926e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515227 Commit-Queue: vikas soni <vikassoni@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Auto-Submit: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#823610}
-
Clemens Arbesser authored
Bug: b/171776026 Change-Id: Iae2f60159b3ee6e1d912aa2a37aad238ffe8597b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517721 Auto-Submit: Clemens Arbesser <arbesser@google.com> Commit-Queue: Marian Fechete <marianfe@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#823609}
-
Maciek Slusarczyk authored
This CL adds stats for SAML password sync token API calls. We use the standard UMA framework and record basic token operations as well as API errors. Bug: 1112896 Change-Id: I280c966a257db6600c9a7734b6c74c88a5d4630a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513207Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maciek Slusarczyk <mslus@chromium.org> Cr-Commit-Position: refs/heads/master@{#823608}
-
Noam Rosenthal authored
The UseCounter is counted when offsetX/offsetY/layerX/layerY is requested, and the target element is rendered inline. Bug: 1054515 Change-Id: Ie584a9070edce2748537edd06b8b8f2f27efe0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517020Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#823607}
-
Peter Kasting authored
Bug: 772945 Change-Id: Idc5e97a2f8161f6e673a75352c4a398b990a7a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515940 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Matthew Wolenetz authored
This reverts commit 341aef47. Reason for revert: Tree-closing compilation failure. For example, https://ci.chromium.org/p/chromium/builders/ci/Win%20x64%20Builder/96007? ../../remoting/host/win/etw_trace_consumer.cc(119,11): error: use of undeclared identifier 'thread_checker_' DCHECK(!thread_checker_.CalledOnValidThread()); ^ ../../remoting/host/win/etw_trace_consumer.cc(125,11): error: use of undeclared identifier 'thread_checker_' DCHECK(!thread_checker_.CalledOnValidThread()); Original change's description: > [Windows][Host][Logging] Adding EtwTraceConsumer class > > This CL adds the class which consumes the ETW events from > Windows. The class is fairly straight-forward but there > is one interesting bit as the call to consumer events > blocks us from running tasks on that thread. In order to > receive events and not block any of the existing threads, > we create a new AutoThread which we use to listen for and > handle events on. When it is time to clean up, we unblock > the listening thread by stopping the trace session. > > Future CLs will add the logic needed to parse the events > and redirect the output to a new location (likely based on > registry settings). I've kept that out of this CL to keep > its size on the smaller side. > > Bug: 1144185 > Change-Id: Ibf494251d0929a1741cb2796f26d69d258d96a64 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515140 > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Commit-Queue: Joe Downing <joedow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823596} TBR=jamiewalch@chromium.org,joedow@chromium.org Change-Id: Id754b4ac043c4ae34196e6df3e2b621b60673591 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1144185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518104Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#823605}
-
Yann Dago authored
Extended the Enterprise.Policies.SourceConflicts and Enterprise.Policies.IgnoredByPolicyGroup histograms. Bug: 1084092, 1125834 Change-Id: I113b93ae2c452a63fb77d31e4dfe9b06fda40b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508261 Auto-Submit: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#823604}
-
Lily Chen authored
This adds a bool for SameParty to CanonicalCookie and updates ctor callers (mostly tests). It enforces the requirement that a canonical CanonicalCookie with SameParty must be Secure, and must not have SameSite=Strict. Cookies that violate this are rejected with a newly added CookieInclusionStatus::ExclusionReason. SameParty attribute semantics are not yet enforced. This adds same_party to the cookie attributes logged for cookie store events in the NetLog. Bug: 1142606 Change-Id: I06899aa5e24b5037e0609009aec498476a616bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506303Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#823603}
-
Krzysztof Olczyk authored
When Chromium is started with dynamic more core lib (--mojo-core-library-path=path_to_lib), the given library is used for core mojo functionality instead of the mojo core embedded in the Chromium. This switch is propagated to child processes (such as gpu process) in order for them to use the same mojo core library. Due to sandboxes, the library is loaded early for child processes and initialized in a separate step. However, if single process mode is used (--single-process) the ChildProcess class is instantiated in a thread of browser process. This results in a library being loaded twice and an adequate DCHECK. Don't attempt to load the mojo core library if ChildProcess instance is run embedded in the browser process. Change-Id: Ic22d612481b62ccc6b1d07fa245b56bde55e42d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517460Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Krzysztof Olczyk <kolczyk@vewd.com> Cr-Commit-Position: refs/heads/master@{#823602}
-
Emircan Uysaler authored
This CL fixes an earlier error where we might be pushing nullptr reference into a vector. Bug: 1144967, 1127984 Change-Id: Id80dc38b7ba7611661c080fa404e2fa7c69a762a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517601Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Auto-Submit: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823601}
-
Mohamed Heikal authored
BackgroundTaskSchedulerExternalUma#toUmaEnumValueFromTaskId is used by child classes but gives a lint warning. Fix the lint warning by explaining to lint it was supposed to be protected not private. Change-Id: I1f1cf080cf0750aaea1fdf94b1972b0f70e134b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514963 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823600}
-
Koji Ishii authored
Currently |LayoutNGBlockFlowMixin<Base>::AddOutlineRects| falls back to legacy when NG block fragmented. This should be implemented in NG. This patch replces with |GetPhysicalFragment| without changing the behavior for now. Investigation: https://docs.google.com/document/d/1Yx7iGeHA2bTZory9kpA2NJNd-nMplGlUIEJl7gglqVo/edit?usp=sharing This patch has no behavior changes. Bug: 1061423, 1145048 Change-Id: I22d0e6b3f000060c01e3314e835cb693f2fdd87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514940Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#823599}
-
Christopher Cameron authored
This avoids re-parsing the ICC profile in the GPU process. The drawback is that we go back to the behavior that we had (just a few weeks ago) of ignoring the custom color profile for capture content. Of note is that specifying AVCaptureColorSpace_sRGB to the capturer results in the same gamma=1.961 color space (with the sRGB primaries). Also of note is that the alternative constant of kCGColorSpaceITUR_709 is not used because it has a substantial difference from gamma=1.961 in darker colors. Bug: 1143477, 959962 Change-Id: Id5d794ba05801cd6d54a79bd3a3f9cc292537eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515235 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#823598}
-
Yury Khmel authored
This to keep in sync with go/ssufd Main reasons are: * v5.4 reading of this file is slow. * file forwat has been changed and it is not clear for now how to deal with it. BUG=b/170215628 TEST=Locally on eve-kernelnext Change-Id: I80e17014a5bdb67d13b3089e8cd09b5c4bc29612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516242 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823597}
-
Joe Downing authored
This CL adds the class which consumes the ETW events from Windows. The class is fairly straight-forward but there is one interesting bit as the call to consumer events blocks us from running tasks on that thread. In order to receive events and not block any of the existing threads, we create a new AutoThread which we use to listen for and handle events on. When it is time to clean up, we unblock the listening thread by stopping the trace session. Future CLs will add the logic needed to parse the events and redirect the output to a new location (likely based on registry settings). I've kept that out of this CL to keep its size on the smaller side. Bug: 1144185 Change-Id: Ibf494251d0929a1741cb2796f26d69d258d96a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515140Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#823596}
-
Peter Wen authored
Downstream(s) can define their own additional_lint_targets to be included in the general "android_lint" target. Bug: 1078229 Change-Id: I7c2cb50ef644dd700639860feda8ec9b9f793cc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512526Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823595}
-
Omar Morsi authored
Change-Id: Ica5f90107d05bca69ecfb44b652ca24d35a3bf81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516699 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#823594}
-
Alexander Timin authored
R=eseckler@chromium.org Change-Id: I7773289dc53065c27f7ac12bb73f299f67d40b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517581 Commit-Queue: Alexander Timin <altimin@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Auto-Submit: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823593}
-
Reilly Grant authored
Change-Id: If163eb94a69d8b3743658b84009027dbf80f1f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514241 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#823592}
-
David Dorwin authored
Use will follow in a separate CL. Bug: 1145025 Change-Id: Ib0d302120256c080f73db36d66c29ad60ab4d14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516246 Commit-Queue: David Dorwin <ddorwin@chromium.org> Reviewed-by:
-
Mohamed Heikal authored
The extra_application_definitions is still used by downstream manifests even if not used upstream. Change-Id: I610bb6c50df2ed828c503b4567c1bc0bfc3a8f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517624Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#823590}
-
Alexander Lapshenkov authored
For GCC 8.4.0 is important to get all the first initializer in designated init-list in case of implicit construction. Correct compile if use explicit construction. Error example (GCC 8.4.0): -c ../../ui/events/platform/x11/x11_event_source.cc -o obj/ui/events/platform/x11/x11/x11_event_source.o ../../ui/events/platform/x11/x11_event_source.cc: In function ‘void ui::{anonymous}::InitializeXkb(x11::Connection*)’: ../../ui/events/platform/x11/x11_event_source.cc:78:4: error: no matching function for call to ‘x11::Xkb::SelectEvents(<brace-enclosed initializer list>)’ }); Change-Id: I80ea8d5f0a14bb8edc1e89e66eb6d1034bd1fec3 Bug: 819294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516219Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#823589}
-
Elly Fong-Jones authored
Instead, have HUDDisplayView::Toggle explicitly create and configure a WidgetDelegate. This change also adds callbacks for widget initialization steps to WidgetDelegate. Bug: 1075649 Change-Id: Ia48270e7d7431abbfdf0c6d58988d4846a1ed8c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511409Reviewed-by:
-
Leo Lai authored
We are deprecating attestation methods by CryptohomeClient. This CL also includes a simplied flow by consolidating TpmAttestationDoesKeyExist and TpmAttestationGetCertificate, of which results come from the same methods of attestation service anyway. BUG=b:158955123 TEST=chromeos_unittests. Change-Id: I29734d7a2b5546e60f9af599c656ade7dc6ea210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513949 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#823587}
-
James Vecore authored
This is Nearby Share launch bug where the discussion for this change happened: https://crbug.com/1071222 Change-Id: I2c15ad2377016b9c9bd5001f7549c1be45dc67e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512548 Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
-
Clemens Arbesser authored
This adds the UI only. This is not yet functional, because the link to native is not yet implemented. I plan to submit the necessary native CLs first and then do the required JNI plumbing to stitch everything together. Keeping things separate makes for easier developing and (hopefully) reviewing. See screenshot of the UI in the attached bug. Bug: b/171776026 Change-Id: Ic7da1904a6a3c33d19c780c7dd5b9450599ba443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510053 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Reviewed-by:
-
Ben Mason authored
Bug: 1131716 Change-Id: Ief5778daf229c1da55f78c8b58a13f0e9f49d1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517699Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#823584}
-
Mohsen Izadi authored
Currently, as soon as we notice a frame needs to be produced while processing an event, a copy of its EventMetrics is saved for reporting. The plan is to add the timestamp of when the processing of the event is done (on both compositor and main threads) to this object to be included in reports. To allow this, the copy of the object should be saved after the processing is done and the timestamp is added. This CL changes EventsMetricsManager to get a callback for its scoped monitor instead of a pointer to the metrics object. The callback will be called when the scoped monitor is destroyed (i.e. when the event processing is finished). The client code can update metrics object as appropriate and return it to EventsMetricsManager if necessary. Also, if the metrics object is supposed to be saved, the client code can safely move the object to EventsMetricsManager as it won't need it anymore. Bug: 1054009 Change-Id: I503bf64171f08f8233d7f738304b0e2e3a96da31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488549Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823583}
-
Robbie McElrath authored
This CL adds the ability to specify a script in an android_aar_prebuilt rule that can modify prebuilt jar files, and adds a script to change Fragment.getActivity() and Fragment.requireActivity() to return an Activity instead of a FragmentActivity. This is the first CL in a chain that will allow us to remove the fake activity we create when embedding Fragments that cross classloader boundaries. Bug: 1123216 Change-Id: I4b9d3ca5f9c3a4d86e08d64f49d601c08fca9a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432413Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/ed8bd0453f73..d550bebee919 2020-11-03 courtneygo@google.com Fix build error with Chromium & ANGLE (#2446) 2020-11-02 dev@creatingtrouble.com Add new SpirvToolsDisassemble API interface + Improve Doc on existing API interface (#2442) 2020-11-02 justsid@widerwille.com Support for CapabilityShaderViewportIndex and CapabilityShaderLayer (#2432) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I23d0f1bd2ee18ebc9b77832e8bfb6a7e7e8df8d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517600Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823581}
-
