GitLab

The instantiation for this was removed in
https://chromium-review.googlesource.com/c/chromium/src/+/1435824/6..7/chrome/browser/metrics/antivirus_metrics_provider_win_unittest.cc
, which I think must have been in error.

Bug: none
Change-Id: I984a0f7d73b2099333a67cb14369df676e9e3db1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139113
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757131}

These use actions will show up in Breadcrumbs logs, which are the steps
to reproduce attached to the crash logs.

Bug: 1046223
Change-Id: I49d6a19fb22eebce2d939a7378179148913cc85f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138166Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757130}

Bug: 1067208
Change-Id: I7c731470111440b9f5ca1100819dff780e847172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139720Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Dominic Battré <battre@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757129}

After:
When a merchant page runs in a Trusted Web Activity that's installed
from an app store (e.g., Google Play) and the PaymentRequest is not
requesting shipping or payer contact, if it satisfies the following
conditions, the TWA itself would be included:
- the PaymentRequest supports the (TWA installer) app store's
billing method in the payment request.
- the TWA can handle pay intents.
- the TWA can handle the app store billing method.

Before:
AndroidPaymentAppFinder could not include a TWA for an app store
billing method.

Change:
* In AndroidPaymentAppFinder#findAndroidPaymentApps, check if the
merchant page is a TWA installed from app store and if the
PaymentRequest is requesting shipping or payer contact. If it is,
add the TWA itself as a payment app if it's eligible.
* remove mIgnoredMethods.

Note:
* Counterintuitively, the merchant page would send the pay intent to
the TWA instead of the Play Store, because it would be the TWA who
is responsible to interact with the app stores.

Bug: 1064740

Change-Id: I0a2f6baebae422aaeab574e3c39a10cd61fafb4a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135152
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757128}

Bug: 1067622
Change-Id: I1fddfec245cf267100f56756bc9fd38ddacb87ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137868
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757127}

This CL adds a cache config in ImageFetcherParams public API. There is
no internal change in this CL.

Also use reduced mode image fetcher for query tiles project.

Bug: 1067049,1058534
Change-Id: I3accc828e3436d71fbf801f6bdd33d934c51f091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133210Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757126}

BUG=v8:9684

Change-Id: I5ff38157fffe36f99aed05f4199544c46c66e897
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139767
Auto-Submit: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757125}

Bug: none
Change-Id: Ica79e3731938a6a342d86d072177516ae0c5ca3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136474
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757124}

This CL moves the Skia to Java bitmap conversion off UI thread.
It also adds background color support to the Paint Preview player.

Bug: 1068644
Change-Id: Ice495fe1ec2e52e7ef29ae45263679e29cd3bc7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139906
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757123}

This reverts commit deccd219.

Reason for reland: Relanding after consideration of landing
in M83 branch.

- This CL now has just the content/ changes implementing
RenderDocumentHostUserData.

- Followup CL (https:://crrev.com/c//2139814) will introduce the
first use of the new content/public API for
RenderDocumentHostUserData.

Original change's description:
> Revert "[content] Introduce RenderDocumentHostUserData"
>
> This reverts commit d2cce3a4.
>
> Reason for revert: To avoid large code changes/fixes according to the
guidelines and postponing landing this CL after M83 branches out.
>
> Original change's description:
> > [content] Introduce RenderDocumentHostUserData
> >
> > This CL introduces RenderDocumentHostUserData(RDHUD) API through which
> > we can associate data with the underlying document.
> >
> > This patch converts UsbTabHelper to use RenderDocumentHostUserData and
> > replaces existing manual tracking of frame lifetime in a map.
> > Currently a map from render_frame_host to the FrameUsbServices is
> > maintained to get the associated FrameUsbServices
> > object instead we use RDHUD to do the same set of operations.
> >
> > This document https://docs.google.com/document/d/138_67WkBaU35W_wlLUS7ux-ICM_5tosdyLOBiqvlWs8/edit?usp=sharing
> > explains in more detail on how RenderDocumentHostUserData can be
> > used and extended to different classes.
> >
> > BUG=1057611
> >
> > Change-Id: I37894f2897f4f7b2c5bbd10d422a39daba9bd0c2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055105
> > Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> > Reviewed-by: François Doray <fdoray@chromium.org>
> > Reviewed-by: Reilly Grant <reillyg@chromium.org>
> > Reviewed-by: Alexander Timin <altimin@chromium.org>
> > Reviewed-by: Jun Cai <juncai@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#754070}
>
> TBR=nasko@chromium.org,rockot@google.com,fdoray@chromium.org,reillyg@chromium.org,clamy@chromium.org,alexmos@chromium.org,juncai@chromium.org,altimin@chromium.org,arthursonzogni@chromium.org,sreejakshetty@chromium.org
>
> Change-Id: If3a7449dd9155c542bf374cd2bcbf8aec267ffdd
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1057611
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124671
> Reviewed-by: Sreeja Kamishetty <sreejakshetty@chromium.org>
> Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#754115}

TBR=nasko@chromium.org,rockot@google.com,fdoray@chromium.org,reillyg@chromium.org,clamy@chromium.org,haraken@chromium.org,alexmos@chromium.org,juncai@chromium.org,altimin@chromium.org,arthursonzogni@chromium.org,sreejakshetty@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1057611
Change-Id: I8817e26f4a21edc03471e6946ac449e97b6b8611
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137103
Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
Reviewed-by: Sreeja Kamishetty <sreejakshetty@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757122}

This tries to prevent users from accidentally triggering a context menu
option on platforms with show-context-menus-on-mouse-press.  It forces
people to wait 200 ms before the mouse release will activate the context
menu.

This is fine, but there's a better check just above in this code which
early-returns in this case, except that that check also includes a mouse
movement check -- we allow releases if the mouse moved more than 4 DIP.
This seems like desirable behavior.

Worse, the two checks have reverse conditionals, but this check uses >
instead of >=, so the "==" case is not handled equivalently by the two;
and in tests, where the "hold time" is often reset to zero (in an
attempt to disable this check) and the task environment often uses
MOCK_TIME (so press and release often have an identical timestamp), that
means this check can trigger when it shouldn't.

Bug: none
Change-Id: I25d94c9c0d793321dd872ebcac886c5eac7deb27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138234
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757121}

In ambient mode, when user interacting with the background image by
mouse or gesture, lock screen contents (login pod and media control
view) need be shown on top for users to either do re-authentication,
or media control.

This CL implements a prototype of this view transaction by:
1. Show the lock screen contents, and
2. Fade-out the current shown image.

Bug: b/149246238
Test: manually.
Change-Id: Ie31c666cdfaddefc863ff8173dc185d73ef19178
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110689
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757120}

Assistant UI and search results page in the app list view may contain
hosted native views (e.g. for answer cards, or assistant card UI
elements). These would not animate with the app list page layers,
causing glitches when app list view was animating after drag to
fullscreen or half position.

This CL updates the app list view contents animations for app list view
state change to animate windows hosted within the app list (i.e. app
list window children that have a host view property).

Along the way, this makes sure that page shadoes are animated together
with the page layers.

BUG=b:147825124

Change-Id: Ic1974b8a6767bbc25fdf96d5d6a67c41eb906fff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136845
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757119}

TBR=govind@chromium.org

Change-Id: Ib974507d0994b5d945c1e143930c2a869aec8db8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140067Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757118}

Add a new parameter for the TrayBubbleView that allows whether they
are anchored to the status tray area to be set without extending the
class, and updates the autoclick menu to take advantage of that.

Relnotes: N/A
Bug: 973719
Change-Id: I5a65afa02a4aaf8150049551ab97ced3eb425a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134956Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#757117}

File chrome\browser\policy\browser_dm_token_storage_win.cc includes
comutil.h for _variant_t but doesn't add comsuppw.lib which is required
according to MSDN:
https://docs.microsoft.com/en-us/cpp/cpp/variant-t-class?view=vs-2019

Without this change, we'll get a linking error as follows:

[2773/2779] LINK(DLL) chrome.dll chrome.dll.lib chrome.dll.pdb

FAILED: chrome.dll chrome.dll.lib chrome.dll.pdb
...
lld-link: error: undefined symbol:
wchar_t * __cdecl _com_util::ConvertStringToBSTR(char const *)
>>> referenced by .\..\..\third_party\depot_tools\win_toolchain\
    vs_files\<...>\include\comutil.h:1294
>>> obj/chrome/browser\browser/browser_dm_token_storage_win.obj:
    (public: __cdecl _variant_t::_variant_t(char const *))

Bug: 1068627
Change-Id: Iec1c323fca3664b8310e31c622e4d145bc7bc37f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140192
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757116}

This came in handy while debugging when I wanted an accurate classname.

Bug: none
Change-Id: I09c427b8ae74e5866f5262f2c76b809790e1dacc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137829
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Reviewed-by: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757115}

* Minor tweaks to comments/blank lines/etc.
* Use temps as needed
* Remove unnecessary headers
* Remove spurious RunUntilIdle()
* Remove unnecessary resets of raw pointers to null during teardown/destruction
* Init members in declaration
* Use =default where possible
* Prefer make_unique to bare new
* Prefer unique_ptr::reset() to =nullptr

Bug: none
Change-Id: Id7d0374d60519be8b65c1611b3d33a63872efee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139071
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757114}

This removes all dependencies on chrome:// from PageInfoControllerAndroid
except for the dependency on the JNI header for its java counterpart. We
can remove this once the java counterpart is ready to be moved to
components.

Bug: 1052375
Change-Id: I26e21019655d7099f89e16d481789f1afb1736d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137323
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757113}

Bug: 369206
Change-Id: I73bcffbaf87b8db84e75293d5d590bea70568ef3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137817Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757112}

Updates the expires_after attribute for 50 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 60 days of 2020-10-04.

TBR=bcwhite@chromium.org

Change-Id: Ibd3878f819cc6cadab4ed61fcdf0dd30e08048ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140211Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Cr-Commit-Position: refs/heads/master@{#757111}

Work on IsolationInfo is hopefully getting us towards getting the
browser-side one entirely right.

Bug: 1066044
Change-Id: Ib62b1f2bea2843649b2dd48a45b4d68ed3c769d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140171Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757110}

No change to logic.

This is a partial revert of commit
5d6c4ec7, to remove the histogram it
added (this metric is no longer necessary). This only keeps the
comments the original CL added to AwHistogramRecorder.

Fixed: 1066113
Test: N/A
Change-Id: I6cb270225e048c67473a288de387ec7a822ff140
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137826Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757109}

This migrates remaining DeprecatedEqual comparisons against ASCII
constants [1]. Although it is potentially web-facing, no tests are
written as suggested on blink-dev [2].

[1] https://docs.google.com/document/d/1uZ0wMBF63eLJNbW3yz1oGK7qkO3VqRUwdmNAbiLanN8
[2] https://groups.google.com/a/chromium.org/d/msg/blink-dev/sFOpNuQ91UU/3u1HxbnQCQAJ

Bug: 627682
Change-Id: I5479c236c44c61a4f722a1746fdc859983c3135b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128315Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Frédéric Wang <fwang@igalia.com>
Cr-Commit-Position: refs/heads/master@{#757108}

Spellcheck languages that have Windows platform support but not
Hunspell support (Arabic, Finnish, ...) cannot be disabled or forced
enabled by enterprise policy. This is because of the use of
spellcheck::GetCorrespondingSpellCheckLanguage in
SpellcheckLanguageBlacklistPolicyHandler::SortBlacklistedLanguages and
SpellcheckLanguagePolicyHandler::SortForcedLanguages, a method that
only recognizes Hunspell languages.

The fix is to instead check if a language with policy being enforced is
on the list of supported accept languages, as these are what are used
to populate the language list on the language settings page. Note that
in the upcoming implementation of support for non-Hunspell languages,
we will only allow Windows platform spellchecking for these accept
languages (if they have a Windows spellcheck dictionary).

Instead of just searching for the accept language within the tag, the
algorithm first tries for an exact match (so "en-CA" would be found),
then searches for an exact match for the language without locale
info, that is, what's to the left of the hyphen in a language tag
(so "ar" would be found for "ar-SA").

Also adds unit test coverage for the spellcheck policy handlers, which
previously had none.

Note that there is an interplay between forced and blocked languages,
as well as the spellcheck-enabled policy:

  1) If a language is both forced and blocked, forced wins.
  2) If spellcheck is disabled by policy, the forced/blocked languages
     policy has no effect.

Test cases cover this interplay.

Bug: 1056850
Change-Id: Iec54a851d38f00a7aa7597449f7acc30f3dd2de3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080450Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Bruce Long <brlong@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#757107}

This builder was broken by recipe-side change crrev.com/c/2125157,
but the fix (crrev.com/c/2128842) was not cherry-picked to the M81
branch. Since this feature is not enabled in M81, we can simply
remove this builder from the CQ rather than cherry-picking the test
fix.

Bug: 1068383
TBR: gbeaty@chromium.org
No-Try: True
No-Tree-Checks: True
Change-Id: I2cc44a80dca5ca55cc5f94c96c3bbbec2397907e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140295
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Auto-Submit: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757106}

Create a new junit test suite with a few simple tests to check whether
page vs overview menu should be shown and menu items visible on the NTP.

BUG=1066119

Change-Id: I803cd0503b8a254fc9f5a8fb3e3ca5e1b6f65ec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135306Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757105}

Introduce a caption controller which is a keyed service that belongs
to a single profile. The caption controller will be responsible for
handling the caption feature turning on/off, and piping the text from
the caption service to the UI. The caption controller creates and
destroys the caption bubble controllers.

Introduce a caption bubble controller which is a lightweight controller
of the caption bubble. It is responsible for tasks such as
post-processing of the text that might need to occur before it is
displayed in the bubble, and hiding or showing the caption bubble when
captions are received or the tab changes. There exists one caption
bubble controller per browser window.

Bug: 1055150
Change-Id: I825d47923d07e65c26b46c90e5100328fedc42e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081111
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757104}

It's odd having text files that don't end with a \n. Vim adds them
automatically.

Change-Id: I2d7fe826b8689b321dd195f2f2741495a332854c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137823
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Henry Jian <hzjian@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757103}

This is a reland of 7d25a90d

The test needed some fixes.

Original change's description:
> [EventTiming] Implement EventCounts
>
> This CL adds support for performance.eventCounts, gated behind the
> EventTiming flag. EventCounts is maplike and enables computing the
> number of input events that have occurred for any of the supported event
> types. It is populated on WindowPerformance::RegisterEventTiming so that
> it matches when timing with when the PerformanceEventTiming entry is
> created for slow events. The spec for this is here:
> https://wicg.github.io/event-timing/#sec-event-counts
>
> Bug: 543598
>
> Change-Id: I95bd8b977556557811a1eff8d9fc5d106af0d2b1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125019
> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#755468}

Bug: 543598
Change-Id: I2dd1ea4379805c246976746ffb6d02346adb1141
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134931Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757102}

This reverts commit 318566fd.

Reason for revert:NavigationController_Background test failing on https://ci.chromium.org/p/chromium/builders/ci/ios13-sdk-simulator

Original change's description:
> [Sharing] Adding Empty Modal for QR Code Generator
> 
> Includes empty:
> - Coordinator
>   - Uses a UINavigationController to present VC.
> - View Controller
> 
> Hooked up to the sharing action through BrowserCoordinator, which is
> hidden behind a flag.
> 
> Tested on iPhone X 13.4 and iPad sim 12.4.
> 
> Added unit tests for the view controller.
> 
> Bug: 1064990
> Change-Id: Ia23b83208cd0672372e2f53bcbc3dc4d6c1cf1fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130819
> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#756659}

TBR=marq@chromium.org,seblalancette@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1064990
Change-Id: I4927cf9588efaf2959b99c9241db45107c870923
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140293Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757101}

Per guidance, all the hardcoded colors in this file have new
native color IDs.

For now the color IDs have the same values, no changes made to
the colors, and they are used for GetDarkSchemeColor and
GetDefaultColor.

Bug: 1056950
Change-Id: Iae1bfe721e45b594724a0cf7cb4b2127c23716bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111761
Commit-Queue: Maria Villarreal <mavill@microsoft.com>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757100}

This CL eliminates the duplicate business logic in result view that
determines visibility of button row buttons. Instead, the view consults
the popup model to determine visibility.

IsSelectionAvailable is made public as originally intended.

Bug: 1046523
Change-Id: I92333dfd9e1d9e733af286640f1c1c8c4ac1f475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138631
Auto-Submit: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757099}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Id0052df6c64fa7bd06dd3253e77a16214c82b170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139789Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757098}

Bug: 1025907
Change-Id: I7849f4decfd800f1608a231c1ae038b4ec56e90f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136882Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757097}

This already happens implicitly, but using a raw pointer doesn't make it
clear, and one test used set_owned_by_client() here to avoid it.  Switch
to smart pointers and remove set_owned_by_client() use.

Bug: none
Change-Id: Icd87a9c48631697dc0e4638ba5af643828a840e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137815
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757096}

This test seems slow - 20 iterations of the test took more than 80
seconds on Z840.  Therefore the [ Timeout ] expectation for this test
should probably be replaced with a [ Slow ] expectation.

Fixed: 678482
Change-Id: I8e400a813901d390673907bf9c7b64057fee5057
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137816
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757095}

The DCHECK in the bug was caused by an order-of-operations issue.
Within the following calculation:
max_inline_contribution =
          child_sizes.max_size + line_left_inset + line_right_inset;

If:
child_sizes.max_size == LayoutUnit::Max()
line_left_inset == LayoutUnit(1)
line_right_inset == LayoutUnit(-1)

max_inline_contribution would be LayoutUnit::Max() - LayoutUnit(1);

This resulted in max_size < min_size.

Bug: 1004060
Change-Id: I3e439500f07a2cd1cf0cbe5528ece16090c9fa70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136885
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757094}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e89877724aba..09fdff26a543


Created with:
  gclient setdep -r src-internal@09fdff26a543

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC melzhang@google.com,huangdarwin@google.com,battre@google.com,csharp@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1026667
Tbr: melzhang@google.com,huangdarwin@google.com,battre@google.com,csharp@google.com
Change-Id: I55a8a2b09da7cd400f099305358bca88f8e6cb12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140064Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Reviewed-by: Chris Sharp <csharp@chromium.org>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#757093}

Some Mac high end devices has been dead for more than a week. This has blocked
the perf test for two days already.
Due to the current COVID-19 situation, the lab may not be able to recover
machines as quickly as normal. We will reduce the shard size for now to keep
perf test running.

Bug: chromium:1068120
Change-Id: Id0c60787bfa684a267f3f782a7ec2bfbc326b4a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138000Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757092}