- 29 Oct, 2020 40 commits
-
-
Peter Marshall authored
DevTools is intending to share Chrome's HaTS implementation, but we have a slightly different use-case as we are presenting 'persistent' surveys, which are triggered by user interaction like clicking a link to take a survey. These surveys are always triggered on the server-side, and don't have a client-side rate limit. DevTools' surveys will be triggered by the user clicking on a link. If we know that a survey won't succeed, we want to avoid showing the link in the first place. We've extended the HatsService API with CanShowSurvey() to indicate whether we already know a survey will fail. We also want to know whether a survey has failed to show to the user, even after the initial CanShowSurvey check, which is possible. To get a signal for this we've added success and failure callbacks to LaunchSurvey(). As DevTools will use persistent, user-prompted surveys, we've added the notion of user-prompted to the SurveyConfig struct. This changes some survey triggering behavior: - We remove the minimum profile age check. - We remove the last started time for this survey check. - We remove the last started time for any survey check. We still trigger the UMA stats in CanShowSurvey(), even though they will be duplicated in LaunchSurvey. The reasoning is that the UMA stats are only recorded for 'failed' cases where CanShowSurvey() returns false - the expectation is that the caller will not then call LaunchSurvey and trigger a 2nd UMA stat which would potentially skew results. Doc: https://docs.google.com/document/d/1wMRb1hI2zJ1mzOSJjjF46C2hToGksQf2AxurorxaiTg Bug: 1112738 Change-Id: Id48fb9296fbce898fc6428cd562990e25e96457b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485940 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#822079}
-
Matt Falkenhagen authored
This adds UseCounter for local storage being first used before fcp and after fcp. For prerendering, we expect to cancel the prerender on a local storage access, because it uses a synchronous IPC. Note that while getAll() is the only sync method in blink::mojom::StorageArea, any initial use of local storage uses that to populate Blink's in memory cache. This adds a page load metrics observer which logs to Blink UseCounter on Local Storage access. This is somewhat an abuse of the UseCounter, as it's a targeted use case, but the UseCounter has good properties like defining what a page load is. This will eventually be replaced with Prerendering cancellation metrics when Prerendering is actually implemented. Bug: 1126305 Change-Id: If719c21115481d93930101e95d6fe86701f30523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497965 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#822078}
-
Evan Shrubsole authored
In the kWebRtcLibvpxEncodeNV12 feature, avoid converting the scaled image to I420. This saves an allocation in creating the NV12ToI420 scale, and a copy of the scaled UV plane. Bug: 1134165 Change-Id: I6b4e433ae0ea4b22c49cc5f14904b1a67439f34b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483828Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/master@{#822077}
-
Kuo Jen Wei authored
Add check to early return from taking process of camera intent view if the underlying camera view ends the take process earlier(e.g. timer canceled) and produce no take result. Bug: b/171874692 Test: Manually Change-Id: I7aa8c70680e6c59fa013a0ced4738a200388b30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505321 Commit-Queue: Inker Kuo <inker@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#822076}
-
Zhaoliang Ma authored
Bug: None Change-Id: I82107c410e016c1303828a91be1fd2e277b9333d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506277 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#822075}
-
Colin Blundell authored
The test was expecting events in the wrong order: upon reload and click on the form it was expecting to see a CANCEL event followed by a VIEW_EXITED event, but the latter event is fired first as part of focus moving off of the current form, followed by the former event as part of starting the new autofill session. I did not detect this problem in my local testing because the CANCEL event is not sent (/listened for by the testing infrastructure) on Android versions > O. I verified locally that the test fails on an O emulator before the change in this CL and succeeds after the change. One thing that's not clear is how this test ever succeeded on the O trybot, e.g. on this run: https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20O%20%28dbg%29/12151 This CL also changes the test to do the reload via AwActivityTestRule#reloadSync() rather than AwActivityTestRule#loadUrlSync() to reflect production behavior. That change, however, does not impact the above logic. Bug: 1142486 Change-Id: Id2e9d6dbb44615356b43603afb11a2b4de40467e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502043Reviewed-by:
Michael Bai <michaelbai@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#822074}
-
Bartek Nowierski authored
Bug: 1092288 Change-Id: Iabef18be7e80d36ca6242d869a66a8c684c66472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505320 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#822073}
-
Wei Lee authored
This reverts commit e9e022ce. Reason for revert: Per UI review, camera folder should be non-modifiable. Original change's description: > [Files App] Makes Camera folder modifiable > > Per discussion with Files team, we agree that Camera folder should still > be modifiable. > > Bug: 1127587 > Test: Manually > Change-Id: I22a9e3eca0b7fb71bd883c37bb0e6a30509e8b80 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477707 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Wei Lee <wtlee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820680} TBR=lucmult@chromium.org,wtlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1127587 Change-Id: Iaaa95f90958b3a539c3f32254d784c75dd8ad39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505705Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f418c109094a..3591997b58bf 2020-10-29 syoussefi@chromium.org Roll Vulkan-Loader from 8e2b7d03ccfd to 8308d6744d50 (2 revisions) 2020-10-29 jmadill@chromium.org Revert "Tests: Update COD:Mobile trace" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I066c5e92f6e60ea2a41aa5a8d85f02a352e62335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506665Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#822071}
-
Anders Hartvoll Ruud authored
Our specificity calculation for :host() incorrectly uses the maximum specificity for the selector that _matched_ inside :host(). Since no selector matches in this case, the specificity is zero, and we end up applying the wrong thing. Bug: 1143404 Change-Id: Ib3f4d132c36aedeade3fd79d86c960c352eba120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505896Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#822070}
-
dpapad authored
The failure could be easily reproduced as follows rm -rf out/<out>/gen/chrome/browser/resources rm -rf out/<out>/ui/webui/resources ninja -C out/<out> chrome/browser/resources/extensions:build and was caused by a missing dependency to cr_components:preprocess. TBR=futhark@chromium.org No-Tree-Checks: true No-Try: true Bug: 1143476 Change-Id: Ib06568eeb9782beace3093cb434c58c978708d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506643 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#822069}
-
Koji Ishii authored
When block fragmentation is enabled, it is often necessary to know which fragment |NGInlineCursor| is at. This function returns the |NGPhysicalBoxFragment| for the current root |NGFragmentItems|. To do this, constructors are adjusted to take |NGPhysicalBoxFragment|. Usually callers know it. Also fixes a crash in |NGCraretRect| when block fragmentation is enabled. Other places that use functions to be eliminated for block fragmentation (|ContainingBlockFlowFragment|, |CurrentFragment|, |FragmentItems|, etc.) are not reviewed yet. Will do so in future patches. Bug: 1131405, 1061423 Change-Id: Ie7611a892a7e874e194100f3a905c10af070ee97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505354 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#822068}
-
Hitoshi Yoshida authored
Currently, the work queue of a test is managed in a TestRunner, i.e. a render thread. But if we swap RenderFrameHost with pro-active same-site BI swap or Back-Forward cache, the TestRunner that controls the test can migrate processes and can lose some information. This CL migrates the work queue to WebTestControlHost, i.e. the browser process, and makes the TestRunner that refers the main window work together. Bug: 1136383, 1132180 Change-Id: Ie95fd4c694be120b9611e4ac156fc6417bb96d87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469351 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#822067}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4860462a2734..3cd384a5b039 2020-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from c1839ee3cedd to 2be25f08deaf (1 revision) 2020-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from ee4e0866cb85 to e3eaa60f1faf (16 revisions) 2020-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 0b545254 to 6ce7ceff (406 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Test: Test: Test: Capture PUBG MobileTest: Test: Capture PUBG Mobile LiteTest: Test: angle_perftests --gtest_filter="*cod_mobile*"Test: Test: angle_perftests --gtest_filter="*pubg_mobile_lite*" Change-Id: Iac749edc5ccb207c8f3b0f8887e1bf13b9e30769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506873Reviewed-by:
-
Ramin Halavati authored
Current Guest profiles are OffTheRecord and upgrade detection is disabled when an OTR session is running. But ephemeral Guest profiles are not OTR and hence not covered. An extra check for existence of Guest profiles to disable upgrade is added. Please see go/ephemeral-guest-profiles for more context. Bug: 1125474 Change-Id: I1a14f7222bab47ea8385f03e262d2982b53ab749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505750 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#822065}
-
Daniel Cheng authored
Change-Id: Ie8e9b9ebd7ada8cce06f6500196ea950efd01201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506617 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#822064}
-
Alexander Alekseev authored
This CL removes IME dependency from the session state and makes IME UI changes synchronous with the system UI. Bug: b/160647413 Change-Id: Iefc1711cafac3d2ee42108d08bc7f0165b00e18e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479862Reviewed-by:
Shu Chen <shuchen@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#822063}
-
Mason Freed authored
These tests were in a group that was timing out on android servers. I converted both of them from PerfTestRunner.measureTime to PerfTestRunner.measureRunsPerSecond(), which should be more predictable across platforms. I also cleaned up the code a bit. * blink_perf.dom/custom-element-default-style-with-shadow.html * blink_perf.dom/custom-element-default-style.html Metrics for these two tests *will* change after this CL lands, but that should not be a concern. Bug: 1142315 Change-Id: I80bc469553621420eb2e3f8b250d96260e8515b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505744 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
James Vecore authored
We now wait for the FastPathReady message before returning the result for the StartReceivingMessages mojo call. Fixed: 1134212 Change-Id: Ic1b64421544a90a7ae82b0d11f69edf64c2d1021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506391Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#822061}
-
Solomon Kinard authored
Bug: None Change-Id: I91bb493036a66daa99da8932e167ef2e22dd805d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505882Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#822060}
-
Koji Ishii authored
When the `lang` attribute does not match the hyphenation dictionary exactly, this patch computes fallback languages, by incrementally removing the last component separated by U+002D HYPHEN-MINUS character. This allows, for instance, `lang="fr-fr"` or `lang=`fr-ca`" to find the `fr` dictionary. Bug: 815059 Change-Id: Ia4b76621dfb18b5aef604e8c7351ed9322f056dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505353 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Keishi Hattori authored
Check if all FreelistEntry pointers in the linked list are valid. By making sure the FreelistEntry and the next one are on the same super page. Bug: 1137799 Change-Id: Ic37f4fb80a0a14251247fa39912f9d4cc8f90901 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500652 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#822058}
-
Joel Hockey authored
Bug: 953310 Change-Id: I04762056fb288807d9dc7a8fce717f331d43784a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504750Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#822057}
-
Alex Danilo authored
Bug: 1110540 Tests: browser_tests --gtest_filter="*saveFileDialogAriaSingleSelect" Change-Id: I1ec00b62daaa7e4e476380a1a0f3df8fa6acce5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504753 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#822056}
-
Nidhi Jaju authored
In an effort to change the blink implementation of readable streams to better match the Web IDL descriptions in the Streams API Standard, this CL changes the first parameter of pipeTo() in readable_stream.idl to WritableStream type based on https://streams.spec.whatwg.org/#ref-for-rs-pipe-to%E2%91%A1. This CL also modifies the ordering and comments within pipeTo() inside the ReadableStream class to better reflect the steps outlined in https://streams.spec.whatwg.org/#rs-pipe-to. Bug: 1093862 Change-Id: Id6029dc3dc0551e59c812daac499a8e538f3be75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505333Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#822055}
-
Hiroshige Hayashizaki authored
According to the spec https://html.spec.whatwg.org/C/#timer-initialisation-steps setTimeout()/setInterval() don't inherit initiating script's muted errors flag, which matches with Chromium/Firefox/Safari. This CL fixes WPT tests to match with the spec/impl, i.e. to expect errors from setTimeout()/setInterval() from cross-origin scripts not to be muted. Bug: 1111134 Change-Id: I3b4d0a5450ccee8fb04113846c9e9773d476cfe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485416Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#822054}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/67e1cf4b1d81..4860462a2734 2020-10-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 47ee61679da0 to a584311a6a73 (5 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I8a4679a6cfe16ceb1b1238ebf8b46dd11d8a71e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506342Reviewed-by:
-
Samuel Attard authored
Electron's Context Isolation implementation has a side-effect of initializing the isolated worlds WindowProxy during the initialization of the main world WindowProxy as a result of creating the isolated world inside the DidCreateScriptContext hook. This results in an assertion failing in Chromium during a frame swap where it expects to be able to set a new global_proxy in the WindowProxy of the isolated world BEFORE it is initialized. To meet this assumption this patch splits SetGlobalProxy into two calls, SetGlobalProxyWithoutInitializing and InitializeIfNeeded which has the same resultant effect but means that all of the global_proxy objects are set BEFORE any WindowProxy's are initialized. To further clarify, if an embedder creates and initializes new script context as a result of a call to DidCreateScriptContext the "global_proxy_.IsEmpty()" CHECK fails as it doesn't expect that context to have been initialized yet. Change-Id: I0efa579a4ec2d93369f3e1fc7a922a459a2300cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503397Reviewed-by:
-
Brett Kilty authored
No definitive repro, but found in several large automated test runs with rapid activity on device. All protect this remaining member against access after destruction. Bug: b/163868029 Test: Local execution, no regression Change-Id: Icaf5e73f10f75e6edcf414c830b8eb99611b4b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503637Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Brett Kilty <brettk@google.com> Cr-Commit-Position: refs/heads/master@{#822051}
-
Julie Jeongeun Kim authored
As blink::mojom::ResourceType is deprecated[1], this CL uses network::mojom::RequestDestination in ServiceWorkerFetchDispatcher, ServiceWorkerControlleeRequestHandler, and ServiceWorkerMainResourceLoaderInterceptor. [1] https://crbug.com/960143 Bug: 1059639 Change-Id: Ida0434e7ba07ed4f87b0bdaa3c5c7d732613059f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491595 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
Alex Moshchuk authored
Currently, there are two SiteIsolationPolicy objects: one in //content which knows about content-internal things, and one in //components, which knows about higher-layer modes such as password-triggered site isolation on Android. The ShouldPdfCompositorBeEnabledForOopifs() in content was a bit problematic for two reasons: (1) it's a bit of a layering violation for content to know about PDF compositor, (2) it implicitly relied on AreIsolatedOriginsEnabled() being true for the password-triggered site isolation mode used on Android, which stopped being true in https://crbug.com/1005895. This CL moves ShouldPdfCompositorBeEnabledForOopifs() to the SiteIsolationPolicy in //components, where it's also updated to check IsIsolationForPasswordSitesEnabled() in addition to the other two site isolation modes. Note that this still should exclude (1) low-memory Android devices that don't use any site isolation (enforced via IsSiteIsolationDisabled() checks inside SiteIsolationPolicy), and (2) Android Webview, where OOPIFs aren't supported (hopefully this is true because AW doesn't go through code paths that check ShouldPdfCompositorBeEnabledForOopifs()). Eventually, the goal is to enable PDF compositor everywhere, so hopefully we can remove ShouldPdfCompositorBeEnabledForOopifs() altogether at some point. Bug: 1022917 Change-Id: Ib8d3a7c7b133707d5c6ca88efbbdc0f77635fe1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500444Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#822049}
-
chrome://flags#check-offline-capabilityAsami Doi authored
Bug: 965802 Change-Id: Id0008fd9418110c3d1d4590c7ca035b5317d7aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494288 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822048}
-
Jiewei Qian authored
By default, we use an empty SWA list in test. When the test chrome process starts, SystemWebAppManager first calls SynchronizeInstalledApps with an empty list. In the upgrade test, this cause previously installed apps to be uninstalled. In the test body, we then use InstallSystemAppsForTesting to install the real system apps. This effectively installs apps on a clean state, and defeats the purpose of this test. This CL adds a check so SystemWebAppManager uses the real SWA list, if EnableAllSystemWebApps feature is enabled. Fixed: 1143108 Change-Id: I7f60429bcae45c011eb0681a6d8c322e898a32c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503374Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Jiewei Qian <qjw@chromium.org> Cr-Commit-Position: refs/heads/master@{#822047}
-
Hiroshige Hayashizaki authored
Before this CL, there are three slightly different methods for module script evaluation: - Modulator::ExecuteModule() - ModuleRecord::Evaluate() - V8ScriptRunner::EvaluateModule() To unify the code paths and behavior, this CL - Merges them into V8ScriptRunner::EvaluateModule() (Mostly just inlining) - Merges Modulator::CaptureEvalErrorFlag into V8ScriptRunner::RethrowErrorsOption, and - Introduces a thin wrapper ModuleScript::RunScriptAndReturnValue() to align with the ClassicScript conterpart. The new behavior of V8ScriptRunner::EvaluateModule() is the same as the previous ModulatorImplBase::ExecuteModule(). This CL shouldn't change the non-test behavior, because all non-test code path went through ModulatorImplBase::ExecuteModule(), This CL also replaces some Modulator calls (that were in Modulator::ExecuteModule() and are now in V8ScriptRunner::EvaluateModule()) with equivalent direct calls to ExecutionContext, to avoid many more overrides in DummyModulator subclasses in unit tests. Bug: 1111134 Change-Id: Icbda1e657b33077f0ae1e681045b04857229cbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462885Reviewed-by:
Dominic Farolino <dom@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#822046}
-
Kenichi Ishibashi authored
There seems a situation where multiple operations are queued at a time for the same resource id. Since `active_entry_calls_` and `active_doom_calls_` used resource id as a key, only one callback was preserved. When DidGetEntryResult() or DidDoomEntry() were called for the second time, these tried to find active calls from the maps but callbacks were already consumed. This CL replaces keys of `active_entry_calls_` and `active_doom_calls_` with monotonically increasing `call_id_` to make sure we don't lose the callback of each operation. Bug: 1142779 Change-Id: Ie4a999c50bcee3417453da8bbe4b2b529462b91f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505338 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/77defeb04693..f418c109094a 2020-10-29 ianelliott@google.com Vulkan: Document how to turn on debug markers 2020-10-28 ianelliott@google.com Vulkan: App-compat for apps that disable validation & don't link 2020-10-28 cnorthrop@google.com Tests: Update COD:Mobile trace 2020-10-28 cnorthrop@google.com Tests: Add PUBG Mobile Lite trace 2020-10-28 geofflang@google.com Work around Mac glGenerateMipmap with missing levels bug. 2020-10-28 cnorthrop@google.com FrameCapture: Disable GL_OES_mapbuffer during capture 2020-10-28 cnorthrop@google.com FrameCapture: Track surface width/height per context If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Test: Test: Capture PUBG MobileTest: Test: Capture PUBG Mobile LiteTest: Test: angle_perftests --gtest_filter="*cod_mobile*"Test: Test: angle_perftests --gtest_filter="*pubg_mobile_lite*" Change-Id: I2306b49c5acc06747db6656e01399616647f204f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506388Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/5ede1190cf97..d2fa57d26dff 2020-10-29 dsinclair@chromium.org [doc] Add some documentation around translations. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: rharrison@google.com Change-Id: Id8ec10288703153b7dab16ac017c939b507cee01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506606Reviewed-by:
-
Dirk Pranke authored
Currently, when a bot runs a test (say, url_unittests) on an Android build, it'll launch `python test_env.py logdog_wrapper.py bin/run_url_unittests` (roughly speaking). This CL flips that around so that the generated bin/run_url_unittests script will invoke test_env.py to launch url_unittests (and the bot will then invoke bin/run_url_unittests directly). This slightly reduces the discrepancy between what a dev runs locally and what the bot runs, and will make Android consistent with every other platform. Bug: 816629 Change-Id: I76727641b5a4362f37762ed4ed4b175eea58ce2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506634Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#822042}
-
Emircan Uysaler authored
This CL applies the crop rect calculated by the overlay processor on Scenic's scene graph. Bug: 1127984 Change-Id: Ifc4a7078c1323fcdc2921e8fccb367e05dfd3824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503857 Auto-Submit: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#822041}
-
Harvey Yang authored
This commit extracts ECLidAngleDriverSupported information from AccelerometerUpdate and adds a public function GetECLidAngleDriverStatus() in AccelerometerReader to provide this information because it doesn't change. It also adds SetECLidAngleDriverStatusForTesting() to fake the status for unittests. BUG=b:171446270 TEST=unit tests, and run on jacuzzi & hatch Change-Id: I80cb66e6caf77f9d193b92e9a675d649576fcc87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491462 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#822040}
-
