- 21 Jun, 2018 40 commits
-
-
Ramin Halavati authored
Another update to annotations.xml as annotation tests were not active on Windows for a few days. Change-Id: I668239db1ba577b04850e0833d6c16e4319e0dcf TBR: msramek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1109506Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#569176}
-
edchin authored
Previously, model changes and table updates were not synchronized for handling "Hide for now" on long presses in recent tabs. This CL moves the model changes into the same block as table updates so that they are fed together into |-performBatchUpdates:| in iOS 11 and |-beginUpdates| in iOS 10. This was only crashing in iOS 10 iPad, but theoretically, it is wrong and would crash in other configurations. Bug: 851946 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4fe35eb06cf77d1fb6097a5508d72dd1e93fc6ee Reviewed-on: https://chromium-review.googlesource.com/1108346Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569175}
-
mrefaat authored
Check all the members of WebStatePolicyDecider::RequestInfo instead of only checking the target frame in NavigationAndLoadCallbacksTest. Bug: 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I7be2bc81f613a2a4d7d052634ab3a96edb8bf267 Reviewed-on: https://chromium-review.googlesource.com/1101499 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#569174}
-
Yuichiro Hanada authored
Test: keyboard_unittests Change-Id: If0144253d227b3d46813fa2e7f339359fd70874c Reviewed-on: https://chromium-review.googlesource.com/1109602Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#569173}
-
Maksim Sisov authored
In order to ensure media files can enter fullscreen mode, manually handle fullscreen states. Basically, a compositor sends configuration events on each request for state changes from clients asynchronously, which is unefficient for media files when they enter a fullscreen mode. For example, when a youtube video file is being set to fullscreen, a WaylandWindow is also set to a fullscreen mode, but the return value from the WaylandWindow::GetPlatformWindowState still contains an old value until the compositor calls with a configuration event. This short race is enough for a media content to be placed in a forever "entering fullscreen" state, which never results in a fullscreen state for media files. Bug: 843018 TEST: XdgVersionV5Test/WaylandWindowTest.SetFullscreenAndRestore/0 XdgVersionV6Test/WaylandWindowTest.SetFullscreenAndRestore/0 Change-Id: Ib9bc8c0ce09412c36437d165efc6a0cad60c4d17 Reviewed-on: https://chromium-review.googlesource.com/1107636Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#569172}
-
Timothy Loh authored
This CL adds support for launching Crostini apps from the File Manager. For the moment, we only support files which are already in the Crostini container, but in the future we will support external files as well. Support for display app icons will be added in a separate patch, but as it will require FindCrostiniTasks to be asynchronous, it is made to take a callback to run upon completion. Bug: 822513 Change-Id: I257b482991ab8cf2e4d0ef5be18d0e33205df4e3 Reviewed-on: https://chromium-review.googlesource.com/1100606 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#569171}
-
Hajime Hoshi authored
This CL merges EventQueue and EventQueueImpl into one class. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: I302f99848ec59f16e7c8c2f1a5ca14aa0896a21a Reviewed-on: https://chromium-review.googlesource.com/1107527Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#569170}
-
Keishi Hattori authored
We tried running incremental marking from a normal task but noticed it could cause large delays when there are many queued tasks. This moves incremental marking step/finalize to RunScheduledGC where we run after every task. Change-Id: Ibdd4ee0f7fa3a2ac1245c37581c0109f0206f94a Reviewed-on: https://chromium-review.googlesource.com/1109455Reviewed-by:
-
Yoichi Osato authored
SelectionPaintRange::Iterator iterated LayoutObjects using layout order but we marks SelectionStatus on flat tree order. This causes invalidation leak if they are not same order. Ruby element is a reported example for that. This patch changes SelectionPaintRange::Iterator iterate on a flat tree considering first-letter. Bug: 843144 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I02cbad86e64d0a7781f8fb37e2d13c7aa00228fb Reviewed-on: https://chromium-review.googlesource.com/1063521 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569168}
-
Karan Bhatia authored
SandboxedUnpacker::ReportUnpackingError posts a task on the |unpacker_io_task_runner_| to report unpacking failures. However, all its callers are on |unpacker_io_task_runner_| itself. Prevent unnecessarily posting a task by merging ReportUnpackingError and UnpackExtensionFailed methods. BUG=None Change-Id: Id229392333d0236fd60a5cce0cf642f3aa436ab8 Reviewed-on: https://chromium-review.googlesource.com/1108574 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569167}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/db6af36979b6..5b8dd4d75ec3 git log db6af36979b6..5b8dd4d75ec3 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 qingsi@google.com Fix a dangling-pointer bug in P2PTransportChannel unit tests. 2018-06-20 steveanton@webrtc.org Remove unused/deprecated DTMF methods 2018-06-20 deadbeef@webrtc.org Removing some TSan suppressions around Thread class. Created with: gclient setdep -r src/third_party/webrtc@5b8dd4d75ec3 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iabc7455f5f50a84a3a1ba22e51ef45ba67bc6121 Reviewed-on: https://chromium-review.googlesource.com/1109517Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569166}
-
Alexandre Courbot authored
Extract the useful interface from the V4L2ImageProcessor into a generic interface that can be used for other kinds of processors and codecs. Update the V4L2 encoder and decoder to use this more generic interface. Also convert one instance of Callback into OnceCallback in the image processor. BUG=850375 BUG=b:73752373 TEST=Checked both VDA and VEA unittests on Hana. Change-Id: Ia40a3989717f3cb03711b13a2ec574e018d2c614 Reviewed-on: https://chromium-review.googlesource.com/1084364Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569165}
-
Ramin Halavati authored
Traffic annotations summary needs update as the trybot for Windows has been not working since last Friday due to a clang script error. Change-Id: I685de179aaa748e7e3affc7cab2a9356623732c7 Reviewed-on: https://chromium-review.googlesource.com/1107933Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#569164}
-
Zhongyi Shi authored
Two tests simulates that session encounters a ASYNC/SYNCHRONOUS write error on the old network, new network connected before old network disconnects. Session should migrate successfully on write error. Two tests simulates that session encounters a ASYNC/SYNCHRONOUS write error on the old network, new network connected after old network disconnects. Session should migrate successfully on write error. Bug: 818259, 843299 Change-Id: I43206f683743675302af31b1ee86c64c258b1c9d Reviewed-on: https://chromium-review.googlesource.com/1108931 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#569163}
-
Koji Ishii authored
From manual review of build 7004 with some local normalization tools. flag-specific baselines match to their parent baselines: - fast/deprecated-flexbox/crash-flexbox-no-layout-child Images match, and text dumps match after normalizations: - fast/css/margin-top-bottom-dynamic.html - fast/forms/form-element-geometry.html - svg/custom/text-match-highlight.html - virtual/video-surface-layer/media/video-colorspace-yuv420.html - virtual/video-surface-layer/media/video-colorspace-yuv422.html - virtual/video-surface-layer/media/video-layer-crash.html - virtual/video-surface-layer/media/video-replaces-poster.html - virtual/video-surface-layer/media/video-zoom.html Text dump differences are reasonable for NG list item changes: - paint/invalidation/list-marker.html NG text dump includes ellipsis as "\x{2026}": - paint/markers/active-suggestion-marker-split.html - paint/markers/composition-marker-split.html NG text dump includes a CONSOLE MESSAGE for Blink test plugin: - plugins/iframe-plugin-bgcolor.html Blank line differences (crbug.com/854889): - fast/events/background-tab-on-submit-ctrl-click.html - fast/events/background-tab-on-submit-synthesized-ctrl-click.html - virtual/mouseevent_fractional/fast/events/background-tab-on-submit-ctrl-click.html - virtual/mouseevent_fractional/fast/events/background-tab-on-submit-synthesized-ctrl-click.html - virtual/user-activation-v2/fast/events/background-tab-on-submit-ctrl-click.html - virtual/user-activation-v2/fast/events/background-tab-on-submit-synthesized-ctrl-click.html TBR=xiaochengh@chromium.org, mstensho@chromium.org, cathiechen@tencent.com, yoichio@chromium.org NOTRY=true Bug: 591099, 854889 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I77d90c868eca472ce558f165f3768febf757506b Reviewed-on: https://chromium-review.googlesource.com/1109586 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569162}
-
Zhongyi Shi authored
These tests verify that session sends connnectivity probes on new default network before migrate to it. Bug: 818259, 843299 Change-Id: I73e9961dec23de933818e16f917f41d224fde98a Reviewed-on: https://chromium-review.googlesource.com/1109407Reviewed-by:
-
Ian Vollick authored
With this change, recentering the UI will preserve the content scale as well as its pitch, but it's yaw will be reset to zero. I.e., it will be positioned in front of you, but it will be the same size and will be in the same spot with respect to the horizon. Bug: 854860 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ifced628481bdfbbae473bb530df6f766f5728485 Reviewed-on: https://chromium-review.googlesource.com/1109393 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#569160}
-
Koji Ishii authored
Following bot results are included. 6975 6982 6985 6990 6991 6997 7001 7004 1 lines were removed and 2 lines were deflaked by consecutive results since 6953. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I63eb1ad1f5559394cbb61985dac97ad1f81fb3cb Reviewed-on: https://chromium-review.googlesource.com/1107528 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Sam McNally authored
Bug: 844292 Change-Id: I89b008ab1483aee6c5d619435e0e082d463fc2b3 Reviewed-on: https://chromium-review.googlesource.com/1107424 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#569158}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/2db95136c551..f3c454475aee git log 2db95136c551..f3c454475aee --date=short --no-merges --format='%ad %ae %s' 2018-06-21 simonhatch@chromium.org Dashboard - Raise error on duplicate histograms in /add_histograms Created with: gclient setdep -r src/third_party/catapult@f3c454475aee The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ief79475d5523dbde014dd1c3969fdedf60f55361 Reviewed-on: https://chromium-review.googlesource.com/1108718Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569157}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6407dba4. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19941 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio pwnall@chromium.org, jsbell@chromium.org: external/wpt/cookie-store TBR=robertma No-Export: true Change-Id: Ia5094284a59d636b550ade70f0ee1f8a7a369f84 Reviewed-on: https://chromium-review.googlesource.com/1109460 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569156}
-
Paul Meyer authored
This method allows queued reports to be captured early. https://wicg.github.io/reporting/#dom-reportingobserver-takerecords Bug: 731810 Change-Id: I885d53a1800959d39e9451fc014ce05a4cda475f Reviewed-on: https://chromium-review.googlesource.com/1106642 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#569155}
-
Timothy Loh authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/557c37af39f5..0e2a5fd43dc3 $ git log 557c37af3..0e2a5fd43 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 timloh Add a files argument to vm_tools.cicerone.LaunchContainerApplicationRequest 2018-06-18 benchan shill: remove deprecated kHostNameProperty 2018-06-18 jkardatzke Removed unused protobufs/constants for concierge Created with: roll-dep src/third_party/cros_system_api Bug: 822513 Change-Id: Ia857d7d8836ea91b71634c4fa42092be57e9fa19 Reviewed-on: https://chromium-review.googlesource.com/1109316Reviewed-by:
-
Dirk Pranke authored
This reverts commit 52f13686. Reason for revert: I should just use the custom trigger script and dimension sets instead ... Original change's description: > Move the CQ Mac layout tests from 10.12 to 10.13. > > Currently the Mac10.13 Tests bot runs the layout tests on 10.12; > this is done because we didn't have enough capacity on 10.13 to > run them. This CL is one of a series that is attempting to fix this. > > In this particular CL, this switches the test step from 100% > 10.12 to 50% 10.13, and also updates the chromium.clang ToTMac > and 'Chromium Mac 10.13' bots to get around the unneeded hacks. > > A subsequent CL will ramp this to 100% (non-experimental) once > we're sure we have the capacity. > > BUG=853356 > > Change-Id: I4a772f4bd82f427fde1931417dd60d0f80a8d40a > Reviewed-on: https://chromium-review.googlesource.com/1109458 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569147} TBR=dpranke@chromium.org,tikuta@chromium.org,jbudorick@chromium.org Change-Id: I8cd37858ad7fe16a43009168d0d16a0535dac7e5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853356 Reviewed-on: https://chromium-review.googlesource.com/1108619Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569153}
-
Yoichi Osato authored
This patch stops painting document markers on ellipsis character. Old implementation is bit strange : painting background of ellipsis as culled characters are not hided only for find-in-page marker. See: https://docs.google.com/document/d/1Osd-W9IMxHrrgJ2Kvo7HfpVTms7EDUbOHhsmL1c3_Yo/ This patch implements simply: do not paint any marker on ellipsis because characters are hide. That can cause a bit weird situation: if find-in-page hits such hide texts, it shows numbers of found texts but blink doesn't paint anything. However old implementation already has similar situation: if found text are clipped by text-overflow: clip, also blink doesn't show them. Thus this is acceptable change. This patch fixes following tests: paint/markers/ellipsis-ltr-text-in-ltr-flow-with-markers.html paint/markers/ellipsis-ltr-text-in-rtl-flow-with-markers.html paint/markers/ellipsis-mixed-text-in-ltr-flow-with-markers.html paint/markers/ellipsis-mixed-text-in-rtl-flow-with-markers.html paint/markers/ellipsis-rtl-text-in-ltr-flow-with-markers.html paint/markers/ellipsis-rtl-text-in-rtl-flow-with-markers.html Bug: 850448 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibdd7d485e2b5ac4b5db665d54b64131e6c1bcdb9 Reviewed-on: https://chromium-review.googlesource.com/1105681 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
Sam McNally authored
This is a reland of d201cbeb with the flaky tests disabled. Original change's description: > Run some file manager browsertests with DriveFS enabled. > > Bug: 848126 > Change-Id: Ifd3cf1996fdb33f5d0d93f5c5cf721abd5440d29 > Reviewed-on: https://chromium-review.googlesource.com/1102279 > Reviewed-by: Noel Gordon <noel@chromium.org> > Commit-Queue: Sam McNally <sammc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568339} Bug: 848126, 854600 Change-Id: Id04da7d9a670bc54bb968f681e6b610b52e16c2f Reviewed-on: https://chromium-review.googlesource.com/1109320 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#569151}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a58d69e90b91..cd70aa422ce6 git log a58d69e90b91..cd70aa422ce6 --date=short --no-merges --format='%ad %ae %s' 2018-06-20 ynovikov@chromium.org Always depend on libandroid for angle_util. 2018-06-20 geofflang@chromium.org Release the current context's surface before making the next context current. 2018-06-20 jmadill@chromium.org Vulkan: Remove obsolete TODO. 2018-06-20 lucferron@chromium.org GLES: Add skip for failing test 2018-06-20 fjhenigman@chromium.org Vulkan: get vertex formats from format table. 2018-06-20 lfy@google.com Reland "GLES1: Point rasterization (partial implementation)" 2018-06-20 jmadill@chromium.org Vulkan: Fix counting for shader texture bindings. Created with: gclient setdep -r src/third_party/angle@cd70aa422ce6 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I66953490c4df1f0385615b3c44911a8940192cc5 Reviewed-on: https://chromium-review.googlesource.com/1109417Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569150}
-
Koji Ishii authored
The implementation was missing. Includes rebaseline due to 1px position differences. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6520129899d8d9d7940cb06b55e49302ed477327 Reviewed-on: https://chromium-review.googlesource.com/1104618 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#569149}
-
Kenichi Ishibashi authored
Before this CL we haven't recorded following UMA in S13nSW path: - ServiceWorker.ActivatedWorkerPreparationForMainFrame.Type This CL adds recording this UMA. Bug: 852664 Change-Id: Iba8701e2a17dc857f26c5cc80ae5dc1075170c1f Reviewed-on: https://chromium-review.googlesource.com/1101606 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569148}
-
Dirk Pranke authored
Currently the Mac10.13 Tests bot runs the layout tests on 10.12; this is done because we didn't have enough capacity on 10.13 to run them. This CL is one of a series that is attempting to fix this. In this particular CL, this switches the test step from 100% 10.12 to 50% 10.13, and also updates the chromium.clang ToTMac and 'Chromium Mac 10.13' bots to get around the unneeded hacks. A subsequent CL will ramp this to 100% (non-experimental) once we're sure we have the capacity. BUG=853356 Change-Id: I4a772f4bd82f427fde1931417dd60d0f80a8d40a Reviewed-on: https://chromium-review.googlesource.com/1109458Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569147}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Ibfa312ac5be05773e1c7a8c087a1190d3ec9a093 Reviewed-on: https://chromium-review.googlesource.com/1109499Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#569146}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/081487b9fb06..a28b14f12246 git log 081487b9fb06..a28b14f12246 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@a28b14f12246 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Icddc4e2fb771f9df0bcac2f70accd5b14fcb03af Reviewed-on: https://chromium-review.googlesource.com/1108861Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569145}
-
Darren Shen authored
We replace instances of KeyboardController::container_ with the keyboard UI contents window. In most cases, we can directly replace them, but there are still some special considerations: - Container used to be created in the ctor, but Contents is created when we load the keyboard UI. So some operations used to be valid when we haven't loaded the UI, but now are not valid. In practice, this doesn't matter as we always preload the keyboard UI when we enable it. However, we should still figure out a sensible lifetime for the keyboard UI. - KeyboardLayoutManager used to be attached to the (old) Container, where we could guarantee that the only child is the contents window. Now it's attached to the (real) container, where we might want to have multiple children in the future. So some changes need to be made there. Change-Id: Ic2b42523565c2acf186ae66f43837ca28888be41 Bug: 849980 Reviewed-on: https://chromium-review.googlesource.com/1098753 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#569144}
-
Kenichi Ishibashi authored
Record the UMA in ServiceWorkerNewScriptLoader as it uses ServiceWorkerCacheWriter when S13nServiceWorker is enabled. Bug: 852667 Change-Id: I82007bcb8d6b1daee118d39e96570b1ba6921353 Reviewed-on: https://chromium-review.googlesource.com/1103432 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Joshua Peraza authored
edc8084c3bdc Roll mini_chromium to d5523a7 [fuchsia] Update to zx_cprng_draw_new fa47143c8c62 [fuchsia] Move to zx_take_startup_handle 85565c545cb1 Doc update for GN build 0a665e3c81a1 Suppress output when generating test server key 2771ebf805ae fuchsia: Package test cert and key when running in Fuchsia tree 639cba075c8d Use new Fuchsia kernel API to suspend threads c0a0d70a2b7a Increase max annotations size Change-Id: Id16830d847a07880c6b2750d0b5245da985b8996 Reviewed-on: https://chromium-review.googlesource.com/1109210Reviewed-by:Scott Graham <scottmg@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#569142}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5831b835bc15..0d22d3fa3ae1 git log 5831b835bc15..0d22d3fa3ae1 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 moragues@google.com chromeos_config: Add sign_types to nocturne release Created with: gclient setdep -r src/third_party/chromite@0d22d3fa3ae1 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6f5ab2ca93c9cade98b5033cd206bea6973e627f Reviewed-on: https://chromium-review.googlesource.com/1109318Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569141}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/825622bd..160d2815 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0005e6204b00408347a12579143e239cfd064dab Reviewed-on: https://chromium-review.googlesource.com/1108962Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569140}
-
Matt Menke authored
Mostly around downloads, which no longer use NetLog, but also some others as well. Bug: None Change-Id: Ia323d8486a4e8a35ce461aaa37ad910d6c09499d Reviewed-on: https://chromium-review.googlesource.com/1106218Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#569139}
-
codeimpl authored
The spec[1] says that the boundingBox attribute should be DOMRectReadOnly instead of DOMRect. [1] https://wicg.github.io/shape-detection-api/#detectedbarcode Bug: 852838 Change-Id: Ic38665031b6e91b77f6251613b1e7ffdf072945c Reviewed-on: https://chromium-review.googlesource.com/1102444 Commit-Queue: Byoungkwon Ko <codeimpl@gmail.com> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#569138}
-
Ryan Tseng authored
Bug: 815386, 790297 TBR: tandrii Change-Id: I60fd795bee0c0bf9d4b1ae9f0252de9d9624cbad Reviewed-on: https://chromium-review.googlesource.com/1109440Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#569137}
-
