- 30 Nov, 2020 40 commits
-
-
Chris Sharp authored
Also update description_guidelines.md to have a ph tag for Android. Bug: 1137865 Change-Id: Icfe0fff13d54e7c72003196c587dd3414ff8b129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562219 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#832059}
-
Matthew Mourgos authored
Change-Id: I4a3ab25d7da7397ef2f17077aea0f8d1f9adde9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565950 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#832058}
-
David Bertoni authored
These test were disabled for SW-based extensions due to flakiness. This CL uses a workaround to enable file access for the two tests that are flaky when restarted to remove file access. Bug: 1115182, 1146173 Change-Id: Id586996467847d42a6ec6eb60a034d0152a16d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380137 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Auto-Submit: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#832057}
-
Aaron Leventhal authored
This CL progresses towards removal of ShouldUseLayoutBuilderTraversal(), simplifying AddChildren() and removing conditions that lead to lack of symmetry in child-parent relationships. NOTRY: true Bug: None Change-Id: I195438d46522aad0c66da996df56d5716823992b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564380 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#832056}
-
chromium-autoroll authored
https://dawn.googlesource.com/tint.git/+log/aa212ee81f71..eac3c5bf5197 2020-11-30 dsinclair@chromium.org Add tricium config. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/tint-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I59c713a953b93ac63afae9706dd048c0923faf98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565890Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832055}
-
Toni Barzic authored
Note that transform animations may conflict with animation done for home to overview nudge. To avoid issues, provides an method to home_to_overview_nudge_controller to get the layer that should be used to animate hotseat while showing the nudge. The layer to be used for nudges is set to the hotseat widget delegate view (which is changed to paint to layer). BUG=None Change-Id: If73900d02e575d4437f1dd26d6b529f6787bf3e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557197Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#832054}
-
Livvie Lin authored
Cleanup since the feature has fully launched (crbug.com/1108425) Change-Id: Ib8573a164066e8fa3ac3312f1cf2d3a7199a5582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555884 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#832053}
-
Greg Thompson authored
Also remove the casting that was introduced in https://crrev.com/830328, as it is no longer necessary. BUG=1147071 Change-Id: Id41ef7ae9c8aff4f74c7e67e0024af651de0e239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550676 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#832052}
-
Aleks Totic authored
Based on TableCellPaintInvalidator. TablesNG paint algorithm differs from Legacy: - Table/Section/Row paint their background into cell's backgrounds. - Table column backgrounds are painted by table into cell's background. - All collapsed borders are painted by Table in foreground phase. Table's fragment size often does not change after layout. LayoutNG invalidates paint by default only if fragment size changes. Because of this, table paint has to be invalidated explicitly whenever grid is regenerated. Bug: 958381 Change-Id: I14c30a8bbab31b253f0bf5daf5ef4583f9079a9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563373Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#832051}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/7cbb98085a26..1eadcfb3be99 2020-11-30 srisser@google.com Accept Sign/Zero Extend operands in OpImageRead 2020-11-30 srisser@google.com Implement shaderSubgroupBroadcastDynamicId If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I8bc526e19758a9d93a00b3d8263631d0f259c635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565404Reviewed-by:
-
Robert Sesek authored
The latter is deprecated, and they have the same constant value, so no change in behavior. Bug: 1153883 Change-Id: I530981290fd5101995550e68d65a013f5722683e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564395 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#832049}
-
Jesse Schettler authored
The histograms are still monitored and used for OKR planning. Bug: 1151970 Change-Id: I13147270f2831dae5cc4da85deb5f18124dae302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565741 Auto-Submit: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#832048}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/eb386eb3d290..f819411f2a3c 2020-11-30 ehmaldonado@google.com [dirmd] Bump to 8d8dfbbee8184bf5f1c90c875e80d0dd58659f03 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Id62db623d8fd61527c842d19501073c425d460a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565116 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/140364ea8c33..494efc70ded6 2020-11-30 tsepez@chromium.org Tidy fxjs/cjs_global.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I7847a9d97821422e614bd9bd3f84bec67e740535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565406Reviewed-by:
-
Alex Newcomer authored
When available, use plain-text for html content. Otherwise show the placeholder "HTML Content" string. Bug: 1152856 Change-Id: Ifbe40c49fb106d5a30d259b98ab5c893953c0a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566035 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832045}
-
Michael Thiessen authored
It looks like when we send CTA to the background, then call finish() on it, it doesn't actually get Finished. Likely Android just doesn't bother actually finishing background Activities right away (maybe something to do with the launcher)? I haven't been able to reproduce the issue, but this appears to be the commonality between the failing tests, and this should fix it if so. If this works, I'll follow up with some infra changes to detect/advise in this case. Bug: 1153712 Change-Id: Ic46c30c99df390e0cf8c7d732c3a10535dddc2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565619 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#832044}
-
Joao Victor Almeida authored
For out-of-process iframes, the current code has the following values for the upper-bound that limits percent-based deltas: - the visualviewport size in blink (ScrollableArea::ResolveScrollDelta) - the iframe's size in CC (ThreadedInputHandler::ResolveScrollGranularityToPixels) In this CL we plumb the size of the visualviewport to LayerTreeHostImpl and update ThreadedInputHandler to use it, making CC and Blink behave the same when clamping percent-based scroll deltas. Bug: 1090075 Change-Id: I4aca6c13b49e7537abdbfff0843000de41a7fd7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376069Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Rahul Arakeri <arakeri@microsoft.com> Commit-Queue: João Victor Almeida de Aguiar <joalmei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#832043}
-
rbpotter authored
Currently, grit sets the key in the id dictionary for a grd file to its basename if the generated folder does not reside inside the src/ folder. This case occurs when building Chrome OS, and causes breakages if two generated grd files happen to have the same basename. To make this less fragile, match the file name to the ID using the full path after substitutions instead. Bug: 1150466 Change-Id: I5b491180b31035f7c7ddcab5113e138423ce2696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559635 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#832042}
-
Brandon Wylie authored
Change-Id: I6982068089cd7a90f2c5add9662a1991ee1121bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555473Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#832041}
-
Jesse Schettler authored
The Scan app can still be disabled by the ScanningUI feature flag and the SystemFeaturesDisableList enterprise policy. Bug: 1059779 Change-Id: I54e0115c619088cbbe2d07372717d3fe44f50106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553389 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#832040}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9941ec95. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Ica2c211606ba22e4c67c775e05a475822e129ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565618Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832039}
-
Akihiro Ota authored
Moving this out of http://crrev.com/c/2488081 for cleaner review. Usage of externs file can be found in that change. Bug: N/A Change-Id: I3596c377cf73b83f39ae74e9562be578499100c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564763Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e177dd9adffc..236d4f36e63d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xialinyan@google.com,rogerta@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1145230 Tbr: xialinyan@google.com,rogerta@google.com Change-Id: I917611e2caa90319539bad0d854e8a0f8ad430ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565394Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832037}
-
Sophie Chang authored
I still need to pass the download file to the store but will do that in the next CL to unblock Bug: 1146151 Change-Id: Ide99d8437c8601aae95e2ee4400970a3348bce77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565699 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#832036}
-
Sammie Quon authored
As per UX it is preferred we draw a shield over the wallpaper instead of using a color filter to mix the two together. It will make it work better in light mode since previously it was blending the colors with kDarken. Also, this fix a bug where tablet mode shield was too dark. Bug: 1145342 Test: manual Change-Id: I0ecd2b8fbd55eae029125c454887fffaf19e0406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551954Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#832035}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c4fbc8d6cf34..5b589fd27351 2020-11-30 johnstiles@google.com Add test for returning arrays from functions. 2020-11-30 johnstiles@google.com Fix ASAN error when inlining array constructor expressions. 2020-11-30 johnstiles@google.com Fix ASAN error when inlining multi-dimensional arrays. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: I798d8891c860b5ae63ede8ba2264159f103be947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565402Reviewed-by:
-
Mattias Nissler authored
This new device setting will supersede the existing "startup flags" setting. The latter was storing chrome://flags feature flags as raw command line switches, which turned out to be problematic since Chrome can't easily map the switches back to feature flags to validate them. Subsequent changes will add support for the new way of doing things as well as migration logic in session_manager and Chrome. BUG=chromium:1073940 TEST=None Change-Id: Id816469ab29e0458a36085655a5922a3dcb3e5bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565637Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#832033}
-
David Roger authored
The avatar images in profile UIs did not have any accessibility options, and the voice over was spelling out the whole image URL, which is a broken experience. The voice over label for the avatars is not strictly required, and thus this CL disables the voice over by passing an empty 'alt' attribute to the images. Fixed: 1151916 Change-Id: Ifd098e78842a3b01e1bd28d19baf8e2aac86c4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565432 Auto-Submit: David Roger <droger@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#832032}
-
Kenneth Russell authored
It's failing on that configuration as well. Bug: 1152259 Change-Id: Iacba1849f88cb5bb6f02315eb26d1b684ca3de95 Tbr: shrekshao@google.com Tbr: penghuang@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566330Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#832031}
-
Eric Lawrence [MSFT] authored
Clarify a comment by fixing a spelling error. Change-Id: I8ab42f402bae9b5706ad4915be2a7808f79490eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565395 Auto-Submit: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#832030}
-
Joe Downing authored
Change-Id: I4673b4bec0b3f2c0a75ec690124c5f2c02470de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565770Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#832029}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/2fe7335d34bc..6a7095d8c753 2020-11-30 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from aa212ee81f71 to eac3c5bf5197 (1 revision) 2020-11-30 enga@chromium.org Update ScissorTests to use WGSL 2020-11-30 enga@chromium.org Update DepthStencilCopyTests to use WGSL 2020-11-30 enga@chromium.org Update ObjectCachingTests to use WGSL 2020-11-30 jiawei.shao@intel.com Use FilterMode::Nearest in TextureFormatSamplingTests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: I9a3198ae179cd1b9e5841620762380bd477b25fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565891Reviewed-by:
-
David Bertoni authored
This test is flaky for Service Worker-based extensions due to reloading to remove file access. This CL adds the kEnableFileAccess flag as a workaround. Bug: 1127564 Change-Id: I9fe5728639169bdcb8ea8d05f3cb0081675cdd18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560608 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Roman Arora authored
Modified `Verify ShowUI()` test to avoid timing issues that can cause the test to flake and re-enabled it. Move the listenOnce/showUI logic to the ready() function of the component. Bug: 1148061 Change-Id: I1a583dcc1ba531b39e8f92a5f9b9faf4fcfc18e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538150Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#832026}
-
Ben Pastene authored
crrev.com/i/3438440 allocates the machines for this. Bug: 1140727 Change-Id: I0a4fee5f1d267ec698f20b740cbbc4e0619685c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564391Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#832025}
-
Aaron Leventhal authored
This logic doesn't make a difference in any tests. Notably: continuation.html in web tests passes. This CL progresses towards removal of ShouldUseLayoutBuilderTraversal(), simplifying AddChildren() and removing conditions that lead to lack of symmetry in child-parent relationships. Bug: None Change-Id: Ic436c4dd51ba7d12cd6adec0f7d35cdbab7dc487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563863Reviewed-by:
-
Tommy Li authored
This CL simplifies ProcessSyncChanges() to no longer attempt to uniquify keywords for engines. We can do that now because the preceding CL made Add() and Update() tolerant of engines with keyword conflicts: https://chromium-review.googlesource.com/c/chromium/src/+/2548160 The long explanation is here: go/chrome-search-engines-2020-improvements Bug: 1022775 Change-Id: If99d4d12510625b9474e4abfcb235c202f4911cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558911 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#832023}
-
Andrew Xu authored
In this CL, the code of MainButton and DeleteButton is moved to independent files instead of living in clipboard_history_item_view.cc. It improves the code readability. This CL should not introduce any visual differences. Bug: 1151493, 1152815 Change-Id: I16200f26ca1d5321a1407b6703e297f0b7d7fe89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556898Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832022}
-
Dan Harrington authored
Bug: b/173610894 Change-Id: I20bb9ebb59a04b6d13b8cc4a1a3fabfbf4c7d6be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558977 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#832021}
-
Xi Han authored
The bug was caused by cleaning up suppression tokens by the StartSurfaceStateObserver after leaving the start surface. In this CL, the following changes are made: 1) Two observers, StateObserver and the HintlessActivityTabObserver, share the same token to handle the suppression/unsuppression of the bottom sheet for tab switcher. 2) The suppression is done by the first observer who notices the tab switcher is shown. The token is reset after suppression to guarantee it can be used again to suppress the sheet. 3) Clearing up requests when transit from a tab to Start surface. This prevents the preview page (a kind of bottom sheet) from being shown on the Start surface. Bug: 1151804 Change-Id: I42a9405e46f863971dd439f03d31fed8eda46524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553286 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#832020}
-
![Eric Lawrence [MSFT]'s avatar](https://secure.gravatar.com/avatar/16e6d745c0e05bade0525857d18118ce?s=80&d=identicon "Eric Lawrence [MSFT]")
