- 21 Mar, 2018 40 commits
-
-
Nodir Turakulov authored
Update luci.chromium.{ci,try} defaults to use "cores:8" dimension. Update builders and mixins not to specify default values for cores, cpu and pool dimensions. Update some Mac GPU/Angle builders and mixins to use cores:4 or clear cores requirement because we have 4-core or a mix of 4-core and 8-core Macs. R=dpranke@chromium.org, kbr@chromium.org, tandrii@chromium.org No-Try: true Change-Id: I370a004c2c07e450a6c1426e5f7419b00d882536 Reviewed-on: https://chromium-review.googlesource.com/970907Reviewed-by:Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#544716}
-
Emily Hanley authored
Bug: 758630 Change-Id: I6cfe03cb7f2fd2d210ee370554af4044a10cfb59 Reviewed-on: https://chromium-review.googlesource.com/973183Reviewed-by:
Ashley Enstad <ashleymarie@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#544715}
-
Michael Lippautz authored
The method require heap access for every single check so it should live on Heap. Bug: chromium:757440 Change-Id: Id9f4530bbd488b2e23e64c0f959427ad662d72fa Reviewed-on: https://chromium-review.googlesource.com/973307Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#544714}
-
Becca Hughes authored
As the experiment was successful we are now proceeding with the launch of the overflow icons. This switches them on by default. BUG=763301 Change-Id: If3f2cf5dc4537a7fa700c56775827ccb4cd4663d Reviewed-on: https://chromium-review.googlesource.com/970342 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#544713}
-
Amirhossein Simjour authored
Cancel dialogs before destroying their View. Bug: 821443 Change-Id: Ifb0eb47cc60efa3e0b7e6354754d5db0fef38cda Reviewed-on: https://chromium-review.googlesource.com/969584Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/heads/master@{#544712}
-
Andrew Grieve authored
This regressed in be35cd67 Bug: 824141 Change-Id: I7975bc8dffbfafeec7f0a50bad4d75dfeefff0ee Reviewed-on: https://chromium-review.googlesource.com/973383 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#544711}
-
Hans Wennborg authored
The bot is using ToT clang (by setting LLVM_FORCE_HEAD_REVISION when running hooks), but it wasn't setting the corresponding gn flag. Currently this was causing the builds to fail due to not suppressing the new -Wignored-pragma-optimize warning in tip-of-tree clang. Bug: 495204 Change-Id: I857faf0dfb149a938f892187e9830e9b030c82cf Reviewed-on: https://chromium-review.googlesource.com/973284Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#544710}
-
Dianna Hu authored
Modify HpackEntry::GetDebugString() to use SpdyStringPrintf instead of the "+" concatenator. Some benefits: - Avoid the cost of the "+" operator. - Improve readability, slightly. - Avoid non-shared string methods. This CL lands server changes 187876536 by dlj and 189639795 by diannahu. BUG=488484 Change-Id: Ieb2dc7840460a4b7d38628a2e7c07440d4268139 Reviewed-on: https://chromium-review.googlesource.com/972431Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Dianna Hu <diannahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#544709}
-
https://pdfium.googlesource.com/pdfium.git/+log/9a635e812788..a17ac192c043 $ git log 9a635e812..a17ac192c --date=short --no-merges --format='%ad %ae %s' 2018-03-21 hnakashima Explain how CPDF_Page::GetDisplayMatrix() inverts y. 2018-03-21 thestig Fix some param names in the public API. 2018-03-21 thestig Change FXSYS_RGB() to FXSYS_BGR(). 2018-03-21 thestig Change FXSYS_Get{R,G,B}Value()'s input param to BGR. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I44753f4c9360d3816f38f60622e5d3cef55abddd Reviewed-on: https://chromium-review.googlesource.com/973462 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544708}
-
Danyao Wang authored
Bug: 822908 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iea189976c26ace0de8ff3461aef84ac2be01fc50 Reviewed-on: https://chromium-review.googlesource.com/972325 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#544707}
-
Andrew Grieve authored
It's used only by the browser process, so doesn't need to be in the main dex. Bug: 820570 Change-Id: I3f02e1f2d1255452f474db306e68583f8c7200e6 Reviewed-on: https://chromium-review.googlesource.com/971343 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#544706}
-
Jonathan Backer authored
Plumbs it through from client to service side. We track some TextureMetadata on the service side. I've opted to keep the separate from the per level metadata that TextureManager tracks. This will be used in future CLs that implement TexStorage2D and BindTexImage2D. Left a TODO for more validation in CreateAndConsumeTexture for validation of BufferUsage and ResourceFormat because it can't be tested until we implement TexStorage2D and/or BindTexImage2D. Bug: 789238 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6012c0351b69eb86504102aba6bff94afe07d3e7 Reviewed-on: https://chromium-review.googlesource.com/963285Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#544705}
-
Elad Alon authored
Destroy WebRtcEventLogManager rather than leak it, so as to deflake unit tests. Bug: 823318 Change-Id: Ibe255217eafe13569e1d86091dc71929adbaf646 Reviewed-on: https://chromium-review.googlesource.com/968874 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#544704}
-
Jérôme Lebel authored
Related to crrev.com/i/480972 and crrev.com/c/973229. Bug: 516021 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I61578ae5d44d7b61b40ae5b4a6e1df9ac923137c Reviewed-on: https://chromium-review.googlesource.com/973303 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#544703}
-
Sadrul Habib Chowdhury authored
|embed_token_| explains better what this field is used for, so use that name instead of |nonce_|. Update the doc to include a little more info. BUG=none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ib292618377b7ccc75204cf15096b7544bd120c50 Reviewed-on: https://chromium-review.googlesource.com/972341Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#544702}
-
https://skia.googlesource.com/skia.git/+log/f3015114b51e..0e2eeee3bcf0 $ git log f3015114b..0e2eeee3b --date=short --no-merges --format='%ad %ae %s' 2018-03-20 robertphillips Move DDL TSAN bot to Release & add Release DDL ASAN bot Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I06b9b7cec1ade8ac174b1ecf668ac2f4f66a3b7e Reviewed-on: https://chromium-review.googlesource.com/973262Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#544701}
-
jdoerrie authored
Since dgn@ does not work on Chrome anymore, this change updates the bug link to add agrieve@ as the bug owner. Bug: NONE Change-Id: I00d5de07d8b329d1f95856f3c0582a7f35b0054f Reviewed-on: https://chromium-review.googlesource.com/973204 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#544700}
-
Evan Stade authored
Remove ability to implicitly convert between mojo type string and base::string16 See 86836ab2 Bug: 816970 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5633ff8d5b6bba56ea568d0f49a38d1d4157b6b1 Reviewed-on: https://chromium-review.googlesource.com/965453Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#544699}
-
Devlin Cronin authored
There's a crash happening when a JSRunner associated with a context (which is checked to be valid) somehow doesn't exist. This shouldn't happen, but somehow is. This patch adds checks that if a context is considered to be valid, it has an associated JSRunner. This also slightly reorders tear down flow in order to match this requirement, putting context invalidation prior to JSRunner deletion. Bug: 819968 Change-Id: I0e0d634f3e8c910cf50a157dfa367119be522d9a Reviewed-on: https://chromium-review.googlesource.com/972571Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544698}
-
Matt Menke authored
It can take an order of magnitude more time to spin a message loop and handle a result asynchronously than it does to handle the same result synchronously, and tests were timing out as a result. Placing a limit on async results will hopefully reduce the number of fuzzers using FuzzedSocket that time out. Bug: 823012 Change-Id: I110fbf2ce0b96cce12cb84ea21c3f44e6b45005b Reviewed-on: https://chromium-review.googlesource.com/972377 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#544697}
-
Tom Anderson authored
BUG=787020 TBR=dpranke Change-Id: Icd2361485c27486ef4676ea9c8725bf959d36a21 Reviewed-on: https://chromium-review.googlesource.com/972448Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544696}
-
Vaclav Brozek authored
This CL adds a unit test for PasswordManagerPresenter (which provides passwords for exporting on desktop and Android), checking that blacklisted passwords are not included among those being exported. Bug: 819138 Change-Id: Ia63eac7abc20179c3f2775186bf11cefdd36f86a Reviewed-on: https://chromium-review.googlesource.com/971101Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#544695}
-
Tom Anderson authored
BUG=812950 Change-Id: Ic729b195d151480e2123fe490df8d6cce89a3198 Reviewed-on: https://chromium-review.googlesource.com/969333Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#544694}
-
Becca Hughes authored
Adds sort key handler for isHigh which will allow users to sort by "isHigh" when using chrome://media-engagement. BUG=792906 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I11db5ddf4843faca361eb9016535d582e6230fa5 Reviewed-on: https://chromium-review.googlesource.com/970584Reviewed-by:
-
Matthew Cary authored
Starting from Android O it is no longer possible to run any of the processes isolated. However, it is not necessary if SELinux is in permissive mode, which the orderfile generator sets (see tools/cygprofile/profile_android_startup.py in _SetUpDevice). This CL therefore removes the orderfile-specific changes to the android manifest for all builds. Bug: 758566 Change-Id: If3a8e0a3f0dfe81b034b4e0b080db53f661ef265 Reviewed-on: https://chromium-review.googlesource.com/970660Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#544692}
-
David Bokan authored
This prevents ScrollbarTestWithVirtualTimer from polluting global state for tests following it. Bug: 791742 Change-Id: Iae3440451833408a6a5bd24b3319b307cd6d3547 Reviewed-on: https://chromium-review.googlesource.com/969582 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#544691}
-
Florin Malita authored
virtual/gpu-rasterization/images/imagemap-focus-ring-outline-color-not-inherited-from-map.html virtual/gpu/fast/canvas/canvas-composite-video-shadow.html virtual/gpu/fast/canvas/canvas-composite-video.html BUG=785931 TBR= Change-Id: I57a89b21d76cf69b1608b7cac79fc785a5e0b0de Reviewed-on: https://chromium-review.googlesource.com/971834Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#544690}
-
edchin authored
This CL updates the correct page scroll offset and toolbar configuration upon rotation. Bug: 804603 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I055ce3f63204393bdc8ced23f8ed3ec212b0eab8 Reviewed-on: https://chromium-review.googlesource.com/972666Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#544689}
-
https://pdfium.googlesource.com/pdfium.git/+log/765d1ebe41de..9a635e812788 $ git log 765d1ebe4..9a635e812 --date=short --no-merges --format='%ad %ae %s' 2018-03-21 franzih Replace deprecated SetNamedPropertyHandler Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id4d62d88ed3bf6f07b3482259c400f982ad2b47c Reviewed-on: https://chromium-review.googlesource.com/973182 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Mark Cogan authored
In some cases, there may be no visible items in a grid, so the selected item will be nil, which is never a member of any collection. This CL updates the DCHECK condition in [GridTransitionLayout setSelectedItem:] to not trigger in this case. Bug: 822912 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I845355feee5f4af1d3443ff3d362aae45c05d9c9 Reviewed-on: https://chromium-review.googlesource.com/973121Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#544687}
-
Thiemo Nagel authored
Add per-request metrics for cookie age based on individual cookies (not just for the oldest cookie in the request) and split by {secure,non-secure} x {same-site,cross-site}. Bug: 749059 Change-Id: I0ef5fba95df226da05ea56537984264a0bce5941 Reviewed-on: https://chromium-review.googlesource.com/962601 Commit-Queue: Thiemo Nagel <tnagel@chromium.org> Reviewed-by:Ilya Sherman <isherman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#544686}
-
qi1988.yang authored
Fix the TODO(crbug.com/822317): Rename to Allowlist Bug:822317 Signed-off-by:
qi1988.yang <qi1988.yang@samsung.com> Change-Id: I1dd676fd5953b4cfc90e6b24d75ab9e3d69bc4da Reviewed-on: https://chromium-review.googlesource.com/968043Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Luna Lu <loonybear@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#544685}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/09e7152e..ad47b297 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I877790dfd8f5bb906ee2ccb903b1ef8a6d70a051 Reviewed-on: https://chromium-review.googlesource.com/972866Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#544684}
-
Alexander Potapenko authored
It has been flaky for too long. BUG=823484 TBR=nyquist@chromium.org,mamir@chromium.org Change-Id: Iee085516ea05d98d3fddd6620005818a822bc0ab Reviewed-on: https://chromium-review.googlesource.com/973223Reviewed-by:
Alexander Potapenko <glider@chromium.org> Commit-Queue: Alexander Potapenko <glider@chromium.org> Cr-Commit-Position: refs/heads/master@{#544683}
-
Becca Hughes authored
Add a 'AutoplayOriginsWhitelist' managed policy setting that allows autoplay on these origins (e.g. for internal enterprise websites). BUG=821379 Change-Id: I7bde18ef1c68741af5645f184c910b779002fdf7 Reviewed-on: https://chromium-review.googlesource.com/960666Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
-
Manuel Rego Casasnovas authored
We have been calling testGridTemplateColumnsRows() with and without arrays. Arrays are needed because the serialization of 2 tracks of the same size can be "100px 100px" or "repeat(2, 100px)". But in the rest of the cases we don't need an array, so we call the method with a single value. testGridTemplateColumnsRows() was not ready to support that, and it wasn't actually checking anything in that case. The patch modifies testing-utils.js, so it wraps values in an array when required. Now testGridTemplateColumnsRows() will be actually checking things. Change-Id: I7e360677c391df74dedb474922bf5c04247141c5 Reviewed-on: https://chromium-review.googlesource.com/973063Reviewed-by:
Sergio Villar <svillar@igalia.com> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#544681}
-
Olivier Robin authored
Material components marks some of its API as deprecated but still use them internally and recommends not treating those warning as error [1]. Disable the warnings when compiling material_components_ios. [1]: https://github.com/material-components/material-components-ios/tree/develop/howto/build-env Bug: 823767 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I377c971130372e80109e54cd29dd21def29067d2 Reviewed-on: https://chromium-review.googlesource.com/973002 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Stephen McGruer authored
This is a reland of c838bf40 The original CL contained two subtle bugs from a comparison of compositor_state_->start_time to start_time_. Previously if both were 'null' (represented by NaN), the comparison would still say they were inequal because NaN != NaN. The original CL 'fixed' those comparisons, but it turns out the behavior was intentional. This version of the CL restores the intentional behavior, adds a test for it, and documents it. Bug: 791086, 819591 Change-Id: I6587d028e66c6f6a9213b60f8d5f51b1dac3f899 Reviewed-on: https://chromium-review.googlesource.com/956280Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#544679}
-
Brian White authored
Bug: 810766 Change-Id: Ib2804c6218211e75ca2f98d6ddc345740e599d32 Reviewed-on: https://chromium-review.googlesource.com/969406Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#544678}
-
Alexander Potapenko authored
This reverts commit e944fadd. Reason for revert: https://crbug.com/653609 (tl;dr tests are still flaky) BUG=653609 TBR=yolandyan@chromium.org, dtrainor@chromium.org Original change's description: > Try runnining flaky download notification tests > > This flake might be caused by the test not properly set up, which > is fixed in the upstream CL. Please revert if the flake comes back > > Bug: 773346 > Change-Id: Ifae64c5e1cbf1319501f281162692d2dcfb22e07 > Reviewed-on: https://chromium-review.googlesource.com/894639 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Reviewed-by: Joy Ming <jming@chromium.org> > Commit-Queue: Yoland Yan <yolandyan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533430} TBR=dtrainor@chromium.org,yolandyan@chromium.org,jming@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 773346 Change-Id: Iab1f7b6d07dda46ae34c935604ac87c6f4901cb3 Reviewed-on: https://chromium-review.googlesource.com/973281Reviewed-by:
-
