GitLab

* Stop calling GetIconID() as a proxy for having RTTI to detect
  ThreeDAPIInfoBarDelegates.  Just add a downcast function.
* Slightly more reasonable base class function order.
* Fix declaration/definition orders to match base class (and each other) in
  other instances where it was noticeably wrong.
* Keep infobar code consistent about not inlining method definitions in class
  declarations, and making overridden functions private unless otherwise
  necessary.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/922953002

Cr-Commit-Position: refs/heads/master@{#317685}

This brings in:

28ddd48  Replace second set of #defines with templates in JS_Define.h
94dd28e  Update GN build files w/ cpu_arch -> current_cpu changes.
dce5730  Add test for PDF's JS "global".
a96cc9b  Replace ugly JS_Define macros with templates.
2da7bd4  Tidy up JS_Defines.h
7435e8e  Run pixel tests via automated script.
83c87e5  run_javascript_tests.py: Be more flexible about directory layout.

TBR=jam@chromium.org, tsepez@chromium.org
BUG=344767

Review URL: https://codereview.chromium.org/948933003

Cr-Commit-Position: refs/heads/master@{#317684}

R=lcwu@chromium.org,byungchul@chromium.org
BUG=internal b/18934906

Review URL: https://codereview.chromium.org/947993003

Cr-Commit-Position: refs/heads/master@{#317683}

SrcAttribute.setValueIgnoreMutation was calling takeRecords() prior to applying the operation,
which meant it didn't actually do the right thing. Mutation callbacks would still get queued
up by the mutation observer. This wasn't noticed because WebViewImpl.onLoadCommit only called
setValueIgnoreMutation if there was a change in value, and so the mutation observer would not
trigger any mutations. This CL fixes this issue and simplifies the code in WebViewImpl.onLoadCommit
a bit.

This CL moves setting NameAttribute details from WebViewImpl and into the NameAttribute object.

This CL also fixes some attribute changes to make sure their mutation handlers don't fire.

Finally, this CL moves setupEventProperty to web_view_events.js where it makes more sense to be.

BUG=none
TBR=lazyboy@chromium.org

Review URL: https://codereview.chromium.org/954543002

Cr-Commit-Position: refs/heads/master@{#317682}

BUG=459632
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/951083002

Cr-Commit-Position: refs/heads/master@{#317681}

This also adds app_shell_unittests to the :root target.

BUG=None

Review URL: https://codereview.chromium.org/930933003

Cr-Commit-Position: refs/heads/master@{#317680}

Currently if an app needs to whitelist with feedback, it needs to put its
original ID into the event_handler JS. We want apps to be able to keep their
ids private and still be able to whitelist themselves. Hence we now check
the sha-256 hash of the app id instead of the app id itself.

R=arv@chromium.org
BUG=453587

Review URL: https://codereview.chromium.org/942123004

Cr-Commit-Position: refs/heads/master@{#317679}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1199970..abc2d6b

TBR=zmo@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/948153002

Cr-Commit-Position: refs/heads/master@{#317678}

R=reed@google.com

Review URL: https://codereview.chromium.org/951623002

Cr-Commit-Position: refs/heads/master@{#317677}

In the previous commit, I made a wrong assumption that
policy::Schema::Normalize will always set the |changed|
parameter.  This has been fortunately caught by the Valgrind/FYI bot.

BUG=427513

Review URL: https://codereview.chromium.org/947313003

Cr-Commit-Position: refs/heads/master@{#317676}

Part 1 of reland of https://codereview.chromium.org/900063002.

R=danakj@chromium.org
BUG=453731,455104,457248

Review URL: https://codereview.chromium.org/950923002

Cr-Commit-Position: refs/heads/master@{#317675}

expensive calls if connection type has changed or if connection description was null.

Defined a new class to cache the connection
description and this class is owned by QuicStreamFactory.

This fixes the Jank on IO thread and avoids call to GetWifiPHYLayerProtocol
(which takes around 40ms).

BUG=422516
R=rch@chromium.org

Review URL: https://codereview.chromium.org/944883003

Cr-Commit-Position: refs/heads/master@{#317674}

Previously streams would be intercepted even if the MimeHandlerView plugin
associated with them was disabled which would prevent the resource
from being download if a plugin wasn't being enabled to handle it.

BUG=459383

Review URL: https://codereview.chromium.org/933093002

Cr-Commit-Position: refs/heads/master@{#317673}

https://chromium.googlesource.com/angle/angle/+log/6df9b3..7825f6

Update EGL enums used with ANGLE_platform_angle_d3d from the latest
version of the extension.

BUG=angle:490

Review URL: https://codereview.chromium.org/954513002

Cr-Commit-Position: refs/heads/master@{#317672}

Prior to this commit, Telemetry on Linux Desktop was X11 oriented. The changes
introduced here allow other graphics architectures through Ozone as well for
testing, by recognizing a specific extra browser arguments "--ozone-platform".

For example one can use it as following:

./run_benchmark --browser=exact --browser-executable=./out/Release/chrome --extra-browser-args="--ozone-platform=gbm" <benchmark>

BUG=None

Review URL: https://codereview.chromium.org/901143006

Cr-Commit-Position: refs/heads/master@{#317671}

Revert of Re-enable some HistoryApiTests (patchset #1 id:1 of https://codereview.chromium.org/926283003/)

Reason for revert:
All of these tests are still flaky, so reverting it will re-disable the tests.

Original issue's description:
> Re-enable some HistoryApiTests
>
> Currently HistoryApiTest.Delete, HistoryApiTest.GetVisits, and HistoryApiTest.SearchAfterAdd are disabled. These do not flake or time out locally nor on the try bots, so this CL re-enables them.
>
> BUG=88318, 79074, 76170
>
> Committed: https://crrev.com/f1c7ab473515bf887dcf628f9c004c3114a5f862
> Cr-Commit-Position: refs/heads/master@{#316680}

TBR=rdevlin.cronin@chromium.org
BUG=88318, 79074, 76170

Review URL: https://codereview.chromium.org/943413003

Cr-Commit-Position: refs/heads/master@{#317670}

This should catch the following usages:

1- return scoped_ptr<T>(foo)
2- bar = scoped_ptr<T>(foo)

And recommend the solo usage of make_scoped_ptr().

The entries were found with the following command line:

$ git grep -E '(=|\breturn)\s*scoped_ptr<.*?>([^)]+)'

BUG=None
TEST=g cl presubmit -uv
R=sky@chromium.org,maruel@chromium.org

Review URL: https://codereview.chromium.org/919253002

Cr-Commit-Position: refs/heads/master@{#317669}

Revert of Re-enable memory.top_7_stress test now that bug 455349 is fixed. (patchset #1 id:1 of https://codereview.chromium.org/940283007/)

Reason for revert:
This is still failing on the bots, with a facebook login failure: http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%283%29/builds/9314/steps/memory.top_7_stress.reference/logs/stdio

Original issue's description:
> Re-enable memory.top_7_stress test now that bug 455349 is fixed.
>
> BUG=459646
>
> Committed: https://crrev.com/92fb7ce426ebe966630fbd0de62e59cee91a6e74
> Cr-Commit-Position: refs/heads/master@{#317606}

TBR=petrcermak@chromium.org,primiano@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=459646

Review URL: https://codereview.chromium.org/942113005

Cr-Commit-Position: refs/heads/master@{#317668}

BUG=413998
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/935913002

Cr-Commit-Position: refs/heads/master@{#317667}

BUG=298193
TEST=
TBR=creis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/951613004

Cr-Commit-Position: refs/heads/master@{#317666}

Revert of Move base_dir to user_story_set, remove file_path. (patchset #4 id:60001 of https://codereview.chromium.org/946473002/)

Reason for revert:
breaks on main waterfall, i.e.
http://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/21577/steps/telemetry_unittests/logs/stdio

  AssertionError: 'E:\\b\\build\\slave\\Win_7_Tests_x64__1_\\build\\src\\tools\\telemetry\\telemetry\\user_story\\user_story_set_unittest.pyc' != 'E:\\b\\build\\slave\\Win_7_Tests_x64__1_\\build\\src\\tools\\telemetry\\telemetry\\user_story\\user_story_set_unittest.py'

not sure why this fails on main waterfall but not trybots?

Original issue's description:
> Move base_dir to user_story_set, remove file_path.
>
> BUG=454531
>
> Committed: https://crrev.com/65ff7d22f8986ab2832045af09160dc753e40c5f
> Cr-Commit-Position: refs/heads/master@{#317632}

TBR=chrishenry@google.com,dtu@chromium.org,sullivan@chromium.org,nednguyen@google.com,aiolos@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=454531

Review URL: https://codereview.chromium.org/951593003

Cr-Commit-Position: refs/heads/master@{#317665}

CLs.

BUG=260022,350202

Review URL: https://codereview.chromium.org/872433006

Cr-Commit-Position: refs/heads/master@{#317664}

This CL enables PIN browser tests on the waterfall.
It introduce in a timeout in ConnectMe2Me to account for the asynchronous
click handler hooking of the 'this-host-connect' button.

BUG=399839
TEST=Test Passed on Chromoting waterfall.

See https://chromium-swarm.appspot.com/user/tasks?sort=created_ts&state=all&limit=10&task_name=chromoting_integration_tests.

Review URL: https://codereview.chromium.org/940713003

Cr-Commit-Position: refs/heads/master@{#317663}

This CL also exposes the property tabs on the class TabTestCase.

BUG=442546

Review URL: https://codereview.chromium.org/940153002

Cr-Commit-Position: refs/heads/master@{#317662}

Revert of cc: Increase kMaxCopyOperations to 32. (patchset #1 id:1 of https://codereview.chromium.org/937843006/)

Reason for revert:
This is likely to cause a crash on the Webkit Linux MSAN bot:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=virtual/gpu/fast/canvas/canvas-path-context-clip.html

Below is the stack:

crash log for gpu (pid <unknown>):
STDOUT: #CRASHED - gpu
STDERR: [21350:21350:1203/112619:8509072119133:FATAL:gles2_cmd_copy_texture_chromium.cc(263)] Check failed: !buffer_id_.
STDERR: #0 0x7f2ee72e416e base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f2ee737e965 logging::LogMessage::~LogMessage()
STDERR: #2 0x7f2ee598c5be gpu::CopyTextureCHROMIUMResourceManager::~CopyTextureCHROMIUMResourceManager()
STDERR: #3 0x7f2ee59e48ae base::DefaultDeleter<>::operator()()
STDERR: #4 0x7f2ee59e486b base::internal::scoped_ptr_impl<>::reset()
STDERR: #5 0x7f2ee59d467d scoped_ptr<>::reset()
STDERR: #6 0x7f2ee59b373f gpu::gles2::GLES2DecoderImpl::Destroy()
STDERR: #7 0x7f2ee2332bd9 content::GpuCommandBufferStub::Destroy()
STDERR: #8 0x7f2ee2332665 content::GpuCommandBufferStub::~GpuCommandBufferStub()
STDERR: #9 0x7f2ee2332ca9 content::GpuCommandBufferStub::~GpuCommandBufferStub()
STDERR: #10 0x7f2ee231d72e IDMap<>::Releaser<>::release()
STDERR: #11 0x7f2ee231cd4d IDMap<>::Remove()
STDERR: #12 0x7f2ee231a252 content::GpuChannel::OnDestroyCommandBuffer()
STDERR: #13 0x7f2ee231e3da DispatchToMethod<>()
STDERR: #14 0x7f2ee231e21d IPC::SyncMessageSchema<>::DispatchWithSendParams<>()
STDERR: #15 0x7f2ee231c8ad GpuChannelMsg_DestroyCommandBuffer::Dispatch<>()
STDERR: #16 0x7f2ee2319731 content::GpuChannel::OnControlMessageReceived()
STDERR: #17 0x7f2ee2318583 content::GpuChannel::HandleMessage()
STDERR: #18 0x7f2ee23208e2 base::internal::RunnableAdapter<>::Run()
STDERR: #19 0x7f2ee23207f3 base::internal::InvokeHelper<>::MakeItSo()
STDERR: #20 0x7f2ee2320795 base::internal::Invoker<>::Run()
STDERR: #21 0x7f2ee72cc5be base::Callback<>::Run()
STDERR: #22 0x7f2ee72ea7a9 base::debug::TaskAnnotator::RunTask()
STDERR: #23 0x7f2ee73a76d8 base::MessageLoop::RunTask()
STDERR: #24 0x7f2ee73a783b base::MessageLoop::DeferOrRunPendingTask()
STDERR: #25 0x7f2ee73a7a75 base::MessageLoop::DoWork()
STDERR: #26 0x7f2ee72a012e base::MessagePumpGlib::Run()
STDERR: #27 0x7f2ee73a71a2 base::MessageLoop::RunHandler()
STDERR: #28 0x7f2ee740ff94 base::RunLoop::Run()
STDERR: #29 0x7f2ee73a68e1 base::MessageLoop::Run()
STDERR: #30 0x7f2ee23bed92 content::GpuMain()
STDERR: #31 0x7f2ee142f02f content::RunNamedProcessTypeMain()
STDERR: #32 0x7f2ee14333a2 content::ContentMainRunnerImpl::Run()
STDERR: #33 0x7f2ee142e4d5 content::ContentMain()
STDERR: #34 0x00000044ec9c main
STDERR: #35 0x7f2ed82f676d __libc_start_main
STDERR: #36 0x00000044eb89 <unknown>
STDERR:
STDERR: Received signal 6
STDERR: #0 0x7f2ee72e416e base::debug::StackTrace::StackTrace()
STDERR: #1 0x7f2ee72e3ca3 base::debug::(anonymous namespace)::StackDumpSignalHandler()
STDERR: #2 0x7f2ed86a4cb0 <unknown>
STDERR: #3 0x7f2ed830b425 gsignal
STDERR: #4 0x7f2ed830eb8b abort
STDERR: #5 0x7f2ee72e02f6 base::debug::(anonymous namespace)::DebugBreak()
STDERR: #6 0x7f2ee72e02d9 base::debug::BreakDebugger()
STDERR: #7 0x7f2ee737ecca logging::LogMessage::~LogMessage()
STDERR: #8 0x7f2ee598c5be gpu::CopyTextureCHROMIUMResourceManager::~CopyTextureCHROMIUMResourceManager()
STDERR: #9 0x7f2ee59e48ae base::DefaultDeleter<>::operator()()
STDERR: #10 0x7f2ee59e486b base::internal::scoped_ptr_impl<>::reset()
STDERR: #11 0x7f2ee59d467d scoped_ptr<>::reset()
STDERR: #12 0x7f2ee59b373f gpu::gles2::GLES2DecoderImpl::Destroy()
STDERR: #13 0x7f2ee2332bd9 content::GpuCommandBufferStub::Destroy()
STDERR: #14 0x7f2ee2332665 content::GpuCommandBufferStub::~GpuCommandBufferStub()
STDERR: #15 0x7f2ee2332ca9 content::GpuCommandBufferStub::~GpuCommandBufferStub()
STDERR: #16 0x7f2ee231d72e IDMap<>::Releaser<>::release()
STDERR: #17 0x7f2ee231cd4d IDMap<>::Remove()
STDERR: #18 0x7f2ee231a252 content::GpuChannel::OnDestroyCommandBuffer()
STDERR: #19 0x7f2ee231e3da DispatchToMethod<>()
STDERR: #20 0x7f2ee231e21d IPC::SyncMessageSchema<>::DispatchWithSendParams<>()
STDERR: #21 0x7f2ee231c8ad GpuChannelMsg_DestroyCommandBuffer::Dispatch<>()
STDERR: #22 0x7f2ee2319731 content::GpuChannel::OnControlMessageReceived()
STDERR: #23 0x7f2ee2318583 content::GpuChannel::HandleMessage()
STDERR: #24 0x7f2ee23208e2 base::internal::RunnableAdapter<>::Run()
STDERR: #25 0x7f2ee23207f3 base::internal::InvokeHelper<>::MakeItSo()
STDERR: #26 0x7f2ee2320795 base::internal::Invoker<>::Run()
STDERR: #27 0x7f2ee72cc5be base::Callback<>::Run()
STDERR: #28 0x7f2ee72ea7a9 base::debug::TaskAnnotator::RunTask()
STDERR: #29 0x7f2ee73a76d8 base::MessageLoop::RunTask()
STDERR: #30 0x7f2ee73a783b base::MessageLoop::DeferOrRunPendingTask()
STDERR: #31 0x7f2ee73a7a75 base::MessageLoop::DoWork()
STDERR: #32 0x7f2ee72a012e base::MessagePumpGlib::Run()
STDERR: #33 0x7f2ee73a71a2 base::MessageLoop::RunHandler()
STDERR: #34 0x7f2ee740ff94 base::RunLoop::Run()
STDERR: #35 0x7f2ee73a68e1 base::MessageLoop::Run()
STDERR: #36 0x7f2ee23bed92 content::GpuMain()
STDERR: #37 0x7f2ee142f02f content::RunNamedProcessTypeMain()
STDERR: #38 0x7f2ee14333a2 content::ContentMainRunnerImpl::Run()
STDERR: #39 0x7f2ee142e4d5 content::ContentMain()
STDERR: #40 0x00000044ec9c main
STDERR: #41 0x7f2ed82f676d __libc_start_main
STDERR: #42 0x00000044eb89 <unknown>
STDERR:   r8: 000000000000007c  r9: 0000000000500000 r10: 0000000000000008 r11: 0000000000000206
STDERR:  r12: 000000000044eb60 r13: 00007fff5e500ac0 r14: 0000000000000000 r15: 0000000000000000
STDERR:   di: 0000000000005366  si: 0000000000005366  bp: 00007fff5e4fd330  bx: 0000000000000000
STDERR:   dx: 0000000000000006  ax: 0000000000000000  cx: ffffffffffffffff  sp: 00007fff5e4fd1f8
STDERR:   ip: 00007f2ed830b425 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000
STDERR:  trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000

Original issue's description:
> cc: Increase kMaxCopyOperations to 32.
>
> Increase max number of copy operations from 16 to 32. This
> improves the throughput on systems where raster performance
> is relatively high.
>
> BUG=454898
>
> Committed: https://crrev.com/ed9a3edff6bffc58ff37c2bd78b768062771b647
> Cr-Commit-Position: refs/heads/master@{#317614}

TBR=vmpstr@chromium.org,vangelis@chromium.org,reveman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=454898

Review URL: https://codereview.chromium.org/941253003

Cr-Commit-Position: refs/heads/master@{#317661}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1e3ab69..1199970

TBR=zmo@chromium.org,hiroshige@chromium.org

Review URL: https://codereview.chromium.org/953573002

Cr-Commit-Position: refs/heads/master@{#317660}

Fix +x on Windows-only binary after https://chromium.googlesource.com/chromium/src/+/92d69f7733f4028cf8b3d5b4b97a31173e687594

TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/948923002

Cr-Commit-Position: refs/heads/master@{#317659}

The median run time is 30 minutes now and it'll drop after the recent fix to make it use analyze.

BUG=453471

Review URL: https://codereview.chromium.org/954463002

Cr-Commit-Position: refs/heads/master@{#317658}

Review URL: https://codereview.chromium.org/944143002

Cr-Commit-Position: refs/heads/master@{#317657}

With the NPAPI deprecation, Adobe have now made a supported, automatically updating version of Pepper Flash available on Windows and OS X.

This CL moves the code previously added in https://codereview.chromium.org/203993004 into chrome/common so the system plugin is added on all Chromium builds.

To manually override bundled PepperFlash on Chrome (e.g. to load a Debug version), use --disable-bundled-ppapi-flash

BUG=345886,454131
TEST=Install PPAPI Flash from Adobe site (link in bug)
TEST=For Chromium builds: Check Chromium now automatically uses system version of Flash in chrome://plugins.
TEST=For Chrome builds: Check Chrome still uses bundled Flash by default.  Check if --disable-bundled-ppapi-flash it uses system flash.
TEST=Check an old version of System flash will pop out of date plugin warning.

Review URL: https://codereview.chromium.org/893823002

Cr-Commit-Position: refs/heads/master@{#317656}

This was originally added by this CL:
https://chromiumcodereview.appspot.com/15714003

But later broke when the code was componentized here:
https://codereview.chromium.org/116863002

This CL restores the original functionality and adds
a test to hopefully prevent it from regressing in the
future.

BUG=460604

Review URL: https://codereview.chromium.org/942863003

Cr-Commit-Position: refs/heads/master@{#317655}

For enabling UMA uploads on cellular networks upload interval should be increased to 15min instead of 5min which according to initial experiments showed to decrease average overall size of the upload.

This behavior is enabled for users which are assigned to Finch experiment.

BUG=455847

Review URL: https://codereview.chromium.org/922383003

Cr-Commit-Position: refs/heads/master@{#317654}

Review URL: https://codereview.chromium.org/945143002

Cr-Commit-Position: refs/heads/master@{#317653}

This fixes three more TODO(GYP)s.

BUG=None
TEST=trybots
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/946873002

Cr-Commit-Position: refs/heads/master@{#317652}

This fixes the hang that caused the addition of the early out in
stack_trace_win.cc.

Removing that in turn fixes symbolization of stack traces on XP bots.

R=cpu@chromium.org
BUG=460506

Review URL: https://codereview.chromium.org/943933005

Cr-Commit-Position: refs/heads/master@{#317651}

This can be tested with the following command lines in a Mac computer:

$ gn gen out-gn
$ ninja -C out-gn apple_sample_code molokocacao

BUG=None
TEST=see above
R=avi@chromium.org,mark@chromium.org

Review URL: https://codereview.chromium.org/946963002

Cr-Commit-Position: refs/heads/master@{#317650}

This was a failed experiment. The jumplist is way too fragile and finicky
to be a good, long term solution for a fast-profile-switcher (mostly because
it can only display up to 10 profiles).

This code was initially introduced in https://codereview.chromium.org/660813002/
(with a followup CL to fix it), but that CL also introduced some useful
jumplist related metrics, so I'll just manually revert the jumplist bits.

BUG=431392

Review URL: https://codereview.chromium.org/931853003

Cr-Commit-Position: refs/heads/master@{#317649}

Revert of Fixes for two different HUD issues related to win32k lockdown (patchset #9 id:350001 of https://codereview.chromium.org/900063002/)

Reason for revert:
Causes regression in cold start on Android and maybe Mac.

Details in http://crbug.com/457248.

Original issue's description:
> Fixes for two different HUD issues related to win32k lockdown
>
> 1. Using a GDI bitmap -- switch to SkSurface instead
>
> 2. Lazily loading a font. This breaks for two different reasons.
> The first is a DCHECK for doing IO on the Compositor thread. This
> could have been just ignored in general since it's only for debug
> usage, the drawbacks of minor jank are limited.
>
> However, once lockdown is on, the font load hard fails from the
> renderer. So, load the typeface before lockdown and pass it into
> CC and the hud via LayerTreeSettings.
>
> R=danakj@chromium.org
> BUG=453731,455104
> TEST=run chrome with --enable-win32k-renderer-lockdown --show-fps-counter --ui-show-fps-counter on Win8
>
> Committed: https://crrev.com/616a8e656b2d923ed393bde86adc150e555ba799
> Cr-Commit-Position: refs/heads/master@{#314929}

TBR=enne@chromium.org,danakj@chromium.org,piman@chromium.org
BUG=453731,455104,457248

Review URL: https://codereview.chromium.org/922293006

Cr-Commit-Position: refs/heads/master@{#317648}

BUG=440407

Review URL: https://codereview.chromium.org/950993002

Cr-Commit-Position: refs/heads/master@{#317647}

After this changelist policy::Schema is used to validate policy contents.
Mistyped values trigger PolicyWatcher::PolicyErrorCallback.
Misspelled names trigger just a LOG(WARNING) message.

As a follow-up to using policy::Schema for validation, we can remove ad-hoc
fallback values for 2 out of 15 or our policies that used to be stored in
PolicyWatcher::bad_type_values_.  This can be replaced with a CHECK that
verifies that the Schema indeed didn't pass through any mistyped values.

As another follow-up we can remove the TODO comment asking to start using
PolicyWatcher::PolicyErrorCallback again.  We can also remove
SignalTransientPolicyError which is not used anymore at this point (we can
hesitantly consider reintroducing it if needed to handle detection of
unparseable files;  this is still some time in the future though).

BUG=427513
TEST=remoting_unittests + manual verification on Win and Linux via TestRealChromotingPolicy

Review URL: https://codereview.chromium.org/891053003

Cr-Commit-Position: refs/heads/master@{#317646}