- 03 Dec, 2019 40 commits
-
-
Steven Bennetts authored
This provides support for type="chrome_messages_json_gzip" in grit/build.py, which compresses the output files (which should have .gz appended to the name, e.g. messages.json.gz). This makes it fairly simple to convert an extension (e.g. chromevox) to use compressed l10n files. Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1913610 For changes reviewed in the original CL: TBR=agrieve@chromium.org TBR=dtseng@chromium.org TBR=rdevlin.cronin@chromium.org Bug: 1023568 Change-Id: I7f83e5de8e339aea2e47b84f3ec701350246b38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947386Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#720779}
-
Koji Ishii authored
This patch implements hit-testing text items, that was not implemented in the initial hit-test implementation in r720001 <crrev.com/c/1935773>. The LayoutNG specific logic for |NodeForHitTest()| was moved to |LayoutObject| in r720148 to share the logic with |NGFragmentItem|. 8 failures, ~110 passes. Bug: 982194 Change-Id: I4a1f3414cb1d299d4f1d6f57e64881f6aeddbff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943719Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720778}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::PdfToPwgRasterConverter from PwgRasterConverterHelper using Remote instead of InterfacePtr. Bug: 955171 Change-Id: I8a44ec93c23433f04674a1e543fa6bdb9c7ba10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936067Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#720777}
-
Sean Kau authored
When the lifetime of the binders is changed, it can be initialized after the Profile or Settings objects. When this happens, we may never get a change event if the policies don't change. Alleviate this by querying the policy objects on initialization. Bug: chromium:1015949 Change-Id: I401e1c116c89b7a9165f60c7850a1a34f17c70ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940306 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#720776}
-
Mike Reed authored
Change-Id: I5e853241ba13d81787dd8546ef6157af78764525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947098 Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#720775}
-
nancy authored
For Chrome apps for Web apps, if the window is opened for a browser, we don't need to register app window, because BrowserShortcutLauncherItemController sets the window's property. If register app window for the app opened with browser, the window is added to aura_window_to_app_window_, and when the window is destroyed, it could cause crash in RemoveFromShelf, because BrowserShortcutLauncherItemController manages the window, and sets related window properties, so it could cause the conflict settings. BUG=1011235 Change-Id: I80cd22dad1085a49ea30dc4f3b3a732c7924a834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937951 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720774}
-
Caleb Rouleau authored
R=johnchen@chromium.org Bug: 1028125 Change-Id: I0837eee6aadaa8085161da96dda8e2a6a486de30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947663 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#720773}
-
khmel@chromium.org authored
This gives important information about app quality. TEST=Locally BUG=b/143532713 Change-Id: Icb6b1a37ed077b6a9aad5ed81e3b7b650c62cd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947185Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720772}
-
Ahmed Mehfooz authored
The special case for letting the focus ring for the bottom most notification exceed it's bottom side bounds is not applicable with the recent message center changes. Bug: 1020546 Change-Id: Ib0242dddc6aeb922d50a8795ce16c150734a6f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947625Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#720771}
-
Scott Violet authored
There are more that need to be converted, but they are require other code to be converted. BUG=none TEST=none Change-Id: Ifc44aa4c015a32c49488b14bcda2c721767748bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947389Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#720770}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ca1b0fb895ca..fb40d231c3e2 git log ca1b0fb895ca..fb40d231c3e2 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 jmadill@chromium.org Add new test runner harness. 2019-12-02 syoussefi@chromium.org Vulkan: implement external semaphore barriers 2019-12-02 syoussefi@chromium.org Fix RenderingLimitToDefaultFBOSizeWithNoAttachments test 2019-12-02 syoussefi@chromium.org Add test for multithreaded shared-context resource 2019-12-02 geofflang@chromium.org D3D: Log why a renderer fails to initialize. Created with: gclient setdep -r src/third_party/angle@fb40d231c3e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026673,chromium:1029091 Tbr: geofflang@google.com Change-Id: Ie7249b58c3681e8f2a2238cfc86689216142593c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947424Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720769}
-
Lambros Lambrou authored
PipeMessagingChannel takes ownership of the passed File objects, closing them. This means that stdin/stdout are closed, to prevent accidental corruption of the native-messaging streams. This CL reopens stdin/stdout against /dev/null, which protects them, preventing any future calls to POSIX open() returning these descriptors. For example, LaunchProcess (by default) treats FDs 0, 1, 2 specially (it closes all descriptors except them), so having stdin/stdout directed to some random file could cause unintended effects. This CL also fixes PipeMessagingChannel ctor to not interleave the dup() and close() calls: dup, dup, close, close instead of dup, close, dup, close so that the second dup() call now returns a high-numbered descriptor instead of 0 (freed up by first close() call). Bug: 1029858 Change-Id: I209f5734a06216323c54a680852b381fb6f2f96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947397 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#720768}
-
Mitsuru Oshima authored
Changed BuildWindowListIgnoreModal to keep the activation order. This also fixes the method not to add a window w/o parent. Bug: None Test: covered by unittests. Change-Id: I727b3af0421b9f0f61552ec4a25e440e30e903d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935287 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#720767}
-
Jay Harris authored
Explainer: https://github.com/WICG/file-handling/blob/master/explainer.md#example Summary of Changes: Old way: { "file_handler": { "action": "/files", "files": { "name": "Text", "accept": [ "text/plain", ".txt", ".md" ] } } } New way: { "file_handlers": [ { "action": "/files", "name": "Text", "accept": { "text/plain": [ ".txt", ".md" ] } } ] } Note: This change is behind the NativeFileSystemAPI and FileHandlingAPI flags, so this change won't effect any live web APIs. Bug: 829689 Change-Id: I85ea3abdc22f1b6c89749e051e2ce5dc592357dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877497 Commit-Queue: Jay Harris <harrisjay@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#720766}
-
Tetsui Ohkubo authored
As the impact of the feature is unclear, we want to add a kill switch of the feature through Finch experiment, so that even when the feature lands in stable it can be disabled quickly. Android side CL: http://ag/9778557 TEST=Add --force-fieldtrials="ArcMinimizeOnBackButton/Enabled/" or "ArcMinimizeOnBackButton/Disabled/" to /etc/chrome_dev.conf to see TEST=ArcPropertyBridgeTest the setting is properly overridden BUG=972708,b:144896228 Change-Id: If82db66508f623a7a6f7846d8c7d702fa4bc4e95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930367Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#720765}
-
Fergal Daly authored
PROBLEM: Each event resolve a pending promise if set, however this is racy, sometimes it is set after the event. FIX: Switch to waiting until there is *at least* N events. We need to track more state in the test but we can cope with events arriving early. Bug: 1029238 Change-Id: If4c14b82907d5bb6460208e6218e84501b836ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946187Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#720764}
-
David Vallet authored
TEST=simple chrome Bug: 937152 Change-Id: Id7cdb80ee6390c78589a4ff8042b4f7ed911eb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942670 Commit-Queue: David Vallet <dvallet@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#720763}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33ae3e65534f..0724e61c3c58 Created with: gclient setdep -r src-internal@0724e61c3c58 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1013386,chromium:1017165,chromium:1024588,chromium:1026318 Tbr: jbudorick@google.com Change-Id: I95dab3f33c96bc7469b0cdccaa59cae85fdc712a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947425Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720762}
-
Clark DuVall authored
The top bar was still taking up space even though it is not needed in fullscreen. This also fixes a bug where pressing the back button did not exit fullscreen in the shell. Bug: 1029894 Change-Id: I215e8e1066670ba2e57d83114537b95c70186d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946629Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#720761}
-
Thomas Anderson authored
This reverts commit bbfce899. Reason for revert: Issue should be fixed after https://chromium-review.googlesource.com/c/chromium/src/+/1937507/ lands Original change's description: > Revert PowerSaveBlockerLinux [2/4] > > and the subsequent PowerSaveBlockerLinux [3/4] and PowerSaveBlockerLinux [4/4] patches > > This reverts commit 2fdeba1b. ("Rewrite PowerSaveBlockerLinux [2/4]") > This reverts commit 38fdf074. ("Rewrite PowerSaveBlockerLinux [3/4]") > This reverts commit 3bc463b4. ("Rewrite PowerSaveBlockerLinux [4/4]") > > The patch caused timeouts in WakeLockTest.ChangeType() and other tests in the services_unittests on > Linux Tests (dbg). More details in crbug/1027852. > > TBR=thomasanderson@chromium.org > > Bug: 1013812,1027852 > Change-Id: I7688c72f9d9d6c12ff3731f3abde6a05508cfbeb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932357 > Commit-Queue: Tim Schumann <tschumann@chromium.org> > Reviewed-by: Tim Schumann <tschumann@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718447} TBR=thomasanderson@chromium.org,tschumann@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1013812, 1027852 Change-Id: I84a6681cc8ec347587d38f0f5f38ed628e624274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937509Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#720760}
-
Anand K. Mistry authored
Also NULL->nullptr at call sites to satisfy presubmit checks. Bug: 1007645 Change-Id: I2b1e30c68e4040f3e6e340f8c9e5f448998e2980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943647Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#720759}
-
Sean Kau authored
Refactor is necessary so that we can have more Prefs binders than Settings binders when we have multi-profile. Making this change removes the refcounting logic that we had and allows the two binders to be owned by different classes. Bug: chromium:1015949 Change-Id: Icd341c511d31c7a2742bd50343726718262f5dad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935414Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#720758}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/564d3d9119da..39667c751d42 $ git log 564d3d911..39667c751 --date=short --no-merges --format='%ad %ae %s' 2019-12-02 jb Update NEWS 2019-12-01 martin arm: 32: ipred: Fix assembling with older binutils 2019-11-22 gramner Avoid excessive L2 collisions with certain frame widths 2019-11-25 janne-vlc build: do not error out if clock_gettime is not found on darwin 2019-11-22 gramner Specify inlining decisions for common ipred_z C functions 2019-11-26 me cli: Return only EXIT_SUCCESS or EXIT_FAILURE from main 2019-11-23 gramner tools: simplify get_seed on macOS 2019-07-29 jbeich checkasm: replace gettimeofday with clock_gettime 2019-11-22 jbeich tools: prefer mach_absolute_time on macOS for forward compatibility 2019-11-22 jbeich tools: mach_absolute_time is not portable, so stop checking at configure 2019-11-21 ltrudeau Avoid adding offsets to NULL pointers 2019-11-22 thresh snap: bump grade to stable 2019-11-23 gramner input: Use EIO instead of ENODATA 2019-11-22 martin annexb: Cast size_t to int before adding to an int 2019-11-17 rsbultje Fix accidental capital letter in variable name 2019-11-21 rsbultje Fix stride type 2019-11-21 martin section5: use signed type for seeking backwards 2019-11-16 rsbultje Add demuxer probing 2019-11-15 rsbultje Add section-5 raw OBU demuxer 2019-11-16 rsbultje Make OBU_* types public 2019-11-19 gramner Increase DAV1D_PICTURE_ALIGNMENT to 64 Created with: roll-dep src/third_party/dav1d/libdav1d TBR=tguilbert Fixes: 1027029 Change-Id: If00ab333797cb321a9323a3d1af8ae94d2e07fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946877Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#720757}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ebec004c878f..ca84a4265921 git log ebec004c878f..ca84a4265921 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 perezju@chromium.org [dashboard] Remove old code to allow point_id jump. Created with: gclient setdep -r src/third_party/catapult@ca84a4265921 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:632309 Tbr: nuskos@google.com Change-Id: If47a6eb32703404dbe12ead1fdd6ff65aa7aa40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720756}
-
Yue Zhang authored
Bug: 1029419 Change-Id: I904d29eb86b61a4b8d13100e0146b868a5591af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946871Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#720755}
-
Avery Musbach authored
Instead of a CanSnapInSplitview function referring to the root window of the argument window, there shall be a SplitViewController::CanSnapWindow function referring to the root window of the SplitViewController. Leveraging that, the split view drag indicators on each root window shall account for whether the dragged window can be snapped in split view on that root window. The present CL is also a step toward properly implementing functionality where you drag from one display to another and snap (see the TODO in OverviewWindowDragController::SnapWindow). Bug: 970013, 995413 Change-Id: I0e0b6d34ec8b3b3856d26fc5750bb062405f8dc6 Fixed: 961171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906931Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#720754}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7724a9414f89..a5287b0409dc git log 7724a9414f89..a5287b0409dc --date=short --first-parent --format='%ad %ae %s' 2019-12-02 lalitm@google.com trace_processor: add helper methods for adding constraints on typed cols Created with: gclient setdep -r src/third_party/perfetto@a5287b0409dc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ieae4be878290a28b3178aff2a4eece571576f359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947062Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720753}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cdf1bc3bd32e..8ebac1732c99 git log cdf1bc3bd32e..8ebac1732c99 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 mtklein@google.com remove T*/void* union in SkTArray 2019-12-02 mtklein@google.com tweak for GCC, memcpy() -> for-loop 2019-12-02 mtklein@google.com remove pointless tests 2019-12-02 egdaniel@google.com Update GrSwizzle to only store key and not string. 2019-12-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-02 bsalomon@google.com This is a reland of GrDomainEffect with significant changes: 2019-12-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-12-02 michaelludwig@google.com Compare textureType separately from backend format Created with: gclient setdep -r src/third_party/skia@8ebac1732c99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bsalomon@google.com Change-Id: I38c8d2b69f4c26225cf756f137afae9bd971986e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720752}
-
Sebastien Marchand authored
Change-Id: I1e58983e062d03f2c8532d6b7ed282509a625371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943349 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#720751}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/02b5af35755b..6d31ed5d639e git log 02b5af35755b..6d31ed5d639e --date=short --first-parent --format='%ad %ae %s' 2019-12-02 ehmaldonado@google.com cpplint: Fix Python 3 errors. Created with: gclient setdep -r src/third_party/depot_tools@6d31ed5d639e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1027160 Tbr: agable@chromium.org Change-Id: I5b78c8a634cb0b15fb8026298f5fc7cfa1658510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947303Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720750}
-
Changwan Ryu authored
You can set frequency, duration, recording method, among other things in record_options. Especially, frequency seems makes some difference in terms of coverage and accuracy. Alternative considered: exposing frequency, duration, recording method separately. There are many other options for record_options, so adding numerous args would make it too complicated. Bug: 1015236 Change-Id: I081e95a7f02a3d54dba3b5a0f55291deb309b4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946019Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#720749}
-
Maggie Chen authored
in_gpu_initialization_ was set by the GPU main thread and read by the watchdog thread. This caused data race. This CL fixes it by setting the flag in the watchdog thread only after the init in the constructor. Bug:1029475, 1028946 Change-Id: I5c38a2af70962e0d68880e930b6657f7107d2def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943545Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#720748}
-
Adrian Taylor authored
Change-Id: I661e2983db1324459fc6a112be00c908f6ba85e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938034 Auto-Submit: Adrian Taylor <adetaylor@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#720747}
-
Xiaoqian Dai authored
The overview gesture kDragFromShelfToHomeOrOverview feature is disabled by default, and is only enabled on the devices that has hotseat feature enabled (i.e., on Krane and on Dogfood devices). Bug: 1029991, 997885 Change-Id: I2e783b099160b42b03e452d6e4ec044504973c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946881Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#720746}
-
Toni Barzic authored
The search result page opacity might get set to a partially opaque value during app list drag - this resets the opacity to 1.0 before showing app list view again (in case the app list was dragged really close to shelf before closing, in which case last opacity set on the layer might have been small). This should not affect initial search result page appearance (as the page starts in invisible state). BUG=1027805 Change-Id: I7a5fbd22647f976a22a39aa61a4f44ab03756215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936108Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#720745}
-
Jarryd authored
The current All Sites page forces users to go into site details to clear data for any site with only 1 origin listed in the siteGroup. This change saves the user from having to do so, and lets them clear data and reset permissions directly from the all sites page. Bug: 997258 Change-Id: I186439d73330f8489149f849e68dfc98db2b26c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884579 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#720744}
-
Kenny Levinsen authored
Pulls latest stable of wayland-protocol to get a few minor spec fixes to xdg-shell stable before we implement support for it. Also pulls in latest stable of wayland core, as the in-tree version at the time of commit is 3.5 years old, with upstream containing many fixes since then. Bug: 997631 Change-Id: I135ef605635b9f50576d078cd024aa7901805126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937075 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#720743}
-
Ian Struiksma authored
Verified different states of tests from top 275 autofill list. This meant adding a 25 that had been failing previously and doing an audit of failure reasons. Also, sorted them in the json file as the states should be steady now. Includes update to cipd version for autofill wpr/test files. Bug: 984664 Change-Id: I0b506140dd62679e5fef5928cff160ac0694476f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937508Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#720742}
-
Vadim Bendebury authored
Much more Cr50 versions were released since last update, this patch brings the enum list up to date. The same python script (now attached to the bug) was used to generate version strings for all images. BUG=chromium:728134 TEST=None Change-Id: I4c276cd61ce0c2e021d9d2d884fb878d29c9c27d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946453 Auto-Submit: Vadim Bendebury <vbendeb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#720741}
-
Dan Harrington authored
suppress.py outputs XML tags in sorted order, which makes seeing the changes difficult when suppressions.xml is not sorted. I've re-ordered tags in this file so that running suppress.py results in no diff beyond missing comments. Added a note at the top to suggest inserting tags in sorted order. There should be no material changes to suppressions.xml in this CL. Change-Id: I43b8ad4928bc6262e486bcba71aa2c0bb282c1f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1947227Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#720740}
-