- 30 Nov, 2018 40 commits
-
-
Xiyuan Xia authored
- Add a kClientWindowHasContent property to pass the info from client to Window Service; - DesktopWindowTreeHostMus sets the property based on layer type and opacity of Widget::InitParams; - Check kClientWindowHasContent property as part of the remote window has-content check for occlusion tracking; Bug: 908629 Change-Id: I23c582d7135d50b70ba0776cb0368da59fe5d8c7 Reviewed-on: https://chromium-review.googlesource.com/c/1354439Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612773}
-
Aiden Benner authored
MASS REFACTOR - please consider fixing rather than reverting. The jclass parameter is never used in static JNI functions because we generate bindings ourselves for functions that are called by native. This CL removes the jclass parameter from all JNI methods by refactoring all current JNI method declarations that contain a jclass and stops the JNI generator from generating stubs that pass jclass to our implementation. This change is also being done to support the conversion of all non-static native methods to static native methods and then all static natives to the new JNI interface. When this is done proguard will be able to obfuscate classes that contain native methods. And native methods that don't rely on native TBR=agrieve # wide-reaching mechanical refactor Bug: 898660 Change-Id: Ie2932564d58933a2f4bcd23fe47723e147cf87d8 Reviewed-on: https://chromium-review.googlesource.com/c/1352518 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#612772}
-
Joel Einbinder authored
This code was not used Change-Id: I57c742e34811807e091d8a833fa89ac0487e64bf Reviewed-on: https://chromium-review.googlesource.com/c/1356128Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#612771}
-
Martin Robinson authored
In the accessibility tree, each popup menu and its submenus have a native window. When using popup menus, the AtkWindow for the native window of the active menu should always have the ATK 'active' property. We listen to events associated with the lifetime active popup menus and use them to properly manage the 'active' property on this constellation of AtkWindows. Bug: 895921 Bug: 896392 Change-Id: I7a5e148feb8486bab7984f19c7ee2532b1fd16f0 Reviewed-on: https://chromium-review.googlesource.com/c/1335586 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#612770}
-
sebsg authored
Bug: 907929 Change-Id: I6cc9d7a908010c204fc8060802c7ee453363ffa3 Reviewed-on: https://chromium-review.googlesource.com/c/1349455 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#612769}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 11e0d834. With Chromium commits locally applied on WPT: b6e2cb9b "[EventTiming] Always buffer firstInput" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-break NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I8e830b280b458cdd488856f7289319f5beaaf14e Reviewed-on: https://chromium-review.googlesource.com/c/1357310 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612768}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/199f50b66cb0..010497f89102 Created with: gclient setdep -r src-internal@010497f89102 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4324a32bb363bbe01b5b9e31874b2a9f12f6050f Reviewed-on: https://chromium-review.googlesource.com/c/1357347Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612767}
-
Ryan Meier authored
Bug: 725197 Change-Id: I24e0f3ff08ebd26f0621c2e16154f34a3dfd5467 Reviewed-on: https://chromium-review.googlesource.com/c/1355771 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#612766}
-
Xing Liu authored
This CL polishes the comment for transient flag in DownloadUrlParameters. Change-Id: I06732268dc08889cc195b61d3140560acc9e5242 Reviewed-on: https://chromium-review.googlesource.com/c/1357380Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612765}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/35457f076227..559cacb8fdf1 git log 35457f076227..559cacb8fdf1 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 benjhayden@chromium.org Move Catapult Android Tryserver to LUCI. Created with: gclient setdep -r src/third_party/catapult@559cacb8fdf1 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:825432 TBR=sullivan@chromium.org Change-Id: I45252f26469927cd0ebc9f70724b1d04ce2a7178 Reviewed-on: https://chromium-review.googlesource.com/c/1357346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612764}
-
Philip Rogers authored
The name "SlimmingPaintV2" has led to confusion about what exactly is in "v2". This renames the in-development feature to "CompositeAfterPaint". Tasks left to do: 1) Remove the --enable-slimming-paint-v2 flag 2) Remove the SlimmingPaintV2 runtime enabled feature 3) Move the virtual tests from virtual/spv2 to virtual/composite-after-paint 4) Move the flag-specific expectations to enable-features=CompositeAfterPaint This patch has been generated from the following commands: cd third_party/blink git grep -l SlimmingPaintV2 | xargs sed -i "" 's/SlimmingPaintV2/CompositeAfterPaint/' git grep -l "slimming paint v2" | xargs sed -i "" 's/slimming paint v2/composite after paint/' git grep -l "slimming paint V2" | xargs sed -i "" 's/slimming paint V2/composite after paint/' git grep -l "Slimming Paint v2" | xargs sed -i "" 's/Slimming Paint v2/Composite After Paint/' git grep -l "Slimming Paint V2" | xargs sed -i "" 's/Slimming Paint V2/Composite After Paint/' git grep -l "Slimming paint v2" | xargs sed -i "" 's/Slimming paint v2/Composite after paint/' git grep -l "Slimming paint V2" | xargs sed -i "" 's/Slimming paint V2/Composite after paint/' git grep -l "enable-slimming-paint-v2" | xargs sed -i "" 's/enable-slimming-paint-v2/enable-composite-after-paint/' git grep -l "spv2" | xargs sed -i "" 's/spv2/cap/' git grep -l "SPv2" | xargs sed -i "" 's/SPv2/CAP/' git grep -l "SPV2" | xargs sed -i "" 's/SPV2/CAP/' git grep -l "enable_s_pv2" | xargs sed -i "" 's/enable_s_pv2/enable_cap/' git grep -l "kSlimmingPaintV2" | xargs sed -i "" 's/kSlimmingPaintV2/kCompositeAfterPaint/' git mv third_party/blink/renderer/core/paint/stub_chrome_client_for_spv2.h third_party/blink/renderer/core/paint/stub_chrome_client_for_cap.h git checkout -- perf_tests/bindings/resources/data/blink-dev.json git checkout -- perf_tests/svg/resources/CrawFishGanson.svg git checkout -- renderer/build/scripts/blinkbuild/name_style_converter.py git checkout -- renderer/build/scripts/blinkbuild/name_style_converter_test.py git checkout -- web_tests/VirtualTestSuites git checkout -- renderer/platform/exported/web_runtime_features.cc git checkout -- public/platform/web_runtime_features.h git checkout -- web_tests/FlagExpectations/enable-blink-features=LayoutNG git checkout -- web_tests/FlagExpectations/enable-blink-gen-property-trees git checkout -- web_tests/FlagExpectations/enable-slimming-paint-v2 git checkout -- web_tests/SlowTests git checkout -- web_tests/TestExpectations git checkout -- web_tests/animations/resources/composited-animation-test.js git checkout -- web_tests/virtual/spv2/compositing/README.txt git checkout -- web_tests/virtual/spv2/fast/block/README.txt git checkout -- web_tests/virtual/spv2/fast/borders/README.txt git checkout -- web_tests/virtual/spv2/fast/clip/README.txt git checkout -- web_tests/virtual/spv2/fast/css/README.txt git checkout -- web_tests/virtual/spv2/fast/overflow/README.txt git checkout -- web_tests/virtual/spv2/fast/repaint/README.txt git checkout -- web_tests/virtual/spv2/paint/README.txt git checkout -- web_tests/virtual/spv2/paint/subpixel/README.txt git checkout -- web_tests/virtual/spv2/svg/README.txt git checkout -- web_tests/virtual/threaded/animations/composited-animation-independent-transform-cancel.html git checkout -- web_tests/virtual/threaded/animations/compositor-independent-transform-properties.html git checkout -- renderer/platform/runtime_enabled_features.json5 { name: "CompositeAfterPaint", implied_by: ["SlimmingPaintV2"], }, git cl format I then manually cleaned up some instances of "composite after paint" being "CompositeAfterPaint" as well as some grammar. Bug: 909899 Change-Id: Iec0a803b997ada7c58c9c0446bbca23451de08dd Reviewed-on: https://chromium-review.googlesource.com/c/1355247Reviewed-by:Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612763}
-
Ella Ge authored
Bug: None Change-Id: I3df4dd15394d61b4334c5e8794c6e382535417d5 Reviewed-on: https://chromium-review.googlesource.com/c/1355761Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#612762}
-
Joey Arhar authored
Bug: 802182 Change-Id: I01b45373ab5fe21bf2513cd1ea9e7f2e90d9820f Reviewed-on: https://chromium-review.googlesource.com/c/1356135Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#612761}
-
Ryan Meier authored
Bug: 802374 Change-Id: I89e01e755d4a5bf4dabda8f93b75eafc7418fc34 Reviewed-on: https://chromium-review.googlesource.com/c/1355613 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#612760}
-
Dave Tapuska authored
BUG=879657 Change-Id: I522fa35be26873436ed090990cbae1897acef6f7 Reviewed-on: https://chromium-review.googlesource.com/c/1355841Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#612759}
-
Pavel Feldman authored
Change-Id: I43c98ef335c76b0bbc5276742fdfe791c40f3a7d Reviewed-on: https://chromium-review.googlesource.com/c/1357009Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#612758}
-
chrome://flagsdpapad authored
Bug: 907791 Change-Id: I18f62b564509ac97d54aa6fec33d213ebf16e575 Reviewed-on: https://chromium-review.googlesource.com/c/1357018Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#612757}
-
Stephen Martinis authored
This CL adds a check to //infra/config/branch/cq_cfg_presubmit.py to check the path regexps in cq.cfg to make sure there is at least one file that they could match with. This CL also fixes a few typos which already exist in cq.cfg, as a result of this missing checking. Bug: 902507 Change-Id: I535d6671e4598eda27a0919ef14404a228398ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1334940 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#612756}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/58017e91adbf..179db44c2586 git log 58017e91adbf..179db44c2586 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 brandon1.jones@intel.com Refactor Internal Command Buffer Copy APIs 2018-11-30 cwallez@chromium.org Revert "Run linux-dawn-rel on the CQ" Created with: gclient setdep -r src/third_party/dawn@179db44c2586 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:901830 TBR=cwallez@chromium.org Change-Id: I0589a99d1cab6762ddf577d2fd7997fb32881007 Reviewed-on: https://chromium-review.googlesource.com/c/1357341Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612755}
-
Anne Lim authored
Added GetExpiryTime() to StrikeDatabase interface and removes expired striked on StrikeDB init. Bug: 884817 Change-Id: Ie99173b631f668f3be848f1afa925d7feec801ef Reviewed-on: https://chromium-review.googlesource.com/c/1351887Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Anne Lim <annelim@google.com> Cr-Commit-Position: refs/heads/master@{#612754}
-
Martin Kreichgauer authored
In http://crrev.com/c/1354559, the thread waiting for the blocking Windows WebAuthn API calls to return was moved into the WinWebAuthnApi singleton. Unfortunately, this introduced a potential use-after-free, because arguments to the blocking API calls get passed via pointer and the owner of those arguments, WinHelloApiAuthenticator, wasn't generally guaranteed to outlive the duration of the request. This change fixes the issue by moving all data passed to the Windows API calls into WinWebAuthnApi by value. Bug: 898718 Change-Id: Ib4f2e86f4ef04cbac712682d4cff386709e735eb Reviewed-on: https://chromium-review.googlesource.com/c/1356334 Commit-Queue: Martin Kreichgauer <martinkr@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#612753}
-
Xing Liu authored
This CL enable a flaky test: NotificationIntentInterceptorTest#testContentIntentInterception Bug: 906843 Change-Id: Icf92bbd5fae556b0faf1c1a6c5b2bf65c0016449 Reviewed-on: https://chromium-review.googlesource.com/c/1353949Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#612752}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dae4dfd2c5df..7b5740a89e63 git log dae4dfd2c5df..7b5740a89e63 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 thestig@chromium.org Move pdf_enable_xfa build rules inside pdf_enable_v8 blocks. Created with: gclient setdep -r src/third_party/pdfium@7b5740a89e63 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I8156992c15102ad2b8fff22a6fc8e4c9fa0f678a Reviewed-on: https://chromium-review.googlesource.com/c/1357343Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612751}
-
Becca Hughes authored
This CL deletes the old content::MediaMetadata types. BUG=875004 Change-Id: Ia6c5fa76090d2e848261207d6a0dc28e782a4db3 Reviewed-on: https://chromium-review.googlesource.com/c/1241554 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#612750}
-
Becca Hughes authored
Add the MediaSessionMetadataChanged event to the observer that will be fired if the metadata associated with the media session changes. This will be used for the notification to display metadata of the currently playing media. BUG=875004 Change-Id: I17d4e2af8b1d3b5b6213ec2eaaf0c29eb58c5937 Reviewed-on: https://chromium-review.googlesource.com/c/1316659 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#612749}
-
Lily Chen authored
New unit test checks that setting the priority of a request to an SSLClientSocketPool layered on top of a HttpProxyClientSocketPool passes the priority change all the way down to the transport socket pool. Bug: 166689 Change-Id: I4a4b00106659a65ea75689c5cea1c4e44266bb13 Reviewed-on: https://chromium-review.googlesource.com/c/1356865Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#612748}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7ae5d7a9b12c..020b59722ab0 git log 7ae5d7a9b12c..020b59722ab0 --date=short --no-merges --format='%ad %ae %s' 2018-11-30 ehmaldonado@chromium.org presubmit: Remove EnsureCQIncludeTrybotsAreAdded Created with: gclient setdep -r src/third_party/depot_tools@020b59722ab0 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:845642 TBR=agable@chromium.org Change-Id: I32ac7a57384716d8c246a50a4a62cab231b53b91 Reviewed-on: https://chromium-review.googlesource.com/c/1357344Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612747}
-
bsheedy authored
Fixes or disables the tests that were consistently failing on the vega standalone device. A few tests required special casing standalones due to them always being in the VR Browser, while a few others are simply disabled because they don't make sense on standalone devices. Bug: 876946 Change-Id: Ia27e76b79ee6be2af0a7429e111d2fe57a1c532d Reviewed-on: https://chromium-review.googlesource.com/c/1354654Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#612746}
-
Ted Meyer authored
If the previous packet position and the current match and we fall back to comparing display timestamps, make sure that we don't drop packets which never had a display timestamp set. Bug: 894776 Change-Id: I5033462642255743cb05cd44ec85312441503f53 Reviewed-on: https://chromium-review.googlesource.com/c/1356310Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#612745}
-
Katie D authored
Bug: 910653 Change-Id: Id6009d4789c560e54c450377c16f1013e57a914c Reviewed-on: https://chromium-review.googlesource.com/c/1356886Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#612744}
-
Luna Lu authored
Change-Id: I9806545fd84b6e17d1d3c4c81155d099396d89cd Reviewed-on: https://chromium-review.googlesource.com/c/1352587Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#612743}
-
Peter Kotwicz authored
This CL removes the application context parameter from several functions in WebappLauncherActivity and WebappAuthenticator. BUG=None Change-Id: Ie4486cb4f9950a34e6b8349806cab35ebbb8f5a0 Reviewed-on: https://chromium-review.googlesource.com/c/1354128 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#612742}
-
Wez authored
This reverts commit 49c8774b. Reason for revert: CL seems likely cause of a new MainThreadHasPendingTasks() flake observed on the Fuchsia builders (see crbug.com/910645). Original change's description: > [Reland] Use the SequenceManager in ScopedTaskEnvironment > > A reland of https://crrev.com/c/1324391 > > This is necessary because we want content::TestBrowserThreadBundle to > own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment > and you can't have two SequenceManagers on the same thread. > > This patch allows ScopedTaskEnvironment to optionally work with an > externally owned SequenceManager solving the problem. > > This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk, > > We now have the ability to mock time on the UI thread. > > TBR=asvitkine@chromium.org,miu@chromium.org,gab@chromium.org,fdoray@chromium.org > > Bug: 863341, 891670, 708584 > Change-Id: Ia4409b885deb9935e6e5b6d99f4598f164d350db > Reviewed-on: https://chromium-review.googlesource.com/c/1354919 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612122} TBR=gab@chromium.org,miu@chromium.org,fdoray@chromium.org,asvitkine@chromium.org,alexclarke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 910645, 863341, 891670, 708584 Change-Id: I395322743c110f9b1dd424434756f05b2301a45b Reviewed-on: https://chromium-review.googlesource.com/c/1357014 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#612741}
-
Nicolas Ouellet-Payeur authored
This reverts commit 706b39eb. Reason for revert: broke check_network_annotations on CQ and didn't fix the underlying issue. Original change's description: > Remove journey_journey_info_json_request network annotation > > Bug: 909867 > Change-Id: I8d910acd2b5adf3686678ef186318cc4dc4fe118 > Reviewed-on: https://chromium-review.googlesource.com/c/1355772 > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Reviewed-by: Ramin Halavati <rhalavati@chromium.org> > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612653} TBR=yusufo@chromium.org,rhalavati@chromium.org,meiliang@chromium.org,nicolaso@chromium.org Change-Id: If75c9709ad6d81e9c4f5576b89f91b6af66fe4f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 909867 Reviewed-on: https://chromium-review.googlesource.com/c/1357215Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#612740}
-
Meilin Wang authored
Record the input source of each Assistant query (e.g. voice input, typing, suggestion chip). Test: local compile and test. Change-Id: Ibb2993c49879d46e398a38984099971f457abd6b Reviewed-on: https://chromium-review.googlesource.com/c/1340276 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#612739}
-
Esmael El-Moslimany authored
Bug: 910092 Change-Id: I20f669bf401437ac52695274a01f32e08d427170 Reviewed-on: https://chromium-review.googlesource.com/c/1355843Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#612738}
-
Wez authored
This reverts commit 66fbaed9. Reason for revert: Revert required to allow https://chromium-review.googlesource.com/c/chromium/src/+/1354919 to be reverted cleanly for issue 910645. Original change's description: > Feature to run Blink main thread using SequenceManager > > This will enable us to start trialing the MessageLoop replacement by > SequenceManager. > > We only do this in the Blink main thread for now. There is some work > needed around SequenceManager ownership to be done before this can be > enabled in worker threads. > > > Bug: 891670 > Change-Id: I1e59784ff35c87883a66d9b315435bf47cd0f809 > Reviewed-on: https://chromium-review.googlesource.com/c/1349316 > Reviewed-by: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Commit-Queue: Carlos Caballero <carlscab@google.com> > Cr-Commit-Position: refs/heads/master@{#612185} TBR=dcheng@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org,carlscab@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 910645, 891670 Change-Id: I3529309984cd61dfef8a10e49129d364efabcf1f Reviewed-on: https://chromium-review.googlesource.com/c/1357016 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#612737}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ae7e8f53c6eb..1d5a8c686edd git log ae7e8f53c6eb..1d5a8c686edd --date=short --no-merges --format='%ad %ae %s' 2018-11-30 zhuohao@chromium.org rammus: add firmware branch builder Created with: gclient setdep -r src/third_party/chromite@1d5a8c686edd The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5672ae541fee58dc393bbd21810d8a06e80b5d08 Reviewed-on: https://chromium-review.googlesource.com/c/1357340Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612736}
-
Tommy C. Li authored
Bug: 908440 Change-Id: Id846e2c8d209ebe77b08fa78dab90d1362e95328 Reviewed-on: https://chromium-review.googlesource.com/c/1351277Reviewed-by:
Kevin Bailey <krb@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#612735}
-
manuk authored
This allows us to 1) have smarter filtering; e.g. filtering for bookmarked properties with 'is bookmarked' (separate CL) and 2) avoid unnecessarily going through the DOM for something. Bug: 891303 Change-Id: I336096881f0fcd2e90a621ab2e54853c83e01608 Reviewed-on: https://chromium-review.googlesource.com/c/1357311Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#612734}
-