- 26 Jul, 2018 40 commits
-
-
Daniel Cheng authored
This method is never accessible cross-origin, so by definition, it can only be invoked on a local frame. Change-Id: I9fd8c436a8169dcad8e1c1c7bfd213c7696337b1 Reviewed-on: https://chromium-review.googlesource.com/1151064Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#578408}
-
Stephen McGruer authored
This test appears to be timeout-flaky on both Linux (dbg) and Mac (dbg). TBR=clamy@chromium.org Bug: 846747 Change-Id: Ic2fb023374915a8c5516127e5172402d8a4af27d Reviewed-on: https://chromium-review.googlesource.com/1151788Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#578407}
-
Chris Mumford authored
base::DeleteFile ignores database locks, leveldb_chrome::DeleteDB does not and is safer. Bug: 802298 Change-Id: I6b30fb6826216c9e54a16569a133e1fbddfad98f Reviewed-on: https://chromium-review.googlesource.com/1151543 Commit-Queue: Chris Mumford <cmumford@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#578406}
-
Majid Valipour authored
- Move two tests for AnimationHost/WorkletAnimation interactions to animation_host_unittests - Remove unnecessary complexity related to creating and testing an impl instance. These tests don't need to distinguish between main/impl instances at all. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I928e664ddf4fab8496fbbe3a09fcdcd120c875fb Reviewed-on: https://chromium-review.googlesource.com/1133770Reviewed-by:
-
kristipark authored
Added functionality for adding/removing links and restoring the Most Visited tiles. If the URL is not valid, the link will not be added. The blacklist button now opens the edit dialog (editing links is currently not functional and will be added in a later CL). Also added hover/pressed/focus styling to the input fields and the buttons. Design Doc: go/chrome-ntp-custom-links Video: https://screencast.googleplex.com/cast/NTQyNDU2OTc1ODI1MzA1NnwwMjFkODAwYi1kMg Bug: 851293 Change-Id: Ic92e46ba93a4abcb375467a1d047cbb573f231ba Reviewed-on: https://chromium-review.googlesource.com/1149458 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#578404}
-
Scott Haseley authored
This restores several obsolete affected-histogram names that are still were removed by commit c492381b (crrev.com/c/1106384) and are still being recorded. These are still useful in versions where the new metrics don't exist. Change-Id: Iee9a1fd852f19b9cbf7fb0c54ea9999441098ed8 Reviewed-on: https://chromium-review.googlesource.com/1145827Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#578403}
-
Daniel Bratell authored
Switching from Khronos headers to more approprite headers primarily to avoid jumbo compilation problems but also because it was wrong. Bug: 864986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9a7c33acfcc72133638c47ae370020331c445ac9 Reviewed-on: https://chromium-review.googlesource.com/1151630Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#578402}
-
Dale Curtis authored
This implements the MediaCodec.Callback API as a layer within MediaCodecBridge so that we may easily support both the async and sync API on older versions of Android. Essentially it registers a callback listener that just stuffs the input and output buffers into queues as if we were using the normal synchronous API. When new inputs or outputs are available a callback is delivered to the bridge so that decoders may pump whatever work they need. For < 60fps content, this is reduction in the total number of timer interrupts used to drive the codec. E.g., with MCVD for 30fps we go from 3720 wakeups over 30s to 2706. For 60fps content we increase from 3926 wakeups with the old path to 4502 wakeups in the new path. There are a couple ways we could reduce the PumpCodec calls further (coalescing, smarter usage during Decode()), but we should see if it matters first. Testing shows this also reduces the total time spent waiting for frames by ~63% as measured by VideoRendererImpl. I.e. for a 1080p60 30s clip, we go from a total of ~17249ms spent waiting for a frame from the decoder to ~10867ms. Bug: 517673 Test: passes bots Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I35fa015dc8b1d6a2f396d7a143279c48d6471dfb Reviewed-on: https://chromium-review.googlesource.com/1132569 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#578401}
-
Joshua Bell authored
The 'secure' and 'sameSite' options were included for delete() calls for symmetry with set(). Although they are used internally as inputs into the cookie deletion process (which is a set with an expiry time in the past) they do not have an observable effect as they are not part of the "key" for cookies in the jar. Remove 'em from the script-facing API, and just pass defaults through. If passed, the options will be ignored, so this will have no affect on code using the API unless the code is trying to specifically probe option parsing. GitHub issue: https://github.com/WICG/cookie-store/issues/77 GitHub PR: https://github.com/WICG/cookie-store/pull/81 Bug: 729800 Change-Id: I847293f5274abcb6335140f7f1bf4e2f6f2f8bcf Reviewed-on: https://chromium-review.googlesource.com/1151723Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#578400}
-
gogerald authored
Bug: 845904 Change-Id: I1ee70df70b808e4611608006a019324c11ec87a9 Reviewed-on: https://chromium-review.googlesource.com/1151554 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#578399}
-
Ria Jiang authored
RootConsumesScrollDuringOverscrollGesture, InputEventRouterTouchpadGestureTargetTest and TouchpadPinchOverOOPIF were flaky tests with Viz hit-testing config. However, looking at the log, they only happened infrequently on Android and Windows. I couldn't repro these locally and there have been some changes with how we wait for hit-test data and setting initial window bounds, so tentatively re-enable these three tests to see whether they are still flaky or not. Bug: 853761, 835058, 838835 Change-Id: I66ae6162ab9065e4a940c5779adb92254a6bf54c Reviewed-on: https://chromium-review.googlesource.com/1151899Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#578398}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b5093bc9ede3..897f256413c1 git log b5093bc9ede3..897f256413c1 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 ziadb@google.com SkAR Java: smooth finger painting, planes draw with outlines 2018-07-26 senorblanco@chromium.org GrTessellator: fix for collinear edge merging. Created with: gclient setdep -r src/third_party/skia@897f256413c1 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866319 TBR=benjaminwagner@chromium.org Change-Id: I8cd6673f999a9f27ebcb29c5c7e3e6161008f153 Reviewed-on: https://chromium-review.googlesource.com/1151550Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578397}
-
Simeon Anfinrud authored
It's actually more concise to type "x ->" than "() ->", and this simplifies the model to make it more amenable to further refactors. Namely, the goal is to rename "ScopeFactory" to the less arcane "Observer" and "watch()" to the more conventional "subscribe()". Bug: None Test: cast_base_junit_tests, cast_shell_junit_tests Change-Id: I2763a987b1a2c424996cb404a9e59e211344372d Reviewed-on: https://chromium-review.googlesource.com/1119067Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#578396}
-
Ian Vollick authored
This structure used to have 3 repetitive groups of booleans. With this change each of those similar groupings is a separate struct. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Idef02f62650d5a3b73486a206e0f8077992fa2cd Reviewed-on: https://chromium-review.googlesource.com/1151711Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#578395}
-
Eric Orth authored
As MockHostResolver is essentially a simplified version of HostResolverImpl, the implementation very much mirrors the non-mock implementation. Also allow cancellation in HangingHostResolver (by tracking number of cancellations made since a cancelled request has no external difference from a hung request). Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id439203542d3206af63ba46d2906e3c6e94b6b39 Reviewed-on: https://chromium-review.googlesource.com/1125160 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#578394}
-
James Hawkins authored
R=hansberry@chromium.org Bug: none Test: none Change-Id: Ic8c95f26c3f950febac68dca596558997556a641 Reviewed-on: https://chromium-review.googlesource.com/1151766Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#578393}
-
Kyle Horimoto authored
As part of the MultiDeviceSetup flow, we use JS <==> C++ Mojo bindings, so we were transferring RemoteDevice objects from C++ to JS. RemoteDevice objects hold a "public_key" field, which is a std::string containing randomly-generated bits. These bits are not all necessarily ASCII characters and often contain NULL characters before the end of the string. The std::string class handles this situation, but JS strings do not. Thus, transferring the public_key field was problematic because the key would not be received correctly on the JS side. This CL modifies device_sync.mojom's RemoteDevice struct: * The device ID (human-readable string) is included instead of the public key. * StructTraits use RemoteDeviceRef::DerivePublicKey() to retrieve the public key on the other side of the pipe. Additionally, this CL modifies multidevice_setup.mojom such that SetHostDevice() now takes a device ID instead of a public key as a parameter. Bug: 824568 Change-Id: I16bda595ce25ba9321f11d3f455fbbeec71d7809 Reviewed-on: https://chromium-review.googlesource.com/1149328Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#578392}
-
Jordy Greenblatt authored
This CL implements the skeleton of the prefs controlling MultiDevice features as laid out in khorimoto's mini design doc https://docs.google.com/document/d/1XvTd1kuU7ZigOFwau39oDstg_-wjjjGD3Lf02Cc9Oek/edit# Note that the MultiDeviceSetupService::RegisterProfilePrefs() call in profile_impl.cc needs to be moved outside the flag progected if block where it currently is because it will eventually include the registration of some prefs that are not not controlled by the same flags (e.g. Instant Tethering). Note that I also deleted the old kSmsConnectEnabled pref to avoid confusion. It was added according to a now deprecated design and is not used anywhere so this will have no effect. It will soon be moved to chromeos/services/multidevice_setup/public/cpp/prefs and, once the SMS Connect Item is added to the MultiDevice Settings UI subpage, added back in. However, in order to have the prefs in settings reflect the state of the MultiDevice Settings UI, I don't want it in Settings UI (especially not whitelisted from a misleading file and namespace). ------------- To test it I surfaced the pref in the settings pref singleton and verified that it appears as expected. Here is a screenshot from the settings page console on my dev PixelBook: https://drive.google.com/open?id=0B1-cJJPK-cu6dS10ZGRId3U3Sm56a3JaZ04tbWdDTGt2aTE0 Bug: 824568 Change-Id: I3537e19b81e8c3db9bc7cc6f6fedf7780465ea22 Reviewed-on: https://chromium-review.googlesource.com/1149194 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#578391}
-
spqchan authored
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1135829 The previous CL got reverted because the touch bar is initialized in the BrowserWindowTouchBarControllerTest, which causes issues if the touch bar API is not available. This CL addresses that issue by only creating the BrowserWindowTouchBarController when the API is available. Remove Cocoa dependency from WebTextfieldTouchBar by moving it from TabContentsController to BrowserWindowTouchBarController. Hook up BrowserWindowTouchBarController to AutofillPopupControllerImplMac on MacViews so that the credit card touch bar can be updated. Move the the logic that listens to WebContent changes to the BrowserWindowTouchBarController. When the WebContents has changed, BrowserWindowTouchBarController will update the WebContents in BrowserWindowDefaultTouchBar and WebTextfieldTouchBarController. Modified SuggestedTextTouchBarController so that when its WebContents has changed, it'll observe the new WebContents. Bug: 856391 Change-Id: Ic3dfb002ecec6574502c3f1a4cdd32e9edb713f4 Reviewed-on: https://chromium-review.googlesource.com/1135829Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sarah Chan <spqchan@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577940} Reviewed-on: https://chromium-review.googlesource.com/1151613 Cr-Commit-Position: refs/heads/master@{#578390}
-
Denis Kuznetsov authored
Bug: 864455 Change-Id: Ide16abf2cc21cffacd6507bb17645b00547c2817 Reviewed-on: https://chromium-review.googlesource.com/1151113Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#578389}
-
Moe Ahmadi authored
Bug: 841758 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1475b5ccf301eb83cdecc0b9fbd2ba5d56092416 Reviewed-on: https://chromium-review.googlesource.com/1151488 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
The stripped fields are "line" and "class". see: https://cs.corp.google.com/clankium/src/gpu/ipc/client/gpu_channel_host.cc?l=47 R=oysteine@chromium.org Bug: 867931 Change-Id: Id9374121e57fdad804add77b152f18e53204d8b2 Reviewed-on: https://chromium-review.googlesource.com/1151611Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#578387}
-
Helen Li authored
With network service, net:: C++ socket access will need to be changed to using network service's socket APIs. This CL changes gcm to using proxy_resolving_socket.mojom instead of the C++ ProxyResolvingClientSocket. GCM files that are changed: - google_apis/gcm/engine/connection_factory_impl.cc This will request and own a network::mojom::ProxyResolvingSocketPtr - google_apis/gcm/engine/connection_handler_impl.cc This will pass the mojo read/write pipes to socket streams. - google_apis/gcm/base/socket_stream.cc SocketInputStream/SocketOutputStream will read from/write to mojo data pipes instead of the C++ socket. Network service changes - services/network/public/mojom/proxy_resolving_socket.mojom Peer address is surfaced directly when connection is established. This is needed to support GCM's use case. They need the peer address synchronously when connection is done. Browser changes: - NetworkContext raw mojo pointer has to be queried on the UI thread on demand. Therefore changes are added to pass through a callback and ui task runner. Bug: 862608 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic0c72c8ee7d9bc7deb6e8109234227f80ea3bbe3 Reviewed-on: https://chromium-review.googlesource.com/1142344Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#578386}
-
Peter Boström authored
This fixes an issue where Hindi increases ToolbarButton's height resulting in oblong InkDrop shapes. It also increases the font size for touchable Chrome which matches the larger shape of the toolbar better. Bug: chromium:862514 Change-Id: I66cd2d7e06a27e6c03402e28679b55eaaaeaccf8 Reviewed-on: https://chromium-review.googlesource.com/1150960Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#578385}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f07f60ef0baa..721613b08607 git log f07f60ef0baa..721613b08607 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 perezju@chromium.org [devil] Fix PRESUBMIT errors in devil 2018-07-26 anthonyalridge@google.com Graph Data API change 2018-07-26 perezju@chromium.org Fix PRESUBMIT errors in catapult/experimental Created with: gclient setdep -r src/third_party/catapult@721613b08607 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867809,chromium:866423,chromium:867844 TBR=sullivan@chromium.org Change-Id: I5f2e7a10c7729efd3daacdf25ca68340f2ee5ed1 Reviewed-on: https://chromium-review.googlesource.com/1151547Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578384}
-
Tiger Oakes authored
When adjusting the radio buttons, hightlights only update for symbols and not for containers. This is now fixed. Additionally, the dynamic inputs (byteunit and highlight) previously did not disappear from the URL when set back to the default value. This is now fixed. The UI code has been cleaned up a little and more comments have been added. Bug: 867760 Change-Id: I6671b28939d73a32222a1b5f6dcaf18da8783e68 Reviewed-on: https://chromium-review.googlesource.com/1151622Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Tiger Oakes <tigero@google.com> Cr-Commit-Position: refs/heads/master@{#578383}
-
Robert Ma authored
This is a reland of 82d1bd2b Original change's description: > Rebaseline a virtual PiP test and unskip it > > TBR=foolip > > Bug: 866802 > Change-Id: I633708217593c5b132beb69eeb27f7e6caeeedc0 > Reviewed-on: https://chromium-review.googlesource.com/1150632 > Reviewed-by: Robert Ma <robertma@chromium.org> > Commit-Queue: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578084} Bug: 866802 Change-Id: Ib6b87fa99899ec0d974c417cb6e2362ddeabcb1b Reviewed-on: https://chromium-review.googlesource.com/1151467 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#578382}
-
Stephen McGruer authored
This reverts commit e630f950. Reason for revert: AdaptiveToolbarViewControllerTest.DetectForceTouch failing on ios-uirefresh-simulator Bug: 868017 Original change's description: > Add unit test for toolbars' force touch gestures > > This CL adds a unit test for the force touch gesture recognizer added > to the toolbar buttons, triggering the popup menu. > > Bug: 864430 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Icc2524f7e8e58bf20fb4b1381913cb82c57206a8 > Reviewed-on: https://chromium-review.googlesource.com/1150142 > Reviewed-by: Mark Cogan <marq@chromium.org> > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578349} TBR=marq@chromium.org,gambard@chromium.org Change-Id: I7d4833a56c139ce501c673cd305c19efa456e1e0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 864430 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1151927Reviewed-by:
-
Stephen McGruer authored
This reverts commit 4480bf47. Reason for revert: Strong suspect for causing crashes in WidgetTest.FullscreenFrameLayout on linux-chromeos-rel Bug: 868004 Original change's description: > OopAsh: improve immersive fullscreen for app windows > > Immersive fullscreen for an app window almost works aside from the fact > that the normal frame remains when the app window is fullscreened. This > is a result of not updating the client area inset when the window show > state changes (e.g. from restored to fullscreen). The client area is > updated when the window bounds change, as they would when entering > fullscreen, but the bounds change comes through just before the state > change. Thus, when ClientSideNonClientFrameView checks fullscreen state > during layout, it still finds the widget is restored and calculates the > wrong bounds. The solution is to explicitly kick off a layout when > entering or exiting fullscreen. > > after launching with --enable-features=Mash --ash-dev-shortcuts > > Test: enter and exit fullscreen on an app window with ctrl+shift+F > Bug: 640365 > Change-Id: I499e29427ed072f3428de1f195ede1dc9892e71f > Reviewed-on: https://chromium-review.googlesource.com/1150618 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578353} TBR=sky@chromium.org,estade@chromium.org Change-Id: I2effa307fa2da94610130e6b084b6979fc4c070e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 640365 Reviewed-on: https://chromium-review.googlesource.com/1151908Reviewed-by:
-
chrome://safe-browsingDaniel Rubery authored
When we send a download ping, show the referrer chain so that problems with the referrer chain logic can be debugged. Bug: 865761 Change-Id: Id3f5dac4345b9cf179dee80417f99d94f3c3d7b0 Reviewed-on: https://chromium-review.googlesource.com/1150573Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#578379}
-
Mikolaj Boc authored
Using e.g. URLs as hash split keys is not possible ATM. Change this by deliberately not expanding the dictionary tree on settings split hashes. Change-Id: Ifbc09aedd546f2f7e774807e091caa2069e1d0a6 Reviewed-on: https://chromium-review.googlesource.com/1144880 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#578378}
-
Marcin Wiacek authored
@IntDef/@StringDef annotation are preferred way for declaring set of String/int values. 1. they need less space in APK than enum, see https://developer.android.com/topic/performance/reduce-apk-size#remove-enums 2. they give more control over allowed values than "static final" values Main goal of patch is writing "static final" values, enum and some classes in one common @IntDef/@StringDef form: 1. with @IntDef/@StringDef first, @Retention second and related @interface third 2. with values inside @interface 3. with NUM_ENTRIES declaring number of entries if necessary 4. with comment about numbering from 0 without gaps when necessary 5. with @Retention(RetentionPolicy.SOURCE) 6. without "static final" in the @interface Change-Id: Ifa37fd39666c206bf727f97fbf1f5c2e2a277ac0 Reviewed-on: https://chromium-review.googlesource.com/1147522Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#578377}
-
Hiroshige Hayashizaki authored
This CL rejects cross-origin redirects in top-level scripts of classic (dedicated | shared) workers in WorkerClassicScriptLoader, to ensure that the response and request URLs of a worker top-level script are same-origin in successful cases. As most of cross-origin redirects should be already rejected by loaders, this CL affects only cross-origin-redirected workers created from an extension origin that has permissions and CSP settings to access both the origins of the request and response URLs, which I expect extremely rare. This CL also adds browser_tests that cover such cases. Bug: 861965, 861564 Change-Id: I80c27f9df550490384b5066b4b192d6415210b6d Reviewed-on: https://chromium-review.googlesource.com/1135916Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#578376}
-
Manas Verma authored
The change is required for the sign-in after local save project. It will allow the save card icon to be able to animate and display text as part of feedback to the user that their card was saved. This will also allow the password manager icon to be able to animate and display text as well. Bug: 855186 Change-Id: I4e769a8b92f51a34d0feec10cdc77d508cd47b57 Reviewed-on: https://chromium-review.googlesource.com/1142439Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#578375}
-
Philip Rogers authored
Working on PaintTouchActionRects, I found this is unused. Removing this makes the code cleaner. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I762933aac6c937b8f7f617eb047fffbf4ddd3123 Reviewed-on: https://chromium-review.googlesource.com/1150829Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#578374}
-
etienneb authored
The symbol name returned by SymFromName may not contains a NUL character when the symbol name is exactly the size of the buffer. It believe this may also happen when the symbol name is too long and truncated. The original code is based on: https://msdn.microsoft.com/en-us/library/windows/desktop/ms680580(v=vs.85).aspx A right implementation can be found here: https://cs.chromium.org/chromium/src/base/debug/stack_trace_win.cc?l=145&rcl=f4ecb9e37e9e2d59e32b8b96f23ac4a1e33b9552 As described here: https://msdn.microsoft.com/en-us/library/windows/desktop/ms680686(v=vs.85).aspx NameLen The length of the name, in characters, not including the null-terminating character. MaxNameLen The size of the Name buffer, in characters. If this member is 0, the Name member is not used. This issue was causing the catapult symbolisation script to encode incorrect (random) characters into the symbol names. See the example in the bug. Original BUG=713741 Review-Url: https://codereview.chromium.org/2832643004 Cr-Commit-Position: refs/heads/master@{#466098} BUG=724399,b:70905156 Change-Id: Ia6de4ddbd5c66a966b74ecec3fda5e853f36073b Reviewed-on: https://chromium-review.googlesource.com/1147669Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Gabriel Marin <gmx@chromium.org> Cr-Commit-Position: refs/heads/master@{#578373}
-
Koji Ishii authored
Bug: 866556 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie9977ebaa733e43d54fa6006e88adb3fce7cfb50 Reviewed-on: https://chromium-review.googlesource.com/1146882Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#578372}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/3190ae3f2fd3..52660b68f115 git log 3190ae3f2fd3..52660b68f115 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 dgarrett@google.com prototype-firmwarebranch: Switch to standard firmware configs. Created with: gclient setdep -r src/third_party/chromite@52660b68f115 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Iccb54945bbf3ad54309b17dc34dc4184dbe7c63a Reviewed-on: https://chromium-review.googlesource.com/1151507Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578371}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/17aff35e1dea..e4db6a151806 git log 17aff35e1dea..e4db6a151806 --date=short --no-merges --format='%ad %ae %s' 2018-07-26 peah@webrtc.org AEC3: Improved the accuracy of the adaptive filter 2018-07-26 buildbot@webrtc.org Roll chromium_revision 56d60694..96177551 (578186:578286) 2018-07-26 titovartem@webrtc.org Untangle fft third party lib from dependon WebRTC 2018-07-26 mbonadei@webrtc.org Enable clang::find_bad_constructs for congestion_controller/goog_cc. Created with: gclient setdep -r src/third_party/webrtc@e4db6a151806 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:867873,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ifa388fe6b4bb81c65959a0729af3afa38081cad5 Reviewed-on: https://chromium-review.googlesource.com/1151549Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578370}
-
Elad Alon authored
Before this CL, WebRtcEventLogManager was made aware of newly loaded profiles (BrowserContext-s) through code that called it from BrowserContext::Initialize. However, this runs before Prefs are loaded. We therefore introduce a KeyedService that will inform WebRtcEventLogManager of newly loaded BrowserContext-s; this happens after Prefs are loaded. Bug: 775415 Change-Id: I7a6beed0fda161784e2c8683793c387fa4734bda Reviewed-on: https://chromium-review.googlesource.com/1150023 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
-
