- 16 Dec, 2016 40 commits
-
-
scottmg authored
Crashpad initialization has been reworked to support an asynchronous mode where StartHandler() only calls CreateThread() and does not synchronize with that thread, making it safe to use in DllMain(). So, we can now move it back into chrome_elf to catch earlier crashes. We block much later now in browser startup, before a renderer (i.e. another client that would connect to the handler) will be started. This should not be strictly necessary, but is slightly more conservative as a first pass. This allows for error reporting, and prevents log spew from each renderer that starts up and tries to connect to a nonexistent handler. Also added is a UMA timer to see how long we're blocking startup for by joining with the background thread. This includes an effective revert of https://chromium.googlesource.com/chromium/src/+/f3a5670dd8d42b045d31625dde4a2561b471138f . BUG=655788,656800,565063 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2475863004 Cr-Commit-Position: refs/heads/master@{#439188}
-
https://crbug.com/606990bnc authored
It seems like https://crbug.com/606990 is fixed, this CL adds regression tests for it. BUG=606990 Review-Url: https://codereview.chromium.org/2576283005 Cr-Commit-Position: refs/heads/master@{#439187}
-
lgrey authored
BUG=647206, 673362 Review-Url: https://codereview.chromium.org/2582593003 Cr-Commit-Position: refs/heads/master@{#439186}
-
robertphillips authored
BUG=672527 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2583493002 Cr-Commit-Position: refs/heads/master@{#439185}
-
sdy authored
BUG=620049 Review-Url: https://codereview.chromium.org/2582793003 Cr-Commit-Position: refs/heads/master@{#439184}
-
dgn authored
BUG= Review-Url: https://codereview.chromium.org/2582793002 Cr-Commit-Position: refs/heads/master@{#439183}
-
nick authored
As far as I can tell this scheme does not do anything. It serves files from a directory that appears not to exist in a default install of Chrome for Windows, and I do not see code (outside of tests of this scheme) that would serve to create such a directory. BUG=674272 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2574763003 Cr-Commit-Position: refs/heads/master@{#439182}
-
zpeng authored
Create adding_to_third_party.md to document the process of introducing new 3rd party libraries to Chromium. Original source of information: https://www.chromium.org/developers/adding-3rd-party-libraries BUG=674221 Review-Url: https://codereview.chromium.org/2577123003 Cr-Commit-Position: refs/heads/master@{#439181}
-
michaeldo authored
BUG=620887 Review-Url: https://codereview.chromium.org/2585863002 Cr-Commit-Position: refs/heads/master@{#439180}
-
baxley authored
7 tests, at least some of which use context menus, are failing when run on devices. BUG=675015 Review-Url: https://codereview.chromium.org/2583683004 Cr-Commit-Position: refs/heads/master@{#439179}
-
estevenson authored
If GMS needs to be updated when fetching accounts and the user switches between Chrome and another app during the update, the GMS update dialog in Chrome will persist after the update is complete. Now, the dialog is dismissed when the view becomes invisible so that no GMS update dialog is shown when switching back to Chrome after a completed GMS update. BUG=669522 Review-Url: https://codereview.chromium.org/2552893002 Cr-Commit-Position: refs/heads/master@{#439178}
-
alph authored
NOTRY=true Review-Url: https://codereview.chromium.org/2583983002 Cr-Commit-Position: refs/heads/master@{#439177}
-
dgn authored
BUG=625646 Review-Url: https://codereview.chromium.org/2569953003 Cr-Commit-Position: refs/heads/master@{#439176}
-
Brett Wilson authored
Convert the preprocessor define to a buildflag //header defined in //media. The build arg is kept in //build/config/features.gni due to a dependency on WebRTC (described in a comment). R=xhwang@chromium.org Review-Url: https://codereview.chromium.org/2572883002 . Cr-Commit-Position: refs/heads/master@{#439175}
-
drcrash authored
BUG=none TEST=unit tests Review-Url: https://codereview.chromium.org/2557663002 Cr-Commit-Position: refs/heads/master@{#439174}
-
gogerald authored
BUG=666885 Review-Url: https://codereview.chromium.org/2585453002 Cr-Commit-Position: refs/heads/master@{#439173}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/99ad164886ba..138ea97c1aca $ git log 99ad16488..138ea97c1 --date=short --no-merges --format='%ad %ae %s' 2016-12-16 brianosman Add color space to picture image as a creation parameter 2016-12-16 robertphillips Add GM for filtering bug 2016-12-16 reed hide deprecated SkImage::preroll 2016-12-16 bsalomon move src/gpu/batches -> src/gpu/ops 2016-12-16 bsalomon Rename GrTestBatch and subclasses to Op BUG=673261 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2581253002 Cr-Commit-Position: refs/heads/master@{#439172}
-
thomasanderson authored
BUG=132847 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2579223002 Cr-Commit-Position: refs/heads/master@{#439171}
-
megjablon authored
Update the stings for the first and second run Data Reduction Proxy promos. BUG=674645 Review-Url: https://codereview.chromium.org/2583633002 Cr-Commit-Position: refs/heads/master@{#439170}
-
mthiesse authored
Reparenting the content CVC isn't necessary anymore; it won't be receiving input as the presentation view now captures it, and we can set the CVC size directly, rather than having it inherit the size from its parent view. This was also adding a lot of complexity and makes switching tabs/WebContents difficult. BUG=673536 Review-Url: https://codereview.chromium.org/2579163002 Cr-Commit-Position: refs/heads/master@{#439169}
-
xingliu authored
This CL changes all call sites of EmbedContentViewActivity to use CustomTabActivity. Didn't delete the EmbedContentViewActivity code yet, also not sure if we should clean the chrome strings for the titles if we don't need them. There are a couple of details in the UI: 1. Title is now using html document title instead of chrome strings. Not sure which one should we use here. 2. The color of the toolbar is same as EmbeddedContentViewActivity. But the color of icons or other components depends on their own logic and theme color of the activity, etc. 3. The url bar is not hidden for now, since the security icon color on tablet is not correct.(Black icon on a dark background). Don't have a spec so not sure if we would hide the url bar here and fix the icon color logic. Screen shots are attached in crbug. BUG=673522 Review-Url: https://codereview.chromium.org/2571553003 Cr-Commit-Position: refs/heads/master@{#439168}
-
bpastene authored
Copy-pasted from Marshmallow 64 bit tester (+ s/MMB29Q/NRD91N/) BUG=663803 Review-Url: https://codereview.chromium.org/2482793007 Cr-Commit-Position: refs/heads/master@{#439167}
-
joel.liang authored
Temporary turn the new SDF algorithm feature off. See here for more detail. https://codereview.chromium.org/1643143002 TBR=jvanverth@google.com BUG= Review-Url: https://codereview.chromium.org/2581563004 Cr-Commit-Position: refs/heads/master@{#439166}
-
nektar authored
Clamps the character ranges for which bounds are requested so that they fall within the number of pixel offsets provided by Blink. Blink doesn't always return the location of all the characters in an inline text box. BUG=674273 R=dmazzoni@chromium.org TESTED=manually using NVDA's Python Console and by calling get_characterExtents(offset, 0) and (offset, 1) on a few paragraphs Review-Url: https://codereview.chromium.org/2579323002 Cr-Commit-Position: refs/heads/master@{#439165}
-
mattreynolds authored
BUG=630769 Review-Url: https://codereview.chromium.org/2583683002 Cr-Commit-Position: refs/heads/master@{#439164}
-
jialiul authored
(1) Create SafeBrowsingErrorUI in security_interstitials component. Move display and command handling logic from SafeBrowsingBlockingPage to SafeBrowsingErrorUI. (2) Move all SB interstitial related strings from c/a/generated_reources.grd to components/security_interstitials_strings.grdp (3) Deprecate all interstitial related rappor metrics, since nobody is using them. BUG=666100 Review-Url: https://codereview.chromium.org/2575623002 Cr-Commit-Position: refs/heads/master@{#439163}
-
sadrul authored
GpuMain depends on display_compositor in cc, and GpuService depends on gfx and geometry mojoms. BUG=643746 Review-Url: https://codereview.chromium.org/2583933002 Cr-Commit-Position: refs/heads/master@{#439162}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1d9e2948..2590cbab Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2577383002 Cr-Commit-Position: refs/heads/master@{#439161}
-
pdr authored
6 new passing tests, likely from incremental paint property fixes: https://crrev.com/1ea99b023ae5c0d7a421b2e308fa910aa6bd107c 1 new css blend mode failure, likely from the recent blend mode work. 1 untriaged failure in popup menu positioning. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2579213003 Cr-Commit-Position: refs/heads/master@{#439160}
-
skobes authored
BUG=672060,672851 Review-Url: https://codereview.chromium.org/2585633002 Cr-Commit-Position: refs/heads/master@{#439159}
-
khorimoto authored
To retrieve: *all devices: call synced_devices() *unlock keys: call unlock_keys() *tether hosts: call tether_hosts() BUG=672263 Review-Url: https://codereview.chromium.org/2561683002 Cr-Commit-Position: refs/heads/master@{#439158}
-
justincarlson authored
BUG=674699 Review-Url: https://codereview.chromium.org/2580973002 Cr-Commit-Position: refs/heads/master@{#439157}
-
fbarchard authored
ConvertFromI420 to I420 supports destination stride for subrects. Mips MSA scaling and RGB565 conversion Change log: https://chromium.googlesource.com/libyuv/libyuv/+log/97fb18b8..b18fd21d https://chromium.googlesource.com/libyuv/libyuv/+/97fb18b8..b18fd21d BUG=libyuv:662,libyuv:660,libyuv:634 TEST=libyuv unittests pass on try bots. Review-Url: https://codereview.chromium.org/2580953002 Cr-Commit-Position: refs/heads/master@{#439156}
-
sadrul authored
BUG=none Review-Url: https://codereview.chromium.org/2584913002 Cr-Commit-Position: refs/heads/master@{#439155}
-
staraz authored
ImageCursor->SetDisplay() is called in Init() so that all cursors are loaded at launch. This fixes the bug where the cursor image is positioned off to the left in Chrome mash. BUG=615861 Review-Url: https://codereview.chromium.org/2268563003 Cr-Commit-Position: refs/heads/master@{#439154}
-
dtapuska authored
This change is intended to have no behavioural changes. Some of the math is slightly adjusted the root frame coordinates. The root frame coordinates are calculated via: A/scale - B/scale + VO + OO as it was previously (A-B)/scale + VO + OO If this is a problem we can store translateX and translateY as the actual coordinates instead instead a computation. Cleanup proposal: https://docs.google.com/document/d/1s4Lfy22CNU1OZ5Rec6Oano_5BvIhdK6uFVsVe7FphKI/edit BUG=625684 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2539283002 Cr-Commit-Position: refs/heads/master@{#439153}
-
mattreynolds authored
In preparation for making the icon in Physical Web omnibox suggestions tappable, add a highlighted version of the icon. This version will be shown when the icon is tapped. BUG=630769 Review-Url: https://codereview.chromium.org/2578313002 Cr-Commit-Position: refs/heads/master@{#439152}
-
chrishtr authored
BUG=668342 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2577123002 Cr-Commit-Position: refs/heads/master@{#439151}
-
agrieve authored
Revert of Support saturation overrides in saturated_cast (patchset #7 id:180001 of https://codereview.chromium.org/2578613002/ ) Reason for revert: Suspect breaking base_unittests (missing test name in unittest macro). https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/38202 Original issue's description: > Support saturation overrides in saturated_cast > > This is a requirement for adding a full saturated type implementation. > > BUG=672489 > NOTRY=true > > Committed: https://crrev.com/186c7dbbea5eef852bf0c4277d1da16f56f9156e > Cr-Commit-Position: refs/heads/master@{#439061} TBR=eae@chromium.org,jschuh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672489,674849 Review-Url: https://codereview.chromium.org/2582063002 Cr-Commit-Position: refs/heads/master@{#439150}
-
rbpotter authored
There is a lot of repeated code in other_options_settings.js. Simplify the code and make it easier to add additional options if needed in future. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2576233003 Cr-Commit-Position: refs/heads/master@{#439149}
-