- 14 Dec, 2020 40 commits
-
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I198128b18209814d1c4e5ac2a3bf5a554d866e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590285Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#836780}
-
Brian Sheedy authored
Fixes a typo in update_wpr_unittest.py that causes a test to fail with newer versions of the mock library due to assert_not_called actually working properly in newer versions. Bug: 1156832 Change-Id: Ic980f181ca18c3b0e2148fcdbd35fde39bd5c1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587756 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#836779}
-
chrome://flagsdpapad authored
Bug: 1148478 Change-Id: I40eb960f78bb165320483f17cae361ee299a5961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589453 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#836778}
-
Raymond Toy authored
Add metrics to record the value of latencyHint which can be one of four values in the following order: "interactive" "balanced" "playback" exact The first three are the values of the AudioContextLatencyCatergory enum. The last is for case when an explicit floating-point value is given. When the hint is a floating-point value, we record the value in milliseconds. Each of these metrics are recorded each time an AudioContext is created. Bug: 1156304 Change-Id: I264f6f9a38983bd0e40f42e720cfcf685e7a1cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586047Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#836777}
-
Fredrik Söderqvist authored
In some fairly generic code-paths we can have a 'filter' property while not actually applying it - and thus don't have a SVGResourceClient. (For example for 'filter' on <feImage>.) Bug: 1158392, 1028063 Change-Id: I12bf8b6120a17f750582f037d59951a565731210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589837 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#836776}
-
Fredrik Söderqvist authored
We can get null SVGResource objects if the property references an external resource while external resources are not allowed (which is the case for most properties ATM). Bug: 1158420, 1028063 Change-Id: I9fbd92166250cb2ba954cb754e3b3b0d1c476a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589877 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Clark DuVall authored
This is a reland of f63587ac Reason for reland: This broke on L because loadNativeLibrary returns void and it was being cast to int. We don't actually use the return value for anything, so just return success on L/M. Original change's description: > [WebLayer] Fix relro sharing in GPU and load native lib in the background > > WebLayer relro sharing in the browser process has likely always been > broken in WebView compatibility mode because the ClassLoader created > does not have a class loader namespace, see here: https://cs.android.com/android/platform/superproject/+/master:frameworks/base/native/webview/loader/loader.cpp;l=129-132;drc=master > Unfortunately, this is difficult to fix since sharing relro in WebLayer > when it is loaded in the same process as WebView causes crashes. This > will be investigated more in a follow up. > > Relro sharing was never implemented for the WebLayer GPU process, and > this change adds support to do that. > > In addition, library loading is kicked off on a separate thread much > earlier in startup, which allows it to finish before it is needed on the > UI thread. > > Pinpoint runs: > startup.mobile: https://pinpoint-dot-chromeperf.appspot.com/job/169ab7ef520000 > -18.4% messageloop_start_time > -3.4% navigation_commit_time > -1.8% first_contentful_paint_time > > weblayer_startup: https://pinpoint-dot-chromeperf.appspot.com/job/17959d48d20000 > -6.4% weblayer_startup_wall_time > > system_health.memory_mobile: https://pinpoint-dot-chromeperf.appspot.com/job/16d61b37520000 > -10.0% (3.9MiB) all_processes private_dirty_size > -29.8% (3.7Mib) gpu_process private_dirty_size > > Bug: 1146438 > Change-Id: I52292f0472f18397b0a900307649e6f1b54bd5c1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581007 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Richard Coles <torne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835580} Bug: 1146438 Change-Id: I189a6a3605174a60a5269839c6cb3ce89c18efbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586518 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#836774}
-
Alex Turner authored
Rarely, a subframe navigation to about:blank can have an ongoing activation throttle, which is unexpected and triggers a DCHECK. Such a navigation should not have a throttle created. We add a DCHECK to ensure a navigation with such a URL does not. We also temporarily add some DCHECKs that will provide some detail about the redirect chain when an unexpected filter is found. Finally, we add a DCHECK that covers uncommitted initial loads. These will only trigger when the original DCHECK already would have; which DCHECK triggers will tell us details about the navigation. Bug: 1155870 Change-Id: Id6ba3f47f75ef871456c2bd311995b4f7ff2ddab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576433 Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#836773}
-
Aaron Leventhal authored
When replacing an AXObject with a different type of object, and keeping the same id, we don't want to remove it from the relation cache, is its relations are still the same. In addition, make sure that AXIDs that are removed are removed from all relevant maps, so that the condition cannot occur where an AXID is removed from an owner children map, but is still tracked by the owner, thus its owned children do not think they are owned. The best failing test for this is in CL:2585685 which turns on accessibility for all browser tests, via browser_tests --gtest_filter="HistoryListTest.*". Bug: 1153576,1156936 Change-Id: I0bb4d38f78b343bd34d2e42e1cf695fcfd99460e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584610 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#836772}
-
Shengfa Lin authored
Add a sentence to describe New session command in New Request section Change-Id: I4ac4d6273e9d10afa2ac0b73b0e47d760df0f117 no-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585108Reviewed-by:
-
Solomon Kinard authored
Change-Id: Id537c69afff7c933498f072ec4b0fd1741e8d1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559801 Commit-Queue: Solomon Kinard <solomonkinard@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#836770}
-
Joon Ahn authored
Similar to using base::TimeTicks over base::Time, performance.now() only ticks forward and allows us to not worry about system time changes. It also allows for easier mock in tests. Bug: 1156229 Test: browser_tests --gtest_filter=*NearbySh* Change-Id: Id1cf98d77b5f3557aaa95daf8a3114714ef97008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587613 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#836769}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607925234-ef20c18621d9ca5f7c0d39fedb05c76a05c36900.profdata to chrome-mac-master-1607968714-c306ec7882cc59048926f4cb1ac6492a09bdd2f6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I5ecabd006d5301fcbd61c9dcdf1ab0669f8c83dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590406Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836768}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/928ad2740611..4b99456364d8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC atotic@google.com,ftirelo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1158020,chromium:783819 Tbr: atotic@google.com,ftirelo@google.com Change-Id: I4b016e987a6e2d38f57df92f6073f3ac880d64d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589339Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836767}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/778b2c216924..54174aefa84c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iffa6165398de3f1e011ca39b097b42ac7e0db108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589671Reviewed-by:
-
Michael Lippautz authored
Inheriting from Heap* containers is dangerous because of missing virtual destructors and trace methods. This only leaves HeapHashSet as container that can be inherited from, which has one actual use in production code. Bug: 1056170 Change-Id: I66a301754adb4d970ccc631f1113edcb915c3abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589855Reviewed-by:
-
Peter McNeeley authored
Bug: 1113306 Change-Id: I631f1d722acf8c39c296643e16c12ce6f3d0e95e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585629Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#836764}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/39f69dcae076..1f0dc9cd1b82 2020-12-14 johnstiles@google.com Update SkSL type priorities to differentiate signed/unsigned types. 2020-12-14 johnstiles@google.com Fix various SkSL errors that don't report a line number. 2020-12-14 brianosman@google.com Centralize storage/initialization of SkSL::Compiler in GrGpu 2020-12-14 brianosman@google.com SkSLSlide: Guard against asserts in the compiler 2020-12-14 johnstiles@google.com Replace SkSL::Type constructors with named factory functions. 2020-12-14 kjlubick@google.com [canvaskit] Update to emsdk 2.0.10 2020-12-14 kjlubick@google.com [canvaskit] Update Chrome version and use npm ci for tests 2020-12-14 kjlubick@google.com [canvaskit] Update npm dev dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: tdenniston@google.com Change-Id: I2e4bdabf3855e98b9b5d8589b06d81380a7894e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590204Reviewed-by:
-
Peter Wen authored
This is no longer used anywhere. Bug: 1015559 Change-Id: Ib7eb8a99276a66ce6150d062ad6f106d474b4b3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590386 Commit-Queue: Peter Wen <wnwen@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#836762}
-
Yi Gu authored
[CodeHealth] Convert chrome/browser/ui/views/tabs from base::Bind and base::Callback to Once/Repeating Bug: 1152282 Change-Id: I4ab30e88b352645a9a32dcc834931c5a8089c87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586155Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836761}
-
Michael Checo authored
Screenshot: http://shortn/_JRLox4VlQe Bug: 1156395 Change-Id: I079883b3f3557ccf6dad7cf5a39be737b8d6fec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578082 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
-
Ryan Sturm authored
50% of canary dev traffic has Google Search URL modified here to add a dark mode query param. We should only check the query is the same and that the URL broadly matches DSE (so origin/alt origin match). Bug: 1158466 Change-Id: Ib112dd2916e67c9fc075d4acb39e4f7e0a25ab02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588011 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#836759}
-
Yi Gu authored
Bug: 1007635 Change-Id: Ic21eacd6aa7760c94261e035871d97c1de6a8569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587351Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836758}
-
Liviu Tinta authored
This reverts commit 42509254. Reason for revert: Test ScrollNestedLocalNonFastScrollableDiv becomes flaky. Original change's description: > Fix ScrollNestedLocalNonFastScrollableDiv under ScrollUnification > > With Scroll Unification, in LayerTreeImpl::DidUpdateScrollOffset there > are cases where a ScrollUpdate may be mutating a ScrollNode that: > - has a MainThreadScrollingReason - the main thread needs to repaint it > each time we scroll. > - it isn't composited > > In this case, when ScrollNode is mutated we don't want to make a > corresponding change in the associated TransformNode. Instead, we want > to SetNeedsCommit so that the changed offset in the ScrollNode is > committed to the main thread, then blink regenerates its side of the > property trees and cc::Layers. > > In this test, we hit the first case. In order for the test to pass we > need to wait for the main thread to sync. > > Bug: 1086625 > Change-Id: Icdc3eb5cc786ebdecd516f3cb0fd58d47077d6ec > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585765 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Commit-Queue: Liviu Tinta <liviutinta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836593} TBR=kenrb@chromium.org,bokan@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,liviutinta@chromium.org Change-Id: I935deae0ef3f55868d18e8f6406c9746404a375b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1086625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590426Reviewed-by:
Liviu Tinta <liviutinta@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#836757}
-
Nicholas Hollingum authored
This is part of the work of migrating the existing functionality to use the new infra components. We factor the task management out of the context manager implementation and into a transition called the Startup. This includes metrics reporting as well, which make more sense in the context of the startup object. Bug: b/175360169 Change-Id: I49cc7e7740e76eda873ee7104924b3e344348154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584631Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#836756}
-
chinsenj authored
This is a part of go/cros-bento which aims to improve virtual desks. Currently a user can send the current active desk to an adjacent desk using keyboard commands. However, they cannot send it directly to any desk. This CL allows users to send windows to any desk through the context menu. Test: manual Bug: 1155370 Change-Id: I01d6199379a3a96ea78b5af1e3de4b8bc64fb7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572978 Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#836755}
-
Justin Donnelly authored
The holdback experiment ended on 2020-11-30 so this code is no longer required. This change mostly has no effect, assuming Finch isn't overriding the default-enabled state of kNewSearchFeatures. The one exception is that kLocalHistoryZeroSuggest, added in https://crrev.com/c/2581920, will now affect Android. Bug: 1073606 Change-Id: I251ba01c9546006dc717e5c8fc69721376d7e91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586064Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#836754}
-
Mikhail Khokhlov authored
This reverts commit d4e2b4da. Reason for revert: Causes failures on the android-pixel4a_power-perf bot. Original change's description: > [tools/perf] Enable proxy power metric on Pixel 4a bots > > This CL supplies two command-line flags that are necessary to compute > the proxy power metric (based on CPU usage and power profiles). > > * --fetch-power-profile downloads the power profile from the cloud. > > * --performance-mode=keep disables the Telemetry power management, > making it possible to collect cpu_freq events. Note that there will > likely be a drop in observed power rails metrics after this CL lands, > because devices will use more efficient CPU scheduling policy. > > Change-Id: I9aeecd80cda1a883e1994ba70b0a439cd83f8749 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566995 > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> > Cr-Commit-Position: refs/heads/master@{#832770} Bug: 1154788 TBR=johnchen@chromium.org,khokhlov@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ifdf838140e4cb2fb8bf5df321819a0d6901e299c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589858Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
-
Joel Riley authored
Original patch: http://crrev.com/c/2582997 Revert: http://crrev.com/c/2587604 Previous re-land caused MSAN failures due to uninitialized variable. This re-land has a one-line fix to initialize the value of stacking_order_ in accessibility_focus_ring_layer.h. Otherwise this patch is identical. Tested with 'linux_chromium_chromeos_msan_rel_ng' try job. With fix, no longer get uninitialized variable failures. Original change's description: > Re-land: Move focus rings and highlight layers under accessibility bubbles. > > Original patch: http://crrev.com/c/2568547 > Revert: http://crrev.com/c/2583106 > > Fix for issue where focus ring appears below switch access panel. Now clients can specify if they want their focus ring to appear above or below accessibility bubble panels. STS will specify they appear below, though other clients will (by default) specify they appear above all panels. This fixes an issue with the switch access focus ring didn't appear above the switch access panel. > > Original description: > > Move focus rings and highlight layers under accessibility bubbles. > > Will allow Select-to-speak panel UI to appear above focus ring and highlight layers. This also avoids the need to create more window containers. > > Bug: 1157261, 1143814 > Change-Id: Ibd8dd577ecd4fb5767b628c2eff679a2f6931b9c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582997 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Joel Riley <joelriley@google.com> > Cr-Commit-Position: refs/heads/master@{#836222} Bug: 1157261 Bug: 1143814 Change-Id: I445296009d67c9b71d60f5e6b5f17e48b188be71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588309Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Vikas Soni authored
1. Limit AImageReader max size to 1 based on the model name of the device. Model name of the device is sent from server side using the finch experiment. 2. There will be an equivalent critique CL to add a list of known devices which can only support max size of 1. This CL will be checked in first. 3. Move the finch experiment from media/ to gpu/ to avoid dependency issues. 4. Add error logs to print device model name for the devices which fails creating image reader with max size > 1. This is required so that the model name can then be added to the finch experiment. Bug: 1051705 Change-Id: Ie4809da3591b0535ca129642f248bf9534e37874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578385 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#836751}
-
Yicheng Li authored
After examining these metrics, we decided that these metrics are needed in at least 2021. Bug: b/174067213 Change-Id: I1dabb7dddea7b6f936ecb684016332976c3e7bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588016Reviewed-by:
Chris Thompson <cthomp@chromium.org> Commit-Queue: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#836750}
-
Zach Trudo authored
The response needs to be handled within this method anyway adding a class for handling it would be nice, but doesn't address any current issue. If portability is important in the future a new class can be created at that time. Bug: chromium:169883262 Change-Id: Idd8d8505ae003dc71f3b57b1d1877f6b4f903d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583507 Commit-Queue: Zach Trudo <zatrudo@google.com> Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#836749}
-
David Roger authored
This histogram is still used by the profile metrics dashboard. Fixed: 1121217 Change-Id: I82caf8e4c2afc738ca189ffcb57e4316e73afcb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587033 Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#836748}
-
Allen Bauer authored
Run with --enable-logging --vmodule=event_*=5,root_view=5 to enable the detailed diagnostic logging of input events as they pass through the event pipeline. Bug: 1156656 Change-Id: I9f1c7b369276ada145fb06586a8d5fd5d0582bd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550367Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#836747}
-
Caroline Rising authored
As a label button, the read later button will match the style of the other bookmark bar buttons. This change also fixes bugs with the button label/icon not updating colors corrently with themes. Bug: 1109316 Change-Id: Iebe176f60a87d26abbfdf1c8e01bc4c36f135445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586242Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#836746}
-
Abigail Klein authored
This ensures that the MediaToolbarButtonView, which inherits from ToolbarButton, gets the promo highlight. Before this change, the promo highlight was only applied to the BrowserAppMenuButton. Screenshot: https://screenshot.googleplex.com/FiSjzR3C4EZdDcJ Bug: 1055150 Change-Id: I6d8aae51731ca7c5d22283088f689ef16cfc88b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588643Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#836745}
-
Joel Riley authored
Resumes now happen at sentence boundaries. AX-Relnotes: N/A Bug: 1157817 Change-Id: Iaad4aa3fb0ae19d0d27d511e3cd8a04209d104bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586767Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Joel Riley <joelriley@google.com> Cr-Commit-Position: refs/heads/master@{#836744}
-
Sam Maier authored
Bug: 1157603 Change-Id: I04bf94d2e2d758cd871d5328513de135c2e155de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585843Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#836743}
-
Erik Chen authored
This CL has no intended behavior change. Change-Id: Ic05292cb7f620cd02e2950bee17b48c0ae69b725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585541 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#836742}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607925234-871dfb77196d03b9fcef95521dbd7963c906e6ee.profdata to chrome-linux-master-1607968714-2c0d8e306c302723844f6b00a98bd81e984a44c7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib9a429aa2088d617b48f40e524d685fd5c005259 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589338Reviewed-by:
-
