- 08 Sep, 2020 40 commits
-
-
Weilun Shi authored
We've already verified that the Experimental version of the CustomTabs.Visible histogram is actually better than the old one. So we make the CustomTabs.Visible use the new implementation and deprecate the .Experimental version. Bug: 1007308 Change-Id: I6b0e5337c596edfdfe14df9e045e48ee447f9105 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395079Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#805129}
-
Liquan (Max) Gu authored
Context: * Moves SkipToGPayHelper out of parseAndValidateDetails(). In order to make parseAndValidateDetails() a method of PaymentRequestSpec (in //components), parseAndValidateDetails() needs to be free of //browsers dependency, and SkipToGPayHelper is the dependency. * Move mSpec above parseAndValidateDetails(). In order to make parseAndValidateDetails() a method of PaymentRequestSpec, PaymentRequestSpec's definition has to comes ahead of parseAndValidateDetails(). Bug: 1102522 Change-Id: Ica7ee5d2df8cb8789b76f95f3839e635043681b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389226 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805128}
-
Aleks Totic authored
https://chromium-review.googlesource.com/c/chromium/src/+/2214895 introduced a change where LayoutTable started respecting OverrideLogicalWidth for flex items. This broke rendering of non-auto tables inside flexbox. The fix has 2 parts: 1) LayoutTable::UpdateLogicalWidth always respects OverrideLogicalWidth 2) FlexLayoutAlgorithm::ShouldApplyMinSizeAutoForChild returns true for tables. Another side effect of this fix is that the TablesNG flexbox hack is no longer needed. https://chromium-review.googlesource.com/c/chromium/src/+/1730138/167/third_party/blink/renderer/core/layout/ng/flex/ng_flex_layout_algorithm.cc Bug: 1123100 Change-Id: Ide428db79a3d9b26e426c6f7727349549ea40836 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392444 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#805127}
-
sczs authored
On iPhone the header container view will be hardcoded to kFeedCardIPhoneWidth in order to match the card width. Before: https://drive.google.com/file/d/1IAB3wM6tYx_DhcT3akytx11wJUhofOxf/view?usp=sharing After: https://drive.google.com/file/d/1hz5Qq0vrfu6VbUNu1IgDHOH_lBfeqwNv/view?usp=sharing Bug: 1124870, 1085419 Change-Id: I7a34f87ae227791d25cdc69be5b6137359416ea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392938 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#805126}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id6127b9f7641047fe5ea4b5165ec659edb1fad36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399680Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805125}
-
Trent Apted authored
This makes the test a bit more compelling than just ensuring the file name changes. There is no "rename" in the WritableFiles API, so the implementation must actually copy bytes over. This ensures the bytes are copied correctly. Bug: b/153021155 Change-Id: Iba73a146b4643f6dba1f89c8e1b4f6302b848777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397477 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#805124}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4b505928d537..0cf22e5ad89d 2020-09-08 aerotwist@chromium.org [loc] Escape paths correctly If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia91a63dc17da3efac0bf812c815103b04b07ca2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399378Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b6030fb2c818..04b9443274cf 2020-09-08 michaelludwig@google.com Fix SkRRect::ConservativeIntersect when inputs share corner 2020-09-08 jlavrova@google.com Fixing a bug (reusing wrong formatting state) 2020-09-08 egdaniel@google.com Fix sksl spirv subpassLoad. 2020-09-08 bsalomon@google.com Perf bot experiment, disable GLSL integers on ANGLE ES3 2020-09-08 fmalita@chromium.org SkArenaAlloc aligned under-allocation 2020-09-08 jvanverth@google.com Revert "Use Microsoft's ComPtr to wrap D3D12 objects." 2020-09-08 egdaniel@google.com Add support for input attachment descriptors. 2020-09-08 brianosman@google.com Harden MetalCodeGenerator::writeFields 2020-09-08 jlavrova@google.com Return to save/translate/restore for drawing via SkPicture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1124776 Tbr: reed@google.com Change-Id: I406f0b04dd1615a046e13e9d09cb9f9224861ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399070Reviewed-by:
-
Christopher Cameron authored
Prior to this change, only "reserved client ids" could open an IOSurface's mach port to create a GpuMemoryBuffer. Change this to allow it from any client id, but add validation to ensure that the client doesn't mismatch the size or format of the buffer. Also make GpuMemoryBufferHandle::Clone work for IOSurface mach ports (the underlying ScopedRefCountedIOSurfaceMachPort supports copy and assign operators). Bug: 1125879 Change-Id: Iec259e078461bb23d9021a427be8ae703bcfd26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396917Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#805121}
-
David Tseng authored
TBR=dtseng@chromium.org AX-Relnotes: n/a Fixed: 1125221 Change-Id: I1516f582a0a2e65b908f47989d7fcc4ec25c9ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399561Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805120}
-
Anatoliy Potapchuk authored
These calls are identical to feature_name().SetEnabled(). Let's change the calls and remove identical functions. Bug: 2390184 Change-Id: I2a222fe6911b1a67dda72c242fe5aa98c14fcf00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391143Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#805119}
-
James Vecore authored
This hooks up the receive manager mojo to receive dialog. When the dialog is open we try to enter high-visibility mode and wait for a share to come in. Once a share arrives, the user can confirm or reject the share. Bug: b:163148440, b:163147818 Change-Id: Iec27057a670f814992715490dcfaa4d4a3711e14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392396 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805118}
-
Prakhar authored
Pending build time looks within limits as of now: http://shortn/_knva2rUxM9 Change-Id: I7a98198bcd3eca40fdd8698946d8d6b5869148a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397978Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Prakhar Asthana <pasthana@google.com> Auto-Submit: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/master@{#805117}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 332b8fcc. With Chromium commits locally applied on WPT: 9dea9475 "[LayoutNG] Small legend large border and large legend small border" 030f8a68 "Allow composited foreignObject with backdrop-filter" 16f5f379 "Move pointerevent_touch-adjustment_click_target to WPT" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Id5f47c1185718314588c630bdfda1a272558c7c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399579Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805116}
-
cfredric authored
Change-Id: I9a64a0426c784bd692905512f32735e8d7ae600d Bug: 1126207 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398901Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@google.com> Cr-Commit-Position: refs/heads/master@{#805115}
-
Dan Harrington authored
Bug: 1126132 Change-Id: Idc971f841101cb59b65c42bcd845af35d03a813e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399342 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#805114}
-
Tom Anderson authored
BUG=1066670 Change-Id: I1db5526ff6929bd90ee19cec4494674dbeee1dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388708Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#805113}
-
Natalie Chouinard authored
Test is also failing on android-bfcache-rel: https://ci.chromium.org/p/chromium/builders/ci/android-bfcache-rel so further disabling it on all devices. TBR=wychen@chromium.org Bug: 1119322 Change-Id: Iff4476a20e05af9d8fac79a259b111c64bf22d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399564Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#805112}
-
Miguel Casas authored
This CL adds a GPU driver bug workaround for VP8 video decoding on Broadwell (BDW) devices, which are hard-disabled via driver patch now. Having this disabling in chrome:gpu is better for developers and testers on the field. [1] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/chromiumos-overlay/x11-libs/libva-intel-driver/files/Disable-VP8-decoder-on-BDW.patch;bpv=1 Bug: 1126058, b/167923822 Change-Id: Ifb74a66dd8a0e4d4b081b7e4bc42009803f4be72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398906Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805111}
-
Anthony Cui authored
Bug: 949716 Change-Id: If26c31874dd529ce3a37cfdd22eb4d7dfe61c14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385635Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/heads/master@{#805110}
-
Ilia Samsonov authored
Adding mac11.0 ci and try builders to builders list. Setting fallback path to mac11/10.16 and adding sub path for 10.15. Also adding missing mac10.15 ci builder. Bug: 1108410 Change-Id: Ifcd712696534393713b916d467d4a568e02dfaa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374046 Commit-Queue: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#805109}
-
Sven Zheng authored
Briefly went through the last 200 jobs and disable these flaky tests caused the jobs fail. Bug: 1111979 Change-Id: I33211e2e3eb14de37927fe7e35e476a1debe57bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399501 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805108}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I69deb938115a91d411d9f96932f209f6ca4eb9e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399442Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805107}
-
Lijin Shen authored
Add new unit tests for testing whether Util can decide promo action correctly based on the given external states by mocking Deps. Bug: 1109255 Change-Id: I3e7f653e4c156b2fadcdbb605ce40ecda3a738f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396601 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#805106}
-
Liquan (Max) Gu authored
Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/2388561 Reverting CL: https://chromium-review.googlesource.com/c/chromium/src/+/2393061 Reverting reason: The original CL was landed before its dependent CL got reverted, so the original CL got reverted later. This CL is to reland it after its dependent CL got relanded[1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2392763 Bug: 1107039 Change-Id: I04c2025310ceeea01f51ceb30231cefb6a134bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399520Reviewed-by:
-
John Abd-El-Malek authored
Also bring WebLayer's implementation closer to Chrome's (e.g. deleting safe browsing cookies and some other content types). Bug: 1123034 Change-Id: I0bb03c1096aa749215dda9cc137c9f859667021c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391560 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#805104}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/62442aceb0fb..22e5e179fa28 2020-09-08 aleksi@sapon.ca Vulkan: unused resolve attachments must be marked as such If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ibab670ec568f8c39fffc46b5d8db9d64e82a8a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399372Reviewed-by:
-
Thomas Guilbert authored
These tests verify that a we can't create a VideoFrame from a closed ImageBitmap or encode a destroyed frame. Bug: 1116636, 1121255 Change-Id: Iba02d61128f5544550351408020223681a29b5a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399448 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#805102}
-
Joel Hockey authored
iron-list provides better focus management for tab/chromevox navigation. Bug: 1096143 Change-Id: Icaf2d27da606c9792a5aef9ac27226a77c63e76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390939 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: Ie6d82daf29d48260a6b6adc7e6d177b73b092251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396496Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#805100}
-
Tibor Goldschwendt authored
Collapsing/expanding hides/shows the local module UI. Before: https://screenshot.googleplex.com/7YpsgDQZg6EQbjT After: https://screenshot.googleplex.com/3wv7qaoupMtPQj5 Bug: 1124089 Change-Id: I80d88b1c2311da6a4d047e2ffb4837b6d4158add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388977 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#805099}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9dd5f6257f3e..dc9083e4831f 2020-09-08 jleconte@google.com Fix WebRTC repo when retrieving git hash. 2020-09-08 hypan@google.com Explicitly check the root status when RunShellCommand has as_root set to True. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1052434,chromium:1123318 Tbr: rmhasan@google.com Change-Id: I716202a0dd28b4d86484dffba895135d03422e8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399365Reviewed-by:
-
Anatoliy Potapchuk authored
The API is only available in kiosk mode, but the documentation does not specify that. Bug: 1099688 Change-Id: Ia0d067d77d4fc75991e447c59ff77d9595ff8e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398623Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#805097}
-
Sunny Sachanandani authored
Texture quads are considered as "requires overlay" quads which means that non-opaque occluded texture quads will be put into an overlay without any possibility of blending. This is ok for video since overlay compatible YUV video quads don't have any alpha, but texture quads can have alpha. A totally transparent texture quad would show up as black. This CL fixes that by applying the underlay validation check to texture quads. Multiple texture quads are still promoted if possible, but a quad could be skipped if it's occluded and non-opaque. This CL also adds a pixel test for this scenario. Bug: 1122638 Change-Id: I5c4f120d88ce8ad2bd340b7a4aa33d59fe1ef116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2380161 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805096}
-
Gang Wu authored
This is different from current app menu redesign divider lines. AppMenu#mItemDividerHeight added long time ago, from the screenshot in crbug.com/331960,it seems app menu had divider lines between each items. And mItemDividerHeight is for calculate the height for that divider lines. And from https://codereview.chromium.org/377083002, we start to use OverflowMenuTheme in styles.xml(now it named OverflowMenuThemeOverlay), and it set <item name="android:listDivider">@null</item>, so we are no longer need AppMenu#mItemDividerHeight. Change-Id: I8c6bf1a5c9aeb5b5ac82eda7c6a5e924c7432156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393523Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805095}
-
David Black authored
This CL: * Adds drag-and-drop behavior to holding space views * Adds a new base class for holding space browsertests * Adds browsertests to verify drag-and-drop behavior Still TODO: * Add drag image Bug: 1124581 Change-Id: I4a2e7fe63b26b10b7a7563adcfe7569d095ea7fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392263 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805094}
-
Becca Hughes authored
The NTP team have raised concern with loading data on the NTP that takes a few seconds so this adds a feature that will load the data the first time but hide the module and then on the second load and beyond show the cached data. BUG=1121360 Change-Id: Ib1288dfccc026c5a6b37814c32a1d0561bfded0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393176Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
Sammie Quon authored
Adds a way to pipe data from WmGestureHandler -> DeskController -> DeskAnimationBase -> RootWindowDeskSwitchAnimator in preparation for the touchpad continuous desks gestures feature. This CL will remove the touchpad animation temporarily, if the feature is on, but will still switch desks. Done in this CL: 1) WmGestureHandler uses different path if the feature is enabled. 2) DesksController has 3 new functions for WmGestureHandler to use. 3) DesksAnimationBase has Update and End functions. Test: manual, with and without feature Bug: 1111445 Change-Id: I08af31452a6614de3d72c42433d1dde8b5704cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388276 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805092}
-
Dan Harrington authored
This was testing code previously removed Bug: 1115745 Change-Id: I68ce48491f7529c88ab29a915837eedb5b8bfc88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398900 Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
-
Torne (Richard Coles) authored
When we're not expecting an error but we get one, fail stating the actual error we received, not just the error count. Bug: 1106472 Bug: 1117289 Change-Id: I355b307a9dcf2ba0ecf24191541d6e74db761ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399522 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805090}
-
