GitLab

Reviewed by Maciej Stachowiak

Apply our vm reentry caching logic to String.replace with global
regexes.


git-svn-id: svn://svn.chromium.org/blink/trunk@42743 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        * fast/encoding/mailto-always-utf-8-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@42742 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Jon Honeycutt.

        - Mac part of fixing for <rdar://problem/6755137> Action dictionary for
          policy decision is missing keys when full-page zoom is used

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::actionDictionary): Use absoluteLocation() instead
        of pageX() and pageY(), which are adjusted for zoom.

WebKit/win:

        Reviewed by Jon Honeycutt.

        - Windows part of fixing <rdar://problem/6755137> Action dictionary for
          policy decision is missing keys when full-page zoom is used

        * WebActionPropertyBag.cpp:
        (WebActionPropertyBag::Read): Use absoluteLocation() instead of
        clientX() and clientY(), which are adjusted for zoom.

LayoutTests:

        - test for <rdar://problem/6755137> Action dictionary for policy
          decision is missing keys when full-page zoom is used

        * fast/loader/policy-delegate-action-hit-test-zoomed-expected.txt: Added.
        * fast/loader/policy-delegate-action-hit-test-zoomed.html: Added.



git-svn-id: svn://svn.chromium.org/blink/trunk@42741 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Jon Honeycutt.

        - implement DOMNode::nodeName()

        * DOMCoreClasses.cpp:
        (DOMNode::nodeName):

WebKitTools:

        Reviewed by Jon Honeycutt.

        - dump the node in the element dictionary in the action information
          passed to the policy delegate

        * DumpRenderTree/mac/PolicyDelegate.mm:
        (-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
        * DumpRenderTree/win/PolicyDelegate.cpp:
        (dumpPath):
        (PolicyDelegate::decidePolicyForNavigationAction):

LayoutTests:

        Reviewed by Jon Honeycutt.

        - updated result that shows the node in the element dictionary in the
          action information passed to the policy delegate

        * http/tests/security/feed-urls-from-remote-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@42740 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        Add a method to purge the Chromium plugin list cache.
        https://bugs.webkit.org/show_bug.cgi?id=25318

        * plugins/chromium/PluginDataChromium.cpp:
        (WebCore::resetChromiumPluginCache):

git-svn-id: svn://svn.chromium.org/blink/trunk@42739 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reviewed by Darin Adler.

We need to ensure that XMLTokenizer sets the current DocLoader before calling in to
any libxml2 methods that may trigger a load.  The presence of a DocLoader indicates
that the load was originated by WebCore's use of libxml2 and that we should enforce
the same-origin policy on it.  XMLTokenizer::initializeParserContext,
XMLTokenizer::doWrite and XMLTokenizer::doEnd were three methods that were not setting
the current DocLoader when they should have.

The XMLTokenizerScope class is introduced to simplify the pattern of saving, setting and
restoring the current DocLoader and libxml2 error handlers.  The DocLoader and error handlers
are saved and set when the scope is allocated, and restored to their previous values when
the scope is exited.

Test: http/tests/security/xss-DENIED-xml-external-entity.xhtml

* GNUmakefile.am:
* WebCore.pro:
* WebCore.scons:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/XMLTokenizer.cpp:
* dom/XMLTokenizer.h:
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::matchFunc):
(WebCore::shouldAllowExternalLoad):
(WebCore::openFunc):
(WebCore::XMLTokenizer::doWrite):
(WebCore::XMLTokenizer::initializeParserContext):
(WebCore::XMLTokenizer::doEnd):
(WebCore::xmlDocPtrForString):
* dom/XMLTokenizerScope.cpp:
(WebCore::XMLTokenizerScope::XMLTokenizerScope):
(WebCore::XMLTokenizerScope::~XMLTokenizerScope):
* dom/XMLTokenizerScope.h:
* xml/XSLStyleSheet.cpp:
(WebCore::XSLStyleSheet::parseString):
* xml/XSLTProcessor.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42738 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Fix for <rdar://problem/5874009>
        Add port 3659 (apple-sasl / PasswordServer) to the list of blocked ports.

        * platform/network/ResourceHandle.cpp:
        (WebCore::portAllowed):

LayoutTests:

2009-04-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Dan Bernstein.

        Update test and results for <rdar://problem/5874009>
        Add port 3659 (apple-sasl / PasswordServer) to the list of blocked ports.

        * platform/mac-tiger/security/block-test-expected.txt:
        * platform/mac/security/block-test-expected.txt:
        * security/block-test.html:



git-svn-id: svn://svn.chromium.org/blink/trunk@42737 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42736 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-21  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=25320
        Crash when changing block styles in a root that contains no visible content (but contains nodes with renderers)

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary): If the enclosing block is the 
        root editable element and it contains no visible content, create a new block but don't try and move 
        content into it, since there's nothing for moveParagraphs to move.

LayoutTests:

2009-04-21  Justin Garcia  <justin.garcia@apple.com>
        
        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=25320
        Crash when changing block styles in a root that contains no visible content (but contains nodes with renderers)

        * editing/execCommand/25320-expected.txt: Added.
        * editing/execCommand/25320.html: Added.
        * platform/mac/fast/forms/caret-rtl-expected.checksum: Replaced.
        * platform/mac/fast/forms/caret-rtl-expected.txt: Replaced.



git-svn-id: svn://svn.chromium.org/blink/trunk@42735 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Cameron Zwarich and Oliver Hunt.
        
        Re-Fixed <rdar://problem/6406045> REGRESSION: Stack overflow on PowerPC on
        fast/workers/use-machine-stack.html (22531)
        
        SunSpider reports no change.
        
        Use a larger recursion limit on the main thread (because we can, and
        there's some evidence that it may improve compatibility), and a smaller
        recursion limit on secondary threads (because they tend to have smaller
        stacks).

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::execute):
        (JSC::Interpreter::prepareForRepeatCall):
        * interpreter/Interpreter.h:
        (JSC::): Ditto. I wrote the recursion test slightly funny, so that the
        common case remains a simple compare to constant.

        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncToString):
        (JSC::arrayProtoFuncToLocaleString):
        (JSC::arrayProtoFuncJoin): Conservatively, set the array recursion limits
        to the lower, secondary thread limit. We can do something fancier if
        compatibility moves us, but this seems sufficient for now.



git-svn-id: svn://svn.chromium.org/blink/trunk@42734 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Minor clean-ups to WebKitCreateInstance change.
        
        Reviewed by Jon Honeycutt.

        * WebKitCOMAPI.cpp:
        (classFactory):
        (WebKitCreateInstance):



git-svn-id: svn://svn.chromium.org/blink/trunk@42733 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-21  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 25162: REGRESSION (r41176-r41242): Drag-selection above/below the line does not select to beginning/end
        https://bugs.webkit.org/show_bug.cgi?id=25162
        rdar://problem/6764354

        * page/Settings.cpp:
        (WebCore::Settings::Settings): Initialize editing behavior to Mac-style for PLATFORM(MAC).
        Later we may want to change this default to encompass other versions running on Mac.

        * page/Settings.h: Added EditingBehavior, setEditingBehavior, editingBehavior, and
        m_editingBehavior. Also moved m_maximumDecodedImageSize out of the middle of all
        the bit fields.

        * platform/graphics/IntPoint.h: Added a constructor to turn an IntSize into an IntPoint.
        I'm not sure the distinction here is serving us well at the moment. When converting from
        global to local coordinates you want to do IntPoint - IntPoint and have the result be
        another IntPoint, not an IntSize. And so on.

        * rendering/RenderBlock.cpp:
        (WebCore::positionForPointRespectingEditingBoundaries): Changed to use pointers more and
        separate coordinates less.
        (WebCore::RenderBlock::positionForPointWithInlineChildren): Turned into a member function.
        Added separate cases to support the Mac and Windows behavior.
        (WebCore::RenderBlock::positionForPoint): Updated for the change above. Also moved the
        computation of pointInContents closer to the place it's used.

        * rendering/RenderBlock.h: Updated for the new private member function.

LayoutTests:

2009-04-21  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Bug 25162: REGRESSION (r41176-r41242): Drag-selection above/below the line does not select to beginning/end
        https://bugs.webkit.org/show_bug.cgi?id=25162
        rdar://problem/6764354

        * editing/selection/resources/click-in-margins-inside-editable-div.js:
        Updated to expect different results on the Mac.
        * editing/selection/resources/click-in-padding-with-multiple-line-boxes.js: Ditto.

        * fast/css-generated-content/positioned-background-hit-test-crash.html: Clear the selection at
        the end of the test so the result won't include a caret.

        * platform/mac/editing/selection/click-in-margins-inside-editable-div-expected.txt:
        * platform/mac/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
        Copied from LayoutTests/editing/selection. Then changed to expect the different Mac results.

        * platform/mac/editing/selection/select-from-textfield-outwards-expected.checksum:
        * platform/mac/editing/selection/select-from-textfield-outwards-expected.png:
        * platform/mac/editing/selection/select-from-textfield-outwards-expected.txt:
        Changed to expect the different Mac results.

        * platform/mac/fast/css-generated-content/positioned-background-hit-test-crash-expected.txt:
        Changed to expect no caret.

        * platform/win/editing/selection/click-in-margins-inside-editable-div-expected.txt:
        * platform/win/editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
        Copied from editing/selection.

        * platform/win/editing/selection/select-from-textfield-outwards-expected.checksum:
        * platform/win/editing/selection/select-from-textfield-outwards-expected.png:
        * platform/win/editing/selection/select-from-textfield-outwards-expected.txt:
        Copied from platform/mac/editing/selection.



git-svn-id: svn://svn.chromium.org/blink/trunk@42732 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Rubber-stamped by John Sullivan.

        * StringsNotToBeLocalized.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@42731 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler and Kevin Decker.

        WebKit side of <rdar://problem/6781642>.
        
        When we call resize with an actual changed size, block until the plug-in host is done.
        
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::resize):
        * Plugins/Hosted/WebHostedNetscapePluginView.h:
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView updateAndSetWindow]):
        * Plugins/Hosted/WebKitPluginHost.defs:



git-svn-id: svn://svn.chromium.org/blink/trunk@42730 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        * DumpRenderTree/win/DumpRenderTree.cpp: Touched to force a rebuild.
        * DumpRenderTree/win/DumpRenderTree.vcproj: Delete any pre-r42726
        manifest files during the pre-build event.

git-svn-id: svn://svn.chromium.org/blink/trunk@42729 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42728 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42727 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-21  Steve Falkenburg  <sfalken@apple.com>

        Add registry-free CoCreateInstance API for WebKit clients: WebKitCreateInstance.

        Manifest-based registry-free COM continues to work for clients that have embedded
        manifests with isolated COM information.
        
        Reviewed by Adam Roben.

        * WebKit.vcproj/WebKit.def: Added WebKitCreateInstance.
        * WebKit.vcproj/WebKit.vcproj: Link against rpcrt4.dll for UUID hashing.
        * WebKit.vcproj/WebKit_debug.def: Added WebKitCreateInstance.
        * WebKitCOMAPI.cpp: Added.
        (CLSIDHash::hash):
        (CLSIDHash::equal):
        (CLSIDHashTraits::constructDeletedValue):
        (CLSIDHashTraits::isDeletedValue):
        (classFactory):
        (WebKitCreateInstance): New API.
        * WebKitCOMAPI.h: Added.

WebKitTools:

2009-04-21  Steve Falkenburg  <sfalken@apple.com>

        Use new WebKitCreateInstance API instead of CoCreateInstance
        or COMPtr's createInstance to instantiate WebKit COM objects.

        Reviewed by Adam Roben.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (initialize):
        (runTest):
        (createWebViewAndOffscreenWindow):
        (main):
        * DumpRenderTree/win/DumpRenderTree.vcproj:
        * DumpRenderTree/win/GCControllerWin.cpp:
        (GCController::collect):
        (GCController::collectOnAlternateThread):
        (GCController::getJSObjectCount):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::keepWebHistory):
        (LayoutTestController::webHistoryItemCount):
        (LayoutTestController::setIconDatabaseEnabled):
        * DumpRenderTree/win/WorkQueueItemWin.cpp:
        (LoadItem::invoke):



git-svn-id: svn://svn.chromium.org/blink/trunk@42726 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change pending unload and beforeunload counts to store the listeners in a single data structure that can be quickly iterated for dispatch.

WebCore:

2009-04-17  Timothy Hatcher  <timothy@apple.com>

        Change pending unload and beforeunload counts to store the listeners
        in a single data structure that can be quickly iterated for dispatch.

        <rdar://problem/6383352&6383379&6383940>

        Reviewed by Darin Adler.

        * WebCore.base.exp: Change what symbols are exported.
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading): Remove count updating code
        and move an if inside a block already checking m_frame->document().
        * page/Chrome.cpp: Remove disableSuddenTermination/enableSuddenTermination.
        * page/Chrome.h: Ditto.
        * page/ChromeClient.h: Ditto.
        * page/DOMWindow.cpp:
        (WebCore::pendingUnloadEventListenerMap): Create a static map.
        (WebCore::pendingBeforeUnloadEventListenerMap): Ditto.
        (WebCore::addPendingEventListener): Add the event listener to the map.
        (WebCore::removePendingEventListener): Remove the event listener from the map.
        (WebCore::removePendingEventListeners): Remove all listeners for the window.
        (WebCore::dispatchWindowEventToListeners): Dispatch the event to the given listeners.
        (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents): Send the beforeunload event.
        (WebCore::DOMWindow::pendingUnloadEventListeners): Return a count of pending listeners.
        (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): Send the unload event.
        (WebCore::DOMWindow::~DOMWindow): Remove the window from both event listener maps.
        (WebCore::DOMWindow::addEventListener): Call addPendingEventListener when needed.
        (WebCore::DOMWindow::removeEventListener): Call removePendingEventListener when needed.
        (WebCore::DOMWindow::removeAllEventListeners): Call removePendingEventListeners.
        (WebCore::DOMWindow::removeInlineEventListenerForType): Call removePendingEventListener when needed.
        * page/DOMWindow.h:
        (WebCore::DOMWindow::frame): Changed to be const.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::EventHandler): Remove count tracking code.
        * page/EventHandler.h: Ditto.
        * page/Page.cpp:
        (WebCore::Page::Page): Ditto.
        * page/Page.h: Ditto.

WebKit/mac:

2009-04-17  Timothy Hatcher  <timothy@apple.com>

        Change how sudden termination works with WebView teardown.

        <rdar://problem/6383352&6383379&6383940>

        Reviewed by Darin Adler.

        * WebCoreSupport/WebChromeClient.h: Remove disableSuddenTermination/enableSuddenTermination.
        * WebCoreSupport/WebChromeClient.mm: Ditto.
        * WebView/WebFrame.mm:
        (-[WebFrame _pendingFrameUnloadEventCount]): Ask the DOMWindow.
        * WebView/WebView.mm:
        (+[WebView canCloseAllWebViews]): Call DOMWindow::dispatchAllPendingBeforeUnloadEvents.
        (+[WebView closeAllWebViews]): Call DOMWindow::dispatchAllPendingUnloadEvents and
        call close on all the WebViews.
        (-[WebView _closeWithFastTeardown]): Remove code for unload event dispatch.
        (-[WebView _close]): Correct a comment.
        (+[WebView _applicationWillTerminate]): Call closeAllWebViews.
        * WebView/WebViewPrivate.h: Add canCloseAllWebViews and closeAllWebViews.

git-svn-id: svn://svn.chromium.org/blink/trunk@42725 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-21  Geoffrey Garen  <ggaren@apple.com>

        Rubber-stamped by Adam Roben.
        
        Disabled one more Mozilla JS test because it fails intermittently on Windows.
        (See https://bugs.webkit.org/show_bug.cgi?id=25160.)

        * tests/mozilla/expected.html:

WebKitTools:

2009-04-21  Geoffrey Garen  <ggaren@apple.com>

        Rubber-stamped by Adam Roben.
        
        Disabled one more Mozilla JS test because it fails intermittently on Windows.
        (See https://bugs.webkit.org/show_bug.cgi?id=25160.)

        * Scripts/run-javascriptcore-tests:



git-svn-id: svn://svn.chromium.org/blink/trunk@42724 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Adele Peterson.

        Fix some tests that are depending on Mac vs. Windows selection quirks accidentally.
        Added failing tests to the skipped list for SnowLeopard.

        * editing/resources/select-all-iframe-src.html: Moved.
        * editing/selection/resources/select-all-iframe-src.html: Moved from
        editing/resources/select-all-iframe-src.html, since this is used by a test in the
        selection directory. Changed mouse coordinates to be farther to the right so we
        don't depend on the rule for what's selected when you click below text on the last line.
        * editing/selection/select-all-iframe.html: Updated for new location of file above.

        * fast/events/standalone-image-drag-to-editable.html: Changed mouse coordinates to be
        farther to the right so we don't depend on the rule for what's selected when you click
        below text on the last line.

        * platform/mac-snowleopard/Skipped: Added some tests to the Skipped list.

        * svg/custom/pointer-events-path.svg: Clear the selection at the end of the test so it's
        not in the test results. Also removed unneeded use of the layout test controller.

        * platform/mac/editing/selection/select-all-iframe-expected.checksum: Generated new results.
        * platform/mac/editing/selection/select-all-iframe-expected.png: Ditto.
        * platform/mac/editing/selection/select-all-iframe-expected.txt: Ditto.
        * platform/mac/fast/events/standalone-image-drag-to-editable-expected.checksum: Ditto.
        * platform/mac/fast/events/standalone-image-drag-to-editable-expected.png: Ditto.
        * platform/mac/fast/events/standalone-image-drag-to-editable-expected.txt: Ditto.
        * platform/mac/svg/custom/pointer-events-path-expected.checksum: Ditto.
        * platform/mac/svg/custom/pointer-events-path-expected.png: Ditto.
        * platform/mac/svg/custom/pointer-events-path-expected.txt: Ditto.



git-svn-id: svn://svn.chromium.org/blink/trunk@42723 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-21  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19644
        Text copied with Select All pastes with a indent but shouldn't
        <rdar://problem/6102483> 
        Pasting the content of an HTML message in Mail causes addition nested <div> elements to be added
        
        To improve selectall/copy/paste fidelity of certain pages, we began wrapping copied content with
        a div that held properties and attributes from the fully selected body.  To fix the above issues, 
        only do this if if the body has certain properties or attributes.  We'll begin adding to this list as 
        necessary.  For now it's just background colors and images.  Tested copy/paste of nytimes, wired,
        arstechnica, and several others.
        
        Massive nesting can still happen, it will just be much less common.

        * editing/markup.cpp:
        (WebCore::createMarkup): 

LayoutTests:

2009-04-21  Justin Garcia  <justin.garcia@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19644
        Text copied with Select All pastes with a indent but shouldn't
        <rdar://problem/6102483> 
        Pasting the content of an HTML message in Mail causes addition nested <div> elements to be added

        * editing/pasteboard/19644-1-expected.txt: Added.
        * editing/pasteboard/19644-1.html: Added.
        * editing/pasteboard/19644-2-expected.txt: Added.
        * editing/pasteboard/19644-2.html: Added.
        * platform/mac/editing/inserting/insert-3907422-fix-expected.txt:
        * platform/mac/editing/pasteboard/paste-text-015-expected.checksum:
        * platform/mac/editing/pasteboard/paste-text-015-expected.png:
        * platform/mac/editing/pasteboard/paste-text-015-expected.txt:
        * platform/mac/editing/style/font-family-with-space-expected.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@42722 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by David Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=25250
        Allow platforms to snap the scroll thumb back to the drag origin
        during a drag.  Implement functions for Safari/Win and Chromium/Win
        to do this snapping at distances approximating the native ones.

        * platform/Scrollbar.cpp:
        (WebCore::Scrollbar::Scrollbar):
        (WebCore::Scrollbar::setValue):
        (WebCore::Scrollbar::scroll):
        (WebCore::Scrollbar::moveThumb):
        (WebCore::Scrollbar::setCurrentPos):
        (WebCore::Scrollbar::mouseMoved):
        (WebCore::Scrollbar::mouseDown):
        * platform/Scrollbar.h:
        * platform/ScrollbarTheme.h:
        (WebCore::ScrollbarTheme::shouldSnapBackToDragOrigin):
        * platform/chromium/ScrollbarThemeChromium.h:
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromium::shouldSnapBackToDragOrigin):
        * platform/chromium/ScrollbarThemeChromiumWin.cpp:
        (WebCore::ScrollbarThemeChromium::shouldSnapBackToDragOrigin):
        * platform/win/ScrollbarThemeWin.cpp:
        (WebCore::ScrollbarThemeWin::shouldCenterOnThumb):
        (WebCore::ScrollbarThemeWin::shouldSnapBackToDragOrigin):
        * platform/win/ScrollbarThemeWin.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@42721 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        * bindings/js/JSLazyEventListener.cpp:
        (WebCore::eventParameterName): Remove unreachable code when SVG is
        enabled.

git-svn-id: svn://svn.chromium.org/blink/trunk@42720 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Steve Falkenburg and Sam Weinig.

        * Scripts/run-webkit-nightly.cmd: Moved quotes from variable
        definitions to variable uses. Otherwise cmd.exe can get confused about
        the quoting.
        * Scripts/run-webkit-tests: Changed to use an absolute path to
        execAppWithEnv so that run-webkit-tests will work when run from
        outside the source tree.

git-svn-id: svn://svn.chromium.org/blink/trunk@42719 bbb929c8-8fbe-4397-9dbb-9b2b20218538

JavaScriptCore:

        Rename JavaScriptCore_debug.dll to JavaScriptCore.dll in the Debug
        configuration

        This matches the naming scheme for WebKit.dll, and will be necessary
        once Safari links against JavaScriptCore.dll. This change also causes
        run-safari not to fail (because the launcher printed by FindSafari was
        always looking for JavaScriptCore.dll, never
        JavaScriptCore_debug.dll).

        Part of Bug 25305: can't run safari or drt on windows
        <https://bugs.webkit.org/show_bug.cgi?id=25305>

        Reviewed by Steve Falkenburg and Sam Weinig.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:
        * JavaScriptCore.vcproj/testapi/testapi.vcproj:
        Use $(WebKitDLLConfigSuffix) for naming JavaScriptCore.{dll,lib}.

WebKit/win:

        Rename JavaScriptCore_debug.dll to JavaScriptCore.dll in the Debug
        configuration

        This matches the naming scheme for WebKit.dll, and will be necessary
        once Safari links against JavaScriptCore.dll. This change also causes
        run-safari not to fail (because the launcher printed by FindSafari was
        always looking for JavaScriptCore.dll, never
        JavaScriptCore_debug.dll).

        Part of Bug 25305: can't run safari or drt on windows
        <https://bugs.webkit.org/show_bug.cgi?id=25305>

        Reviewed by Steve Falkenburg and Sam Weinig.

        * WebKit.vcproj/WebKit.vcproj: Use $(WebKitDLLConfigSuffix) for naming
        JavaScriptCore.{dll,lib}.

WebKitTools:

        Rename JavaScriptCore_debug.dll to JavaScriptCore.dll in the Debug
        configuration

        This matches the naming scheme for WebKit.dll, and will be necessary
        once Safari links against JavaScriptCore.dll. This change also causes
        run-safari not to fail (because the launcher printed by FindSafari was
        always looking for JavaScriptCore.dll, never
        JavaScriptCore_debug.dll).

        Part of Bug 25305: can't run safari or drt on windows
        <https://bugs.webkit.org/show_bug.cgi?id=25305>

        Reviewed by Steve Falkenburg and Sam Weinig.

        * DumpRenderTree/win/DumpRenderTree.vcproj: Use
        $(WebKitDLLConfigSuffix) for naming JavaScriptCore.{dll,lib}.

git-svn-id: svn://svn.chromium.org/blink/trunk@42718 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Steve Falkenburg and Sam Weinig.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Link
        explicitly against gdi32.lib and oleaut32.lib.

git-svn-id: svn://svn.chromium.org/blink/trunk@42717 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Add test for (as of yet not implemented) HTML5 named option access.
        https://bugs.webkit.org/show_bug.cgi?id=25191

        I believe this will require separate implementations
        for V8 and JSC the way our current bindings are designed.

        * fast/dom/HTMLSelectElement/named-options-expected.txt: Added.
        * fast/dom/HTMLSelectElement/named-options.html: Added.
        * fast/dom/HTMLSelectElement/resources/TEMPLATE.html: Copied from LayoutTests/fast/dom/CSSStyleDeclaration/resources/TEMPLATE.html.
        * fast/dom/HTMLSelectElement/resources/named-options.js: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@42716 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42715 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=25309
        Better use AtomicStrings when calling from the V8
        bindings into WebCore code.

        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * bindings/v8/custom/V8HTMLCollectionCustom.cpp:
        * bindings/v8/custom/V8HTMLFormElementCustom.cpp:
        * bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@42714 bbb929c8-8fbe-4397-9dbb-9b2b20218538

https://bugs.webkit.org/show_bug.cgi?id=25304



git-svn-id: svn://svn.chromium.org/blink/trunk@42713 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        * page/mac/EventHandlerMac.mm:
        (method_setImplementation):



git-svn-id: svn://svn.chromium.org/blink/trunk@42712 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Darin Adler.

        Add a test for bug 3235: CSS2: Table cell coalescing in CSS broken
        <https://bugs.webkit.org/show_bug.cgi?id=3235>
        <rdar://3299883/>

        This was fixed long ago, but we should add a test to prevent a regression.

        * fast/table/cell-coalescing.html: Added.
        * platform/mac/fast/table/cell-coalescing-expected.txt: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@42711 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Ariya Hidayat.

        QWebElementSelection renamed to QWebElementCollection.

        * Api/qwebelement.cpp:
        (QWebElement::findAll):
        (QWebElementCollectionPrivate::QWebElementCollectionPrivate):
        (QWebElementCollectionPrivate::create):
        (QWebElementCollection::QWebElementCollection):
        (QWebElementCollection::operator=):
        (QWebElementCollection::~QWebElementCollection):
        (QWebElementCollection::operator+):
        (QWebElementCollection::append):
        (QWebElementCollection::count):
        (QWebElementCollection::at):
        (QWebElementCollection::toList):
        * Api/qwebelement.h:
        * Api/qwebframe.cpp:
        (QWebFrame::findAllElements):
        * Api/qwebframe.h:
        * QtLauncher/main.cpp:
        (MainWindow::selectElements):
        * tests/qwebelement/tst_qwebelement.cpp:
        (tst_QWebElement::simpleCollection):
        (tst_QWebElement::iteration):
        (tst_QWebElement::emptyCollection):
        (tst_QWebElement::appendCollection):
        (tst_QWebElement::nullSelect):

git-svn-id: svn://svn.chromium.org/blink/trunk@42710 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=25271

        Fix the build with disabled DOM storage or disabled database support.

        * bindings/js/ScriptObjectQuarantine.cpp:
        * bindings/js/ScriptObjectQuarantine.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@42709 bbb929c8-8fbe-4397-9dbb-9b2b20218538

git-svn-id: svn://svn.chromium.org/blink/trunk@42708 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        - fix <rdar://problem/5914146> Crash at -[NSScrollView scrollWheel:]

        -[NSScrollView scrollWheel:] runs a nested event-tracking run loop
        in a mode that allows WebCore timers to fire and NSURLConnection
        callbacks to be dispatched, which can release the NSScrollView and
        cause it to be deallocated (one example is a DOM timer callback that
        removes a subframe from the document). This leads to a crash in
        -scrollView:.

        The fix is to replace the implementation of -[NSScrollView scrollWheel:]
        with one that optionally retains the receiver for the duration of the
        call.

        * page/mac/EventHandlerMac.mm:
        (WebCore::nsScrollViewScrollWheelShouldRetainSelf): Added.
        (WebCore::setNSScrollViewScrollWheelShouldRetainSelf): Added. Replaces
        the implementation of -[NSScrollView scrollWheel:] with the
        self-retaining one, and sets a static boolean that tells it whether to
        retain the receiver around the call to the original implementation.
        (WebCore::selfRetainingNSScrollViewScrollWheel): Added. If
        setNSScrollViewScrollWheelShouldRetainSelf(true) was called and this
        function is executing on the main thread, it retains the NSScrollView,
        invokes the original -[NSScrollView scrollWheel:], then releases the
        view. Otherwise it just calls through to the original implementation.
        (WebCore::EventHandler::passWheelEventToWidget): Added calls to
        setNSScrollViewScrollWheelShouldRetainSelf() around the call to
        -scrollWheel:.



git-svn-id: svn://svn.chromium.org/blink/trunk@42707 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Also removed code previously needed to support running nightlies against Safari 3 on Windows.
        
        Reviewed by Mark Rowe.

        * FindSafari/FindSafari.cpp:
        (getStringValue):
        (getInstalledWebKitDirectory):
        (_tmain):



git-svn-id: svn://svn.chromium.org/blink/trunk@42706 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2009-04-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Mark Rowe.
        
        Tiger crash fix: Put VM tags in their own header file, and fixed up the
        #ifdefs so they're not used on Tiger.

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::RegisterFile):
        * jit/ExecutableAllocatorFixedVMPool.cpp:
        (JSC::FixedVMPoolAllocator::FixedVMPoolAllocator):
        * jit/ExecutableAllocatorPosix.cpp:
        (JSC::ExecutablePool::systemAlloc):
        * runtime/Collector.cpp:
        (JSC::allocateBlock):
        * wtf/VMTags.h: Added.

JavaScriptGlue:

2009-04-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Mark Rowe.

        Tiger crash fix: Put VM tags in their own header file, and fixed up the
        #ifdefs so they're not used on Tiger.

        * ForwardingHeaders/wtf/VMTags.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/HashTraits.h.

WebCore:

2009-04-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Mark Rowe.

        Tiger crash fix: Put VM tags in their own header file, and fixed up the
        #ifdefs so they're not used on Tiger.

        * ForwardingHeaders/wtf/VMTags.h: Copied from WebCore/ForwardingHeaders/wtf/HashTraits.h.

WebKit/mac:

2009-04-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Mark Rowe.

        Tiger crash fix: Put VM tags in their own header file, and fixed up the
        #ifdefs so they're not used on Tiger.

        * ForwardingHeaders/wtf/VMTags.h: Copied from ForwardingHeaders/wtf/HashTraits.h.



git-svn-id: svn://svn.chromium.org/blink/trunk@42705 bbb929c8-8fbe-4397-9dbb-9b2b20218538

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=21546
        [GTK] ATK accessibility enhancements

        Based on a patch by Alp Toker.

        Implement AtkComponent interface.

        * page/gtk/AccessibilityObjectWrapperAtk.cpp:
        (core):

git-svn-id: svn://svn.chromium.org/blink/trunk@42704 bbb929c8-8fbe-4397-9dbb-9b2b20218538