GitLab

When NTP realbox was initially implemented, we didn't use the default
provider list, and instead opted to create a manual whitelist of enabled
providers.

Original CL for context:
https://chromium-review.googlesource.com/c/chromium/src/+/1761688/22/chrome/browser/ui/search/search_tab_helper.cc#558

Now that we are aiming to bring NTP realbox to feature parity with
the actual omnibox, I suggest adopting this two-prong strategy.

 1. Aggressively enable all the same providers in realbox as in the
    omnibox. They should work in principle.

 2. Make NTP realbox work with chrome://omnibox so we can identify and
    fix any weird behavior. See:
    https://bugs.chromium.org/p/chromium/issues/detail?id=1058486

Here's the status on the four newly enabled suggestion types:
 1. On Device Head - seems to work fine.
 2. Document Provider - seems to work fine, although the icons don't
    have the nice custom document icons yet. Not a blocker IMO.
 3. KeywordProvider - I haven't noticed it activate on NTP realbox
    even when enabled. I think since we have forbidden keyword
    operations on AutocompleteInput, it's early exiting. We will need
    to enable chrome://omnibox for NTP realbox to verify this.
 4. Shortcuts - I can't see how this could cause a problem, but again,
    we will need chrome://omnibox to verify its behavior in realbox.

Bug: 1039357
Change-Id: Ibf2b2ec08a8f718c57f3af9456a7457185d67d6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088347Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747806}

Bug: 1026426
Change-Id: I0e085305564aaa6f1359ac11818de748b796d1d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088182Reviewed-by: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747805}

This reverts commit b8ffaf4c.

Reason for revert:
This broke the build of the blink_gc_plugin, which does not use base/
(see bug). Please don't commit to tools/clang/ without review.

Original change's description:
> IWYU for bind/callback_helpers.h and ptr_util.h
> 
> These missing includes are preventing removal of unused headers from
> task_runner_util.h and consequently migration from task_runner_util.h to
> task_runner.h's new PostTaskAndReplyWithResult member method.
> 
> The following script was run on every file in the codebase, prioritizing
> .h over matching .cc to best enforce the rule of not include a header
> included by your .h :
> 
> def Fix(file_path):
>   content = refactor_lib.ReadFile(file_path)
> 
>   # Assume fwd-decls are correct in first pass.
>   fwd_decls_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*class (NullCallback|DoNothing|ScopedClosureRunner);', re.DOTALL).findall(content)
>   if fwd_decls_match:
>     print 'fwd_decls_match in %s' % (file_path)
>     return False
> 
>   bind_helpers_match = re.compile(
>       # Doesn't begin with a comment.
>       r'\n *[^/\n][^/\n]'
>       # Anything else after a non-comment start (and don't allow this to capture a comment start either)
>       r'[^/\n]*'
>       # Anything before but an open angle-bracket to avoid cases like unique_ptr<Foo> where you don't need the full definition of Foo.
>       r'[^<]'
>       # Only match with base:: prefix; more precise, can manually fix missing includes in //base proper in a follow-up pass if needed.
>       r'base::(NullCallback|DoNothing|DeletePointer)\b[^*]', re.DOTALL).findall(content)
> 
>   callback_helpers_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::(IsBaseCallback|EnableIfIsBaseCallback|AdaptCallbackForRepeating|ScopedClosureRunner)\b[^*]', re.DOTALL).findall(content)
> 
>   ptr_util_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::WrapUnique\b[^*]', re.DOTALL).findall(content)
> 
>   if not bind_helpers_match and not callback_helpers_match and not ptr_util_match:
>     return False
> 
>   updated_content = content
>   if bind_helpers_match:
>     updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/bind_helpers.h")
>   if callback_helpers_match:
>     updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/callback_helpers.h")
>   if ptr_util_match:
>     updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/memory/ptr_util.h")
> 
>   if updated_content == content:
>     return False
> 
>   # Write updated file
>   refactor_lib.WriteFile(file_path, updated_content)
> 
>   return True
> 
> TBR=danakj@chromium.org
> (mechanical change for //base API)
> 
> Bug: 1026641
> Change-Id: Ic88585c62dd2f74d34c59c708faeddb231aee47f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087971
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Reviewed-by: danakj <danakj@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747685}

TBR=danakj@chromium.org,gab@chromium.org

Change-Id: I59d6cd69bd898e9f6d10922c67d8c24ba582bf7f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1026641, 1059359
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091356Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747804}

https://android.googlesource.com/platform/external/perfetto.git/+log/88d9224c538a..6b79fee5ae98

git log 88d9224c538a..6b79fee5ae98 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 taylori@google.com Merge "perfetto-ui: Don't throw an error for user queries"

Created with:
  gclient setdep -r src/third_party/perfetto@6b79fee5ae98

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Ib528ca755b55784860b2013be98da57076a4f446
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091666Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747803}

Fixed: 1037256,1037258,1021155,1053121,1053122,1037259,1037260,1037261,1037257,1025890
Change-Id: I97aef4c0d7537e3192ae2b1fc29164e7223e2690
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090364
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747802}

https://chromium.googlesource.com/angle/angle.git/+log/81cee994e1d2..e8883562ef57

git log 81cee994e1d2..e8883562ef57 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 geofflang@google.com Add a GN argument to enable/disable commit_id.

Created with:
  gclient setdep -r src/third_party/angle@e8883562ef57

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: ianelliott@google.com
Change-Id: I6c7825f5bab705102384fbf82ee6578a65235f4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091423Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747801}

https://webrtc.googlesource.com/src.git/+log/74dadc1e8e33..d14525eb59b9

git log 74dadc1e8e33..d14525eb59b9 --date=short --first-parent --format='%ad %ae %s'
2020-03-06 jakobi@webrtc.org Make sure that the audio stream is allocated with the correct overhead.
2020-03-06 hbos@webrtc.org [Overuse] Make VideoStreamAdapter responsible for executing adaptation.

Created with:
  gclient setdep -r src/third_party/webrtc@d14525eb59b9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I382cc50efd422913df42647580a7d336df6fd6d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091671Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747800}

In such case, it's enough to only remove the profile copy without
changing the account store.

Bug: 1032992
Change-Id: I75a3e8ebdcbf3c7bb096850cb031b06c1364e4b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091348
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747799}

Fixed this issue by overriding GetDescription().

Bug: 1059071
Change-Id: I7def9efbf3b9ae1d86511b875b8e44af60c99a56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090727Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747798}

This is a reland of 4ed2234c

Original change's description:
> generate_wrapper targets for iOS' non-EG/EG2 tests, EG, and EG2 tests
>
> The existing iOS recipe utilizes an isolate template, and an
> isolated.gen.json file to fill the template in per test with
> config-variables and path-variables. This isolate template contains
> the command arguments to invoke the iOS test runner.
>
> To support the iOS recipe migration to the Chromium recipe, I use GN to
> generate a script per test target instead of the isolate template. The
> script is pre-baked with arguments to the test runner (run.py). The
> given Swarming task is expected to execute the test by invoking the
> generated script.
>
> Invoking the generated script requires changes to gn_isolate_map.pyl
> for each iOS test target, and thus, these changes are only additive.
>
> * "ios_test_runner_wrapper" template wraps the generate_wrapper target.
>  It bakes iOS specific arguments into the script, such that it can
>  launch run.py with the given args.
> * ios_eg2_test, ios_eg_test, and test templates have
>  been updated to utilize the ios_test_runner_wrapper for iOS targets.
> * mb.py to skip generated_directory check when writing isolates.
>  View crbug/ in comments.
>
> Change-Id: I941d37dfdff0bd1ead1baff70907a197fee3fe64
> Bug: 1055328,912681
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023748
> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745105}

Bug: 1055328, 912681
Change-Id: Ie7979979365b570369e6b6f750cc9f3006024564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088345Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747797}

The current instruction is a bit confusing and the example 'smoothness'
no longer exists. Updating to make it clear.

Bug: chromium:1058129
Change-Id: Iaa37a77580035493744f2928be26e85ddfd0cf63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089954
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747796}

This CL refactors OmniboxPopupView::OnSelectionStateChanged into a new
OmniboxPopupView::OnSelectedLineChanged method.

The general theme for these refactors is:

The "OnFooChanged" methods should provide all the data necessary as
parameters, rather than forcing the delegate to reach back into the
OmniboxPopupModel to see what has changed.

This is because:
 - For WebUI, we want to minimize the number of calls / roundtrips.
 - This new API is I think more clear even for the native Views code.

Should be no behavioral changes here, just a pure refactor.

Bug: 1046561
Change-Id: I0aec1cb7487dc549270c8db677cd89fde1312b25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085604
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Orin Jaworski <orinj@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747795}

Add new string nickname to WalletMaskedCreditCard, also update
corresponding proto_visitor. We will update other copies of
this proto in other places as a follow up.

Please refer to design doc for more info: go/nicknames-autofill-dd

Bug: 1059087
Change-Id: I1a1f666e96049e9dec40a53ec4085bbcb4b1f3c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090770
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#747794}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ee8be8a36862..94bafe03c84e

git log ee8be8a36862..94bafe03c84e --date=short --first-parent --format='%ad %ae %s'
2020-03-06 tikuta@chromium.org add instruction for download failure due to 401

Created with:
  gclient setdep -r src/third_party/depot_tools@94bafe03c84e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: Ieee3fa0db1feae07d6d56735e1b7ce66dc5d1ee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091667Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747793}

The test was flaky less than 1% of the time because of a race between
the "Cancel" button click propagating and the scan responses. The fix is
to set up the delegate so that those responses never come back.

Bug: 1059060
Change-Id: I5d6dd17bfe76f8a2120e3a8cd1cb312f8f5c1fac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090135Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747792}

Change-Id: I2200d62068bde5defc3ce0ae65978b6850d7520d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090363
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747791}

The end_time of SendBeginMainToCommit would be set by the time that
OnFinishImplFrame is received, which might be before the MainFrameAbort.
This could result into TotalLatency being smaller than the sum of stages.

Bug: chromium:1048696
Change-Id: I551c495da084c1887410495caab28de91cfa63e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062575Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747790}

This reverts commit 28640451.

Reason for revert: build failures (https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/48184)

Original change's description:
> Add browser tests for DeepScanningDialogDelegate
> 
> These tests use the least possible amount of overrides to ensure
> DeepScanningDialogDelegate every requests/callbacks eventually resolves
> and returns to the caller.
> 
> Also add code to handle the web contents being destroyed and avoid ASAN
> issues.
> 
> Bug: 1041890
> Change-Id: Ibfe232354f0591ae9e854bf5a0163ede68d6faf9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083598
> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
> Reviewed-by: Daniel Rubery <drubery@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747713}

TBR=drubery@chromium.org,domfc@chromium.org

Change-Id: I6f6df269f31685f004d317e42670542e3e69941c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1041890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090208Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747789}

http://crrev.com/c/2012901 this CL uses DisplayAndroid to get screen
height as preparation for upcoming android R. However, the new way of
fetching screen height includes the top and bottom bar height, which is
different from the setup we use in tab_ui. This CL fixes this issue.

Bug: 1046395
Change-Id: If0bf151a90147b237cf8f41806e1d42b0ff70d1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023250
Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747788}

Change-Id: I6fb443e529da1a09eb607972e107d2f6e260fb35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091590
Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747787}

Since we are no longer launching the Zenith PiP button on ChromeOS,
this CL updates the fieldtrial_testing_config.json to reflect that.

Bug: 1058771
Change-Id: I4d21021bc1db0d3ddedefd28a6c73b5c8c2fec91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091213Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747786}

Changed the data type of underlying buffer to unique_ptr<uint8_t[]>.
Removed the alignment and padding logic because ffmpeg copies the data
in av_packet_ref().

Bug: 834088
Change-Id: I984963b081ff24afb2f05aa0b7aeb718be7fa899
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090303Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Qingwen Pi <qwp@google.com>
Cr-Commit-Position: refs/heads/master@{#747785}

Fixed by moving the file-reading callback to where it's actually needed.

Bug: 1058891
Change-Id: Id90f7de25ce747a7647c1259a7e7cb48885caecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090511Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747784}

Bug: 1052460
Change-Id: I044ee0b2e13e9cafd51c64ffa92f4de5e152f79a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087173
Commit-Queue: benjamin joyce <bjoyce@google.com>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747783}

Consistently fails on K. Example build:
https://ci.chromium.org/p/chromium/builders/ci/KitKat%20Phone%20Tester%20%28dbg%29/20759

TBR=meiliang@chromium.org

Bug: 1059299
Change-Id: I63fa06d7aeb69d994175bcd0eb11bd56f3b81add
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091726Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747782}

This CL enables baseline_tab_suggestions under the Immediate variation
for close tab suggestion.

Change-Id: Ibe37fe0060fd00d6d56e530e18bc9eee1ab81efc
Bug: None
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090798Reviewed-by: Mei Liang <meiliang@chromium.org>
Reviewed-by: David Maunder <davidjm@chromium.org>
Commit-Queue: Mei Liang <meiliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747781}

Clairfy the correct thread behaviors for PaintPreviewClient and
PaintPreviewBaseService.

Largely just a documentation change.

Change-Id: Ia1f9cadc8420a80610b3fd8ddb17d77bae3b12d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090198Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747780}

Change-Id: I5c8a7f25889b7dfeca4c4b9693e456dac749c63a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087725
Auto-Submit: Jose Lopes <jabolopes@google.com>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747779}

We opted for this instead of outright removing the code since a
semi-recent change requires the migration logic.

R=davidbienvenu@chromium.org, grt@chromium.org

Bug: 1055349
Change-Id: Ie137bca4801f3647d37f1e12ad65bea353c43b2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087982
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747778}

Now that trace processor can read and emit proto annotations, we no
longer need a separate json config.

I turned the description into comments, and it will likely stay that way
because descriptions are rarely used. We eventually want the
requiredCategories to be a file/message option instead of the comment,
but right now trace processor only supports field options and not
file/message options, so we'll have to wait until that's implemented.

Bug: 1012687
Change-Id: I4ef713ebef151e959b9c373a220f9f2630415ed5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090452Reviewed-by: Deep Roy <dproy@chromium.org>
Reviewed-by: Mikhail Khokhlov <khokhlov@google.com>
Commit-Queue: Deep Roy <dproy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747777}

Bug: 1033573
Change-Id: I82212918f95850c8e650011d54dd9f6c752e99c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087696
Commit-Queue: Yann Dago <ydago@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747776}

Use v8::StackTrace::CurrentStackTrace() rather than
v8_inspector::captureStackTrace() to capture stack trace when looking
for script origin. This allows us to bypass forced resolution of
location info (line numbers, method names etc) and when the related
v8 change is landed (http://crrev.com/c/v8/v8/+/2080663), greatly
speeds DOM operations on certain pages with DOMSnapshotAgent enabled.

Bug: 1057211
Change-Id: Ifbb5c7fb89b1f752f5d353d138d3b2c52bcd7e08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079165Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747775}

This is never subclassed.  Inline its functionality into
ScopedViewsTestHelper and clean up a bunch of stuff as a result.

Bug: none
Change-Id: Ib8abbd30a8d19becfa6de78309cbc9a2f2581263
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091272
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org>
Reviewed-by: Thomas Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747774}

Change-Id: I13376d67fadeed4b7fe6e6c4114876d4a21c10ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090338
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747773}

This patch rewrites and cleanups the subtree visibility wpt tests
- Consistent naming
- Consistent reference and style in the tests
- Removed duplicate and unnecessary tests

R=chrishtr@chromium.org

Fixed: 1007291
Change-Id: Ia0ebcc9d380f26a2e7ac10ad745416c570779ff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090017Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747772}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/93731aec6bd2..9d8c9bf34d9c

git log 93731aec6bd2..9d8c9bf34d9c --date=short --first-parent --format='%ad %ae %s'
2020-03-06 jacktfranklin@chromium.org Remove Sinon and associated deps

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@9d8c9bf34d9c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Ib3ec218fc8a16e1d7beaa200f17424ecc09e8512
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091424Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#747771}

getCurrentUrl returns the NTP url in overview mode after this CL
https://chromium-review.googlesource.com/c/chromium/src/+/1894293
Overview mode is considered visible before finished hiding.
So, previously, getUrlBarData in handleOmniboxInOverviewMode would return the data for overview mode.
In this CL, I moved the update to after finished hiding the tab switcher.

Bug: 1049847
Change-Id: I08e7508ec3426314d924b008bb2e472103ae77e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088020Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747770}

This reverts commit 4093df97.

Reason for revert: build failures (e.g. https://ci.chromium.org/p/chromium/builders/ci/Linux%20Builder%20(dbg)/169420?)

Original change's description:
> Move ExecutionContext to LocalDOMWindow
> 
> This actually changes the structure, so that LocalDOMWindow inherits
> ExecutionContext, rather than Document.
> 
> I left as much logic as I could on Document, and had LocalDOMWindow
> call in to it. A few things needed to move for consistency, and I moved
> anything where the Document override of a ExecutionContext function
> was only called through the ExecutionContext interface.
> 
> Added null-checks and updated code to final format where it was necessary
> to keep tests passing, otherwise left transitional code/helpers intact.
> 
> Updated many unit tests that needed an ExecutionContext to use
> DummyPageHolder instead of just a standalone Document.
> 
> Bug: 1029822
> Change-Id: I9e4276aaeba476289e260e7a28e500db9982a424
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051021
> Commit-Queue: Nate Chapin <japhet@chromium.org>
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#747759}

TBR=dcheng@chromium.org,yhirano@chromium.org,haraken@chromium.org,japhet@chromium.org

Change-Id: I50475a6d5d6f50ba1891a18c078031555806fae5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1029822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090204Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747769}

This introduces types to represent update states and update priority.

Bug: 1048654
Change-Id: I9c09df32cad49a7e9901ed93e7cf3dd43ead6a83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2073399
Commit-Queue: Adam Norberg <norberg@google.com>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747768}

Fix for potential deadlock between crashpad and ExitCodeWatcher during
launch - Bug:1057774. In the case where we fail to fully initialize
crashpad, we need to explicitly stop the ExitCodeWatcher.

Bug: 1057774
Change-Id: I31befef2bf25477d38d78c4d136a76d3aaa3be52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087900Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Mike Rorke <mrorke@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#747767}