- 21 Nov, 2018 40 commits
-
-
Esmael El-Moslimany authored
When a div has its cursor style set to pointer, it is highlighted when clicked. This can be replicated on desktop using the dev tools device toolbar. When expand button does not have a label, the expand button is highlighted. The actionable attribute is used set the cursor style to pointer. The label div has has 0 dimensions when no label is slotted. Moving the actionable attribute down to the label div works for both when a label is present and missing. Bug: 907057 Change-Id: I23a0950b789c842739997554a3232c1805b3089e Reviewed-on: https://chromium-review.googlesource.com/c/1344819Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610170}
-
Becca Hughes authored
Add support for seeking to MediaController and the underlying media session. Consolidates the SeekForward/SeekBackward methods into a single Seek method. BUG=893296 Change-Id: I6e76406e2ec3d8afe3a31ae8acfdaf1dcbf667d7 Reviewed-on: https://chromium-review.googlesource.com/c/1306297Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#610169}
-
Brad Hall authored
Bug: 878527 Change-Id: I2e527d39337232a657c34aa51c021d82b5f8a02d Reviewed-on: https://chromium-review.googlesource.com/c/1347054Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Brad Hall <bradhall@google.com> Cr-Commit-Position: refs/heads/master@{#610168}
-
Aiden Benner authored
Can't use @JniStaticNatives in comments because it's not a valid javadoc tag. Use {@link JniStaticNatives} instead. Also renames instances of JNINatives -> JniStaticNatives in comments. Bug: 898261 Change-Id: I62d0dda735559af92473052f4856466308cd14a4 Reviewed-on: https://chromium-review.googlesource.com/c/1345231 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610167}
-
Allen Bauer authored
Removed IDS_CRITICAL_NOTIFICATION_RESTART; use IDS_CANCEL instead. Reworded IDS_CRITICAL_NOTIFICATION_TEXT content per referenced bug. TBR=cpu@chromium.org Bug: 763227 Change-Id: Ie8bf0157da2a62f0e1d32807b9b5ea022d02bd49 Reviewed-on: https://chromium-review.googlesource.com/c/938186Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#610166}
-
Kelvin Jiang authored
Add a loading state to activity log so we clear the activity log when we switch to a new extension. This ensures that the user does not see any previous data when new activity log data is being loaded. It also gives users a bit more feedback on progress loading the activity log. Bug: 832354 Change-Id: I30d5756fc375979d0a6f183af1e2e1bf25fe1073 Reviewed-on: https://chromium-review.googlesource.com/c/1345409 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610165}
-
Scott Violet authored
Ash related services, such as shortcut-viewer, create various objects that read command line flags (such as ui::Compositor). This makes such services copy the command line flags from chrome. Long term we shold move to a whitelist, but shorterm not copying all flags is causing display problems for some devices. BUG=906954,905569 TEST=none Change-Id: I408798f0c0a6145b84a926f464a6d76b3a116bb9 Reviewed-on: https://chromium-review.googlesource.com/c/1346690Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#610164}
-
Christopher Grant authored
When bundles start using bundle-specific native libraries, the unwind asset name will need to change accordingly. This is easier to do if the asset name is specified alongside the native library, which currently isn't always the case. Monochrome specifies its shared library in the public repo, but names the unwind asset in the internal repo. That means there'll be a build break if the library changes names. Note that non-Monochrome doesn't have this problem, because its public and internal configurations both specify the library and asset names together. These templates also don't have the luxury of specifying such properties in a root template, because they're reused by test APKs. We can clean this up with the following sequence: 1. Add the "monochrome" unwind asset specifier in the public repo. This will duplicate the value currently set in the internal repo. 2. Remove the internal repo variable assignment. 3. Land the bundle-specific libraries with their new names. BUG=874584 Change-Id: I7f4db40c0496a7f17e766afb1ba7e2b290054551 Reviewed-on: https://chromium-review.googlesource.com/c/1346809Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#610163}
-
liberato@chromium.org authored
Also adds a typemap for TrainingExample. Bug: 897463 Change-Id: I66d47d01e56e0a8f250783225662f258646e4cfa Reviewed-on: https://chromium-review.googlesource.com/c/1338223 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#610162}
-
Benoît Lizé authored
We don't need the feature anymore, especially since this will be available before native is loaded. In this case the feature flag would be at best misleading (because its setting would not be respected), and at worst cause crashes (calling a native method before native is loaded). Bug: 901835 Change-Id: I5e07931674ac1344e3ff3eff805c6b9d15e159d0 Reviewed-on: https://chromium-review.googlesource.com/c/1341833Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610161}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0e4dfcbcf4fd..8da7b350cf93 git log 0e4dfcbcf4fd..8da7b350cf93 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 alessiob@webrtc.org AGC2 adaptive digital false by default 2018-11-21 jonasolsson@webrtc.org Add ios bindings for PeerConnectionState. 2018-11-21 srte@webrtc.org Don't restart streams in scenario tests. Created with: gclient setdep -r src/third_party/webrtc@8da7b350cf93 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib4c1f6d347b02c39cf6ddfef6395c2b570bfab89 Reviewed-on: https://chromium-review.googlesource.com/c/1346929Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610160}
-
Etienne Pierre-Doray authored
Turn may_block_threshold and blocked_workers_poll_period into finch parameters under the experiment kMayBlockAdjustTasksTiming. Bug: 874080 Change-Id: I0104b68a96b08e9bf318258e75869555ab39e54b Reviewed-on: https://chromium-review.googlesource.com/c/1337276Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#610159}
-
Erik Luo authored
Bug: 700519 Change-Id: I85553324c653f7397ed538581dc62ac5260188fe Reviewed-on: https://chromium-review.googlesource.com/c/1329900 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#610158}
-
Peter Kasting authored
These pass on Windows. Bug: 320050, 327287, 406574, 427184, 624513, 701241, 865527 Change-Id: I51db36ebd63ca17b60eff0bf999ed3aae9ddd958 Reviewed-on: https://chromium-review.googlesource.com/c/1338955 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610157}
-
Lukasz Anforowicz authored
Bug: 907402, 902685 Change-Id: Ifa530668be9f322a2ae5d92692298c20f98da828 Reviewed-on: https://chromium-review.googlesource.com/c/1347089Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#610156}
-
Jun Cai authored
https://chromium-review.googlesource.com/c/chromium/src/+/1318750 The above CL changed the layout test expected file for the following two tests: http/tests/inspector-protocol/network/raw-headers-for-protected-document.js http/tests/inspector-protocol/network/security-info-on-response.js and these two tests fail in the Mojo Linux and Mojo Windows trybots: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Linux?numbuilds=200 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20Windows?numbuilds=200 This CL adds an expectation of failure for these two tests to: //third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService Bug: 898306 Change-Id: I63fb64fe5531c55dbcb06e9642aee22411ca5342 Reviewed-on: https://chromium-review.googlesource.com/c/1345432 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#610155}
-
Avi Drissman authored
Their last listeners were removed in r593728 and their last broadcasters were removed in r598355. BUG=411569 Change-Id: I1471d4984a2e0439d29daf538972b317940af224 Reviewed-on: https://chromium-review.googlesource.com/c/1346835Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610154}
-
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: p*/ - s*/ Most of this patch is mechanical rebaseline, except that some LayoutNG-specific baselines become redundant and are removed. For some svg tests, we see new text lines in their text dumps. This is because legacy TextIterator doesn't enter <svg> elements, while innerText does so and dumps text from <foreignObject>. Bug: 887148 Change-Id: Ieef2419ab4deeeb64fe47cc0af49c30c6ca6887a Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1335844Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#610153}
-
Mikel Astiz authored
Historically, sync integration tests were incompatible with testing an actual browser restarts, leading to (best case) weird workarounds or (more often) lack of test coverage for very basic functionality (e.g. loading of persisted data). Browser tests do support a mechanism for this, which involves prefixing test names with PRE_, designed to reuse the very same profile path in multiple tests and hence carry over state. The only reason why this didn't work for sync integration tests is that we created random directories on every test run: instead, this patch makes the profile path deterministic. In this patch, a couple of tests are migrated to the new scheme, as a proof-of-concept. Bug: 856696 Change-Id: I6bf33bcb78d834984ff5230f7119cb79eb8bab55 Reviewed-on: https://chromium-review.googlesource.com/c/1341996 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#610152}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fd17a12ec7ac..d69ae20edf94 git log fd17a12ec7ac..d69ae20edf94 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 perezju@chromium.org [soundwave] Add timeseries2 API Created with: gclient setdep -r src/third_party/catapult@d69ae20edf94 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:900218 TBR=sullivan@chromium.org Change-Id: I15708dc6e61810aa55530c6e1713f11350b2f545 Reviewed-on: https://chromium-review.googlesource.com/c/1347071Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610151}
-
Alexandr Ilin authored
This CL updates the expiry from M72 to M73 for the following histograms: - CustomTabs.ResourcePrefetch.Duration.Failure - CustomTabs.ResourcePrefetch.Duration.Success - CustomTabs.ResourcePrefetch.FinalStatus The experiment these histograms were added for isn't complete yet. Bug: 899952 Change-Id: I9963e520c8ed966525b9e172a2acbe0e568da673 Reviewed-on: https://chromium-review.googlesource.com/c/1343006Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610150}
-
Guido Urdaneta authored
Since screen capture does not have a clear concept of native resolution, rescaling will be enabled by default and will be disabled only if explicitly requested. This maintains existing behavior in all existing applications that use content capture. This CL concludes the resizeMode series. Bug: 854980 Change-Id: I8658e36f22501f18d1d9dc9b6b0fe6e24063140b Reviewed-on: https://chromium-review.googlesource.com/c/1310716 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#610149}
-
Ella Ge authored
This change is under a blink flag MovementXYInBlink. With the flag on, MouseEvent and PointerEvent's movement_x/y is calculated in blink instead of in browser. The movement_x/y for pointerrawmove event is not set yet. And also this CL does not handle the calculation when pointer is locked. These is going to be done in the following changes. See the design doc: https://docs.google.com/document/d/1jL93PMbNHLhr6jYd4AWkjB8wgS73C5EDUa_2kYOjOn4/ With the flag, movement_x/y is in dip (same scale with screenX/Y), which is different the current behavior(physical pixel). The coordinate space is discuss in this doc: https://docs.google.com/document/d/1mYk4qMxBVsFweqFOku2FZvMajejp2Q7XWGIld9ivlXE/ It needs to be changed or clarified before we enable the flag. Bug: 802067 Change-Id: I5abb71181702c3b5265985f6ff8d2537116c5e18 Reviewed-on: https://chromium-review.googlesource.com/c/1297744Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#610148}
-
Fredrik Söderquist authored
Three 'w' should be enough for everyone... Bug: 907470 Change-Id: I7a724e708b73e4d5a80bcd28a2a459912e5ae69b Reviewed-on: https://chromium-review.googlesource.com/c/1346399Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#610147}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ae57ced21615..1b079a6aacab git log ae57ced21615..1b079a6aacab --date=short --no-merges --format='%ad %ae %s' 2018-11-21 chrome-bot@chromium.org Update config settings by config-updater. 2018-11-21 achuith@chromium.org cros_vm: Move Device/VM to lib/vm.py Created with: gclient setdep -r src/third_party/chromite@1b079a6aacab The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic1f1a64ef8cc7d34fb271e9ebfe667f6bd2e475d Reviewed-on: https://chromium-review.googlesource.com/c/1346793Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610146}
-
Darwin Huang authored
Change-Id: I0e650bc3a98e7778278ef0e4f474c435c6d36611 Reviewed-on: https://chromium-review.googlesource.com/c/1328229 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#610145}
-
Collin Baker authored
Fixes promo display on Windows, where promo bubble is activated then immediately deactivated when opening a new tab. Change-Id: Icc764660b5a4840edf7e345fdd460126cc1c1600 Reviewed-on: https://chromium-review.googlesource.com/c/1344869Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#610144}
-
Andreas Butler authored
Implemented the proper throwing behaviour for handling the case of an opaque origin for IDBFactory.databases(). Also included is a WPT for verifying the behaviour written by jsbell@. Spec PR: https://github.com/w3c/IndexedDB/pull/250 Change-Id: I506f82bf69b27d34b499eacbe12aaa18a69b63be Reviewed-on: https://chromium-review.googlesource.com/c/1344629 Commit-Queue: Andreas Butler <andreasbutler@google.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#610143}
-
Matt Menke authored
Also move all PrivacyMode logic up to URLRequestJob layer and rename CanEnablePrivacyMode to ForcePrivacyMode, to mode accurately reflect what it does. TBR=droger@chromium.org Bug: 906864 Change-Id: I6527cc34579e474292491886a2fb54ba2003561e Reviewed-on: https://chromium-review.googlesource.com/c/1343051Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#610142}
-
Bruce Dawson authored
Until recently Chrome required the 10.0.17134 SDK to build because it needed declarations from that SDK and there was no more recent SDK. Now there is a more recent (10.0.17763) SDK which can also build Chrome and the 10.0.17134 requirement is annoying. Removing the requirement for a specific version means that some new Chromium developer might try building with an *older* version, but that is unlikely, and they will hit errors and will then just need to install the latest. That is better than forcing developers to install an old SDK version. Bug: 907300 Change-Id: Iad5a5bb1cdab944926df030cb1adb46ae0d55b56 Reviewed-on: https://chromium-review.googlesource.com/c/1345652Reviewed-by:
Xi Cheng <chengx@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#610141}
-
Kevin McNee authored
Add crash keys to identify why the forbidden access is happening and which WebView extension function(s) are involved in the kill. Bug: 780728 Change-Id: I7b68103696ef3c5c46a5e00299aceef422e136bd Reviewed-on: https://chromium-review.googlesource.com/c/1344874Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#610140}
-
Yi Su authored
google_services_settings_egtest. google_services_settings_egtest.testActivityAndInteractionsDisabledWithHistoryDisabled is disabled on both simulators and devices. Update the message in macro EARL_GREY_TEST_DISABLED. Change-Id: I8c25d3031067f2c571f0c3ceb56a9742f5f55ddf Reviewed-on: https://chromium-review.googlesource.com/c/1345438Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#610139}
-
Allen Bauer authored
Change-Id: Ibf1c13b9cd48393bafe12c4c38d7fc7dba976699 Reviewed-on: https://chromium-review.googlesource.com/c/1342764 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#610138}
-
edchin authored
The private method |-(CGFloat)headerHeightForTab:(Tab*)tab| was not using the |tab| argument in calculations. Therefore, the argument was unnecessary. Furthermore, there already exists a property called |headerHeight|, which called this private method. This CL simplifies and removes unnecessary references to Tab. Change-Id: Ib56aef51929d59e672197d2c9d58cf62061209f0 Reviewed-on: https://chromium-review.googlesource.com/c/1344834Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610137}
-
Nate Chapin authored
1. When selecting a thread for a task, consider which thread all prerequisites were assigned, not just the ones still pending. 2. Store the v8::Value for completed tasks. 3. If a task will run on the same thread as a completed prerequisite, hop to the worker thread and pass the prerequisite's result directly without a deserialization. (2) enables this, and (1) increases the frequency in which this optimization can be used. 4. Given that it is no longer guaranteed that the serialized result will be needed (i.e., if all dependents run on the same thread and task.result is never requested on the main thread, only the v8::Value will be used), move to a lazy serialization model, where the result is only serialized when it is promised via task.result or when a dependent is assigned to a different thread. Bug: 879306 Change-Id: I22fe5f201f22b376861a5fb6d6e881ce0d5785cc Reviewed-on: https://chromium-review.googlesource.com/c/1311498 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#610136}
-
Peter Kasting authored
This also tries to get closer/improve debuggability for RenderTextTest.MoveLeftRightByWordInBidiText, which remains disabled. Bug: 196326, 906308 Change-Id: I1e9c1217d5ef2e05aa49315de5138c5ad8de0f99 Reviewed-on: https://chromium-review.googlesource.com/c/1343564 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#610135}
-
jdoerrie authored
This change modifies HttpPasswordStoreMigrator to not replace the signon_realm if the previous signon_realm did not have a HTTP scheme. While rare, this scenario can happen for federated credentials that have been saved on a secure HTTP origin, such as http://localhost. Bug: 687968 Change-Id: Ib777aac0aadd1ca39723de40b40fd75193954f7e Reviewed-on: https://chromium-review.googlesource.com/c/1346458 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#610134}
-
Ryan Meier authored
Change-Id: I6d2fcdf455cb65faa67450754b8fea4084783afb Reviewed-on: https://chromium-review.googlesource.com/c/1340957 Commit-Queue: Ryan Meier <rameier@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#610133}
-
Ryan Meier authored
Change-Id: Idc5ad051bdbe1699ddcf018e33f9f09e8de54f48 Reviewed-on: https://chromium-review.googlesource.com/c/1345413 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#610132}
-
Clemens Arbesser authored
This overlay also blocks users from interacting with the website until the onboarding screen is closed. Before: https://screenshot.googleplex.com/Xx1bJCk0YBp.png After: https://screenshot.googleplex.com/zBX6vYLym2c.png Bug: 806868 Change-Id: Id4cbb9c19ef561c5e61d70891830541e4dcfadbb Reviewed-on: https://chromium-review.googlesource.com/c/1346302 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#610131}
-