- 08 Nov, 2018 11 commits
-
-
Esmael El-Moslimany authored
Bug: 899602 Change-Id: I58371b62f9e810b25fa05e431db8e17b82ff0d10 Reviewed-on: https://chromium-review.googlesource.com/c/1308908Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#606238}
-
Carlos IL authored
Added UKM and UMA metrics that trigger when a site displays or runs mixed content. Bug: 901403 Change-Id: I855682e2c0999a859070e89907838bcc133f8673 Reviewed-on: https://chromium-review.googlesource.com/c/1319189Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#606237}
-
Peter Kotwicz authored
This CL makes HostBrowserUtilsTests easier to understand and modify. Changes: - Tests are now parameterized so that they run on both a bound and an unbound WebAPK. - Comments for the tests are shorter and more concise. - Global constants do not state whether the browser should be installed or not. BUG=None Change-Id: Ie1ce96892bf99001e07b42e3e4aaa4cdc53dfcb6 Reviewed-on: https://chromium-review.googlesource.com/c/1316364 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#606236}
-
John Chen authored
Add code to handle all unhandledPromptBehavior states defined by W3C spec, and make the behaviors spec compliant in W3C mode. To help testing the changes, also fixed error reporting code in ChromeDriver that was corrupting error messages in W3C mode. Bug: chromedriver:2597 Change-Id: I23e4fb0bff2fbc82213d8e28d79b82f0db220e29 Reviewed-on: https://chromium-review.googlesource.com/c/1321851 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#606235}
-
Ben Hayden authored
component is a singular string, not a list. Bug: chromium:902796 Change-Id: I0efd7f9eec2fb88173225ea4f597e8687fa9ee3a Reviewed-on: https://chromium-review.googlesource.com/c/1323801Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ben Hayden <benjhayden@chromium.org> Cr-Commit-Position: refs/heads/master@{#606234}
-
Steve Kobes authored
This avoids the use of Clone() in a couple of places. (It also creates new uses of Clone(), but only in tests.) Requested in review thread of http://crrev.com/c/1294695. Change-Id: I0ce5c00f3a4acb25cf8d8e265cea063fac5301e2 Reviewed-on: https://chromium-review.googlesource.com/c/1307054Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#606233}
-
Robert Sesek authored
Bug: 546288 Change-Id: I06388c3d208a37f8743d1b116e50ef133d7a0857 Reviewed-on: https://chromium-review.googlesource.com/c/1324050 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#606232}
-
Paul Jensen authored
Bug: 902195 Bug: 900072 Change-Id: I97307e754cbdcb8eddd78e05b19b5f6b3bc0b3dd Reviewed-on: https://chromium-review.googlesource.com/c/1323790Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606231}
-
Tomas Popela authored
We have to check with define() whether the variable is defined instead looking at its value as it couldn't be defined. It's defined with: if (dcheck_is_configurable) { defines += [ "DCHECK_IS_CONFIGURABLE=1" ] } And the compilation failure: In file included from gen/modules/desktop_capture/linux/pipewire_stubs.cc:3: In file included from gen/modules/desktop_capture/linux/pipewire_stubs.h:11: ../../base/logging.h:846:5: error: 'DCHECK_IS_CONFIGURABLE' is not defined, evaluates to 0 [-Werror,-Wundef] ^ \#if DCHECK_IS_CONFIGURABLE Change-Id: I85137252cb3ebd6965037b747574804a3c837f40 Reviewed-on: https://chromium-review.googlesource.com/c/1312948Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tomáš Popela <tomas.popela@gmail.com> Cr-Commit-Position: refs/heads/master@{#606230}
-
Miguel Casas authored
This CL has a few side cleanups to crrev.com/c/1321773, taken out for clarity. - Renames class CanvasResourceProviderRamGpuMemoryBuffer to CanvasResourceProviderBitmapGpuMemoryBuffer - Moves calculation of |gl_format| to where it's used. Bug: 902585 Change-Id: Ia0f0393425afd60ad98dbdd38f3ef5bc0d5e9e2f Reviewed-on: https://chromium-review.googlesource.com/c/1321749 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#606229}
-
Takuto Ikuta authored
To speed up build time on windows component build, I will enable newly added /Zc:dllexportInlines- flag. The flag is similar to -fvisibility-inlines-hidden in gcc/clang. This flag makes inline member function is not exported if it does not have static local variables. But in few classes of chromium, we need to add additional EXPORT specifier to prevent link failure. This is a part of effort adding EXPORT speicifer to enable the flag. Master CL is https://chromium-review.googlesource.com/c/chromium/src/+/1317069 This CL was uploaded by git cl split. R=ericwilligers@chromium.org Bug: 901709 Change-Id: Ib1b1c7a0649ce67620a9b25ec77d4c6ace44b546 Reviewed-on: https://chromium-review.googlesource.com/c/1322252Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606228}
-
- 07 Nov, 2018 29 commits
-
-
Ken Rockot authored
Adds mojo_base.mojom.Token to serialize the new base::Token type. Bug: 895591 Change-Id: I7e982d75a9e5d40b4df7e49645d7bf4791e8d57e Reviewed-on: https://chromium-review.googlesource.com/c/1321191 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#606227}
-
Yao Xiao authored
Besides, as a result of exploring different approaches, this CL additionally adds FromAdState enum that can be potentially shared between WindowOpen and other event. Made the testing logic easier to follow by switching to parameter test and expecting single UMA/UKM entry per test. Bug: 897256 Change-Id: Ic3f0e3637de77968f15e17f25d340d2456f988ef Reviewed-on: https://chromium-review.googlesource.com/c/1292369 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#606226}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/ef4d21b915d8..693e848cded9 $ git log ef4d21b91..693e848cd --date=short --no-merges --format='%ad %ae %s' 2018-10-17 mutexlox vm_tools: Add functionality to update guest time. 2018-11-04 joelhockey vm_tools: seneschal: Add support for MY_FILES, use CamelCase mappings 2018-10-19 matthewmwang shill: Make Fast Transition configurable via dbus Created with: roll-dep src/third_party/cros_system_api Change-Id: I37d39cb64378164cabcddfbd3e14dd97b57935c1 Reviewed-on: https://chromium-review.googlesource.com/c/1324509Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#606225}
-
sebsg authored
There is an issue with the replacing logic if the forms and fields have no identifier. This CL does not fix this directly, but greatly reduces the cases where it will happen (only dynamic forms with more than one form with no id). Rogerm@ is working on a better way of identifying fields that should help resolve this: crbug.com/896689 Bug: 898346 Change-Id: I7e17a6a2009be9e376088640bb14a81549ebbef2 Reviewed-on: https://chromium-review.googlesource.com/c/1319851 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#606224}
-
Joshua Peraza authored
456476c3f62e Add ReadMinidumpUTF16String 95b177e79398 Flesh out ModuleSnapshotMinidump 2dee96b84114 Remove use of MSVC_SUPPRESS_WARNING bf327d8ceb6a Introduce "dart" dependencies configuration for embedding into Dart VM 411f0ae41d96 Implement MemoryMap for ProcessSnapshotMinidump df5d1aa3ff29 Implement Stack() for ThreadSnapshotMinidump 8e329d12c791 linux: Use capget syscall instead of its libc wrapper 5dd094381ca3 [sysinfo] Convert sysinfo ioctls to FIDL calls 96391cb80f47 [fuchsia] early return in handler on disable e00c42e63fad linux: use offset of d_name to get size of dirents 95e97a32eba4 Use a relative address in .note.crashpad.info 8c0d3d2c1e8c [fuchsia] support general registers for arm64 a4754a9ae94b [snapshot][arm64] rename CPU context pstate to spsr 9d4afb05820f [fuchsia][arm64] support vector registers dc0052bd43eb Fuchsia: Use SDK manifest for CC prebuilt and source packages 0b19010fba9f Include windows.h before dbghelp.h da3c7e7ac508 android: fix the build 236ee1076c81 Roll mini_chromium to d2c271a 9ee48fb1be75 Revert "Use a relative address in .note.crashpad.info" a008d8a151e2 Make Windows bots non-experimental 1b20b620cfc9 Fix 32-bit Windows downcast build failure 131dd81d4ce4 mac: Fix crashpad_snapshot_test ProcessReaderMac.Child*Thread* for 10.14 a9be1b140370 Add ProcessMemoryWin and re-factor tests 7f71c57a29cd [fuchsia] re-introduce pstate temporarily fdfd782c9bd6 switch to EXPECT_DEATH_CRASH bf10ed0a693b posix: use threadsafe gtest death test for ScopedGuardedPage 3663b7cbbec5 Reland "Use a relative address in .note.crashpad.info" 71c75401c43c Revert "[fuchsia] re-introduce pstate temporarily" e287a3ab12af win: fix mismatched format macros 651af7583b35 win: use zx format specifier instead of a cast Change-Id: Ie577589f7e27820954c69122f07241b14845783b Reviewed-on: https://chromium-review.googlesource.com/c/1315363Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#606223}
-
Mohamed Heikal authored
This cl adds a life of a resource doc to the repo to help chromium developers understand how the build system interacts with resources in chromium. Change-Id: I9f7a88fb6c50fc89e5068173cc4ce749eda6b488 Reviewed-on: https://chromium-review.googlesource.com/c/1281918 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#606222}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/50f60cb4b3a6..e769ed90c359 git log 50f60cb4b3a6..e769ed90c359 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 38dcb5ed..db720b4a (605924:606025) Created with: gclient setdep -r src/third_party/webrtc@e769ed90c359 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iba27cc51e79a343445620da9a9dae1bf8e24dc54 Reviewed-on: https://chromium-review.googlesource.com/c/1324030Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606221}
-
Emil A Eklund authored
Merge ShapeResult::ComputeGlyphPositions into ComputeGlyphBounds thereby avoiding an extra unnecessary iteration over the glyph vector. Change-Id: If0faa2ccfe870d0207b8e6e3b6f073a6224c7903 Reviewed-on: https://chromium-review.googlesource.com/c/1323796Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#606220}
-
Fredrik Hubinette authored
Change-Id: I60f38e50a0071fec803752d1f36dd7905a9adad2 Reviewed-on: https://chromium-review.googlesource.com/c/1316827Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#606219}
-
Joe Downing authored
Our previous logic would only check the common name of the certificate to use for third party auth. If someone wanted to use a cert which specified O or OU instead of CN, then that certificate could not be targeted via our Chrome Policy i.e. RemoteAccessHostTokenValidationCertificateIssuer. The new helper function will return the first valid field (in order): CN, O, OU. Our cert selection code will still favor CN so there won't be any compat issues. Change-Id: I2e1ea37f794c407e3b62afe87cf774976f283e55 Reviewed-on: https://chromium-review.googlesource.com/c/1323805 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#606218}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1f3ebd2b9a65..85b2efb9fc33 Created with: gclient setdep -r src-internal@85b2efb9fc33 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iac4f9c2178cd0aa2621cde1290109af5a9a74f8f Reviewed-on: https://chromium-review.googlesource.com/c/1324471Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606217}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2969d2776054..36b85be49443 git log 2969d2776054..36b85be49443 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 kjlubick@google.com Revert "Autobuild the jsfiddle docker image" 2018-11-07 halcanary@google.com SkQP: SK_DO_NOT_REGISTER_NONGPU_UNIT_TESTS no longer uses __attribute_ 2018-11-07 mtklein@google.com Revert "simplify disabling effect deserialization" Created with: gclient setdep -r src/third_party/skia@36b85be49443 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I90a773d1f18931d1681dc658ae3c8dc32249805a Reviewed-on: https://chromium-review.googlesource.com/c/1324469Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606216}
-
Robert Ogden authored
This came up in review, but when the IPH bubble shows, it should highlight the anchor view. This CL does that with a simple call to ViewHighlighter Bug: 902817 Change-Id: I003e3d1ea0304badcf42ef922f82caf0d6e548b1 Reviewed-on: https://chromium-review.googlesource.com/c/1323618Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#606215}
-
David Tseng authored
1. do not map ignored role when a node has text. Much of Gmail appears to be marked as is important for accessibility == false. Unfortunately, this means most of the content in the mail message pane is actually hidden and skipped by ChromeVox. Revise our mapping rule so that it only applies the ignored role if there is no text (content description or text). 2. compute a node's name based on its descendants. We currently do this for nodes which are clickable. This covers Gmail's messages list. Each item in the messages list is exposed to Chrome as a "genericContainer" and has no name from the node itself. By computing name from contents at this layer, we avoid having each service do it. Test: manually. Change-Id: I4f53b022c066cb9a6796ac3a0645c47e7d05bddc Reviewed-on: https://chromium-review.googlesource.com/c/1318356 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#606214}
-
siyua authored
1. Modify autofill_client files and local_card_migration_manager to wire up files in CL 1300473 2. Changed method name to ShowOfferDialog to match the ShowFeedbackDialog. Bug: 897998 Change-Id: I6490ab18e1e822da13d550b0fb7d30d3fcebdec6 Reviewed-on: https://chromium-review.googlesource.com/c/1307074Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#606213}
-
Becky Zhou authored
Bug: 902427 Change-Id: Ida893cf41478976f4d3784091a79385db69ef1f0 Reviewed-on: https://chromium-review.googlesource.com/c/1324450Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#606212}
-
Tatiana Buldina authored
Bug: chromedriver:2653 Change-Id: I761a26f640d642e71f40cdc26b4959eea29e0259 Reviewed-on: https://chromium-review.googlesource.com/c/1324830Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#606211}
-
Antoine Labour authored
Bug: 882513, 897214 Change-Id: I3d7dc804db292b7a9844eda856195b7b7b1450d3 Reviewed-on: https://chromium-review.googlesource.com/c/1316347 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#606210}
-
Tibor Goldschwendt authored
Bug: 889985 Change-Id: If65ba8da760c0d9c0e79e71c8a2d2b6f240c5e9d Reviewed-on: https://chromium-review.googlesource.com/c/1319849 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#606209}
-
Wenzhao Zang authored
1. It's not easy to capture the "proceeded to logout" state because the logout is not initiated by Chrome. Also, it can't guarantee to be captured every time? Instead, we could record "shown" and "canceled", and in the comments emphasize that "show and proceeded" should be calculated by subtracting the two. 2. In |IdleActionWarningObserver::IdleActionImminent|, there's a check for if |warning_dialog_| already exists. I think this is a check for a rare case that the policy is updated while the dialog is showing. We should not record UMA in this case. Bug: 900263 Change-Id: Ied2f4b03252933e9ced3c792655e981b38105039 Reviewed-on: https://chromium-review.googlesource.com/c/1313118Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#606208}
-
Tommy Steimel authored
This CL adds a feature flag to toggle hardware key handling. This is currently unused and disabled by default. Bug: 902792 Change-Id: Ic1dfd70a81f6aa7abb8fd79b504b0d3bd05843e3 Reviewed-on: https://chromium-review.googlesource.com/c/1323798Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606207}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/273fe31d..b90faf57 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I009b8b395445986d46cb7f560bd6566490e3d829 Reviewed-on: https://chromium-review.googlesource.com/c/1323617Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606206}
-
Chris Morin authored
Workaround for patchoat intermittently taking much longer than normal to complete on startup. This will be reverted once issue is root caused and fixed. Bug: 117832337 Test: Add a sleep 30 before patchoat and ensure container starts Change-Id: I3c66110dff876b8aa61fa4fb12c658038db978a3 Reviewed-on: https://chromium-review.googlesource.com/c/1322352 Commit-Queue: Christopher Morin <cmtm@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#606205}
-
Jian Li authored
Bug: 898834 Change-Id: I1194e4805e4504f4be120a1f89bdd99cb6bc34e7 Reviewed-on: https://chromium-review.googlesource.com/c/1324421Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#606204}
-
Yue Cen authored
This is required after the change in https://chromium-review.googlesource.com/c/1297172 Bug: 900793 Change-Id: I6f21fefc9d24f7209e7cfc8569c009c27a90c236 Reviewed-on: https://chromium-review.googlesource.com/c/1315968Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Yue Cen <rsgingerrs@chromium.org> Cr-Commit-Position: refs/heads/master@{#606203}
-
John Budorick authored
https://chromium.googlesource.com/catapult.git/+log/2e722b007d34..1a1b38dabca6 $ git log 2e722b007..1a1b38dab --date=short --no-merges --format='%ad %ae %s' 2018-11-06 bpastene devil: Add an option to reset USB devices when no HealthyDevices are found. Created with: roll-dep src/third_party/catapult Tbr: nednguyen@google.com,sullivan@chromium.org Bug: 892670 Change-Id: Ief672aa6656cd757ddc1b75657c4831af4f9e81f Reviewed-on: https://chromium-review.googlesource.com/c/1323905Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#606202}
-
Tony de Luna authored
It might take some seconds between users submit pin update and operation completes. In the meantime users shouldn't be able to modify the PIN input fields. Bug: 901290 Change-Id: I21aa06288d3f0aaf00db8dae72715a8a4e94d85d Reviewed-on: https://chromium-review.googlesource.com/c/1323903Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Cr-Commit-Position: refs/heads/master@{#606201}
-
Francois Doray authored
Previously, SetCurrentThreadPriority(BACKGROUND) did not affect CPU priority on Windows in a IDLE process when the "WindowsThreadModeBackground" feature was enabled. It only affected I/O and memory priorities. With this CL, a second call to ::SetThreadPriority() is made to ensure that CPU priority is affected. Bug: 901483 Change-Id: I22640c8fa56eeec489fbf0fe516359b828e39541 Reviewed-on: https://chromium-review.googlesource.com/c/1318438 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#606200}
-
dpapad authored
Test steps: 1) Build Android Chrome once ninja -C out/gchrome/ chrome_public_apk 2) Touch a WebUI target that was previously unnecessarily included as a dependency, for example: touch chrome/browser/resources/md_history/app.js 3) Build Android Chrome again. There should be nothing to do. Bug: 901261 Change-Id: If81312b54bc785bc4faced24d3f516b029fd1d86 Reviewed-on: https://chromium-review.googlesource.com/c/1324195Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#606199}
-